30593 Commits

Author SHA1 Message Date
Gray Mackall
8cce730f9b Fix name in description of 'create_cipd_packages.sh' (flutter/engine#44513)
The description uses an old name.

This PR also partly exists to spread awareness that this script exists, for whenever we need to upload [android versions to CIPD](https://chrome-infra-packages.appspot.com/p/flutter/android/sdk/all/mac-arm64/+/).

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-08-08 21:49:48 +00:00
gaaclarke
025925411e [Impeller] started std::moving Commands instead of copying (flutter/engine#44508)
Each Command is 440 B so copying them when adding them to the RenderPass adds up.  This change represents a 36% speedup in `TextContents::Render` when scrolling around on the main screen of the of the Flutter Gallery.

issue: https://github.com/flutter/flutter/issues/131787

## before
<img width="1217" alt="Screenshot 2023-08-08 at 1 11 30 PM" src="https://github.com/flutter/engine/assets/30870216/3545f9cd-b596-4a7c-bcf0-a20c7f7c40e8">

## after

<img width="1048" alt="Screenshot 2023-08-08 at 1 10 05 PM" src="https://github.com/flutter/engine/assets/30870216/3443ec70-5d4f-4022-b3e7-41b13c25cb00">

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-08-08 21:27:49 +00:00
skia-flutter-autoroll
a31c651ebb Roll Skia from 9fa8ebdfdbb8 to 68b80f663be6 (1 revision) (flutter/engine#44511)
https://skia.googlesource.com/skia.git/+log/9fa8ebdfdbb8..68b80f663be6

2023-08-08 nicolettep@google.com Add some nullchecks to GrTriangulator

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-08 21:21:36 +00:00
LongCatIsLooong
bd6dcc68c9 Disable HTML renderer paragraph input width flooring (flutter/engine#44478)
Hopefully the flooring will no longer be needed once the framework stops doing the rounding.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-08-08 21:07:53 +00:00
skia-flutter-autoroll
8be9a371ad Roll Skia from 5c8c7faf9131 to 9fa8ebdfdbb8 (2 revisions) (flutter/engine#44507)
https://skia.googlesource.com/skia.git/+log/5c8c7faf9131..9fa8ebdfdbb8

2023-08-08 lovisolo@google.com CommandLineFlags::StringArray: Add method parseAndValidate().
2023-08-08 kjlubick@google.com Partial revert of "Remove SK_GL #ifdefs from GrBackendSurface"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-08 20:12:19 +00:00
skia-flutter-autoroll
f3b3e417fe Roll Skia from 6fa6fdd04783 to 5c8c7faf9131 (3 revisions) (flutter/engine#44506)
https://skia.googlesource.com/skia.git/+log/6fa6fdd04783..5c8c7faf9131

2023-08-08 herb@google.com Bentley-Ottmann EventQueue
2023-08-08 thakis@chromium.org Fix an unreachable code diag
2023-08-08 lovisolo@google.com [bazel] Add serve-bazel-test-undeclared-outputs.sh utility script.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-08 19:24:21 +00:00
Matt2D
d669ddd4f4 Flutter iOS Interactive Keyboard: Handle Pointer Up (flutter/engine#44457)
This PR address the movement aspect of the flutter interactive keyboard. It handles pointer up while a scroll view widget is visible, and the interactive behavior is chosen for keyboardDismissBehavior. This is a desired behavior of the keyboard that has not yet been implemented.
Design Document:
https://docs.google.com/document/d/1-T7_0mSkXzPaWxveeypIzzzAdyo-EEuP5V84161foL4/edit?pli=1

Issues Address:
https://github.com/flutter/flutter/issues/57609

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-08-08 19:09:44 +00:00
gaaclarke
77941b98d5 [Impeller] improved glyph hashing performance (flutter/engine#44502)
This change makes the glyph hash 39% faster (66ms vs 107ms).  The glyph hash function occupies the most CPU time on the raster thread when scrolling around the main screen for the Flutter Gallery

## before

<img width="1101" alt="Screenshot 2023-08-08 at 10 53 06 AM" src="https://github.com/flutter/engine/assets/30870216/2332323e-80cd-4f39-9ec1-95cb5662be7b">

## after
<img width="1097" alt="Screenshot 2023-08-08 at 10 52 51 AM" src="https://github.com/flutter/engine/assets/30870216/13bbc07b-7f56-40e8-ada5-32de77ddf614">

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-08-08 18:44:21 +00:00
skia-flutter-autoroll
c5159af2df Roll Skia from 30c0319e7e42 to 6fa6fdd04783 (2 revisions) (flutter/engine#44503)
https://skia.googlesource.com/skia.git/+log/30c0319e7e42..6fa6fdd04783

2023-08-08 kjlubick@google.com Move StrokeForGPUTest to ganesh test list
2023-08-08 bungeman@google.com [skunicode] Add temporary file for transition

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-08 18:38:37 +00:00
Caroline Liu
e493b1011e Remove GFX branches from Flutter engine (flutter/engine#44401)
This change does the following:
- Refactors `engine.cc`/`.h` and `component_v2.cc`/`.h` to remove GFX ctors and callbacks.
- Removes `gfx_external_view_embedder`, `gfx_platform_view`, `gfx_session_connection`, their tests, and any supporting testing infrastructure (e.g. `fake_session`) from the build. This change does not delete the source files themselves in order to keep the change size smaller (as all these file deletions together are about another ~8K lines worth of deletions.) A separate follow up change will delete these files.

Related bug: fxbug.dev/64206
2023-08-08 18:20:09 +00:00
Jason Simmons
2ae4942db0 Use the Clang unreachable code warning flag in the engine tree (flutter/engine#44458) 2023-08-08 17:40:03 +00:00
skia-flutter-autoroll
0e5a9ddf5f Roll Skia from 66ba512c613c to 30c0319e7e42 (3 revisions) (flutter/engine#44500)
https://skia.googlesource.com/skia.git/+log/66ba512c613c..30c0319e7e42

2023-08-08 johnstiles@google.com Remove unused 'virtual' in GLSLCodeGenerator.
2023-08-08 johnstiles@google.com Reject sequence-expressions containing arrays.
2023-08-08 kjlubick@google.com Add Fontations Jobs

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-08 16:57:21 +00:00
Chris Bracken
e43adf1acd [macOS] Fix engine/binaryMessenger retain cycle (flutter/engine#44471)
Previously, FlutterEngine.binaryMessenger returned the FlutterEngine
instance itself, which meant that channels/plugins could hold a strong
reference to the engine and thus cause a retain cycle, preventing the
engine from being deallocated.

We introduce FlutterBinaryMessengerRelay, which implements the
FlutterBinaryMessenger protocol, by delegating back to the engine, to
which it holds a weak reference, thus avoiding the retain cycle.

This also changes the FlutterBinaryMessengerRelay.parent property from
an assign property to a weak property since that code is compiled with
ARC enabled as of https://github.com/flutter/engine/pull/44395.

This patch also rearranges the headers to comply with our style guide:
related headers for this file, C headers, C++ headers, other Flutter
headers, in that order.

Fixes: https://github.com/flutter/flutter/issues/116445
2023-08-08 09:26:28 -07:00
skia-flutter-autoroll
875ee57aa1 Roll Skia from f7162d33afb2 to 66ba512c613c (8 revisions) (flutter/engine#44497)
https://skia.googlesource.com/skia.git/+log/f7162d33afb2..66ba512c613c

2023-08-08 kjlubick@google.com Move SkChromeRemoteGlyphCache.cpp to src/text/gpu
2023-08-08 johnstiles@google.com Revert "Use pointers to avoid static variable destruction."
2023-08-08 kjlubick@google.com Skip deleted test file
2023-08-08 kjlubick@google.com Add missing file to public.bzl
2023-08-08 johnstiles@google.com Disable MatrixScalarMath test on Mac ANGLE.
2023-08-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from c46d48f777b7 to cc5d2913cf83 (3 revisions)
2023-08-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 135a24fc3706 to f7d7be8d2ff0 (13 revisions)
2023-08-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 0e52994bf1b6 to 333a87d1ef8a (6 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-08 16:13:18 +00:00
Mouad Debbar
2b761a04f7 [web] Expose the benchmark callback through dart:ui_web (flutter/engine#44461)
Required by https://github.com/flutter/flutter/pull/132087
Part of https://github.com/flutter/flutter/issues/130175
Part of https://github.com/flutter/flutter/issues/126831
2023-08-08 16:09:14 +00:00
Zachary Anderson
90ee3f407f Excludes entity_pass.cc from clang-tidy due to timeouts (flutter/engine#44495)
For https://github.com/flutter/flutter/issues/132129
2023-08-08 15:33:48 +00:00
skia-flutter-autoroll
2bd0199443 Roll Fuchsia Linux SDK from 0Jd9VPJCX145RGnqr... to 9Pl8nd13UI8rrS3JD... (flutter/engine#44494)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-08 15:23:46 +00:00
skia-flutter-autoroll
39f6766acf Roll Fuchsia Mac SDK from r0vBgWqKSvQ6zzFam... to c18Y3Ga7cvdrmy8FQ... (flutter/engine#44492)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-08 14:37:06 +00:00
skia-flutter-autoroll
93e46fe40e Roll Skia from b4a893827b2a to f7162d33afb2 (1 revision) (flutter/engine#44479)
https://skia.googlesource.com/skia.git/+log/b4a893827b2a..f7162d33afb2

2023-08-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 89658e42bb91 to 333a87d1ef8a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-08 04:39:19 +00:00
Jason Simmons
0413e2710d Revert "[Impeller] DlCanvas implementation wrapping Aiks canvas" (flutter/engine#44466)
This reverts commit 1785eb5cb8cba53da249614158065d1d53f8f863.

See https://github.com/flutter/flutter/issues/132071
2023-08-07 23:59:47 +00:00
skia-flutter-autoroll
4417cf19fd Roll Skia from 5dd88a48f7e2 to b4a893827b2a (3 revisions) (flutter/engine#44470)
https://skia.googlesource.com/skia.git/+log/5dd88a48f7e2..b4a893827b2a

2023-08-07 brianosman@google.com Only skip (BitmapProcState) Init_hsw when building for AVX2+
2023-08-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 33af718d939e to c46d48f777b7 (5 revisions)
2023-08-07 johnstiles@google.com Disable CommaExpressionsAllowInlining in WebGL2.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-07 23:18:53 +00:00
Mouad Debbar
dc0147d3d3 [web] Silence pub get when it's successful (flutter/engine#44445)
In the spirit of keeping the happy path's output as clean as possible, let's hide the many lines printed by `pub get` even when it's successful.

If `pub get` fails, its output will be printed on the terminal.
2023-08-07 22:38:03 +00:00
skia-flutter-autoroll
b165a0651a Roll Fuchsia Mac SDK from mlT1Bm0L9bVynvMFF... to r0vBgWqKSvQ6zzFam... (flutter/engine#44463)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-07 22:36:46 +00:00
skia-flutter-autoroll
b8bb3206ae Roll Skia from d1ada6624536 to 5dd88a48f7e2 (8 revisions) (flutter/engine#44465)
https://skia.googlesource.com/skia.git/+log/d1ada6624536..5dd88a48f7e2

2023-08-07 brianosman@google.com blit_row_color32 doesn't need to support separate src/dst pointers
2023-08-07 johnstiles@google.com Improve errors with ternary ops.
2023-08-07 lovisolo@google.com [bazel] //gm/gm.h: Add support for dynamically registered GMs.
2023-08-07 johnstiles@google.com Add WGSL polyfill for inverse intrinsic.
2023-08-07 brianosman@google.com Split out BlitMask opts into separate cpp files
2023-08-07 johnstiles@google.com Add WGSL support for matrix-op-scalar math.
2023-08-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll debugger-app-base from a8be3b12ad17 to be6bd0fc62ef
2023-08-07 drott@chromium.org [Fontations-backend] Build fontations-enabled viewer with GN

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-07 22:32:03 +00:00
skia-flutter-autoroll
ac5626b7b9 Roll Dart SDK from 0816d590a220 to f664f4b9c50d (1 revision) (flutter/engine#44462)
https://dart.googlesource.com/sdk.git/+log/0816d590a220..f664f4b9c50d

2023-08-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-42.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-07 22:30:11 +00:00
Brandon DeRosier
e8e4f8c118 [Impeller] Flutter GPU: Add GpuContext. (flutter/engine#44359)
Move the GpuContext to its new home. I added a `flutter_tester` test that just verifies an exception is gracefully thrown when Impeller isn't available.

In a later patch, I'll land a way to eagerly supply the Impeller context on the cpp side to enable testing through the playground (as mentioned in https://github.com/flutter/flutter/issues/127712).
2023-08-07 19:41:57 +00:00
ftsui
0cc053b836 Fix use-after-free crash in glfw embedder (flutter/engine#44358)
When setting up the paths to assets and ICU data, we were previously returning the underlying char* data in a temporary string returned by `std::filesystem::path::string()`. Since the return value of `string()` is never stored, there's no guarantee that the underlying data pointer is still valid later in the function. By storing the string in a local whose lifetime exceeds that of the running engine instance, we guarantee the string isn't freed until after the Flutter app terminates.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-08-07 19:11:24 +00:00
skia-flutter-autoroll
48ed458cbb Roll Skia from 9fbd7296de9a to d1ada6624536 (1 revision) (flutter/engine#44447)
https://skia.googlesource.com/skia.git/+log/9fbd7296de9a..d1ada6624536

2023-08-07 johnstiles@google.com Use explicit versioning with Python.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,jcgregorio@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-07 18:42:39 +00:00
Zachary Anderson
58abab271f Revert clang back to 6d667d4b261e81f325756fdfd5bb43b3b3d2451d (flutter/engine#44442)
b/294820516


https://stackoverflow.com/questions/76852785/how-to-fix-itms-90338-non-public-api-usage-issue-after-review
2023-08-07 11:30:07 -07:00
Yegor
fc753e1355 [web] remove leftover comments from semantics tester (flutter/engine#44350)
Remove commented out debug code from `expectSemanticsTree`.
2023-08-07 18:04:47 +00:00
skia-flutter-autoroll
357faa3756 Roll Skia from 77007f51bf81 to 9fbd7296de9a (4 revisions) (flutter/engine#44443)
https://skia.googlesource.com/skia.git/+log/77007f51bf81..9fbd7296de9a

2023-08-07 johnstiles@google.com Use pointers to avoid static variable destruction.
2023-08-07 brianosman@google.com Remove SkAutoGraphics
2023-08-07 brianosman@google.com Move Init_BitmapProcState call back to SkGraphics
2023-08-07 johnstiles@google.com Remove unused 'skia_enable_skvm' GN argument.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,jcgregorio@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-07 18:01:01 +00:00
skia-flutter-autoroll
1b46cf50e8 Roll Skia from f19578685d17 to 77007f51bf81 (1 revision) (flutter/engine#44440)
https://skia.googlesource.com/skia.git/+log/f19578685d17..77007f51bf81

2023-08-07 johnstiles@google.com Remove SK_ENABLE_SKSL_IN_RASTER_PIPELINE.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,jcgregorio@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-07 17:10:06 +00:00
skia-flutter-autoroll
6b26b6b0c9 Roll Skia from 359808ec2cb1 to f19578685d17 (1 revision) (flutter/engine#44439)
https://skia.googlesource.com/skia.git/+log/359808ec2cb1..f19578685d17

2023-08-07 brianosman@google.com Remove SkGraphics::AllowJIT completely

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,jcgregorio@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-07 16:04:52 +00:00
skia-flutter-autoroll
ebe68a8088 Roll Skia from e327eb094605 to 359808ec2cb1 (2 revisions) (flutter/engine#44438)
https://skia.googlesource.com/skia.git/+log/e327eb094605..359808ec2cb1

2023-08-07 johnstiles@google.com Remove ES3 flag from new comma-expression test.
2023-08-07 johnstiles@google.com Remove GL backend bit from Layout.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,jcgregorio@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-07 15:12:08 +00:00
Jason Simmons
75f91264d1 Do not log exceptions from JNI lookups of APIs that are known to be unavailable on older devices (flutter/engine#44357)
These exceptions are benign but were being logged every time an app is launched on a device with an Android API level below 26.
2023-08-07 14:35:05 +00:00
skia-flutter-autoroll
ddc56b227b Roll Skia from 7a98630e0de9 to e327eb094605 (2 revisions) (flutter/engine#44437)
https://skia.googlesource.com/skia.git/+log/7a98630e0de9..e327eb094605

2023-08-07 kjlubick@google.com Rename bazel build options to support Graphite expansion
2023-08-07 johnstiles@google.com Add inliner test for void-typed comma-expressions.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,jcgregorio@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-07 14:22:56 +00:00
skia-flutter-autoroll
18f22098ec Roll Skia from f4047f002891 to 7a98630e0de9 (1 revision) (flutter/engine#44436)
https://skia.googlesource.com/skia.git/+log/f4047f002891..7a98630e0de9

2023-08-07 johnstiles@google.com Add an EmptyExpression IR element to SkSL.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,jcgregorio@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-07 13:41:21 +00:00
skia-flutter-autoroll
ae38c1bfe8 Roll Fuchsia Linux SDK from zVfdIYcZ93Loob7VG... to 0Jd9VPJCX145RGnqr... (flutter/engine#44435)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-07 13:03:24 +00:00
skia-flutter-autoroll
ab52b7052c Roll Skia from 558d9754241d to f4047f002891 (1 revision) (flutter/engine#44433)
https://skia.googlesource.com/skia.git/+log/558d9754241d..f4047f002891

2023-08-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 99737cb7d8b5 to 33af718d939e (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,jcgregorio@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-07 09:43:29 +00:00
skia-flutter-autoroll
3203e3565b Roll Skia from b7a1f4fdedc1 to 558d9754241d (1 revision) (flutter/engine#44432)
https://skia.googlesource.com/skia.git/+log/b7a1f4fdedc1..558d9754241d

2023-08-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 95d88a5bb117 to 135a24fc3706 (6 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,jcgregorio@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-07 07:01:24 +00:00
skia-flutter-autoroll
9391a39fbc Roll Fuchsia Mac SDK from 9QyQ03F49oT_9slFF... to mlT1Bm0L9bVynvMFF... (flutter/engine#44431)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-07 06:29:21 +00:00
skia-flutter-autoroll
e35df5ab5f Roll Skia from 9c4cfcd16529 to b7a1f4fdedc1 (2 revisions) (flutter/engine#44430)
https://skia.googlesource.com/skia.git/+log/9c4cfcd16529..b7a1f4fdedc1

2023-08-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 0e52994bf1b6 to c8d53e7227c9
2023-08-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from ed824b45206d to 0e52994bf1b6 (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,jcgregorio@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-07 06:25:22 +00:00
skia-flutter-autoroll
47b59717bc Roll Fuchsia Linux SDK from fwCoUCWKEqZSJGPE8... to zVfdIYcZ93Loob7VG... (flutter/engine#44428)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-07 00:15:24 +00:00
skia-flutter-autoroll
a7a7ad6753 Roll Skia from 72264deb9f05 to 9c4cfcd16529 (1 revision) (flutter/engine#44427)
https://skia.googlesource.com/skia.git/+log/72264deb9f05..9c4cfcd16529

2023-08-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from d8553707088f to 99737cb7d8b5 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,jcgregorio@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-06 23:19:22 +00:00
skia-flutter-autoroll
8f10391455 Roll Fuchsia Mac SDK from iY3v8FawLUo9HvTeR... to 9QyQ03F49oT_9slFF... (flutter/engine#44425)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-06 17:53:21 +00:00
skia-flutter-autoroll
6899042d82 Roll Fuchsia Linux SDK from E0vw_CD-BaFAcSoH4... to fwCoUCWKEqZSJGPE8... (flutter/engine#44424)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-06 11:29:36 +00:00
skia-flutter-autoroll
8455b87494 Roll Skia from 1d390344bfca to 72264deb9f05 (1 revision) (flutter/engine#44423)
https://skia.googlesource.com/skia.git/+log/1d390344bfca..72264deb9f05

2023-08-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from cc90bbf81ed9 to d8553707088f (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,jcgregorio@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-06 08:09:14 +00:00
skia-flutter-autoroll
2048fb94e0 Roll Fuchsia Mac SDK from 4pA5pP6XaVIJBXuq0... to iY3v8FawLUo9HvTeR... (flutter/engine#44422)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-06 05:13:16 +00:00
skia-flutter-autoroll
7472fbf223 Roll Fuchsia Linux SDK from QazMbN_0ttbJpf36s... to E0vw_CD-BaFAcSoH4... (flutter/engine#44421)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-05 22:43:04 +00:00
skia-flutter-autoroll
77e44fa51d Roll Fuchsia Mac SDK from UpzOzWyiGYKrIuKmG... to 4pA5pP6XaVIJBXuq0... (flutter/engine#44420)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-05 16:34:20 +00:00