Ellet
8bf614f181
Update reorderable_list.dart to use Dart 3 return switch statement for consistency ( #147505 )
...
*Update `reorderable_list.dart` from `widgets` to use Dart 3 return switch statement syntax for consistency.*
This just a syntax change to match the rest of the functions in this file
2024-05-01 16:03:08 +00:00
Kostia Sokolovskyi
d33bb8fa5e
Add tests for single_activator.0.dart API example. ( #147426 )
...
This PR contributes to https://github.com/flutter/flutter/issues/130459
### Description
- Fixes name of the `examples/api/lib/widgets/shortcuts/single_activator.single_activator.0.dart`
- Adds tests for `examples/api/lib/widgets/shortcuts/single_activator.0.dart`
2024-05-01 14:52:57 +00:00
Kishan Dhankecha
2867ac7885
Added missing code block language in docs ( #147481 )
...
- added language for all code blocks
- replaced `bash` or `shell` with `sh` for consistency.
- added `sh` and `console` in the GitHub template link generator.
- updated test for GitHub template.
2024-05-01 14:44:27 +00:00
Zachary Anderson
cb2197e9b3
Move docs_test and docs_publish to bringup ( #147645 )
...
For https://github.com/flutter/flutter/issues/147609 to unblock the
tree.
@gspencergoog @jason-simmons
2024-05-01 07:41:55 -07:00
auto-submit[bot]
abbaaea8a1
Reverts "Fix memory leak in TabPageSelector ( #147403 )" ( #147622 )
...
Reverts: flutter/flutter#147403
Initiated by: chingjun
Reason for reverting: Causing an internal test to fail, see b/338159496 for details
Original PR Author: ValentinVignal
Reviewed By: {polina-c}
This change reverts the following previous change:
Part of https://github.com/flutter/flutter/issues/141198
2024-05-01 05:32:19 +00:00
chunhtai
3e399c1578
Revert "add a new PopScope.onPopWithResultInvoke widget to replace Po… ( #147597 )
...
…pScope.onPopInvoke (#147016 )"
This reverts commit 8031a3e30cf4adc13bedea0aa44c05a1cf8aa852.
Needs to migrate flutter_eval
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
[Data Driven Fixes]:
https://github.com/flutter/flutter/wiki/Data-driven-Fixes
2024-04-30 13:25:24 -07:00
Andrew Kolos
ce822ec8bb
include exception details in tool exit displayed when adb call fails ( #147498 )
...
Fixes #125971
2024-04-30 17:38:21 +00:00
Valentin Vignal
af270935bb
Fix memory leak in TabPageSelector ( #147403 )
2024-04-30 10:35:22 -07:00
engine-flutter-autoroll
b597dd24cb
Roll Flutter Engine from 2c1517bbf555 to 0ce67714ce4c (1 revision) ( #147585 )
...
2c1517bbf5...0ce67714ceskia-flutter-autoroll@skia.org Roll Skia from 459555f490bf to 8f2d039e1190 (1 revision) (flutter/engine#52458 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-30 17:26:16 +00:00
engine-flutter-autoroll
456f0101fd
Roll Packages from 87a7c51cc633 to cc47b06b438d (5 revisions) ( #147580 )
...
87a7c51cc6...cc47b06b43joonas.kerttula@codemate.com [google_maps_flutter_web] Add marker clustering support (flutter/packages#6187 )
2024-04-30 joonas.kerttula@codemate.com [google_maps_flutter_android] Add marker clustering support (flutter/packages#6185 )
2024-04-29 32538273+ValentinVignal@users.noreply.github.com [go_router] Don't log if `hierarchicalLoggingEnabled` is `true` (flutter/packages#6019 )
2024-04-29 43054281+camsim99@users.noreply.github.com [file_selector_android] Update `LICENSE` file to include newly added licensed code (flutter/packages#6626 )
2024-04-29 43054281+camsim99@users.noreply.github.com [file_selector_android] Modifies `getDirectoryPath`, `openFile`, `openFiles` to return file/directory paths instead of URIs (flutter/packages#6438 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-30 16:04:09 +00:00
engine-flutter-autoroll
d840390f61
Roll Flutter Engine from 1a6ef9957b24 to 2c1517bbf555 (1 revision) ( #147579 )
...
1a6ef9957b...2c1517bbf5skia-flutter-autoroll@skia.org Roll Dart SDK from 4144af4e4704 to 7a517de88964 (1 revision) (flutter/engine#52456 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-30 15:48:05 +00:00
engine-flutter-autoroll
12ad41ca9e
Roll Flutter Engine from 64877c08661d to 1a6ef9957b24 (1 revision) ( #147576 )
...
64877c0866...1a6ef9957bskia-flutter-autoroll@skia.org Roll Skia from b20651c1aad4 to 459555f490bf (1 revision) (flutter/engine#52455 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-30 13:52:24 +00:00
engine-flutter-autoroll
3d9d3ea12b
Roll Flutter Engine from 1d62704cb3d2 to 64877c08661d (1 revision) ( #147567 )
...
1d62704cb3...64877c0866skia-flutter-autoroll@skia.org Roll Skia from 0b22a72dffeb to b20651c1aad4 (3 revisions) (flutter/engine#52454 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-30 09:22:41 +00:00
engine-flutter-autoroll
3b1d9b5e98
Roll Flutter Engine from aace42365fc7 to 1d62704cb3d2 (2 revisions) ( #147566 )
...
aace42365f...1d62704cb3flutter/engine#52453 )
2024-04-30 skia-flutter-autoroll@skia.org Roll Skia from e9d3faf63fce to 0b22a72dffeb (1 revision) (flutter/engine#52451 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-30 08:36:26 +00:00
engine-flutter-autoroll
abf796e9cb
Roll Flutter Engine from ea6343846c62 to aace42365fc7 (2 revisions) ( #147563 )
...
ea6343846c...aace42365fskia-flutter-autoroll@skia.org Roll Dart SDK from 9eb838fa00af to 4144af4e4704 (4 revisions) (flutter/engine#52450 )
2024-04-30 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from TFm2_qWC2xpkzk8QS... to HP2saK9sVOtKvpquC... (flutter/engine#52449 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from TFm2_qWC2xpk to HP2saK9sVOtK
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-30 07:35:32 +00:00
engine-flutter-autoroll
0c5f9c2c05
Roll Flutter Engine from c519e9dd182b to ea6343846c62 (1 revision) ( #147560 )
...
c519e9dd18...ea6343846cjohn@johnmccutchan.com Workaround HardwareRenderer breakage in Android 14 (flutter/engine#52370 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-30 06:53:35 +00:00
engine-flutter-autoroll
2da8633fca
Roll Flutter Engine from 27bb23221305 to c519e9dd182b (1 revision) ( #147557 )
...
27bb232213...c519e9dd18skia-flutter-autoroll@skia.org Roll Skia from 29a483abf358 to e9d3faf63fce (1 revision) (flutter/engine#52444 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-30 02:19:22 +00:00
engine-flutter-autoroll
3b2bfc740f
Roll Flutter Engine from 93ccb9ab2cda to 27bb23221305 (2 revisions) ( #147556 )
...
93ccb9ab2c...27bb232213zanderso@users.noreply.github.com Add commands to rbe.md (flutter/engine#52442 )
2024-04-29 chinmaygarde@google.com Add a host_debug_unopt_arm64 macOS configuration. (flutter/engine#52443 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-30 01:16:11 +00:00
engine-flutter-autoroll
4ef2bb96e2
Roll Flutter Engine from c093562677fa to 93ccb9ab2cda (1 revision) ( #147553 )
...
c093562677...93ccb9ab2cskia-flutter-autoroll@skia.org Roll Skia from 9ffb18cccf2a to 29a483abf358 (2 revisions) (flutter/engine#52441 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-30 00:28:34 +00:00
Elliott Brooks
c1c7898b96
Bump dependencies in Flutter ( #147546 )
2024-04-29 15:53:25 -07:00
Amir Panahandeh
b176bce22b
Add configurable hitTestBehavior to Scrollable ( #146403 )
...
This PR adds `hitTestBehavior` to Scrollable as a configurable member.
- https://github.com/flutter/flutter/issues/146401
2024-04-29 22:46:06 +00:00
Taha Tesser
7ff31a4f7a
Fix wide DatePicker input mode button padding for Material 3 ( #147236 )
...
fixes [Wide `DatePickerDialog` "Switch to input" button has no margin from dialog side](https://github.com/flutter/flutter/issues/141338 )
### Description
Currently, there is no material design token for the input mode button padding. This PR fixes the padding by taking date picker side padding values into account.
### Code sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() {
runApp(const MyApp());
}
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
home: Scaffold(
body: Center(
child: Builder(builder: (BuildContext context) {
return ElevatedButton(
onPressed: () {
showDatePicker(
context: context,
initialDate: DateTime.now(),
firstDate: DateTime.utc(2010),
lastDate: DateTime.utc(2030),
);
},
child: const Text('Show Date Picker'),
);
}),
),
),
);
}
}
```
</details>
### Before
### After
2024-04-29 22:14:01 +00:00
engine-flutter-autoroll
d5baa33b0d
Roll Flutter Engine from 13c7ac9376a5 to c093562677fa (1 revision) ( #147547 )
...
13c7ac9376...c093562677skia-flutter-autoroll@skia.org Roll Skia from 953589c71b4a to 9ffb18cccf2a (4 revisions) (flutter/engine#52438 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-29 22:08:52 +00:00
engine-flutter-autoroll
28b81dc575
Roll Flutter Engine from 5165c711771c to 13c7ac9376a5 (1 revision) ( #147542 )
...
5165c71177...13c7ac9376skia-flutter-autoroll@skia.org Roll Skia from f7bfa8eef5b5 to 953589c71b4a (6 revisions) (flutter/engine#52437 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-29 20:25:20 +00:00
engine-flutter-autoroll
a53e89aad8
Roll Packages from dd01140f470e to 87a7c51cc633 (2 revisions) ( #147539 )
...
dd01140f47...87a7c51cc6engine-flutter-autoroll@skia.org Roll Flutter from f9933b6994e4 to db8c475cac11 (3 revisions) (flutter/packages#6622 )
2024-04-27 engine-flutter-autoroll@skia.org Roll Flutter from 2e806700b928 to f9933b6994e4 (17 revisions) (flutter/packages#6620 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-29 19:17:10 +00:00
engine-flutter-autoroll
07db2c4d55
Roll Flutter Engine from 399837d38807 to 5165c711771c (2 revisions) ( #147537 )
...
399837d388...5165c71177zanderso@users.noreply.github.com Remove references to goma (flutter/engine#52411 )
2024-04-29 kjlubick@users.noreply.github.com Make SkUnicode explicitly instead of relying on SkParagraph to make it for us (flutter/engine#52086 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-29 19:05:37 +00:00
zhengzeqin
aabe53ca36
[Fix]: showDateRangePicker with "large" helpText cutoffs the save button ( #146049 )
...
Fix https://github.com/flutter/flutter/issues/146039
Pre-launch Checklist
2024-04-29 18:18:06 +00:00
engine-flutter-autoroll
7719f87055
Roll Flutter Engine from 752b146df767 to 399837d38807 (10 revisions) ( #147532 )
...
752b146df7...399837d388skia-flutter-autoroll@skia.org Roll Skia from 27e872349963 to f7bfa8eef5b5 (1 revision) (flutter/engine#52436 )
2024-04-29 jonahwilliams@google.com [Impeller] fix GLES image upload. (flutter/engine#52430 )
2024-04-29 skia-flutter-autoroll@skia.org Roll Skia from aeab79038011 to 27e872349963 (1 revision) (flutter/engine#52435 )
2024-04-29 skia-flutter-autoroll@skia.org Roll Skia from c720e2446926 to aeab79038011 (1 revision) (flutter/engine#52434 )
2024-04-29 skia-flutter-autoroll@skia.org Roll Skia from 1a5436d50954 to c720e2446926 (1 revision) (flutter/engine#52433 )
2024-04-29 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from bIUvi3y4gRFxMSKV3... to TFm2_qWC2xpkzk8QS... (flutter/engine#52432 )
2024-04-29 skia-flutter-autoroll@skia.org Roll Skia from e3dfcd1b25af to 1a5436d50954 (1 revision) (flutter/engine#52431 )
2024-04-28 robert.ancell@canonical.com Use a AT-SPI socket/plug to export the Flutter accessibility state. (flutter/engine#52355 )
2024-04-28 jonahwilliams@google.com [Impeller] remove image upload from IO thread, limit concurrent worker threads. (flutter/engine#52423 )
2024-04-28 jonahwilliams@google.com [Impeller] when creating new pipeline variant block on current thread, re-persist dirty pipeline cache. (flutter/engine#52375 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from bIUvi3y4gRFx to TFm2_qWC2xpk
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-29 17:30:33 +00:00
Taha Tesser
257df5ebfc
Add ability to disable FloatingActionButton scale and rotation animations using FloatingActionButtonAnimator.noAnimation ( #146126 )
...
fixes [[Proposal] Allow disabling the scaling animation of the FloatingActionButton](https://github.com/flutter/flutter/issues/145585 )
### Using default `FloatingActionButton` animations
### Using `FloatingActionButtonAnimator.noAnimation`
2024-04-29 08:26:19 +00:00
auto-submit[bot]
098e7e7ff3
Reverts "Roll Flutter Engine from 752b146df767 to f4c20e97e6aa (2 revisions) ( #147495 )" ( #147502 )
...
Reverts: flutter/flutter#147495
Initiated by: zanderso
Reason for reverting: Crash in framework CI https://ci.chromium.org/ui/p/flutter/builders/prod/Linux_pixel_7pro%20new_gallery_opengles_impeller__transition_perf/2417/overview
Original PR Author: engine-flutter-autoroll
Reviewed By: {fluttergithubbot}
This change reverts the following previous change:
752b146df7...f4c20e97e6jonahwilliams@google.com [Impeller] remove image upload from IO thread, limit concurrent worker threads. (flutter/engine#52423 )
2024-04-28 jonahwilliams@google.com [Impeller] when creating new pipeline variant block on current thread, re-persist dirty pipeline cache. (flutter/engine#52375 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-29 01:25:19 +00:00
engine-flutter-autoroll
23e080ed9f
Roll Flutter Engine from 752b146df767 to f4c20e97e6aa (2 revisions) ( #147495 )
...
752b146df7...f4c20e97e6jonahwilliams@google.com [Impeller] remove image upload from IO thread, limit concurrent worker threads. (flutter/engine#52423 )
2024-04-28 jonahwilliams@google.com [Impeller] when creating new pipeline variant block on current thread, re-persist dirty pipeline cache. (flutter/engine#52375 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-28 20:52:24 +00:00
engine-flutter-autoroll
db8c475cac
Roll Flutter Engine from 5c6d4ffb66bd to 752b146df767 (2 revisions) ( #147487 )
...
5c6d4ffb66...752b146df7skia-flutter-autoroll@skia.org Roll Skia from 362737e0d9ad to e3dfcd1b25af (2 revisions) (flutter/engine#52429 )
2024-04-28 skia-flutter-autoroll@skia.org Roll Dart SDK from 7173b4dd0163 to 9eb838fa00af (3 revisions) (flutter/engine#52428 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-28 09:09:25 +00:00
engine-flutter-autoroll
8e9f9c4d22
Roll Flutter Engine from 20fb62ba1455 to 5c6d4ffb66bd (2 revisions) ( #147480 )
...
20fb62ba14...5c6d4ffb66skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from SVcynyah0BO4d5mRM... to bIUvi3y4gRFxMSKV3... (flutter/engine#52427 )
2024-04-28 jason-simmons@users.noreply.github.com Manual Dart roll to 7173b4dd0163 (flutter/engine#52425 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from SVcynyah0BO4 to bIUvi3y4gRFx
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-28 04:54:11 +00:00
Dimil Kalathiya
1189d44240
Fix _RenderValueIndicator leak ( #147451 )
2024-04-27 17:30:58 -07:00
engine-flutter-autoroll
f9933b6994
Roll Flutter Engine from 5205e3683a0a to 20fb62ba1455 (1 revision) ( #147449 )
...
5205e3683a...20fb62ba14skia-flutter-autoroll@skia.org Roll Skia from 7e92a0458e21 to 362737e0d9ad (1 revision) (flutter/engine#52417 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-27 05:41:24 +00:00
engine-flutter-autoroll
b10e725740
Roll Flutter Engine from e14649ea0c80 to 5205e3683a0a (1 revision) ( #147448 )
...
e14649ea0c...5205e3683askia-flutter-autoroll@skia.org Roll Skia from a819e9fa3016 to 7e92a0458e21 (2 revisions) (flutter/engine#52415 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-27 04:41:33 +00:00
engine-flutter-autoroll
f6f8c48f11
Roll Flutter Engine from 87f489c1bed4 to e14649ea0c80 (1 revision) ( #147446 )
...
87f489c1be...e14649ea0cskia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Rc4K-_-ym7vwUzXyo... to SVcynyah0BO4d5mRM... (flutter/engine#52413 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from Rc4K-_-ym7vw to SVcynyah0BO4
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-27 03:48:31 +00:00
engine-flutter-autoroll
d3cb68eaa2
Roll Flutter Engine from cecf5aa8a778 to 87f489c1bed4 (1 revision) ( #147445 )
...
cecf5aa8a7...87f489c1beskia-flutter-autoroll@skia.org Roll Skia from 3401ef9641cc to a819e9fa3016 (17 revisions) (flutter/engine#52412 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-27 02:29:38 +00:00
engine-flutter-autoroll
7d140561d4
Roll Flutter Engine from 8af10eba3ef3 to cecf5aa8a778 (1 revision) ( #147444 )
...
8af10eba3e...cecf5aa8a7dkwingsmt@users.noreply.github.com Move `PointerDataPacketConverter` from `PlatformView` to `RuntimeController` (flutter/engine#51952 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-27 01:43:12 +00:00
Chris Bracken
22a57531e6
[macOS] Eliminate flutter_gallery_macos__start_up benchmark ( #147442 )
...
The macOS devicelab machines are not physically configured for benchmarking at a 60 Hz refresh rate. With Flutter vsync wired up via CVDisplayLink (rather than a hardcoded 60 Hz rate as previously), the bot shows 0 monitors configured and syncs at 30 Hz. This is not a meaningful target to measure against but consumes devicelab CPU cycles.
Given that there is currently no plan in place to acquire and configure a consistent pool of physical benchmarking desktop machines, disabling this test to reduce load on the bots.
See https://github.com/flutter/engine/pull/51210 for a discussion of the decision to move forward with wiring up vsync from macOS and ignore this benchmark.
For future archaeologists, I don't think it's worth removing all the plumbing in the Dart code (in [dev/devicelab/lib/tasks/perf_tests.dart](9d47055640/dev/devicelab/lib/tasks/perf_tests.dart (L963)
2024-04-27 01:25:17 +00:00
engine-flutter-autoroll
ba1bdcde7f
Roll Flutter Engine from bc055398f42a to 8af10eba3ef3 (1 revision) ( #147441 )
...
bc055398f4...8af10eba3eskia-flutter-autoroll@skia.org Manual roll Dart SDK from 9936bafe5eb1 to 919c7cab870b (1 revision) (flutter/engine#52409 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-27 01:04:19 +00:00
engine-flutter-autoroll
9d47055640
Roll Flutter Engine from c410180e5bba to bc055398f42a (7 revisions) ( #147440 )
...
c410180e5b...bc055398f4skia-flutter-autoroll@skia.org Roll Dart SDK from 9936bafe5eb1 to 919c7cab870b (1 revision) (flutter/engine#52407 )
2024-04-26 gabeschine@users.noreply.github.com Delete errant back-tick in CONTRIBUTING.md (flutter/engine#52324 )
2024-04-26 dustingreen@google.com [fuchsia] route fuchsia.sysmem2.Allocator (flutter/engine#52187 )
2024-04-26 jonahwilliams@google.com [Impeller] clamp maximum glyph scale. (flutter/engine#52403 )
2024-04-26 zanderso@users.noreply.github.com Add markdown docs about RBE (flutter/engine#52394 )
2024-04-26 skia-flutter-autoroll@skia.org Roll Skia from 52083c205016 to 3401ef9641cc (5 revisions) (flutter/engine#52402 )
2024-04-26 jason-simmons@users.noreply.github.com Fix function type cast warnings for macOS embedder callbacks (flutter/engine#52377 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-27 00:05:17 +00:00
Kostia Sokolovskyi
9230b0e820
Add tests for character_activator.0.dart API example. ( #147384 )
...
This PR contributes to https://github.com/flutter/flutter/issues/130459
### Description
- Adds `examples/api/lib/widgets/shortcuts/character_activator.0.dart` test
- Fixes the description of the `examples/api/lib/widgets/shortcuts/character_activator.0.dart` example
2024-04-26 22:26:14 +00:00
dependabot[bot]
3488d9af80
Bump github/codeql-action from 3.25.2 to 3.25.3 ( #147437 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.25.2 to 3.25.3.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/github/codeql-action/blob/main/CHANGELOG.md ">github/codeql-action's changelog</a>.</em></p>
<blockquote>
<h1>CodeQL Action Changelog</h1>
<p>See the <a href="https://github.com/github/codeql-action/releases ">releases page</a> for the relevant changes to the CodeQL CLI and language packs.</p>
<p>Note that the only difference between <code>v2</code> and <code>v3</code> of the CodeQL Action is the node version they support, with <code>v3</code> running on node 20 while we continue to release <code>v2</code> to support running on node 16. For example <code>3.22.11</code> was the first <code>v3</code> release and is functionally identical to <code>2.22.11</code>. This approach ensures an easy way to track exactly which features are included in different versions, indicated by the minor and patch version numbers.</p>
<h2>[UNRELEASED]</h2>
<p>No user facing changes.</p>
<h2>3.25.3 - 25 Apr 2024</h2>
<ul>
<li>Update default CodeQL bundle version to 2.17.1. <a href="https://redirect.github.com/github/codeql-action/pull/2247 ">#2247</a></li>
<li>Workflows running on <code>macos-latest</code> using CodeQL CLI versions before v2.15.1 will need to either upgrade their CLI version to v2.15.1 or newer, or change the platform to an Intel MacOS runner, such as <code>macos-12</code>. ARM machines with SIP disabled, including the newest <code>macos-latest</code> image, are unsupported for CLI versions before 2.15.1. <a href="https://redirect.github.com/github/codeql-action/pull/2261 ">#2261</a></li>
</ul>
<h2>3.25.2 - 22 Apr 2024</h2>
<p>No user facing changes.</p>
<h2>3.25.1 - 17 Apr 2024</h2>
<ul>
<li>We are rolling out a feature in April/May 2024 that improves the reliability and performance of analyzing code when analyzing a compiled language with the <code>autobuild</code> <a href="https://docs.github.com/en/code-security/code-scanning/creating-an-advanced-setup-for-code-scanning/codeql-code-scanning-for-compiled-languages#codeql-build-modes ">build mode</a>. <a href="https://redirect.github.com/github/codeql-action/pull/2235 ">#2235</a></li>
<li>Fix a bug where the <code>init</code> Action would fail if <code>--overwrite</code> was specified in <code>CODEQL_ACTION_EXTRA_OPTIONS</code>. <a href="https://redirect.github.com/github/codeql-action/pull/2245 ">#2245</a></li>
</ul>
<h2>3.25.0 - 15 Apr 2024</h2>
<ul>
<li>
<p>The deprecated feature for extracting dependencies for a Python analysis has been removed. <a href="https://redirect.github.com/github/codeql-action/pull/2224 ">#2224</a></p>
<p>As a result, the following inputs and environment variables are now ignored:</p>
<ul>
<li>The <code>setup-python-dependencies</code> input to the <code>init</code> Action</li>
<li>The <code>CODEQL_ACTION_DISABLE_PYTHON_DEPENDENCY_INSTALLATION</code> environment variable</li>
</ul>
<p>We recommend removing any references to these from your workflows. For more information, see the release notes for CodeQL Action v3.23.0 and v2.23.0.</p>
</li>
<li>
<p>Automatically overwrite an existing database if found on the filesystem. <a href="https://redirect.github.com/github/codeql-action/pull/2229 ">#2229</a></p>
</li>
<li>
<p>Bump the minimum CodeQL bundle version to 2.12.6. <a href="https://redirect.github.com/github/codeql-action/pull/2232 ">#2232</a></p>
</li>
<li>
<p>A more relevant log message and a diagnostic are now emitted when the <code>file</code> program is not installed on a Linux runner, but is required for Go tracing to succeed. <a href="https://redirect.github.com/github/codeql-action/pull/2234 ">#2234</a></p>
</li>
</ul>
<h2>3.24.10 - 05 Apr 2024</h2>
<ul>
<li>Update default CodeQL bundle version to 2.17.0. <a href="https://redirect.github.com/github/codeql-action/pull/2219 ">#2219</a></li>
<li>Add a deprecation warning for customers using CodeQL version 2.12.5 and earlier. These versions of CodeQL were discontinued on 26 March 2024 alongside GitHub Enterprise Server 3.8, and will be unsupported by CodeQL Action versions 3.25.0 and later and versions 2.25.0 and later. <a href="https://redirect.github.com/github/codeql-action/pull/2220 ">#2220</a>
<ul>
<li>If you are using one of these versions, please update to CodeQL CLI version 2.12.6 or later. For instance, if you have specified a custom version of the CLI using the 'tools' input to the 'init' Action, you can remove this input to use the default version.</li>
<li>Alternatively, if you want to continue using a version of the CodeQL CLI between 2.11.6 and 2.12.5, you can replace <code>github/codeql-action/*@v3</code> by <code>github/codeql-action/*@v3.24.10</code> and <code>github/codeql-action/*@v2</code> by <code>github/codeql-action/*@v2.24.10</code> in your code scanning workflow to ensure you continue using this version of the CodeQL Action.</li>
</ul>
</li>
</ul>
<h2>3.24.9 - 22 Mar 2024</h2>
<ul>
<li>Update default CodeQL bundle version to 2.16.5. <a href="https://redirect.github.com/github/codeql-action/pull/2203 ">#2203</a></li>
</ul>
<h2>3.24.8 - 18 Mar 2024</h2>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="d39d31e687https://redirect.github.com/github/codeql-action/issues/2262 ">#2262</a> from github/update-v3.25.3-ac2f82a1f</li>
<li><a href="a7278252c71efa8597b1ac2f82a1ffhttps://redirect.github.com/github/codeql-action/issues/2261 ">#2261</a>)</li>
<li><a href="0ad7791640https://redirect.github.com/github/codeql-action/issues/2247 ">#2247</a> from github/update-bundle/codeql-bundle-v2.17.1</li>
<li><a href="79d9ee7f07dbf2b1706bhttps://redirect.github.com/github/codeql-action/issues/2255 ">#2255</a> from github/mergeback/v3.25.2-to-main-8f596b4a</li>
<li><a href="ff6a3c42a5619dc0c4b839e1e6509e8f596b4ae3...d39d31e687https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github/codeql-action&package-manager=github_actions&previous-version=3.25.2&new-version=3.25.3 )](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2024-04-26 22:26:11 +00:00
Andrew Kolos
290dadba35
Add integration test for asset transformation feature ( #145715 )
...
In service of https://github.com/flutter/flutter/issues/143348
This adds a simple integration test for the new asset transformation feature.
2024-04-26 21:42:06 +00:00
Kishan Dhankecha
e4ad15900a
Added missing tests for Table api example table.0.dart. ( #147318 )
...
Added missing tests for Table example. Issue #130459
2024-04-26 21:30:17 +00:00
Andrew Kolos
69e68f6e04
Catch any FileSystemException thrown when trying to read the template manifest during flutter create ( #145620 )
...
Fixes https://github.com/flutter/flutter/issues/145423
2024-04-26 21:24:25 +00:00
Dimil Kalathiya
cc9ac7d13c
fixes CupertinoFullscreenDialogTransition leaks ( #147168 )
2024-04-26 13:19:31 -07:00
Bruno Leroux
de411a5976
Fix helperMaxLines and errorMaxLines documentation ( #147409 )
...
## Description
This PR updates InputDecoration.helperMaxLines and InputDecoration.errorMaxLines comments.
Those comments have not been updated since they landed in https://github.com/flutter/flutter/pull/17292 , at that time they were probably correct but unfortunately there were no tests to catch the change of behavior. This PR adds those two missing tests.
## Tests
Adds 2 tests.
2024-04-26 18:25:17 +00:00
Greg Spencer
d274a2126f
Refactor route focus node creation ( #147390 )
...
## Description
This fixes an issue in the creation of the `FocusScope` in a route: the route should be creating the `FocusScope` widget it has with `withExternalFocusNode`, since it is modifying the node attributes in a builder.
Also modified some `AnimatedBuilder`s to be `ListenableBuilder`s, since they're not using animations (no functionality change there, since the implementation of the two is identical).
## Related Issues
- #147256
- Fixes #146844
## Tests
- Updated example test.
2024-04-26 17:17:19 +00:00
