Chris Bracken
8bb8a03fa9
iOS: update provisioning profile for 2024-2025 cert ( #155052 )
...
Tells our iOS bots to use the provisioning profile stored in the flutter_internal/mac/mobileprovision CIPD packages tagged `version:to_2025`.
This CIPD package contains an updated provisioning profile which supports both the current development signing certificate expiring in October 2024, and the updated signing cert expiring in August 2025.
Also removes the CIPD dependency for devicelab tasks. On devicelab bots, the cert and provisioning profile are deployed via Salt, not via CIPD. We only need this dependency on the Chromium bots.
CIPD packages can be seen at:
https://chrome-infra-packages.appspot.com/p/flutter_internal/mac/mobileprovision
Required for: https://g-issues.chromium.org/issues/366034566
Issue: https://github.com/flutter/flutter/issues/152888
2024-09-12 00:26:17 +00:00
Nate Wilson
360e42c7af
Factor out Container objects ( #153619 )
...
This pull request follows up on [a PR from 4 months ago](https://github.com/flutter/flutter/pull/147432 ) that aimed to reduce the number of `Container` objects in the framework.
I feel like now's a good time to wrap it up!
(especially since I've gained a grasp of how "rebase" vs. "merge commit" can [affect test results](https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#using-git ) ð)
<br>
resolves #147431
2024-09-11 23:59:53 +00:00
Matan Lurey
5d5e633c44
Move (dev/tools), complete v0 of native_driver (Android) ( #154843 )
...
**This is a WIP**, and the only reason it is not a draft PR is so that Flutter (Skia) Gold is executed.
---
Closes https://github.com/flutter/flutter/issues/148269 .
Work towards https://github.com/flutter/flutter/issues/148269 .
2024-09-11 23:56:21 +00:00
engine-flutter-autoroll
87ab4116ec
Roll Flutter Engine from ade8ef293bc6 to ee5adf6d2ee1 (2 revisions) ( #155046 )
...
ade8ef293b...ee5adf6d2emagder@google.com Zip and upload Xcode xcresults on scenario test failure (flutter/engine#55093 )
2024-09-11 jonahwilliams@google.com [Impeller] hash less text stuff per frame for text rendering. (flutter/engine#55060 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-11 23:56:18 +00:00
Loïc Sharma
ea208f824b
Fix flutter run on Mac x64 hosts if Swift Package Manager is enabled ( #154645 )
...
### Problem
Enabling the Swift Package Manager feature caused post-submit tests to fail on Mac x64 hosts:
<details>
<summary>Example error...</summary>
https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_ios%20rrect_blur_perf_ios__timeline_summary/575/overview
```
⦠... flutter --verbose assemble ... -dIosArchs=x86_64 ... profile_unpack_ios
Target profile_unpack_ios failed:
Exception: Binary ... build/ios/Profile-iphoneos/Flutter.framework/Flutter does not contain x86_64.
Running lipo -info:
Non-fat file: ... build/ios/Profile-iphoneos/Flutter.framework/Flutter is architecture: arm64
#0 UnpackIOS._thinFramework (package:flutter_tools/src/build_system/targets/ios.dart:351:7)
<asynchronous suspension>
#1 UnpackIOS.build (package:flutter_tools/src/build_system/targets/ios.dart:298:5)
<asynchronous suspension>
...
```
</details>
### Reproduction
On a mac x64 host:
1. Switch to the latest master channel: `flutter channel master ; flutter upgrade`
1. Disable the Swift Package Manager feature: `flutter config --no-enable-swift-package-manager`
2. Create a Flutter project
2. [Edit the Xcode project manually to add the prepare pre-action](https://docs.flutter.dev/packages-and-plugins/swift-package-manager/for-app-developers#step-2-add-run-prepare-flutter-framework-script-pre-action )
3. Run `flutter run` (`flutter build ios` does not reproduce this issue).
### Background
Previously, the Flutter framework was unpacked in the Xcode target's build. Unfortunately, this happens after Swift packages are built; this prevented Swift packages from using the Flutter framework.
To fix this, we added an Xcode pre-action that unpacks the Flutter framework _before_ Swift Package Manager builds packages. The Xcode target still runs the Flutter framework unpack step, but this step no-ops if the unpack step has the exact same inputs.
```mermaid
flowchart LR
A[flutter run -d iphone] --> B(Build Xcode project)
B --> C(Xcode 'prepare framework' pre-action)
B --> G[Build Swift packages]
B --> D(Build 'Runner' target)
C --> E[Unpack Flutter framework #1 ]
D --> F["
Unpack Flutter framework #2
(No-ops if inputs are same as #1 )
"]
```
https://github.com/flutter/flutter/pull/150052 added an optimization that made it more likely the second unpack step no-ops by fixing a case where the target architecture input could be different:
> When using SwiftPM, we use `flutter assemble` in an Xcode Pre-action to run the `debug_unpack_macos` (or profile/release) target. This target is also later used in a Run Script build phase. Depending on `ARCHS` build setting, the Flutter/FlutterMacOS binary is thinned. In the Run Script build phase, `ARCHS` is filtered to the active arch. However, in the Pre-action it doesn't always filter to the active arch. As a workaround, assume arm64 if the [`NATIVE_ARCH`](https://developer.apple.com/documentation/xcode/build-settings-reference/#NATIVEARCH ) is arm, otherwise assume x86_64.
This optimization is only applied if [`ONLY_ACTIVE_ARCH`](https://developer.apple.com/library/archive/documentation/DeveloperTools/Reference/XcodeBuildSettingRef/1-Build_Setting_Reference/build_setting_ref.html#//apple_ref/doc/uid/TP40003931-CH3-SW157 ) is `YES`.
> [!IMPORTANT]
> [`ONLY_ACTIVE_ARCH`](https://developer.apple.com/library/archive/documentation/DeveloperTools/Reference/XcodeBuildSettingRef/1-Build_Setting_Reference/build_setting_ref.html#//apple_ref/doc/uid/TP40003931-CH3-SW157 )'s name is misleading. It specifies whether the product includes only object code for the native architecture.
>
> A value of `YES` means the product includes only code for the native architecture ([NATIVE_ARCH](https://developer.apple.com/library/archive/documentation/DeveloperTools/Reference/XcodeBuildSettingRef/1-Build_Setting_Reference/build_setting_ref.html#//apple_ref/doc/uid/TP40003931-CH3-SW59 )).
>
> A value of `NO` means the product includes code for the architectures specified in [ARCHS (Architectures)](https://developer.apple.com/library/archive/documentation/DeveloperTools/Reference/XcodeBuildSettingRef/1-Build_Setting_Reference/build_setting_ref.html#//apple_ref/doc/uid/TP40003931-CH3-SW62 ).
### Problem
`buildXcodeProject` incorrectly always sets `ONLY_ACTIVE_ARCH` to `YES` if the Xcode built is for a single architecture:
6abef22251/packages/flutter_tools/lib/src/ios/mac.dart (L353-L361)https://developer.apple.com/library/archive/documentation/DeveloperTools/Reference/XcodeBuildSettingRef/1-Build_Setting_Reference/build_setting_ref.html#//apple_ref/doc/uid/TP40003931-CH3-SW157 ) should be `NO`.
This caused the prepare pre-action to incorrectly use x64 as the target architecture for arm64 devices on an x64 host, which in turn caused builds to fail if Swift Package Manager was enabled.
### Solution
This change updates `buildXcodeProject` to set `ONLY_ACTIVE_ARCH` correctly.
This change also updates the prepare pre-action's to be more conservative in applying the optimization that filters the target architecture. This ensures that the build still works (but without the optimization) if `ONLY_ACTIVE_ARCH` is incorrectly set.
Follow-up PR: https://github.com/flutter/flutter/pull/154649
This unblocks: https://github.com/flutter/flutter/issues/151567
### DeviceLab test
This problem reproduces if you `flutter run` to an iPhone Arm64 device from an x64 mac host with the Swift Package Manager feature enabled.
I ran an affected DeviceLab test to verify the fix works as expected:
Description | CI test | Result
-- | -- | --
SwiftPM enabled without this fix: https://github.com/flutter/flutter/pull/154750 | [Link](https://ci.chromium.org/ui/p/flutter/builders/try.shadow/Mac_ios%20rrect_blur_perf_ios__timeline_summary/7/overview ) | â
SwiftPM enabled with this fix: https://github.com/flutter/flutter/pull/154749 | [Link](https://ci.chromium.org/ui/p/flutter/builders/try.shadow/Mac_ios%20rrect_blur_perf_ios__timeline_summary/8/overview ) | â
2024-09-11 20:03:22 +00:00
engine-flutter-autoroll
3c2e25d7e4
Roll Packages from bb53e5d536ae to 4c18648650ae (1 revision) ( #155033 )
...
bb53e5d536...4c1864865010687576+bparrishMines@users.noreply.github.com Adds internal wrapper for Android native `ContentProgressProvider` (flutter/packages#7461 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-11 18:26:17 +00:00
engine-flutter-autoroll
5b3356ca43
Roll Flutter Engine from 4eb729b7a5c4 to ade8ef293bc6 (3 revisions) ( #155031 )
...
4eb729b7a5...ade8ef293bskia-flutter-autoroll@skia.org Roll Skia from 44b4a40178cc to fb0b2eb61b65 (1 revision) (flutter/engine#55104 )
2024-09-11 reidbaker@google.com Add back FlutterViewTest.java (flutter/engine#55048 )
2024-09-11 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 8XJTJm4D4Go1dBaTi... to fKNT8lbGh8JzxjE6m... (flutter/engine#55103 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 8XJTJm4D4Go1 to fKNT8lbGh8Jz
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-11 18:24:07 +00:00
Kishan Rathore
04e1b174ea
fix: Dropdown menu trying to access highlight element which doesn't exist when search and filters both are enabled ( #151969 )
...
DropdownMenu throws RangeError when both filter and search are enabled because when we search for elements, we have some highlighted element, but if there is no element to highlight it tries to access 0th element is the filtered entries, but entries are empty.
Fixes #151878
2024-09-11 18:00:50 +00:00
Flutter GitHub Bot
d4bfa2fd14
Marks Linux build_tests_3_5 to be unflaky ( #154993 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Linux build_tests_3_5"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux%20build_tests_3_5%22 ).
This test can be marked as unflaky.
2024-09-11 17:59:39 +00:00
abdalmonem
3e4d59eae1
Add 'direction' allow to 'SegmentedButton' oriented vertically ( #150903 )
...
This PR add the ability to change buttons of 'SegmentedButton' directionality (In the vertical and horizontal axis) to be 'vertical' or 'horizontal' instead of just horizontally position by adding "direction" argument.
`direction: Axis.horizontal` :
`direction: Axis.vertical` :
Notice: in this example i used:
`style: ButtonStyle( shape: MaterialStateProperty.all<RoundedRectangleBorder>( const RoundedRectangleBorder( borderRadius: BorderRadius.zero, ), ), ) `
To change the Radius of `SegmentedButton`, and the default shape will be like:
I keep it as it is right now, cause its not the main purpose of this BR.
*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
Fixes : #150416
2024-09-11 17:59:36 +00:00
Flutter GitHub Bot
6e46ee8d6d
Marks Linux build_tests_5_5 to be unflaky ( #154995 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Linux build_tests_5_5"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux%20build_tests_5_5%22 ).
This test can be marked as unflaky.
2024-09-11 17:51:06 +00:00
Lau Ching Jun
00b410a466
Update the signature of DDS launcher callback. ( #154949 )
...
Following https://dart-review.googlesource.com/c/sdk/+/383901
2024-09-11 17:39:20 +00:00
gaaclarke
b5ce70a760
Migrate Color.toString() test, improves equalsIgnoringHashCodes ( #154934 )
...
This migrates the last failing test for https://github.com/flutter/engine/pull/54981 . In order to effectively resolve that test I had to make `equalsIgnoringHashCodes` more usable by printing out the line that differs instead of just a huge blob of "expected" vs "actual.
## example
Here's the output after the change.
### test
```
test('equalsIgnoringHashCodes - wrong line', () {
expect(
'1\n2\n3\n4\n5\n6\n7\n8\n9\n10',
equalsIgnoringHashCodes('1\n2\n3\n4\n5\n6\na\n8\n9\n10'),
);
});
```
### output
```
Expected: normalized value matches
'1\n'
'2\n'
'3\n'
'4\n'
'5\n'
'6\n'
'a\n'
'8\n'
'9\n'
'10'
Actual: '1\n'
'2\n'
'3\n'
'4\n'
'5\n'
'6\n'
'7\n'
'8\n'
'9\n'
'10'
Which: Lines 7 differed, expected:
'a'
but got
'7'
```
2024-09-11 17:34:58 +00:00
Qun Cheng
bcf1c5a243
Update material and cupertino localizations ( #154959 )
...
The translation console stop processing l10n requests since end of last year and finally finished all of them:) This PR is to update material and cupertino localizations.
2024-09-11 16:57:48 +00:00
Flutter GitHub Bot
d8de38f10d
Marks Linux build_tests_1_5 to be unflaky ( #154991 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Linux build_tests_1_5"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux%20build_tests_1_5%22 ).
This test can be marked as unflaky.
2024-09-11 16:52:29 +00:00
Flutter GitHub Bot
e662a9bafe
Marks Linux build_tests_2_5 to be unflaky ( #154992 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Linux build_tests_2_5"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux%20build_tests_2_5%22 ).
This test can be marked as unflaky.
2024-09-11 16:52:27 +00:00
Shashwat Pathak
0a9148870a
Fix flutter create warning regarding Java compatibility ( #152836 )
...
This PR modifies the warning message regarding Java compatibility to make it consistent with the Flutter style guide.
**Current message looks like this**
```
[RECOMMENDED] If so, to keep the default AGP version 8.1.0, make
sure to download a compatible Java version
(Java 17 <= compatible Java version < Java 21).
You may configure this compatible Java version by running:
`flutter config --jdk-dir=<JDK_DIRECTORY>`
Note that this is a global configuration for Flutter.
Alternatively, to continue using your configured Java version, update the AGP
version specified in the following files to a compatible AGP
version (minimum compatible AGP version: 7.0) as necessary:
- /home/user/project/testproj/android/build.gradle
See
https://developer.android.com/build/releases/gradle-plugin for details on
compatible Java/AGP versions.
```
**After Modification**
```
To keep the default AGP version 8.1.0, download a compatible Java version
(Java 17 <= compatible Java version < Java 21). Configure this Java version
globally for Flutter by running:
flutter config --jdk-dir=<JDK_DIRECTORY>
Alternatively, to continue using your current Java version, update the AGP
version in the following file(s) to a compatible version (minimum AGP version: 7.0):
/home/user/project/testproj/android/build.gradle
For details on compatible Java and AGP versions, see
https://developer.android.com/build/releases/gradle-plugin
```
Fixes #152460
2024-09-11 16:21:16 +00:00
engine-flutter-autoroll
d565781992
Roll Flutter Engine from 54757dab9462 to 4eb729b7a5c4 (1 revision) ( #155022 )
...
54757dab94...4eb729b7a5skia-flutter-autoroll@skia.org Roll Skia from 320dccf1a32d to 44b4a40178cc (1 revision) (flutter/engine#55101 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-11 15:54:38 +00:00
Gray Mackall
fadbf44471
Fix java version used by build_aar_module_test ( #154967 )
...
Used the wrong syntax, whoops
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Co-authored-by: Gray Mackall <mackall@google.com>
2024-09-11 10:17:25 -04:00
engine-flutter-autoroll
e167992911
Roll Flutter Engine from 0a14c519ea4f to 54757dab9462 (1 revision) ( #155015 )
...
0a14c519ea...54757dab94skia-flutter-autoroll@skia.org Roll Dart SDK from 072945e0b457 to a438066d634f (1 revision) (flutter/engine#55100 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-11 13:24:07 +00:00
engine-flutter-autoroll
9108b6d0cf
Roll Flutter Engine from 35a3171b72c5 to 0a14c519ea4f (1 revision) ( #154984 )
...
35a3171b72...0a14c519easkia-flutter-autoroll@skia.org Roll Skia from 7a4bd062b193 to 320dccf1a32d (2 revisions) (flutter/engine#55099 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-11 09:11:17 +00:00
engine-flutter-autoroll
c86dcd4b4f
Roll Flutter Engine from b9c0b96c3316 to 35a3171b72c5 (1 revision) ( #154980 )
...
b9c0b96c33...35a3171b72skia-flutter-autoroll@skia.org Roll Skia from a7ddd4d2c6bb to 7a4bd062b193 (1 revision) (flutter/engine#55098 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-11 08:09:40 +00:00
engine-flutter-autoroll
bf7e2966b1
Roll Flutter Engine from 52eeea075767 to b9c0b96c3316 (1 revision) ( #154976 )
...
52eeea0757...b9c0b96c33skia-flutter-autoroll@skia.org Roll Skia from 618beab475b6 to a7ddd4d2c6bb (1 revision) (flutter/engine#55096 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-11 07:03:24 +00:00
engine-flutter-autoroll
dbac1c3c6f
Roll Flutter Engine from a26075f9b1e6 to 52eeea075767 (1 revision) ( #154973 )
...
a26075f9b1...52eeea0757skia-flutter-autoroll@skia.org Roll Dart SDK from 22d8331d882e to 072945e0b457 (1 revision) (flutter/engine#55097 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-11 06:10:19 +00:00
engine-flutter-autoroll
8a2c3a65fe
Roll Flutter Engine from 60c15bc0f40e to a26075f9b1e6 (6 revisions) ( #154969 )
...
60c15bc0f4...a26075f9b1skia-flutter-autoroll@skia.org Roll Dart SDK from 741512e72e92 to 22d8331d882e (1 revision) (flutter/engine#55094 )
2024-09-10 matanlurey@users.noreply.github.com Move `flutter_frontend_server` and tweak `run_tests.py` to allow env variables. (flutter/engine#55089 )
2024-09-10 jonahwilliams@google.com [Impeller] fix comment on savelayer utils. (flutter/engine#55049 )
2024-09-10 skia-flutter-autoroll@skia.org Roll Skia from 1760de26fb83 to 618beab475b6 (2 revisions) (flutter/engine#55088 )
2024-09-10 jonahwilliams@google.com [Impeller] Fix memory leak I introduced by fixing memory leak. (flutter/engine#55087 )
2024-09-10 matanlurey@users.noreply.github.com Remove the last `--disable-dart-dev` in the engine. (flutter/engine#55086 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-11 02:16:25 +00:00
Matan Lurey
0e6c16c27a
Migrate apple-mobile-web-* to mobile-web-*. ( #154964 )
...
Closes https://github.com/flutter/flutter/issues/154596 .
It's less clear to me if your goal was to migrate _all_ of these btw:
https://github.com/search?q=org%3Aflutter+%22mobile-web-app-capable%22&type=code
2024-09-11 00:39:51 +00:00
engine-flutter-autoroll
2fb154f820
Roll Flutter Engine from 8a038a6f7099 to 60c15bc0f40e (15 revisions) ( #154960 )
...
8a038a6f70...60c15bc0f458529443+srujzs@users.noreply.github.com Update package:web to use new path and latest revision (flutter/engine#55085 )
2024-09-10 skia-flutter-autoroll@skia.org Roll Skia from 82d2e4033333 to 1760de26fb83 (8 revisions) (flutter/engine#55084 )
2024-09-10 matanlurey@users.noreply.github.com Move more of the tests in the engine to `package:test` (flutter/engine#55083 )
2024-09-10 matanlurey@users.noreply.github.com Redirect `run_ios_tests.sh` to `run_ios_tests.dart`. (flutter/engine#53717 )
2024-09-10 jonahwilliams@google.com [Impeller] reland experimental canvas. (flutter/engine#55047 )
2024-09-10 magder@google.com Fix 'dart --enable-asserts' typo in license check script (flutter/engine#55082 )
2024-09-10 skia-flutter-autoroll@skia.org Roll Dart SDK from af7460619b2b to 741512e72e92 (1 revision) (flutter/engine#55080 )
2024-09-10 skia-flutter-autoroll@skia.org Roll Skia from 4815ec808aa5 to 82d2e4033333 (8 revisions) (flutter/engine#55079 )
2024-09-10 rmacnak@google.com Roll buildroot to f85c3be4bf808add6ba867b8ff7943fd235b7b5e. (flutter/engine#55051 )
2024-09-10 skia-flutter-autoroll@skia.org Roll Skia from 5dc067350ab5 to 4815ec808aa5 (2 revisions) (flutter/engine#55074 )
2024-09-10 skia-flutter-autoroll@skia.org Roll Dart SDK from d59138eb6ec2 to af7460619b2b (1 revision) (flutter/engine#55073 )
2024-09-10 skia-flutter-autoroll@skia.org Roll Skia from c62380453c72 to 5dc067350ab5 (1 revision) (flutter/engine#55072 )
2024-09-10 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from kIWQ460iagZLxVRPc... to 8XJTJm4D4Go1dBaTi... (flutter/engine#55071 )
2024-09-10 skia-flutter-autoroll@skia.org Roll Skia from 9bea95918e69 to c62380453c72 (1 revision) (flutter/engine#55070 )
2024-09-10 skia-flutter-autoroll@skia.org Roll Dart SDK from a60078a23978 to d59138eb6ec2 (2 revisions) (flutter/engine#55068 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from kIWQ460iagZL to 8XJTJm4D4Go1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-11 00:26:07 +00:00
gaaclarke
746d8af006
Adds dart fixes for Color opacity functions ( #154953 )
...
fixes https://github.com/flutter/flutter/issues/154572
2024-09-10 23:12:56 +00:00
John McDole
1c3b501f53
Missing benchmarks for foundation/all_elements_bench.dart ( #154954 )
...
I missed awaiting a future. Probably should have a lint for unawaited futures...
2024-09-10 23:01:09 +00:00
gaaclarke
203f11647f
Update color assertions ( #154752 )
...
issue: https://github.com/flutter/flutter/issues/127855
This is a forward fix to help
https://github.com/flutter/engine/pull/54981 land.
It makes the following changes:
1) Removes hardcoded `Color.toString()` assumptions in asserts
1) Switches some lerp tests to use numbers that are more friendly to
uint8_t and floating point numbers
1) implements custom matchers for color
1) removes word wrapping for some asserts since it makes them fragile to
changes in `Color.toString()` invocations
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2024-09-10 15:32:40 -07:00
Andrew Kolos
30835d7dac
handle EAGAIN (macOS) in ErrorHandlingProcessManager ( #154306 )
...
~~Fixes~~ Discovered in https://github.com/flutter/flutter/issues/153776 .
To my knowledge, `Resource temporarily unavailable` when trying to run a process means that some required resource is at capacity. There may be too many processes active, not enough available ports, or some sort of blocking cache is full, etc. Feel free to independently research and see if you come to the same conclusion.
Then, it seems safe to catch and handle this within the tool's `ErrorHandlingProcessManager` abstraction, as Flutter cannot realistically do anything to prevent this issue.
2024-09-10 22:24:56 +00:00
Mairramer
93d06ebd6c
fix unpack freezing app with animation duration zero ( #153890 )
...
Fixes #153889 an issue where nodes were being removed incorrectly when using `AnimationStyle.noAnimation `or the animation duration was zero seconds, which previously caused the application to freeze due to hidden state updates. By skipping the animation and updating active nodes immediately in these cases, we avoid these issues and ensure smooth and accurate management of node states.
2024-09-10 22:24:54 +00:00
Matan Lurey
4b5cf85534
Remove last --disable-dart-dev in flutter/flutter. ( #154948 )
...
Work towards https://github.com/flutter/flutter/issues/154268 .
2024-09-10 21:37:08 +00:00
Gray Mackall
6fd2b9f88b
Remove scheduler: luci from new build_aar_module_test ( #154945 )
...
This option was deprecated (/removed?) in the time since the test was originally disabled.
See https://github.com/flutter/flutter/issues/109712 , https://github.com/flutter/flutter/pull/109714
2024-09-10 20:35:07 +00:00
flutter-pub-roller-bot
ad4162f863
Roll pub packages ( #154939 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2024-09-10 19:54:11 +00:00
Qun Cheng
b872a27c4e
CupertinoSlidingSegmentedControl update (#152976 )
...
This PR is to improve `CupertinoSlidingSegmentedControl` fidelity and add a new property `setEnabled` so that segments can be disabled now.
Fidelity update includes:
* small change on default thumb radius (Based on iOS 17 Figma file)
* separator height (Based on the comparison with SegmentedControl example in Xcode)
* segment min padding (Based on iOS 17 Figma file)
* thumb scale alignment (Based on the comparison with SegmentedControl example in Xcode). If the thumb is on the first or last position in SegmentedControl, the alignment should be `Alignment.leftCenter` and `Alignment.rightCenter` respectively, assuming the text direction is left to right. For segments in middle, they should have center alignment as previously.
* TextStyle update (Based on both the Figma file and the Xcode example)
* Clipped thumb shadow if the shadow is outside of the segmented control (Based on the Xcode example)
* Fixed the overall size shaking issue during segment switching on macOS and iOS
<details><summary>Alignment update demo</summary>
https://github.com/user-attachments/assets/6de3986f-6810-4dc4-8688-f87120557d89
</details>
<details><summary>Comparison before and after</summary>
Before:
After:
</details>
<details><summary>Shaking issue</summary>
Before:
https://github.com/user-attachments/assets/910d1271-75ea-4cec-8666-24090f9d4fb0
After:
https://github.com/user-attachments/assets/bc5ae3e1-600d-49a6-95d9-b1f5d1bd9f6d
</details>
The `disabledChildren` feature can be used to disable segments. The default disabled color comes from the inspection in the Xcode example.
<details><summary>Disabled feature demos</summary>
Disabled segment cannot be highlighted:
https://github.com/user-attachments/assets/70339364-23d5-41c7-b071-c7abe92abd62
`groupValue` can still be highlighted programmatically if it is disabled.
</details>
2024-09-10 19:41:23 +00:00
flutter-pub-roller-bot
55af75d57b
Roll pub packages ( #154933 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2024-09-10 18:21:26 +00:00
Andrew Kolos
d88e692895
fix test chrome.close can recover if getTab throws a StateError ( #154889 )
...
Fixes https://github.com/flutter/flutter/issues/154857 .
Does so by:
* adding `await chromiumLauncher.connect(chrome, false);` before the `close` call to make sure we enter[ the block ](9cd2fc90af/packages/flutter_tools/lib/src/web/chrome.dart (L521-L535)
2024-09-10 17:23:56 +00:00
Justin McCandless
24d0b1db0a
SearchBar context menu ( #154833 )
...
SearchBar and SearchAnchor can now control their context menu. They both received new contextMenuBuilder parameters. See the docs for EditableText.contextMenuBuilder for how to use this, including how to use the native context menu on iOS and to control the browser's context menu on web.
2024-09-10 09:54:00 -07:00
Gray Mackall
f964f15dcb
Fix flutter build aar for modules that use a plugin ( #154757 )
...
https://github.com/flutter/flutter/pull/151675 bumped module templates to AGP 8.1.
In doing so, I tried to work around a behavior change [that was new in AGP 8.0](https://developer.android.com/build/releases/past-releases/agp-8-0-0-release-notes ):
> AGP 8.0 creates no SoftwareComponent by default. Instead AGP creates SoftwareComponents only for variants that are configured to be published using the publishing DSL.
by using AGP's publishing DSL to define which variants to publish in the module's ephemeral gradle files:
```
android.buildTypes.all {buildType ->
if (!android.productFlavors.isEmpty()) {
android.productFlavors.all{productFlavor ->
android.publishing.singleVariant(productFlavor.name + buildType.name.capitalize()) {
withSourcesJar()
withJavadocJar()
}
}
} else {
android.publishing.singleVariant(buildType.name) {
withSourcesJar()
withJavadocJar()
}
}
}
```
The problem is that this doesn't get applied to the plugin projects used by the module, so if a module uses any plugin it breaks. This PR fixes that by applying similar logic, but to each project (not just the module's project).
Tested manually with https://github.com/gmackall/GrayAddToApp , and also re-enabled an old test that tested this use case as a part of the PR.
Fixes: https://github.com/flutter/flutter/issues/154371
2024-09-10 16:42:22 +00:00
engine-flutter-autoroll
7e2de37336
Roll Packages from b4e0fc1bc117 to bb53e5d536ae (4 revisions) ( #154926 )
...
b4e0fc1bc1...bb53e5d536magder@google.com [ci] Increase deprecation check minimum to macOS 14 (flutter/packages#7544 )
2024-09-09 paulberry@google.com [camerax] Ignore new `unreachable_switch_default` warning. (flutter/packages#7592 )
2024-09-09 109111084+yaakovschectman@users.noreply.github.com [google_maps_flutter_platform_interface] Split `CameraUpdate` into derived classes to use structured data (flutter/packages#7596 )
2024-09-09 stuartmorgan@google.com [google_maps_flutter] Disable setAndGetScrollPosition on iOS (flutter/packages#7609 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-10 16:34:19 +00:00
Taha Tesser
ebc2c3e437
Clean up SnackBar inherit theme data test ( #154921 )
...
Fixes [Verbose `SnackBar` inherit theme data test](https://github.com/flutter/flutter/issues/154920 )
2024-09-10 16:27:14 +00:00
davidhicks980
bffa21549c
Revert "Improve CupertinoPopupSurface appearance" ( #154893 )
...
Reverts flutter/flutter#151430 to fix
https://github.com/flutter/flutter/issues/154887 until I can investigate
further.
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
2024-09-10 08:12:46 -07:00
engine-flutter-autoroll
4be3035103
Roll Flutter Engine from 3dc8b71f96cc to 8a038a6f7099 (1 revision) ( #154904 )
...
3dc8b71f96...8a038a6f70yjbanov@google.com [skwasm] use temporary RawPaint objects (attempt #2 ) (flutter/engine#55035 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-10 14:53:34 +00:00
engine-flutter-autoroll
d6e2b6aedb
Roll Flutter Engine from 656117fc8ba9 to 3dc8b71f96cc (3 revisions) ( #154900 )
...
656117fc8b...3dc8b71f96skia-flutter-autoroll@skia.org Roll Dart SDK from b6c3cd9b93f1 to a60078a23978 (14 revisions) (flutter/engine#55059 )
2024-09-09 jason-simmons@users.noreply.github.com Add missing include to fml/hex_codec.h (flutter/engine#55034 )
2024-09-09 skia-flutter-autoroll@skia.org Roll Skia from 7e659d5538fa to 9bea95918e69 (3 revisions) (flutter/engine#55052 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-10 05:27:20 +00:00
flutter-pub-roller-bot
b3481c3a2b
Roll pub packages ( #154894 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2024-09-10 04:26:19 +00:00
flutter-pub-roller-bot
ee89e9a560
Roll pub packages ( #154890 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2024-09-10 01:27:22 +00:00
Christopher Fujino
92697d3ecc
Improve tracing and fix packages_autoroller ( #154841 )
...
Reverts flutter/flutter#154555
Re-lands of https://github.com/flutter/flutter/pull/154441 and https://github.com/flutter/flutter/pull/154369
New changes in this PR:
1. extend timeout of the `Linux packages_autoroller` shard (see step 14 in this example [LED build](https://ci.chromium.org/ui/p/flutter/builders/prod.shadow/Linux%20packages_autoroller/7/infra ))
2. use the managed framework repo as the working directory in the `framework.streamDart()` helper function--we were generating gradle lockfiles in the wrong directory
A LED build with this code generated the following gradle lockfile update: d939981cd2
2024-09-09 23:31:21 +00:00
engine-flutter-autoroll
81d23d93f6
Roll Flutter Engine from c18ecf9e4000 to 656117fc8ba9 (2 revisions) ( #154883 )
...
c18ecf9e40...656117fc8bmagder@google.com Unskip Impeller iOS scenario tests (flutter/engine#55012 )
2024-09-09 skia-flutter-autoroll@skia.org Roll Skia from 7ad1252da14f to 7e659d5538fa (2 revisions) (flutter/engine#55050 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-09 23:26:58 +00:00
engine-flutter-autoroll
c7f5b79c57
Roll Flutter Engine from 7ad9e5ba962c to c18ecf9e4000 (1 revision) ( #154855 )
...
7ad9e5ba96...c18ecf9e40skia-flutter-autoroll@skia.org Roll Skia from 8103f53635fd to 7ad1252da14f (3 revisions) (flutter/engine#55046 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-09 22:00:11 +00:00
