DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
29,592 Commits 882 Branches 1,069 Tags
Commit Graph

29592 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Bruno Leroux
8aff00a5d8 [Android] Return the keyboard pressed state (flutter/engine#42758) 
## Description

This PR updates the Android engine in order to answer to keyboard pressed state queries from the framework (as implemented in https://github.com/flutter/flutter/pull/122885).

This is a rework of https://github.com/flutter/engine/pull/41695 which was reverted in https://github.com/flutter/engine/pull/42346.

This issue with https://github.com/flutter/engine/pull/41695 was that the framework side did not get an answer when the channel was setup in the engine without registering a handler (on the engine side) to handle framework requests. The issue was reproducible when the engine initialization was managed by the app (see https://github.com/flutter/flutter/issues/122441#issuecomment-1582052616 for a repro).

This PR fixes this issue by changing `flutter/keyboard` lifecycle: the engine now creates the channel and registers a handler just after the channel creation.
In order to avoid regression, this PR also updates the channel implemenation (see `KeyboardChannel`) to return an empty `HashMap` when there is no handler registered.

## Related Issue

Android engine implementation for https://github.com/flutter/flutter/issues/87391
(see https://github.com/flutter/engine/pull/42346 for Linux implementation)
Fixes https://github.com/flutter/flutter/issues/122441

## Tests

Adds 3 tests.
 2023-06-21 05:49:06 +00:00
skia-flutter-autoroll
8309005f59 Roll Dart SDK from 493133372cac to 178d3d1184cb (1 revision) (flutter/engine#43032) 
https://dart.googlesource.com/sdk.git/+log/493133372cac..178d3d1184cb

2023-06-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-235.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-21 05:13:17 +00:00
skia-flutter-autoroll
57508fcd56 Roll Skia from cc164404690f to efc045c15fdd (1 revision) (flutter/engine#43027) 
https://skia.googlesource.com/skia.git/+log/cc164404690f..efc045c15fdd

2023-06-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 90577eb35eea to f0fc1de57d41 (5 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-21 01:06:06 +00:00
Jason Simmons
c4e22ba089 Implement the APNG_DISPOSE_OP_BACKGROUND disposal method in the animated PNG decoder (flutter/engine#42933) 2023-06-21 00:36:49 +00:00
skia-flutter-autoroll
7f3bed1778 Roll Skia from 13d83a6912ce to cc164404690f (1 revision) (flutter/engine#43024) 
https://skia.googlesource.com/skia.git/+log/13d83a6912ce..cc164404690f

2023-06-20 armansito@google.com [viewer] Don't crash on nextDrawable timeout

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-21 00:01:20 +00:00
Tamir Duberstein
2e2c2a4c72 Roll buildroot to 6e71c38443c0bf9d8954c87bf69bb4e019f44f94 (flutter/engine#43019) 
Rolling:
- https://github.com/flutter/buildroot/pull/746
- https://github.com/flutter/buildroot/pull/747
- https://github.com/flutter/buildroot/pull/748
 2023-06-20 23:33:57 +00:00
skia-flutter-autoroll
d55440b083 Roll Dart SDK from 219b3198373c to 493133372cac (2 revisions) (flutter/engine#43021) 
https://dart.googlesource.com/sdk.git/+log/219b3198373c..493133372cac

2023-06-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-234.0.dev
2023-06-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-233.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-20 23:08:26 +00:00
skia-flutter-autoroll
81836d898a Roll Skia from 0b88d9031cd2 to 13d83a6912ce (4 revisions) (flutter/engine#43020) 
https://skia.googlesource.com/skia.git/+log/0b88d9031cd2..13d83a6912ce

2023-06-20 johnstiles@google.com Apply immutable-value optimization to compound constructors.
2023-06-20 fmalita@google.com Revert "De-SkScalar SkRect"
2023-06-20 kjlubick@google.com Add gl specific filegroup
2023-06-20 jvanverth@google.com [graphite] Add Windows Release Vulkan test job.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-20 22:58:43 +00:00
skia-flutter-autoroll
b02557351d Roll Skia from d56841344bbe to 0b88d9031cd2 (3 revisions) (flutter/engine#43018) 
https://skia.googlesource.com/skia.git/+log/d56841344bbe..0b88d9031cd2

2023-06-20 hitawala@chromium.org Graphite: Loosen TextureUsage validation to allow superset of usages
2023-06-20 herb@google.com De-SkScalar SkRect
2023-06-20 herb@google.com Add sk_float_midpoint

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-20 21:46:17 +00:00
skia-flutter-autoroll
15ffab06fc Roll Skia from 9f8b501ca68c to d56841344bbe (5 revisions) (flutter/engine#43016) 
https://skia.googlesource.com/skia.git/+log/9f8b501ca68c..d56841344bbe

2023-06-20 bungeman@google.com Add text and clusters to debugger text blobs
2023-06-20 brianosman@google.com Revert "Remove SkScalarToFloat and SkFloatToScalar calls"
2023-06-20 michaelludwig@google.com [skif] Remove legacy displacement implementation
2023-06-20 michaelludwig@google.com [skif] Delete legacy morphology implementations
2023-06-20 armansito@google.com [gm] Add GMs that apply a gradient to a path

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-20 20:27:24 +00:00
skia-flutter-autoroll
8934ab1603 Roll Skia from 0b26ffb4efe0 to 9f8b501ca68c (10 revisions) (flutter/engine#43012) 
https://skia.googlesource.com/skia.git/+log/0b26ffb4efe0..9f8b501ca68c

2023-06-20 brianosman@google.com Handle divide-by-zero in dashing code
2023-06-20 vollick@chromium.org Attempt to use fallback color type and backend format
2023-06-20 brianosman@google.com Remove SkScalarToFloat and SkFloatToScalar calls
2023-06-20 herb@google.com Reland "Quad intersections for glyph underlines"
2023-06-20 herb@google.com Change isfinite -> sk_float_isifinite in SkPoint
2023-06-20 brianosman@google.com Fix FuzzCanvas imageFilter selection
2023-06-20 brianosman@google.com Suppress divide-by-zero in hairline intersection code
2023-06-20 johnstiles@google.com Detect immutable variables regardless of the const modifier.
2023-06-20 johnstiles@google.com Add support for immutable data in SkRP.
2023-06-20 uioptt24@gmail.com [graphite] Fix the specified type does not match the argument type error

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-20 19:17:53 +00:00
Jason Simmons
91f507c27c A few minor cleanups of the MultiFrameCodec (flutter/engine#42935) 2023-06-20 17:57:17 +00:00
Jonah Williams
2b383d3b89 [Impeller] use pixel format in construction of initial PSO objects, set default sample count to 4. (flutter/engine#42972) 
Reland of https://github.com/flutter/engine/pull/42902

on iOS the default pixel format can change due to wide gamut + platform views introducing multiple surfaces. Cache the default options used to create all pipelines so that we can guarantee that one can be found.
 2023-06-20 17:45:47 +00:00
skia-flutter-autoroll
d89d28ac68 Roll Dart SDK from dc6691ef755c to 219b3198373c (1 revision) (flutter/engine#43005) 
https://dart.googlesource.com/sdk.git/+log/dc6691ef755c..219b3198373c

2023-06-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-232.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-20 17:42:04 +00:00
fzyzcjy
a0e9bfe3d4 Differentiate two EncodeCommandsInReactor with the same name (flutter/engine#42992) 
*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*

*List which issues are fixed by this PR. You must list at least one issue.*

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-06-20 17:24:09 +00:00
Michael Goderbauer
12e586914e Reland "Add deprecations to PlatformMessage stuff" (#42580) (flutter/engine#42929) 
This reverts commit 2b5c1f8d95c9c54e51787f5ceaeb142c0666aa72.

This is a straight reland without any additional changes. The package that was still using the outdated API causing the original revert has been updated in https://github.com/flutter/packages/pull/4233. **Do not land this until that PR has rolled into the framework.**
 2023-06-20 16:42:25 +00:00
skia-flutter-autoroll
c94610c218 Roll Fuchsia Linux SDK from jzCJwD297aRZtdakZ... to 41wcREjd9roHDS1jM... (flutter/engine#43003) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-20 15:38:08 +00:00
skia-flutter-autoroll
7867b67c5c Roll Skia from 6823d03cf2b2 to 0b26ffb4efe0 (2 revisions) (flutter/engine#43002) 
https://skia.googlesource.com/skia.git/+log/6823d03cf2b2..0b26ffb4efe0

2023-06-20 johnstiles@google.com Disable struct-passing test on Tegra3.
2023-06-20 brianosman@google.com Make SkPathMeasure move-able

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-20 15:11:44 +00:00
skia-flutter-autoroll
273f2a0d27 Roll Skia from 1d6ca884ed77 to 6823d03cf2b2 (1 revision) (flutter/engine#42998) 
https://skia.googlesource.com/skia.git/+log/1d6ca884ed77..6823d03cf2b2

2023-06-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 37334fcf8703 to 90577eb35eea (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-20 11:31:22 +00:00
skia-flutter-autoroll
6a607df41e Roll Fuchsia Mac SDK from JewrT71vAzyDs8qRt... to fdtK_FqpscIVvbb_j... (flutter/engine#42997) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-20 10:43:06 +00:00
skia-flutter-autoroll
2173c6032e Roll Dart SDK from d87670619414 to dc6691ef755c (1 revision) (flutter/engine#42996) 
https://dart.googlesource.com/sdk.git/+log/d87670619414..dc6691ef755c

2023-06-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-231.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-20 08:01:04 +00:00
skia-flutter-autoroll
8db025d6d2 Roll Skia from 60385192e512 to 1d6ca884ed77 (3 revisions) (flutter/engine#42995) 
https://skia.googlesource.com/skia.git/+log/60385192e512..1d6ca884ed77

2023-06-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 24f4007b93e0 to 84379a529407 (9 revisions)
2023-06-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from ab08126079d3 to 850bcdd8dfed
2023-06-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from b32ce543bca1 to ab08126079d3 (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-20 07:45:27 +00:00
skia-flutter-autoroll
d19dcc9340 Roll Skia from abcc292f8afe to 60385192e512 (1 revision) (flutter/engine#42993) 
https://skia.googlesource.com/skia.git/+log/abcc292f8afe..60385192e512

2023-06-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from fc6011e89acd to 0d5e76a2427f (24 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-20 05:51:36 +00:00
skia-flutter-autoroll
7b402c36f0 Roll Fuchsia Linux SDK from lG2K667BLaS_haUZg... to jzCJwD297aRZtdakZ... (flutter/engine#42990) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-19 23:59:17 +00:00
skia-flutter-autoroll
dd81225c44 Roll Skia from 9c2148cd1c82 to abcc292f8afe (1 revision) (flutter/engine#42989) 
https://skia.googlesource.com/skia.git/+log/9c2148cd1c82..abcc292f8afe

2023-06-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 9ed904489a9a to 37334fcf8703 (5 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-19 22:43:32 +00:00
skia-flutter-autoroll
8435b90b4b Roll Fuchsia Mac SDK from gX0QkT_dMBCTbiAHY... to JewrT71vAzyDs8qRt... (flutter/engine#42988) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-19 21:37:23 +00:00
skia-flutter-autoroll
3c0336db57 Roll Skia from 41689ff01f97 to 9c2148cd1c82 (1 revision) (flutter/engine#42987) 
https://skia.googlesource.com/skia.git/+log/41689ff01f97..9c2148cd1c82

2023-06-19 johnstiles@google.com Fix fuzzer-discovered error with inlined arrays.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-19 20:08:15 +00:00
skia-flutter-autoroll
a3765b1e50 Roll Dart SDK from 60adb12ffc30 to d87670619414 (1 revision) (flutter/engine#42986) 
https://dart.googlesource.com/sdk.git/+log/60adb12ffc30..d87670619414

2023-06-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-230.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-19 20:04:52 +00:00
skia-flutter-autoroll
4fddeed704 Roll Skia from 455d7306b951 to 41689ff01f97 (1 revision) (flutter/engine#42983) 
https://skia.googlesource.com/skia.git/+log/455d7306b951..41689ff01f97

2023-06-19 johnstiles@google.com Fix fuzzer-discovered error with void variables.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-19 16:21:12 +00:00
skia-flutter-autoroll
07ad0d9e44 Roll Dart SDK from 3d07173415e8 to 60adb12ffc30 (1 revision) (flutter/engine#42982) 
https://dart.googlesource.com/sdk.git/+log/3d07173415e8..60adb12ffc30

2023-06-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-229.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-19 16:01:18 +00:00
skia-flutter-autoroll
36ccc5c664 Roll Fuchsia Linux SDK from fgS2avQGq4x_sbZHU... to lG2K667BLaS_haUZg... (flutter/engine#42981) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-19 11:00:25 +00:00
skia-flutter-autoroll
159547f733 Roll Skia from c90c7dec5c18 to 455d7306b951 (1 revision) (flutter/engine#42980) 
https://skia.googlesource.com/skia.git/+log/c90c7dec5c18..455d7306b951

2023-06-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 4aa38765aadb to 9ed904489a9a (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-19 10:20:10 +00:00
skia-flutter-autoroll
205568a280 Roll Skia from d182b694a670 to c90c7dec5c18 (1 revision) (flutter/engine#42979) 
https://skia.googlesource.com/skia.git/+log/d182b694a670..c90c7dec5c18

2023-06-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from edf58105d695 to 24f4007b93e0 (9 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-19 09:20:15 +00:00
skia-flutter-autoroll
c0060cf84f Roll Dart SDK from b2ec326cc4f3 to 3d07173415e8 (1 revision) (flutter/engine#42978) 
https://dart.googlesource.com/sdk.git/+log/b2ec326cc4f3..3d07173415e8

2023-06-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-228.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-19 08:20:18 +00:00
skia-flutter-autoroll
3a5a1386d8 Roll Skia from 24f2336d87f2 to d182b694a670 (2 revisions) (flutter/engine#42977) 
https://skia.googlesource.com/skia.git/+log/24f2336d87f2..d182b694a670

2023-06-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from b32ce543bca1 to 15fb7caa7aea
2023-06-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from d044984a01de to b32ce543bca1 (29 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-19 06:54:16 +00:00
skia-flutter-autoroll
6f192cb503 Roll Fuchsia Mac SDK from BuzniDS9u_hdghV5f... to gX0QkT_dMBCTbiAHY... (flutter/engine#42976) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-19 06:26:24 +00:00
skia-flutter-autoroll
53ebbe2765 Roll Skia from f489be63a30a to 24f2336d87f2 (1 revision) (flutter/engine#42975) 
https://skia.googlesource.com/skia.git/+log/f489be63a30a..24f2336d87f2

2023-06-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 4588fe12df3d to fc6011e89acd (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-19 05:45:08 +00:00
skia-flutter-autoroll
9d353fdd13 Roll Dart SDK from 5a9e97eebbed to b2ec326cc4f3 (1 revision) (flutter/engine#42974) 
https://dart.googlesource.com/sdk.git/+log/5a9e97eebbed..b2ec326cc4f3

2023-06-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-227.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-19 03:59:23 +00:00
Jonah Williams
6ddcc5c032 Fix prefer_final_in_foreach analysis errors (flutter/engine#42971) 
This is now failing the engine roll for some reason https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20analyze/58456/overview
 2023-06-18 23:49:28 +00:00
skia-flutter-autoroll
9474fbd337 Roll Fuchsia Linux SDK from xS5RzQLfpMEK1rNEd... to fgS2avQGq4x_sbZHU... (flutter/engine#42973) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-18 21:45:33 +00:00
skia-flutter-autoroll
7baf327e24 Roll Fuchsia Mac SDK from aBEyk5N2HlwOqvpwo... to BuzniDS9u_hdghV5f... (flutter/engine#42970) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-18 17:21:23 +00:00
skia-flutter-autoroll
8e14cb2cbf Roll Skia from dc2e0ebbd045 to f489be63a30a (1 revision) (flutter/engine#42968) 
https://skia.googlesource.com/skia.git/+log/dc2e0ebbd045..f489be63a30a

2023-06-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 3b886d2fc60b to 4aa38765aadb (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,herb@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-18 12:49:21 +00:00
skia-flutter-autoroll
e3ef7be7b9 Roll Skia from 85b4788bc3f1 to dc2e0ebbd045 (1 revision) (flutter/engine#42967) 
https://skia.googlesource.com/skia.git/+log/85b4788bc3f1..dc2e0ebbd045

2023-06-18 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,herb@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-18 11:01:22 +00:00
skia-flutter-autoroll
a7d9ca22c1 Roll Fuchsia Linux SDK from -PsA0LDB2FdS_4_vK... to xS5RzQLfpMEK1rNEd... (flutter/engine#42966) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-18 08:35:29 +00:00
Brandon DeRosier
072ed208cf [Impeller] Use 32 bit for positional stuff in the rrect blur (flutter/engine#42797) 
Resolves https://github.com/flutter/flutter/issues/128410.

16 bit floats aren't precise enough for positional computations, like
computing SDFs in the case of the RRect blur.
 2023-06-17 22:57:14 -07:00
Jonah Williams
4114b30b01 Revert "[Impeller] correct default PSO pixel format and sample count." (flutter/engine#42962) 
Reverts flutter/engine#42902

This is breaking iOS builds:

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8778085761769326737/+/u/run_platform_views_scroll_perf_non_intersecting_impeller_ios__timeline_summary/test_stdout
 2023-06-18 04:39:22 +00:00
Jonah Williams
93351f1448 [Impeller] dont use concurrent runner to decode images on Android. (flutter/engine#42944) 
Even with separate allocators and queues, I think that using the concurrent runner is just overloading the phone.

On Android force it all onto the I/O thread.

https://github.com/flutter/flutter/issues/128919
 2023-06-18 03:54:04 +00:00
skia-flutter-autoroll
e0fb29293e Roll Fuchsia Mac SDK from I1G8Ll0KcxmAoMT8u... to aBEyk5N2HlwOqvpwo... (flutter/engine#42964) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-18 02:04:35 +00:00
skia-flutter-autoroll
3919e8f2c7 Roll Skia from c56f38d79fe0 to 85b4788bc3f1 (2 revisions) (flutter/engine#42963) 
https://skia.googlesource.com/skia.git/+log/c56f38d79fe0..85b4788bc3f1

2023-06-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 067b742c990a to b32ce543bca1
2023-06-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 1f524f69ec88 to 3b886d2fc60b (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,herb@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-18 01:10:31 +00:00
skia-flutter-autoroll
281d006dfe Roll Fuchsia Linux SDK from Au1gd3XLMuSt1Z4oh... to -PsA0LDB2FdS_4_vK... (flutter/engine#42959) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-17 19:23:14 +00:00