skia-flutter-autoroll
8a282ea97a
Roll Skia from 29e7723e1f8c to 2ec12c767ec7 (1 revision) ( flutter/engine#45758 )
...
https://skia.googlesource.com/skia.git/+log/29e7723e1f8c..2ec12c767ec7
2023-09-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 021af1a1b94f to 19ec9904dd95 (5 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com ,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-13 05:48:14 +00:00
skia-flutter-autoroll
92f75e5f6d
Roll Skia from b7d77eb2a9d3 to 29e7723e1f8c (2 revisions) ( flutter/engine#45755 )
...
https://skia.googlesource.com/skia.git/+log/b7d77eb2a9d3..29e7723e1f8c
2023-09-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 0c842c7bcdc2 to 01dab5ab1737 (6 revisions)
2023-09-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 021af1a1b94f to 19ec9904dd95
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com ,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-13 03:51:20 +00:00
skia-flutter-autoroll
84a2bd4b0f
Roll Skia from 2d295711337c to b7d77eb2a9d3 (2 revisions) ( flutter/engine#45753 )
...
https://skia.googlesource.com/skia.git/+log/2d295711337c..b7d77eb2a9d3
2023-09-12 johnstiles@google.com Remove DawnCompileSPIRVShaderModule.
2023-09-12 johnstiles@google.com Fix garbage results when using Dawn with software rendering.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com ,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-13 03:13:23 +00:00
Zachary Anderson
f66e033369
Revert "Lazily allocate RasterCacheItems only when caching is enabled" ( flutter/engine#45734 )
...
Reverts flutter/engine#45211
b/298583505
2023-09-12 23:46:38 +00:00
Harry Terkelsen
6e786534e3
Revert "Use a single OffscreenCanvas for rendering in CanvasKit" ( flutter/engine#45744 )
...
Reverts flutter/engine#42672
This is causing breakages in the Framework roller on golden tests: https://github.com/flutter/flutter/pull/134583
2023-09-12 23:42:48 +00:00
Chinmay Garde
6631e24259
[Impeller] Patch the compiler to account for subpass inputs and PSO metadata. ( flutter/engine#45739 )
...
Towards https://github.com/flutter/flutter/issues/128911
Drive by fixes https://github.com/flutter/flutter/issues/123795
2023-09-12 23:39:16 +00:00
Chinmay Garde
446d776588
[Impeller] Fix swapchain recreation for non-polling cases. ( flutter/engine#45740 )
...
Earlier, there was no recovery from vk::Result::eSuboptimalKHR. This made the playground be stuck with a swapchain image size of 1x1 with suboptimal error code on acquisition indefinitely.
Towards fixing the playgrounds. There are still some validation errors.
2023-09-12 23:14:22 +00:00
skia-flutter-autoroll
89672536e2
Roll Fuchsia Mac SDK from QgAHx3BtJfN3TmodS... to UCa49z8fu0hD9cypj... ( flutter/engine#45738 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-12 22:23:20 +00:00
Chris Yang
7774d22632
[ios] upload extension safe artifacts ( flutter/engine#45664 )
...
Uploads the artifacts for extension safe build. These artifacts need to be codesigned.
part of https://github.com/flutter/flutter/issues/124291
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-09-12 22:20:14 +00:00
gaaclarke
9a1606cb17
Added test to assert the vulkan embedder threadsafe vkqueue usage ( flutter/engine#45732 )
...
fixes https://github.com/flutter/flutter/issues/133933
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-09-12 21:52:10 +00:00
Chinmay Garde
cf31c43c78
[Impeller] If validations are enabled but not found, still create the VK context. ( flutter/engine#45674 )
...
Fixes https://github.com/flutter/flutter/issues/131714
2023-09-12 21:30:04 +00:00
skia-flutter-autoroll
f49eb6e0aa
Roll Skia from 211d63b1e1f5 to 2d295711337c (7 revisions) ( flutter/engine#45729 )
...
https://skia.googlesource.com/skia.git/+log/211d63b1e1f5..2d295711337c
2023-09-12 bungeman@google.com Revert "Make SKP deserialize null instead of PNG images by default."
2023-09-12 bungeman@google.com Revert "[skicu] Use cache and respect locale"
2023-09-12 michaelludwig@google.com Revert "Use over-sampling to avoid branches in 2D blur effect"
2023-09-12 kjlubick@google.com Handle new colortype
2023-09-12 nicolettep@google.com [graphite] Add Vulkan BackendTexture creation and deletion methods; unit tests
2023-09-12 michaelludwig@google.com Stop using SkSpecialSurface in ImageFilterTest
2023-09-12 michaelludwig@google.com Stop using SkSpecialSurface in SkSpecialImageTest
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com ,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-12 20:46:46 +00:00
Harry Terkelsen
9832541563
Use a single OffscreenCanvas for rendering in CanvasKit ( flutter/engine#42672 )
...
This changes CanvasKit's rendering model. Previously, each overlay
canvas induced a new WebGL context and SkSurface. Now, there is only
ever one SkSurface (backed by an OffscreenCanvas), and the overlays are
HTML canvases with a bitmaprenderer context. The content is rendered
using the SkSurface and passed to the overlays using
`transferToImageBitmap`. This way, there is only one WebGL context in
the lifetime of the app.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-09-12 13:07:48 -07:00
skia-flutter-autoroll
9d02d22433
Manual roll Dart SDK from 43d4b1373788 to 1ee7ef8bbc65 (6 revisions) ( flutter/engine#45726 )
...
Manual roll requested by zra@google.com
https://dart.googlesource.com/sdk.git/+log/43d4b1373788..1ee7ef8bbc65
2023-09-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-140.0.dev
2023-09-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-139.0.dev
2023-09-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-138.0.dev
2023-09-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-137.0.dev
2023-09-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-136.0.dev
2023-09-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-135.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com ,dart-vm-team@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-12 19:58:57 +00:00
Chris Yang
c2976f7ad8
Reland "Build iOS unittest target in unopt builds" ( #44356 )"" ( #45346 )" ( flutter/engine#45519 )
...
Reland https://github.com/flutter/engine/pull/44821
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-09-12 19:17:01 +00:00
skia-flutter-autoroll
c7dfd89190
Roll Skia from a4f8f5177c8b to 211d63b1e1f5 (2 revisions) ( flutter/engine#45724 )
...
https://skia.googlesource.com/skia.git/+log/a4f8f5177c8b..211d63b1e1f5
2023-09-12 brianosman@google.com Add basic support for kRGBA_10x6_SkColorType
2023-09-12 michaelludwig@google.com Use over-sampling to avoid branches in 2D blur effect
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com ,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-12 19:04:48 +00:00
Jackson Gardner
b11ff71dd3
Fix JS interop signatures to use only JS types. ( flutter/engine#45668 )
...
This prepares for some upcoming changes to dart2js which will be more strict about what types can be used in a JS interop declaration.
2023-09-12 19:03:08 +00:00
Chris Yang
911433bc29
[ios] Fix testDeallocated failing locally. ( flutter/engine#45663 )
...
Moving the code block to autorelease pool to ensure the FlutterEngine is released in the test.
Fixes: https://github.com/flutter/flutter/issues/134388
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-09-12 18:43:40 +00:00
Chris Yang
4e1274df93
[iOS] move arm64 builds to arm machines ( flutter/engine#45721 )
...
Some builds in ci can happen on arm machines, see https://github.com/flutter/engine/pull/45664/files#r1322197862
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-09-12 18:38:47 +00:00
skia-flutter-autoroll
7c145d1621
Roll Skia from 7cafb622ee7f to a4f8f5177c8b (1 revision) ( flutter/engine#45719 )
...
https://skia.googlesource.com/skia.git/+log/7cafb622ee7f..a4f8f5177c8b
2023-09-12 nicolettep@google.com [graphite] Remove dependency on dynamic rendering extension
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com ,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-12 18:09:14 +00:00
skia-flutter-autoroll
fca5d08293
Roll Fuchsia Linux SDK from vGleXqh2SRUNJM7JN... to MWWrSP9mSVlGIOaDo... ( flutter/engine#45718 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-12 17:44:46 +00:00
skia-flutter-autoroll
378dd1603f
Roll Skia from 438ec87ea2be to 7cafb622ee7f (1 revision) ( flutter/engine#45716 )
...
https://skia.googlesource.com/skia.git/+log/438ec87ea2be..7cafb622ee7f
2023-09-12 bungeman@google.com [skicu] Use cache and respect locale
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com ,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-12 17:20:13 +00:00
Matan Lurey
0a8b89af42
[Impeller] Make CreateMockVulkanContext() thread-safe ( flutter/engine#45687 )
...
I started using `CreateMockVulkanContext()` in
https://github.com/flutter/engine/pull/45654 , and discovered that it was
not thread-safe. This PR does a little bit of refactoring/TLC to ensure
that functions and buffers can be accessed across threads (like the
_real_ `ContextVK`).
The attached test (_test for a test fixture, hoorah!_) fails
consistently before the changes, and passes after. Note that if you try
testing this with `--gtest_repeat=10000` (at least that's the threshold
for me), it'll fail - that's actually due to
https://github.com/flutter/flutter/issues/134482 which in turn is being
fixed in https://github.com/flutter/engine/pull/45686 .
(Unblocks https://github.com/flutter/flutter/issues/133198 )
---------
Co-authored-by: gaaclarke <30870216+gaaclarke@users.noreply.github.com>
2023-09-12 09:43:53 -07:00
gaaclarke
296e9102a0
[Impeller] moved validation layers on by default logic to gni scripts ( flutter/engine#45682 )
...
fixes https://github.com/flutter/flutter/issues/134460
Test will happen in the flutter repo as a result of
https://github.com/flutter/flutter/issues/134175
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-09-12 09:41:55 -07:00
skia-flutter-autoroll
30410af5f6
Roll Skia from f3f0cab7efd0 to 438ec87ea2be (1 revision) ( flutter/engine#45714 )
...
https://skia.googlesource.com/skia.git/+log/f3f0cab7efd0..438ec87ea2be
2023-09-12 johnstiles@google.com Remove SPIR-V option from Graphite Dawn backend.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com ,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-12 16:37:16 +00:00
skia-flutter-autoroll
5413a40713
Roll Skia from 7e9b94634911 to f3f0cab7efd0 (1 revision) ( flutter/engine#45710 )
...
https://skia.googlesource.com/skia.git/+log/7e9b94634911..f3f0cab7efd0
2023-09-12 cmumford@google.com Update IntelIrisXe gpu driver to 8086:9a49-31.0.101.4575
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com ,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-12 15:45:51 +00:00
Derek Xu
6a088c7a02
Add trace-to-file switch ( flutter/engine#45553 )
2023-09-12 11:35:10 -04:00
skia-flutter-autoroll
2d74f5f7de
Roll Skia from a1ff98bebf89 to 7e9b94634911 (2 revisions) ( flutter/engine#45707 )
...
https://skia.googlesource.com/skia.git/+log/a1ff98bebf89..7e9b94634911
2023-09-12 kjlubick@google.com Disable legacy GrDirectContext methods for Flutter
2023-09-12 johnstiles@google.com Add support for the pixel_local modifier to WGSL.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com ,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-12 15:06:04 +00:00
skia-flutter-autoroll
de4a4450af
Roll Skia from 55c9c377f0b0 to a1ff98bebf89 (1 revision) ( flutter/engine#45706 )
...
https://skia.googlesource.com/skia.git/+log/55c9c377f0b0..a1ff98bebf89
2023-09-12 armansito@google.com [graphite][dawn] Use SkSL WGSL backend with compute pipelines
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com ,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-12 14:14:22 +00:00
skia-flutter-autoroll
2f3bf11a1a
Roll Skia from 8d11fcb3068a to 55c9c377f0b0 (1 revision) ( flutter/engine#45705 )
...
https://skia.googlesource.com/skia.git/+log/8d11fcb3068a..55c9c377f0b0
2023-09-12 kjlubick@google.com Make SKP deserialize null instead of PNG images by default.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com ,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-12 13:21:05 +00:00
skia-flutter-autoroll
9c168da7ec
Roll Skia from 5b94fc73a36e to 8d11fcb3068a (1 revision) ( flutter/engine#45703 )
...
https://skia.googlesource.com/skia.git/+log/5b94fc73a36e..8d11fcb3068a
2023-09-12 bungeman@google.com [iwyu] Remove mapping from string.h to string
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com ,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-12 12:33:16 +00:00
skia-flutter-autoroll
a1e84f5758
Roll Skia from 72e5b5c8d5f0 to 5b94fc73a36e (1 revision) ( flutter/engine#45701 )
...
https://skia.googlesource.com/skia.git/+log/72e5b5c8d5f0..5b94fc73a36e
2023-09-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from d3141523dcc2 to 0c842c7bcdc2 (14 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com ,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-12 11:24:10 +00:00
skia-flutter-autoroll
4cf021aed5
Roll Fuchsia Mac SDK from fSmVaZwp41ZGp5hKn... to QgAHx3BtJfN3TmodS... ( flutter/engine#45700 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-12 09:44:29 +00:00
skia-flutter-autoroll
ad84733f53
Roll Skia from 9f92b15074a6 to 72e5b5c8d5f0 (1 revision) ( flutter/engine#45696 )
...
https://skia.googlesource.com/skia.git/+log/9f92b15074a6..72e5b5c8d5f0
2023-09-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 1f1b5ee82e66 to ec89b1a2bd88 (7 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jmbetancourt@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-12 07:31:41 +00:00
skia-flutter-autoroll
2c8d5ea485
Roll Skia from ba5d081cd448 to 9f92b15074a6 (1 revision) ( flutter/engine#45695 )
...
https://skia.googlesource.com/skia.git/+log/ba5d081cd448..9f92b15074a6
2023-09-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 9b300a6d6747 to 4e40d502c440 (2 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jmbetancourt@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-12 06:17:04 +00:00
dependabot[bot]
06a9be6cb2
Bump actions/upload-artifact from 3.1.2 to 3.1.3 ( flutter/engine#45694 )
...
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact ) from 3.1.2 to 3.1.3.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/upload-artifact/releases ">actions/upload-artifact's releases</a>.</em></p>
<blockquote>
<h2>v3.1.3</h2>
<h2>What's Changed</h2>
<ul>
<li>chore(github): remove trailing whitespaces by <a href="https://github.com/ljmf00 "><code>@âljmf00</code></a> in <a href="https://redirect.github.com/actions/upload-artifact/pull/313 ">actions/upload-artifact#313</a></li>
<li>Bump <code>@âactions/artifact</code> version to v1.1.2 by <a href="https://github.com/bethanyj28 "><code>@âbethanyj28</code></a> in <a href="https://redirect.github.com/actions/upload-artifact/pull/436 ">actions/upload-artifact#436</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/upload-artifact/compare/v3...v3.1.3 ">https://github.com/actions/upload-artifact/compare/v3...v3.1.3 </a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="a8a3f3ad30https://redirect.github.com/actions/upload-artifact/issues/436 ">#436</a> from bethanyj28/main</li>
<li><a href="7b48769c0366630398df55e76b779d65d862660ahttps://redirect.github.com/actions/upload-artifact/issues/313 ">#313</a>)</li>
<li>See full diff in <a href="0b7f8abb15...a8a3f3ad30https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/upload-artifact&package-manager=github_actions&previous-version=3.1.2&new-version=3.1.3 )](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2023-09-12 06:15:04 +00:00
skia-flutter-autoroll
9249e1637f
Roll Skia from 62aa41ee8135 to ba5d081cd448 (3 revisions) ( flutter/engine#45692 )
...
https://skia.googlesource.com/skia.git/+log/62aa41ee8135..ba5d081cd448
2023-09-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 4f21ce567dee to 021af1a1b94f (9 revisions)
2023-09-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 656255591ca4 to d00d8da6f58d (8 revisions)
2023-09-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 254dc037bc19 to 021af1a1b94f
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jmbetancourt@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-12 05:41:16 +00:00
skia-flutter-autoroll
b8bc658e7e
Roll Fuchsia Linux SDK from cUKimo52R-2EIfHh5... to vGleXqh2SRUNJM7JN... ( flutter/engine#45691 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-12 04:59:20 +00:00
skia-flutter-autoroll
781167241b
Roll Skia from c4e94d5febdc to 62aa41ee8135 (2 revisions) ( flutter/engine#45690 )
...
https://skia.googlesource.com/skia.git/+log/c4e94d5febdc..62aa41ee8135
2023-09-12 johnstiles@google.com Add new modifier `pixel_local` to SkSL.
2023-09-12 johnstiles@google.com Limit sk_Clockwise workaround to Vulkan + Ganesh only.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jmbetancourt@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-12 04:53:25 +00:00
Matan Lurey
e3a562f6d3
[Impeller] Fix thread leak in ResourceManagerVK. ( flutter/engine#45686 )
...
Fixes https://github.com/flutter/flutter/issues/134482 .
I wish I knew how to create the thread in `::Create()`, but given the
constructor is private I feel less bad about reverting part of
https://github.com/flutter/engine/pull/45474 . Added a test that
consistently fails before this PR and passes after.
(Unblocks https://github.com/flutter/flutter/issues/133198 )
2023-09-11 20:57:07 -07:00
Matej Knopp
e295cca68f
[Web] Properly report inverted selection ( flutter/engine#44806 )
...
Fixes https://github.com/flutter/flutter/issues/131906
*List which issues are fixed by this PR. You must list at least one issue.*
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-09-12 01:23:21 +00:00
Jason Simmons
d097f5d052
Roll libwebp to 1.3.1 ( flutter/engine#45675 )
2023-09-12 00:56:21 +00:00
skia-flutter-autoroll
3aeb7ba0c0
Roll Skia from 0b8d2203ab35 to c4e94d5febdc (5 revisions) ( flutter/engine#45679 )
...
https://skia.googlesource.com/skia.git/+log/0b8d2203ab35..c4e94d5febdc
2023-09-11 kjlubick@google.com Manually roll Dawn and make use of Tint Bazel rules.
2023-09-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from f3528c5f4a7d to d3141523dcc2 (9 revisions)
2023-09-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll debugger-app-base from 3ec84e220b1d to 5b191a5ec3d1
2023-09-11 michaelludwig@google.com Rename base device to root device in SkCanvas
2023-09-11 jvanverth@google.com [ganesh] Add colorspace conversion for color emoji
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jmbetancourt@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-11 23:18:04 +00:00
Chinmay Garde
2034b6688c
Pipe VMA asserts to FML. ( flutter/engine#45661 )
...
These are still only enabled in unopt modes (we can tweak this later). Asserts sometimes may not get piped to the loggers Flutter engine developers usually use. This now brings assertions back in the control of the engine.
2023-09-11 22:58:20 +00:00
skia-flutter-autoroll
8f46ae7cc3
Roll Skia from e6225224fb4e to 0b8d2203ab35 (9 revisions) ( flutter/engine#45671 )
...
https://skia.googlesource.com/skia.git/+log/e6225224fb4e..0b8d2203ab35
2023-09-11 cmumford@google.com [debugger] ship release version of CanvasKit
2023-09-11 herb@google.com Fix math for lessThanAt
2023-09-11 weiyuhuang@google.com Revert "Add a few more UTF-16 paragraph APIs"
2023-09-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from 22f26af5286f to 3d8e63c59919
2023-09-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll debugger-app-base from f61850f9ca4f to 3ec84e220b1d
2023-09-11 johnstiles@google.com Remove duplicated WGSL unit test.
2023-09-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll shaders-base from 6246ccdc88e0 to 45116d485d17
2023-09-11 johnstiles@google.com Implement sk_SampleMask and sk_SampleMaskIn in SPIR-V.
2023-09-11 johnstiles@google.com Implement sk_SampleMask and sk_SampleMaskIn in Metal.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jmbetancourt@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-11 22:31:14 +00:00
yaakovschectman
aaea38144b
Merge Window into FlutterWindow ( flutter/engine#45542 )
...
Merge abstract base class `Window` into concrete derived class
`FlutterWindow` to simplify future development.
https://github.com/flutter/flutter/issues/132260
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
---------
Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
2023-09-11 17:59:47 -04:00
skia-flutter-autoroll
533e4e55fe
Roll Fuchsia Mac SDK from 7Zk_dvFh301kgQte4... to fSmVaZwp41ZGp5hKn... ( flutter/engine#45665 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-11 21:07:27 +00:00
Jackson Gardner
167013fb08
Revert "Remove some of our hacks around JSPromise now that we have better APIs." ( flutter/engine#45660 )
...
Reverts flutter/engine#45591
This is somehow causing some issues with the hot reload tests and blocking engine -> framework rolls. See https://github.com/flutter/flutter/pull/134455
2023-09-11 20:43:59 +00:00
skia-flutter-autoroll
55bff8baf4
Roll Skia from 3ed290acb65f to e6225224fb4e (2 revisions) ( flutter/engine#45658 )
...
https://skia.googlesource.com/skia.git/+log/3ed290acb65f..e6225224fb4e
2023-09-11 weiyuhuang@google.com Add a few more UTF-16 paragraph APIs
2023-09-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll jsfiddle-base from 2e999b8eedf7 to 420bf03c7a80
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jmbetancourt@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-11 19:21:08 +00:00
Kevin Lubick
b353c1fbe4
Update skwasm build to use safer flush call ( flutter/engine#45652 )
...
Follow-up to https://github.com/flutter/engine/pull/45644
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-09-11 13:55:05 -04:00
