skia-flutter-autoroll
89fb5205ea
Roll ANGLE from 17c4741d70dd to 9666d4d5f7c8 (1 revision) ( flutter/engine#45453 )
...
17c4741d70..9666d4d5f7lexa.knyazev@gmail.com Disallow dynamic indexing of SecondaryFragData in WebGL 2.0
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC flutter-engine@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-05 16:50:09 +00:00
skia-flutter-autoroll
c0dbfcf745
Roll Skia from 055b26152483 to d8ea902500a3 (1 revision) ( flutter/engine#45448 )
...
https://skia.googlesource.com/skia.git/+log/055b26152483..d8ea902500a3
2023-09-05 bungeman@google.com Update DWriteCore to 1.4
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-05 15:48:14 +00:00
skia-flutter-autoroll
6142a14b85
Roll ANGLE from e72efa276c45 to 17c4741d70dd (1 revision) ( flutter/engine#45449 )
...
e72efa276c..17c4741d70lexa.knyazev@gmail.com Metal: Disable blending for masked out attachments
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC flutter-engine@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-05 15:44:22 +00:00
skia-flutter-autoroll
76671fae60
Roll Fuchsia Mac SDK from qe_q1aYCmE0eC-2Yz... to bHw1LzoikQJthLkTE... ( flutter/engine#45447 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-05 15:19:05 +00:00
skia-flutter-autoroll
e5a4f45dd8
Roll Skia from 9ef0225b5f8a to 055b26152483 (1 revision) ( flutter/engine#45446 )
...
https://skia.googlesource.com/skia.git/+log/9ef0225b5f8a..055b26152483
2023-09-05 johnstiles@google.com Fix external-texture assertion discovered by the fuzzer.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-05 15:01:20 +00:00
skia-flutter-autoroll
853bf3e711
Roll ANGLE from b62216047112 to e72efa276c45 (1 revision) ( flutter/engine#45443 )
...
b622160471..e72efa276cangle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 4b7a5f2a3522 to f2f4bb6f20ec (5 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC flutter-engine@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-05 11:27:21 +00:00
skia-flutter-autoroll
5fb8d11ce5
Roll Skia from 7d0e33e32427 to 9ef0225b5f8a (1 revision) ( flutter/engine#45442 )
...
https://skia.googlesource.com/skia.git/+log/7d0e33e32427..9ef0225b5f8a
2023-09-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 4b7a5f2a3522 to f2f4bb6f20ec (5 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-05 10:40:34 +00:00
skia-flutter-autoroll
6a8d8a898c
Roll ANGLE from e691a4edb19a to b62216047112 (1 revision) ( flutter/engine#45441 )
...
e691a4edb1..b622160471angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 97f14c8287da to e89c33139c50 (340 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC flutter-engine@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-05 09:12:23 +00:00
skia-flutter-autoroll
9cd820c20b
Roll Skia from 8206402f3c35 to 7d0e33e32427 (2 revisions) ( flutter/engine#45440 )
...
https://skia.googlesource.com/skia.git/+log/8206402f3c35..7d0e33e32427
2023-09-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from ebf1e7163216 to e691a4edb19a (3 revisions)
2023-09-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 959bb251c386 to f5590cb5133d (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,armansito@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-05 07:36:40 +00:00
skia-flutter-autoroll
52cca44ce2
Roll ANGLE from ab9bbb9b11b3 to e691a4edb19a (1 revision) ( flutter/engine#45437 )
...
ab9bbb9b11..e691a4edb1ynovikov@chromium.org Delete obsolete VUID
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC aaclarke@google.com ,flutter-engine@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-05 03:23:20 +00:00
skia-flutter-autoroll
784088606a
Roll Fuchsia Mac SDK from A82pOZ3-NNgfJ2Da7... to qe_q1aYCmE0eC-2Yz... ( flutter/engine#45436 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-05 02:43:26 +00:00
skia-flutter-autoroll
aad1c31bf4
Roll Dart SDK from 671cf059e4b6 to 43d4b1373788 (2 revisions) ( flutter/engine#45435 )
...
https://dart.googlesource.com/sdk.git/+log/671cf059e4b6..43d4b1373788
2023-09-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-134.0.dev
2023-09-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-133.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-04 23:55:27 +00:00
skia-flutter-autoroll
9d4e113c50
Roll Skia from c9d527e6b535 to 8206402f3c35 (1 revision) ( flutter/engine#45434 )
...
https://skia.googlesource.com/skia.git/+log/c9d527e6b535..8206402f3c35
2023-09-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 501ee2809482 to 4b7a5f2a3522 (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,armansito@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-04 21:53:18 +00:00
Robert Ancell
e0006ade23
Fix building on Pango 1.49.4 ( flutter/engine#45098 )
...
This version added the autoptr macros which we no longer need to define.
https://github.com/flutter/flutter/issues/132881
2023-09-05 08:03:28 +12:00
skia-flutter-autoroll
ef57308f58
Roll Dart SDK from a5c7102af509 to 671cf059e4b6 (1 revision) ( flutter/engine#45429 )
...
https://dart.googlesource.com/sdk.git/+log/a5c7102af509..671cf059e4b6
2023-09-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-132.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-04 16:02:24 +00:00
skia-flutter-autoroll
4f08052080
Roll Fuchsia Mac SDK from ynBQWN3XpE2JvSlfd... to A82pOZ3-NNgfJ2Da7... ( flutter/engine#45428 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-04 14:04:28 +00:00
skia-flutter-autoroll
f744e4b37b
Roll ANGLE from 1fb536394148 to ab9bbb9b11b3 (1 revision) ( flutter/engine#45426 )
...
1fb5363941..ab9bbb9b11angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 15007d22798e to 4b7a5f2a3522 (5 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC aaclarke@google.com ,flutter-engine@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-04 11:45:22 +00:00
skia-flutter-autoroll
cf3a5b9ecb
Roll Skia from 5eaf624077b5 to c9d527e6b535 (1 revision) ( flutter/engine#45425 )
...
https://skia.googlesource.com/skia.git/+log/5eaf624077b5..c9d527e6b535
2023-09-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 33e34e073cab to 501ee2809482 (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,armansito@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-04 09:01:30 +00:00
skia-flutter-autoroll
5776cd5809
Roll ANGLE from ebf1e7163216 to 1fb536394148 (1 revision) ( flutter/engine#45424 )
...
ebf1e71632..1fb5363941angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 613933d34730 to 97f14c8287da (765 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC aaclarke@google.com ,flutter-engine@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-04 08:37:09 +00:00
skia-flutter-autoroll
6db0a411ce
Roll Skia from 906dcd219276 to 5eaf624077b5 (1 revision) ( flutter/engine#45423 )
...
https://skia.googlesource.com/skia.git/+log/906dcd219276..5eaf624077b5
2023-09-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 7c3c7b7b9f01 to ebf1e7163216 (11 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,armansito@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-04 07:29:24 +00:00
skia-flutter-autoroll
0d27bf9ccf
Roll Skia from 4d0501380011 to 906dcd219276 (1 revision) ( flutter/engine#45422 )
...
https://skia.googlesource.com/skia.git/+log/4d0501380011..906dcd219276
2023-09-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 959bb251c386 to f5590cb5133d
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,armansito@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-04 06:15:14 +00:00
skia-flutter-autoroll
ee1a541fd7
Roll Skia from 15f77147a3ec to 4d0501380011 (1 revision) ( flutter/engine#45421 )
...
https://skia.googlesource.com/skia.git/+log/15f77147a3ec..4d0501380011
2023-09-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 2b76b0e00861 to 959bb251c386 (2 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,armansito@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-04 05:33:32 +00:00
skia-flutter-autoroll
00ded460ec
Roll Fuchsia Mac SDK from p56hmQk2lEbN-VwEg... to ynBQWN3XpE2JvSlfd... ( flutter/engine#45420 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-04 01:25:28 +00:00
skia-flutter-autoroll
8868ebd434
Roll Fuchsia Mac SDK from E7CUB2EEOm7ShBUib... to p56hmQk2lEbN-VwEg... ( flutter/engine#45419 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-03 12:46:23 +00:00
skia-flutter-autoroll
af49b97f43
Roll Fuchsia Mac SDK from MesZPNdj-uw8VdCyV... to E7CUB2EEOm7ShBUib... ( flutter/engine#45417 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-03 00:06:29 +00:00
skia-flutter-autoroll
1c1b8ed7db
Roll Skia from 2d8849f9f0cc to 15f77147a3ec (1 revision) ( flutter/engine#45414 )
...
https://skia.googlesource.com/skia.git/+log/2d8849f9f0cc..15f77147a3ec
2023-09-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 8643aba2c123 to 33e34e073cab (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-02 12:54:24 +00:00
skia-flutter-autoroll
ff5ee36df0
Roll Fuchsia Mac SDK from OF4TS05qlWCjukWw6... to MesZPNdj-uw8VdCyV... ( flutter/engine#45413 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-02 11:32:22 +00:00
Tong Mu
f0eb04206a
Remove --disable-service-auth-codes ( flutter/engine#45356 )
...
Discovered by a leakage as described in https://github.com/flutter/flutter/issues/133824 , this arg has likely been removed by Dart. Removing this arg eliminates the leakage warning.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-09-02 06:06:10 +00:00
Brandon DeRosier
7f84662294
[Impeller] Import cstring for memcpy. ( flutter/engine#45408 )
...
Fixes builds against some STLs (detected in impeller-cmake [ubuntu
build](https://github.com/bdero/impeller-cmake/actions/runs/6020031888/job/16330726595 )).
2023-09-01 22:11:02 -07:00
skia-flutter-autoroll
47500f589f
Roll Dart SDK from cdf1ce0c6d7e to a5c7102af509 (1 revision) ( flutter/engine#45412 )
...
https://dart.googlesource.com/sdk.git/+log/cdf1ce0c6d7e..a5c7102af509
2023-09-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-131.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-02 04:42:22 +00:00
skia-flutter-autoroll
2e906f5682
Roll ANGLE from 179bd7762ffa to ebf1e7163216 (1 revision) ( flutter/engine#45411 )
...
179bd7762f..ebf1e71632syoussefi@chromium.org Cache transform feedback varying names in the executable
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC aaclarke@google.com ,flutter-engine@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-02 03:26:54 +00:00
Tong Mu
a443c671d0
Remove deprecated MOCK_METHODx calls ( flutter/engine#45307 )
...
The issue that blocks these mocking methods have been resolved.
However, there is [one more mention of this issue in `run_tests.py`](1410d8beaa/testing/run_tests.py (L400)https://github.com/flutter/engine/pull/19033/files#diff-521d7c59c3f721b259f094c760c2613e16e889b0f24702280924466109e3b0b0R137 ).
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-09-02 01:42:21 +00:00
Jonah Williams
17b261d8f5
[Impeller] Better demonstrate blur and draw picture? ( flutter/engine#45388 )
...
The current goldens are changing a lot, this should be stabler. though not sure if it looks quite right.
2023-09-02 01:01:06 +00:00
Jonah Williams
be8bb23633
[Impeller] Make paths externally immutable, update all tests to use PathBuilder to create Path. ( flutter/engine#45393 )
...
This is a design problem in the Flutter API, that in general you can't assume a Path hasn't changed from the last time you used it. We're so close, so just move the mutation methods to PathBuilder :)
Fixes https://github.com/flutter/flutter/issues/133880
2023-09-02 01:01:04 +00:00
skia-flutter-autoroll
ad3b5cf1c8
Roll ANGLE from 962fdf7b7882 to 179bd7762ffa (1 revision) ( flutter/engine#45409 )
...
962fdf7b78..179bd7762flexa.knyazev@gmail.com GL: Adjust disableRenderSnorm condition
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC aaclarke@google.com ,flutter-engine@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-02 00:57:55 +00:00
Jim Graham
00c1242837
Cull the RTree bounds when they are forwarded in DrawDisplayList ( flutter/engine#45358 )
...
Fixes https://github.com/flutter/flutter/issues/133437
With this fix, the [benchmarks](https://github.com/flutter/flutter/pull/133434 ) for pictures with huge bounds become runnable under more conditions. Currently those benchmarks only run on platforms where we don't run into this issue. The performance on those platforms/conditions will not change much, but with this fix we can run them on Impeller and add a variant that has a platform view on the display.
2023-09-02 00:53:19 +00:00
skia-flutter-autoroll
3cf7d6052c
Roll Skia from fedff79a6afc to 2d8849f9f0cc (3 revisions) ( flutter/engine#45407 )
...
https://skia.googlesource.com/skia.git/+log/fedff79a6afc..2d8849f9f0cc
2023-09-01 armansito@google.com [graphite][compute] Dynamically assemble resource declarations from snippets
2023-09-01 armansito@google.com [graphite][compute] Combined "SampledTexture" resource
2023-09-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 15007d22798e to 8643aba2c123 (2 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-02 00:23:20 +00:00
Jonah Williams
26d612bbf4
[impeller] premultiply vertices colors. ( flutter/engine#45406 )
...
Lost this after the transition.
### After
### Before
2023-09-02 00:18:05 +00:00
skia-flutter-autoroll
26ce6e9354
Roll ANGLE from 6a09e41ce6ea to 962fdf7b7882 (224 revisions) ( flutter/engine#45400 )
...
Roll ANGLE from 6a09e41ce6ea to 962fdf7b7882 (224 revisions)
6a09e41ce6..962fdf7b78cclao@google.com Add templated BinaryOutputStream::writeVector and writeStruct
2023-09-01 mark@lunarg.com Tests: Limit CapturedTest to Vulkan backend
2023-09-01 romanl@google.com Traces: temporary patch to log zlib message on failure
2023-09-01 angle-autoroll@skia-public.iam.gserviceaccount.com Roll VK-GL-CTS from a745d5c29c56 to 385ae8bed1f9 (7 revisions)
2023-09-01 romanl@google.com Revert "Gold tests: add temporary logging of angledata hashes"
2023-09-01 romanl@google.com Revert "Traces: add temporary debug info to LoadBinaryData"
2023-09-01 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 988fe1c529b0 to 15007d22798e (6 revisions)
2023-09-01 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from f59e85c23631 to 613933d34730 (499 revisions)
2023-09-01 lexa.knyazev@gmail.com Validate missing fragment outputs for dual-source blending
2023-09-01 cclao@google.com Add more test for GL_SRGB8 format
2023-08-31 ynovikov@chromium.org Skip 2 DrawCallPerfBenchmark tests on Pixel 6
2023-08-31 angle-autoroll@skia-public.iam.gserviceaccount.com Manual roll vulkan-deps from a446c6320b6b to 988fe1c529b0 (28 revisions)
2023-08-31 syoussefi@chromium.org Move transform feedback buffer mode to program state
2023-08-31 angle-autoroll@skia-public.iam.gserviceaccount.com Manual roll Chromium from 90200ab2e92a to f59e85c23631 (744 revisions)
2023-08-31 syoussefi@chromium.org Clean up InfoLog usage during link
2023-08-31 jiawei.shao@intel.com D3D11: Fix register index of read-only storage images
2023-08-31 syoussefi@chromium.org Remove link results from program hash
2023-08-31 ynovikov@chromium.org Don't sync reclient on linux arm64
2023-08-31 romanl@google.com Cleanup: remove tests.csv
2023-08-31 steven@uplinklabs.net d3d11: avoid exit-time-destructor warning
2023-08-31 geofflang@chromium.org Handle Qualcomm's Windows vendor ID.
2023-08-31 jiawei.shao@intel.com D3D11: Fix the compilation of vertex shader with storage image
2023-08-31 romanl@google.com Tests: EGLMakeCurrentPerfTest loads GLES
2023-08-31 zzyiwei@chromium.org Vulkan: disallow pbo copies when offset is incompatible with vulkan
2023-08-30 cclao@google.com Add GL_RGBX8_SRGB_ANGLEX and GL_BGRX8_SRGB_ANGLEX formats
2023-08-30 geofflang@chromium.org Check that postTask is non-null before calling it.
2023-08-30 sokcevic@chromium.org [DEPS] Use Var instead of {} in DEPS
2023-08-30 jonahr@google.com Metal: Fix dropped out arguments from functions with many args.
2023-08-30 m.maiya@samsung.com Vulkan: Support EGL_EXT_gl_colorspace_bt2020
2023-08-30 phanquangminh217@gmail.com Add support for EGL_MESA_platfrom_surfaceless extension
2023-08-30 phanquangminh217@gmail.com egl: Fix device fallback if native display eglInitialize fails
2023-08-30 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from e2ad2e99dc98 to 90200ab2e92a (420 revisions)
2023-08-30 syoussefi@chromium.org Move pre-link program state to ProgramState
2023-08-30 lexa.knyazev@gmail.com Validate active draw buffers for dual-source blending
2023-08-30 syoussefi@chromium.org Vulkan: Stop passing both ProgramExecutable and ...Vk around
2023-08-30 syoussefi@chromium.org Metal: Move program state to ProgramExecutableMtl
2023-08-30 syoussefi@chromium.org GL: Move program state to ProgramExecutableGL
2023-08-30 syoussefi@chromium.org Move left over link state to ProgramExecutable
2023-08-29 geofflang@chromium.org Return the vendor string as hex when it is unknown.
2023-08-29 mikes@lunarg.com Add build overrides for Vulkan Utility Libraries
2023-08-29 syoussefi@chromium.org D3D: Move program state to ProgramExecutableD3D
2023-08-29 m.maiya@samsung.com EGL: Update EGL headers
2023-08-29 syoussefi@chromium.org Make ProgramExecutableImpl managed by ProgramExecutable
2023-08-29 angle-autoroll@skia-public.iam.gserviceaccount.com Manual roll Chromium from 2f13938f5894 to e2ad2e99dc98 (165 revisions)
2023-08-29 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from d213632452c2 to a446c6320b6b (9 revisions)
2023-08-29 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 92b28610c8f3 to 2f13938f5894 (510 revisions)
...
2023-09-01 23:57:51 +00:00
skia-flutter-autoroll
b6ad1bc8a5
Roll Skia from 22ae23891e8e to fedff79a6afc (1 revision) ( flutter/engine#45405 )
...
https://skia.googlesource.com/skia.git/+log/22ae23891e8e..fedff79a6afc
2023-09-01 johnstiles@google.com Move assertion about samplers out of SPIRVCodeGenerator.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-01 23:37:06 +00:00
gaaclarke
d23968a976
[Impeller] turned on validations for all debug builds ( flutter/engine#45350 )
...
fixes https://github.com/flutter/flutter/issues/133794
This adds the following shared libraries to the flutter.jar for debug builds on arm64:
```
lib/arm64-v8a/libVkLayer_khronos_validation.so
lib/arm64-v8a/libc++_shared.so
```
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-09-01 23:29:22 +00:00
skia-flutter-autoroll
d4a133c8bf
Roll Fuchsia Mac SDK from sk7JBGzW1Jw10Wy-T... to OF4TS05qlWCjukWw6... ( flutter/engine#45403 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-01 22:53:33 +00:00
skia-flutter-autoroll
48966a7f06
Roll Skia from 2c0405489966 to 22ae23891e8e (1 revision) ( flutter/engine#45402 )
...
https://skia.googlesource.com/skia.git/+log/2c0405489966..22ae23891e8e
2023-09-01 johnstiles@google.com Enforce backend flags on push_constant layout.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-01 22:52:38 +00:00
Loïc Sharma
2bec12f0b4
[Windows] Update vsync on raster thread ( flutter/engine#45310 )
...
## Background
If the Windows system compositor is enabled, the Windows embedder disables the swap interval so that presenting to a surface does not block until the v-blank. If the Windows system compositor is disabled (which is possible on Windows 7), the Windows embedder enables swap interval to prevent screen tearing.
Updating the swap interval requires making the GL surface current, which we currently do on the platform thread. However, the raster thread also needs the GL surface for rendering. Our current version of ANGLE allows making a GL surface current on multiple threads. However, the latest version of ANGLE errors if a GL context is made current on multiple threads. This is causing the ANGLE roll to fail ([example](https://ci.chromium.org/ui/p/flutter/builders/try/Windows%20Engine%20Drone/203788/overview )).
## Solution
There's two fixes:
1. The GL context is released once the swap interval is updated. This allows the platform thread to set the initial swap interval at start up, before the raster thread is started. This fixes the ANGLE roll.
3. When the system compositor changes, the Windows embedder now switches to the raster thread before updating the swap interval. This ensures that the GL surface is only made current on the raster thread once the raster thread has started. I updated unit tests to cover this scenario and tested this manually on a Windows 7 machine.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-09-01 22:33:01 +00:00
skia-flutter-autoroll
e9eaa3afa9
Roll Dart SDK from a2ea759c16cc to cdf1ce0c6d7e (1 revision) ( flutter/engine#45397 )
...
https://dart.googlesource.com/sdk.git/+log/a2ea759c16cc..cdf1ce0c6d7e
2023-09-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-130.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-01 21:22:12 +00:00
skia-flutter-autoroll
d58cef0f45
Roll Skia from f3f6c733c7e6 to 2c0405489966 (1 revision) ( flutter/engine#45396 )
...
https://skia.googlesource.com/skia.git/+log/f3f6c733c7e6..2c0405489966
2023-09-01 kjlubick@google.com Reland "Roll Dawn from beaf20f90f1b to b9afa50913de (668 revisions)"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-01 21:06:47 +00:00
skia-flutter-autoroll
4712ec69ef
Roll Skia from 02fa14799c6c to f3f6c733c7e6 (1 revision) ( flutter/engine#45394 )
...
https://skia.googlesource.com/skia.git/+log/02fa14799c6c..f3f6c733c7e6
2023-09-01 kjlubick@google.com Revert "Roll Dawn from beaf20f90f1b to b9afa50913de (668 revisions)"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-01 20:23:57 +00:00
skia-flutter-autoroll
48d41d0aa3
Roll Skia from d5d3b0d4ee77 to 02fa14799c6c (2 revisions) ( flutter/engine#45392 )
...
https://skia.googlesource.com/skia.git/+log/d5d3b0d4ee77..02fa14799c6c
2023-09-01 kjlubick@google.com Fix unintentional cpu_sync=true and deprecate sk_sp<SkSurface> APIs
2023-09-01 johnstiles@google.com Enforce matching pixel-format when passing texture2D arguments.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-01 19:40:02 +00:00
hellohuanlin
ef55ffaa9b
[ios][ios17][text_input]fix text input system highlight in iOS 17 Beta 7 with firstRectForRange ( flutter/engine#45303 )
...
Design doc with more details: https://docs.google.com/document/d/1sM3HMv-SQin39yX1aPUU7vtGv7Hcef1Quc3QhRXBl6A/edit?resourcekey=0-SFYD8vmOIkXiXCZvB1Wlcw#heading=h.tul5o3hopauh
Just to be safe, for now we only change for iOS 17. However, the same logic should apply to older iOS as well. So will update in a separate PR.
Basically we were using `firstRectForRange` incorrectly. According to [the API doc](https://developer.apple.com/documentation/uikit/uitextinput/1614570-firstrectforrange ), `firstRectForRange` should return **the rect for the queried range, or a subrange through the end of line, if the range encompasses multiple lines**.
For LTR language:
```
0, 1, 2, 3
4, 5, 6, 7
```
Query: `[1, 2, 3, 4]`
Returns the following rect denoted by `[ ]`:
```
0, [1, 2, 3]
4, 5, 6, 7
```
Similarly, for RTL language (Arabic):
```
3, 2, 1, 0
7, 6, 5, 4
```
Query: `[1, 2, 3, 4]`
Returns the following rect denoted by `[ ]`:
```
[3, 2, 1], 0
7, 6, 5, 4
```
*List which issues are fixed by this PR. You must list at least one issue.*
https://github.com/flutter/flutter/issues/131622
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-09-01 19:03:48 +00:00
skia-flutter-autoroll
78f1c64cb8
Roll Skia from d6266ef14a7e to d5d3b0d4ee77 (2 revisions) ( flutter/engine#45389 )
...
https://skia.googlesource.com/skia.git/+log/d6266ef14a7e..d5d3b0d4ee77
2023-09-01 johnstiles@google.com Require that texture2D function parameters include a pixel format.
2023-09-01 kjlubick@google.com Roll Dawn from beaf20f90f1b to b9afa50913de (668 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-01 18:21:14 +00:00
