DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
32,391 Commits 882 Branches 1,069 Tags
Commit Graph

32391 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
skia-flutter-autoroll
86aada926d Roll Fuchsia Mac SDK from fw9lcUvz8S07_zaAj... to 9YSl2rN0sj5YpYNdQ... (flutter/engine#47409) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-28 01:09:05 +00:00
Ricardo Amador
d4db18900a Add Android Emulator dependencies as "test_dependencies" to Android tests (flutter/engine#47384) 
# Description

Emulator dependencies were not getting picked up correctly when running the Recipes through engine_v2. The fix was to allow the context it runs through to be passed the version via the flutter_deps module. That change can be found here: https://flutter-review.googlesource.com/c/recipes/+/51869.

Do not land until above cl has been merged.

## Related Issue
*List which issues are fixed by this PR. You must list at least one issue.*
Fixes https://github.com/flutter/flutter/issues/137350

## Validation
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-10-28 00:05:23 +00:00
Mouad Debbar
57cc7e9136 [web] DomManager for each FlutterView (flutter/engine#47388) 
The PR may seem large, but the main changes are simple:

- Introduce a `DomManager` that aims to take over all DOM responsibilities from `FlutterViewEmbedder`.
- Update all references to `flutterViewEmbedder.*domElement*` to `domManager.*domElement*`.
- Describe the general DOM structure of a Flutter View in a doc comment.

Next steps (in future PRs):
- Move all DOM manipulation methods out of `FlutterViewEmbedder` into `DomManager`.
- Move DOM creation logic out of `FlutterViewEmbedder` into `DomManager`.
 2023-10-27 23:53:27 +00:00
skia-flutter-autoroll
a20662c91d Roll Skia from 77abd518ad4a to 64f13d5be3f7 (2 revisions) (flutter/engine#47406) 
https://skia.googlesource.com/skia.git/+log/77abd518ad4a..64f13d5be3f7

2023-10-27 michaelludwig@google.com [graphite] Implement drawCoverageMask, enable mask filters
2023-10-27 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from fd22bd69eb33 to 0b52da754fe9 (5 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-27 23:41:24 +00:00
gaaclarke
86d8689ce2 [Impeller] started scaling the gaussian blur sigma to match skia output (flutter/engine#47405) 
fixes https://github.com/flutter/flutter/issues/127770

This will help performance as well since our kernels will be smaller.
The justification for scaling the sigma is that we need to account in
the math the scaling down that we are doing of the input.

Here are the side-by-side comparisons with this math and skia, impeller
is always on the right:

## sigma 10

<img width="1395" alt="blur_10"
src="https://github.com/flutter/engine/assets/30870216/d534d71f-b35b-46aa-be79-8337172968a8">

## sigma 75

<img width="1398" alt="blur_75"
src="https://github.com/flutter/engine/assets/30870216/a8a77048-5212-470d-b537-a0aea98efce6">

## sigma 164 (sigma in bug)
<img width="1402" alt="blur_164"
src="https://github.com/flutter/engine/assets/30870216/cc620d02-4460-4cc8-9798-8dd21530eeed">

## sigma 400
<img width="1404" alt="blur_400"
src="https://github.com/flutter/engine/assets/30870216/653c1f1b-8156-4cff-bfcf-bf1ba737b386">

## sigma 1000
<img width="1395" alt="blur_1000"
src="https://github.com/flutter/engine/assets/30870216/c3456275-7876-4733-a27b-6022140c6a24">



## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-10-27 16:39:29 -07:00
skia-flutter-autoroll
b403f8f1dc Roll Fuchsia Linux SDK from gPQSfYJVLOgXjxQce... to ESkamdoXWIwkdWdP-... (flutter/engine#47404) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-27 23:29:36 +00:00
Zachary Anderson
879275cda3 Remove //third_party/khronos (flutter/engine#47398) 
It was introduced for a Linux/GTK component in https://github.com/flutter/engine/pull/17634.  But it looks like that dependency was later removed.
 2023-10-27 22:11:12 +00:00
skia-flutter-autoroll
a2c31cd0f8 Roll Skia from ccc3518a67b5 to 77abd518ad4a (5 revisions) (flutter/engine#47399) 
https://skia.googlesource.com/skia.git/+log/ccc3518a67b5..77abd518ad4a

2023-10-27 brianosman@google.com Expand powerless hue gradient testing
2023-10-27 michaelludwig@google.com Fix auto-expanding layers when there are no filters
2023-10-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from 14b5f7ddbad3 to b9465588c600
2023-10-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll debugger-app-base from ad6eaad9b866 to b842291db7bb
2023-10-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll jsfiddle-base from 78f3bf93ca15 to b8b6ef8feccd

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-27 21:48:59 +00:00
skia-flutter-autoroll
a07f243df6 Roll Dart SDK from 360370ff93b0 to 5a666e8d8259 (15 revisions) (flutter/engine#47392) 
https://dart.googlesource.com/sdk.git/+log/360370ff93b0..5a666e8d8259

2023-10-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-71.0.dev
2023-10-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-70.0.dev
2023-10-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-69.0.dev
2023-10-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-68.0.dev
2023-10-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-67.0.dev
2023-10-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-66.0.dev
2023-10-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-65.0.dev
2023-10-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-64.0.dev
2023-10-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-63.0.dev
2023-10-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-62.0.dev
2023-10-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-61.0.dev
2023-10-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-60.0.dev
2023-10-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-59.0.dev
2023-10-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-58.0.dev
2023-10-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-57.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-27 21:01:03 +00:00
skia-flutter-autoroll
66e335e072 Roll Skia from ebb2a3d4699b to ccc3518a67b5 (1 revision) (flutter/engine#47394) 
https://skia.googlesource.com/skia.git/+log/ebb2a3d4699b..ccc3518a67b5

2023-10-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll shaders-base from 54d970f7a773 to a536f59bdab0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-27 20:57:05 +00:00
Zachary Anderson
b7d61edc74 Move gtest-parallel to flutter/third_party (flutter/engine#47393) 
As part of eliminating the Flutter buildroot (https://github.com/flutter/flutter/issues/67373), we are moving all third-party dependencies from //third_party to //flutter/third_party.

Once all third-party dependencies have been migrated, tooling and config will be moved and the buildroot will be eliminated altogether.

No tests changed because there is no semantic change to this PR. This is simply relocating a dependency.
 2023-10-27 20:47:37 +00:00
Zachary Anderson
59cc39e9bd Move flatbuffers to flutter/third_party (flutter/engine#47387) 
As part of eliminating the Flutter buildroot
(https://github.com/flutter/flutter/issues/67373), we are moving all
third-party dependencies from //third_party to //flutter/third_party.

Once all third-party dependencies have been migrated, tooling and config
will be moved and the buildroot will be eliminated altogether.

No tests changed because there is no semantic change to this PR. This is
simply relocating a dependency.
 2023-10-27 13:05:56 -07:00
skia-flutter-autoroll
c0a52aa663 Roll Skia from ba3e1db468d0 to ebb2a3d4699b (10 revisions) (flutter/engine#47390) 
https://skia.googlesource.com/skia.git/+log/ba3e1db468d0..ebb2a3d4699b

2023-10-27 brianosman@google.com Add position storage to SkColor4fXformer
2023-10-27 armansito@google.com [graphite] Reduce conditional compilation sites to query vello support
2023-10-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from 0d214ae84fb2 to 14b5f7ddbad3
2023-10-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll shaders-base from bce95eb72596 to 54d970f7a773
2023-10-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll jsfiddle-base from 243e5abc4daa to 78f3bf93ca15
2023-10-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll debugger-app-base from ead32575e5bc to ad6eaad9b866
2023-10-27 jvanverth@google.com [graphite] Switch to using CoreFoundation type rather than MtlHandle.
2023-10-27 nicolettep@google.com Remove Vulkan dynamic rendering and inline uniform extension checks
2023-10-27 nicolettep@google.com Add VK_NV_present_barrier to list of unsupported debug layer extensions
2023-10-27 michaelludwig@google.com [graphite] Generalize transform handling in CoverageMaskRenderStep

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-27 19:47:05 +00:00
skia-flutter-autoroll
16d682f48d Roll Skia from fe9959acc5e0 to ba3e1db468d0 (1 revision) (flutter/engine#47382) 
https://skia.googlesource.com/skia.git/+log/fe9959acc5e0..ba3e1db468d0

2023-10-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from a2bfb92d5166 to 654bb2135ce8 (10 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com
on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-27 14:56:47 -04:00
gaaclarke
caa9f39916 Made FlutterTaskQueue visible for Swift. (flutter/engine#47348) 
fixes https://github.com/flutter/flutter/issues/118832

This makes the `FlutterTaskQueue` protocol visible, but keeps the
`dispatch:` selector private. Under the covers there are runtime checks
to make sure `dispatch:` is available since we can't have compile time
checks anymore.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-10-27 11:01:08 -07:00
Zachary Anderson
bcfec4bcfc Move shaderc to flutter/third_party (flutter/engine#47383) 
As part of eliminating the Flutter buildroot
(https://github.com/flutter/flutter/issues/67373), we are moving all
third-party dependencies from //third_party to //flutter/third_party.

Once all third-party dependencies have been migrated, tooling and config
will be moved and the buildroot will be eliminated altogether.

No tests changed because there is no semantic change to this PR. This is
simply relocating a dependency.
 2023-10-27 10:45:20 -07:00
Jonah Williams
4c9b181ee3 [Impeller] Add present wait latch. (flutter/engine#47311) 
It turns out the fixing https://github.com/flutter/engine/pull/47249 revealed further bugs: we were actually overwriting previous presents and dropping frames, which was what the forward progress error was hinting. Once this problem is fixed, we started hitting present timeouts or overdraw of swapchain images.

The fix for this is that we shouldn't even ask for a swapchain image until after we've called present, which actually wasn't tracked with anything.

The error:

```
A Dart VM Service on Pixel 6 Pro is available at: http://127.0.0.1:62491/_N4PSEPUtA0=/
The Flutter DevTools debugger and profiler on Pixel 6 Pro is available at: http://127.0.0.1:9102?uri=http://127.0.0.1:62491/_N4PSEPUtA0=/
W/OnBackInvokedCallback(19160): OnBackInvokedCallback is not enabled for the application.
W/OnBackInvokedCallback(19160): Set 'android:enableOnBackInvokedCallback="true"' in the application manifest.
W/vulkan  (19160): dequeueBuffer timed out: Function not implemented (-38)
E/flutter (19160): [ERROR:flutter/impeller/base/validation.cc(49)] Break on 'ImpellerValidationBreak' to inspect point of failure: Could not acquire next swapchain image: Timeout
E/flutter (19160): [ERROR:flutter/shell/gpu/gpu_surface_vulkan_impeller.cc(64)] No surface available.
```
 2023-10-27 15:27:51 +00:00
Zachary Anderson
e1fc52e2b6 Move rapidjson to flutter/third_party (flutter/engine#47354) 
As part of eliminating the Flutter buildroot
(https://github.com/flutter/flutter/issues/67373), we are moving all
third-party dependencies from //third_party to //flutter/third_party.

Once all third-party dependencies have been migrated, tooling and config
will be moved and the buildroot will be eliminated altogether.

No tests changed because there is no semantic change to this PR. This is
simply relocating a dependency.
 2023-10-27 08:00:56 -07:00
Jason Simmons
e866800c0c [Impeller] Enable GLES MSAA only if the multisampled_render_to_texture2 extension is available (flutter/engine#47364) 
The GLES MSAA implementation may need to call FramebufferTexture2DMultisampleEXT for the stencil attachment.

See https://github.com/flutter/flutter/issues/137252
 2023-10-27 14:44:58 +00:00
Jason Simmons
e40bd4d3dd [Impeller] Fix leak of framebuffers used in GLES MSAA rendering (flutter/engine#47362) 2023-10-27 14:37:29 +00:00
auto-submit[bot]
fa847e083e Reverts "Manual roll Dart SDK from 360370ff93b0 to 18678a3eddb7 (9 revisions)" (flutter/engine#47380) 
Reverts flutter/engine#47357
Initiated by: zanderso
This change reverts the following previous change:
Original Description:

Manual roll requested by aam@google.com

https://dart.googlesource.com/sdk.git/+log/360370ff93b0..18678a3eddb7

2023-10-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-65.0.dev
2023-10-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-64.0.dev
2023-10-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-63.0.dev
2023-10-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-62.0.dev
2023-10-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-61.0.dev
2023-10-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-60.0.dev
2023-10-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-59.0.dev
2023-10-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-58.0.dev
2023-10-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-57.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,aam@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-27 14:13:17 +00:00
skia-flutter-autoroll
f433c373d6 Roll Skia from 0122c0e18d26 to fe9959acc5e0 (1 revision) (flutter/engine#47379) 
https://skia.googlesource.com/skia.git/+log/0122c0e18d26..fe9959acc5e0

2023-10-27 jvanverth@google.com [graphite] Add per-edge AA quad shaders.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-27 14:05:32 +00:00
skia-flutter-autoroll
6ecb86bacc Roll Fuchsia Mac SDK from 1ngqKBnmTtmFM6aBD... to fw9lcUvz8S07_zaAj... (flutter/engine#47377) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-27 12:25:22 +00:00
skia-flutter-autoroll
34f1b9cb0e Roll Fuchsia Linux SDK from 37VxdxlPfdkek7mwC... to gPQSfYJVLOgXjxQce... (flutter/engine#47375) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-27 09:58:05 +00:00
skia-flutter-autoroll
eb8c308539 Roll Skia from 22f5419438c4 to 0122c0e18d26 (1 revision) (flutter/engine#47373) 
https://skia.googlesource.com/skia.git/+log/22f5419438c4..0122c0e18d26

2023-10-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 5dd0c842d6c8 to eca38a109465 (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-27 07:30:05 +00:00
skia-flutter-autoroll
9cb47c079f Roll Skia from 5262cbff56b1 to 22f5419438c4 (1 revision) (flutter/engine#47372) 
https://skia.googlesource.com/skia.git/+log/5262cbff56b1..22f5419438c4

2023-10-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from ac82f8a7da91 to 3208d90e145c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-27 06:54:09 +00:00
skia-flutter-autoroll
34d3cbf818 Roll Skia from fe61b3467547 to 5262cbff56b1 (1 revision) (flutter/engine#47371) 
https://skia.googlesource.com/skia.git/+log/fe61b3467547..5262cbff56b1

2023-10-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from c92f9bf9379e to fd22bd69eb33 (15 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-27 06:10:33 +00:00
skia-flutter-autoroll
24822888df Roll Skia from fbdd7d97b26e to fe61b3467547 (1 revision) (flutter/engine#47370) 
https://skia.googlesource.com/skia.git/+log/fbdd7d97b26e..fe61b3467547

2023-10-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 50a46e8932cc to ac82f8a7da91 (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-27 05:26:23 +00:00
skia-flutter-autoroll
5cca59bdd4 Roll Skia from 2246f3473053 to fbdd7d97b26e (2 revisions) (flutter/engine#47369) 
https://skia.googlesource.com/skia.git/+log/2246f3473053..fbdd7d97b26e

2023-10-27 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version
2023-10-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from 4d94ff507876 to f1e5fc856f1b (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-27 03:34:23 +00:00
skia-flutter-autoroll
2372b84f1a Roll Skia from ec4c6b3a6690 to 2246f3473053 (1 revision) (flutter/engine#47366) 
https://skia.googlesource.com/skia.git/+log/ec4c6b3a6690..2246f3473053

2023-10-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from 1227163dbdb7 to 4d94ff507876 (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-27 01:22:07 +00:00
Jim Graham
cc929700b6 [Impeller] Add FilterContents::GetSourceCoverage to enable filtered saveLayer clipping. (flutter/engine#47183) 
The new method allows a caller to ask for the coverage of the input pixels required to produce an output that spans a given area. This allows the code to clip a saveLayer that has an image filter applied to it.
 2023-10-27 01:16:23 +00:00
skia-flutter-autoroll
d61df35142 Roll Skia from bc8ca57868d2 to ec4c6b3a6690 (1 revision) (flutter/engine#47365) 
https://skia.googlesource.com/skia.git/+log/bc8ca57868d2..ec4c6b3a6690

2023-10-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 6f757b21c505 to a2bfb92d5166 (7 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-27 00:41:21 +00:00
John McCutchan
632d65292d Don't re-initialize the default RenderSurface when returning from hybrid composition mode (flutter/engine#47358) 
When we enter hybrid composition mode we 'pause' the default RenderSurface (implemented by SurfaceView or TextureView) and swap to an ImageReader based RenderSurface.

When we return from hybrid composition mode we recreate and re-initialize the real RenderSurface as if it was being used for the first time.

This broke Platform Views in an internal app b/306122497 because we would incorrectly tell the texture to attach when it was never detached.

This CL changes the protocol so that when we return from hybrid composition mode we only swap the RenderSurface and do not re-create it. This avoids doing a bunch of unnecessary work and fixes the logic error of re-attaching textures that were never detached.

*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*

*List which issues are fixed by this PR. You must list at least one issue.*

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-10-27 00:33:23 +00:00
skia-flutter-autoroll
9572116d73 Manual roll Dart SDK from 360370ff93b0 to 18678a3eddb7 (9 revisions) (flutter/engine#47357) 
Manual roll requested by aam@google.com

https://dart.googlesource.com/sdk.git/+log/360370ff93b0..18678a3eddb7

2023-10-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-65.0.dev
2023-10-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-64.0.dev
2023-10-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-63.0.dev
2023-10-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-62.0.dev
2023-10-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-61.0.dev
2023-10-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-60.0.dev
2023-10-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-59.0.dev
2023-10-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-58.0.dev
2023-10-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-57.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,aam@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-27 00:12:58 +00:00
skia-flutter-autoroll
2396d6ef3a Roll Skia from 93a0ad4d7ca6 to bc8ca57868d2 (2 revisions) (flutter/engine#47359) 
https://skia.googlesource.com/skia.git/+log/93a0ad4d7ca6..bc8ca57868d2

2023-10-26 rmistry@google.com Change espn page set and recapture archives
2023-10-26 drott@chromium.org [Fontations] Add a suffix to font names to identify when backend is used

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-26 23:52:54 +00:00
skia-flutter-autoroll
d8f5d9fa79 Roll Fuchsia Mac SDK from YSn00b0Trsu2vdhIq... to 1ngqKBnmTtmFM6aBD... (flutter/engine#47363) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-26 23:48:50 +00:00
Tong Mu
a98c3dc263 Skip invalid renders in Dart (flutter/engine#47323) 
With this PR, invalid renders are skipped in Dart in both release build and debug build.

Part of https://github.com/flutter/flutter/issues/137073 and part of relanding https://github.com/flutter/engine/pull/45555.

Unit tests will be relanded in a following PR once this PR is confirmed performance-safe.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-10-26 22:09:10 +00:00
Chris Bracken
987dac0ae1 [macOS] Reuse NSWindow instance across unit tests (flutter/engine#47350) 
Adds a gtest test fixture mixin and convenience class that instantiates an NSAutoreleasePool at the beginning of each test and flushes it at the end; this allows Objective-C tests using ARC to free  allocations at the end of each test.

Adds a subclass for the macOS accessibility bridge tests that instantiates and re-uses an NSWindow* across any tests that use it. This is because instantiating, closing, and immediately collecting an NSWindow results in a crash.

Prior to this patch, tests started failing (on my machine) around the 855th iteration, and issued the following warning on the 101st iteration:

```
2023-10-26 13:02:45.390829-0700 flutter_desktop_darwin_unittests[40837:1509026] [Window] WARNING: NSWindow has detected an excessive live window count of 101. Window 0x1423 of class 'NSWindow' created after passing the threshold of 100. This window is not necessarily the cause, and this warning will only be shown once per window class. (
  0   AppKit                              0x0000000192820d28 -[NSWindow _setWindowNumber:] + 684
  1   AppKit                              0x00000001933050e4 _NXCreateWindow + 284
  2   AppKit                              0x0000000192901ae0 -[NSWindow _commonAwake] + 672
  3   AppKit                              0x000000019281ff00 -[NSWindow _commonInitFrame:styleMask:backing:defer:] + 972
  4   AppKit                              0x000000019281f798 -[NSWindow _initContent:styleMask:backing:defer:contentView:] + 796
  5   AppKit                              0x000000019281f470 -[NSWindow initWithContentRect:styleMask:backing:defer:] + 48
  6   flutter_desktop_darwin_unittests    0x0000000100001e3c _ZN7flutter7testing89AccessibilityBridgeMacTest_SendsAccessibilityCreateNotificationToWindowOfFlutterView_Test8TestBodyEv + 328
```

See: http://www.openradar.me/FB13291861

Issue: https://github.com/flutter/flutter/issues/104789
Issue: https://github.com/flutter/flutter/issues/127441
Issue: https://github.com/flutter/flutter/issues/124840

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-10-26 21:17:01 +00:00
skia-flutter-autoroll
269225124c Roll Skia from fb72136c9325 to 93a0ad4d7ca6 (1 revision) (flutter/engine#47352) 
https://skia.googlesource.com/skia.git/+log/fb72136c9325..93a0ad4d7ca6

2023-10-26 fmalita@chromium.org Add SK_API to SkVertices::Builder

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-26 21:15:06 +00:00
skia-flutter-autoroll
47cebcc239 Roll Fuchsia Linux SDK from akT2HxdLNPWSG-gbV... to 37VxdxlPfdkek7mwC... (flutter/engine#47351) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-26 21:13:07 +00:00
John O'Neil
58bb0adf2c Fix for undefined uint8_t seen on Clang-15+GCC13 (flutter/engine#47288) 
This PR is to address an issue we're seeing compiling flutter+impeller in certain configurations. Specifically:

1. Compiling with `clang-15`
2. using the GCC 13 backend to provide headers and cstdlib.

Via the `clang-15` version flag:

```
clang-15 -v
Debian clang version 15.0.7
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/bin
Found candidate GCC installation: /usr/bin/../lib/gcc/x86_64-linux-gnu/11
Found candidate GCC installation: /usr/bin/../lib/gcc/x86_64-linux-gnu/12
Found candidate GCC installation: /usr/bin/../lib/gcc/x86_64-linux-gnu/13
Selected GCC installation: /usr/bin/../lib/gcc/x86_64-linux-gnu/13
Candidate multilib: .;@m64
Candidate multilib: 32;@m32
Candidate multilib: x32;@mx32
Selected multilib: .;@m64
```

We were building using the gcc 12 backend for a while, but picked up an update that forced us to 13, and then saw this issue.

The issue is seen as `uint8_t` being undefined as in the following partial messages:

```
hex_codec.cc:18:5: error: unknown type name 'uint8_t'
base32.cc:29:32: error: unknown type name 'uint8_t'
```

I'm not sure this is the cleanest fix, or if it might be better handled by adding some compile time switches, but I wanted to provide this to start conversation.

I'm also hoping to get a better idea of tests run against a PR. If there's any I should run manually we can discuss that here.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-10-26 21:10:04 +00:00
auto-submit[bot]
24debb363e Reverts "[Impeller] Disable layer tree screenshots." (flutter/engine#47356) 
Reverts flutter/engine#46171
Initiated by: jonahwilliams
This change reverts the following previous change:
Original Description:
The "rasterizer screenshot" VM service API uses the Skia software backend, even when running with impeller. At best, this leads to confusing half working screenshots that are missing images.

See https://github.com/flutter/flutter/issues/135052

We should disable this functionality when running with impeller. Perhaps this could be reworked to use picture toImage instead of the offscreen so that it uses the "real" backend regardless of the platform it is running on.

Fixes https://github.com/flutter/flutter/issues/135052
 2023-10-26 20:34:17 +00:00
Loïc Sharma
f06b89215e [Windows] Refactor high contrast mode detection (flutter/engine#47314) 
This refactors how high contrast is implemented on Windows:

1. Added a test to verify accessibility features are updated when a view is created. This prevents staleness issues as the Windows embedder isn't notified of accessibility changes while in headless mode.
1. Moved high contrast mode detection to `WindowsProcTable` from `FlutterWindow` to remove engine to view to window plumbing.
1. `FlutterWindow` and `FlutterWindowsEngine` now share their `WindowsProcTable` (which is used for mocking and polyfilling win32 APIs) to reduce redundant dynamic loading.

This pull request contains no functional changes.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-10-26 20:22:15 +00:00
Jonah Williams
912c891a1d [Impeller] Disable layer tree screenshots. (flutter/engine#46171) 
The "rasterizer screenshot" VM service API uses the Skia software backend, even when running with impeller. At best, this leads to confusing half working screenshots that are missing images.

See https://github.com/flutter/flutter/issues/135052

We should disable this functionality when running with impeller. Perhaps this could be reworked to use picture toImage instead of the offscreen so that it uses the "real" backend regardless of the platform it is running on.

Fixes https://github.com/flutter/flutter/issues/135052
 2023-10-26 20:16:09 +00:00
Jason Simmons
6ef260d4b5 [Impeller] Fix the transform and geometry criteria for an optimization in TiledTextureContents (flutter/engine#47341) 
TiledTextureContents::RenderToSnapshot should only create a snapshot directly from the texture if the geometry is an axis-aligned rectangle.

Fixes https://github.com/flutter/flutter/issues/136504
 2023-10-26 20:08:21 +00:00
Jason Simmons
5316d75378 Roll HarfBuzz to 8.2.2 (flutter/engine#47284) 
Fixes https://github.com/flutter/flutter/issues/132327
 2023-10-26 20:03:07 +00:00
skia-flutter-autoroll
b0af8b059f Roll Skia from 19e9ccf5f820 to fb72136c9325 (2 revisions) (flutter/engine#47346) 
https://skia.googlesource.com/skia.git/+log/19e9ccf5f820..fb72136c9325

2023-10-26 egdaniel@google.com Revert "Fix checking of power of 2 for scratch buffer caching."
2023-10-26 jamesgk@google.com [graphite] Limit DrawPass size by number of RenderSteps

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-26 19:10:16 +00:00
Jonah Williams
1db210a686 [Impeller] remove giant closure in EntityPass. (flutter/engine#47343) 
I find it difficult to track what parts of this method are part of the closure and which aren't. Lets hoist this data into a private method and remove some unused imports.
 2023-10-26 18:51:01 +00:00
godofredoc
7f6c801cd4 Adds firebase test lab tests. (flutter/engine#47320) 
The FTL tests were not migrated during the v2 migration.

Bug: https://github.com/flutter/flutter/issues/136767

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-10-26 18:39:49 +00:00
skia-flutter-autoroll
2aa85bc204 Roll Skia from e1cc41ff84ca to 19e9ccf5f820 (1 revision) (flutter/engine#47342) 
https://skia.googlesource.com/skia.git/+log/e1cc41ff84ca..19e9ccf5f820

2023-10-26 kjlubick@google.com Update local demo server with example

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-26 18:26:51 +00:00