Example before:
$ ./tools/fuchsia/build_fuchsia_artifacts.py \
--engine-version HEAD \
--no-lto \
--archs x64 \
--runtime-mode debug
Running gn for variant "fuchsia_debug_x64" with flags: --fuchsia,--fuchsia-cpu,x64,--runtime-mode,debug,--no-lto
Generating GN files in: out/fuchsia_debug_x64
Done. Made 1085 targets from 221 files in 532ms
ninja: Entering directory `/usr/local/google/home/hjfreyer/flutter/engine/src/flutter/tools/fuchsia/../../../out/fuchsia_debug_x64'
ninja: error: empty path
Traceback (most recent call last):
File "./tools/fuchsia/build_fuchsia_artifacts.py", line 391, in <module>
sys.exit(main())
File "./tools/fuchsia/build_fuchsia_artifacts.py", line 380, in main
args.targets.split(","))
File "./tools/fuchsia/build_fuchsia_artifacts.py", line 283, in BuildTarget
BuildNinjaTargets(out_dir, [ 'flutter' ] + additional_targets)
File "./tools/fuchsia/build_fuchsia_artifacts.py", line 72, in BuildNinjaTargets
os.path.join(_out_dir, variant_dir)] + targets)
File "./tools/fuchsia/build_fuchsia_artifacts.py", line 55, in RunExecutable
subprocess.check_call(command, cwd=_src_root_dir)
File "/usr/lib/python2.7/subprocess.py", line 190, in check_call
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['ninja', '-C', '/usr/local/google/home/hjfreyer/flutter/engine/src/flutter/tools/fuchsia/../../../out/fuchsia_debug_x64', 'flutter', '']' returned non-zero exit status 1
Co-authored-by: Hunter Freyer <hjfreyer@google.com>
This avoids the awkward capitalisation 'E.g.' but more importantly
triggers a build with the latest recipe update, which includes Windows
UWP build products.
The FlutterComputePlatformResolvedLocaleCallback does not pass the
standard user_data baton. This was an unintentional omission in the
original patch.
Add documentation to that effect and link to the bug report:
https://github.com/flutter/flutter/issues/79826
FlutterDesktopEngineCreate is part of our C API. We were using a C++
reference type instead of a C-compatible pointer type.
This is a breaking change to anyone calling this directly; we believe
this should affect few people because the Windows template only uses the
`FlutterEngine` wrapper in
`shell/platform/windows/client_wrapper/include/flutter/flutter_engine.h`.
Fixes https://github.com/flutter/flutter/issues/75465
