120 Commits

Author SHA1 Message Date
nturgut
81f2d37070 re-enable integration tests. increase sdk version. (flutter/engine#20075) 2020-07-27 19:37:47 -07:00
nturgut
f491fb0126 both trees are red, stop running integration tests (flutter/engine#20060) 2020-07-27 11:15:56 -07:00
nturgut
bf4cd9d73d Add a todo to felt (PR to rerun the tree) (flutter/engine#20025) 2020-07-25 21:12:15 -07:00
nturgut
fe01de71bf Address platform changes in the integration tests. (flutter/engine#20008) 2020-07-24 10:52:57 -07:00
Ferhat
1ab64f15b3 [web] Fixes arc scaling when counter clockwise (flutter/engine#19927)
* [web] Fix arc scaling when counter clockwise
* update golden write
* Removed unused var
2020-07-22 10:02:07 -07:00
nturgut
d831e5aa86 Migrating web_analysis from Cirrus to LUCI (PART 1) (flutter/engine#19726)
* adding a script for web_analysis for using from luci.

* addressing reviewer comments
2020-07-14 10:14:31 -07:00
Alexandre Ardhuin
2c2e5f362c Operator equals (flutter/engine#19303)
* use Object for operator==

* apply style guide for operator==
2020-06-30 23:16:31 +02:00
nturgut
dfb9bd8f34 collect logs using the new web_installers repo (flutter/engine#19298) 2020-06-25 10:27:53 -07:00
nturgut
b36e0f6e4e skip ios safari tests on felt level (flutter/engine#19280)
* skip ios safari tests on felt level

* instead of skipping use the new web_installers repo

* re-skip the test. led run failed with another error

* remove led json
2020-06-24 20:51:38 -07:00
nturgut
eeac18d23d Run IOS unit tests on LUCI (flutter/engine#19141)
* change the version of simulator. luci bots only has 13.0

* skip failing pointer binding tests

* skip path_metrics (canvaskit) and a method from surface_test

* fix analyzer errors

* remove extra added touch event context test

* removing left overs for screenshot debugging

* apply reviewers suggestion for skipping tests
2020-06-23 15:22:01 -07:00
nturgut
d17556b67b Enable firefox integration tests (flutter/engine#19164)
* firefox integration tests enable

* addressing reviewer comments
2020-06-22 13:16:57 -07:00
nturgut
ca3a8d7aa1 [web] Running integration tests on Safari on Local (flutter/engine#18488)
* rebase. carry driver functionality to drivermanager

* rebase. nabling integration tests on Safari on MacOS

* addressing reviewer comments, updating web_drivers dependency commit number

* addressing reviewer comments

* addressing reviewer comments
2020-06-18 16:48:04 -07:00
Yegor
30879c3f50 take web_ui to null safety (flutter/engine#19027)
move web_ui to NNBD syntax
2020-06-16 15:28:06 -07:00
nturgut
3c39c76a51 renaming variables on integration tests manager (flutter/engine#18975) 2020-06-10 16:33:52 -07:00
nturgut
60f74491f2 Update firefox.dart (flutter/engine#18939) 2020-06-10 11:29:19 -07:00
nturgut
389517d57e [web] running ios unit tests from felt … (flutter/engine#18856)
* running ios unit tests from felt by booting/shutingdown simulators. create simulator with felt

* changing the readme file for ios,mac,xcode spellings

* addressing reviewer comments

* fix analyse error

* fixing cleanup issue. solution: adding and await and using for loop instead of foreach
2020-06-10 09:33:17 -07:00
nturgut
0f62d15509 [web] Adding profile parameter to firefox (flutter/engine#18792)
* opening firefox with a given profile

* use .dart_tool for temporary directory. delete the directory if exits before creation
2020-06-04 13:22:13 -07:00
nturgut
1c457a7a39 add driver for chrome 83 (flutter/engine#18722) 2020-06-01 19:07:25 -07:00
nturgut
ce8fe9903d [web] runs ios unit tests (flutter/engine#18650)
* runs ios unit tests, if the simulator is already booted.

* address reviewer comments

* changing comments for the Safari desktop tests

* addressing reviewer comments. removing the timeout.

* change mobile browsers ver name for safari.dart

* removing then calback on browser exit, only leaving the exception callback
2020-06-01 16:52:27 -07:00
Ferhat
8c44aaf4ee [web] Fix nineslice assertion (flutter/engine#18542)
* Fix nineslice assertion
2020-06-01 11:12:34 -07:00
Yegor
25a9d88894 implement SkPath.computeMetrics (flutter/engine#18667)
* implement SkPath.computeMetrics
2020-06-01 09:43:15 -07:00
Ferhat
2852dca632 [web] Fix arc rendering when it starts a new sub path. (flutter/engine#18535)
* Fix Path.addArc failure due to incorrect start position
2020-05-20 16:46:28 -07:00
Yegor
0e9be39785 compensate for DPR in canvas blur (flutter/engine#18484)
* compensate for DPR in canvas blur
2020-05-19 12:37:29 -07:00
Yegor
d466511441 implement MaskFilter.blur as shadow on Safari (flutter/engine#18216)
* implement MaskFilter.blur as shadow on Safari
2020-05-18 11:58:49 -07:00
nturgut
a92281f44b fix the issue in the test and remove them from the blacklist for chrome (flutter/engine#18441) 2020-05-15 17:47:51 -07:00
nturgut
d05bc0bacc Run integration tests on luci, use cipd package for Chrome (flutter/engine#18180)
* try to run integration tests on luci

* adds extra logs to check if chrome is on lUCI

* use the cipd chrome package for integration tests in LUCI

* add driver version for chrome 83.(cipd package has 83 now)

* no headless mode didn't worked on the bots. try the other option

* On LUCI also use chrome driver as a cipd package

* change the directory name to fit the cpid package

* adding blacklist functionality

* remove logs added for troubleshooting. remove the check that blocks int-test runs on LUCI

* add more comments to blacklists

* also use CIPD package chrome for unit tests

* addressing reviewer comments

* run integration tests first, upon reviewer request

* fix bug. keep running integration tests after unit tests

* update the logs for LUCI

* fix todo comments
2020-05-15 12:46:53 -07:00
Ferhat
fd8bfdf626 [web] Fix paragraph positioning (flutter/engine#18329)
* Fix text positioning
* Update golden locks
2020-05-13 09:09:18 -07:00
Yegor
2abf0646ce make compiler worker count configurable (flutter/engine#17616)
* make compiler worker count configurable
2020-05-08 11:18:02 -07:00
Ferhat
aaad0bab46 [web] Implement matrix parameter for linear gradient (flutter/engine#18208)
* Implement linear gradient matrix
* update golden locks
* Remove matrix check in RadialGradient
2020-05-07 17:22:54 -07:00
Nurhan Turgut
fdeef18465 Autofill main part (flutter/engine#17986)
* changes for getting the configuration

* running autofill

* simplifications, remove unused map

* more changes

* make single autofill fields work. remove print messages

* remove an extra line

* remove extra file. also update chrome version

* addressing reviewers comments

* addressing reviewer comments

* addressing reviewer comments

* addressing reviewer comments

* changing comments

* changing comments

* adding a comment on subscriptions lifecycle

* fixing a bug which was failing the existing unit tests

* add unit tests for AutofillInfo and EngineAutofillForm. add autocomplete to textarea

* add unit tests for method channels

* remove json from the end of the file

* do not change the input type for the focused element

* check name instead of autocomplete for firefox

* check name instead of autocomplete for firefox in other methods as well

* fixing a bug in the autofillhints file, testing if firefox is failing for username hint or for all autocomplete values

* fix the breaking unit test
2020-05-06 12:58:46 -07:00
Ferhat
fe06da4eba Fix path bounds for multiple rects. Implement winding rules (flutter/engine#18165) 2020-05-05 20:53:51 -07:00
Jason Simmons
b4b5342886 [web] Upgrade the test package to remove the dependency on package_resolver (flutter/engine#18135) 2020-05-05 10:57:02 -07:00
Ferhat
9561e45970 [web] Add support for ColorFilter on images (flutter/engine#18111)
* Implement Color filter for images
* Add blend modes
* complete set of blend modes
* Add golden test for blend modes, fix size setting when using drawImage instead of drawImageRect
* Add comments
* Update golden locks
* Fix analyzer errors
Co-authored-by: Harry Terkelsen <hterkelsen@users.noreply.github.com>
* fix blend group count in test
2020-05-05 10:22:16 -07:00
Yegor
e87a60fb92 soften shadows even more; fix shadow alpha (flutter/engine#18029)
* soften shadows even more; fix shadow alpha
2020-04-29 20:54:21 -07:00
Mouad Debbar
f464cd1f7c [web] Use correct shell operator to compare file limits (flutter/engine#18032) 2020-04-29 18:12:48 -07:00
Ferhat
30fe218072 Canvas regression (flutter/engine#17738)
* Change backdrop filter element location based on ancestor clip. Add test.
* update test
* Addressed review comments. updated goldens
* Check ancestor on retain
* addressed review comments
2020-04-20 18:59:17 -07:00
Nurhan Turgut
3a745860c2 [web] fix ulimit issues on Mac (flutter/engine#17767)
* check the max user limit before changing the limits

* more detailed changes in the file/user limit increase

* addressing pr reviews
2020-04-17 17:55:52 -07:00
Ferhat
1e6e25c4da [web] Fix compositing order when adding paragraph tags (flutter/engine#17645)
* Add test and dartfmt
* Update golden locks
* Addressed review comments
* Fix lint error (unused widthConstraint)
* Add maxDiffRatePercent for text diff on mac/linux
2020-04-13 13:30:52 -07:00
Nurhan Turgut
29c24b8a47 Run integration tests on ci (flutter/engine#17598)
* changing felt script to fetch flutter

* changing the clone_flutter.sh code

* running integration tests with felt on cirrus. fetch framework in CI (not in local).

* only run cirrus tests on chrome. fix a comma in the flutter command path

* adding comments to public flags

* use local engine parameter for flutter pub get

* change flutter executable used for flutter drive command

* fix a cleanup issue. address comments. add toolException. enable web in flutter

* address reviwer comments. fix issue with local-engine

* address reviwer comments. fix issue with local-engine

* using engine/flutter/.dart_tools as clone directory. enabling clone script for local usage

* clean flutter repo with felt clean. add a flag to skip cloning the repo. always clone the repo even for local development, unless this flag is set

* fixing typos. updating readme for the new flag.

* fix directory error

* addressing reviewer comments
2020-04-13 09:54:54 -07:00
Nurhan Turgut
4dc4c1fcf2 [web] using pkill to quit safari (flutter/engine#17533)
* adding an apple script to quit safari

* making changes to utils and adding cleanup after unit tests failed

* switch saai quit to pkill instead of applescript

* adding toolexception

* adding a cleanup function option to felt.

* removing unnecassary await's added for the previos version of the PR

* removing unnecassary async

* fix analyze error
2020-04-08 17:35:10 -07:00
Ferhat
60ad54840a [web] Fix canvas z-index leaking across repaints when element is reused. (flutter/engine#17378)
* Fix z-index leak. Add test for canvas reuse
* add regression test
* update golden locks
* fix analysis errors
2020-03-30 12:54:06 -07:00
Yegor
97bf969dc0 fix implicit dynamic and two lints everywhere; implicit cast in dev/ (flutter/engine#17372) 2020-03-29 19:23:37 -07:00
Nurhan Turgut
63faebcd92 change chrome version (flutter/engine#17382)
* change chrome version

* change chrome version
2020-03-27 16:52:02 -07:00
Yegor
d20bb30d3a Reland "add limited analysis options (#17332)" (flutter/engine#17374)
* Reland "add limited analysis options (#17332)"

This time I'm starting without Cirrus. Will add Cirrus serpartely from code changes.

This reverts commit 27da616b212419552551d1f9a9ed097f133d1221.

* disable Cirrus analysis check
2020-03-27 11:06:10 -07:00
Chinmay Garde
27da616b21 Revert "add limited analysis options (#17332)" (flutter/engine#17368)
This reverts commit c6aa044fde6a2b4fe89b6c92402126d6b33ef01b.
2020-03-27 02:38:50 -07:00
Yegor
c6aa044fde add limited analysis options (flutter/engine#17332)
add limited analysis options
2020-03-26 14:38:59 -07:00
Nurhan Turgut
f844653475 [web] improving felt: running target unit tests, cleaning up used proccesses (flutter/engine#17339)
* improving felt: running target unit tests, cleaning up used proccesses

* removing null check
2020-03-26 14:01:36 -07:00
Nurhan Turgut
cdff1342bf [web] use web drivers as a library only. do not fetch/clone web_installers (flutter/engine#17299)
* use web drivers as a library only. do not fetch/clone web_installers

* fixing comments

* addressing reviewer comments

* adding a trim to output. otherwise last fails
2020-03-24 15:37:33 -07:00
Yegor
a63c4b7025 Soften shadows (flutter/engine#17231)
* Soften shadows

* update goldens
2020-03-20 19:50:00 -07:00
Nurhan Turgut
9f6ffe557c Felt add integration (flutter/engine#17190)
* adding arguments to felt for running different type of tests

* adding test type enums to felt

* more changes to felt for testing branches

* more additions to code

* more changes to felt

* adding code for cloning web_drivers

* validating test directories. running the integration tests. update the readme file partially

* Removing todo lists used for development

* addressing reviewers comments

* remove unused imports

* addressing more reviewer comments

* addressing more reviewer comments

* addressing reviewer comments.

* addressing reviewer comments.

* fixing typos

* using chromedriverinstaller as a library. Fixing the commit number used from web_installers repo

* clean drivers directory after tests finish

* addressing more reviewer comments

* throwing all critical exceptions instead of logging and returning boolean flags

* adding todos for items we can do for making felt easier to use for local development

* do not run integration tests on CIs. Added an issue to the TODO.

* changing todo's with issues.
2020-03-20 19:24:13 -07:00