DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

[web] Fix arc rendering when it starts a new sub path. (flutter/engine#18535)

Browse Source 
* Fix Path.addArc failure due to incorrect start position
This commit is contained in:
Ferhat 2020-05-20 16:46:28 -07:00 committed by GitHub
parent 126af7553d
commit 2852dca632
3 changed files with 21 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
engine/src/flutter/lib/web_ui/dev/goldens_lock.yaml
View File

@ -1,2 +1,2 @@
repository: https://github.com/flutter/goldens.git
revision: f80e019e225915e220f0f37884c8cd1b942d9bc2
revision: 993752770817654e362b85f4781d300a9b215d4c

5
engine/src/flutter/lib/web_ui/lib/src/engine/canvas_pool.dart
View File

@ -520,6 +520,11 @@ class _CanvasPool extends _SaveStackTracking {
break;
case PathCommandTypes.ellipse:
final Ellipse ellipse = command;
if (c == 0) {
// Ellipses that start a new path need to set start point,
// otherwise it incorrectly uses last point.
ctx.moveTo(subpath.startX, subpath.startY);
}
DomRenderer.ellipse(ctx,
ellipse.x,
ellipse.y,

16
engine/src/flutter/lib/web_ui/test/golden_tests/engine/canvas_arc_golden_test.dart
View File

@ -4,7 +4,7 @@
// @dart = 2.6
import 'dart:html' as html;
import 'dart:math' as math;
import 'package:ui/src/engine.dart';
import 'package:ui/ui.dart';
import 'package:test/test.dart';
@ -47,6 +47,20 @@ void main() async {
await matchGoldenFile('canvas_arc_to_point.png', region: region);
});
test('Path.addArc that starts new path has correct start point', () async {
final Rect rect = Rect.fromLTWH(20, 20, 200, 200);
final Path p = Path()
..fillType = PathFillType.evenOdd
..addRect(rect)
..addArc(Rect.fromCircle(center: rect.center,
radius: rect.size.shortestSide / 2), 0.25 * math.pi, 1.5 * math.pi);
canvas.drawPath(p, SurfacePaintData()
..color = Color(0xFFFF9800) // orange
..style = PaintingStyle.fill);
html.document.body.append(canvas.rootElement);
await matchGoldenFile('canvas_addarc.png', region: region);
});
}
void paintArc(BitmapCanvas canvas, Offset offset,