DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
29,084 Commits 882 Branches 1,069 Tags
Commit Graph

29084 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Brandon DeRosier
810607e52c [Impeller] Simplify CreateContentsForGeometry overloads (flutter/engine#42306) 
Came across this while working on generic fallbacks for mask blurs. For
the unique_ptr case, we always capture ownership and convert to a
shared_ptr anyhow. For the shared_ptr case, we always need to capture a
copy, and so better to not take a const ref and allow the caller to move
if possible.
 2023-05-24 20:54:45 -07:00
skia-flutter-autoroll
c9a0208693 Roll Skia from 150d534341a4 to 7ec172b433f1 (1 revision) (flutter/engine#42305) 
https://skia.googlesource.com/skia.git/+log/150d534341a4..7ec172b433f1

2023-05-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 881cfa15a343 to 2b787917e4a3

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-25 03:43:22 +00:00
keyonghan
795a726b5f Append $flutter/osx sdk property to existing platforms/targets relying on xcode (flutter/engine#42299) 
Part of https://github.com/flutter/flutter/issues/127534
 2023-05-25 01:37:29 +00:00
skia-flutter-autoroll
f65b68e13c Roll Dart SDK from 9bea16a7dcbd to 96e29af6e0c6 (1 revision) (flutter/engine#42303) 
https://dart.googlesource.com/sdk.git/+log/9bea16a7dcbd..96e29af6e0c6

2023-05-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-143.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-25 00:55:49 +00:00
skia-flutter-autoroll
0fea388f04 Roll Skia from 76bae143aded to 150d534341a4 (2 revisions) (flutter/engine#42301) 
https://skia.googlesource.com/skia.git/+log/76bae143aded..150d534341a4

2023-05-24 michaelludwig@google.com [skif] Add max sample radius to SkImageFilters::RuntimeShader
2023-05-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 84c82fea3f43 to 9ad20521dc02 (8 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-25 00:46:18 +00:00
gaaclarke
dc22f5f572 [Impeller] Turn on vulkan tests for mac CI. (flutter/engine#42225) 
This uses swiftshader to run the tests on mac.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-05-24 23:25:06 +00:00
Jonah Williams
32d648ec7f [Impeller] fix UV and color blending. (flutter/engine#42293) 
Fixes https://github.com/flutter/flutter/issues/127486

Combinations of UV mapping and color blending would cause us to double apply the UV mapping which rendered either nothing or garbage.

Before:

![image](https://github.com/flutter/engine/assets/8975114/84cfbd68-9025-42d2-98be-72af7e26d8be)

After:

![image](https://github.com/flutter/engine/assets/8975114/4a0d5a11-d2a0-48a4-885e-32310d62a6c7)
 2023-05-24 22:57:42 +00:00
godofredoc
a98191b4c0 Use engine_v2 builds on recipe testing. (flutter/engine#42298) 
This is removing the legacy builds from recipes testing and adding the engine v2 ones.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-05-24 22:56:16 +00:00
Jason Simmons
1007f8bea6 [Impeller] Golden test for text with a shader and a transform (flutter/engine#42291) 
See https://github.com/flutter/engine/pull/42142
 2023-05-24 22:07:47 +00:00
skia-flutter-autoroll
81bab68c8f Roll Skia from 593ece8f74c7 to 76bae143aded (13 revisions) (flutter/engine#42295) 
https://skia.googlesource.com/skia.git/+log/593ece8f74c7..76bae143aded

2023-05-24 herb@google.com Test for checking that FMA has at least 63 bits
2023-05-24 kjlubick@google.com Expose Paragraph.unresolvedCodepoints
2023-05-24 kjlubick@google.com Move gpu-specific methods off SkSurface
2023-05-24 robertphillips@google.com [graphite] Remove usage of GrClip in should_tile_image_id
2023-05-24 jvanverth@google.com [graphite] Set up VK_KHR_dynamic_rendering extension
2023-05-24 lovisolo@google.com Delete all Win8 tasks.
2023-05-24 robertphillips@google.com [graphite] Move the bicubic padding constant out of GrBicubicEffect
2023-05-24 drott@chromium.org [Fontations] Implement onOpenStream for SkTypeface_Fontations
2023-05-24 cmumford@google.com Update Skia milestone to 116
2023-05-24 cmumford@google.com Merge 13 release notes into RELEASE_NOTES.md
2023-05-24 fmalita@chromium.org Reland "[skottie] Don't revalidate during render()"
2023-05-24 brianosman@google.com Remove empty SkOpts files (crc32, sse42)
2023-05-24 jvanverth@google.com [graphite] Add VulkanImageView support to VulkanTexture.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-24 21:30:24 +00:00
Mouad Debbar
3784b3880f [web] Remove comment about dart:html migration (flutter/engine#42290) 
Migration has already happened in [this PR](https://github.com/flutter/engine/pull/33370/files#diff-30cfc07b03caec6d1c915b40a9e50a23d1f1a1c54c670d5996199d805b077daeR213) so the comment is not relevant anymore.
 2023-05-24 20:35:15 +00:00
Mouad Debbar
04afaaf25e [web] Hide JS types from dart:ui_web (flutter/engine#42252) 
In order to use the exported `PlatformLocation` cross-platform, we need to remove any JS types from the interface. Namely, `DomEventListener`.

Required by https://github.com/flutter/flutter/pull/126851
 2023-05-24 20:26:23 +00:00
skia-flutter-autoroll
ce619437f2 Roll Fuchsia Mac SDK from qoLy9E5PjnAlICjUb... to RSSC61ubl9JXmn4JO... (flutter/engine#42287) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-24 20:10:05 +00:00
Ashish Myles
a96b23fa7e [web] Update a11y announcements to append divs instead of setting content. (flutter/engine#42258) 
This also removes the appended divs after a short time so that screen readers don't navigate to it, especially when users are entering the DOM to enable accessiblity.

Fixes https://github.com/flutter/flutter/issues/127335.
 2023-05-24 20:08:21 +00:00
Jonah Williams
5fbc30881d [Impeller] fix Xcode frame capture. (flutter/engine#42289) 
This fixed things for me locally. Confirmed frame captures work and this block otherwise doesn't fire when running regularly
 2023-05-24 19:32:06 +00:00
Jason Simmons
4c29368376 [Impeller] Create an autorelease pool for Impeller tests running on macOS. (flutter/engine#42265) 
See https://github.com/flutter/flutter/issues/127358
 2023-05-24 19:16:13 +00:00
skia-flutter-autoroll
a8f1d8d242 Roll Dart SDK from d46987001f76 to 9bea16a7dcbd (2 revisions) (flutter/engine#42286) 
https://dart.googlesource.com/sdk.git/+log/d46987001f76..9bea16a7dcbd

2023-05-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-142.0.dev
2023-05-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-141.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-24 18:05:20 +00:00
Jason Simmons
a5f4c7ffba [Impeller] Disable the offscreen layer checkerboard drawing function on Impeller. (flutter/engine#42221) 
This function creates a Skia bitmap that can not be rendered by Impeller.

See https://github.com/flutter/flutter/issues/127080
 2023-05-24 17:11:01 +00:00
skia-flutter-autoroll
072ef18be0 Roll Skia from 14e1667e8031 to 593ece8f74c7 (3 revisions) (flutter/engine#42284) 
https://skia.googlesource.com/skia.git/+log/14e1667e8031..593ece8f74c7

2023-05-24 robertphillips@google.com [graphite] Use SkCanvas::QuadAAFlags more in the Ganesh Device (esp. drawImageQuad)
2023-05-24 kjlubick@google.com Reland "Remove legacy SkSurface factories"
2023-05-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from cd2d20c6e4a3 to 84c82fea3f43 (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-24 17:05:53 +00:00
Brandon DeRosier
d6a717c958 [Impeller] Add 1 pixel border to snapshots of Contents (flutter/engine#42277) 
Everything in Impeller is theoretically treated as if being drawn to
layers of infinite size. Without this change, there's a coverage leak
that occurs in some filters due to the customizable sampling mode. I
should be able to get rid of this 1 pixel padding by refactoring the way
we do sampling in the filter inputs (we already have most of this
infrastructure in place), but this is a correct, safe, and
not-that-expensive solution for the time being.
 2023-05-24 09:46:46 -07:00
Mouad Debbar
3a4677a6d7 [web] Cleanup assertionsEnabled (flutter/engine#41829) 
For consistency with the rest of the flutter code, this PR explores the possibility of removing our proprietary `assertionsEnabled`.
 2023-05-24 15:08:50 +00:00
skia-flutter-autoroll
bb5340e0d1 Roll Fuchsia Linux SDK from -dXJ_pnUVwmjscIYm... to UYN_Tk7M6_5d2aGIj... (flutter/engine#42280) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-24 15:07:11 +00:00
skia-flutter-autoroll
6ce9bd2fbf Roll Skia from fbae152253ac to 14e1667e8031 (3 revisions) (flutter/engine#42279) 
https://skia.googlesource.com/skia.git/+log/fbae152253ac..14e1667e8031

2023-05-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 3f633521356d to c74dae154363 (10 revisions)
2023-05-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from ddf59ec4e8fc to 881cfa15a343 (6 revisions)
2023-05-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from cd1fb6876701 to 028726497ad3 (19 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-24 15:03:05 +00:00
skia-flutter-autoroll
6b93a153d6 Roll Skia from 69f7860093b4 to fbae152253ac (3 revisions) (flutter/engine#42276) 
https://skia.googlesource.com/skia.git/+log/69f7860093b4..fbae152253ac

2023-05-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from a74d1a1b81a6 to 881cfa15a343
2023-05-23 sunnyps@chromium.org graphite: Change empty submit logs to debug level
2023-05-23 49699333+dependabot[bot]@users.noreply.github.com Bump socket.io-parser and socket.io in /modules/pathkit

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-24 06:04:16 +00:00
Brandon DeRosier
6c9a9ab884 [Impeller] Add golden repro for mask blur issues (flutter/engine#42275) 
Part of https://github.com/flutter/flutter/issues/127013.

This is a repro to track the mask blur issues. If we accidentally
trigger the wrong kind of blur, this golden will make it obvious because
the gradient lines will become much more blurry.

Once this problem is fixed, the circle's mask should be fully blurred
and the rounded rectangle should have no edge clamping (the diagonal
lines should continue as the edges fade to black).
 2023-05-23 22:53:53 -07:00
skia-flutter-autoroll
e974ef7e27 Roll Fuchsia Mac SDK from aAjEDVse7qfMt0NqE... to qoLy9E5PjnAlICjUb... (flutter/engine#42273) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-24 05:14:23 +00:00
Brandon DeRosier
58ad391722 [Impeller] Start of Dart GPU prototype (flutter/engine#42228) 
I've been slowly hacking on a prototype alongside a doc (public go link [imminent](https://github.com/flutter/website/pull/8716)) for a while (the doc has been changing a lot as a result of prototyping) and I think it's time to start landing parts of this prototype/experiment in-tree.

This initial PR just sets up the main context singleton on the UI thread. After this, I'll land the shader management stuff.

I re-used the existing experimental 3D flag for this, since this is meant to replace what can be done with Impeller Scene anyway.
 2023-05-24 04:22:42 +00:00
skia-flutter-autoroll
1ef5f6d0dc Roll Dart SDK from 7546e99f8a50 to d46987001f76 (1 revision) (flutter/engine#42274) 
https://dart.googlesource.com/sdk.git/+log/7546e99f8a50..d46987001f76

2023-05-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-140.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-24 04:22:41 +00:00
Brandon DeRosier
6828abffee [Impeller] Set the coverage hint on everything (flutter/engine#42264) 
Attaches a minimum coverage hint to all rendered entities. This makes ImageFilter blurs do less work when clipped. We can utilize this in a number of other filters as well.

![Screenshot 2023-05-23 at 3 16 49 PM](https://github.com/flutter/engine/assets/919017/5b7182c8-e704-4c4a-bb71-fdf226a60f4e)

The test I added also demonstrates a sampling issue in the gaussian blur that I'm trying to work out. Here it is without any clipping. This coverage hint change does not introduce the issue:

![Screenshot 2023-05-23 at 3 08 15 PM](https://github.com/flutter/engine/assets/919017/524c2fb1-3b58-4589-824b-0794c2bd5ea2)
 2023-05-24 02:06:19 +00:00
Brandon DeRosier
e9298a1d2a [Impeller] Limit rrect blur kernel to 1000x1000 (flutter/engine#42269) 
Impose the same large limit as the slower 2-pass blur.

Also renames "RRectShadow" to the much less ambiguous "SolidRRectBlur".

Before, a large enough blur sigma would result in nothing getting drawn. The Gaussian integral seems to be working fine against 16bit ops, so no adjustments were needed in the shader.

![Screenshot 2023-05-23 at 4 08 41 PM](https://github.com/flutter/engine/assets/919017/108e01ce-2cf1-4bc9-b51b-7f4ad7288fac)
 2023-05-24 01:59:17 +00:00
godofredoc
79407cfd52 Add builders for second level cache of builders. (flutter/engine#42271) 
These builders will generate CAS caches to optimize engine checkouts.

Bug: https://github.com/flutter/flutter/issues/127433

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-05-24 01:33:06 +00:00
Jonah Williams
61c017d2f6 [Impeller] remove framebuffer blending from atlas, fix transform scale (flutter/engine#42254) 
Fixes https://github.com/flutter/flutter/issues/127374
 2023-05-24 00:01:33 +00:00
gaaclarke
9258309eed Turned back on debug unit tests (flutter/engine#42261) 
I refactored the `EXPECT_EXIT` tests since they are unsafe to execute in a process with multiple threads.

This leaves `flutter_desktop_darwin_unittests` disabled since it has existing issues.

fixes https://github.com/flutter/flutter/issues/103757

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-05-23 23:13:35 +00:00
skia-flutter-autoroll
a24e302b6d Roll Dart SDK from 90b4df96e9dc to 7546e99f8a50 (3 revisions) (flutter/engine#42260) 
https://dart.googlesource.com/sdk.git/+log/90b4df96e9dc..7546e99f8a50

2023-05-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-139.0.dev
2023-05-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-138.0.dev
2023-05-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-137.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-23 22:39:34 +00:00
skia-flutter-autoroll
f79135b34a Roll Skia from 28946eda0f6d to 69f7860093b4 (6 revisions) (flutter/engine#42262) 
https://skia.googlesource.com/skia.git/+log/28946eda0f6d..69f7860093b4

2023-05-23 kjlubick@google.com Add placeholders to pdf.gni for SkJpegInfo
2023-05-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 8a3971e5e9c5 to cd2d20c6e4a3 (3 revisions)
2023-05-23 weiyuhuang@google.com Fix Line Break Rounding
2023-05-23 jacksongardner@google.com Create a `GrExternalTextureGenerator` that is usable outside skia.
2023-05-23 kjlubick@google.com Guard extra implementation of SkGetJpegInfo
2023-05-23 brianosman@google.com Avoid redefinition errors in Flutter

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-23 22:34:46 +00:00
skia-flutter-autoroll
35bf453e4d Roll Skia from 292879d286e9 to 28946eda0f6d (5 revisions) (flutter/engine#42257) 
https://skia.googlesource.com/skia.git/+log/292879d286e9..28946eda0f6d

2023-05-23 michaelludwig@google.com [skif] Match decl/def parameter name in merge filter
2023-05-23 jvanverth@google.com [graphite] Clean out ProxyCache before unrefing Resources' cacheref.
2023-05-23 nicolettep@google.com Change Descriptors.h -> DescriptorTypes.h
2023-05-23 nicolettep@google.com [graphite] Get vertex & frag shader for Vulkan pipeline creation
2023-05-23 brianosman@google.com Remove SkOpts::hash_fn

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-23 19:44:05 +00:00
Jonah Williams
be33a58e18 [Impeller] Encode render passes concurrently on iOS. (flutter/engine#42028) 
Allows pushing encoding of command buffers to a worker thread, relying on the fact that these buffers are always scheduled in the order that they are enqueued. This follows the guidelines from https://developer.apple.com/documentation/metal/mtlcommandbuffer?language=objc
 2023-05-23 19:40:05 +00:00
Jesse Seales
3e4dabb16d Revert "Vuln scan on 3p deps triggered by label on PR" (flutter/engine#42256) 
Reverts flutter/engine#42247

Reverting in order to find solution which doesn't add a skipped test onto all PRs. Only PRs which address vuln scanning need to have this test showing at all.
 2023-05-23 19:08:54 +00:00
Jesse Seales
c7bcd52ec2 Vuln scan on 3p deps triggered by label on PR (flutter/engine#42247) 
This change allows for anyone submitting a PR which resolves a vulnerability found from the scanning action to be run on the PR to check for resolution if the label 'vulnerability patch' is applied to the PR. 

*List which issues are fixed by this PR. You must list at least one issue.*
b/283970087

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-05-23 18:42:21 +00:00
Jonah Williams
52b5bc5340 Revert "[Impeller] use host image upload path on simulator" (flutter/engine#42212) 
Reverts flutter/engine#42161

As reported by uses, this did not help with the issue.
 2023-05-23 18:22:47 +00:00
Alexander Aprelev
d28219a3b1 Roll buildroot to 5cab8e095066d8f3de063943af26b7336aa52662 (flutter/engine#42251) 
Changes since last roll

```
5cab8e0 Keep dictionary items sorted when updating dart deps. (#730)
1f35873 Forward inputs from wasm libraries. (#729)
```
 2023-05-23 11:03:10 -07:00
Jesse Seales
4caf5b7de7 Vulnerability scanning print failed command in case of error (flutter/engine#42190) 
The 3p deps vulnerability scanner currently isn't providing helpful output in the case of errors during the processing of the dependencies. This change adds outputting which command caused the error, and conditionally add error output to help aid any changes that need to be made to the dependencies.

*List which issues are fixed by this PR. You must list at least one issue.*
b/282959127

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-05-23 17:51:17 +00:00
skia-flutter-autoroll
30c213e526 Roll Fuchsia Linux SDK from Zbd3haNY2Idcdu1Fj... to -dXJ_pnUVwmjscIYm... (flutter/engine#42250) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-23 17:22:21 +00:00
gaaclarke
5ed6890c14 [Impeller] Removed last ivars to raw vk::Device's. (flutter/engine#42215) 
Removes the last ivars that hold onto a `Device` directly.  This have recently been the cause of crashes, so the safer thing is to remove them all.

For the Allocator and the Sampler library, removing the device ivars is likely just a precaution since they should have only been accessed from the raster thread and killed before the Device.  The fence waiter however was potentially accessing the device from a separate thread, so that was much more risky and likely to cause crashes.

Testing: The existing `impeller_unittests` verify this is setup correctly.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-05-23 17:03:19 +00:00
skia-flutter-autoroll
8fbc30e305 Roll Skia from 225d51031ad0 to 292879d286e9 (5 revisions) (flutter/engine#42249) 
https://skia.googlesource.com/skia.git/+log/225d51031ad0..292879d286e9

2023-05-23 jlavrova@google.com Removing an extra (wrong) placeholder for CLIENT_ICU
2023-05-23 michaelludwig@google.com Revert "[skif] Remove dedicated SkDropShadowImageFilter implementation"
2023-05-23 michaelludwig@google.com [skif] Remove legacy SkImageImageFilter implementation
2023-05-23 brianosman@google.com Reland "Replace SkOpts::hash/hash_fn with SkChecksum::Hash32"
2023-05-23 michaelludwig@google.com Reland "[skif] Add FilterResult::Builder and update SkMergeImageFilter to use it"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-23 16:53:55 +00:00
Zachary Anderson
fa4d9d029d Build arm64 FlutterEmbedder.framework and lipo the result (flutter/engine#42233) 
This PR modifies the mac_host_engine build config to build the
FlutterEmbedder.framework for arm64, and adds a generator that creates a
fat framework containing both the intel and arm64 dylibs. The fat
framework is uploaded to the gcs bucket instead of the thin intel-only
one.

The script to create the lipo'd embedder framework is different enough
from the desktop framework to have a separate script, but this still
triggers the pylint duplicate-code check. Due to a bug in our version of
pylint (https://github.com/pylint-dev/pylint/issues/214), it isn't
possible to disable per-file, so this PR also disables the check
globally.
 2023-05-23 09:50:25 -07:00
Alexander Aprelev
90ee66eeaa Roll watcher dependency for web_ui to 1.1.0. (flutter/engine#42248) 
Incoming dart sdk roll
https://dart.googlesource.com/sdk.git/+log/90b4df96e9dc..4881eadbade6
needs updated version of watcher due to FileSystemEvent becoming sealed.
 2023-05-23 09:44:20 -07:00
Mouad Debbar
9aec8c5c62 [web] Move platformViewRegistry to ui_web (flutter/engine#41877) 
In this PR, I'm leaving a getter for `platformViewRegistry` in `dart:ui` for backwards compatibility. At some point, we need to properly deprecate it (e.g. print a warning asking users to import it from `dart:ui_web` instead).

Next step is to migrate all call sites in flutter/flutter, flutter/packages and flutter/devtools (anything else?).

Issue: https://github.com/flutter/flutter/issues/126831

Fixes https://github.com/flutter/flutter/issues/41563
 2023-05-23 16:17:56 +00:00
skia-flutter-autoroll
e784e3174d Roll Skia from 3ded22186598 to 225d51031ad0 (1 revision) (flutter/engine#42246) 
https://skia.googlesource.com/skia.git/+log/3ded22186598..225d51031ad0

2023-05-23 kjlubick@google.com Make codec registration for decoding explicit

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,rmistry@google.com,scroggo@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-23 14:59:34 +00:00
skia-flutter-autoroll
1c4967760e Roll Fuchsia Mac SDK from DzmjiSg6XC0JUfbKP... to aAjEDVse7qfMt0NqE... (flutter/engine#42245) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-23 14:45:41 +00:00