DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
34,577 Commits 882 Branches 1,069 Tags
Commit Graph

34577 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
skia-flutter-autoroll
80e30c40cf Roll Fuchsia Linux SDK from gJ4Wr2FSpnGmoN3ke... to L6_XzizcJqjneCvGA... (flutter/engine#51317) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-11 00:45:22 +00:00
skia-flutter-autoroll
e2c3b1b5e2 Roll Skia from 8b92038ff67f to e6b884229d2d (1 revision) (flutter/engine#51316) 
https://skia.googlesource.com/skia.git/+log/8b92038ff67f..e6b884229d2d

2024-03-10 bungeman@google.com Roll FreeType from 47574f7e to f42ce255 (6 commits)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-10 01:02:22 +00:00
skia-flutter-autoroll
581424e681 Roll Fuchsia Linux SDK from lAV5jgp4796siOZgI... to gJ4Wr2FSpnGmoN3ke... (flutter/engine#51315) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-09 23:43:29 +00:00
skia-flutter-autoroll
01ccdad771 Roll Skia from 983774f73a16 to 8b92038ff67f (1 revision) (flutter/engine#51313) 
https://skia.googlesource.com/skia.git/+log/983774f73a16..8b92038ff67f

2024-03-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 774824681faa to d3a09c4c5ada (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-09 22:38:23 +00:00
Zachary Anderson
1da67e6666 Roll buildroot to e9df434539745202fa5f9b729fe5f82e5de3f025 (flutter/engine#51306) 
To pick up https://github.com/flutter/buildroot/pull/834
 2024-03-09 21:04:04 +00:00
Zachary Anderson
0b18c484ac Explicitly list Android embedding dependency jars in GN (flutter/engine#51303) 
Part of https://github.com/flutter/flutter/issues/144430.

From `gn help inputs`: "It may be tempting to write a script that
enumerates all files in a directory
  as inputs. Don't do this!"
 2024-03-09 12:02:46 -08:00
skia-flutter-autoroll
350b904b4c Roll Skia from 0da56a6c7446 to 983774f73a16 (1 revision) (flutter/engine#51311) 
https://skia.googlesource.com/skia.git/+log/0da56a6c7446..983774f73a16

2024-03-09 mike@reedtribe.org rename local struct to DPoint, to distinguish it from Mac's global type

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-09 19:16:40 +00:00
skia-flutter-autoroll
b3ce5b7926 Roll Dart SDK from 02e78997f308 to c3bd630e89bb (1 revision) (flutter/engine#51309) 
https://dart.googlesource.com/sdk.git/+log/02e78997f308..c3bd630e89bb

2024-03-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-220.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-09 11:03:50 +00:00
skia-flutter-autoroll
d39607851f Roll Skia from 8feb4b6a4aa6 to 0da56a6c7446 (1 revision) (flutter/engine#51308) 
https://skia.googlesource.com/skia.git/+log/8feb4b6a4aa6..0da56a6c7446

2024-03-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 563dc550e3e6 to 774824681faa (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-09 09:48:22 +00:00
skia-flutter-autoroll
2eb63be634 Roll Dart SDK from b52b754d5d3e to 02e78997f308 (1 revision) (flutter/engine#51307) 
https://dart.googlesource.com/sdk.git/+log/b52b754d5d3e..02e78997f308

2024-03-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-219.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-09 06:34:34 +00:00
skia-flutter-autoroll
690259fcea Roll Skia from 3b0b79511469 to 8feb4b6a4aa6 (18 revisions) (flutter/engine#51305) 
https://skia.googlesource.com/skia.git/+log/3b0b79511469..8feb4b6a4aa6

2024-03-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 886dbf1a5a87 to 912fc2090a1b
2024-03-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from fa4c93a17fe6 to b440ca2fa89c (1 revision)
2024-03-08 bungeman@google.com Remove SkScalerContextFTUtils::drawCOLRv1Glyph assert
2024-03-08 nscobie@google.com Experimenting with OWNERS.android rules for SkUserConfig.h files
2024-03-08 jvanverth@google.com [graphite] Add limited resource test for PathAtlases.
2024-03-08 robertphillips@google.com [graphite] Add Android precompile code path
2024-03-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 3d5581c920a3 to 563dc550e3e6 (5 revisions)
2024-03-08 bungeman@google.com Add --fontations flag to test Fontations
2024-03-08 robertphillips@google.com Actually propagate the stable key to the blur runtime effects
2024-03-08 mike@reedtribe.org Reapply "factor out SkCTFontCreateExactCopy into its own file(s)"
2024-03-08 jvanverth@google.com [graphite] Disable MSAA support on Mac Intel devices.
2024-03-08 kjlubick@google.com Reland "Fix debugger bazel build"
2024-03-08 fmalita@chromium.org [dm] Skip empty sources
2024-03-08 kjlubick@google.com Remove some dead code guarded by legacy defines
2024-03-08 lovisolo@google.com [bazel] Fix //tools/viewer.
2024-03-08 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from 00ea56c88561 to 055af5b4a051 (4 revisions)
2024-03-08 robertphillips@google.com Final batch of StableKeys ...
2024-03-08 robertphillips@google.com Revert "factor out SkCTFontCreateExactCopy into its own file(s)"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-09 03:23:16 +00:00
skia-flutter-autoroll
388e358166 Manual roll Dart SDK from 4c64fcc134bf to b52b754d5d3e (6 revisions) (flutter/engine#51304) 
Manual roll requested by zra@google.com

https://dart.googlesource.com/sdk.git/+log/4c64fcc134bf..b52b754d5d3e

2024-03-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-218.0.dev
2024-03-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-217.0.dev
2024-03-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-216.0.dev
2024-03-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-215.0.dev
2024-03-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-214.0.dev
2024-03-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-213.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-09 03:21:13 +00:00
skia-flutter-autoroll
31cf68fe0c Roll Skia from a4fb847f47d9 to 3b0b79511469 (1 revision) (flutter/engine#51289) 
https://skia.googlesource.com/skia.git/+log/a4fb847f47d9..3b0b79511469

2024-03-08 michaelludwig@google.com Revert "Fix debugger bazel build"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-09 01:44:34 +00:00
Chinmay Garde
dfb7d84ab8 [Impeller] Use the AHB prefix for utils that work with Android Hardware Buffers. (flutter/engine#51298) 
Also doesn't compile the TU on non-Android platforms.

Part of https://github.com/flutter/engine/pull/51213 being chopped up.

No change in functionality. Just renames and moves stuff around.
 2024-03-09 00:52:25 +00:00
Chinmay Garde
fcba196886 [Impeller] Make DeviceHolder follow convention for backend specific utilities. (flutter/engine#51300) 
Utilities below the HAL that are backend specific have the VK (in case of Vulkan) suffix. The only class that doesn't follow this convention is/was DeviceHolder. This caused some confusion when reading code leading to wondering what a device holder above the HAL was supposed to do/mean. Adds the VK suffix to device holder with a docstring. Also adds the file the source set as it was missing.

No change in functionality. Just a rename of an existing class.
 2024-03-09 00:28:46 +00:00
gaaclarke
b220a37102 [Impeller] implement mask blur for textures (flutter/engine#51183) 
fixes https://github.com/flutter/flutter/issues/144266

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-03-08 15:58:03 -08:00
Zachary Anderson
286169bb52 Don't rely on dart binary on PATH in run_test.py (flutter/engine#51302) 2024-03-08 23:49:32 +00:00
Juanjo Tugores
976d528d71 Mark the Flutter Views as focusable by setting a tabindex value. (flutter/engine#50876) 
Mark the Flutter View as focusable by setting a tabindex value.

* When a given flutter view is focused its tabindex will be `-1`
* When a given flutter view is not focused its tabindex will be `0`
* When semantics are enabled no tabindex will be set.

Relevant Issues are:

* Design doc: https://flutter.dev/go/focus-management 
* Focus in web multiview: https://github.com/flutter/flutter/issues/137443
* Platform dispatcher changes: https://github.com/flutter/engine/pull/49841

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-03-08 23:36:16 +00:00
Chinmay Garde
4f8e474738 Update the instructions for updating licenses. (flutter/engine#51297) 
* Adds markdown formatting to better highlight the important bits.
* Removes the bit about patch files not being valid because they are
copied from the GitHub UI (we use LUCI now).
* Add a shortcut for Mac to apply the patch from your pasteboard.
 2024-03-08 15:18:01 -08:00
Harry Terkelsen
4c86674a0f Optimize overlays in CanvasKit (flutter/engine#47317) 
Optimize overlays by detecting when Flutter-rendered content intersects
with platform views. Overlay canvases are only needed when the content
intersects, so by checking for this, we can optimize out most overlays.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-03-08 14:28:24 -08:00
skia-flutter-autoroll
4dc296c0ab Roll Fuchsia Linux SDK from 5Ra_AjCji-uR1GaX7... to lAV5jgp4796siOZgI... (flutter/engine#51296) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-08 22:09:14 +00:00
Chinmay Garde
03a4ec697e [Impeller] Add the KHR prefix to existing swapchain utilities. (flutter/engine#51295) 
This is part of blowing up https://github.com/flutter/engine/pull/51213 into smaller commits.

Our current swapchain is based on the VK_KHR_swapchain extension. When this was the only swapchain that could be created, the KHR prefix was dropped. Since we are going to be having multiple swapchain types, add the KHR prefix and make room for other swapchains.

No change in functionality. Just renames classes and files.
 2024-03-08 22:07:23 +00:00
Zachary Anderson
e1b970ca47 Revert test if changes to golden tests (flutter/engine#51291) 
The tests are not running when they should be:
https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20Engine%20Drone/760676/overview
 2024-03-08 13:31:18 -08:00
Justin McCandless
3a07dc741a iPad keyboard cut/copy/paste buttons (flutter/engine#50923) 
The cut/copy/paste buttons above the keyboard on iPad were previously always greyed out, but now they work.
 2024-03-08 13:30:50 -08:00
Dan Field
a4c787e072 Use io.flutter.Build.API_LEVELS rather than android.os.Build.VERSION_CODES (flutter/engine#51171) 
Updates the linting script to ban the use of `VERSION_CODES`.

We currently have a mish-mash of using the integers, using `VERSION_CODES`, and even how we import the version codes. This makes it more confusing when doing things like #51070 - I think it is clearer to see `22` than `LOLLIPOP_MR1`.

I'd like to get LGTM (or at least no opinion) from all the requested reviewers here.
 2024-03-08 19:04:20 +00:00
Jonah Williams
bcea8bd101 [Impeller] More efficient usage of transient onscreen attachments. (flutter/engine#51206) 
Work towards https://github.com/flutter/flutter/issues/144617

> The primary trick here is making sure that the transient attachments for the onscreen (MSAA and Depth/Stencil) are effectively recycled. In fact, I think we can actually make a single Onscreen MSAA and Onscreen Depth/Stencil and share them across the swapchain images - as they should be effectively synchronized already.

Fixes https://github.com/flutter/flutter/issues/141750
 2024-03-08 17:27:17 +00:00
zijiehe@
3ad51979fd [Fuchsia] Providing FUCHSIA_SDK_PATH env var for fuchsia lsc (flutter/engine#51234) 
This change updates test-scripts with https://crrev.com/c/5347216 so that it can override the sdk location from an env var. The override location can be used by update_product_bundles to download emulator images of an unreleased sdk from gcs buckets. The process is used by fuchsia lsc (https://ci.chromium.org/ui/p/turquoise/builders/global.ci/sdk-core-linux-flutter), now it's failing due to the wrong product_bundle location being used.

This change should have no impact to the existing builders since they do not use either gclient variables relevant. E.g. download_fuchsia_sdk and fuchsia_sdk_path.

Bug: http://b/328110079

FYI: @mbrase 

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-03-08 17:21:05 +00:00
Chris Bracken
c1415300a1 Migrate vulkan_memory_allocator to flutter/third_party (flutter/engine#51275) 
Migrates vulkan_memory_allocator from the buildroot's third_party directory to the engine's.

Issue: https://github.com/flutter/flutter/issues/144812
Part of: https://github.com/flutter/flutter/issues/67373

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-03-08 17:17:16 +00:00
Jason Simmons
7da9c29b79 Update CI scripts to use either src/flutter/third_party/dart or src/third_party/dart (flutter/engine#51276) 
See https://github.com/flutter/flutter/issues/143335
 2024-03-08 17:00:17 +00:00
Martin Kustermann
899fc2a7e0 Add fuchsia_gn_sdk GN variable pointing to //flutter/tools/fuchsia/gn-sdk (flutter/engine#51287) 
The Dart -> Flutter Engine autoroller seems to be failing atm due to
fuchsia build errors.

The Dart SDK CL in [0] is depending on a fuchsia gn sdk import. The
import path defaults to `//third_party/fuchsia/gn-sdk` in the Dart build
rules.

Though flutter seemingly has it in `//flutter/tools/fuchsia/gn-sdk`
(which was added to DEPS in c274921fa6034e5e133129967c0789ab8c7fc827)

=> This is an attempt to override the default & fix autoroller

[0] https://dart-review.googlesource.com/c/sdk/+/355283/14
 2024-03-08 14:49:37 +01:00
skia-flutter-autoroll
53ce36aad5 Roll Skia from 993a88a663c8 to a4fb847f47d9 (1 revision) (flutter/engine#51283) 
https://skia.googlesource.com/skia.git/+log/993a88a663c8..a4fb847f47d9

2024-03-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from f2cacee81b83 to 3d5581c920a3 (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-08 08:27:05 +00:00
skia-flutter-autoroll
fcfcb88ae9 Roll Skia from 15f8d03a9594 to 993a88a663c8 (1 revision) (flutter/engine#51282) 
https://skia.googlesource.com/skia.git/+log/15f8d03a9594..993a88a663c8

2024-03-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 58cd45951deb to 00ea56c88561 (8 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-08 06:38:22 +00:00
skia-flutter-autoroll
0c2b784e45 Roll Skia from 093994f8f078 to 15f8d03a9594 (1 revision) (flutter/engine#51280) 
https://skia.googlesource.com/skia.git/+log/093994f8f078..15f8d03a9594

2024-03-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 0dc646b71e8d to 886dbf1a5a87 (11 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-08 05:46:21 +00:00
skia-flutter-autoroll
a802ee4564 Roll Skia from bf3f9c5f0edb to 093994f8f078 (1 revision) (flutter/engine#51278) 
https://skia.googlesource.com/skia.git/+log/bf3f9c5f0edb..093994f8f078

2024-03-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 0dc646b71e8d to 886dbf1a5a87

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-08 03:36:17 +00:00
Brandon DeRosier
e4a8c84807 [Impeller] Add mask blur style support to the RRect blur fast path. (flutter/engine#51250) 
This improves performance by avoiding the 2-pass Gaussian blur in more shadow drawing situations.

The new golden also serves as a good reference for how mask blurs are supposed to work alongside various other paint properties such as color filters, color opacity, image filters, and blending.

![Screenshot 2024-03-06 at 11 47 04 PM](https://github.com/flutter/engine/assets/919017/dee1b56c-d2e4-40bd-9f50-aeba0cfd69f2)

The top 5 shapes are various RRect cases and are rendering correctly via the new blur style implementation in this patch.
The two bottom rows (the triangles and arcs) are non-rrect paths, so they're falling back to rendering using the 2-pass Gaussian blur. Rendering errors are circled in red below:

![Screenshot 2024-03-06 at 11 47 04 PM](https://github.com/flutter/engine/assets/919017/5ac27d71-95e6-4e6e-99d8-7436476e1aee)

* Cases 1, 2, 7, and 9 all appear to rendering fine.
* Cases 3, 4, 5, and 6 all have mask blur styles set to `BlurStyle::kSolid`. After the first clipped overlay has been drawn, subsequent clipped overlays aren't drawing.
* Case 6 is also has the blend mode set to `BlendMode::kExclusion`.
* Cases 8 and 10 are rendering with `BlurStyle::kInner` and `BlurStyle::kOuter` respectfully, but with a blur ImageFilter also set on the paint state. The ImageFilter needs to be applied to the rasterized mask blurred content.
 2024-03-08 01:36:09 +00:00
gaaclarke
0ad1f44859 [Impeller] moved tests to aiks_blur_unittests, added warning (flutter/engine#51274) 
issue: https://github.com/flutter/flutter/issues/140106

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-03-07 17:29:19 -08:00
Chris Bracken
0575633c34 Move ANGLE to flutter/third_party (flutter/engine#51270) 
This moves Flutter out of the buildroot's third_party directory and into
//flutter/third_party and updates all BUILD and gni files.

Issue: https://github.com/flutter/flutter/issues/144786
Part of: https://github.com/flutter/flutter/issues/67373

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] The odds of this passing on its first CI run is 0%, because
there's no way the licence script isn't going to have a fit over it, at
which point I promise on my honour that I will dutifully fix all the
things it complains about and re-run, probably more than once.
- [X] This PR fulfils the minimum [Canadian
Content](https://www.youtube.com/watch?v=h9NMnPm5kXc&list=PLJ7QPuvv91JuoPWrLhqX0zDFUoLdynMEk&index=3)
regulations mandated by the CRTC.
- [X] I signed the [CLA].
- [X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-03-07 16:23:14 -08:00
skia-flutter-autoroll
d620dd0864 Roll Skia from 4a65dfcc70a5 to bf3f9c5f0edb (4 revisions) (flutter/engine#51268) 
https://skia.googlesource.com/skia.git/+log/4a65dfcc70a5..bf3f9c5f0edb

2024-03-07 penghuang@chromium.org Use ProxyTexture::texture()::textureInfo() to determine depth
2024-03-07 michaelludwig@google.com [sksl] support wgsl's frexp/modf intrinsics
2024-03-07 kjlubick@google.com Start enforcing IWYU on src/gpu
2024-03-07 mike@reedtribe.org factor out SkCTFontCreateExactCopy into its own file(s)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-07 23:22:26 +00:00
Jason Simmons
1faf496ee8 [Impeller] Fix a buffer overrun in ImpellerC reflector resource offsets (flutter/engine#51108) 
This issue can be reproduced by running the CompilerTest.MustFailDueToMultipleLocationPerStructMember test with ASAN

(The Impeller tests are not yet running with ASAN on CI)
 2024-03-07 23:09:20 +00:00
Chris Bracken
01c2ffa574 Roll buildroot to ef514ca5144ba0a4ce5e7075c325d24cd6da73a4 (flutter/engine#51265) 
In flutter/engine#51258, all existing build_overrides from the buildroot
were copied into the engine.

In flutter/buildroot#832, all buildroot build_overrides were converted
into simple forwarding files that point to the ones in the engine such
that we have a seamless path to eliminating the buildroot, while
allowing third-party dependencies to continue to hardcode
`//build_overrides/foo.gni`.

This rolls the buildroot to the engine and switches everthing over to
the new engine-based build_overrides.

Fixes: flutter/flutter#144790
Part of: flutter/flutter#67373

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [X] I'm pretty sure that despite no real changes that should affect
the licence script, that it'll probably fail for some reason anyway and
I'll spend 2 hours fixing it.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I signed the [CLA].
- [X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-03-07 14:44:49 -08:00
skia-flutter-autoroll
ae6ab70478 Roll Dart SDK from 4bc97350dc47 to 4c64fcc134bf (1 revision) (flutter/engine#51266) 
https://dart.googlesource.com/sdk.git/+log/4bc97350dc47..4c64fcc134bf

2024-03-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-212.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-07 22:44:15 +00:00
Brandon DeRosier
9944f5554c [Impeller] Record restore clips in the replay mechanism when StC is enabled. (flutter/engine#51259) 2024-03-07 22:21:52 +00:00
skia-flutter-autoroll
ca81103956 Roll Skia from 6bfd57b8790f to 4a65dfcc70a5 (2 revisions) (flutter/engine#51263) 
https://skia.googlesource.com/skia.git/+log/6bfd57b8790f..4a65dfcc70a5

2024-03-07 herb@google.com Cleanup SkSwizzler_opt.inc
2024-03-07 kjlubick@google.com Fix debugger bazel build

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-07 22:21:50 +00:00
Zachary Anderson
0fb043e6f6 [gn] Disable running some python scripts from GN (flutter/engine#51248) 
For https://github.com/flutter/flutter/issues/144430
 2024-03-07 22:18:12 +00:00
Chris Bracken
b9d7f23abd Migrate build_overrides from buildroot to engine (flutter/engine#51258) 
Files under the build_overrides directory in the buildroot are typically hardcoded imports in third-party dependencies used for project-specific configuration. For example, ANGLE hardcodes an import of `//build_overrides/angle.gni` so that consumers of ANGLE can configure the build to their needs.

This adds a copy all existing src/build_overrides files at the equivalent `src/flutter/build_overrides` path in the engine. A followup patch will replace each existing file under `src/build_overrides` in the buildroot with a shim that just imports the files landed in this patch. This allows third-party dependencies to continue hardcoding the `//build_overrides/foo.gni` path, but provides a seamless path forward when we drop the buildroot.

Issue: https://github.com/flutter/flutter/issues/144790
Part of: https://github.com/flutter/flutter/issues/67373

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-03-07 21:42:06 +00:00
skia-flutter-autoroll
6f59be7215 Roll Fuchsia Linux SDK from y67DIBX84h7pAekIp... to 5Ra_AjCji-uR1GaX7... (flutter/engine#51261) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-07 20:58:17 +00:00
skia-flutter-autoroll
1894cb830d Roll Skia from cf7fefd0bbfb to 6bfd57b8790f (24 revisions) (flutter/engine#51260) 
https://skia.googlesource.com/skia.git/+log/cf7fefd0bbfb..6bfd57b8790f

2024-03-07 robertphillips@google.com Reduce matrix convolution image filter's maximum kernel size
2024-03-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from 99a18601ac24 to e649d06fbad1
2024-03-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 82a4580a3c5a to f2cacee81b83 (6 revisions)
2024-03-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll shaders-base from b04a5aef564b to cbf986e97789
2024-03-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll jsfiddle-base from 0ccdb32ff1ca to 453d00b44c6b
2024-03-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll debugger-app-base from be5714074b1a to 24edbde4082b
2024-03-07 michaelludwig@google.com [skif] Add direct-drawing analog to getAnalyzedShaderView
2024-03-07 johnstiles@google.com Remove flag for SK_RASTER_PIPELINE_FASTER_POW_LOG.
2024-03-07 jlavrova@google.com Moving to the newer ICU4x version (1.4.1)
2024-03-07 jvanverth@google.com [graphite] Move small path management into RasterPathAtlas.
2024-03-07 robertphillips@google.com Manual Roll Dawn from 91a0358034d1 to 58cd45951deb (15 revisions)
2024-03-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 9cd617cb0454 to 82a4580a3c5a (3 revisions)
2024-03-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 756dffd9e74f to 0dc646b71e8d (6 revisions)
2024-03-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 20d29a6cac1b to 0dc646b71e8d
2024-03-06 michaelludwig@google.com [skif] Add animating blur GM testing each tile mode
2024-03-06 jvanverth@google.com [graphite] Switch RasterPathAtlas to use DrawAtlasMgr.
2024-03-06 kjlubick@google.com Fix IWYU and clang-tidy suggestions on ganesh/geometry
2024-03-06 lovisolo@google.com [bazel] Fix broken CI task: BazelTest-benchmark-cpu_8888_benchmark_test-linux_rbe-linux_x64-NUC9i7QN_Debian11.
2024-03-06 penghuang@chromium.org Fix a crash in debug build
2024-03-06 kjlubick@google.com Try limiting all link jobs to 2 at a time
2024-03-06 nscobie@google.com Build Graphite in Android.bp's libskia_renderengine
2024-03-06 brianosman@google.com Add Cargo.lock and target/ to .gitignore
2024-03-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 49ae911d780a to 9cd617cb0454 (34 revisions)
2024-03-06 michaelludwig@google.com [skif] Separate X and Y transform analysis

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-07 20:56:31 +00:00
skia-flutter-autoroll
e365aa3c39 Roll Skia from f17ec7494469 to cf7fefd0bbfb (1 revision) (flutter/engine#51227) 
https://skia.googlesource.com/skia.git/+log/f17ec7494469..cf7fefd0bbfb

2024-03-06 drott@chromium.org [Fontations-backend] Color bitmap support.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-07 19:51:12 +00:00
skia-flutter-autoroll
579e866b42 Roll Dart SDK from bbf21a08a92d to 4bc97350dc47 (1 revision) (flutter/engine#51256) 
https://dart.googlesource.com/sdk.git/+log/bbf21a08a92d..4bc97350dc47

2024-03-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-211.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-07 18:37:14 +00:00
Juanjo Tugores
1e38a17a22 Prepend the accessibility placeholder (flutter/engine#51050) 
Prepends the accesibility placeholder. Previously it was being appended (last child) to the body. 

Relevant Issues are:

* Design doc: https://flutter.dev/go/focus-management 
* Focus in web multiview: https://github.com/flutter/flutter/issues/137443
* Platform dispatcher changes: https://github.com/flutter/engine/pull/49841

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-03-07 18:16:21 +00:00