28315 Commits

Author SHA1 Message Date
Zachary Anderson
7dc83ce910 Add script to test impeller-cmake-example (flutter/engine#41133)
This PR adds an engine CI configuration that downloads the
impeller-cmake-example and builds it.
2023-04-12 14:47:20 -07:00
Mouad Debbar
f97827234f [web] Use the right encoder flags for CanvasKit (flutter/engine#41124)
[web] Use the right encoder flags for CanvasKit
2023-04-12 21:11:05 +00:00
Emircan Uysaler
f54713cc5e [fuchsia] Reduce noise from child view disconnects (flutter/engine#41132)
This CL changes ERROR to WARNING for the logs when a child disconnects
and ChildViewWatcher is closed. This may happen due to other apps and
doesn't necessarily indicate a flutter error.

Bug:fxb/125256
2023-04-13 06:42:55 +10:00
Brandon DeRosier
ba164c17ff [Impeller] Metal: Read from onscreen textures (flutter/engine#41107)
Removes the "final blit" for Metal because
https://github.com/flutter/engine/pull/41085 allows us to read from the
onscreen texture.

We can't do this trick when running the Vulkan backend right now because
it doesn't have `SupportsReadFromResolve` yet, which means we need to
toggle between two textures.
2023-04-12 13:28:42 -07:00
Bernardo Ferrari
d87ae44e99 SemanticsAction / SemanticsFlag cleanup part 5 (flutter/engine#41126)
`SemanticsAction` / `SemanticsFlag` cleanup part 5
2023-04-12 20:10:05 +00:00
Loïc Sharma
0cfb17c6fb [Windows] Shutdown the engine before destroying the surface (flutter/engine#41012)
[Windows] Shutdown the engine before destroying the surface
2023-04-12 19:56:32 +00:00
godofredoc
9a7d3b19f2 Reland "Migrate ios_builders to engine_v2." (flutter/engine#41117)
Reland "Migrate ios_builders to engine_v2."
2023-04-12 19:38:28 +00:00
Brandon DeRosier
77a87d0d65 [Impeller] Add missing advanced blends in Color::BlendColor; absorb any DrawPaint blend mode (flutter/engine#41105)
Resolves https://github.com/flutter/flutter/issues/124623.
2023-04-12 10:55:26 -07:00
Brandon DeRosier
818ca06d71 [Impeller] Improve accuracy of glyph spacing (flutter/engine#41101) 2023-04-12 10:55:16 -07:00
Zachary Anderson
5df3511b4c Roll buildroot to 48f8487897b7f40e2744c808694535478d06ca47 (flutter/engine#41119)
To pick up
48f8487897
2023-04-12 10:34:10 -07:00
godofredoc
c6ccb4deb7 Add docs on how to debug global generators. (flutter/engine#41102)
Add docs on how to debug global generators.
2023-04-12 17:17:27 +00:00
Jason Simmons
c55cb7b6c5 [Impeller] Add a safe way for runtime effects to provide dynamically generated shader metadata (flutter/engine#40992)
See https://github.com/flutter/flutter/issues/113715
2023-04-12 08:19:45 -07:00
Jason Simmons
847d84fb81 [Impeller] Keep a reference to BlitPassGLES in the EncodeCommands lambda to prevent use-after-free (flutter/engine#41100)
[Impeller] Keep a reference to BlitPassGLES in the EncodeCommands lambda to prevent use-after-free
2023-04-12 15:15:55 +00:00
skia-flutter-autoroll
bbca9aeb24 Roll Fuchsia Linux SDK from 0e_0_5725_RNxNyTO... to C2ZkyhfvF-svQYRKt... (flutter/engine#41114)
Roll Fuchsia Linux SDK from 0e_0_5725_RNxNyTO... to C2ZkyhfvF-svQYRKt...
2023-04-12 12:29:30 +00:00
skia-flutter-autoroll
18bfd1a870 Roll Skia from 13af55d6ffe7 to d4e7e1c701c1 (1 revision) (flutter/engine#41112)
Roll Skia from 13af55d6ffe7 to d4e7e1c701c1 (1 revision)
2023-04-12 10:19:20 +00:00
skia-flutter-autoroll
c6fc795701 Roll Skia from 36ddef5c7c6b to 13af55d6ffe7 (4 revisions) (flutter/engine#41111)
Roll Skia from 36ddef5c7c6b to 13af55d6ffe7 (4 revisions)
2023-04-12 08:35:17 +00:00
skia-flutter-autoroll
42e9f5a593 Roll Fuchsia Mac SDK from rHB0F3a_toME3WJgq... to CETPdr-o3iQbJF--2... (flutter/engine#41110)
Roll Fuchsia Mac SDK from rHB0F3a_toME3WJgq... to CETPdr-o3iQbJF--2...
2023-04-12 08:02:45 +00:00
Brandon DeRosier
d5e58c2bf5 [Impeller] Convert SaveLayer alpha playgrounds into goldens (flutter/engine#41095)
[Impeller] Convert SaveLayer alpha playgrounds into goldens
2023-04-12 03:48:16 +00:00
godofredoc
eb1830331a Fixes to strip symbols correctly. (flutter/engine#41097)
Fixes to strip symbols correctly.
2023-04-12 02:03:04 +00:00
skia-flutter-autoroll
eb9fe95251 Roll Skia from 2fceaacc0cbc to 36ddef5c7c6b (3 revisions) (flutter/engine#41099)
Roll Skia from 2fceaacc0cbc to 36ddef5c7c6b (3 revisions)
2023-04-12 01:44:53 +00:00
Jackson Gardner
28d9e0df0f Improve Wasm Debugging. (flutter/engine#41054)
Improve Wasm Debugging.
2023-04-12 00:52:04 +00:00
Brandon DeRosier
1f6af2f479 [Impeller] Absorb root pass DrawPaints for most blend modes (flutter/engine#41088)
We can be a lot more aggressive with absorbing DrawPaints by just
cheaply blending them together on the CPU. We're missing some blend
modes at the moment but can slot those in later.
2023-04-11 17:40:06 -07:00
skia-flutter-autoroll
e70c6aed44 Roll Skia from 53b61e040046 to 2fceaacc0cbc (6 revisions) (flutter/engine#41093)
Roll Skia from 53b61e040046 to 2fceaacc0cbc (6 revisions)
2023-04-11 23:29:17 +00:00
skia-flutter-autoroll
0452f78113 Roll Dart SDK from e0cdac3ed4db to e9053a1d8820 (1 revision) (flutter/engine#41092)
Roll Dart SDK from e0cdac3ed4db to e9053a1d8820 (1 revision)
2023-04-11 23:12:22 +00:00
Jackson Gardner
4b8536c6e9 Implement shadows in the skwasm renderer. (flutter/engine#41056)
Implement shadows in the skwasm renderer.
2023-04-11 22:44:01 +00:00
skia-flutter-autoroll
03acaa99c4 Roll Fuchsia Linux SDK from Ondwn68bALJT8Y_Kp... to 0e_0_5725_RNxNyTO... (flutter/engine#41091)
Roll Fuchsia Linux SDK from Ondwn68bALJT8Y_Kp... to 0e_0_5725_RNxNyTO...
2023-04-11 22:42:09 +00:00
Brandon DeRosier
44e1bddf9d [Impeller] Make Metal layers readable (flutter/engine#41085)
Resolves https://github.com/flutter/flutter/issues/124612.

Doing this would also allow us to remove the final blit on iOS when
advanced blends/backdrop filters are present (all of the facilities
would remain in place for GLES + Vulkan though).
2023-04-11 14:16:13 -07:00
htoor3
a5fdffa8c8 [web] - Move text editing nodes outside of shadowDOM, reland (flutter/engine#40968)
[web] - Move text editing nodes outside of shadowDOM, reland
2023-04-11 19:41:14 +00:00
yaakovschectman
8179d070b3 [Windows] Ignore case optionally in AXPlatformNodeTextRangeProviderWin::FindText (flutter/engine#39922)
When `ignore_case` is `true`, convert needle and haystack strings to
lowercase before performing search,

https://github.com/flutter/flutter/issues/117013

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-04-11 14:54:56 -04:00
skia-flutter-autoroll
a82c7ce989 Roll Skia from 94ed2b7c0aa3 to 53b61e040046 (1 revision) (flutter/engine#41084)
Roll Skia from 94ed2b7c0aa3 to 53b61e040046 (1 revision)
2023-04-11 18:51:16 +00:00
Chris Yang
d753239cc0 [mac] Build mac framework with app extension flag (flutter/engine#41011)
[mac] Build mac framework with app extension flag
2023-04-11 18:32:29 +00:00
Alexander Aprelev
96c773ba3b Roll buildroot to c26173f545880557c36e8fff8b7b6b5c4385c931 (flutter/engine#41080)
Roll buildroot to c26173f545880557c36e8fff8b7b6b5c4385c931
2023-04-11 18:32:28 +00:00
Jackson Gardner
f8cb7c00c7 Revert "Migrate ios_builders to engine_v2." (flutter/engine#41083)
Reverts flutter/engine#40844

We suspect this may be the cause of
https://github.com/flutter/flutter/issues/124572
2023-04-11 11:26:15 -07:00
godofredoc
9a943da9c1 Promote mac_unopt to prod. (flutter/engine#41078)
Promote mac_unopt to prod.
2023-04-11 17:29:06 +00:00
Brandon DeRosier
29585b2482 [Impeller] Move TextRenderContext::Create symbol into the text backend (flutter/engine#41067)
Moves the `TextRenderContext::Create` symbol into the backend, so that
we can easily swap out the backend when building the 2D renderer in
impeller-cmake.
2023-04-11 10:09:28 -07:00
Chinmay Garde
d56e587985 [Impeller] Remove GPUTracer. (flutter/engine#41079)
[Impeller] Remove GPUTracer.
2023-04-11 17:07:16 +00:00
godofredoc
753f2a77b1 Promote linux_desktop build to prod. (flutter/engine#41076)
Promote linux_desktop build to prod.
2023-04-11 17:01:54 +00:00
Jonah Williams
c3a94facab [Impeller] convert most filters to utilize entities instead of subpasses (flutter/engine#40973)
[Impeller] convert most filters to utilize entities instead of subpasses
2023-04-11 16:49:07 +00:00
Jonah Williams
e14c6ed93d [Impeller] remove unref queue usage on Impeller. (flutter/engine#41050)
[Impeller] remove unref queue usage on Impeller.
2023-04-11 16:49:04 +00:00
skia-flutter-autoroll
0eec476411 Roll Skia from 41366284cb7b to 94ed2b7c0aa3 (1 revision) (flutter/engine#41075)
Roll Skia from 41366284cb7b to 94ed2b7c0aa3 (1 revision)
2023-04-11 15:04:58 +00:00
skia-flutter-autoroll
c3d5474e91 Roll Fuchsia Mac SDK from Qjww4yAoe7dXlsRYB... to rHB0F3a_toME3WJgq... (flutter/engine#41074)
Roll Fuchsia Mac SDK from Qjww4yAoe7dXlsRYB... to rHB0F3a_toME3WJgq...
2023-04-11 14:55:33 +00:00
Jason Simmons
c9147eae32 [Impeller] Obtain the subpass texture after calling OnRender (flutter/engine#41052)
[Impeller] Obtain the subpass texture after calling OnRender
2023-04-11 14:41:08 +00:00
skia-flutter-autoroll
a365cec57c Roll Dart SDK from 69985a5c5700 to e0cdac3ed4db (2 revisions) (flutter/engine#41070)
Roll Dart SDK from 69985a5c5700 to e0cdac3ed4db (2 revisions)
2023-04-11 10:58:25 +00:00
skia-flutter-autoroll
c8a92db52f Roll Fuchsia Linux SDK from P15HfBhD19GOwL0lz... to Ondwn68bALJT8Y_Kp... (flutter/engine#41069)
Roll Fuchsia Linux SDK from P15HfBhD19GOwL0lz... to Ondwn68bALJT8Y_Kp...
2023-04-11 08:54:29 +00:00
skia-flutter-autoroll
bb534ef2e6 Roll Skia from d662473a1e8e to 41366284cb7b (3 revisions) (flutter/engine#41068)
Roll Skia from d662473a1e8e to 41366284cb7b (3 revisions)
2023-04-11 07:57:09 +00:00
skia-flutter-autoroll
a168084487 Roll Skia from 8cfe86a8c5da to d662473a1e8e (1 revision) (flutter/engine#41066)
Roll Skia from 8cfe86a8c5da to d662473a1e8e (1 revision)
2023-04-11 07:04:14 +00:00
skia-flutter-autoroll
32e2d44e03 Roll Dart SDK from bafed863716f to 69985a5c5700 (1 revision) (flutter/engine#41065)
Roll Dart SDK from bafed863716f to 69985a5c5700 (1 revision)
2023-04-11 05:32:25 +00:00
Chris Yang
94fa5f4edf [ios] fix background crash when FlutterViewController is destroyed after engine destroyed context (flutter/engine#41037)
[ios] fix background crash when FlutterViewController is destroyed after engine destroyed context
2023-04-11 03:45:27 +00:00
Brandon DeRosier
b3e7898f48 Revert "[Impeller] Load instead of restore drawing for non-MSAA passes" (flutter/engine#41060)
Revert "[Impeller] Load instead of restore drawing for non-MSAA passes"
2023-04-11 03:25:09 +00:00
skia-flutter-autoroll
462e87bb8e Roll Skia from 7eebce479ff8 to 8cfe86a8c5da (3 revisions) (flutter/engine#41061)
Roll Skia from 7eebce479ff8 to 8cfe86a8c5da (3 revisions)
2023-04-11 02:38:17 +00:00