DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
25,997 Commits 882 Branches 1,069 Tags
Commit Graph

25997 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Junji Watanabe
7d5da86648 Install CIPD ninja using DEPS (flutter/engine#37375) 
* Install CIPD ninja using DEPS

* ignore license check for third_party/ninja

* update expected licenses
 2022-11-10 21:07:09 +00:00
fzyzcjy
3ac82e66e3 Eliminate duplicated code when dealing with pointer data (flutter/engine#36822) 
* add methods

* add empty test

* add unit test

* Update licenses_flutter

* add const

* size -> get length

* add boundary checks

* add tests

* remove death test since it says "Death tests use fork(), which is unsafe particularly in a threaded context."
 2022-11-10 21:05:20 +00:00
yusuf-goog
751e4a2424 Adding release_build:true to Mac builds. (flutter/engine#37478) 
This will run the specified jobs under the release builder recipe in dart-internal.

Bug:b/232552448
 2022-11-10 20:34:35 +00:00
杨加康
9084e780a0 Update FlutterView.java (flutter/engine#37312) 2022-11-10 19:52:29 +00:00
Jackson Gardner
e3da6d905b Felt analyze (flutter/engine#37481) 
* Adding `felt analyze` command that CI will run.

* Remove some copypasta'd stuff.

* Also remove code path from felt.dart that forces a rebuild if it doesn't
detect the host_debug_unopt directory.

* More cleanup of felt.bat for CI.

* Fix typo in felt.bat.
 2022-11-10 18:34:24 +00:00
gaaclarke
85a6c86d8f Turned on performance-move-const-arg everywhere. (flutter/engine#37482) 
Turned on performance-move-const-arg everywhere.
 2022-11-10 09:12:33 -08:00
ColdPaleLight
a20cc51c95 [Impeller] Remove duplicate code in 'TiledTextureContents' (flutter/engine#37492) 2022-11-10 16:46:47 +00:00
skia-flutter-autoroll
1783572bf6 Roll Fuchsia Linux SDK from RNSA2Wp1MObtc7OHy... to mduclAELKkftJ-fwI... (flutter/engine#37495) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2022-11-10 13:22:05 +00:00
ColdPaleLight
699f74a3d7 [Impeller] Support access the descriptor of PipelineFuture directly (flutter/engine#37415) 
* [Impeller] Support access the descriptor of PipelineFuture directly

* Tweak code

* Clean code
 2022-11-10 07:23:44 +00:00
Jason Simmons
cc36b52002 Fix a race in the EmbedderA11yTest.A11yTreeIsConsistent tests (flutter/engine#37488) 2022-11-10 06:40:11 +00:00
Kaushik Iska
83c4708ccf Include AndroidSurfaceVulkanImpeller behind a flag (flutter/engine#37486) 
This is to enable building in google3.

See also: b/258506856
 2022-11-10 00:54:20 +00:00
Srujan Gaddam
540e92f91d Add external factories for @staticInterop classes instead of synthetic constructor (flutter/engine#37443) 
Per https://github.com/dart-lang/sdk/issues/49941, synthetic constructors
will be disallowed on @staticInterop classes. Functionally, they are lowered
to the same code.

Also fixes an erroneous call to the DomHTMLStyleConstructor instead of the
relevant factory method.
 2022-11-09 16:15:48 -08:00
skia-flutter-autoroll
7cfbff8ff8 Roll Fuchsia Linux SDK from mDzQK4ZUk_Y4wfZa_... to RNSA2Wp1MObtc7OHy... (flutter/engine#37485) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2022-11-10 00:01:59 +00:00
gaaclarke
643e801f2c Implemented threadsafe platform channel replies on windows (flutter/engine#36909) 
* Implemented threadsafe platform channel replies on windows

* added unit test

* added docstrings

* implemented glfw

* added comments

* made glfw messenger unable to be copied

* stuart feedback 1

* stuart feedback 2: replaced the shared_ptr

* stuart feedback 3

* stuart feedback: remove error log

* Moved FlutterDesktopMessenger to its own file.

* updated licenses

* stuart feedback
 2022-11-09 22:59:00 +00:00
gaaclarke
af036b8857 Turned on performance-unnecessary-value-param everywhere. (flutter/engine#37447) 
* Turned on performance-unnecessary-value-param everywhere.

* linux host additions

* ios patch

* reverted bad fix

* revert bad fix

* another ios patch

* removed lint fix printer
 2022-11-09 20:55:13 +00:00
Harry Terkelsen
bbd93f8fa7 Roll CanvasKit to 0.37.1 (flutter/engine#37454) 2022-11-09 12:07:25 -08:00
Naud Ghebre
ffbedf21c4 [sdk_roll_failure] add facet to allowlist test_manager and other packages. (flutter/engine#37479) 2022-11-09 20:00:52 +00:00
stuartmorgan
ce6a41fd60 Roll expat to 2.5.0 (flutter/engine#37383) 
* Roll expat to 2.5.0

Rolls expat, which was last updated approximately a year ago, to the
very recent 2.5.0 tag.

Fixes https://github.com/flutter/flutter/issues/114734

* Licenses

* Resync

* Apply changes from CI
 2022-11-09 19:36:19 +00:00
Kallen Tu
1da0e076d4 Use IndexError.check instead of RangeError.checkValidIndex in buffers. (flutter/engine#37450) 2022-11-09 18:30:21 +00:00
Brandon DeRosier
32be4b0970 Support HLSL ingestion in ImpellerC (flutter/engine#37461) 2022-11-09 10:28:47 -08:00
Kaushik Iska
eff03907ca Use traingle strip for difference clip (flutter/engine#37469) 2022-11-09 11:48:02 -05:00
skia-flutter-autoroll
0e4555c9f6 Roll Dart SDK from 4fcefaf03496 to fa6586382e5d (1 revision) (flutter/engine#37473) 
https://dart.googlesource.com/sdk.git/+log/4fcefaf03496..fa6586382e5d

2022-11-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 2.19.0-382.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2022-11-09 16:23:29 +00:00
skia-flutter-autoroll
54045753a2 Roll Skia from fe143a0dc368 to 0854badd5783 (1 revision) (flutter/engine#37471) 
https://skia.googlesource.com/skia.git/+log/fe143a0dc368..0854badd5783

2022-11-09 bsalomon@google.com Convert 6 samples to slides

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jimgraham@google.com,lovisolo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2022-11-09 14:57:29 +00:00
Chris Bracken
57d02219ab [macOS] Remove OpenGL rendering backend (flutter/engine#37448) 
In flutter/buildroot#648 (rolled to the engine in flutter/engine#37380)
the minimum macOS SDK was bumped from 10.13 to 10.14. As of macOS 10.14,
Metal is available for all users. This eliminates the macOS OpenGL
rendering support code.

Note that this only removes the GL-specific code in the embedder. A
followup patch will land refactorings to clean up the remaining code,
for example, cases where a parent interface exists only because we had
both a GL and a Metal implementation. This is being does in two patches
in order to keep review clear and simple and to simplify rebases of any
outstanding patches that also touches this code.

Issue: https://github.com/flutter/flutter/issues/114445
 2022-11-09 15:39:48 +01:00
skia-flutter-autoroll
7d1510c7b5 Roll Dart SDK from 874a662f7507 to 4fcefaf03496 (1 revision) (flutter/engine#37470) 
https://dart.googlesource.com/sdk.git/+log/874a662f7507..4fcefaf03496

2022-11-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 2.19.0-381.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2022-11-09 12:04:27 +00:00
Kaushik Iska
5b9e42523e [Reland] Add rects to accumulator rather than bounds (#37435) (flutter/engine#37451) 
* [Reland] Add rects to accumulator rather than bounds (#37435)

When the accumulator is an `RTreeBoundsAccumulator` rather than a `RectBoundsAccumulator` just accumulating the bounds results in incorrect results as the `rtree` would need to be aware of the constituent non-overlapping rectangles. This would work fine for `RectBoundsAccumulator` as it would just adjust its bounds based on the passed rects.

Fixes: https://github.com/flutter/flutter/issues/113251

* Add a test for nested display list rtree
 2022-11-09 10:57:29 +00:00
skia-flutter-autoroll
371ce12048 Roll Fuchsia Mac SDK from d4l6A1aPw6Z0YjxmA... to vEw8iuSZYmlfk1JiE... (flutter/engine#37468) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2022-11-09 09:31:24 +00:00
skia-flutter-autoroll
93b509d79a Roll Dart SDK from c15cdb978761 to 874a662f7507 (3 revisions) (flutter/engine#37466) 
https://dart.googlesource.com/sdk.git/+log/c15cdb978761..874a662f7507

2022-11-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 2.19.0-380.0.dev
2022-11-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 2.19.0-379.0.dev
2022-11-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 2.19.0-378.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2022-11-09 08:07:10 +00:00
skia-flutter-autoroll
b57a39580d Roll Skia from 790aedd91cd8 to fe143a0dc368 (3 revisions) (flutter/engine#37467) 
https://skia.googlesource.com/skia.git/+log/790aedd91cd8..fe143a0dc368

2022-11-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 282e486490ff to 2d33529c3945 (1 revision)
2022-11-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 282e486490ff to 2d33529c3945
2022-11-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 5b2181969a22 to fbf2d2f36442 (9 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jimgraham@google.com,lovisolo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2022-11-09 08:03:06 +00:00
skia-flutter-autoroll
bc2d10d04a Roll Skia from 511aa59461f3 to 790aedd91cd8 (2 revisions) (flutter/engine#37463) 
https://skia.googlesource.com/skia.git/+log/511aa59461f3..790aedd91cd8

2022-11-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from eb949c87ee5a to 4f3f45c00f41 (7 revisions)
2022-11-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 1a3a7f52e8fc to 282e486490ff (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jimgraham@google.com,lovisolo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2022-11-09 06:49:06 +00:00
Brandon DeRosier
542a1594a5 [Impeller] Don't double-convert include path encodings in ImpellerC (flutter/engine#37408) 2022-11-08 19:38:15 -08:00
skia-flutter-autoroll
2dfed5dcd2 Roll Skia from 22526b55be02 to 511aa59461f3 (1 revision) (flutter/engine#37458) 
https://skia.googlesource.com/skia.git/+log/22526b55be02..511aa59461f3

2022-11-09 kjlubick@google.com [canvaskit] Deploy 0.37.1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jimgraham@google.com,lovisolo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2022-11-09 03:20:19 +00:00
skia-flutter-autoroll
5384ec4cb0 Roll Skia from 94450cd1df4e to 22526b55be02 (6 revisions) (flutter/engine#37455) 
https://skia.googlesource.com/skia.git/+log/94450cd1df4e..22526b55be02

2022-11-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 65ed8710816a to 1a3a7f52e8fc (1 revision)
2022-11-08 herb@google.com Change SkTArray::size to return int
2022-11-08 penghuang@chromium.org [graphite] add some jobs for build graphite dawn on Windows, Linux, etc
2022-11-08 egdaniel@google.com [Graphite] Share vulkan memory helpers between Ganesh and Graphite.
2022-11-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 8f5037737d33 to 65ed8710816a (1 revision)
2022-11-08 jvanverth@google.com Revert "Add asyncReadPixels to SkImage and SkSurface."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jimgraham@google.com,lovisolo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2022-11-09 02:01:12 +00:00
Jackson Gardner
445caa4bbc Oops, accidentally compiled the non-null-safe platform file as null safe. (flutter/engine#37453) 2022-11-09 01:54:01 +00:00
skia-flutter-autoroll
689c3a7bd0 Roll Skia from 3cecb22c5827 to 94450cd1df4e (4 revisions) (flutter/engine#37445) 
https://skia.googlesource.com/skia.git/+log/3cecb22c5827..94450cd1df4e

2022-11-08 herb@google.com Consolidate all the destroy all loops into clear()
2022-11-08 penghuang@chromium.org [graphite][viewer] Wire up Dawn Vulkan on Unix and D3D12 on Windows
2022-11-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 497526fd086e to 8f5037737d33 (1 revision)
2022-11-08 kjlubick@google.com [bazel] Reorganize defines and local_defines to defines.bzl

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jimgraham@google.com,lovisolo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2022-11-09 00:19:20 +00:00
gaaclarke
55cbf264b2 Clang-tidy: Fixed math on shard-id validator. (flutter/engine#37433) 
Clang-tidy: Fixed math on shard-id validator.
 2022-11-08 15:11:28 -08:00
Kaushik Iska
2155c6ce00 Revert "Add rects to accumulator rather than bounds (#37435)" (flutter/engine#37444) 
This reverts commit 10da0743a513f0ae3ae5afb5a6bd99350b881989.
 2022-11-08 18:10:14 -05:00
gaaclarke
8fed30cc77 Revert "Sdk roll failure - add facet to allowlist test_manager and other packages. (#37395)" (flutter/engine#37449) 
This reverts commit 1b143c26e9e748d682326bbf35172dfaa1b24e21.
 2022-11-08 14:44:17 -08:00
Naud Ghebre
1b143c26e9 Sdk roll failure - add facet to allowlist test_manager and other packages. (flutter/engine#37395) 
* Use fuchsia_component

* [fuchsia-sdk-roll] Hermetic packaging is flipped on by default. Add
test_manager package to the tests facets.

Co-authored-by: Erik <erkln@google.com>
 2022-11-08 21:58:02 +00:00
skia-flutter-autoroll
cde654e487 Roll Skia from 6a056a26b3c5 to 3cecb22c5827 (1 revision) (flutter/engine#37439) 
https://skia.googlesource.com/skia.git/+log/6a056a26b3c5..3cecb22c5827

2022-11-08 egdaniel@google.com Fix ResourceAllocatorTests use of static.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jimgraham@google.com,lovisolo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2022-11-08 21:00:20 +00:00
skia-flutter-autoroll
1ae526ddab Roll Skia from 0c8127b3dd7d to 6a056a26b3c5 (16 revisions) (flutter/engine#37438) 
https://skia.googlesource.com/skia.git/+log/0c8127b3dd7d..6a056a26b3c5

2022-11-08 bsalomon@google.com Make CPU nearest image sampling round down and remove matrix tweak
2022-11-08 kjlubick@google.com [bazel] Generate driver workarounds file
2022-11-08 johnstiles@google.com Allow SkSpan(data, size) ctor to accept any integral-typed size.
2022-11-08 bsalomon@google.com Convert FatBits and ManyRects from Samples to Slides
2022-11-08 johnstiles@google.com Replace Ctx::None with NoCtx.
2022-11-08 brianosman@google.com Disable gamut clamping in GrConvertPixels, too
2022-11-08 bsalomon@google.com Viewer slides default to window-filling dimensions
2022-11-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 2561765b1755 to 497526fd086e (1 revision)
2022-11-08 michaelludwig@google.com Reland "MatrixTransform image filter supports complex canvas' transform"
2022-11-08 herb@google.com Revert "Use accurate block size in SkArenaAlloc"
2022-11-08 johnstiles@google.com [cleanup] Add SkRasterPipeline_TablesCtx for byte tables.
2022-11-08 brianosman@google.com Remove static-if and static-switch from SkSL
2022-11-08 johnstiles@google.com [cleanup] Use pipeline context pointer instead of void*.
2022-11-08 johnstiles@google.com Restructure build_pipeline logic.
2022-11-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 9bda9a79b4ac to 5b2181969a22 (11 revisions)
2022-11-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 4cd8452c3caf to eb949c87ee5a (14 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jimgraham@google.com,lovisolo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2022-11-08 19:44:52 +00:00
skia-flutter-autoroll
2f5d0dd707 Roll Dart SDK from b22b36c0f52e to c15cdb978761 (2 revisions) (flutter/engine#37437) 
https://dart.googlesource.com/sdk.git/+log/b22b36c0f52e..c15cdb978761

2022-11-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 2.19.0-377.0.dev
2022-11-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 2.19.0-376.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2022-11-08 19:26:41 +00:00
Kaushik Iska
10da0743a5 Add rects to accumulator rather than bounds (flutter/engine#37435) 
When the accumulator is an `RTreeBoundsAccumulator` rather than a `RectBoundsAccumulator` just accumulating the bounds results in incorrect results as the `rtree` would need to be aware of the constituent non-overlapping rectangles. This would work fine for `RectBoundsAccumulator` as it would just adjust its bounds based on the passed rects.

Fixes: https://github.com/flutter/flutter/issues/113251
 2022-11-08 19:09:49 +00:00
Mouad Debbar
45ad44de85 [web] Use v8BreakIterator where possible (flutter/engine#37317) 
* [web] Use v8BreakIterator where possible

* address review comments
 2022-11-08 18:24:07 +00:00
skia-flutter-autoroll
c3260418f6 Roll Fuchsia Mac SDK from sa5bVGimNo3JwLV27... to d4l6A1aPw6Z0YjxmA... (flutter/engine#37432) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2022-11-08 18:15:01 +00:00
Zachary Anderson
f2372c426a Revert "Roll Skia from 0c8127b3dd7d to 8b19fb0f57d4 (1 revision) (#37409)" (flutter/engine#37430) 
This reverts commit a106ca5c77e26dbac80cfadae8e1199c9d92be42.
 2022-11-08 16:13:56 +00:00
godofredoc
81fd86a6cf Pass the correct name for gclient variables in ci.yaml (flutter/engine#37429) 
The right name in .ci.yaml is gclient_variables instead of
gclient_custom vars.
 2022-11-08 08:08:37 -08:00
skia-flutter-autoroll
a106ca5c77 Roll Skia from 0c8127b3dd7d to 8b19fb0f57d4 (1 revision) (flutter/engine#37409) 
https://skia.googlesource.com/skia.git/+log/0c8127b3dd7d..8b19fb0f57d4

2022-11-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 4cd8452c3caf to eb949c87ee5a (14 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC garyq@google.com,lovisolo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2022-11-08 06:06:31 +00:00
Michael Ludwig
83e1fc90e2 Update display_list_image_filter_unittests to be permit Skia roll (flutter/engine#37327) 
* Update display_list_image_filter_unittests to be permit Skia roll

https://skia-review.googlesource.com/c/skia/+/571798 had to be reverted because it causes DisplayListImageFilter.LocalImageFilterBounds to fail. With SkMatrixTransformImageFilter (returned by SkImageFilters::MatrixTransform) supporting complex matrices, makeWithLocalMatrix(rotation) will no longer return null.

This is at odds with the behavior of DlImageFilter's implementation which tries to mimic the existing behavior of image filters. This relaxes the test case so that Skia can improve its implementation without breaking Flutter's tests. Flutter can then update DlImageFilter to match out-of-band.

* Update comment to reference flutter issue.
 2022-11-08 02:22:00 +00:00
Harry Terkelsen
01d17d6af9 Add test for image readback (flutter/engine#37401) 2022-11-07 17:05:37 -08:00