1108 Commits

Author SHA1 Message Date
MennaFadali
77db1c8e9e Implementing Locale.toLanguageTag in flutter web. (flutter/engine#17131) 2020-03-13 08:57:53 -07:00
Nurhan Turgut
0a3bbd1f00 increasing user limits for macos (flutter/engine#17097) 2020-03-11 12:15:47 -07:00
Chinmay Garde
6349c95def Implement asynchronous texture uploads when using the Metal backend on iOS. (flutter/engine#17046)
This moves the Metal `GrContext` creation utilities from `GPUSurfaceMetal` into
a separate `IOSContext` object subclass. An analogue of this object was used in
the GL regime for the management of onscreen and offscreen contexts that were
not tied to the lifecycle of the `GPUSurface`. This pattern has now been
generalized for use with all backends that need a resource context
(`IOSContextGL` and `IOContextMetal`).

The platform views controller management in the `ExternalViewEmbedder` interface
implementation was repeated three times for [Metal][metal], [OpenGL](opengl) and
[Software](software) rendering. This repetition has been removed and a single
implementation present in the base `IOSSurface` and used on all platforms.
Addition of new client rendering APIs should not affect how the engine renders
into the platform view interleaving levels.

All rendering API selection logic has been moved into a single set of utilities
in `rendering_api_selection.h`. This enables the removal of a lot of code blocks
guarded by `FLUTTER_SHELL_ENABLE_METAL`. The remaining uses of this will be
removed when unified builds are enabled.

The Metal backend now also adds traces similar to the GL backend.

The `IOGLContext` has been renamed to `IOContextGL` to be more in line with the
convention used in this library.

Fixes https://github.com/flutter/flutter/issues/41827
Adds https://github.com/flutter/flutter/issues/52150

[metal]: 46dbf3a761/shell/platform/darwin/ios/ios_surface_metal.mm (L55)
[opengl]: 46dbf3a761/shell/platform/darwin/ios/ios_surface_gl.mm (L95)
[software]: 46dbf3a761/shell/platform/darwin/ios/ios_surface_software.mm (L146)
2020-03-10 16:01:53 -07:00
Chinmay Garde
52e75cba16 Use the ELF loader to setup AOT symbols in benchmark runner. (flutter/engine#17051)
We no longer package AOT artifacts as discrete blobs. The portable ELF loader
from the testing library may be used instead.

Fixes https://github.com/flutter/flutter/issues/52263
2020-03-10 12:28:24 -07:00
Ferhat
b9785ff7c3 [web] Fixes for Firefox & Safari double underline decoration bugs. (flutter/engine#16994)
* Work around line measurement rounding bug in Firefox. Add -webkit prefix for Safari text decoration
* Add check for measurement tests for firefox
2020-03-09 22:36:46 -07:00
Dan Field
f48784c95b Avoid capturing this unsafely in MultiFrameCodec (flutter/engine#16824) 2020-03-09 21:18:50 -07:00
Yegor
98f2be6b1f Revert "Revert "fix shadows and mask filter blurs (#16963)" (#17008)" (flutter/engine#17040)
This reverts 7205c0e7b3e575a6dd5d14c0c22058ae40f261a3 and re-lands 8b77254d97416bb9b347a578410911ed09efbce3. The 8b77254d97416bb9b347a578410911ed09efbce3 was good. The screenshot changes were expected.

Fixes https://github.com/flutter/flutter/issues/32215
2020-03-09 20:32:59 -07:00
Ferhat
c54d2ebe85 Add support for firefox mac installer. Update web_ui pubspec for http.wq (flutter/engine#17044)
* Add support for firefox mac installer. Update web_ui pubspec for http.wq
* Addressed review comment 'final'
2020-03-09 18:13:37 -07:00
Yegor
ec1c0c147c fix "TREE INCONSISTENT" noise in compositing_test.dart (flutter/engine#16995) 2020-03-09 16:26:18 -07:00
Yegor
138614b81a Add more child lifecycle tests (flutter/engine#16689) 2020-03-09 16:26:06 -07:00
Chris Bracken
7205c0e7b3 Revert "fix shadows and mask filter blurs (#16963)" (flutter/engine#17008)
Broke golden file tests in the framework. Reverting to unblock the
engine roll to the framework.

This reverts commit 8b77254d97416bb9b347a578410911ed09efbce3.
2020-03-07 10:18:10 -08:00
Yegor
8dafc47d0e remove 10s timeouts from tests (flutter/engine#16988) 2020-03-06 12:37:52 -08:00
Ferhat
d6a38fbd6f [web] Fixes IE11 crash due to missing canvas ellipse support and font polyfill failure (flutter/engine#16965)
* Add context ellipse polyfill
* Change call sites for ellipse
* Switch fontloader polyfill font for ie11
2020-03-06 09:50:02 -08:00
Yegor
8b77254d97 fix shadows and mask filter blurs (flutter/engine#16963)
* fix shadows and mask filter blurs

* update goldens

* clarify the choice to min the shadows
2020-03-05 22:07:57 -08:00
Chris Bracken
90f3de7400 Revert "Drop last usages of Dart_New from engine (#16838)" (flutter/engine#16915)
We believe this may be implicated in a Windows-specific crash during the
Flutter Gallery integration test.

See:
https://github.com/flutter/flutter/issues/51896

This reverts commit b41f86eb00e16e0dd6e1bfba7d670e05a8dafd4b.
2020-03-03 14:52:56 -08:00
Dan Field
b41f86eb00 Drop last usages of Dart_New from engine (flutter/engine#16838)
Image
Codec
FrameInfo
Scene/Picture toImage
2020-03-02 21:30:28 -08:00
Dan Field
18f7355d00 shake out Paint.toString (flutter/engine#16850) 2020-02-28 10:41:55 -08:00
Dan Field
4a2a7fbaa3 Avoid using Dart_New for semantics (flutter/engine#16849) 2020-02-28 10:31:03 -08:00
Dan Field
81efbea9a8 remove usage of Dart_New for paragraph/libtxt (flutter/engine#16837) 2020-02-28 00:15:40 -08:00
Ben Konyi
780e60193d Enable HTTP and socket profiling dart:io service extensions for Flutter (flutter/engine#16800) 2020-02-27 08:29:58 -08:00
Ferhat
df9e5782b0 Fix stale physicalSize on resize event (flutter/engine#16822) 2020-02-26 15:54:10 -08:00
Mouad Debbar
b77b7512c7 [web] Guard the remaining calls to window.onPlatformMessage (flutter/engine#16791) 2020-02-25 15:06:07 -08:00
Nurhan Turgut
a868ed4b44 [web] changing user limits for macos (flutter/engine#16797)
* changing user limits for macos

* check kernel name instead
2020-02-25 15:04:07 -08:00
Ferhat
0e20dc802c Evict BitmapCanvas(s) from cache when canvas allocation fails (flutter/engine#16793) 2020-02-25 13:38:25 -08:00
Mouad Debbar
53dc99cd26 [web] Respect maxLines when calculating boxes for a range (flutter/engine#16749) 2020-02-24 14:26:03 -08:00
Mouad Debbar
489ddd405b [web] Reduce the usage of unnecessary lists in pointer binding (flutter/engine#16745) 2020-02-24 14:21:04 -08:00
Ferhat
a07014a9ca [web] Fix canvas leak when dpi changes. Evict from BitmapCanvas cache under… (flutter/engine#16721)
* Fix canvas leak when dpi changes. Evict from BitmapCanvas cache under memory pressure.

* optimized _reduceCanvasMemoryUsage

* Addressed review comments
2020-02-24 11:19:47 -08:00
Miguel Beltran
0858707729 Add support for Increase Contrast on iOS (flutter/engine#15343) 2020-02-22 14:04:04 -08:00
Dan Field
9bbbd5078d Migrate Path to AssociateWithDartWrapper (flutter/engine#16753) 2020-02-22 12:59:35 -08:00
Mouad Debbar
1e37bb489a [web] Paragraph.longestLine doesn't need to check for isSingleLine anymore (flutter/engine#16736) 2020-02-21 13:18:09 -08:00
Mouad Debbar
5f8ca597db [web] Rename LineMetrics.text to LineMetrics.displayText (flutter/engine#16734) 2020-02-21 13:17:59 -08:00
Nurhan Turgut
a443623a34 [web] add comment to skipped safari test (flutter/engine#16737)
* add comment to skipped safari test

* test not running semantics on Mac

* disable semantics test which is unreliable
2020-02-21 13:03:29 -08:00
Ryan Macnak
101b70147f Fix some compiler warnings in newer versions of Clang. (flutter/engine#16733) 2020-02-21 12:57:06 -08:00
Nurhan Turgut
3fb1af296c [web] Running safari tests on LUCI (flutter/engine#16715)
* Safari font collection tests skip failing methods

* add a clear to the semantics test to make sure no DOM elements are leaking to the other tests

* fix semantics_helper_test. skip for semantics_test. teardown didn't work

* skip test, the skipped method run for 8 minutes according to the logs

* history tests methods runs multiple times. only run them on linux for now. they were also already failing in edge/windows
2020-02-21 09:03:13 -08:00
Dan Field
b1f692e9cb Refactor of ClaimDartHandle -> AssociateWithDartWrapper (flutter/engine#16720) 2020-02-20 17:31:03 -08:00
Dan Field
a03a05a385 Reland "Remove usage of Dart_AllocateWithNativeFields" (flutter/engine#16713) 2020-02-20 16:06:02 -08:00
vsmenon
a605113c25 opt out dart:ui from nnbd (flutter/engine#16473)
* opt out dart:ui from nnbd

* Annotate tests as well
2020-02-20 11:04:00 -08:00
Dan Field
d483ae6288 Revert "Remove usage of Dart_AllocateWithNativeFields from tonic (#16588)" (flutter/engine#16684)
This reverts commit d32975f3877f6be5b227f3156226ccdea35f15c9.
2020-02-19 10:00:05 -08:00
Mouad Debbar
713cdb3d7b [web] Paragraph.getBoxesForRange uses LineMetrics (flutter/engine#16625) 2020-02-19 09:56:57 -08:00
Harry Terkelsen
a51698a522 URL-encode asset URLs so assets are properly loaded (flutter/engine#16630)
* URL-encode asset URLs so assets are properly loaded

* Add comment
2020-02-18 16:19:36 -08:00
Yegor
2782ec758d update hash code logic on the web (flutter/engine#16624) 2020-02-18 12:29:17 -08:00
Nurhan Turgut
97d1caffaa [web] Skipping failing edge tests (flutter/engine#16626)
* making edge default test browser on windows. adding some skips (not all) for methods failing on edge

* skip failing tests. make egde default for testing

* skip one more test

* addressing reviewer comments. removing extra bat file
2020-02-18 09:36:04 -08:00
Ben Konyi
d32975f387 Remove usage of Dart_AllocateWithNativeFields from tonic (flutter/engine#16588)
This API is being removed from the Dart SDK.
2020-02-14 13:55:38 -08:00
Ferhat
5b6f5f36ed Implement Path extractPath, tangent APIs (flutter/engine#16599)
* Add pathMeasure
* Implement tangetAt
* add extractPath segment iterator
* Implement extractPath/chopCubicAt/chopQuadAt
* Wire up extractPath and add tests for cubic/quadratic
* Switch to interpolate on chopCubic
* addressed review comments
2020-02-14 13:29:27 -08:00
Mouad Debbar
7f9d005477 [web] Unskip tests that are already passing in Safari (flutter/engine#16567) 2020-02-14 10:27:32 -08:00
Nurhan Turgut
fb1b707879 [web] Fixing launching Safari. This should solve the LUCI issue (flutter/engine#16590)
* Fixing launching Safari. This should solve the LUCI issue

* more comments and linking the issue
2020-02-14 10:27:20 -08:00
Mouad Debbar
72edf47d71 [web] Handle alignment correctly in Paragraph.getPositionForOffset (flutter/engine#16569) 2020-02-14 10:24:13 -08:00
Ferhat
3ed6b577e9 Fix drawRRect failure when shader is specified (flutter/engine#16601) 2020-02-14 09:08:28 -08:00
Yegor
e2a5925457 improve surface state assert error messages (flutter/engine#16595) 2020-02-14 08:04:31 -08:00
Harry Terkelsen
3dfb7710f9 Set the current GL context to the most recently acquired Surface (flutter/engine#16572) 2020-02-13 10:49:13 -08:00