DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

URL-encode asset URLs so assets are properly loaded (flutter/engine#16630)

Browse Source 
* URL-encode asset URLs so assets are properly loaded

* Add comment
This commit is contained in:
Harry Terkelsen 2020-02-18 16:19:36 -08:00 committed by GitHub
parent 011e3866a9
commit a51698a522
1 changed files with 19 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
engine/src/flutter/lib/web_ui/lib/src/engine/assets.dart
View File

@ -24,11 +24,28 @@ class AssetManager {
?.content;
}
/// Returns the URL to load the asset from, given the asset key.
///
/// We URL-encode the asset URL in order to correctly issue the right
/// HTTP request to the server.
///
/// For example, if you have an asset in the file "assets/hello world.png",
/// two things will happen. When the app is built, the asset will be copied
/// to an asset directory with the file name URL-encoded. So our asset will
/// be copied to something like "assets/hello%20world.png". To account for
/// the assets being copied over with a URL-encoded name, the Flutter
/// framework URL-encodes the asset key so when it sends a request to the
/// engine to load "assets/hello world.png", it actually sends a request to
/// load "assets/hello%20world.png". However, on the web, if we try to load
/// "assets/hello%20world.png", the request will be URL-decoded, we will
/// request "assets/hello world.png", and the request will 404. Therefore, we
/// must URL-encode the asset key *again* so when it is decoded, it is
/// requesting the once-URL-encoded asset key.
String getAssetUrl(String asset) {
if (Uri.parse(asset).hasScheme) {
return asset;
return Uri.encodeFull(asset);
}
return (_baseUrl ?? '') + '$assetsDir/$asset';
return Uri.encodeFull((_baseUrl ?? '') + '$assetsDir/$asset');
}
Future<ByteData> load(String asset) async {