Simone Stasi
777bfea286
fix PopupMenuButton unmounted exception when updating position ( #166412 )
...
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->
This PR fixes an exception thrown when trying to update an unmounted
PopupMenuButton's position, which can happen when a layout change is
triggered during PopupMenuButton's pop animation (see issue's attached
video).
A workaround is to set `popUpAnimationStyle:
AnimationStyle.noAnimation`.
This PR fixes it by returning the last known position if the button is
unmounted.
Exception thrown:` FlutterError (This widget has been unmounted, so the
State no longer has a context (and should be considered defunct).
Consider canceling any active work during "dispose" or using the
"mounted" getter to determine if the State is still active.)`
Code that causes the exception: `final PopupMenuThemeData popupMenuTheme
= PopupMenuTheme.of(context);`
Fixes #163477
Tested both on stable (3.29.2) and master (a0b1b325341)
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Navaron Bracke <brackenavaron@gmail.com>
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
2025-06-26 21:04:05 +00:00
Jason Simmons
5285cbb750
Clamp the alpha channel to the valid range in the DlColor constructor ( #171203 )
2025-06-26 20:58:55 +00:00
Kishan Rathore
d72a4853c4
Feat: Add brightness export from widgets.dart ( #169410 )
...
Feat: Add brightness export from widgets.dart
fixes : #169294
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
2025-06-26 20:16:25 +00:00
Jason Simmons
6af3df8d9a
Add a flag that disables SecureSocket support in Dart ( #171201 )
...
See https://github.com/flutter/flutter/issues/170459
2025-06-26 20:03:32 +00:00
Bruno Leroux
5bb48258cc
Add missing M3 tests for InputDecoration.floatingLabelAlignment ( #170903 )
...
## Description
This PR adds missing M3 tests for
InputDecoration.floatingLabelAlignment.
## Related Issue
Will help to complete https://github.com/flutter/flutter/pull/168981
## Tests
Adds 8 tests (based on existing M2 tests).
2025-06-26 19:03:41 +00:00
engine-flutter-autoroll
1147f14a04
Roll Dart SDK from 7c1fb216a4f2 to 21c55ff25118 (1 revision) ( #171232 )
...
https://dart.googlesource.com/sdk.git/+log/7c1fb216a4f2..21c55ff25118
2025-06-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-279.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC aaclarke@google.com ,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-26 17:57:26 +00:00
John "codefu" McDole
685ea6ca03
feat: remove "cmd.exe" requirement for content-hashing ( #171233 )
...
Removing cmd.exe means content_aware_hash.ps1 runs on other platforms as
well.
hash | command | host
-|-|-
728dc653e5efeb64175acce4bd2d7090781df70a | content_aware_hash.sh | mac
728dc653e5efeb64175acce4bd2d7090781df70a | content_aware_hash.ps1 |
powershell 5.1 windows 11
728dc653e5efeb64175acce4bd2d7090781df70a | content_aware_hash.ps1 |
powershell 7.5.1 macos
2025-06-26 17:41:08 +00:00
Lucas SAUDON
ab0087c256
feat: Add hintLocales in TextFormField ( #170938 )
...
Add hintLocales in TextFormField
*List which issues are fixed by this PR. You must list at least one
issue. An issue is not required if the PR fixes something trivial like a
typo.*
*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-06-26 16:38:24 +00:00
engine-flutter-autoroll
173ed2cebc
Roll Packages from 5963ecdb2dbc to 2c8d2bc0589c (3 revisions) ( #171227 )
...
5963ecdb2d...2c8d2bc058jessiewong401@gmail.com Bump AVD and SDK to API 36 in
Packages CI (flutter/packages#9414 )
2025-06-26 stuartmorgan@google.com [tool] Use `swift-format` from Xcode
(flutter/packages#9460 )
2025-06-26 stuartmorgan@google.com Revert "[camera_android_camerax]
Force new `Surface` for each `SurfaceRequest`" (flutter/packages#9500 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-26 15:56:25 +00:00
engine-flutter-autoroll
edb19e6dd6
Roll Dart SDK from f83d43fa2ff4 to 7c1fb216a4f2 (1 revision) ( #171225 )
...
https://dart.googlesource.com/sdk.git/+log/f83d43fa2ff4..7c1fb216a4f2
2025-06-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-278.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC aaclarke@google.com ,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-26 12:51:18 +00:00
engine-flutter-autoroll
961ce3ec82
Roll Fuchsia Linux SDK from XX8LxiX10yPg8EwED... to lOriymW5zTP5ByH8-... ( #171206 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC aaclarke@google.com ,zra@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-26 04:08:58 +00:00
engine-flutter-autoroll
9f3a323242
Roll Dart SDK from b43ca793d4bf to f83d43fa2ff4 (1 revision) ( #171205 )
...
https://dart.googlesource.com/sdk.git/+log/b43ca793d4bf..f83d43fa2ff4
2025-06-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-277.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC aaclarke@google.com ,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-26 04:07:32 +00:00
engine-flutter-autoroll
8d89d1edac
Roll Dart SDK from d9edd9e7a634 to b43ca793d4bf (8 revisions) ( #171189 )
...
https://dart.googlesource.com/sdk.git/+log/d9edd9e7a634..b43ca793d4bf
2025-06-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-276.0.dev
2025-06-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-275.0.dev
2025-06-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-274.0.dev
2025-06-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-273.0.dev
2025-06-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-272.0.dev
2025-06-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-271.0.dev
2025-06-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-270.0.dev
2025-06-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-269.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC aaclarke@google.com ,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-25 22:59:20 +00:00
Harry Terkelsen
0f2d7ea537
Fix gestures not being recognized in <img>-backed NetworkImages ( #171190 )
...
On the web, when a `NetworkImage` falls back to an `<img>`
element-backed implementation, the gesture events were being lost
because the underlying Platform View had
`PlatformViewHitTestBehavior.opaque` (the default). This changes it to
`PlatformViewHitTestBehavior.transparent` so the gestures are handled by
parent widgets.
Fixes https://github.com/flutter/flutter/issues/167398
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-06-25 22:40:28 +00:00
Jason Simmons
89ba94902a
[Impeller] Make ContextVK hash values globally unique ( #171119 )
...
ContextVK had been using a thread-local counter to assign the value
returned by GetHash. But CommandPoolRecyclerVK was using these values as
keys in a process-wide global map.
If two engine instances using different task runner threads both created
a ContextVK, then the thread-local counter could cause both contexts to
share the same hash. So when
CommandPoolRecyclerVK::DestroyThreadLocalPools destroys the pools
associated with the first context's hash, it will also incorrectly
destroy the second context's pools.
Fixes https://github.com/flutter/flutter/issues/170141
2025-06-25 22:20:14 +00:00
Chinmay Garde
a39147c813
Allow uninstalling Git hooks. ( #170839 )
...
The hooks get in the way of pushing to branches via tools like Sublime
Merge. Installation of these hooks can be disabled via the
setup_githooks DEPS [custom
variable](edc792e098/DEPS (L127)
2025-06-25 21:56:47 +00:00
Chinmay Garde
f8f7455a12
[Impeller] libImpeller: Allow user supplied fragment programs to shade pixels. ( #170616 )
...
Fixes https://github.com/flutter/flutter/issues/170008
2025-06-25 21:18:44 +00:00
John "codefu" McDole
90e5f43ada
feat: upload artifacts to content_hash if signaled ( #171166 )
...
part of #167780
`upload_content_hash` is paired with
[cocoon's](2a5f4afa3d/app_dart/config.yaml (L12-L15)2a5f4afa3d/app_dart/lib/src/service/scheduler.dart (L703-L706)https://flutter-review.googlesource.com/c/recipes/+/66780 ) will
upload to a second location. This upload should happen only once; for
the first matching engine change.
> [!IMPORTANT]
>
[`windows_arm_host_engine`](https://flutter-dashboard.appspot.com/#/build?taskFilter=windows_arm_host_engine&repo=flutter&branch=master )
is not built in the merge queue and won't get the content_hash value
passed down to it, so it will not get uploaded today. This should be
fine given we're still testing; but Cocoon would need to schedule
limited post submits so this eventually only builds and uploads once.
2025-06-25 21:00:51 +00:00
Alex Talebi
e6ecca06dd
Fix text selection toolbar alignment for RTL languages ( #169854 )
...
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->
**Fix text selection toolbar alignment for RTL (right-to-left)
languages**
This PR updates the Material text selection toolbar to properly support
right-to-left (RTL) layouts. Previously, the toolbar and its buttons did
not align or order correctly when using RTL text direction, leading to a
broken or confusing user experience for RTL languages.
**Summary of changes:**
- Refactored layout logic in `text_selection_toolbar.dart` to handle RTL
and LTR directions for both horizontal and overflow (vertical)
arrangements.
- Updated padding logic in `text_selection_toolbar_text_button.dart` to
use `EdgeInsetsDirectional`, ensuring correct padding for both text
directions.
- Added new widget tests to verify that:
- Toolbar items are ordered right-to-left in RTL contexts.
- The overflow menu behaves correctly in RTL, showing items in the
correct order and position.
**Before:**
- Toolbar items and overflow menus did not respect RTL layout, resulting
in misaligned or reversed button order.
- Padding was inconsistent in RTL.
<details>
<summary>Before Screenshots</summary>
| LTR Not Expanded | LTR Expanded | RTL Not Expanded | RTL Expanded |
|---|---|---|---|
| 
| 
|
|
|
</details>
**After:**
- Toolbar items and overflow menus are correctly ordered and aligned for
RTL.
- Button padding is now directionally correct.
<details>
<summary>After Screenshots</summary>
| LTR Not Expanded | LTR Expanded | RTL Not Expanded | RTL Expanded |
|---|---|---|---|
|
|
|
|
|
</details>
This improves the usability and accessibility of text selection controls
for users of RTL languages.
Fixes #59306
---
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-06-25 21:00:49 +00:00
Valentin Vignal
a5a3ab3f92
Fix Radio's painters ( #170321 )
...
While working on https://github.com/flutter/flutter/issues/168787 as a
follow-up of https://github.com/flutter/flutter/pull/169415 , I noticed
that the tests introduced in
https://github.com/flutter/flutter/pull/169415 were incorrect. However,
because of the way the `Radio` implements `paint` and reuses 1 painter,
it was not possible to properly assert the paints in the test.
This PR fixes it
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-06-25 19:25:50 +00:00
ash2moon
c9537a5509
Add back "Use live region in error text input decorator for Android #165531 " ( #168992 )
...
Partly of https://github.com/flutter/flutter/issues/165510
⤴️ Parent PR: https://github.com/flutter/flutter/pull/169685 (✅ Merged)
⤴️ Parent PR (refactor): https://github.com/flutter/flutter/pull/170618
(✅ Merged)
Re-lands https://github.com/flutter/flutter/pull/165531
The PR was originally reverted due to an issue with an internal Google
test. I added a new test case under `input_decorator_test.dart` which
does something similar to prevent the regression. All other code is the
same as https://github.com/flutter/flutter/pull/165531 .
The easiest way to review this would probably be to just check the [diff
after the first
commit](cb5647c3939bd8d5689bhttps://github.com/flutter/flutter/pull/165531/files ).
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-06-25 19:12:23 +00:00
gaaclarke
091f0ff99e
License cpp jun24 ( #171088 )
...
additions:
- root package files need a header
- added ci step
- performance increases (executes in like 15s now)
- added README.md to the data directory
- cleaned up --v=1 log
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-06-25 18:29:57 +00:00
jcheng
c103588ed5
feat: Add constraints to the AlertDialog and SimpleDialog ( #169327 )
...
close: https://github.com/flutter/flutter/issues/169326
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
2025-06-25 17:26:10 +00:00
Ben Konyi
b6ea64bee4
[ Tool ] Report Android x86 target devices as unsupported ( #170282 )
2025-06-25 16:44:07 +00:00
Ben Konyi
1ec94f9572
[ Widget Previews ] Use monospace fonts when displaying stack traces ( #171167 )
...
**Example:**
<img width="1149" alt="image"
src="https://github.com/user-attachments/assets/fc2a43a9-7622-479e-bca5-957b9d32d0e7 "
/>
2025-06-25 16:15:13 +00:00
Ben Konyi
5959600e16
[ Widget Previews ] Support projects containing libraries with part files ( #171027 )
...
Reworked the dependency model to be library based instead of script
based in order to support libraries spanning multiple scripts.
Also refactored test logic to improve maintainability and simply writing
tests against the `PreviewDetector`.
2025-06-25 16:00:10 +00:00
engine-flutter-autoroll
e197ed2ac9
Roll Packages from d9d3191ea6cf to 5963ecdb2dbc (2 revisions) ( #171163 )
...
d9d3191ea6...5963ecdb2d43054281+camsim99@users.noreply.github.com
[camera_android_camerax] Force new `Surface` for each `SurfaceRequest`
(flutter/packages#9360 )
2025-06-24 48065222+MsYoda@users.noreply.github.com
[google_maps_flutter_web] Fix no effect behavior of cameraTargetBounds
option on web (flutter/packages#9153 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-25 16:00:09 +00:00
Jason Simmons
2773c0c8e1
Log stack traces from exceptions thrown by devicelab test tasks ( #171165 )
2025-06-25 15:52:59 +00:00
Mouad Debbar
6e68383f79
Revert "Move web_long_running_tests_{1,5}_5 to bringup." ( #171100 )
...
Reverts flutter/flutter#171026
These tasks have been consistently
[green](https://flutter-dashboard.appspot.com/#/build?taskFilter=Linux+web_long_running_tests_&repo=flutter&branch=master&showBringup=true )
since https://github.com/flutter/flutter/pull/170939 . Let's take them
out of bringup.
Closes https://github.com/flutter/flutter/issues/171025
2025-06-25 14:49:39 +00:00
Bruno Leroux
e9d8e93e53
Add missing M3 tests for InputDecoration.isDense ( #171058 )
...
## Description
This PR adds missing M3 tests for `InputDecoration.isDense`.
## Related Issue
Related to https://github.com/flutter/flutter/pull/168981
## Tests
Adds 4 tests.
2025-06-25 08:07:20 +00:00
Gray Mackall
47c6e40802
Add Android specific sub-step to validate the Android sdk path has no spaces ( #170829 )
...
The android sdk cannot have spaces in it
<img width="704" alt="Screenshot 2025-06-18 at 11 41 12 AM"
src="https://github.com/user-attachments/assets/2d78599d-8417-4af6-8bc8-f9037f4aab01 "
/>
Add a validation step that it doesn't as it currently blocks building an
app bundle (as we need the apkanalyzer now, after the debug symbol
changes).
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Gray Mackall <mackall@google.com>
2025-06-25 00:16:17 +00:00
Loïc Sharma
5706259791
Update foundation library to export internal ( #170563 )
...
In the Flutter framework, only the `foundation` library is allowed to
import `package:meta`. If other parts of the Flutter framework want to
use `package:meta`, they must do so through the `foundation` library by
exporting the desired `package:meta` member. This requirement is
enforced through `dev/bots/analyze.dart`
[here](https://github.com/flutter/flutter/blob/master/dev/bots/analyze.dart#L2749-L2750 ).
This exports the `internal` attribute so that it can be used by the
Flutter framework. This change was split off from
https://github.com/flutter/flutter/pull/168437 as it might cause
problems in google3 if there is code that imports both
`package:meta/meta.dart` and `package:flutter/foundation.dart`.
I will get a test exemption.
Part of: https://github.com/flutter/flutter/issues/167668
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-06-24 23:05:23 +00:00
Matan Lurey
3bc69cb262
Remove stale references to Release-process.md and conductor ( #171046 )
...
Closes https://github.com/flutter/flutter/issues/169780 .
Renamed references to `conductor`, and removed `Release-process.md`
which was an out of date copy of internal documentation that did not
offer much (other than being another place to look, but simultaneously
not very useful).
2025-06-24 22:28:04 +00:00
gaaclarke
14bee0273a
License cpp jun23 ( #171047 )
...
Additions:
- There are no runtime exceptions now.
- There are some cases that are ignored for now where there wasn't clear
action on how to resolve them.
- Adds a script and license file that will be run by ci.
- Switched the excluded file to relative paths.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-06-24 21:51:19 +00:00
Jenn Magder
10bb72faba
Add android-reviewers to CODEOWNERS ( #170157 )
...
Mirror GitHub team-android labeller to android-reviewer CODEOWNERS so
that group is automatically put on Android PRs.
Add tools android and gradle files. Also add the Android embedder.
You can run `git ls-files packages/flutter_tools/**/*android*` etc to
see which files are included.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-06-24 21:08:13 +00:00
Sam Rawlins
0042be0562
Update tool/README.md regarding locally-built engine ( #171102 )
...
This needs some review, but reflects the merged engine repo.
CC @jonahwilliams
2025-06-24 21:06:55 +00:00
Mouad Debbar
08a7ec79b5
[web] Align the PR triage process with the ecosystem's triage flow ( #171086 )
...
_The following applies only to PRs in `flutter/packages`_
After speaking with @stuartmorgan-g, updating the team-web PR triage
links to align with the expectations of the ecosystem team:
1. The ecosystem team does a first pass triage and adds `triage-*`
labels to request review from other teams.
2. The web team reviews PRs labelled with `triage-web`.
3. The web team removes the `triage-web` label when they approve the PR
and don't need to look at it anymore.
4. If the web team is the last reviewer, they should apply the
`autosubmit` label.
2025-06-24 20:33:00 +00:00
Danny Tuppeny
7deecabc9a
[flutter_tool] Migrate DAP off ProcessUtils.writelnToStdinUnsafe ( #171081 )
...
Instead, queue up each write to ensure we don't try to write to the
stream concurrently which leads to "Bad state: StreamSink is bound to a
stream"
Fixes https://github.com/Dart-Code/Dart-Code/issues/5554
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-06-24 20:24:50 +00:00
Mouad Debbar
caf0c82b82
[web] More granular configuration of the test environment ( #168767 )
...
There's today a single boolean `debugEmulateFlutterTesterEnvironment`
that determines certain behaviors in the engine to emulate how the
Flutter Tester runs (more details at
https://github.com/flutter/flutter/issues/145779 ).
With this PR:
- Run all engine unit tests in production mode by default.
- Give tests more granular control over which test behaviors to
enable/disable (e.g. Ahem font).
- Keep it easy for framework tests to enable all emulation behaviors.
Fixes https://github.com/flutter/flutter/issues/145779
2025-06-24 19:45:19 +00:00
Salem Iranloye
5a0a9d0f9d
Clean up Devfs_Web into separate files ( #170769 )
...
Split the huge devfs_web file into separate easier to maintain files
Fixes: https://github.com/flutter/flutter/issues/170842
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-06-24 17:53:55 +00:00
davidhicks980
dfadc91433
Add RawMenuAnchor animation callbacks ( #167806 )
...
Alternative to https://github.com/flutter/flutter/pull/163481 ,
https://github.com/flutter/flutter/pull/167537 ,
https://github.com/flutter/flutter/pull/163481 that uses callbacks.
@dkwingsmt - you inspired me to simplify the menu behavior. I didn't end
up using Actions, mainly because nested behavior was unwieldy and
capturing BuildContext has drawbacks. This uses a basic callback
mechanism to animate the menu open and closed. Check out the examples.
<hr />
### The problem
RawMenuAnchor synchronously shows or hides an overlay menu in response
to `MenuController.open()` and `MenuController.close`, respectively.
Because animations cannot be run on a hidden overlay, there currently is
no way for developers to add animations to RawMenuAnchor and its
subclasses (MenuAnchor, DropdownMenuButton, etc).
### The solution
This PR:
- Adds two callbacks -- `onOpenRequested` and `onCloseRequested` -- to
RawMenuAnchor.
- onOpenRequested is called with a position and a showOverlay callback,
which opens the menu when called.
- onCloseRequested is called with a hideOverlay callback, which hides
the menu when called.
When `MenuController.open()` and `MenuController.close()` are called,
onOpenRequested and onCloseRequested are invoked, respectively.
Precursor for https://github.com/flutter/flutter/pull/143416 ,
https://github.com/flutter/flutter/issues/135025 ,
https://github.com/flutter/flutter/pull/143712
## Demo
https://github.com/user-attachments/assets/bb14abca-af26-45fe-8d45-289b5d07dab2
```dart
// Copyright 2014 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// ignore_for_file: public_member_api_docs
import 'dart:ui' as ui;
import 'package:flutter/material.dart' hide MenuController, RawMenuAnchor, RawMenuOverlayInfo;
import 'raw_menu_anchor.dart';
/// Flutter code sample for a [RawMenuAnchor] that animates a simple menu using
/// [RawMenuAnchor.onOpenRequested] and [RawMenuAnchor.onCloseRequested].
void main() {
runApp(const App());
}
class Menu extends StatefulWidget {
const Menu({super.key});
@override
State<Menu> createState() => _MenuState();
}
class _MenuState extends State<Menu> with SingleTickerProviderStateMixin {
late final AnimationController animationController;
final MenuController menuController = MenuController();
@override
void initState() {
super.initState();
animationController = AnimationController(
vsync: this,
duration: const Duration(milliseconds: 300),
);
}
@override
void dispose() {
animationController.dispose();
super.dispose();
}
void _handleMenuOpenRequest(Offset? position, void Function({Offset? position}) showOverlay) {
// Mount or reposition the menu before animating the menu open.
showOverlay(position: position);
if (animationController.isForwardOrCompleted) {
// If the menu is already open or opening, the animation is already
// running forward.
return;
}
// Animate the menu into view. This will cancel the closing animation.
animationController.forward();
}
void _handleMenuCloseRequest(VoidCallback hideOverlay) {
if (!animationController.isForwardOrCompleted) {
// If the menu is already closed or closing, do nothing.
return;
}
// Animate the menu out of view.
//
// Be sure to use `whenComplete` so that the closing animation
// can be interrupted by an opening animation.
animationController.reverse().whenComplete(() {
if (mounted) {
// Hide the menu after the menu has closed
hideOverlay();
}
});
}
@override
Widget build(BuildContext context) {
return RawMenuAnchor(
controller: menuController,
onOpenRequested: _handleMenuOpenRequest,
onCloseRequested: _handleMenuCloseRequest,
overlayBuilder: (BuildContext context, RawMenuOverlayInfo info) {
final ui.Offset position = info.anchorRect.bottomLeft;
return Positioned(
top: position.dy + 5,
left: position.dx,
child: TapRegion(
groupId: info.tapRegionGroupId,
child: Material(
color: ColorScheme.of(context).primaryContainer,
shape: RoundedRectangleBorder(borderRadius: BorderRadius.circular(8)),
elevation: 3,
child: SizeTransition(
sizeFactor: animationController,
child: const SizedBox(
height: 200,
width: 150,
child: Center(child: Text('Howdy', textAlign: TextAlign.center)),
),
),
),
),
);
},
builder: (BuildContext context, MenuController menuController, Widget? child) {
return FilledButton(
onPressed: () {
if (animationController.isForwardOrCompleted) {
menuController.close();
} else {
menuController.open();
}
},
child: const Text('Toggle Menu'),
);
},
);
}
}
class App extends StatelessWidget {
const App({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
theme: ThemeData(colorScheme: ColorScheme.fromSeed(seedColor: Colors.blue)),
home: const Scaffold(body: Center(child: Menu())),
);
}
}
```
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
2025-06-24 17:46:50 +00:00
Jason Simmons
12e4a898dc
Support wide gamut colors when applying a DlColor to an SkPaint ( #170613 )
...
Fixes https://github.com/flutter/flutter/issues/170203
2025-06-24 17:06:07 +00:00
Nicholas Shahan
8c104eb053
Remove temporary workaround for web testing ( #170949 )
...
Running applications with `-d web-server --web-experimental-hot-reload`
was fixed in https://github.com/flutter/flutter/commit/b757dab . These
tests can now run with the hot reload support enabled.
2025-06-24 16:19:40 +00:00
engine-flutter-autoroll
87748a0128
Roll Packages from 02770da46831 to d9d3191ea6cf (6 revisions) ( #171075 )
...
02770da468...d9d3191ea6stuartmorgan@google.com [google_sign_in] Redesign API for
current identity SDKs (flutter/packages#9267 )
2025-06-24 32538273+ValentinVignal@users.noreply.github.com [go_router]
Fix routing to treat URLs with different cases (e.g., `/Home` vs
`/home`) as distinct routes. (flutter/packages#9426 )
2025-06-23 stuartmorgan@google.com [google_sign_in] Redesign API for
current identity SDKs - Platform Implementations (flutter/packages#9479 )
2025-06-23 engine-flutter-autoroll@skia.org Roll Flutter from
0ab008a17228 to d733bea58c1a (16 revisions) (flutter/packages#9478 )
2025-06-23 32538273+ValentinVignal@users.noreply.github.com
[go_router_builder] Skip case sensitive test (flutter/packages#9444 )
2025-06-23 stuartmorgan@google.com [google_sign_in] Redesign API for
current identity SDKs - Platform Interface (flutter/packages#9454 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-24 15:43:13 +00:00
Victoria Ashworth
d49d805ea3
Add LLDB warnings ( #170827 )
...
LLDB is now required again for iOS 26+ so add back warnings.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-06-24 14:47:32 +00:00
Bruno Leroux
97853d5f1f
Update FormField.initialValue documentation ( #171061 )
...
## Description
This PR updates `FormField.initialValue` documentation to remove a
sentence which is obsolete since
https://github.com/flutter/flutter/pull/170805 .
## Tests
Documentation only PR.
2025-06-24 12:56:36 +00:00
engine-flutter-autoroll
a545ff5a33
Roll Skia from 132cb2052565 to a462e701b493 (2 revisions) ( #171063 )
...
https://skia.googlesource.com/skia.git/+log/132cb2052565..a462e701b493
2025-06-24 drott@google.com Reland "[Fontations] Roll Fontations"
2025-06-24
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,kjlubick@google.com,maxhudnell@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-24 11:20:36 +00:00
engine-flutter-autoroll
c2988b0bab
Roll Skia from f88706e3a863 to 132cb2052565 (4 revisions) ( #171057 )
...
https://skia.googlesource.com/skia.git/+log/f88706e3a863..132cb2052565
2025-06-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from 5220e634850e to 79ac1a8cd767 (8 revisions)
2025-06-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from d03fe7eda12d to 0df5a8fd9a75 (15 revisions)
2025-06-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from 63bd78a28535 to 6043290d5e93 (3 revisions)
2025-06-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
SwiftShader from 0ce9bc68d3fc to ed01d9931de3 (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,kjlubick@google.com,maxhudnell@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-24 09:10:28 +00:00
zhengzeqin
dd89ae96c4
When maintainHintSize is false, hint is centered and aligned, it is different from the original one ( #168654 )
...
This PR changes the Hint uses topLeft alignment when maintainHintSize is
false
> code
```dart
buildTextField() {
return const Center(
child: TextField(
decoration: InputDecoration(
hintText: 'hint',
maintainHintSize: false,
),
),
);
}
```
Before:
<img width="416" alt="b"
src="https://github.com/user-attachments/assets/fe58c2d0-4d37-4bca-aabc-0f7d4785fb2a "
/>
After:
<img width="415" alt="a"
src="https://github.com/user-attachments/assets/096fd83a-9d8f-4cb7-be1d-c3075acbfdc0 "
/>
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
---------
Co-authored-by: 郑泽钦 <zhengzeqin@addcn.com>
2025-06-24 08:04:12 +00:00
Bruno Leroux
0adb0337e0
Deprecate DropdownButtonFormField "value" parameter in favor of "initialValue" ( #170805 )
...
## Description
This PR renames the DropdownButtonFormField constuctor parameter 'value'
to 'initialValue'.
See
https://github.com/flutter/flutter/pull/170050#issuecomment-2965486000
and
https://github.com/flutter/flutter/pull/170050#issuecomment-2971920009
for some context.
## Related Issue
Fixes [DropdownButtonFormField retains selected value even after setting
value to null](https://github.com/flutter/flutter/issues/169983#top )
## Tests
Adds 2 tests (one to validate the deprecated parameter can still be
used, one for the dart fix).
Updates many (renaming the confusing parameter).
2025-06-24 07:08:21 +00:00
