engine-flutter-autoroll
708f53c4e6
Roll Flutter Engine from 311ba971bb3a to 4f2d866aef32 (4 revisions) ( #155329 )
...
311ba971bb...4f2d866aefskia-flutter-autoroll@skia.org Roll Skia from b5cc234f229d to 86abf2391374 (1 revision) (flutter/engine#55269 )
2024-09-17 skia-flutter-autoroll@skia.org Roll Dart SDK from 84fac36df65a to 50f697183f25 (3 revisions) (flutter/engine#55268 )
2024-09-17 bdero@google.com [Flutter GPU] Remove the redundant smoketest. (flutter/engine#55267 )
2024-09-17 30870216+gaaclarke@users.noreply.github.com Fixed solid blur style math (flutter/engine#55194 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-18 01:05:31 +00:00
Taha Tesser
d5e843eca3
Fix missing icon props in button styleFrom methods ( #154821 )
...
Fixes [Add missing icon props in button `styleFrom` methods.](https://github.com/flutter/flutter/issues/154798 )
### Description
Add missing icon propers in the following widgets:
- `ElevatedButton.styleFrom` (missing `iconSize`)
- `FilledButton.styleFrom` (missing `iconSize`)
- `OutlinedButton.styleFrom` (missing `iconSize`)
- `TextButton.styleFrom` (missing `iconSize`)
- `MenuItemButton.styleFrom` (missing `iconSize` and `disabledIconColor`)
- `SubmenuButton.styleFrom` (missing `iconSize` and `disabledIconColor`)
- `SegmentedButton.styleFrom` (missing `iconSize`, `iconColor`, and `disabledIconColor`)
### Code sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
enum Calendar { day, week, month, year }
void main() => runApp(const MyApp());
class MyApp extends StatefulWidget {
const MyApp({super.key});
@override
State<MyApp> createState() => _MyAppState();
}
class _MyAppState extends State<MyApp> {
Calendar calendarView = Calendar.week;
bool isEnabled = true;
@override
Widget build(BuildContext context) {
return MaterialApp(
debugShowCheckedModeBanner: false,
home: Scaffold(
body: Center(
child: Column(
spacing: 10.0,
mainAxisAlignment: MainAxisAlignment.center,
children: <Widget>[
ElevatedButton.icon(
style: ElevatedButton.styleFrom(
iconSize: 30,
iconColor: Colors.red,
disabledIconColor: Colors.red.withValues(alpha: 0.5),
),
onPressed: isEnabled ? () {} : null,
icon: const Icon(Icons.add),
label: const Text('ElevatedButton'),
),
FilledButton.icon(
style: ElevatedButton.styleFrom(
iconSize: 30,
iconColor: Colors.red,
disabledIconColor: Colors.red.withValues(alpha: 0.5),
),
onPressed: isEnabled ? () {} : null,
icon: const Icon(Icons.add),
label: const Text('FilledButton'),
),
FilledButton.tonalIcon(
style: ElevatedButton.styleFrom(
iconSize: 30,
iconColor: Colors.red,
disabledIconColor: Colors.red.withValues(alpha: 0.5),
),
onPressed: isEnabled ? () {} : null,
icon: const Icon(Icons.add),
label: const Text('Add'),
),
OutlinedButton.icon(
style: ElevatedButton.styleFrom(
iconSize: 30,
iconColor: Colors.red,
disabledIconColor: Colors.red.withValues(alpha: 0.5),
),
onPressed: isEnabled ? () {} : null,
icon: const Icon(Icons.add),
label: const Text('OutlinedButton'),
),
TextButton.icon(
style: ElevatedButton.styleFrom(
iconSize: 30,
iconColor: Colors.red,
disabledIconColor: Colors.red.withValues(alpha: 0.5),
),
onPressed: isEnabled ? () {} : null,
icon: const Icon(Icons.add),
label: const Text('TextButton'),
),
SizedBox(
width: 200,
child: MenuItemButton(
style: MenuItemButton.styleFrom(
iconSize: 30,
iconColor: Colors.red,
disabledIconColor: Colors.red.withValues(alpha: 0.5),
),
trailingIcon: const Icon(Icons.arrow_forward_ios),
onPressed: isEnabled ? () {} : null,
child: const Text('MenuItemButton'),
),
),
SizedBox(
width: 200,
child: SubmenuButton(
style: SubmenuButton.styleFrom(
iconSize: 30,
iconColor: Colors.red,
disabledIconColor: Colors.red.withValues(alpha: 0.5),
),
trailingIcon: const Icon(Icons.arrow_forward_ios),
menuChildren: <Widget>[
if (isEnabled) const Text('Item'),
],
child: const Text('SubmenuButton'),
),
),
SegmentedButton<Calendar>(
style: SegmentedButton.styleFrom(
iconColor: Colors.red,
iconSize: 30,
disabledIconColor: Colors.red.withValues(alpha: 0.5),
),
segments: const <ButtonSegment<Calendar>>[
ButtonSegment<Calendar>(
value: Calendar.day,
label: Text('Day'),
icon: Icon(Icons.calendar_view_day)),
ButtonSegment<Calendar>(
value: Calendar.week,
label: Text('Week'),
icon: Icon(Icons.calendar_view_week)),
ButtonSegment<Calendar>(
value: Calendar.month,
label: Text('Month'),
icon: Icon(Icons.calendar_view_month)),
ButtonSegment<Calendar>(
value: Calendar.year,
label: Text('Year'),
icon: Icon(Icons.calendar_today)),
],
selected: <Calendar>{calendarView},
onSelectionChanged:
isEnabled ? (Set<Calendar> newSelection) {} : null,
)
],
),
),
floatingActionButton: FloatingActionButton.extended(
onPressed: () {
setState(() {
isEnabled = !isEnabled;
});
},
label: Text(isEnabled ? 'Enabled' : 'Disabled'),
),
),
);
}
}
```
</details>
### Preview (Customized using icon props in `styleFrom` methods)
<img width="838" alt="Screenshot 2024-09-09 at 16 27 19" src="https://github.com/user-attachments/assets/551d328b-307f-4f63-b0e8-1358a12877f9 ">
2024-09-18 00:19:40 +00:00
engine-flutter-autoroll
d0a9e3be94
Roll Flutter Engine from 0ef18a3ef064 to 311ba971bb3a (8 revisions) ( #155325 )
...
0ef18a3ef0...311ba971bbskia-flutter-autoroll@skia.org Roll Skia from de3717fe550e to b5cc234f229d (1 revision) (flutter/engine#55266 )
2024-09-17 bdero@google.com Remove tinygltf (flutter/engine#55264 )
2024-09-17 bdero@google.com Update the Impeller Scene doc (flutter/engine#55265 )
2024-09-17 bdero@google.com [Flutter GPU] Add DeviceBuffer.flush & GpuContext.getMinimumUniformByteAlignment. (flutter/engine#53620 )
2024-09-17 bdero@google.com Remove scene GLB files (flutter/engine#55263 )
2024-09-17 bdero@google.com [Flutter GPU] Add golden test for rendering a triangle. (flutter/engine#55262 )
2024-09-17 skia-flutter-autoroll@skia.org Roll Dart SDK from de4a3d63671c to 84fac36df65a (2 revisions) (flutter/engine#55255 )
2024-09-17 skia-flutter-autoroll@skia.org Roll Skia from ad08229fd016 to de3717fe550e (5 revisions) (flutter/engine#55261 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-17 23:05:22 +00:00
Tong Mu
c57f99e419
[CupertinoAlertDialog] Add tap-slide gesture ( #154853 )
...
This PR adds "sliding tap" to `CupertinoAlertDialog` and fixes https://github.com/flutter/flutter/issues/19786 .
Much of the needed infrastructure has been implemented in https://github.com/flutter/flutter/pull/150219 , but this time with a new challenge to support disabled buttons, i.e. the button should not show tap highlight when pressed (https://github.com/flutter/flutter/issues/107371 ).
* Why? Because whether a button is disabled is assigned to `CupertinoDialogAction`, while the background is rendered by a private class that wraps the action widget and built by the dialog body. We need a way to pass the boolean "enabled" from the child to the parent when the action is pressed. After much experimentation, I think the best way is to propagate this boolean using the custom gesture callback.
* An alternative way is to make the wrapper widget use an inherited widget, which allows the child `CupertinoDialogAction` to place a `ValueGetter<bool> getEnabled` to the parent as soon as it's mounted. However, this is pretty ugly...
This PR also fixes https://github.com/flutter/flutter/issues/107371 , i.e. disabled `CupertinoDialogAction` no longer triggers the pressing highlight. However, while legacy buttons (custom button classes that are implemented by `GestureDetector.onTap`) still functions (their `onPressed` continues to work), disabled legacy buttons will still show pressing highlight, and there's no plan (actually, no way) to fix it.
All tests related to sliding taps in `CupertinoActionSheet` has been copied to `CupertinoAlertDialog`, with additional tests for disabled buttons.
2024-09-17 20:16:18 +00:00
John McDole
93eabf3558
Uninstall /can fail/ ( #155314 )
...
Error != Exception.
Fixes #149666
2024-09-17 19:17:06 +00:00
engine-flutter-autoroll
6fb9a19182
Roll Packages from df88c814248d to 4f2b9cd5b674 (3 revisions) ( #155312 )
...
df88c81424...4f2b9cd5b6engine-flutter-autoroll@skia.org Roll Flutter from 5d83a98331ac to c4c9f47c479d (15 revisions) (flutter/packages#7656 )
2024-09-17 engine-flutter-autoroll@skia.org Roll Flutter from 2d30fe448cd4 to 5d83a98331ac (5 revisions) (flutter/packages#7650 )
2024-09-17 stuartmorgan@google.com Revert "[webview_flutter] Improve flaky scroll tests" (flutter/packages#7652 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-17 19:02:26 +00:00
engine-flutter-autoroll
659236866e
Roll Flutter Engine from a1700b9ea2db to 0ef18a3ef064 (1 revision) ( #155311 )
...
a1700b9ea2...0ef18a3ef0reidbaker@google.com FlutterViewTest add back part 4 and 5 (flutter/engine#55243 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-17 18:56:05 +00:00
engine-flutter-autoroll
b99ac8942a
Roll Flutter Engine from 1376288f5c2a to a1700b9ea2db (2 revisions) ( #155290 )
...
1376288f5c...a1700b9ea2skia-flutter-autoroll@skia.org Roll Skia from be871a37a154 to ad08229fd016 (1 revision) (flutter/engine#55252 )
2024-09-17 skia-flutter-autoroll@skia.org Roll Skia from 0409718f34c6 to be871a37a154 (1 revision) (flutter/engine#55250 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-17 17:53:37 +00:00
zijiehe@
a4f45471bc
Delete packages/flutter_tools/lib/src/fuchsia directory ( #154880 )
...
It's not being actively used, and fuchsia team does not have bandwidth
to maintain it.
Bug: https://b.corp.google.com/issues/353729557
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2024-09-17 09:10:02 -07:00
gaaclarke
1db9a61348
Adds ColorSwatch matcher ( #155272 )
...
https://github.com/flutter/flutter/issues/155113
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2024-09-17 09:08:22 -07:00
engine-flutter-autoroll
c4c9f47c47
Roll Flutter Engine from a328f2362414 to 1376288f5c2a (1 revision) ( #155282 )
...
a328f23624...1376288f5cskia-flutter-autoroll@skia.org Roll Skia from d78293574d12 to 0409718f34c6 (1 revision) (flutter/engine#55248 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-17 05:27:11 +00:00
engine-flutter-autoroll
3b119ce6f1
Roll Flutter Engine from 04bc90bff86c to a328f2362414 (2 revisions) ( #155280 )
...
04bc90bff8...a328f23624skia-flutter-autoroll@skia.org Roll Skia from 68eeaa5e20dc to d78293574d12 (2 revisions) (flutter/engine#55245 )
2024-09-16 robert.ancell@canonical.com Delay the window until the first frame is received from the Flutter engine (flutter/engine#54703 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-17 01:57:07 +00:00
engine-flutter-autoroll
332bd8083d
Roll Flutter Engine from 6b698138c600 to 04bc90bff86c (3 revisions) ( #155277 )
...
6b698138c6...04bc90bff8chinmaygarde@google.com [Embedder] Warn when embedders try to enable an unsupported renderer. (flutter/engine#55240 )
2024-09-16 reidbaker@google.com flutter view add test 2 (flutter/engine#55188 )
2024-09-16 skia-flutter-autoroll@skia.org Roll Skia from 87ba10cbfad3 to 68eeaa5e20dc (1 revision) (flutter/engine#55239 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-16 23:59:09 +00:00
gaaclarke
af21d9f5b3
Added .keys to ColorSwatch ( #155262 )
...
This addresses the issue that ColorSwatch has operator[], but no way to know what are valid inputs.
issue: https://github.com/flutter/flutter/issues/155113
2024-09-16 21:20:32 +00:00
engine-flutter-autoroll
411b2ae1bd
Roll Flutter Engine from 362b9bcdedce to 6b698138c600 (4 revisions) ( #155267 )
...
362b9bcded...6b698138c6skia-flutter-autoroll@skia.org Roll Skia from ee5e413fe436 to 87ba10cbfad3 (5 revisions) (flutter/engine#55233 )
2024-09-16 skia-flutter-autoroll@skia.org Roll Skia from 3ebf0a14bbdd to ee5e413fe436 (1 revision) (flutter/engine#55229 )
2024-09-16 30870216+gaaclarke@users.noreply.github.com Added .vscode back to being ignored (flutter/engine#55195 )
2024-09-16 skia-flutter-autoroll@skia.org Roll Skia from 80583104076d to 3ebf0a14bbdd (1 revision) (flutter/engine#55228 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-16 20:44:14 +00:00
engine-flutter-autoroll
6d04a16210
Roll Packages from 330581face4b to df88c814248d (7 revisions) ( #155261 )
...
330581face...df88c8142410687576+bparrishMines@users.noreply.github.com [webview_flutter] Improve flaky scroll tests (flutter/packages#7621 )
2024-09-13 kevmoo@users.noreply.github.com Bump deps (flutter/packages#7357 )
2024-09-13 mhvdijk@gmail.com [flutter_adaptive_scaffold] Use improved MediaQuery methods (flutter/packages#7565 )
2024-09-13 109111084+yaakovschectman@users.noreply.github.com [many] Update example android apps to target SDK level 34. (flutter/packages#7587 )
2024-09-13 tarrinneal@gmail.com [pigeon] adds support for non nullable types in collections (flutter/packages#7547 )
2024-09-13 mhvdijk@gmail.com [flutter_adaptive_scaffold] Adds additional slot animation parameters (flutter/packages#7411 )
2024-09-13 engine-flutter-autoroll@skia.org Roll Flutter from 303f222e17e3 to 2d30fe448cd4 (21 revisions) (flutter/packages#7646 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-16 18:29:33 +00:00
Tess Strickland
c50b3fea32
Extend 'flutter symbolize' to handle deferred loading units. ( #149315 )
...
Adds `-u`/`--unit-id-debug-info` arguments to `flutter symbolize` to pass paths to DWARF information for deferred loading units. The argument passed via `-u` should be of the form `N:P`, where `N` is the loading unit ID (an integer) and `P` is the path to the debug information for loading unit `N`. The DWARF information for the root loading unit can either be passed by `-d`/`--debug-info` as before or by `--unit-id-debug-info 1:<path>`.
Partial fix for https://github.com/flutter/flutter/issues/137527 . Additional work is needed to adjust tools built on top of `flutter symbolize` to store and pass along this additional information appropriately when there are deferred loading units.
2024-09-16 17:55:05 +00:00
Christopher Fujino
b565379812
Catch unable to start app exception ( #154970 )
...
Fixes https://github.com/flutter/flutter/issues/153433
2024-09-16 17:32:49 +00:00
Jenn Magder
0a400f8cd8
Assert iOS framework artifact contains xcprivacy manifest ( #155187 )
...
Add tool test to validate a built iOS app contains the Flutter framework xcprivacy manifest.
Follow up to https://github.com/flutter/engine/pull/48951 .
2024-09-16 13:13:30 +00:00
engine-flutter-autoroll
cfdab3cdc8
Roll Flutter Engine from 52dcc8a16d8b to 362b9bcdedce (1 revision) ( #155241 )
...
52dcc8a16d...362b9bcdedskia-flutter-autoroll@skia.org Roll Skia from efd841820b09 to 80583104076d (1 revision) (flutter/engine#55223 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-16 10:43:25 +00:00
engine-flutter-autoroll
f073ed3f80
Roll Flutter Engine from af4fe97fa13a to 52dcc8a16d8b (1 revision) ( #155238 )
...
af4fe97fa1...52dcc8a16dskia-flutter-autoroll@skia.org Roll Skia from 2d4c662c2cab to efd841820b09 (3 revisions) (flutter/engine#55221 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-16 09:06:24 +00:00
engine-flutter-autoroll
93c8d00963
Roll Flutter Engine from 9aaea5a4bd50 to af4fe97fa13a (1 revision) ( #155235 )
...
9aaea5a4bd...af4fe97fa1skia-flutter-autoroll@skia.org Roll Skia from 2238d45e670e to 2d4c662c2cab (1 revision) (flutter/engine#55219 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-16 07:44:24 +00:00
engine-flutter-autoroll
b4903228eb
Roll Flutter Engine from fe22a199aca3 to 9aaea5a4bd50 (1 revision) ( #155232 )
...
fe22a199ac...9aaea5a4bdrobert.ancell@canonical.com Match Windows logic for picking RGB/BGR textures. (flutter/engine#55121 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-16 02:29:13 +00:00
engine-flutter-autoroll
d3e757cfb4
Roll Flutter Engine from f5ccef12c15c to fe22a199aca3 (1 revision) ( #155229 )
...
f5ccef12c1...fe22a199acskia-flutter-autoroll@skia.org Roll Skia from 175815a3feac to 2238d45e670e (1 revision) (flutter/engine#55213 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-15 20:52:33 +00:00
engine-flutter-autoroll
2c449a96f4
Roll Flutter Engine from 622d4aec2e04 to f5ccef12c15c (1 revision) ( #155215 )
...
622d4aec2e...f5ccef12c1skia-flutter-autoroll@skia.org Roll Skia from 0ec9b089fa9e to 175815a3feac (1 revision) (flutter/engine#55205 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-15 03:16:38 +00:00
engine-flutter-autoroll
5d83a98331
Roll Flutter Engine from c83cc8856282 to 622d4aec2e04 (1 revision) ( #155202 )
...
c83cc88562...622d4aec2eskia-flutter-autoroll@skia.org Roll Skia from 2b8e33aa4824 to 0ec9b089fa9e (1 revision) (flutter/engine#55201 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-14 14:54:34 +00:00
engine-flutter-autoroll
e1cb59fd9f
Roll Flutter Engine from 4d8d8517a0ff to c83cc8856282 (3 revisions) ( #155201 )
...
4d8d8517a0...c83cc88562skia-flutter-autoroll@skia.org Roll Dart SDK from c0f7e399ff4a to de4a3d63671c (1 revision) (flutter/engine#55199 )
2024-09-14 bdero@google.com [Impeller] desktop: Add missing dispatch for TextFrameDispatcher in embedder view. (flutter/engine#55197 )
2024-09-14 magder@google.com Add xcprivacy privacy manifest to macOS framework (flutter/engine#55078 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-14 13:51:25 +00:00
engine-flutter-autoroll
1dce0c7ffb
Roll Flutter Engine from ab9daaa0bcc7 to 4d8d8517a0ff (12 revisions) ( #155194 )
...
ab9daaa0bc...4d8d8517a034871572+gmackall@users.noreply.github.com Synthesize remove events on `PointerChange.ACTION_UP` and `PointerChange.ACTION_POINTER_UP` (flutter/engine#55157 )
2024-09-13 skia-flutter-autoroll@skia.org Roll Skia from bdc5e73cb6c9 to 2b8e33aa4824 (1 revision) (flutter/engine#55192 )
2024-09-13 skia-flutter-autoroll@skia.org Roll Dart SDK from 302b6472b849 to c0f7e399ff4a (1 revision) (flutter/engine#55191 )
2024-09-13 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[skwasm] Scene builder optimizations for platform view placement (#54949 )" (flutter/engine#55193 )
2024-09-13 flar@google.com Delete VolatilePathTracker in favor of Dispatch tracking (flutter/engine#55125 )
2024-09-13 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 3YH1DEYJ-s93fHBw5... to -kKh_AYzPh_iEmTxK... (flutter/engine#55190 )
2024-09-13 skia-flutter-autoroll@skia.org Roll Skia from 9877f459399a to bdc5e73cb6c9 (1 revision) (flutter/engine#55189 )
2024-09-13 jonahwilliams@google.com [impeller] add Android flag for disabling surface control for debugging. (flutter/engine#55185 )
2024-09-13 skia-flutter-autoroll@skia.org Roll Skia from a5a6d12b3642 to 9877f459399a (2 revisions) (flutter/engine#55187 )
2024-09-13 skia-flutter-autoroll@skia.org Roll Dart SDK from eb664303c5ff to 302b6472b849 (2 revisions) (flutter/engine#55182 )
2024-09-13 jacksongardner@google.com [skwasm] Scene builder optimizations for platform view placement (flutter/engine#54949 )
2024-09-13 reidbaker@google.com add back test itSendsTextShowPasswordToFrameworkOnAttach with new mock for display metrics (flutter/engine#55110 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 3YH1DEYJ-s93 to -kKh_AYzPh_i
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-14 03:30:24 +00:00
Denis Bowen
47aed96ca1
text button case rework ( #154943 )
...
Rework on the text button use case to pass [b/347102786](https://b.corp.google.com/347102786 ),
After talking with the tester, it seems like there isn't an issue with the A11y of the text button, rather just how the test case is set up. In order for the text case to pass, there needs to be real time feedback of an action that is done by pressing the text button (think of a dialog popup, or form submission notification).
So I rewrote the test case to mimic a simple form with a submit button that once submitted, will let the user know it is submitted with a snack bar notification. https://screencast.googleplex.com/cast/NTM0ODc1NDIxMDE2MDY0MHwzYWI4MTZhMS1hMA
2024-09-13 19:11:08 +00:00
engine-flutter-autoroll
07647cae9f
Roll Flutter Engine from bef48e87f438 to ab9daaa0bcc7 (3 revisions) ( #155172 )
...
bef48e87f4...ab9daaa0bcskia-flutter-autoroll@skia.org Roll Skia from 7cba76a07795 to a5a6d12b3642 (3 revisions) (flutter/engine#55179 )
2024-09-13 reidbaker@google.com Add copyright notices to java test files (flutter/engine#55155 )
2024-09-13 skia-flutter-autoroll@skia.org Roll Skia from abb4eeac59c2 to 7cba76a07795 (1 revision) (flutter/engine#55174 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-13 18:55:08 +00:00
engine-flutter-autoroll
2d30fe448c
Roll Packages from 91caa7a6e3dd to 330581face4b (4 revisions) ( #155171 )
...
91caa7a6e3...330581face43759233+kenzieschmoll@users.noreply.github.com Refactor the test benchmark app to make the example easier to follow (flutter/packages#7640 )
2024-09-12 matanlurey@users.noreply.github.com Fix an if statement with resumed video players on Android. (flutter/packages#7641 )
2024-09-12 engine-flutter-autoroll@skia.org Roll Flutter from 2e221e7308ba to 303f222e17e3 (77 revisions) (flutter/packages#7638 )
2024-09-12 109111084+yaakovschectman@users.noreply.github.com [google_maps_flutter_android] Convert `PlatformCameraUpdate` to pigeon. (flutter/packages#7507 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-13 18:39:25 +00:00
Kishan Rathore
bbc17fae3a
Fix: Flicker when reorderable list doesn't change its position ( #151026 )
...
Fix: Flicker when no update in index of dragged item
Resolves #150843
This PR ensures that even if we move dragged item anywhere in list and comeback to initial position, we smoothly adjust to that position.
2024-09-13 16:58:00 +00:00
Sigurd Meldgaard
2812d4685c
Stop reading .packages from flutter_tools. ( #154912 )
2024-09-13 13:53:05 +02:00
engine-flutter-autoroll
15c0ae0e5a
Roll Flutter Engine from 70109e3b40c0 to bef48e87f438 (1 revision) ( #155156 )
...
70109e3b40...bef48e87f4skia-flutter-autoroll@skia.org Roll Dart SDK from 6c1e919a85f2 to eb664303c5ff (2 revisions) (flutter/engine#55173 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-13 11:47:30 +00:00
engine-flutter-autoroll
cb6a4b97fb
Roll Flutter Engine from d917a15823f3 to 70109e3b40c0 (1 revision) ( #155151 )
...
d917a15823...70109e3b40skia-flutter-autoroll@skia.org Roll Skia from c8a493c589d6 to abb4eeac59c2 (2 revisions) (flutter/engine#55172 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-13 10:22:29 +00:00
engine-flutter-autoroll
46438acdba
Roll Flutter Engine from 94696ed75dea to d917a15823f3 (1 revision) ( #155147 )
...
94696ed75d...d917a15823skia-flutter-autoroll@skia.org Roll Skia from 515a23f3cbe1 to c8a493c589d6 (1 revision) (flutter/engine#55169 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-13 08:35:43 +00:00
Bruno Leroux
2277e05550
Fix TextField content should be selected on desktop when gaining focus ( #154916 )
...
## Description
This PR fixes the default selection on desktop when a text field is gaining focus.
Before this PR, when a text field is focused, the selection was collapsed at the end for all platforms except on Web where the entire content was selected.
After this PR, when a text field is focused, the entire content is selected on desktop and Web, and the selection is collapsed at the end on mobile platforms.
The implementation extends the work done in https://github.com/flutter/flutter/pull/119583 which implemented this feature for web.
## Related Issue
Fixes https://github.com/flutter/flutter/issues/150339 .
## Tests
Updates 1 test.
Fixes 2 tests.
2024-09-13 08:09:13 +00:00
engine-flutter-autoroll
221a58cdd0
Roll Flutter Engine from 04802b779045 to 94696ed75dea (1 revision) ( #155144 )
...
04802b7790...94696ed75dskia-flutter-autoroll@skia.org Roll Dart SDK from 23fc7751b8b2 to 6c1e919a85f2 (1 revision) (flutter/engine#55167 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-13 07:23:05 +00:00
engine-flutter-autoroll
1d5f36f014
Roll Flutter Engine from 3d8163f47919 to 04802b779045 (2 revisions) ( #155138 )
...
3d8163f479...04802b7790matanlurey@users.noreply.github.com Remove now unused extra args/opts/env from `run_tests.py`. (flutter/engine#55164 )
2024-09-13 matanlurey@users.noreply.github.com Remove `assert(() {... })` and other unnecessary patterns in `dart:ui` tests (flutter/engine#55165 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-13 02:59:31 +00:00
engine-flutter-autoroll
47b8a52e94
Roll Flutter Engine from 4d5fea97e933 to 3d8163f47919 (1 revision) ( #155136 )
...
4d5fea97e9...3d8163f479robert.ancell@canonical.com Filter out bad locales returned by g_get_language_names (flutter/engine#55091 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-13 02:02:17 +00:00
LongCatIsLooong
f513a69838
Mark _LayoutBuilderElement as always clean ( #154694 )
...
Fixes https://github.com/flutter/flutter/issues/154060
The error message doesn't make sense to me since one can call `setState` during the idle phase, and I'm not sure what this is guarding against without the right error message.
In the case of #154060 the layout builder was never laid out:
```
ââchild 1: _RenderLayoutBuilder#7c319 NEEDS-LAYOUT NEEDS-PAINT
â creator: LayoutBuilder â _BodyBuilder â MediaQuery â
â LayoutId-[<_ScaffoldSlot.body>] â CustomMultiChildLayout â
â _ActionsScope â Actions â AnimatedBuilder â DefaultTextStyle â
â AnimatedDefaultTextStyle â _InkFeatures-[GlobalKey#1f6eb ink
â renderer] â NotificationListener<LayoutChangedNotification> â â¯
â parentData: offset=Offset(0.0, 0.0); id=_ScaffoldSlot.body
â constraints: MISSING
â size: MISSING
```
So https://github.com/flutter/flutter/pull/154681 doesn't really fix #154060 since the layout callback cannot be run without a set of valid constraints.
Before the `BuildScope` change all `_inDirtyList` flags were unset after the `BuildOwner` finishes rebuilding the widget tree, so `LayoutBuilder._inDirtyLst` is always set to false after a frame even for layout builders that were never laid out.
With the `BuildScope` change, `LayoutBuilder` has its own `BuildScope` which is only flushed after LayoutBuilder gets its constraints.
2024-09-13 01:24:11 +00:00
engine-flutter-autoroll
3f78a5b1fc
Roll Flutter Engine from 8609af642725 to 4d5fea97e933 (7 revisions) ( #155134 )
...
8609af6427...4d5fea97e9matanlurey@users.noreply.github.com Remove all references to `litetest` from the engine repo. (flutter/engine#55163 )
2024-09-12 skia-flutter-autoroll@skia.org Roll Dart SDK from aa27c61f5859 to 23fc7751b8b2 (1 revision) (flutter/engine#55160 )
2024-09-12 skia-flutter-autoroll@skia.org Roll Skia from bcbc3038a8ad to 515a23f3cbe1 (2 revisions) (flutter/engine#55161 )
2024-09-12 bdero@google.com Remove Impeller Scene ð (flutter/engine#55118 )
2024-09-12 skia-flutter-autoroll@skia.org Roll Skia from 26b048c6a53b to bcbc3038a8ad (3 revisions) (flutter/engine#55159 )
2024-09-12 matanlurey@users.noreply.github.com Move `zircon_tests` from `package:litetest` to `package:async_helper`. (flutter/engine#55149 )
2024-09-12 34871572+gmackall@users.noreply.github.com Add a note about re generating Gradle lockfiles (flutter/engine#55150 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-13 01:06:24 +00:00
zijiehe@
fc9220c981
Disable fuchsia in flutter_tools ( #155111 )
...
This change disables fuchsia in flutter_tools, most of the fuchsia logic becomes no-op, so the test cases need to be removed altogether.
This change needs to go first to avoid breaking dependencies.
Bug: b/353729557
2024-09-12 23:40:06 +00:00
John McDole
b755641559
Address frame policy benchmark flakes ( #155130 )
...
Recently the microbenchmarks were flakey, but from an older bug. Turns out, `LiveTestWidgetsFlutterBindingFramePolicy` is defaulted to `fadePointers` with this fun note:
> This can result in additional frames being pumped beyond those that
the test itself requests, which can cause differences in behavior
Both `text_intrinsic_bench` and `build_bench` use a similar pattern:
* Load stocks app
* Open the menu
* Switch to `benchmark` frame policy
What happens, rarely, is that
`LiveTestWidgetsFlutterBinding.pumpBenchmark()` will call (async) `handleBeginFrame` and `handleDrawFrame`. `handleDrawFrame` juggles a tri-state boolean (null, false, true). This boolean is only reset to `null` when handleDrawFrame is called back to back, say, from an extra frame that was scheduled.
1. Switch tri-state boolean to an enum, its easier to read
2. remove asserts that compile away in benchmarks (`--profile`)
3. use `Error.throwWithStackTrace` to keep stack traces.
I've been running this test on device lab hardware for hundreds of runs and have not hit a failure yet.
Fixes #150542
Fixes #150543 - throw stack!
2024-09-12 23:19:15 +00:00
engine-flutter-autoroll
74caead4cd
Roll Flutter Engine from 48ddaf578fb0 to 8609af642725 (11 revisions) ( #155128 )
...
48ddaf578f...8609af642730870216+gaaclarke@users.noreply.github.com Revert "Update Color to do all calculations with floating point components" (flutter/engine#55153 )
2024-09-12 matanlurey@users.noreply.github.com Migrate more tests from `litetest` to `package:test` (flutter/engine#55119 )
2024-09-12 skia-flutter-autoroll@skia.org Roll Skia from acff7f24ddbe to 26b048c6a53b (1 revision) (flutter/engine#55151 )
2024-09-12 skia-flutter-autoroll@skia.org Roll Dart SDK from a438066d634f to aa27c61f5859 (8 revisions) (flutter/engine#55147 )
2024-09-12 bungeman@chromium.org Update Skia build for Vulkan headers (flutter/engine#55143 )
2024-09-12 skia-flutter-autoroll@skia.org Roll Skia from 2b40b50ea423 to acff7f24ddbe (1 revision) (flutter/engine#55144 )
2024-09-12 30870216+gaaclarke@users.noreply.github.com Update Color to do all calculations with floating point components (flutter/engine#54981 )
2024-09-12 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from fKNT8lbGh8JzxjE6m... to 3YH1DEYJ-s93fHBw5... (flutter/engine#55142 )
2024-09-12 matanlurey@users.noreply.github.com Migrate `const_finder_test` to use `package:test` (flutter/engine#55132 )
2024-09-12 jonahwilliams@google.com [engine] make UI thread the platform thread for Android. Still allows opt out as g3 escape hatch. (flutter/engine#55111 )
2024-09-12 skia-flutter-autoroll@skia.org Roll Skia from b750cbedc114 to 2b40b50ea423 (1 revision) (flutter/engine#55141 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from fKNT8lbGh8Jz to 3YH1DEYJ-s93
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-12 23:19:13 +00:00
dependabot[bot]
5e28f3fe7d
Bump peter-evans/create-pull-request from 7.0.1 to 7.0.2 ( #155126 )
...
Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request ) from 7.0.1 to 7.0.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/peter-evans/create-pull-request/releases ">peter-evans/create-pull-request's releases</a>.</em></p>
<blockquote>
<h2>Create Pull Request v7.0.2</h2>
<p>âï¸ Fixes an issue with commit signing when a change was detected as being a rename or copy.</p>
<h2>What's Changed</h2>
<ul>
<li>build(deps-dev): bump <code>@âtypes/node</code> from 18.19.48 to 18.19.50 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3320 ">peter-evans/create-pull-request#3320</a></li>
<li>build(deps-dev): bump typescript from 5.5.4 to 5.6.2 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3319 ">peter-evans/create-pull-request#3319</a></li>
<li>fix: disable diff detection for renames and copies by <a href="https://github.com/peter-evans "><code>@âpeter-evans</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3330 ">peter-evans/create-pull-request#3330</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/peter-evans/create-pull-request/compare/v7.0.1...v7.0.2 ">https://github.com/peter-evans/create-pull-request/compare/v7.0.1...v7.0.2 </a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="d121e62763https://redirect.github.com/peter-evans/create-pull-request/issues/3330 ">#3330</a>)</li>
<li><a href="f4d66f4d5ahttps://redirect.github.com/peter-evans/create-pull-request/issues/3319 ">#3319</a>)</li>
<li><a href="488c869d17https://redirect.github.com/peter-evans/create-pull-request/issues/3320 ">#3320</a>)</li>
<li><a href="5354f856168867c4aba1...d121e62763https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=peter-evans/create-pull-request&package-manager=github_actions&previous-version=7.0.1&new-version=7.0.2 )](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2024-09-12 21:43:24 +00:00
LongCatIsLooong
dbb588b6e8
Prevent the keyboard from reshowing on iOS ( #154584 )
...
Fixes https://github.com/flutter/flutter/issues/154156
Some iOS keyboard implementations change the selection in the text field if dismissed with active composing regions. The framework should not call `requestKeyboard` in such cases since that would bring up the keyboard again.
In general the `TextInput.show` call is not needed for selection only changes. For working around https://github.com/flutter/flutter/issues/68571 the show call is needed only if we restarted the input on Android (and we don't restart on selection-only changes any way).
2024-09-12 21:29:13 +00:00
Kristen McWilliam
ea3c3e719e
fix(Linux): specify application id ( #154522 )
...
This change sets the program name to the application ID, which helps various
systems like GTK and desktop environments map this running application to its
corresponding .desktop file. This ensures better integration by allowing the
application to be recognized beyond its binary name.
Notably, this is necessary on Wayland to map the running application window to
the desktop file, and therefore apply the correct icon.
I've tested that this works in both GNOME & KDE Wayland sessions.
Partially addresses https://github.com/flutter/flutter/issues/53229
Resolves https://github.com/flutter/flutter/issues/154521
## Icon Association
### Task switcher
The task switcher shows the application's icon in the bottom-middle. Before it only showed a generic Wayland icon.
| Before | After |
|-------- |------- |
|  | |
### Window Decorations
KDE shows the application's icon on the window decorations, at the top-left. Before it only showed a generic Wayland icon.
| Before | After |
|-------- |------- |
|  |  |
2024-09-12 20:52:50 +00:00
Kevin Chisholm
afaecd9bf0
update changelog on master ( #155109 )
...
Merges changes from stable to master.
2024-09-12 18:58:57 +00:00
Chris Bracken
0cd170798c
iOS: update provisioning profile for 2024-2025 cert ( #155101 )
...
Tells our iOS bots to use the provisioning profile stored in the flutter_internal/mac/mobileprovision CIPD packages tagged `version:to_2025`.
This CIPD package contains an updated provisioning profile which supports both the current development signing certificate expiring in October 2024, and the updated signing cert expiring in August 2025.
CIPD packages can be seen at:
https://chrome-infra-packages.appspot.com/p/flutter_internal/mac/mobileprovision
This is a reland of #155052 , except without the removal of the CIPD dependency from the devicelab bots. After landing the original, many devicelab bots (and only devicelab bots) started failing with signing errors. The devicelab bots *should* be getting their certs/provisioning profile via the devicelab Salt configuration server (Googlers, see: go/flutter-salt) but it's possible some tests are fetching it from the CIPD package instead. This new patch simply updates the CIPD package version wherever it was already present. We can attempt to remove the CIPD package dependency from devicelab bots in a followup PR, and switch those over to using the profile installed via Salt (these are the same profile).
Required for: https://g-issues.chromium.org/issues/366034566
Issue: https://github.com/flutter/flutter/issues/152888
2024-09-12 18:15:58 +00:00
