Changes to make this work:
- Had to change the use of an UBool constant `FALSE` to 0 because
the file referring to it does not include the respective header.
- Had to change the license checker to ignore files in the directory
icu/source/samples. There were random changes to the licensing
headers which tripped up license checks. And since we don't include
samples in the binaries we build, the most efficient way to fix it is
to exclude sample code from license checks.
Issue: https://github.com/flutter/flutter/issues/70370
* remove the extra values which was overshadowing the test result
* increase difference. canvaskit gives different results
* increase difference more. firefox gave 1.7 diff. add comments
This reverts commit 698b69f, relanding #22267, now that flutter/flutter#70252 has landed to prevent the problems it had the first time.
Here is the original PR description:
For some reason (probably a bad merge on my part), the return values for locale and locales are not the same on web as they are on other platforms for the PlatformDispatcher and SingletonFlutterWindow classes. The web versions are non-nullable and the others are nullable.
This converts them to be the same (non-nullable) values
Instead of synchronousResizing flag which in some cases seems to be set too early, synchronous resizing is postponed until framework produces a frame so ResizeSynchronizer knows for sure that the engine is up and running.
FontLanguageListCache.cpp uses the ICU constant FALSE of type UBool, but
does not #include <umachine.h> where it is defined.
This makes the code brittle with respect to header file reorganization,
and I found this while trying to roll ICU version 68.1 to Flutter
engine.
* Revert "Remove GetExternalViewEmbedder from surface (#22272)"
This reverts commit 9dffddd08d0ad6fa7434c5a5bdff87e09da92e57.
* Revert "Rasterizer is initialized with an external view embedder (#22405)"
This reverts commit 417c869d6bcd70ba82fdd6efc8db1efa19fb997c.
* testing running the tests on all build modes
* don't run debug mode on other browsers
* fix platform message test failures
* some cleanup. change dispose platform channel message
* adding flags to control the integration tests better with felt
* running tests by target name, selecting web rendering backend
* fix conditions
* carrying some conditions to helper methods. Adding comments
* create a blocked list for failing canvaskit test
* parse parameters before all integration tests
* Give better warning to developers for tests that are blocked for CI
* address some reviwer comments (more remains)
* remove named parameters
* also run with auto mode
* add verbose option
* reduce the number of tests running. skip url_test for now
For some reason (probably a bad merge on my part), the return values for locale and locales are not the same on web as they are on other platforms for the PlatformDispatcher and SingletonFlutterWindow classes. The web versions are non-nullable and the others are nullable.
This converts them to be the same (non-nullable) values.
