DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
84,692 Commits 882 Branches 1,069 Tags
Commit Graph

84692 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
engine-flutter-autoroll
6d821e6681
Roll Dart SDK from 6a4b11760906 to cc2f604acb05 (1 revision) (#170895) 
https://dart.googlesource.com/sdk.git/+log/6a4b11760906..cc2f604acb05

2025-06-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-254.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-06-20 03:51:10 +00:00
engine-flutter-autoroll
ff957e10a8
Roll Skia from 61c89daa3888 to 2ac2476b0bcb (4 revisions) (#170890) 
https://skia.googlesource.com/skia.git/+log/61c89daa3888..2ac2476b0bcb

2025-06-19 syoussefi@google.com [vulkan] Use std::vector<uint32_t> for
SPIR-V
2025-06-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 978144890e92 to 1c18b20944ca (14 revisions)
2025-06-19 michaelludwig@google.com Revert "[Fontations] Roll
Fontations"
2025-06-19 michaelludwig@google.com [graphite] Context::insertRecording
returns more status info on failure

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
danieldilan@google.com,jimgraham@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-06-19 22:10:36 +00:00
engine-flutter-autoroll
0970a6bedb
Roll Dart SDK from bce9abe03175 to 6a4b11760906 (1 revision) (#170884) 
https://dart.googlesource.com/sdk.git/+log/bce9abe03175..6a4b11760906

2025-06-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-253.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-06-19 19:44:12 +00:00
Ben Konyi
6fe40caccf
[ Tool ] Roll DDS 5.0.3 (#170880) 
Fixes https://github.com/dart-lang/sdk/issues/60851
 2025-06-19 19:05:26 +00:00
engine-flutter-autoroll
86e1fbfbd6
Roll Packages from 715a0a5c4fdd to 0ec405358e43 (8 revisions) (#170879) 
715a0a5c4f...0ec405358e

2025-06-19 engine-flutter-autoroll@skia.org Roll Flutter from
8303a96a0a99 to 85a9b4f38906 (93 revisions) (flutter/packages#9457)
2025-06-19 32538273+ValentinVignal@users.noreply.github.com [go_router]
Update sype safe routing topic to use mixin from go_router_builder 3.0.0
(flutter/packages#9422)
2025-06-19 august.oberhauser@swissinfo.ch [go_router] fix:
PopScope.onPopInvokedWithResult not called in branch routes
(flutter/packages#9245)
2025-06-18 10687576+bparrishMines@users.noreply.github.com [pigeon]
Create a message call free InstanceManager when running unit tests
(flutter/packages#9395)
2025-06-18 737941+loic-sharma@users.noreply.github.com [go_router] Use
library prefix for meta (flutter/packages#9434)
2025-06-18 41765610+ahyangnb@users.noreply.github.com [go_router] fix
Popping state and re-rendering scaffold at the same time doesn't update
the URL on web [new] (flutter/packages#8352)
2025-06-18 robert.odrowaz@leancode.pl [camera_avfoundation] Fix
incorrect types in image stream events (flutter/packages#9418)
2025-06-18 stuartmorgan@google.com [go_router_builder] Temporarily
restrict `build` (flutter/packages#9453)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-06-19 17:19:12 +00:00
engine-flutter-autoroll
6cfdc63c91
Roll Skia from 794936b23812 to 61c89daa3888 (7 revisions) (#170878) 
https://skia.googlesource.com/skia.git/+log/794936b23812..61c89daa3888

2025-06-19 mike@reedtribe.org Introducing SkPathRaw
2025-06-19 mike@reedtribe.org Use SkSpan in SkData
2025-06-19 syoussefi@google.com Manual bug id map to the new issue
tracker
2025-06-19 syoussefi@google.com [graphite][vulkan] Simplify render pass
creation
2025-06-19 mike@reedtribe.org Reapply "remove guard -- it is now in all
clients"
2025-06-19 drott@chromium.org [Fontations] Roll Fontations
2025-06-19 michaelludwig@google.com [graphite] Generate blurred rrect
profile on the GPU

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
danieldilan@google.com,jimgraham@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-06-19 17:13:13 +00:00
engine-flutter-autoroll
85a9b4f389
Roll Skia from af242598f14d to 794936b23812 (2 revisions) (#170875) 
https://skia.googlesource.com/skia.git/+log/af242598f14d..794936b23812

2025-06-19 syoussefi@google.com Replace bug ids with mapped ids in the
new issue tracker - v2
2025-06-19 syoussefi@google.com Reland "[vulkan] Add helpers for Skia to
enable Vulkan features"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
danieldilan@google.com,jimgraham@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-06-19 14:56:50 +00:00
gourabkumarsi
3143e7c00c
Drop support for 21/22 Lollipop (#170748) 
Update Robolectric tests to run on minSdk 23. Some of the code are
modified/removed to support the same.

<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->

*Replace this paragraph with a description of what this PR is changing
or adding, and why. Consider including before/after screenshots.*

*List which issues are fixed by this PR. You must list at least one
issue. An issue is not required if the PR fixes something trivial like a
typo.*

*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-06-19 14:53:21 +00:00
engine-flutter-autoroll
2d383ad32e
Roll Dart SDK from 6020126c10e8 to bce9abe03175 (1 revision) (#170872) 
https://dart.googlesource.com/sdk.git/+log/6020126c10e8..bce9abe03175

2025-06-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-252.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-06-19 14:37:26 +00:00
engine-flutter-autoroll
44c6e065d7
Roll Skia from df97f7f407db to af242598f14d (4 revisions) (#170867) 
https://skia.googlesource.com/skia.git/+log/df97f7f407db..af242598f14d

2025-06-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from 9e0008570681 to 5928133450bb (4 revisions)
2025-06-19
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-06-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from 591e8cd0c6ad to 83f69a4f154f (19 revisions)
2025-06-19 syoussefi@google.com [graphite] Remove ShaderInfo::fRootNodes

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
danieldilan@google.com,jimgraham@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-06-19 10:38:19 +00:00
engine-flutter-autoroll
a56ef5fa31
Roll Skia from 1d8f7ebd23cc to df97f7f407db (5 revisions) (#170864) 
https://skia.googlesource.com/skia.git/+log/1d8f7ebd23cc..df97f7f407db

2025-06-19
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-06-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from ee0bcc111afe to 978144890e92 (1 revision)
2025-06-19 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com
Update SKP version
2025-06-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from e3ddb182d581 to d2f0baa84b48 (17 revisions)
2025-06-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
SwiftShader from 7b7b93aa0b85 to 47399fc146fa (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
danieldilan@google.com,jimgraham@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-06-19 08:28:33 +00:00
engine-flutter-autoroll
4953a988cd
Roll Dart SDK from 4ab716b09e9d to 6020126c10e8 (1 revision) (#170862) 
https://dart.googlesource.com/sdk.git/+log/4ab716b09e9d..6020126c10e8

2025-06-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-251.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-06-19 08:24:40 +00:00
engine-flutter-autoroll
40f4988e53
Roll Skia from 291d41414fa7 to 1d8f7ebd23cc (2 revisions) (#170857) 
https://skia.googlesource.com/skia.git/+log/291d41414fa7..1d8f7ebd23cc

2025-06-19 mike@reedtribe.org Revert "remove guard -- it is now in all
clients"
2025-06-18 nicolettep@google.com [graphite] Add skipColorXForm attribute
to PaintOption

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
danieldilan@google.com,jimgraham@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-06-19 03:41:25 +00:00
engine-flutter-autoroll
2bf0e0c683
Roll Dart SDK from b32559bca3cc to 4ab716b09e9d (9 revisions) (#170855) 
https://dart.googlesource.com/sdk.git/+log/b32559bca3cc..4ab716b09e9d

2025-06-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-250.0.dev
2025-06-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-249.0.dev
2025-06-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-248.0.dev
2025-06-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-247.0.dev
2025-06-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-246.0.dev
2025-06-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-245.0.dev
2025-06-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-244.0.dev
2025-06-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-243.0.dev
2025-06-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-242.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-06-19 02:55:07 +00:00
Jessy Yameogo
b757dab0e2
remove --start-paused flag by default and set useDwdsWebSocketConnect… (#170612) 
- Removed --start-paused flag by default and set
useDwdsWebSocketConnection in DWDS
- Updated logic for adding middleware and generating loadindicator
- Revert changes in https://github.com/flutter/flutter/pull/170610/

Related to https://github.com/dart-lang/webdev/issues/2605.
Fixes https://github.com/dart-lang/sdk/issues/60289. 

Sibling PR in DWDS: https://github.com/dart-lang/webdev/pull/2629
This PR will need to be submitted before this one. The pubspec must be
updated with a new release of DWDS after the changes are submitted
 2025-06-19 01:07:08 +00:00
Matan Lurey
d77e14ce4f
Engine builders no longer require is_fusion (#170849) 
Yay, we're de-fused!

/cc @LouiseHsu
 2025-06-18 23:59:09 +00:00
engine-flutter-autoroll
2e50924df5
Roll Skia from 5f110d5f48a3 to 291d41414fa7 (2 revisions) (#170836) 
https://skia.googlesource.com/skia.git/+log/5f110d5f48a3..291d41414fa7

2025-06-18 michaelludwig@google.com Skip SkColorSpaceXform_* GPU tests
on protected configs
2025-06-18 nicolettep@google.com Update some files to use new SkMatrix
span APIs

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
danieldilan@google.com,jimgraham@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-06-18 23:16:06 +00:00
Robert Ancell
d4ab90823e
Use a shared vertex buffer for rendering layers. (#170717) 
Only generate the vertex buffer once, and use uniforms to translate and
scale it in the vertex shader.

We still need to generate the vertex for each view, which seems
unnecessary but it cannot be shared across contexts in OpenGL. This
should be tackled in a future change.
 2025-06-18 23:14:11 +00:00
gaaclarke
db2832a644
fixes deeplinking in uiscenedelegate migrated projects (#170452) 
fixes https://github.com/flutter/flutter/issues/170350

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-06-18 21:43:51 +00:00
Jonah Williams
0d333d7193
[Impeller] fix array uniforms on GLES backend. (#170710) 
Fixes https://github.com/flutter/flutter/issues/170647


Correctly account for the size of array elements for runtime effect
shaders on the GLES backend.
 2025-06-18 21:12:03 +00:00
Chinmay Garde
edc792e098
[Impeller] Update README to add section about custom embedders. (#170077) 
Also cleans up out-of-date iOS/Android guidance.

Fixes https://github.com/flutter/flutter/issues/170074
 2025-06-18 21:01:19 +00:00
Jason Simmons
37a6e5fbfb
Escape the forbidden strings in the regex used to check test command output (#170702) 
The forbidden string might be something like "[ERROR" that contains
characters used in the regex syntax.
 2025-06-18 20:49:59 +00:00
gaaclarke
556b20e7c3
License cpp jun16 (#170716) 
The big additions here are:
1) Checking against the catalog of known licenses
1) Parsing of the known catalogs from disk
1) Nicer error messages

With this PR we are getting pretty close to feature parity. The big
changes left are updating the contents of of the data directory so we
match what we want. Execution across the directory is still around 35s.

Known extra work:
1) Propagate the `data` directory
1) Make sure the auditable output is looking as we want it
1) Make sure to treat the root directory different where we want to
enforce the presence of the file copyright
1) Remove hardcoded name "engine" for the root directory (that means
shifting all the integration tests to run in a `engine` directory.
1) Maybe cleanup the file format for the known licenses?

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-06-18 20:47:39 +00:00
Chinmay Garde
9c3a133e4f
Work around newer compilers requiring the satisfaction of three-way comparison of EncodableValue. (#170822) 
Evolution of a previous blocker
https://github.com/flutter/engine/pull/43091.
Fixes b/423885648
 2025-06-18 20:03:27 +00:00
Ramon Farizel
90b958cdc3
Update didUnmountRenderObject text description (#169628) 
fixes: https://github.com/flutter/flutter/issues/163550

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

---------

Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
 2025-06-18 19:27:56 +00:00
engine-flutter-autoroll
ae285146ba
Roll Skia from 297dbc32a6c7 to 5f110d5f48a3 (2 revisions) (#170821) 
https://skia.googlesource.com/skia.git/+log/297dbc32a6c7..5f110d5f48a3

2025-06-18 robertphillips@google.com [graphite] More Android-specific
PaintOptions
2025-06-18 michaelludwig@google.com Revert "[vulkan] Add helpers for
Skia to enable Vulkan features"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
danieldilan@google.com,jimgraham@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-06-18 19:19:54 +00:00
Matan Lurey
ea010f3e44
Add an initial "Using feature flags" doc for the team. (#170767) 
Closes https://github.com/flutter/flutter/issues/170456.

There are still some TODOs I'd like to address, but in follow-up PRs:

- Update the `# Framework` sub-sections after #168437 merges
- Add known limitations (i.e. embedder/engine)
- Add best practices (using a feature flag versus just using a
parameter, named constructor, etc)
 2025-06-18 19:02:33 +00:00
Kishan Rathore
5ecde8a2c4
Feat: Add mouse cursor for CupertinoDialogAction (#169051) 
This PR updates the mouse pointer behavior for CupertinoDialogAction to
display a pointer cursor when hovering over the action button.
Currently, when hovering over CupertinoDialogAction buttons on desktop
platforms, the default cursor is shown instead of changing to a pointer
cursor, which doesn't provide proper visual feedback to users that the
element is clickable.

## Changes
- Added mouse cursor property to CupertinoDialogAction to display
SystemMouseCursors.click when hovering
- Updated relevant tests to verify the cursor behavior

## Technical Details
The implementation adds the appropriate cursor property to the
CupertinoDialogAction widget, ensuring that when users hover over the
action button on desktop platforms, the cursor changes to a pointer,
indicating that the element is clickable.

## Related Issues
fixes: #169037 (Mouse style doesn't change to pointer when hovering over
CupertinoDialogAction on Desktop)
Part of: #58192 (Add mouse cursor support to the remaining widgets)

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

---------

Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
Co-authored-by: chunhtai <47866232+chunhtai@users.noreply.github.com>
 2025-06-18 18:38:40 +00:00
Matan Lurey
784e5149aa
Update Engine-artifacts.md to reflect flutter/cocoon/4785 (#170751) 
See https://github.com/flutter/cocoon/pull/4785.
 2025-06-18 18:17:48 +00:00
Alex Medinsh
25931666f3
CupertinoPicker new onChanged behaviour (#170202) 
This PR adds a new behaviour to `ListWheelScrollView` that allows to
switch between reporting changes on scroll update or only on scroll end.
`CupertinoPicker` now has a `changeReportingBehavior` param that
forwards to `ListWheelScrollView`.

New behaviour is a breaking change if set as default, so I have added
the `changeReportingBehavior` param to opt-in. My idea is that it can be
marked as `Deprecated` immediately and then removed from
`CupertinoPicker` later or we can just leave the param there and make it
more customizable.

I am open to other ideas on how to land this without breaking clients.

Fixes https://github.com/flutter/flutter/issues/170201

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
 2025-06-18 18:03:20 +00:00
Tirth
9bfb92e6f8
Rename entryPointBaseUrl to entrypointBaseUrl (#170166) 
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->

Closes #168968 

Need to change here as well -
https://github.com/flutter/website/blob/main/src/content/platform-integration/web/initialization.md

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-06-18 17:48:04 +00:00
engine-flutter-autoroll
fac358d6fe
Roll Skia from 1cb13a21b547 to 297dbc32a6c7 (4 revisions) (#170809) 
https://skia.googlesource.com/skia.git/+log/1cb13a21b547..297dbc32a6c7

2025-06-18 michaelludwig@google.com [graphite] De-register gen ID
listeners added by ProxyCache
2025-06-18 syoussefi@google.com [vulkan] Add helpers for Skia to enable
Vulkan features
2025-06-18 ccameron@chromium.org HDR v2: Add SkColorSpaceXform raster,
graphite, and GLSL support
2025-06-18 mike@reedtribe.org remove guard -- it is now in all clients

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
danieldilan@google.com,jimgraham@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-06-18 16:58:13 +00:00
engine-flutter-autoroll
75a77fec8c
Roll Packages from 25d4fa425508 to 715a0a5c4fdd (2 revisions) (#170808) 
25d4fa4255...715a0a5c4f

2025-06-17 32538273+ValentinVignal@users.noreply.github.com
[go_router_builder] Update readme to use mixin `with _$RouteName`
(flutter/packages#9423)
2025-06-17 sokolovskyi.konstantin@gmail.com [rfw] Update tests to no
longer depend on a `Container` pumped via `testWidgets`.
(flutter/packages#9063)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-06-18 15:52:07 +00:00
engine-flutter-autoroll
6056b55399
Roll Skia from 0a106c038cd0 to 1cb13a21b547 (1 revision) (#170801) 
https://skia.googlesource.com/skia.git/+log/0a106c038cd0..1cb13a21b547

2025-06-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from c1dac6e0d1f5 to ee0bcc111afe (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
danieldilan@google.com,jimgraham@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-06-18 14:43:12 +00:00
Derek Xu
b6d2b3552b
Add --profile-microtasks switch (#170690) 
This PR adds a switch that can be used to set [the Dart VM's
`profile_microtasks`
flag](c48dd51b90/runtime/vm/microtask_mirror_queues.cc (L18-L23)).
 2025-06-18 14:13:32 +00:00
engine-flutter-autoroll
31d11b5695
Roll Skia from ff7fffa5dac5 to 0a106c038cd0 (3 revisions) (#170795) 
https://skia.googlesource.com/skia.git/+log/ff7fffa5dac5..0a106c038cd0

2025-06-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from dfefcbc68cc3 to 9e0008570681 (7 revisions)
2025-06-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from 7f698b0f4af7 to 591e8cd0c6ad (17 revisions)
2025-06-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from b72a76c990d9 to c1dac6e0d1f5 (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
danieldilan@google.com,jimgraham@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-06-18 12:29:27 +00:00
Dipali Thakare
74ff8767a7
Add example for CupertinoExpansionTile transition modes (#170335) 
This PR adds a combined example for the CupertinoExpansionTile widget,
demonstrating its usage with both available transition modes: fade and
scroll.

**A demo app showing two CupertinoExpansionTile widgets:**

- One using the default fade transition mode

- One using the scroll transition mode

A corresponding widget test verifying expand/collapse behavior for both
tiles

### Issue
Closes: #167317

## Tests

- Added widget tests to validate the expand and collapse behavior for
both transition modes




## Pre-launch Checklist

- [x] I read the [Contributor
Guide](https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview)
and followed the process outlined there for submitting PRs.
- [x] I read the [Tree
Hygiene](https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md)
wiki page, which explains my responsibilities.
- [x] I read and followed the [Flutter Style
Guide](https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md),
including [Features we expect every widget to
implement](https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement).
- [x] I signed the [CLA](https://cla.developers.google.com/).
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with ///).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt](https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests).
- [x] I followed the [breaking change
policy](https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes)
and added [Data Driven
Fixes](https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md)
where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on
[Discord](https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md).
 2025-06-18 06:52:21 +00:00
jcheng
061dd46f15
feat: Add radius to DividerThemeData. (#169739) 
close: https://github.com/flutter/flutter/issues/169738

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
 2025-06-18 05:29:09 +00:00
engine-flutter-autoroll
112f101328
Roll Skia from 75af9450b121 to ff7fffa5dac5 (3 revisions) (#170772) 
https://skia.googlesource.com/skia.git/+log/75af9450b121..ff7fffa5dac5

2025-06-17 thomsmit@google.com Remove adaptive epsilon for
GrTriangulator
2025-06-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 8d1a39bd39e4 to b72a76c990d9 (3 revisions)
2025-06-17 michaelludwig@google.com [graphite] Visit clip stack before
choosing renderer

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
danieldilan@google.com,jimgraham@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-06-18 03:06:26 +00:00
auto-submit[bot]
5bdd0beed2
Reverts "add run_gradle_lock_files_check.dart for new PR's that modify gradle files (#169245)" (#170770) 
<!-- start_original_pr_link -->
Reverts: flutter/flutter#169245
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: matanlurey
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: Increased the time of the test task
`gradle_java8_compile_test` from about 5 minutes per run to over 30m,
which hits the timeout causing tree failures.


https://ci.chromium.org/ui/p/flutter/builders/luci.flutter.prod/Linux%20gradle_java8_compile_test
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: ash2moon
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {matanlurey}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
This commit checks if there have been any changes to the gradle files
and if gradle lock files need updating. If so, it will alert then PR
owner to update their PR with the new gradle lock file.s

Fixes https://github.com/flutter/flutter/issues/163228

Example test run:
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8712427303492230593/+/u/run_gradle_java8_compile_test/stdout?format=raw

This was added as an existing test under Linux gradle_java8_compile_test
because benchmarking results showed on average about 3min 30s to run on
my local M2 Mac. SInce it is not > 10min to run, placing it inside an
existing test case was ideal.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
 2025-06-17 23:59:28 +00:00
gaaclarke
b1af493964
Started bridging the scene delegate to the lifecycle delegate for shortcuts (#170180) 
testing: There integration tests in the plugins repo.
fixes: https://github.com/flutter/flutter/issues/169928

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-06-17 22:57:31 +00:00
Jonah Williams
85824038d0
[ui] npot display_list allocation. (#170447) 
Split off of https://github.com/flutter/flutter/pull/168019/

Worst case allocation performance for dl is fairly bad as we end up
copying the data many more times than something like an STL vector
would. At the cost of more memory usage, we can improve the case where
the display list grows quite large.
 2025-06-17 22:06:32 +00:00
Kevin Moore
55f5aed6e4
Prefer .of over .from (#170750) 
Often faster in cases where the types match

There SHOULD be a lint: https://github.com/dart-lang/sdk/issues/58359
 2025-06-17 18:37:11 +00:00
chunhtai
19428451b3
Fix RawGestureDetector semantics (#170549) 
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->

fixes https://github.com/flutter/flutter/issues/170348

The root cause is the RawGestureDetector doesn't call individual ontap
method with correct position. A previous refactor to cupertinoButton
remove the onTap, but instead using the individual tap method to
register the click and surfaced this issue

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-06-17 18:15:55 +00:00
Runar Heggset
a0c8bd4c3a
Use correct type for filterIdentifier (#170343) 
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->

After upgrading to v3.32.2 from v3.29.2 I encountered this issue while
building our app with `flutter build apk --split-per-abi`

```
FAILURE: Build failed with an exception.

* Where:
Build file '/<redacted>/android/build.gradle' line: 13

* What went wrong:
A problem occurred evaluating root project 'android'.
> A problem occurred configuring project ':app'.
   > java.lang.NullPointerException: output.getFilter(com.and…antOutput.FilterType.ABI) must not be null

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.
> Get more help at https://help.gradle.org.

BUILD FAILED in 1s
```

This seems to be caused by enabling universalApk and splits at the same
time. Here's a snippet from our `build.gradle`:

```
android {
    ...

    splits {
        abi {
            enable true
            reset()
            include 'arm64-v8a', 'armeabi-v7a', "x86_64"
            universalApk true
        }
    }

    buildTypes {
        release {
            signingConfig signingConfigs.release
            ndk {
                abiFilters 'arm64-v8a', 'armeabi-v7a', 'x86_64'
            }
        }
    }
}
```

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-06-17 18:12:18 +00:00
Matan Lurey
e496ad5ea7
Remove and inline license_header.txt (#170475) 
Towards https://github.com/flutter/flutter/issues/169780.
 2025-06-17 18:06:55 +00:00
ash2moon
22dc6b6566
add run_gradle_lock_files_check.dart for new PR's that modify gradle files (#169245) 
This commit checks if there have been any changes to the gradle files
and if gradle lock files need updating. If so, it will alert then PR
owner to update their PR with the new gradle lock file.s

Fixes https://github.com/flutter/flutter/issues/163228

Example test run:
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8712427303492230593/+/u/run_gradle_java8_compile_test/stdout?format=raw

This was added as an existing test under Linux gradle_java8_compile_test
because benchmarking results showed on average about 3min 30s to run on
my local M2 Mac. SInce it is not > 10min to run, placing it inside an
existing test case was ideal.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-06-17 17:25:14 +00:00
engine-flutter-autoroll
eaad9f44e2
Roll Dart SDK from 4fad61257b29 to b32559bca3cc (3 revisions) (#170746) 
https://dart.googlesource.com/sdk.git/+log/4fad61257b29..b32559bca3cc

2025-06-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-241.0.dev
2025-06-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-240.0.dev
2025-06-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-239.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-06-17 17:21:26 +00:00
Kevin Chisholm
2d5987027d
[release] Sync stable changelog to master (#170691) 
Introduce an action that is triggered when there is a push to
CHANGELOG.md on the stable branch, signifying that a release was
conducted, then update CHANGELOG.md on master to reflect these changes.
 2025-06-17 15:59:21 +00:00
engine-flutter-autoroll
d9c64f4d29
Roll Packages from 03a6abbedabb to 25d4fa425508 (5 revisions) (#170743) 
03a6abbeda...25d4fa4255

2025-06-17 22373191+Hari-07@users.noreply.github.com
[google_maps_flutter] Add a new zIndexInt param to marker and deprecate
zIndex (flutter/packages#8012)
2025-06-17 33691143+JesseRiemens@users.noreply.github.com [pigeon] Use a
const for custom type ids for gobject generated files (#156100)
(flutter/packages#9306)
2025-06-16 22373191+Hari-07@users.noreply.github.com
[google_maps_flutter_platform_(web/android/ios)] Add a new zIndexInt
param to marker and deprecate zIndex (flutter/packages#9408)
2025-06-16 jorgesarpe@gmail.com [camera_avfoundation] fix race condition
when starting image stream on iOS (flutter/packages#8733)
2025-06-16 engine-flutter-autoroll@skia.org Roll Flutter from
f79452e3f4ea to 8303a96a0a99 (21 revisions) (flutter/packages#9433)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-06-17 15:48:07 +00:00