engine-flutter-autoroll
6aaa387f2e
Roll Flutter Engine from 090c33aeae83 to c40b0b602822 (1 revision) ( #157896 )
...
090c33aeae...c40b0b6028chris@bracken.jp iOS: Eliminate strong retain loop in Scenario tests (flutter/engine#56249 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-31 02:29:54 +00:00
engine-flutter-autoroll
b0e84af3dc
Roll Flutter Engine from 9295eeb6d3ce to 090c33aeae83 (4 revisions) ( #157893 )
...
9295eeb6d3...090c33aeaeskia-flutter-autoroll@skia.org Roll Skia from 85b77db25fa3 to 3c62d4a94d78 (1 revision) (flutter/engine#56248 )
2024-10-30 skia-flutter-autoroll@skia.org Roll Dart SDK from 4566845d8e30 to 6a8058eef22c (1 revision) (flutter/engine#56246 )
2024-10-30 skia-flutter-autoroll@skia.org Roll Skia from f334411b0a08 to 85b77db25fa3 (5 revisions) (flutter/engine#56245 )
2024-10-30 matanlurey@users.noreply.github.com Add and use `mergeGnArgs` with `--gn-args` from `et`. (flutter/engine#56228 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-31 01:30:25 +00:00
engine-flutter-autoroll
939fd61bb0
Roll Flutter Engine from 2bd854e23b61 to 9295eeb6d3ce (5 revisions) ( #157882 )
...
2bd854e23b...9295eeb6d3skia-flutter-autoroll@skia.org Roll Skia from 77779dfed911 to f334411b0a08 (1 revision) (flutter/engine#56243 )
2024-10-30 jonahwilliams@google.com [engine] add back opt out for merged thread mode. (flutter/engine#56242 )
2024-10-30 jason-simmons@users.noreply.github.com [Impeller] Remove the use of a subpixel minimum stroke size for MSAA (flutter/engine#56223 )
2024-10-30 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from zuDYsDZHnJMZVvrc8... to dDWvmfG4AxSEs0BQA... (flutter/engine#56241 )
2024-10-30 skia-flutter-autoroll@skia.org Roll Dart SDK from 36aed3607108 to 4566845d8e30 (1 revision) (flutter/engine#56240 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from zuDYsDZHnJMZ to dDWvmfG4AxSE
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-30 22:49:15 +00:00
LouiseHsu
ec04707feb
Adds a new helpful tool exit message for SocketExceptions thrown during mdns discovery ( #157638 )
...
Addresses https://github.com/flutter/flutter/issues/150131 , but doesn't fix it, as there seem to be cases where the steps included in the messages added in this PR don't work.
2024-10-30 21:20:25 +00:00
miechoo
2d2ebbe263
Fix GlowingOverscrollIndicator examples ( #155203 )
...
Part of https://github.com/flutter/flutter/issues/130459
This pull request adds tests for the example files shown in the [GlowingOverscrollIndicator](https://api.flutter.dev/flutter/widgets/GlowingOverscrollIndicator-class.html ) Flutter API reference documentation.
2024-10-30 20:50:00 +00:00
engine-flutter-autoroll
bb08ec9a03
Roll Flutter Engine from 906a7ad88052 to 2bd854e23b61 (1 revision) ( #157878 )
...
906a7ad880...2bd854e23bskia-flutter-autoroll@skia.org Roll Skia from d022fe64116f to 77779dfed911 (1 revision) (flutter/engine#56239 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-30 20:18:01 +00:00
Gray Mackall
55c026a230
Upgrade templates to AGP 8.7/Gradle 8.10.2 ( #157872 )
...
These are the versions we use in test, as of https://github.com/flutter/flutter/pull/157617 .
Motivated by noticing a warning with the old template version:
```
This Android Gradle plugin (8.1.0) was tested up to compileSdk = 33 (and compileSdkPreview = "UpsideDownCakePrivacySandbox").
You are strongly encouraged to update your project to use a newer
Android Gradle plugin that has been tested with compileSdk = 35.
```
2024-10-30 18:54:06 +00:00
engine-flutter-autoroll
cb7861cc5f
Roll Flutter Engine from 57ed5d338e7e to 906a7ad88052 (13 revisions) ( #157875 )
...
57ed5d338e...906a7ad880skia-flutter-autoroll@skia.org Roll Skia from 03600bc22ab8 to d022fe64116f (1 revision) (flutter/engine#56237 )
2024-10-30 skia-flutter-autoroll@skia.org Roll Skia from 948b01e28f48 to 03600bc22ab8 (1 revision) (flutter/engine#56236 )
2024-10-30 skia-flutter-autoroll@skia.org Roll Dart SDK from b319b2e53bfa to 36aed3607108 (2 revisions) (flutter/engine#56235 )
2024-10-30 skia-flutter-autoroll@skia.org Roll Skia from 1a47627e627a to 948b01e28f48 (1 revision) (flutter/engine#56231 )
2024-10-30 skia-flutter-autoroll@skia.org Roll Skia from 5410f1c6f86c to 1a47627e627a (1 revision) (flutter/engine#56230 )
2024-10-30 skia-flutter-autoroll@skia.org Roll Dart SDK from 70eca740f23f to b319b2e53bfa (1 revision) (flutter/engine#56229 )
2024-10-30 chris@bracken.jp iOS: make unopt debug builds unopt and debug (flutter/engine#56226 )
2024-10-30 skia-flutter-autoroll@skia.org Roll Skia from 7385b2d99fe9 to 5410f1c6f86c (1 revision) (flutter/engine#56227 )
2024-10-30 skia-flutter-autoroll@skia.org Roll Dart SDK from fcc2bc69db3e to 70eca740f23f (2 revisions) (flutter/engine#56225 )
2024-10-30 skia-flutter-autoroll@skia.org Roll Skia from 6e0c0a255166 to 7385b2d99fe9 (5 revisions) (flutter/engine#56222 )
2024-10-29 aam@google.com Roll buildroot to 3f1a1f0. (flutter/engine#56214 )
2024-10-29 ditman@gmail.com [web] Prioritize split font fallbacks over monolythic ones. (flutter/engine#56187 )
2024-10-29 skia-flutter-autoroll@skia.org Roll Skia from 5758d9c344e3 to 6e0c0a255166 (3 revisions) (flutter/engine#56215 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-30 18:42:07 +00:00
Taha Tesser
b8dcb0c3c5
Update Material 3 LinearProgressIndicator for new visual style ( #154817 )
...
Related to [Update both `ProgressIndicator` for Material 3 redesign](https://github.com/flutter/flutter/issues/141340 )
### Code sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() => runApp(const MyApp());
class MyApp extends StatefulWidget {
const MyApp({super.key});
@override
State<MyApp> createState() => _MyAppState();
}
class _MyAppState extends State<MyApp> {
bool isRTL = false;
@override
Widget build(BuildContext context) {
return MaterialApp(
debugShowCheckedModeBanner: false,
home: Scaffold(
body: Directionality(
textDirection: isRTL ? TextDirection.rtl : TextDirection.ltr,
child: Center(
child: Column(
spacing: 2.0,
mainAxisAlignment: MainAxisAlignment.center,
children: <Widget>[
const Text('Default LinearProgressIndicator'),
const Padding(
padding: EdgeInsets.all(16.0),
child: LinearProgressIndicator(
value: 0.45,
),
),
const Text('Default indefinite LinearProgressIndicator'),
const Padding(
padding: EdgeInsets.all(16.0),
child: LinearProgressIndicator(),
),
const Text('Updated height and border radius'),
Padding(
padding: const EdgeInsets.all(16.0),
child: LinearProgressIndicator(
value: 0.25,
minHeight: 16.0,
borderRadius: BorderRadius.circular(16.0),
),
),
const Text('Updated stop indicator color and radius'),
Padding(
padding: const EdgeInsets.all(16.0),
child: LinearProgressIndicator(
value: 0.74,
minHeight: 16.0,
borderRadius: BorderRadius.circular(16.0),
stopIndicatorColor: Theme.of(context).colorScheme.error,
stopIndicatorRadius: 32.0,
),
),
const Text('Track gap and stop indicator radius set to 0'),
Padding(
padding: const EdgeInsets.all(16.0),
child: LinearProgressIndicator(
value: 0.50,
minHeight: 16.0,
borderRadius: BorderRadius.circular(16.0),
trackGap: 0,
stopIndicatorRadius: 0,
),
),
],
),
),
),
floatingActionButton: FloatingActionButton.extended(
onPressed: () {
setState(() {
isRTL = !isRTL;
});
},
label: const Text('Toggle Direction'),
),
),
);
}
}
```
</details>
### Preview
<img width="824" alt="Screenshot 2024-09-09 at 13 53 10" src="https://github.com/user-attachments/assets/d12e56a5-f196-4011-8266-c7ab96be96b2 ">
2024-10-30 18:14:11 +00:00
engine-flutter-autoroll
cf4a4b8162
Roll Flutter Engine from 999797a2f690 to 57ed5d338e7e (5 revisions) ( #157833 )
...
999797a2f6...57ed5d338ebdero@google.com [Flutter GPU] Fix MSAA sample size and HostBuffer alignment. (flutter/engine#56218 )
2024-10-29 flar@google.com Change default TileMode for blur ImageFilter objects to null (flutter/engine#55552 )
2024-10-29 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Reland: disable AHBs on devices that were upgraded to 29. (#56213 )" (flutter/engine#56220 )
2024-10-29 30870216+gaaclarke@users.noreply.github.com Made et compilation errors relative to the CWD (flutter/engine#56177 )
2024-10-29 jonahwilliams@google.com [Impeller] Reland: disable AHBs on devices that were upgraded to 29. (flutter/engine#56213 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-30 17:24:08 +00:00
Matan Lurey
e6c9fce313
Add hidden --no-implicit-pubspec-resolution flag for one stable release. ( #157635 )
...
Closes https://github.com/flutter/flutter/issues/157532 .
Work towards https://github.com/flutter/flutter/issues/157819 .
Because this flag is checked in `FlutterCommand.verifyAndRun`, it seemed cleaner to just make it a global flag - particularly because this flag's longevity is unlikely to be longer than a single stable release.
2024-10-30 17:00:32 +00:00
engine-flutter-autoroll
e10d1dee5d
Roll Packages from 028027e6b1f1 to 7cc1caa0cc36 (5 revisions) ( #157864 )
...
028027e6b1...7cc1caa0ccstuartmorgan@google.com [tool] Update build-all app creation (flutter/packages#7955 )
2024-10-30 srawlins@google.com Disable two lint rules which are being removed. (flutter/packages#7959 )
2024-10-29 matanlurey@users.noreply.github.com Bump `path_provider_android` to `^2.2.5` due to Android v1 embedder. (flutter/packages#7935 )
2024-10-29 engine-flutter-autoroll@skia.org Roll Flutter from 3fb95c7dd21d to 42132e879b42 (19 revisions) (flutter/packages#7958 )
2024-10-29 stuartmorgan@google.com [webview_flutter] Fix macOS 14+ test hangs (flutter/packages#7953 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-30 15:55:07 +00:00
stuartmorgan
d3723857de
Mention partial PRs in the contributing docs ( #157863 )
...
Adds a small new subsection to the section on contributing via coding that highlights the list of issues with partial patches that could be picked up by another contributor.
2024-10-30 15:23:21 +00:00
Reid Baker
fe71cadf19
Update CHANGELOG.md to correct ios vs macos issue ( #157822 )
2024-10-30 14:07:28 +00:00
Taha Tesser
40c22749f5
Add ability to customize the default Slider padding ( #156143 )
...
Fixes [Ability to change Sliders padding](https://github.com/flutter/flutter/issues/40098 )
Add ability to override default padding so the Slider can fit better in a layout.
### Code sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() => runApp(const MyApp());
class MyApp extends StatefulWidget {
const MyApp({super.key});
@override
State<MyApp> createState() => _MyAppState();
}
class _MyAppState extends State<MyApp> {
double _sliderValue = 0.5;
@override
Widget build(BuildContext context) {
return MaterialApp(
debugShowCheckedModeBanner: false,
theme: ThemeData(
sliderTheme: const SliderThemeData(
padding: EdgeInsets.symmetric(vertical: 4.0),
thumbColor: Colors.red,
inactiveTrackColor: Colors.amber,
),
),
home: Scaffold(
body: Directionality(
textDirection: TextDirection.ltr,
child: Center(
child: Card(
shape: const RoundedRectangleBorder(
borderRadius: BorderRadius.all(Radius.circular(4.0)),
),
color: Theme.of(context).colorScheme.surfaceContainerHighest,
margin: const EdgeInsets.symmetric(horizontal: 16.0),
child: Padding(
padding: const EdgeInsets.all(16.0),
child: Column(
mainAxisSize: MainAxisSize.min,
children: [
const Placeholder(fallbackHeight: 100.0),
Slider(
value: _sliderValue,
onChanged: (double value) {
setState(() {
_sliderValue = value;
});
},
),
const Placeholder(fallbackHeight: 100.0),
],
),
),
),
),
),
),
);
}
}
```
</details>
### Before
(Cannot adjust default `Slider` padding to fill the horizontal space in a `Column` and reduce the padded height)
<img width="717" alt="Screenshot 2024-10-03 at 15 45 18" src="https://github.com/user-attachments/assets/e9d9a4d1-3087-45b4-8607-b94411e2bd23 ">
### After
Can adjust default `Slider` padding via `SliderTheme`)
<img width="717" alt="Screenshot 2024-10-03 at 15 46 25" src="https://github.com/user-attachments/assets/cd455881-6d52-46cb-8ac6-cc33f50a13ff ">
2024-10-30 10:16:23 +00:00
YeungKC
ec50578982
Fix menu anchor state handling ( #157612 )
...
This commit refactors the `_MenuAnchorState` class in `menu_anchor.dart` to include a check for the mounted state and the scheduler phase before calling `setState()`. This ensures that UI updates are only performed when the widget is still mounted and not during the persistent callbacks phase. Additionally, a new test case is added in `menu_anchor_test.dart` to verify that the `isOpen` state of the `MenuAnchor` widget is updated correctly when the button is pressed.
Fix : #157606
*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*
*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2024-10-30 09:42:00 +00:00
Valentin Vignal
f9c130abf0
Add test for interactive_viewer.0.dart ( #157773 )
...
Contributes to https://github.com/flutter/flutter/issues/130459
It adds a test for
- `examples/api/lib/widgets/interactive_viewer/interactive_viewer.0.dart`
2024-10-30 05:46:24 +00:00
Valentin Vignal
1ec1c59d47
Add test for scroll_metrics_notification.0.dart ( #157768 )
...
Contributes to https://github.com/flutter/flutter/issues/130459
It adds a test for
- `examples/api/lib/widgets/scroll_position/scroll_metrics_notification.0.dart`
2024-10-30 05:46:21 +00:00
yim
c051b69e2a
Add boundary feature to the drag gesture. ( #147521 )
...
Inspired by the review on #146182 .
This PR adds boundary feature to the drag gestures, including `MultiDragGestureRecognizer` and `DragGestureRecognizer`. The `GestureDetector` widget will also benefit from this.
2024-10-30 03:01:18 +00:00
Nate Wilson
7ee7fff210
Fix ResizeImage documentation ( #157619 )
...
Whoever reviewed the documentation changes in #154212 neglected to double-check that the information was accurate (it was me who did this).
Fixes #136508
2024-10-30 00:46:11 +00:00
engine-flutter-autoroll
47318592d1
Roll Flutter Engine from 795b5492f1b9 to 999797a2f690 (1 revision) ( #157825 )
...
795b5492f1...999797a2f6jonahwilliams@google.com [Impeller] disable Adreno 506. (flutter/engine#56210 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-29 23:01:25 +00:00
Jenn Magder
7c27a05a54
Avoid labeling all PRs as 'text-input' ( #157805 )
...
After https://github.com/flutter/flutter/pull/157650 all PRs are being labeled as text-input by the PR labeler. I think the config is missing an `all` based on the [negation example](https://github.com/actions/labeler/blob/main/README.md#basic-examples )
2024-10-29 22:49:17 +00:00
engine-flutter-autoroll
8b7d0c3b22
Roll Packages from e0c4f55cd355 to 028027e6b1f1 (8 revisions) ( #157813 )
...
e0c4f55cd3...028027e6b1stuartmorgan@google.com [various] Remove multiDexEnabled (flutter/packages#7956 )
2024-10-28 engine-flutter-autoroll@skia.org Roll Flutter from 5a11904383d1 to 3fb95c7dd21d (16 revisions) (flutter/packages#7948 )
2024-10-28 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Adds internal wrapper for iOS native `IMACompanionAdSlot` and `IMACompanionDelegate` (flutter/packages#7889 )
2024-10-27 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 4.2.1 to 4.2.2 (flutter/packages#7919 )
2024-10-26 engine-flutter-autoroll@skia.org Roll Flutter from 4faa4a415ec9 to 5a11904383d1 (67 revisions) (flutter/packages#7937 )
2024-10-25 kevmoo@users.noreply.github.com Drop deprecated web library (flutter/packages#7926 )
2024-10-25 127771428+ahmedbilal008@users.noreply.github.com [video_player_web] Don't modify volume when muting video (flutter/packages#7845 )
2024-10-25 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 2663184aa790 to 603104015dd6 (3 revisions) (flutter/packages#7930 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-29 21:20:08 +00:00
engine-flutter-autoroll
3ed40f003a
Roll Flutter Engine from 725c8e4bc379 to 795b5492f1b9 (5 revisions) ( #157820 )
...
725c8e4bc3...795b5492f1#56202 )" (flutter/engine#56212 )
2024-10-29 aam@google.com Remove --time run of gen_snapshot. (flutter/engine#56204 )
2024-10-29 jason-simmons@users.noreply.github.com [Impeller] Clip the DrawImageRect source rect to the bounds of the image (flutter/engine#56183 )
2024-10-29 jonahwilliams@google.com [Impeller] disable Maleoon GPU from using Vulkan. (flutter/engine#56203 )
2024-10-29 jonahwilliams@google.com [Impeller] disable AHBs on devices that were upgraded to 29. (flutter/engine#56202 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-29 19:45:22 +00:00
Matan Lurey
1068d31382
Fix and remove a few no-shuffle tags in flutter_tools. ( #157656 )
...
Two of the tests, `test_test` and `break_on_framework_exceptions`, no longer appear to leak (without changes). Perhaps underlying infrastructure has changed, or some other bug in the tool itself was fixed in meantime.
`packages_test` required resetting `Cache.flutterRoot`.
Work towards https://github.com/flutter/flutter/issues/85160 .
2024-10-29 19:01:54 +00:00
Gray Mackall
42132e879b
Reland "Upgrade tests to AGP 8.7/Gradle 8.10.2/Kotlin 1.8.10" ( #157617 )
...
Reland of https://github.com/flutter/flutter/pull/157032 .
Failed tests for initial land:
https://flutter-dashboard.appspot.com/#/build?hashFilter=5ca6350a06fdae8d3e160f9adbece193f34d0302&repo=flutter&branch=master
These two tests run the same `flavors_test`
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux_pixel_7pro%20flavors_test/4579/overview
https://ci.chromium.org/ui/p/flutter/builders/prod/Windows_mokey%20flavors_test_win/988/overview
which is now passing
https://ci.chromium.org/ui/p/flutter/builders/try/Linux_pixel_7pro%20flavors_test/37/overview
(fixed by 23c62df1dchttps://ci.chromium.org/ui/p/flutter/builders/prod/Linux_pixel_7pro%20new_gallery_impeller_old_zoom__transition_perf/4902/overview
https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20tool_integration_tests_2_5/1247/overview
the first is a timeout, the second passed in presubmit on the original PR and also on this PR.
2024-10-29 18:01:19 +00:00
Jonah Williams
8fc6dc2aa6
[impeller] re-enable impeller shard. ( #157806 )
...
This is fixed now
2024-10-29 17:53:35 +00:00
engine-flutter-autoroll
af60541f4d
Roll Flutter Engine from 4cb4478016b5 to 725c8e4bc379 (1 revision) ( #157808 )
...
4cb4478016...725c8e4bc3skia-flutter-autoroll@skia.org Roll Skia from 6d8a5ebeb76c to 5758d9c344e3 (7 revisions) (flutter/engine#56201 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-29 17:53:33 +00:00
auto-submit[bot]
64e0f6a57b
Reverts "Avoid labeling 'context' PRs as 'text-input' ( #157650 )" ( #157812 )
...
Reverts: flutter/flutter#157650
Initiated by: jmagman
Reason for reverting: this made the labeler go crazy and put it on everything that didn't contain "context".
Original PR Author: jmagman
Reviewed By: {christopherfujino}
This change reverts the following previous change:
https://github.com/flutter/flutter/pull/157646 is being labeled by the PR labeler as "text-input" because it edited "con**text**_runner.dart".
```
##[debug] "**/*text*" pattern matched packages/flutter_tools/lib/src/context_runner.dart
```
https://github.com/flutter/flutter/actions/runs/11526508378/job/32090756495?pr=157646#step:2:134
Exclude the common "context" word from this label rule.
See negation example at https://github.com/actions/labeler/blob/main/README.md#basic-examples .
2024-10-29 17:22:18 +00:00
engine-flutter-autoroll
ebc80f0164
Roll Flutter Engine from b95da8106b98 to 4cb4478016b5 (1 revision) ( #157792 )
...
b95da8106b...4cb4478016skia-flutter-autoroll@skia.org Roll Dart SDK from 52af705f878b to fcc2bc69db3e (1 revision) (flutter/engine#56199 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-29 15:51:26 +00:00
Koji Wakamiya
94c537192f
Remove unused import from kt plugin template ( #157220 )
...
Remove import as `@NonNull` is no longer used by https://github.com/flutter/flutter/pull/129472 .
<img width="480" alt="code" src="https://github.com/user-attachments/assets/de45b396-995a-459f-8f36-f738d16cc229 ">
2024-10-29 15:42:20 +00:00
engine-flutter-autoroll
f935e53587
Roll Flutter Engine from 5fa7a123b14a to b95da8106b98 (1 revision) ( #157787 )
...
5fa7a123b1...b95da8106bskia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from RXUZ9eDc7cS4NpKoh... to zuDYsDZHnJMZVvrc8... (flutter/engine#56197 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from RXUZ9eDc7cS4 to zuDYsDZHnJMZ
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-29 13:36:17 +00:00
Taha Tesser
97596e5895
Fix TabBar tab icons not respecting custom IconTheme ( #157724 )
...
Fixes [TabBar ignores Theme's iconTheme.size](https://github.com/flutter/flutter/issues/155518 )
### Description
When `ThemeData.IconTheme` with color and size, is provided, it can override the default `Tab` icon color and size.
### Code sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() {
runApp(const MyApp());
}
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
theme: ThemeData(
iconTheme: const IconThemeData(color: Colors.amber, size: 40),
),
home: const Scaffold(
body: SafeArea(
child: DefaultTabController(
length: 2,
child: Column(
children: [
TabBar(
tabs: [
Tab(icon: Icon(Icons.backpack_outlined), text: 'Backpack'),
Tab(icon: Icon(Icons.map_outlined), text: 'Map'),
],
overlayColor: WidgetStatePropertyAll(Colors.transparent),
),
Expanded(
child: TabBarView(
children: [
Icon(Icons.backpack_outlined),
Icon(Icons.map_outlined),
],
),
),
],
),
),
),
),
);
}
}
```
</details>
---
<img width="666" alt="Screenshot 2024-10-28 at 16 25 06" src="https://github.com/user-attachments/assets/56d31115-7ee9-4378-9811-75a3a2a4ce0f ">
<img width="666" alt="Screenshot 2024-10-28 at 16 24 52" src="https://github.com/user-attachments/assets/ab8a3e4b-e912-40ac-b249-6358492581e0 ">
2024-10-29 10:51:38 +00:00
engine-flutter-autoroll
03c405a43f
Roll Flutter Engine from 0c8f0bf4d740 to 5fa7a123b14a (1 revision) ( #157780 )
...
0c8f0bf4d7...5fa7a123b1skia-flutter-autoroll@skia.org Roll Dart SDK from 6e55dfe77483 to 52af705f878b (2 revisions) (flutter/engine#56195 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-29 10:37:25 +00:00
aniq
c83cf967cf
Allow customizing entry mode icons in TimePicker ( #157151 )
...
This PR adds two new properties to the Material Design `TimePicker`: `switchToInputEntryModeIcon` and `switchToTimerEntryModeIcon`. These allow developers to customize the icons for toggling between dial and input modes, with default icons (`Icons.keyboard_outlined` and `Icons.access_time`) used if none are provided.
Fixes #156942
2024-10-29 10:25:20 +00:00
Valentin Vignal
2de487308a
Add test for focus_scope.0.dart ( #157772 )
...
Contributes to https://github.com/flutter/flutter/issues/130459
It adds a test for
- `examples/api/lib/widgets/focus_scope/focus_scope.0.dart`
2024-10-29 09:02:01 +00:00
Valentin Vignal
55fa5ae07f
Add test for page_storage.0.dart ( #157770 )
...
Contributes to https://github.com/flutter/flutter/issues/130459
It adds a test for
- `examples/api/lib/widgets/page_storage/page_storage.0.dart`
2024-10-29 09:01:59 +00:00
engine-flutter-autoroll
662bac8f37
Roll Flutter Engine from c05af6f939fc to 0c8f0bf4d740 (1 revision) ( #157774 )
...
c05af6f939...0c8f0bf4d7flutter/engine#56192 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-29 08:02:39 +00:00
engine-flutter-autoroll
4a8e2f983f
Roll Flutter Engine from b394e0c98fa0 to c05af6f939fc (1 revision) ( #157767 )
...
b394e0c98f...c05af6f939skia-flutter-autoroll@skia.org Roll Skia from bdd225968dab to 6d8a5ebeb76c (3 revisions) (flutter/engine#56185 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-29 03:06:38 +00:00
Valentin Vignal
88d992042c
Add test for nested_scroll_view_state.0.dart ( #157714 )
...
Contributes to https://github.com/flutter/flutter/issues/130459
It adds a test for
- `examples/api/lib/widgets/nested_scroll_view/nested_scroll_view_state.0.dart`
2024-10-29 02:40:41 +00:00
Zachary Anderson
1ab3c57ea4
Pin Mac tool_integration_test shards to arm64 ( #157760 )
...
Using `Mac_arm64` would require these to go through a `bringup: true`
dance, which would require not running in presubmit. Instead, this PR
just adds the `cpu` property to pin to `arm64` without changing the task
name.
Towards https://github.com/flutter/flutter/issues/157758
2024-10-28 19:32:32 -07:00
engine-flutter-autoroll
749c2368d2
Roll Flutter Engine from ed587dcf61fd to b394e0c98fa0 (4 revisions) ( #157766 )
...
ed587dcf61...b394e0c98fskia-flutter-autoroll@skia.org Roll Dart SDK from c9180e9de9e8 to 6e55dfe77483 (1 revision) (flutter/engine#56184 )
2024-10-28 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Deduplicate golden test file names (flutter/engine#56143 )
2024-10-28 bdero@google.com [Flutter GPU] Replace HostBuffer with Dart version. (flutter/engine#56054 )
2024-10-28 jonahwilliams@google.com [Impeller] add basic Impeller+Vulkan support to embedder API. (flutter/engine#55490 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-29 02:00:24 +00:00
engine-flutter-autoroll
6f9a476cd3
Roll Flutter Engine from 70671baabbba to ed587dcf61fd (10 revisions) ( #157751 )
...
70671baabb...ed587dcf61skia-flutter-autoroll@skia.org Roll Dart SDK from 69b50768d733 to c9180e9de9e8 (1 revision) (flutter/engine#56180 )
2024-10-28 jonahwilliams@google.com [Impeller] fix initial layout for loadOp load and incorrect usage of host visible textures. (flutter/engine#56148 )
2024-10-28 skia-flutter-autoroll@skia.org Roll Skia from 21035cd95b68 to bdd225968dab (1 revision) (flutter/engine#56178 )
2024-10-28 chris@bracken.jp iOS/macOS: migrate darwin/common to ARC (flutter/engine#56155 )
2024-10-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Pin local_engine mac builds to arm64 (#56172 )" (flutter/engine#56179 )
2024-10-28 chris@bracken.jp Migrate PlatformViewIOS to ARC (flutter/engine#55672 )
2024-10-28 skia-flutter-autoroll@skia.org Roll Skia from 35ad4e89212f to 21035cd95b68 (1 revision) (flutter/engine#56176 )
2024-10-28 aam@google.com Roll buildroot to pick up revert of debugging gen_snapshot prints (flutter/engine#56175 )
2024-10-28 zanderso@users.noreply.github.com Pin local_engine mac builds to arm64 (flutter/engine#56172 )
2024-10-28 zanderso@users.noreply.github.com Switch some mac_unopt tests from intel to arm hosts (flutter/engine#55882 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-28 22:08:56 +00:00
engine-flutter-autoroll
8990ed6538
Roll Flutter Engine from 23b2c6d3b3b1 to 70671baabbba (1 revision) ( #157740 )
...
23b2c6d3b3...70671baabbskia-flutter-autoroll@skia.org Roll Skia from f08fbc465888 to 35ad4e89212f (1 revision) (flutter/engine#56171 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-28 19:22:05 +00:00
engine-flutter-autoroll
3fb95c7dd2
Roll Flutter Engine from bf5bfeebf89f to 23b2c6d3b3b1 (3 revisions) ( #157736 )
...
bf5bfeebf8...23b2c6d3b3jonahwilliams@google.com [Impeller] dont increment shared_ptr when tracked object is already tracked. (flutter/engine#56153 )
2024-10-28 skia-flutter-autoroll@skia.org Roll Dart SDK from a75848f92210 to 69b50768d733 (2 revisions) (flutter/engine#56168 )
2024-10-28 skia-flutter-autoroll@skia.org Roll Skia from 263c3e2ecd30 to f08fbc465888 (1 revision) (flutter/engine#56170 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-28 18:18:07 +00:00
Jenn Magder
4a4664946b
Avoid labeling 'context' PRs as 'text-input' ( #157650 )
...
https://github.com/flutter/flutter/pull/157646 is being labeled by the PR labeler as "text-input" because it edited "con**text**_runner.dart".
```
##[debug] "**/*text*" pattern matched packages/flutter_tools/lib/src/context_runner.dart
```
https://github.com/flutter/flutter/actions/runs/11526508378/job/32090756495?pr=157646#step:2:134
Exclude the common "context" word from this label rule.
See negation example at https://github.com/actions/labeler/blob/main/README.md#basic-examples .
2024-10-28 17:34:56 +00:00
Valentin Vignal
ab256e5caf
Add test for restorable_route_future.0.dart ( #157708 )
...
Contributes to https://github.com/flutter/flutter/issues/130459
It adds a test for
- `examples/api/lib/widgets/navigator/restorable_route_future.0.dart`
2024-10-28 17:02:07 +00:00
Reid Baker
bac39a3899
Update .ci.yaml have android sdk be 35v1 ( #157621 )
...
Bump the android sdk to 35v1 to see if doing so helps android 35 emulator stability.
2024-10-28 16:01:23 +00:00
engine-flutter-autoroll
a1587bdf2f
Roll Flutter Engine from 2522789c4199 to bf5bfeebf89f (1 revision) ( #157713 )
...
2522789c41...bf5bfeebf8skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from VJIEKDIuzhhloCBro... to RXUZ9eDc7cS4NpKoh... (flutter/engine#56166 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from VJIEKDIuzhhl to RXUZ9eDc7cS4
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-28 12:21:32 +00:00
Valentin Vignal
e6e820d776
Add test for restoration_mixin.0.dart ( #157709 )
...
Contributes to https://github.com/flutter/flutter/issues/130459
It adds a test for
- `examples/api/lib/widgets/restoration/restoration_mixin.0.dart`
2024-10-28 11:37:15 +00:00
