skia-flutter-autoroll
69a4bbf5dd
Roll ANGLE from fce1e57401bf to 48e2c605adcd (2 revisions) ( flutter/engine#45602 )
...
fce1e57401..48e2c605adsyoussefi@chromium.org More instances of program usage converted to executable
2023-09-09 syoussefi@chromium.org D3D: Remove more usages of program instead of executable
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC flutter-engine@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-09 02:16:04 +00:00
gaaclarke
66cdbc5dc9
Makes Skia's vkQueueSubmit threadsafe. ( flutter/engine#45459 )
...
fixes https://github.com/flutter/flutter/issues/133933
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-09-09 00:52:53 +00:00
skia-flutter-autoroll
7d13ac2ae3
Roll Fuchsia Linux SDK from KvtLknmg3f23uqWVm... to jYqYNRum5gWGFyoHR... ( flutter/engine#45599 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-09 00:47:02 +00:00
skia-flutter-autoroll
d7e256149e
Roll Skia from 7f1d86d81d41 to e5987e341cfd (1 revision) ( flutter/engine#45597 )
...
https://skia.googlesource.com/skia.git/+log/7f1d86d81d41..e5987e341cfd
2023-09-08 robertphillips@google.com [graphite] Guard removal of entries from the ProxyCache
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-09 00:15:06 +00:00
skia-flutter-autoroll
282fc5fc38
Roll ANGLE from 98b0855b9a71 to fce1e57401bf (3 revisions) ( flutter/engine#45596 )
...
98b0855b9a..fce1e57401cnorthrop@google.com FrameCapture: Skip output dir check if disabled
2023-09-08 geofflang@chromium.org GL: Don't use system info for Android SDK queries.
2023-09-08 cclao@google.com Attempt to fix the MSan failure on chromium bots
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC flutter-engine@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-08 23:24:30 +00:00
skia-flutter-autoroll
1dbfbe05ea
Roll Skia from 1012ef8349ba to 7f1d86d81d41 (1 revision) ( flutter/engine#45594 )
...
https://skia.googlesource.com/skia.git/+log/1012ef8349ba..7f1d86d81d41
2023-09-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll debugger-app-base from 24c6e5d875d2 to f61850f9ca4f
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-08 22:43:10 +00:00
skia-flutter-autoroll
b11ef263d8
Roll ANGLE from 765bca2f810a to 98b0855b9a71 (1 revision) ( flutter/engine#45589 )
...
765bca2f81..98b0855b9apetermcneeley@chromium.org Add drm format ABGR16161616F to linux
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC flutter-engine@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-08 21:04:47 +00:00
skia-flutter-autoroll
4686d2b085
Roll Skia from 4996cc1ef9ba to 1012ef8349ba (1 revision) ( flutter/engine#45588 )
...
https://skia.googlesource.com/skia.git/+log/4996cc1ef9ba..1012ef8349ba
2023-09-08 michaelludwig@google.com Make Device draw functions public, clean up header organization
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-08 20:24:51 +00:00
skia-flutter-autoroll
72f97d26c8
Roll ANGLE from a507f31285b8 to 765bca2f810a (1 revision) ( flutter/engine#45587 )
...
a507f31285..765bca2f81armansito@google.com Add <cstring> include to FastVector.h
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC flutter-engine@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-08 19:32:48 +00:00
skia-flutter-autoroll
6d1efeb382
Roll Skia from 244c9ba5d0d7 to 4996cc1ef9ba (2 revisions) ( flutter/engine#45586 )
...
https://skia.googlesource.com/skia.git/+log/244c9ba5d0d7..4996cc1ef9ba
2023-09-08 armansito@google.com Fix build errors due to SkShadowFlags enum
2023-09-08 michaelludwig@google.com onCreateDevice uses smart pointer
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-08 19:27:03 +00:00
skia-flutter-autoroll
fefb75602e
Roll Skia from 948959b6b53e to 244c9ba5d0d7 (2 revisions) ( flutter/engine#45584 )
...
https://skia.googlesource.com/skia.git/+log/948959b6b53e..244c9ba5d0d7
2023-09-08 bungeman@google.com Fix names of sktext slides
2023-09-08 johnstiles@google.com Remove SPIRVCodeGenerator::isDead.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-08 18:40:26 +00:00
skia-flutter-autoroll
7667eabf24
Roll Skia from 5181fcf6184e to 948959b6b53e (4 revisions) ( flutter/engine#45583 )
...
https://skia.googlesource.com/skia.git/+log/5181fcf6184e..948959b6b53e
2023-09-08 armansito@google.com Revert "Allow lambdas with captures for SkSerialProcs/SkDeserialProcs"
2023-09-08 egdaniel@google.com Add option for clients to set default gpu staging buffer size.
2023-09-08 johnstiles@google.com Re-enable lenient SkSL deserialization for runtime shaders/filters.
2023-09-08 michaelludwig@google.com [skif] Delete deprecated functions from skif::Context
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-08 17:52:48 +00:00
Greg Spencer
528ab0c90b
Remove usage of the Jazzy document formatter for Objective C, in favor of Doxygen. ( flutter/engine#45561 )
...
## Description
This removes references to Jazzy, and removes the `gen_objcdoc.py` script, since that is now handled by `gen_docs.py`
## Related Issues
- https://github.com/flutter/flutter/issues/124833
## Related PRs
- https://github.com/flutter/flutter/pull/134246
2023-09-08 17:45:06 +00:00
skia-flutter-autoroll
ee2ad79a9a
Roll ANGLE from 83030fed595b to a507f31285b8 (1 revision) ( flutter/engine#45582 )
...
83030fed59..a507f31285angle-autoroll@skia-public.iam.gserviceaccount.com Roll VK-GL-CTS from 385ae8bed1f9 to 58e66c9d2857 (11 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC flutter-engine@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-08 17:22:10 +00:00
skia-flutter-autoroll
7ba352a1b0
Roll Skia from 5b1e40fc0548 to 5181fcf6184e (2 revisions) ( flutter/engine#45580 )
...
https://skia.googlesource.com/skia.git/+log/5b1e40fc0548..5181fcf6184e
2023-09-08 kjlubick@google.com Move SkSLDefines to src/sksl/
2023-09-08 jzern@google.com update libwebp to v1.3.1-1-g2af26267
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-08 17:01:53 +00:00
Matan Lurey
4bfc25b688
Document and provide small cleanups to CommandPoolVk. ( flutter/engine#45558 )
...
I was reviewing this code for the first time before implementing
https://github.com/flutter/flutter/issues/133198 .
- Removed unused public method `GetGraphicsCommandPool()`.
- Removed forward references by including the right references [^1].
- Tried to document the contracts of various methods that return invalid
or disconnected objects.
If I made any mistakes, please feel free to point them out as this is
how I'm learning how this stuff works 😄
/cc @jonahwilliams
[^1]: [Avoid using forward declarations where
possible](https://google.github.io/styleguide/cppguide.html#Forward_Declarations ).
Instead, include the headers you need.
2023-09-08 09:23:50 -07:00
skia-flutter-autoroll
24a8550803
Roll Skia from c5e67d222f46 to 5b1e40fc0548 (5 revisions) ( flutter/engine#45578 )
...
https://skia.googlesource.com/skia.git/+log/c5e67d222f46..5b1e40fc0548
2023-09-08 kjlubick@google.com Fold SkShadowFlags into SkShadowUtils
2023-09-08 kjlubick@google.com Allow lambdas with captures for SkSerialProcs/SkDeserialProcs
2023-09-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 540560e729c6 to e599bae15d96
2023-09-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from b821e2b90d25 to d5404cb869d7 (5 revisions)
2023-09-08 michaelludwig@google.com [skif] Remove legacy bounds APIs
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-08 16:16:16 +00:00
skia-flutter-autoroll
5e7c8207e9
Roll ANGLE from 65ec697f4183 to 83030fed595b (1 revision) ( flutter/engine#45577 )
...
65ec697f41..83030fed59romanl@google.com Tests: rename isolated_scripts groups
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC flutter-engine@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-08 15:44:04 +00:00
skia-flutter-autoroll
237988cd1a
Roll Skia from 71e40cc0faf6 to c5e67d222f46 (4 revisions) ( flutter/engine#45576 )
...
https://skia.googlesource.com/skia.git/+log/71e40cc0faf6..c5e67d222f46
2023-09-08 robertphillips@google.com Remove deprecated SkImage::makeWithFilter call
2023-09-08 aaclarke@google.com Added ability to decode indexed PNG files that are in wide gamut color spaces to the BGR101010_XR pixel format.
2023-09-08 aaclarke@google.com Implements encoding PNG files from BGR_101010x_XR pixel format.
2023-09-08 blundell@chromium.org [SkImage] Add == and < operators to SkImage::RequiredProperties.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-08 15:27:00 +00:00
Renzo Olivares
31768e6ea4
[Web] Fix insertions/deletions at inverted selection for TextEditingDeltas ( flutter/engine#44693 )
...
Fixes issue where the delta range would be calculated wrong when the selection is inverted.
2023-09-08 14:52:51 +00:00
skia-flutter-autoroll
2a6f4e2e17
Roll Skia from ece9f3a15b08 to 71e40cc0faf6 (1 revision) ( flutter/engine#45575 )
...
https://skia.googlesource.com/skia.git/+log/ece9f3a15b08..71e40cc0faf6
2023-09-08 johnstiles@google.com Remove synthetic assignment to sk_FragColor outside of skslc.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-08 14:21:30 +00:00
skia-flutter-autoroll
ff80a5c88f
Roll Fuchsia Linux SDK from 33DToYd0jNpWX1jNv... to KvtLknmg3f23uqWVm... ( flutter/engine#45573 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-08 11:43:55 +00:00
skia-flutter-autoroll
721af6b263
Roll ANGLE from e60556f75b68 to 65ec697f4183 (1 revision) ( flutter/engine#45572 )
...
e60556f75b..65ec697f41angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 32f9332d1d7a to 9b300a6d6747 (2 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC flutter-engine@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-08 11:40:21 +00:00
William Hesse
5161f30cf7
Add dart2wasm dependency to flutter_frontend_server ( flutter/engine#45570 )
...
The change
https://dart-review.googlesource.com/c/sdk/+/323000 added a dependency on dart2wasm to the frontend_server package.
Flutter engine has all dependencies in its source checkout, and paths to their locations hardcoded in the dependency_ovedrrides of flutter_frontend_server's pubspec.yaml.
Add the dart2wasm package location to pubspec.yaml. Add the transitive dependency wasm_builder package lcoation to pubspec.yaml.
2023-09-08 10:47:22 +00:00
skia-flutter-autoroll
4535011927
Roll Fuchsia Mac SDK from EuBfOtm5TZIdgNaQe... to h_bQLstuirD8blCZW... ( flutter/engine#45571 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-08 09:39:14 +00:00
skia-flutter-autoroll
2b3a00048a
Roll ANGLE from 99d39241ad4d to e60556f75b68 (1 revision) ( flutter/engine#45569 )
...
99d39241ad..e60556f75bangle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 4ae31457f4f5 to 5a5b1cec68d0 (469 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC flutter-engine@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-08 08:29:00 +00:00
Brandon DeRosier
07803f501e
[Impeller] Aiks image filters; allow setting effect transforms after FilterContents instantiation. ( flutter/engine#45530 )
...
These are API improvements on the way to solving
https://github.com/flutter/flutter/issues/131182 .
* Remove `effect_transform` and `is_subpass` from the static
`FilterContents` factories. These are for internal use only.
* Replace `impeller::Paint` filter procs with Aiks `ImageFilter`
factories similar to `ColorFilter`. This gives Aiks a simple interface
for constructing filters and prevents possible state cloning bugs when
copying filters into `EntityPass`.
* Allow for setting filter inputs, setting the effect transform, and
enabling subpass mode on a filter chain after it has been instantiated.
This will allow us to sample coverage in `EntityPass` without rendering
any snapshots using rect filter inputs.
2023-09-07 23:54:45 -07:00
skia-flutter-autoroll
c0a795a6b1
Roll Skia from ce3ec572ae77 to ece9f3a15b08 (1 revision) ( flutter/engine#45568 )
...
https://skia.googlesource.com/skia.git/+log/ce3ec572ae77..ece9f3a15b08
2023-09-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from ab4cd777e0f0 to 540560e729c6 (5 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-08 06:44:18 +00:00
skia-flutter-autoroll
38ef3995f3
Roll Skia from fb4faa8646f8 to ce3ec572ae77 (1 revision) ( flutter/engine#45567 )
...
https://skia.googlesource.com/skia.git/+log/fb4faa8646f8..ce3ec572ae77
2023-09-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 32f9332d1d7a to 9b300a6d6747 (2 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-08 05:26:04 +00:00
skia-flutter-autoroll
e36e138f42
Roll Skia from 658025e9efdd to fb4faa8646f8 (1 revision) ( flutter/engine#45564 )
...
https://skia.googlesource.com/skia.git/+log/658025e9efdd..fb4faa8646f8
2023-09-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 6fb24c81ba91 to b821e2b90d25 (4 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-08 02:46:23 +00:00
skia-flutter-autoroll
cecf6e9706
Roll Skia from 1b8a25d05c45 to 658025e9efdd (1 revision) ( flutter/engine#45563 )
...
https://skia.googlesource.com/skia.git/+log/1b8a25d05c45..658025e9efdd
2023-09-08 michaelludwig@google.com Pull backing-store modification back to SkBitmapDevice
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-08 02:07:23 +00:00
skia-flutter-autoroll
60585a3577
Roll ANGLE from a412b149d5b1 to 99d39241ad4d (1 revision) ( flutter/engine#45562 )
...
a412b149d5..99d39241adgeofflang@chromium.org Metal: Increase the size of the default uniform block
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC flutter-engine@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-08 00:16:22 +00:00
skia-flutter-autoroll
5f706c9d25
Roll Skia from 17f36a6a101e to 1b8a25d05c45 (2 revisions) ( flutter/engine#45560 )
...
https://skia.googlesource.com/skia.git/+log/17f36a6a101e..1b8a25d05c45
2023-09-07 johnstiles@google.com Implement preliminary SkSL sample mask support.
2023-09-07 armansito@google.com Manually roll Dawn from 59f488872a6e to a97b5b824f6d (27 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-07 23:13:43 +00:00
skia-flutter-autoroll
a4a66ec69b
Roll Fuchsia Linux SDK from N915IZbyx6MSrwwS-... to 33DToYd0jNpWX1jNv... ( flutter/engine#45559 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-07 23:01:22 +00:00
skia-flutter-autoroll
3ac167feb1
Roll Skia from efd438ed1c06 to 17f36a6a101e (2 revisions) ( flutter/engine#45557 )
...
https://skia.googlesource.com/skia.git/+log/efd438ed1c06..17f36a6a101e
2023-09-07 michaelludwig@google.com Flatten clip virtuals in SkDevice
2023-09-07 michaelludwig@google.com Delete unused SkSpecialImages::ImageToColorSpace function
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-07 22:28:03 +00:00
skia-flutter-autoroll
94da399750
Roll ANGLE from cdbc45a9f37e to a412b149d5b1 (2 revisions) ( flutter/engine#45556 )
...
cdbc45a9f3..a412b149d5yuxinhu@google.com Suppress out of bounds on no robust contexts tests
2023-09-07 cclao@google.com Load mUniformLocations using loadVector
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC flutter-engine@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-07 22:00:03 +00:00
skia-flutter-autoroll
95c8bbf137
Roll Skia from ce2c94883cb5 to efd438ed1c06 (2 revisions) ( flutter/engine#45554 )
...
https://skia.googlesource.com/skia.git/+log/ce2c94883cb5..efd438ed1c06
2023-09-07 johnstiles@google.com Implement atomicUint type and intrinsics in WGSL.
2023-09-07 michaelludwig@google.com [skif] Delete legacy CropRect per image filter
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-07 21:43:05 +00:00
skia-flutter-autoroll
a96d916f89
Roll ANGLE from 204c07a56b64 to cdbc45a9f37e (1 revision) ( flutter/engine#45551 )
...
204c07a56b..cdbc45a9f3romanl@google.com Tests: capture_tests: remove ANGLE_FEATURE_OVERRIDES_ENABLED
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC flutter-engine@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-07 21:10:05 +00:00
skia-flutter-autoroll
fdb1349aba
Roll Fuchsia Mac SDK from WbB3tmMXnuwJBAHoi... to EuBfOtm5TZIdgNaQe... ( flutter/engine#45550 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-07 21:02:55 +00:00
skia-flutter-autoroll
3542eb58c5
Roll Skia from ee741e5e8cf3 to ce2c94883cb5 (1 revision) ( flutter/engine#45552 )
...
https://skia.googlesource.com/skia.git/+log/ee741e5e8cf3..ce2c94883cb5
2023-09-07 johnstiles@google.com Enable WGSL in the Dawn Graphite backend.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-07 20:59:36 +00:00
gaaclarke
71f9d88ab9
[Impeller] Started tracking the pool with the command buffer. ( flutter/engine#45298 )
...
issue: https://github.com/flutter/flutter/issues/133506
This fixes one of the issues seen in https://github.com/flutter/flutter/issues/133506 . There were multiple ones though.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-09-07 20:49:00 +00:00
dependabot[bot]
c0085494e8
Bump actions/checkout from 3.6.0 to 4.0.0 ( flutter/engine#45439 )
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 3.6.0 to 4.0.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/checkout/releases ">actions/checkout's releases</a>.</em></p>
<blockquote>
<h2>v4.0.0</h2>
<h2>What's Changed</h2>
<ul>
<li>Update default runtime to node20 by <a href="https://github.com/takost "><code>@âtakost</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1436 ">actions/checkout#1436</a></li>
<li>Support fetching without the --progress option by <a href="https://github.com/simonbaird "><code>@âsimonbaird</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1067 ">actions/checkout#1067</a></li>
<li>Release 4.0.0 by <a href="https://github.com/takost "><code>@âtakost</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1447 ">actions/checkout#1447</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/takost "><code>@âtakost</code></a> made their first contribution in <a href="https://redirect.github.com/actions/checkout/pull/1436 ">actions/checkout#1436</a></li>
<li><a href="https://github.com/simonbaird "><code>@âsimonbaird</code></a> made their first contribution in <a href="https://redirect.github.com/actions/checkout/pull/1067 ">actions/checkout#1067</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/checkout/compare/v3...v4.0.0 ">https://github.com/actions/checkout/compare/v3...v4.0.0 </a></p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/actions/checkout/blob/main/CHANGELOG.md ">actions/checkout's changelog</a>.</em></p>
<blockquote>
<h1>Changelog</h1>
<h2>v4.0.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1067 ">Support fetching without the --progress option</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1436 ">Update to node20</a></li>
</ul>
<h2>v3.6.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1377 ">Fix: Mark test scripts with Bash'isms to be run via Bash</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/579 ">Add option to fetch tags even if fetch-depth > 0</a></li>
</ul>
<h2>v3.5.3</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1196 ">Fix: Checkout fail in self-hosted runners when faulty submodule are checked-in</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1287 ">Fix typos found by codespell</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1369 ">Add support for sparse checkouts</a></li>
</ul>
<h2>v3.5.2</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1289 ">Fix api endpoint for GHES</a></li>
</ul>
<h2>v3.5.1</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1246 ">Fix slow checkout on Windows</a></li>
</ul>
<h2>v3.5.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1237 ">Add new public key for known_hosts</a></li>
</ul>
<h2>v3.4.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1209 ">Upgrade codeql actions to v2</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1210 ">Upgrade dependencies</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1225 ">Upgrade <code>@âactions/io</code></a></li>
</ul>
<h2>v3.3.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1045 ">Implement branch list using callbacks from exec function</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1050 ">Add in explicit reference to private checkout options</a></li>
<li>[Fix comment typos (that got added in <a href="https://redirect.github.com/actions/checkout/issues/770 ">#770</a>)](<a href="https://redirect.github.com/actions/checkout/pull/1057 ">actions/checkout#1057</a>)</li>
</ul>
<h2>v3.2.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/942 ">Add GitHub Action to perform release</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/967 ">Fix status badge</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1002 ">Replace datadog/squid with ubuntu/squid Docker image</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/964 ">Wrap pipeline commands for submoduleForeach in quotes</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1029 ">Update <code>@âactions/io</code> to 1.1.2</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1039 ">Upgrading version to 3.2.0</a></li>
</ul>
<h2>v3.1.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/939 ">Use <code>@âactions/core</code> <code>saveState</code> and <code>getState</code></a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/922 ">Add <code>github-server-url</code> input</a></li>
</ul>
<h2>v3.0.2</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/770 ">Add input <code>set-safe-directory</code></a></li>
</ul>
<h2>v3.0.1</h2>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="3df4ab11ebhttps://redirect.github.com/actions/checkout/issues/1447 ">#1447</a>)</li>
<li><a href="8b5e8b7687https://redirect.github.com/actions/checkout/issues/1067 ">#1067</a>)</li>
<li><a href="97a652b800https://redirect.github.com/actions/checkout/issues/1436 ">#1436</a>)</li>
<li>See full diff in <a href="f43a0e5ff2...3df4ab11ebhttps://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/checkout&package-manager=github_actions&previous-version=3.6.0&new-version=4.0.0 )](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2023-09-07 20:35:44 +00:00
hellohuanlin
4d9074ec8b
Reverts part of "fix auto-correction highlight on top left corner (Again)" ( flutter/engine#45523 )
...
This reverts part of https://github.com/flutter/engine/pull/44779 . Verified this to be the regression for https://github.com/flutter/flutter/issues/133908 .
This pair of `textWill/DidChange` calls was added in Beta 1, in order to fix highlight region missing last character (more details [here](https://docs.google.com/document/d/1sM3HMv-SQin39yX1aPUU7vtGv7Hcef1Quc3QhRXBl6A/edit?resourcekey=0-SFYD8vmOIkXiXCZvB1Wlcw#heading=h.ddlvu2i2epyl )).
However, that fix doesn't work anymore for Beta 7 - it turns out that in Beta 7, the system doesn't rely on the `selectionRects` to determine the highlight region anymore. Instead, the system relies on `firstRectForRange` API. So we fixed the system highlight in `firstRectForRange` in Beta 7.
So even after reverting this change, the system highlight still works correctly in Beta 7. I was initially leaning towards keeping these calls even after Beta 7, because without it, the `selectionRects` are still out of sync with iOS text input system. (more details [here](https://docs.google.com/document/d/1sM3HMv-SQin39yX1aPUU7vtGv7Hcef1Quc3QhRXBl6A/edit?resourcekey=0-SFYD8vmOIkXiXCZvB1Wlcw )).
However, I was able to verify that it is indeed `textWill/DidChange` that introduced the regression for IME inputs (It's unclear why they are related, so need further investigation).
In summary, after this revert, system highlights are still in the right place, and with the right length.
*List which issues are fixed by this PR. You must list at least one issue.*
Fixes https://github.com/flutter/flutter/issues/133908
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-09-07 20:11:07 +00:00
skia-flutter-autoroll
da15308108
Roll Skia from 59a2610cd83d to ee741e5e8cf3 (4 revisions) ( flutter/engine#45548 )
...
https://skia.googlesource.com/skia.git/+log/59a2610cd83d..ee741e5e8cf3
2023-09-07 michaelludwig@google.com Revert "Add epsilon to texture effect clamping at pixel centers"
2023-09-07 johnstiles@google.com Ignore 'writeonly' modifier on WGSL storage buffers.
2023-09-07 johnstiles@google.com Enable compute tests in WGSL.
2023-09-07 johnstiles@google.com Add support for stage-input builtins in compute shaders.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-07 20:11:06 +00:00
skia-flutter-autoroll
8692d6fade
Roll ANGLE from 60b56591dee5 to 204c07a56b64 (7 revisions) ( flutter/engine#45546 )
...
60b56591de..204c07a56bcclao@google.com Initialize bitfield using constructor
2023-09-07 mark@lunarg.com Capture/Replay: Trim inactive Texture resources
2023-09-07 syoussefi@chromium.org Revert "Verify shader link correctness after looking up in program cache"
2023-09-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from e89c33139c50 to 4ae31457f4f5 (1177 revisions)
2023-09-07 syoussefi@chromium.org GL: Use the executable instead of program
2023-09-07 cclao@google.com Load ShaderInterfaceVariableInfoMap data members with readStruct
2023-09-07 cclao@google.com Vulkan: Separate out XFB data from ShaderInterfaceVariableInfo
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC flutter-engine@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-07 19:52:18 +00:00
skia-flutter-autoroll
9ed31989f7
Roll Skia from c3d6534b0ac3 to 59a2610cd83d (1 revision) ( flutter/engine#45545 )
...
https://skia.googlesource.com/skia.git/+log/c3d6534b0ac3..59a2610cd83d
2023-09-07 michaelludwig@google.com Add epsilon to texture effect clamping at pixel centers
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-07 19:22:17 +00:00
Brandon DeRosier
642d25e4bc
Update impeller-cmake-example ( flutter/engine#45526 )
...
Fix breakages detected in CI.
2023-09-07 11:53:05 -07:00
Matan Lurey
e7e938cdb5
[Impeller] Document and slightly refactor ResourceManagerVK & friends. ( flutter/engine#45474 )
...
@chinmaygarde specifically, let me know if I violated any correctness you were looking for, or if you would prefer I _don't_ make 1 or more of the changes I made here.
@gaaclarke would love your input on C++ style specifically, or anything that stands out in general.
---
## Summary
I plan to use the resource strategy in https://github.com/flutter/flutter/issues/133198 , but wanted to understand the code better first, so this is my contribution to make it a bit easier to understand (hopefully! push back if not!) and contribute tests.
1. Renamed `Reset(ResourceType)` to `Swap()` for consistency with the std smart pointers.
2. Moved non-trivial work out of the constructor into `::Create` ([style guide](https://google.github.io/styleguide/cppguide.html#Doing_Work_in_Constructors )).
3. Added some `FML_DCHECK`s to private APIs to enforce correctness.
4. Made classes final and methods private where they were effectively that ([style guide](https://google.github.io/styleguide/cppguide.html#Inheritance )).
5. Added tests to make sure I understood the contracts.
2023-09-07 18:32:11 +00:00
Emircan Uysaler
929a86d3fc
[fuchsia] Restructure Flatland vsync loop ( flutter/engine#45531 )
...
This CL restructures Flatland vsync loop to fire for each vsync instead
of each OnNextFrameBegin. As shown in the traces attached to the bug,
the current implementation of firing callbacks on each OnNextFrameBegin
causes skips when Flutter has longer draw calls. By scheduling frames in
between, we are increasing the chance of sending one before the latch
point. OnNextFrameBegin is now used to keep track of present credits and
future presentation times as well as when to start frame, replacing the
need for max_frames_in_flight and vsync_offset fields.
Bug: b/296272449
2023-09-07 14:14:46 -04:00
skia-flutter-autoroll
271e74a743
Roll Skia from 16df0c27bc0e to c3d6534b0ac3 (3 revisions) ( flutter/engine#45543 )
...
https://skia.googlesource.com/skia.git/+log/16df0c27bc0e..c3d6534b0ac3
2023-09-07 kjlubick@google.com Remove unused file SkOrderedReadBuffer.h
2023-09-07 michaelludwig@google.com Rename SkBaseDevice to SkDevice
2023-09-07 bungeman@google.com [paragraph] Minor cleanup
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-07 17:52:42 +00:00
