Hixie
68c57fb67f
Require giving a GlobalKey to UniqueComponent
...
Having UniqueComponent automatically generate its own key is a trap. If
anyone ever creates a UniqueComponent in a build function (rather than
ahead of time) and forgets to pass a key, then that entire subtree is
going to be rebuilt, including layout, every time it's updated. Since
there's basically no way for us to catch this, we should at least force
the author to see the explicit "new GlobalKey()" call in their code.
2015-09-28 11:53:03 -07:00
Ian Hickson
eb6f2f069e
Update gestures.md
...
Replace the old proposal with a placeholder for a description of the actual implementation.
2015-09-28 09:11:59 -07:00
Adam Barth
20fb026cc4
Merge pull request #1369 from abarth/notify_global_key_listeners
...
Actually notify GlobalKey listeners in fn3
2015-09-27 22:04:15 -07:00
Adam Barth
9752979e99
Actually notify GlobalKey listeners in fn3
...
This patch makes a number of changes:
1) buildDirtyComponents now prevents all calls to setState, not just those
higher in the tree. This change is necessary for consistency with
MixedViewport and HomogeneousViewport because those widgets already build
subwidgets with that restriction. If the "normal" build didn't enforce that
rule, then some widgets would break when put inside a mixed or homogeneous
viewport.
2) We now notify global key listeners in a microtask after beginFrame. That
means setState is legal in these callbacks and that we'll produce another
frame if someone calls setState in such a callback.
2015-09-27 17:22:48 -07:00
Adam Barth
ef2c86864b
Merge pull request #1370 from abarth/nit
...
Address review comments from @hixie
2015-09-26 21:08:59 -07:00
Adam Barth
db3923a017
Address review comments from @hixie
2015-09-26 20:18:16 -07:00
Adam Barth
31585045ea
Merge pull request #1367 from abarth/update_navigation_example
...
Update navigation example
2015-09-26 18:39:33 -07:00
Adam Barth
dd4d4f30c1
Merge pull request #1368 from abarth/fn3_address_book
...
Fn3 address book
2015-09-26 14:24:31 -07:00
Adam Barth
88b797bf1c
Port hello_world to fn3
2015-09-26 13:18:20 -07:00
Adam Barth
f005958b72
Port address_book to fn3
2015-09-26 13:16:33 -07:00
Adam Barth
16706a94ae
Update navigation example after Navigator changes
...
Now this example uses the App widget to drive the adventure game.
2015-09-26 13:07:46 -07:00
Adam Barth
43349f82f6
Fix analyzer warnings
2015-09-26 13:07:31 -07:00
Adam Barth
7a6b22e622
Add missing export
2015-09-26 13:07:21 -07:00
Adam Barth
5c3a0cb4ba
Merge pull request #1366 from abarth/fn3_mine_digger
...
Port MineDigger to fn3
2015-09-26 13:06:57 -07:00
Adam Barth
adaa06f7d8
Add missing .gitignore file
2015-09-26 12:54:17 -07:00
Adam Barth
4a13cf5d1f
Port MineDigger to fn3
2015-09-26 12:53:14 -07:00
Adam Barth
1a332aef01
Merge pull request #1365 from abarth/renames
...
Rename Sky to Flutter in a few more places
2015-09-26 12:49:00 -07:00
Adam Barth
198f23cb53
Rename Sky to Flutter in a few more places
2015-09-26 12:46:03 -07:00
Ian Hickson
4112922564
Merge pull request #1363 from Hixie/stocks
...
Port stocks to fn3 and introduce an App component.
2015-09-25 21:22:41 -07:00
Hixie
d8ef78edcf
Port stocks to fn3 and introduce an App component.
2015-09-25 17:52:33 -07:00
Adam Barth
497f0c1fa2
Merge pull request #1362 from abarth/mimic
...
Add Mimic to fn3
2015-09-25 16:44:09 -07:00
Adam Barth
c6e10010ca
Add Mimic to fn3
2015-09-25 16:43:22 -07:00
Adam Barth
f67e7879b9
Fix indent
2015-09-25 15:43:03 -07:00
Adam Barth
b69c6ceb7d
Merge pull request #1360 from abarth/fn3_unique_component
...
Add UniqueComponent helper for creating components with unique states
2015-09-25 15:37:23 -07:00
Adam Barth
ea7522c0d5
Add UniqueComponent helper for creating components with unique states
2015-09-25 15:36:25 -07:00
Adam Barth
4ce42f6c7b
Merge pull request #1359 from abarth/fn3_onscroll
...
Add an onScroll callback to Scrollable
2015-09-25 15:08:45 -07:00
Adam Barth
c5042aff8a
Add an onScroll callback to Scrollable
2015-09-25 15:08:22 -07:00
Ian Hickson
601251bbca
Merge pull request #1357 from Hixie/mixed
...
fn3: Port Card Collection demo
2015-09-25 14:50:51 -07:00
Chinmay Garde
b2de4bed44
Merge pull request #1356 from chinmaygarde/master
...
Update Dart revision
2015-09-25 14:49:37 -07:00
Hixie
0abd6f2b9c
fn3: Port Card Collection demo
...
Also:
- Make Dismissable report when it starts squashing, since otherwise we
don't invalidate the list early enough and it gets mad that it wasn't
told one of its children had changed size.
- Have Dismissable check that it gets removed after it's dismissed, to
avoid having lots of redundant widgets around.
- Start tracking the height of each child of a MixedViewport, so that we
don't accumulate floating point errors when a child jiggles up and down.
- Have _childOffsets reuse its storage space rather than newing up a new
copy each time we reset the cache.
- Avoid double-updating child sizes when handling mixed viewport invalidations.
2015-09-25 14:44:54 -07:00
Chinmay Garde
82ce491db3
Update Dart revision
2015-09-25 14:28:39 -07:00
Adam Barth
b07509159c
Merge pull request #1355 from abarth/current_state
...
Add a currentWidget and currentState accessor to GlobalKeys
2015-09-25 14:22:39 -07:00
Adam Barth
1f4e6df48f
Add a currentWidget and currentState accessor to GlobalKeys
2015-09-25 14:22:22 -07:00
Adam Barth
58e887a404
Merge pull request #1354 from abarth/fn3_ensure_widgets_is_visible
...
Add ensureWidgetIsVisible to fn3
2015-09-25 14:21:27 -07:00
Adam Barth
b753a37b9e
Add ensureWidgetIsVisible to fn3
2015-09-25 14:21:12 -07:00
Viktor Lidholt
367935b777
Merge pull request #1351 from vlidholt/master
...
Renames pointQuickDist in GameMath
2015-09-25 13:50:48 -07:00
Hans Muller
f5f8e7bcf7
Merge pull request #1353 from HansMuller/bump_newton_version
...
Bumped Newton version to 0.1.4
2015-09-25 13:45:44 -07:00
Adam Barth
7431ecfd45
Merge pull request #1350 from abarth/localToGlobal
...
Add findRenderObject to BuildContext
2015-09-25 13:40:12 -07:00
Adam Barth
4fc3eb0f7a
Add findRenderObject to BuildContext
2015-09-25 13:37:14 -07:00
Hans Muller
f21b54b224
Bumped Newton version to 0.1.4
2015-09-25 13:32:37 -07:00
Viktor Lidholt
05f31c7259
Renames pointQuickDist in GameMath
2015-09-25 13:12:01 -07:00
Adam Barth
2ab987bbf1
Rev pub package
2015-09-25 12:04:25 -07:00
Adam Barth
c8eee081b9
Rev pub spec
2015-09-25 12:02:09 -07:00
Adam Barth
d947f53571
Merge pull request #1346 from abarth/fn3_sync_tests
...
Port some more tests to fn3
2015-09-25 11:58:12 -07:00
Adam Barth
f54c8ea077
Merge d8ea1b194b446f555402770acd8ac6b217becb7c to fn3
2015-09-25 11:57:30 -07:00
Adam Barth
5e43280ec6
Port some more tests to fn3
2015-09-25 11:27:48 -07:00
Andrew Wilson
8669d118d0
Merge pull request #1342 from apwilson/fling
...
Add fling to Scrollable.
2015-09-25 11:18:53 -07:00
Andrew Wilson
d8ea1b194b
Add fling to Scrollable.
2015-09-25 11:15:24 -07:00
Adam Barth
2272c89e21
Merge pull request #1345 from abarth/fn3_more_tests
...
Port some more tests to fn3
2015-09-25 10:56:53 -07:00
Adam Barth
a895c1d693
Port some more tests to fn3
2015-09-25 10:51:56 -07:00
