30207 Commits

Author SHA1 Message Date
skia-flutter-autoroll
6830d49f3d Roll Skia from 2e28fe9de378 to 359d4726e423 (1 revision) (flutter/engine#43906)
https://skia.googlesource.com/skia.git/+log/2e28fe9de378..359d4726e423

2023-07-21 johnstiles@google.com Add `flat` modifier to SSBO index varying.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-21 20:33:19 +00:00
Brandon DeRosier
b5ee961e4f [Impeller] Disable color attachment removal for clips on VK (flutter/engine#43905)
This is causing a validation failure on the Vulkan backend at ToT, as discovered by @jonahwilliams.

Need to figure out why this isn't getting hit in the Vulkan goldens.
2023-07-21 20:17:05 +00:00
Brandon DeRosier
61b006d0ed [Impeller] Add a way to query the gfx backend type. (flutter/engine#43837)
I've been trying to avoid this, but since the context type may vary
through runtime decisions, we just need something like this to select
which shader data to pull from the Dart GPU bundle at runtime. One
alternative would be to add a special omni shader concept to the HAL,
but that seems worse than just letting renderers key with a backend enum
sometimes.

Cautioned against using it for cap checks in the doc string.
2023-07-21 13:11:32 -07:00
skia-flutter-autoroll
abcd4b44bf Roll ANGLE from 82d68c577b1d to 085f25bbb1e3 (1 revision) (flutter/engine#43904)
82d68c577b..085f25bbb1

2023-07-21 geofflang@chromium.org GL: Protect against drivers returning 0 max clip distances.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC bdero@google.com,flutter-engine@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-21 20:05:31 +00:00
skia-flutter-autoroll
0afb48ecb5 Roll ANGLE from 2e190280f5c5 to 82d68c577b1d (1 revision) (flutter/engine#43901)
2e190280f5..82d68c577b

2023-07-21 angle-autoroll@skia-public.iam.gserviceaccount.com Manual roll Chromium from e3bcada48f45 to 986ed21b8935 (1346 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC bdero@google.com,flutter-engine@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-21 19:01:20 +00:00
skia-flutter-autoroll
6bccb3cf4c Roll Skia from 497326dc66cd to 2e28fe9de378 (2 revisions) (flutter/engine#43900)
https://skia.googlesource.com/skia.git/+log/497326dc66cd..2e28fe9de378

2023-07-21 cmumford@google.com [infra] Add debugger_app_container Bazel config
2023-07-21 lovisolo@google.com [bazel] //gm/vias/SimpleVias.cpp: Delete redundant out.data() call.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-21 18:55:19 +00:00
skia-flutter-autoroll
b7b6090762 Roll Skia from 1f84e9d51bba to 497326dc66cd (1 revision) (flutter/engine#43899)
https://skia.googlesource.com/skia.git/+log/1f84e9d51bba..497326dc66cd

2023-07-21 johnstiles@google.com Fix WGSL codegen for intrinsics that might overflow.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-21 17:58:21 +00:00
Chris Yang
eacae26086 Refactor: fix typo "setup" -> "set up" (flutter/engine#43824)
There are several places in the engine using the word "setup" incorrectly. I have changed them to "set up"

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-07-21 17:06:34 +00:00
Jonah Williams
c309bebb03 [engine] disable picture complexity raster caching (flutter/engine#43897)
Test removing picture complexity based raster caching.
2023-07-21 16:42:09 +00:00
skia-flutter-autoroll
8e24b623e8 Roll Skia from e3d13d1b1c42 to 1f84e9d51bba (1 revision) (flutter/engine#43896)
https://skia.googlesource.com/skia.git/+log/e3d13d1b1c42..1f84e9d51bba

2023-07-21 kjlubick@google.com Allow Ganesh Mesh factories to take nullptr ctx

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-21 16:35:47 +00:00
Zachary Anderson
c985c25882 Revert Dart (flutter/engine#43895)
For analyzer failures starting in
https://github.com/flutter/flutter/pull/131050
2023-07-21 09:09:18 -07:00
skia-flutter-autoroll
61d063717c Roll Fuchsia Linux SDK from CWNVmH6f_iryKU05E... to gpjF3QRGg_KH0guW5... (flutter/engine#43894)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-21 15:42:19 +00:00
skia-flutter-autoroll
340b50386e Roll Skia from 8388ec4d242c to e3d13d1b1c42 (1 revision) (flutter/engine#43893)
https://skia.googlesource.com/skia.git/+log/8388ec4d242c..e3d13d1b1c42

2023-07-21 kjlubick@google.com Merge SkGpuBlurUtils into GrBlurUtils

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-21 15:25:02 +00:00
skia-flutter-autoroll
7b6d372112 Roll Dart SDK from 6e79151ce988 to 921613a055ff (1 revision) (flutter/engine#43892)
https://dart.googlesource.com/sdk.git/+log/6e79151ce988..921613a055ff

2023-07-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-336.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-21 14:07:56 +00:00
skia-flutter-autoroll
89ad78b52d Roll Skia from 3dd45617581b to 8388ec4d242c (1 revision) (flutter/engine#43891)
https://skia.googlesource.com/skia.git/+log/3dd45617581b..8388ec4d242c

2023-07-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 13599b120a68 to 7db08a9e0a29 (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-21 14:06:51 +00:00
skia-flutter-autoroll
dcfd643faf Roll ANGLE from b60068009dca to 2e190280f5c5 (2 revisions) (flutter/engine#43890)
b60068009d..2e190280f5

2023-07-21 geofflang@chromium.org GL: Extend disable of EXT_clip_control to Mali-G51.
2023-07-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from e1c3b16d5aa5 to 7db08a9e0a29 (12 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC bdero@google.com,flutter-engine@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-21 13:55:04 +00:00
skia-flutter-autoroll
0d19dda3d4 Roll ANGLE from f2e0f8a0b236 to b60068009dca (1 revision) (flutter/engine#43887)
f2e0f8a0b2..b60068009d

2023-07-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 4e401427f8dd to 4a260c12b8c1 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC bdero@google.com,flutter-engine@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-21 11:45:05 +00:00
skia-flutter-autoroll
56a8802593 Roll Dart SDK from 8662af7d9aa3 to 6e79151ce988 (2 revisions) (flutter/engine#43885)
https://dart.googlesource.com/sdk.git/+log/8662af7d9aa3..6e79151ce988

2023-07-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-335.0.dev
2023-07-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-334.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-21 10:24:53 +00:00
skia-flutter-autoroll
b9aeef2d4b Roll Fuchsia Mac SDK from -SaPL-46jpiYbnCAu... to WH3AaCa4DtVERww1v... (flutter/engine#43884)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-21 08:42:23 +00:00
skia-flutter-autoroll
7ce5d177df Roll Skia from 4857e876d8cf to 3dd45617581b (1 revision) (flutter/engine#43883)
https://skia.googlesource.com/skia.git/+log/4857e876d8cf..3dd45617581b

2023-07-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 5e38a31bd76a to f2e0f8a0b236 (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-21 07:07:31 +00:00
skia-flutter-autoroll
bf1080e3b0 Roll Skia from 3dce2d4ee4f3 to 4857e876d8cf (1 revision) (flutter/engine#43882)
https://skia.googlesource.com/skia.git/+log/3dce2d4ee4f3..4857e876d8cf

2023-07-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from a1951225a465 to ac6948eb5d9f (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-21 06:28:16 +00:00
skia-flutter-autoroll
7355498f8f Roll Skia from 31b0ed0c0054 to 3dce2d4ee4f3 (1 revision) (flutter/engine#43880)
https://skia.googlesource.com/skia.git/+log/31b0ed0c0054..3dce2d4ee4f3

2023-07-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 4e401427f8dd to 4a260c12b8c1 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-21 05:40:21 +00:00
skia-flutter-autoroll
95beb4c7a2 Roll Skia from bae54bbf49bd to 31b0ed0c0054 (1 revision) (flutter/engine#43879)
https://skia.googlesource.com/skia.git/+log/bae54bbf49bd..31b0ed0c0054

2023-07-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from b698c2aac01c to ac6948eb5d9f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-21 04:57:24 +00:00
skia-flutter-autoroll
77d23fd4f0 Roll Fuchsia Linux SDK from hVAAd2NqYOjUF_I99... to CWNVmH6f_iryKU05E... (flutter/engine#43877)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-21 02:45:36 +00:00
skia-flutter-autoroll
0a24baa004 Roll Dart SDK from 1df95f328d0c to 8662af7d9aa3 (1 revision) (flutter/engine#43876)
https://dart.googlesource.com/sdk.git/+log/1df95f328d0c..8662af7d9aa3

2023-07-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-333.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-21 02:38:21 +00:00
Ian Hickson
69ded94b7b Add a breadcrumb for people who want to run the web tests (flutter/engine#43865) 2023-07-21 02:32:11 +00:00
skia-flutter-autoroll
193c9749fd Roll Skia from 049f389db75b to bae54bbf49bd (2 revisions) (flutter/engine#43875)
https://skia.googlesource.com/skia.git/+log/049f389db75b..bae54bbf49bd

2023-07-21 lovisolo@google.com [bazel] //gm/BazelGMRunner.cpp: Add support for the "picture" via.
2023-07-21 lovisolo@google.com [bazel] //gm/BazelGMRunner.cpp: Add support for the "picture_serialization" via.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-21 02:24:20 +00:00
skia-flutter-autoroll
f558044d9a Roll Skia from 6f2b2e94ebbd to 049f389db75b (1 revision) (flutter/engine#43873)
https://skia.googlesource.com/skia.git/+log/6f2b2e94ebbd..049f389db75b

2023-07-20 kjlubick@google.com Do not register SDFMaskFilter for flattening

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-21 01:04:34 +00:00
Dan Field
193c6260fe [Impeller] [Vulkan] Add reset command buffer bit to command pools. (flutter/engine#43867)
Without this bit, we're holding it wrong. From the docs:

> VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT allows any command buffer allocated from a pool to be individually reset to the initial state; either by calling vkResetCommandBuffer, or via the implicit reset when calling vkBeginCommandBuffer. If this flag is not set on a pool, then vkResetCommandBuffer must not be called for any command buffer allocated from that pool.

This means our reset calls later are getting ignored.

Fixes https://github.com/flutter/flutter/issues/131001
2023-07-20 23:27:13 +00:00
skia-flutter-autoroll
4da623eefc Roll Skia from 981146e6305d to 6f2b2e94ebbd (3 revisions) (flutter/engine#43871)
https://skia.googlesource.com/skia.git/+log/981146e6305d..6f2b2e94ebbd

2023-07-20 aeubanks@google.com Fix newly warned -Wconstant-logical-operand
2023-07-20 johnstiles@google.com Add WGSL support for uniforms inside interface blocks.
2023-07-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from e1c3b16d5aa5 to 13599b120a68 (8 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-20 23:20:04 +00:00
skia-flutter-autoroll
0f60dcbbf0 Roll Skia from 100d0f858f02 to 981146e6305d (3 revisions) (flutter/engine#43866)
https://skia.googlesource.com/skia.git/+log/100d0f858f02..981146e6305d

2023-07-20 jmbetancourt@google.com add typeface setting to SkottieSlide's slot manager interface
2023-07-20 brianosman@google.com Convert recently added GM to unit test
2023-07-20 jvanverth@google.com [graphite] Get Vulkan present working.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-20 21:37:13 +00:00
Jonah Williams
949e91bbba [Impeller] Provide fragment uniform data through varyings for solid color, glyph atlas, texture shaders. (flutter/engine#43838)
From experimentation, providing these values through varyings runs substantially faster on Pixel devices. Alternative solutions to use f16 or push constants did not improve things substantially.

These subset of shaders are used very heavily and so they benefit from this change more substantially. I don't think this is applicable to all shaders as there is going to be an additional varying interpolation cost.

See also: [go/impeller-slow-fragment-shader](http://goto.google.com/impeller-slow-fragment-shader)
2023-07-20 20:47:16 +00:00
skia-flutter-autoroll
a9eb2fe5f3 Roll ANGLE from a4c283be741f to f2e0f8a0b236 (2 revisions) (flutter/engine#43864)
a4c283be74..f2e0f8a0b2

2023-07-20 avi@chromium.org Don't allow ANGLE to be compiled as ARC
2023-07-20 natsu@google.com Vulkan: EGL's DISPLAY_P3_PASSTHROUGH -> VK's DISPLAY_P3_NONLINEAR

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC bdero@google.com,flutter-engine@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-20 20:26:55 +00:00
skia-flutter-autoroll
f4fb229fe4 Roll Skia from 18e834916f47 to 100d0f858f02 (7 revisions) (flutter/engine#43863)
https://skia.googlesource.com/skia.git/+log/18e834916f47..100d0f858f02

2023-07-20 penghuang@chromium.org dawn: remove a annoying spammy log from DawnCaps
2023-07-20 brianosman@google.com Remove reference to (obsolete/deleted) T8888 config
2023-07-20 armansito@google.com [graphite][vello] Adjust rough buffer size reduction
2023-07-20 armansito@google.com [graphite][AtlasShapeRenderStep] Implement boundsOutset
2023-07-20 robertphillips@google.com [graphite] Implement SkImage::textureSize
2023-07-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from 6140cf9c51a5 to 1323db7bd0b4 (2 revisions)
2023-07-20 cmumford@google.com [infra] Reland "Add rule to build final debugger-app image"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-20 20:19:12 +00:00
skia-flutter-autoroll
e7bb3ca55b Roll Fuchsia Mac SDK from SmAtKPfGzPllC9gfO... to -SaPL-46jpiYbnCAu... (flutter/engine#43862)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-20 20:02:11 +00:00
skia-flutter-autoroll
614d825cd6 Roll Skia from a3aca7ae523e to 18e834916f47 (1 revision) (flutter/engine#43860)
https://skia.googlesource.com/skia.git/+log/a3aca7ae523e..18e834916f47

2023-07-20 johnstiles@google.com Fix Overflow test in WGSL codegen.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-20 19:02:23 +00:00
Mouad Debbar
a9896d3b98 Add url to get GoogleFonts API key (flutter/engine#43857) 2023-07-20 18:34:06 +00:00
Dan Field
f28f9ca32c More validation logs for CommandEncoderVK submission (flutter/engine#43859)
Helps while investigating https://github.com/flutter/flutter/issues/131001
2023-07-20 18:29:56 +00:00
skia-flutter-autoroll
ceb3365839 Roll Dart SDK from 857c9a2ae14a to 1df95f328d0c (1 revision) (flutter/engine#43858)
https://dart.googlesource.com/sdk.git/+log/857c9a2ae14a..1df95f328d0c

2023-07-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-332.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-20 18:25:43 +00:00
Mouad Debbar
d205cf6af6 [web] Preserve correct CanvasKit Variant during test initialization (flutter/engine#43854)
At some point, we started setting `useColorEmoji` to true in our tests, but we were doing it in a way that resets all other configurations to their defaults. This caused the `canvasKitVariant` config to be lost and always set to the default `auto`.

This PR fixes the issue and adds tests to:

1. Make sure that the CanvasKit suite always runs with a specific variant (not `auto`).
2. Make sure the given CanvasKit variant makes it all the way through to the tests.

The test harness uses a backdoor (a global JS property on `window`) to communicate which canvaskit variant it's using. The test then compares that with `configuration.canvasKitVariant` to make sure they match. If they don't match, then the configuration was lost somewhere on the way.

Fixes https://github.com/flutter/flutter/issues/130993
2023-07-20 18:06:24 +00:00
skia-flutter-autoroll
102c2eda87 Roll Skia from b8133dda3a8c to a3aca7ae523e (1 revision) (flutter/engine#43855)
https://skia.googlesource.com/skia.git/+log/b8133dda3a8c..a3aca7ae523e

2023-07-20 mike@reedtribe.org Remove unneeded generateAdvance() from SkScalerContext

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-20 17:40:14 +00:00
skia-flutter-autoroll
7ce5bd6366 Roll Skia from 401c85ab1e21 to b8133dda3a8c (4 revisions) (flutter/engine#43853)
https://skia.googlesource.com/skia.git/+log/401c85ab1e21..b8133dda3a8c

2023-07-20 johnstiles@google.com Refactor GetConstantValueOrNullForVariable logic.
2023-07-20 brianosman@google.com Remove kBGR_888x_SkColorType
2023-07-20 johnstiles@google.com Remove inaccurate comment in YUVA pixmaps.
2023-07-20 ramasamy.si@zohocorp.com Fix crash in skparagraph's visit function

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-20 16:22:22 +00:00
skia-flutter-autoroll
e2371670ad Roll Dart SDK from 603aacd8400f to 857c9a2ae14a (1 revision) (flutter/engine#43851)
https://dart.googlesource.com/sdk.git/+log/603aacd8400f..857c9a2ae14a

2023-07-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-331.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-20 14:36:03 +00:00
skia-flutter-autoroll
2ffc866a39 Roll Fuchsia Linux SDK from ZwCUlo28olVzLlqTl... to hVAAd2NqYOjUF_I99... (flutter/engine#43850)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-20 14:01:08 +00:00
skia-flutter-autoroll
2d184793a0 Roll ANGLE from 5e38a31bd76a to a4c283be741f (1 revision) (flutter/engine#43849)
5e38a31bd7..a4c283be74

2023-07-20 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 7f74d379edd8 to e1c3b16d5aa5 (7 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC bdero@google.com,flutter-engine@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-20 11:38:34 +00:00
skia-flutter-autoroll
d6679b38f4 Roll Skia from 65a83c4de7f2 to 401c85ab1e21 (1 revision) (flutter/engine#43848)
https://skia.googlesource.com/skia.git/+log/65a83c4de7f2..401c85ab1e21

2023-07-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from f3c508b81760 to e1c3b16d5aa5 (11 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-20 09:45:05 +00:00
skia-flutter-autoroll
fafb7f302d Roll Skia from d09e9869f84c to 65a83c4de7f2 (2 revisions) (flutter/engine#43847)
https://skia.googlesource.com/skia.git/+log/d09e9869f84c..65a83c4de7f2

2023-07-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from b32d661389a6 to 5e38a31bd76a (5 revisions)
2023-07-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from a1951225a465 to b698c2aac01c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-20 08:03:41 +00:00
skia-flutter-autoroll
664b0f50f8 Roll Fuchsia Mac SDK from 7kGBjmX-zBXcg1svE... to SmAtKPfGzPllC9gfO... (flutter/engine#43845)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-20 07:23:20 +00:00
skia-flutter-autoroll
272e54908f Roll Skia from b238c09fe959 to d09e9869f84c (1 revision) (flutter/engine#43842)
https://skia.googlesource.com/skia.git/+log/b238c09fe959..d09e9869f84c

2023-07-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from c10b5129407a to a1951225a465 (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-20 06:25:22 +00:00
skia-flutter-autoroll
d336742794 Roll Dart SDK from 368a205aa1d4 to 603aacd8400f (1 revision) (flutter/engine#43843)
https://dart.googlesource.com/sdk.git/+log/368a205aa1d4..603aacd8400f

2023-07-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-330.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-20 06:07:21 +00:00