DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
34,074 Commits 882 Branches 1,069 Tags
Commit Graph

34074 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
skia-flutter-autoroll
67db5ec63e Roll Skia from 17d00f9241b3 to a1d9b83034ac (2 revisions) (flutter/engine#50582) 
https://skia.googlesource.com/skia.git/+log/17d00f9241b3..a1d9b83034ac

2024-02-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 8bd678a29dfa to f8dd9bcbe55d (8 revisions)
2024-02-13 armansito@google.com [viewer] Context option and UI toggle for compute MSAAx16

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,johnstiles@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-13 04:38:05 +00:00
skia-flutter-autoroll
b73e1ed01e Roll Fuchsia Linux SDK from RVHAIKU50ogkiV-Lj... to l6mWjvlO1xJg5ZFKK... (flutter/engine#50579) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-13 02:07:14 +00:00
skia-flutter-autoroll
fbab5d3360 Roll Dart SDK from 94f7dec34cef to 8d3a8d85c883 (1 revision) (flutter/engine#50577) 
https://dart.googlesource.com/sdk.git/+log/94f7dec34cef..8d3a8d85c883

2024-02-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-135.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-13 02:03:16 +00:00
Matan Lurey
c4b914c009 Add Impeller runtime options to Android scenario_app (flutter/engine#50487) 
Closes https://github.com/flutter/flutter/issues/143171.

Adds builds for both Impeller Vulkan and Impeller OpenGLES.

_Some of the goldens for Impeller/Vulkan won't look right yet. I'll link
to the blocking issues after CI runs._
 2024-02-12 17:59:19 -08:00
skia-flutter-autoroll
d1efcd938a Roll Skia from c464143dfaab to 17d00f9241b3 (1 revision) (flutter/engine#50576) 
https://skia.googlesource.com/skia.git/+log/c464143dfaab..17d00f9241b3

2024-02-13 armansito@google.com [graphite] Support the MSAA16 mode in VelloRenderer

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,johnstiles@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-13 01:13:38 +00:00
skia-flutter-autoroll
d4bbb25f86 Roll Skia from ecf2f622d0b3 to c464143dfaab (2 revisions) (flutter/engine#50574) 
https://skia.googlesource.com/skia.git/+log/ecf2f622d0b3..c464143dfaab

2024-02-12 armansito@google.com [graphite][vello] Incorporate stroke rework changes
2024-02-12 bungeman@google.com Update sbix slide

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,johnstiles@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-13 00:18:32 +00:00
Jonah Williams
b85e2d9b8d [Impeller] CommandPoolVK recycles command buffers too. (flutter/engine#50468) 
Its a bit ambiguous whether or not resetting a cmd pool returns the cmd buffers resources back to the pool in a way that can be reused on subsequent frames. Since reseting the pool resets the cmd buffers to their initial state, they are safe to reuse once reset. Additionally, through profiling I can observe that there is less allocation in cmd buffer creation when the buffers themselves are recycled, at least on the Mali drivers.

### Before (Animated Advanced Blend Macrobenchmark)

![image](https://github.com/flutter/engine/assets/8975114/c0022d7a-d16e-4db5-862a-01d5a6157e18)

### After

![image](https://github.com/flutter/engine/assets/8975114/3b45f9a9-8811-4fbc-8b90-24338317df6e)
 2024-02-12 23:40:19 +00:00
Matan Lurey
154fa183ad Make dart:ui#Paint final to allow changes/disallow implementing. (flutter/engine#50557) 
Closes https://github.com/flutter/flutter/issues/142937.
 2024-02-12 15:30:32 -08:00
Robert Ancell
51c9fc1c08 Replace usage of an integer for GdkModifierType (flutter/engine#50481) 
The integer is replaced with the enumerated type in GTK4. The
documentation in GTK3 indicates the value is the enumerated type.
 2024-02-13 12:26:46 +13:00
Robert Ancell
08995aae83 Remove FlKeyEvent.dispose_origin and use GdkEvent type for origin (flutter/engine#50483) 
This removes casting. origin was a pointer for testing purposes to be
mocked but the tests make no use of this.
 2024-02-13 12:19:29 +13:00
Zachary Anderson
b2b54c426d Move Linux impeller_unittests to linux_unopt (flutter/engine#50558) 
This PR moves linux impeller_unittests to the correct builder, but does
not yet merge it with the rest of the tests running in a
host_debug_unopt build due to:
https://github.com/flutter/flutter/issues/143330
 2024-02-12 15:00:32 -08:00
Chinmay Garde
6f01f71b03 [Impeller] Don't suppress outdated validation error. (flutter/engine#50568) 
We build our own validation layers. So this should no longer be an issue.
 2024-02-12 22:42:21 +00:00
Chinmay Garde
2416280285 [Impeller] Remove references to moved impeller/image from README. (flutter/engine#50513) 
Moved by @dnfield in https://github.com/flutter/engine/pull/50480
 2024-02-12 22:32:47 +00:00
skia-flutter-autoroll
a3232d6251 Roll Dart SDK from dca13675e65e to 94f7dec34cef (1 revision) (flutter/engine#50567) 
https://dart.googlesource.com/sdk.git/+log/dca13675e65e..94f7dec34cef

2024-02-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-134.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-12 22:14:04 +00:00
skia-flutter-autoroll
d510b5c517 Roll Skia from f88eeb658358 to ecf2f622d0b3 (1 revision) (flutter/engine#50566) 
https://skia.googlesource.com/skia.git/+log/f88eeb658358..ecf2f622d0b3

2024-02-12 scroggo@google.com SkDynamicMemoryWStream::write: allow malloc to fail

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,johnstiles@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-12 22:06:19 +00:00
skia-flutter-autoroll
7a708268c0 Roll Skia from 867c1e8390e2 to f88eeb658358 (5 revisions) (flutter/engine#50564) 
https://skia.googlesource.com/skia.git/+log/867c1e8390e2..f88eeb658358

2024-02-12 michaelludwig@google.com [skif] Make AutoSurface a member type of FilterResult
2024-02-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll debugger-app-base from 3acd3682009f to be5714074b1a
2024-02-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from 67e2da56aec4 to 30062bca1496
2024-02-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll shaders-base from 45ec924a5da0 to b04a5aef564b
2024-02-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll jsfiddle-base from db3abc597412 to 0ccdb32ff1ca

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,johnstiles@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-12 21:11:24 +00:00
Jason Simmons
fb48b918b9 Roll vulkan-deps to 014f44e134a1de387791bffacc32ff9d8db71176 (flutter/engine#50515) 
Fixes https://github.com/flutter/flutter/issues/141277
See https://github.com/flutter/flutter/issues/138117
 2024-02-12 20:22:40 +00:00
skia-flutter-autoroll
84ba9bfb5e Roll Skia from 4081496b7693 to 867c1e8390e2 (20 revisions) (flutter/engine#50562) 
https://skia.googlesource.com/skia.git/+log/4081496b7693..867c1e8390e2

2024-02-12 scroggo@google.com WebpEncoder: respect the return value of write()
2024-02-12 kjlubick@google.com Remove Docker tasks from the CQ
2024-02-12 johnstiles@google.com Manual roll Dawn from 37780d217965 to b10254f79f46 (38 revisions)
2024-02-12 jvanverth@google.com [graphite] Make atlas-related recordUploads() calls have same signature.
2024-02-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from f53f1b6ab28e to 8bd678a29dfa (2 revisions)
2024-02-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 996f56b64f8b to dd80ac99b627
2024-02-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 3ad163d09102 to eaddd3baa5ed (9 revisions)
2024-02-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 536d1c386426 to 996f56b64f8b (5 revisions)
2024-02-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 2e6294aece33 to f53f1b6ab28e (1 revision)
2024-02-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 91655d665673 to 2e6294aece33 (1 revision)
2024-02-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from fe1cbbda7543 to 996f56b64f8b
2024-02-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 6c7bb72d35e0 to 91655d665673 (3 revisions)
2024-02-09 kjlubick@google.com Use old define for gif (for now)
2024-02-09 lovisolo@google.com [bazel] GaneshVulkanSurfaceManager.cpp: Implement.
2024-02-09 jvanverth@google.com [graphite] Stub in SmallPathAtlas.
2024-02-09 lovisolo@google.com [bazel] Move skiatest::TestType from //tests/Test.h to a new //test/TestType.h file.
2024-02-09 kjlubick@google.com Rename Benchmark::Backend::kGPU to Benchmark::Backend::kGanesh
2024-02-09 lovisolo@google.com [bazel] Fix Android build.
2024-02-09 kjlubick@google.com Make sure all uses of SkResources that need codecs register them
2024-02-09 jlavrova@google.com Assure last cluster of Run ends at the end of Run

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,johnstiles@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-12 20:18:27 +00:00
Jonah Williams
73f0041fc8 [Impeller] force render pass construction on all backends to ensure image layout is transitioned/render pass state setup. (flutter/engine#50539) 
Fixes https://github.com/flutter/flutter/issues/142358

We rely on the render pass encoding to transition image textures from undefined to shader read layout. If an empty pass is created with no clear color, we still need to create the pass on the Vulkan backend.
 2024-02-12 19:58:41 +00:00
Loïc Sharma
9c365da297 [Windows] Make the view own its EGL surface (flutter/engine#50421) 
This makes the view own its EGL surface. This will allow us to support multiple EGL surfaces once the engine supports having multiple views.

Some notable changes:

1. EGL surface resizing logic is now entirely in `FlutterWindowsView`. Previously some resizing logic was in the `egl::Manager`, however, the view has to handle resizing failures so this unifies the logic in one place.
2. The `OnEmptyFrameGenerated` and `OnFrameGenerated` now return `false` (aka "don't present") if the surface is invalid. This simplifies the compositor as it no longer needs to check for invalid surfaces
3. This introduces a `ViewModifier` testing helper to allow overriding a view's surface. This isn't strictly necessary, tests can setup a surface by mocking several EGL methods and calling `FlutterWindowsView::CreateRenderSurface()`. However, this is verbose & heavily tied to implementation details. The `ViewModifier` avoids this boilerplate.
4. `CompositorOpenGL`'s initialization now makes the render context current without any render surfaces. Previously it also made the view's surface current, which was unnecessary.

Part of https://github.com/flutter/flutter/issues/137267

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-02-12 18:22:51 +00:00
skia-flutter-autoroll
498e41b9b6 Roll Dart SDK from 5c9e79e66364 to dca13675e65e (1 revision) (flutter/engine#50559) 
https://dart.googlesource.com/sdk.git/+log/5c9e79e66364..dca13675e65e

2024-02-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-133.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-12 18:11:10 +00:00
Miguel
884512b9e4 [fuchsia] Update Inspect library usage (flutter/engine#50467) 
The new Inspect library uses InspectSink as described in
[RFC-168](https://fuchsia.dev/fuchsia-src/contribute/governance/rfcs/0168_exposing_inspect_through_inspectsink?hl=en).

Additionally it's using the new CPP bindings instead of the deprecated
HLCPP bindings.

Bug: https://g-issues.fuchsia.dev/issues/320785253

I've verified on a relevant Fuchsia build that the Flutter runner
continues to correctly publish Inspect after this change.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
 2024-02-12 17:42:16 +00:00
Zachary Anderson
72f4969bfc Initializes RBE in the build config runner (flutter/engine#50543) 
Unlike Goma, the local RBE server must be manually started and stopped
between each `ninja` build.

This PR adds the startup and shutdown before and after `ninja` is run in
the build config runner. It also removes the RBE startup logic from the
`gn` script, which was the wrong place for it since there was no
opportunity for it to shutdown the service. Removing this logic from the
`gn` script will not affect CI since the recipes already do the right
startup and shutdown, and logic in the `gn` script skipped the now
deleted section of code.
 2024-02-12 09:37:37 -08:00
Juanjo Tugores
10c9a2a71a Rename [ViewFocusDirection.backwards] to [ViewFocusDirection.backward] (flutter/engine#50533) 
Rename [ViewFocusDirection.backwards] to [ViewFocusDirection.backward]

Relevant Issues are:

Design doc link: https://github.com/flutter/website/actions/runs/7560898849/job/20588395967
Design doc: https://github.com/flutter/flutter/issues/141711
Focus in web multiview: https://github.com/flutter/flutter/issues/137443
Platform dispatcher changes: https://github.com/flutter/engine/pull/49841

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-02-12 17:24:05 +00:00
Dan Field
2f964dfe37 Refactor NDK helpers some more, add methods for SurfaceControl/Transaction, tests (flutter/engine#50540) 
Adds more dynamic method lookups in service of https://github.com/flutter/flutter/issues/143105

Moves the TU out to FML so that Impeller can more easily use it.

Adds checking on `AHardwareBuffer_getId` so that it checks the return value before returning what is potentially garbage.

Adds some smoke tests to make sure these things actually work/look up meaningful symbols. Test is in the shell because we have testing infra for this kind of thing there.
 2024-02-12 17:12:06 +00:00
gaaclarke
daaedbbe2b [Impeller] deleted the old blur (flutter/engine#50470) 
fixes https://github.com/flutter/flutter/issues/131579


## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-02-12 09:00:06 -08:00
K Lubick
bb9eaca791 Update codec defines for Skia (flutter/engine#50554) 
Skia is coalescing some defines related to codecs in
https://skia-review.googlesource.com/c/skia/+/811816

This will let that change land (hopefully).

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [X] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I signed the [CLA].
- [X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-02-12 11:59:32 -05:00
Zachary Anderson
ac3b11c8c8 Remove host_debug_unopt build from linux_host_engine.json (flutter/engine#50555) 
It wasn't being used for anything on this builder, and the same config was being built below under a different name.
 2024-02-12 16:58:28 +00:00
skia-flutter-autoroll
2392c53fab Roll Dart SDK from efc514815312 to 5c9e79e66364 (1 revision) (flutter/engine#50552) 
https://dart.googlesource.com/sdk.git/+log/efc514815312..5c9e79e66364

2024-02-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-132.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-12 13:37:24 +00:00
skia-flutter-autoroll
614cc479aa Roll Fuchsia Linux SDK from uoByvKUBgYXArsFGL... to RVHAIKU50ogkiV-Lj... (flutter/engine#50546) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-12 01:13:24 +00:00
skia-flutter-autoroll
eb7052ace1 Roll Dart SDK from c64c3d6bae2f to efc514815312 (1 revision) (flutter/engine#50544) 
https://dart.googlesource.com/sdk.git/+log/c64c3d6bae2f..efc514815312

2024-02-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-131.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-11 05:47:23 +00:00
skia-flutter-autoroll
d4d9646461 Roll Fuchsia Linux SDK from H1cNBBNhq0bEpcyPs... to uoByvKUBgYXArsFGL... (flutter/engine#50542) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-11 00:21:07 +00:00
Matan Lurey
748e3f8e0b Remove legacy references to Cirrus and suspected dead-code. (flutter/engine#50442) 2024-02-10 22:08:23 +00:00
skia-flutter-autoroll
a639337620 Roll Dart SDK from 0119704af522 to c64c3d6bae2f (1 revision) (flutter/engine#50538) 
https://dart.googlesource.com/sdk.git/+log/0119704af522..c64c3d6bae2f

2024-02-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-130.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-10 21:22:47 +00:00
skia-flutter-autoroll
7002faf885 Roll Dart SDK from ed5730124fd1 to 0119704af522 (1 revision) (flutter/engine#50527) 
https://dart.googlesource.com/sdk.git/+log/ed5730124fd1..0119704af522

2024-02-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-129.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-10 07:27:32 +00:00
skia-flutter-autoroll
5a7fcdd062 Roll Dart SDK from 10ca8dc7d2b4 to ed5730124fd1 (1 revision) (flutter/engine#50523) 
https://dart.googlesource.com/sdk.git/+log/10ca8dc7d2b4..ed5730124fd1

2024-02-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-128.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-10 03:39:21 +00:00
Zachary Anderson
be53653365 Update build/rbe CIPD hash (flutter/engine#50524) 
Try to fix RBE failures on some builds that are complaining about the wrapper script having the wrong permissions as in:

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8756550755258071729/+/u/collect_rbe_logs/read_reproxy.WARNING/reproxy.WARNING
 2024-02-10 03:37:08 +00:00
Zachary Anderson
5a34bc8fa5 Adds a runner to engine_build_configs (flutter/engine#50342) 
This PR adds an API to the `engine_build_configs` package that executes
an engine build config locally . This API is a building block for an
eventual command line tool to streamline workflows in the engine repo.
In particular, it will allow the command line tool to execute the same
config, build, and test commands that are run on CI.
 2024-02-09 18:42:22 -08:00
Dan Field
b56621e3ae Clean up additional NDK helper related code (flutter/engine#50518) 
Moves more dlsym related code to ndk_helpers.h/cc.
 2024-02-10 01:08:08 +00:00
Juanjo Tugores
7b2766a191 Make the web engine publish view forward focus and unfocus events (flutter/engine#50177) 
Make the flutter web engine publish view focus events.

Relevant Issues are:
* Design doc link: https://github.com/flutter/website/actions/runs/7560898849/job/20588395967
* Design doc: https://github.com/flutter/flutter/issues/141711
* Focus in web multiview: https://github.com/flutter/flutter/issues/137443
* Platform dispatcher changes: https://github.com/flutter/engine/pull/49841

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-02-09 23:30:16 +00:00
skia-flutter-autoroll
0ccccc3e74 Roll Fuchsia Linux SDK from RK2irywND2DKT4l6C... to H1cNBBNhq0bEpcyPs... (flutter/engine#50517) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-09 23:28:00 +00:00
skia-flutter-autoroll
413fb0cb49 Roll Dart SDK from 444f7a422da4 to 10ca8dc7d2b4 (1 revision) (flutter/engine#50516) 
https://dart.googlesource.com/sdk.git/+log/444f7a422da4..10ca8dc7d2b4

2024-02-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-127.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-09 23:20:56 +00:00
Chinmay Garde
ecebcc1704 [Impeller] Add --enable-impeller-vulkan-playgrounds to ./flutter/tools/gn (flutter/engine#50477) 
One has to manually `gn args` to add this flag (usually on macOS) now.
 2024-02-09 22:44:34 +00:00
Jason Simmons
603ed08902 [Impeller] Remove the unused Vulkan queue submit task runner (flutter/engine#50511) 
see https://github.com/flutter/engine/pull/50484
 2024-02-09 22:08:35 +00:00
Zachary Anderson
3874808898 Make .style.yapf and .pylintrc agree on line length (flutter/engine#50510) 
For https://github.com/flutter/flutter/issues/143243

yapf and pylint check different things, but occasionally overlap. I
think we'll just have to make them agree when we catch them fighting.
 2024-02-09 14:07:57 -08:00
Jason Simmons
709f2ece94 [Impeller] Call vkQueuePresentKHR through the ContextVK's synchronized graphics queue wrapper (flutter/engine#50509) 
SwapchainImplVK had been querying the physical device for a queue that supports presentation on the specified surface.  However, the selected queue is typically the same VkQueue instance as the graphics queue provided by ContextVK.

This could cause a thread policy violation where the raster thread is calling vkQueuePresentKHR while the IO thread is calling vkQueueSubmit on the same queue during image decoding.

This PR moves the vkQueuePresentKHR call to the ContextVK's graphics queue wrapper, which serializes access to the VkQueue.
 2024-02-09 21:50:01 +00:00
gaaclarke
f97e1fd131 [Impeller] cleaned up StrokePathGeometry and removed runtime polymorphism (flutter/engine#50506) 
followup to https://github.com/flutter/engine/pull/50379

improvements:
1) Symbols in cc are now in anonymous namespaces
1) The header is smaller (limits recompilation time)
1) Removed runtime polymorphism (faster, yay)

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-02-09 13:06:41 -08:00
David Iglesias
8a8ce3b20f [web] Fix HtmlViewEmbedder.dispose (flutter/engine#50482) 
Fix a `Concurrent modification during iteration` in the `dispose` method of the HtmlViewEmbedder.

### Issues

Fixes https://github.com/flutter/flutter/issues/143193

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-02-09 19:11:48 +00:00
skia-flutter-autoroll
e6f37afc69 Roll Dart SDK from 03130d49f214 to 444f7a422da4 (6 revisions) (flutter/engine#50502) 
https://dart.googlesource.com/sdk.git/+log/03130d49f214..444f7a422da4

2024-02-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-126.0.dev
2024-02-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-125.0.dev
2024-02-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-124.0.dev
2024-02-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-123.0.dev
2024-02-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-122.0.dev
2024-02-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-121.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-09 18:54:09 +00:00
Jonah Williams
7c2fad0219 [Impeller] improve performance of polyline and stroke generation by reducing allocation and lambda usage. (flutter/engine#50379) 
Attempts to reduce the allocation overhead of the stroke geometry generator, while also making it easier to debug and profile. Reverts the change to make PathBuilder::TakePath not move the path data, as this was regressing performance.

* removes dynamic std::vector from cubic to linear component evaluation.
* removes copy from path positions to UVs for texture filled paths
* removes almost all stateful lambdas. Instead there is now a statefull interface that generates the vertices. Stack traces now have useful names.
* Cap/Join procs are now static functions.

Fixes https://github.com/flutter/flutter/issues/142873
 2024-02-09 18:37:21 +00:00