4602 Commits

Author SHA1 Message Date
sergiy-sc
64a8156560 [macos] expose runWithEngine constructor in FlutterViewController
Removing [engine setViewController:self]; because view is not loaded, but in that function controller is saved. Later, when the view is loaded (loadView) passed as an argument controller is checked against the saved controller and since they match, the nil view is not replaced with a new view.

Fixes: flutter/flutter#74735
2022-10-14 09:04:36 -04:00
ColdPaleLight
fc0c9c70f7 Specify correct YUV color space for Darwin YUV external textures (flutter/engine#36709) 2022-10-12 02:52:18 +00:00
LongCatIsLooong
a0c098ec46 [iOS text input] Use the correct coordinate space for firstRectForRange (flutter/engine#36707) 2022-10-11 21:07:22 +00:00
Yegor Pomortsev
7281766810 [fuchsia] Use root-ssl-certificates in v2 runner manifests (flutter/engine#36703)
* Add a `use` for the `root-ssl-certificates` to ensure BoringSSL
  can read the certificates at /config/ssl
* Reformat manifest with `cmc format`

Fixes `HandshakeException`s when establishing a secure connection:

```
HandshakeException: Handshake error in client (OS Error:
        CERTIFICATE_VERIFY_FAILED: unable to get local issuer certificate(handshake.cc:393))
<asynchronous suspension>
```

Depends on changes that offer this directory to the runners,
e.g. https://fxrev.dev/737597

Bug: https://fxbug.dev/111712
2022-10-10 18:46:12 -07:00
Alex Wallen
3cd8b9eaa4 Deprecate single semantics tree assumption from platform dispatcher (flutter/engine#36675) 2022-10-10 18:41:16 +00:00
Erik
9f4d9ff82a Add Dart AOT integration test (flutter/engine#36460) 2022-10-07 22:59:15 +00:00
yaakovschectman
462f506915 Get user's preferred languages from registry (flutter/engine#36536)
* Query preferred languages from registry

* Check registry size

* Line formats

* A space

* Single space

* Update shell/platform/windows/system_utils.cc

Co-authored-by: Chris Bracken <chris@bracken.jp>

* Mockable windows registry

* Mock windows registry in test

* Formatting

* Some more spaces

* Move paths to constants

* Spacing

* Update shell/platform/windows/system_utils.h

Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>

* Move registry keys to const vars

* PR conversation

* 2 spaces

* Import

* Separate functionality

* Linux unopt

* PR suggestions

* Update shell/platform/windows/windows_registry.h

Co-authored-by: Chris Bracken <chris@bracken.jp>

* Update shell/platform/windows/system_utils_unittests.cc

Co-authored-by: Chris Bracken <chris@bracken.jp>

* PR

* PR

* Inject registry in constructor

* Format

Co-authored-by: Chris Bracken <chris@bracken.jp>
Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
2022-10-06 10:32:11 -04:00
Jonah Williams
aadc2d3094 Add ImmutableBuffer.fromFilePath (flutter/engine#36623) 2022-10-05 22:18:03 +00:00
Dan Field
e4d709de85 Avoid using non-UTF-8 encoded argv more often (flutter/engine#36590) 2022-10-05 12:03:20 -07:00
Loïc Sharma
35760d7a3b Revert "[Windows] Move to Visual Studio 2019" (flutter/engine#36606) 2022-10-05 00:13:19 +00:00
Chris Yang
3cd2d3bc82 Workaround iOS text input crash for emoji+Korean text (flutter/engine#36295) 2022-10-04 22:55:50 +00:00
Jenn Magder
ef8d23749a Guard accessibility_bridge UIView access (flutter/engine#36580) 2022-10-04 22:50:02 +00:00
Jenn Magder
058fd02953 Stop compiling iOS with bitcode (flutter/engine#36596) 2022-10-04 21:56:13 +00:00
Loïc Sharma
129f69bc31 [Windows] Move to Visual Studio 2019 (flutter/engine#36538) 2022-10-04 20:00:04 +00:00
Erik
b797d69385 Port over C++ components of the one-flutter test (flutter/engine#36546) 2022-10-03 18:31:03 +00:00
Tong Mu
06bcc278e3 [macOS] Unify FlutterRenderers' presenting callbacks (flutter/engine#36488) 2022-09-30 15:08:43 -07:00
cfontas
b203597bab Add DPR To Flatland Embedder (flutter/engine#36449)
* add dpr field to flatland

* format

* more dpr updates

* add inverse

* fix error

* fix error

* fix formatting

* formatting again

* one more formatting fix

* update metrics

* fix build errors

* formatting

* test

* formatting

* test

* test

* fix typo

* clean up a bit

* format

* fix metrics

* remove line

* fix test

* remove prints

* fix formatting

* update checks

* format
2022-09-30 16:37:14 -04:00
Alexander Biggs
16d5012361 [fuchsia] Add --gtest-filter flag for unit tests. (flutter/engine#36509) 2022-09-29 19:57:05 +00:00
Jonah Williams
463c3d8cba Revert egl presentation time (flutter/engine#36485) 2022-09-28 21:50:13 +00:00
Callum Moffat
582d28921f Fix reversed macOS trackpad rotation (flutter/engine#36444) 2022-09-28 19:52:50 +00:00
Erik
75d2baf5fe Add Dart JIT runner integration test (flutter/engine#36420) 2022-09-27 20:14:16 +00:00
SahilMadan
84766334f6 [flatland] Reduce size of hit-region. (flutter/engine#36447)
Currently, the hit-region is size FLT_MAX which is susceptible to
numerical overflow when rotating or translating (or any other
modification to the value).
2022-09-27 15:21:10 -04:00
Callum Moffat
b92b9bdb6a Add discrete scale pointer signal (flutter/engine#36342) 2022-09-27 15:30:14 +00:00
gaaclarke
e41c775200 Removed instances of unnecessary values (flutter/engine#36221) 2022-09-26 21:28:04 +00:00
Alexander Markov
1dac15b35e Use vm_common set of core libraries in libraries.yaml files (flutter/engine#36414) 2022-09-26 13:04:13 -07:00
Dan Field
63e8e223aa [Impeller] toImageSync for Impeller (flutter/engine#36365) 2022-09-23 20:31:03 +00:00
Nayuta403
4cf8312021 fix typo (flutter/engine#36271) 2022-09-22 22:11:51 +00:00
Matej Knopp
f56c06b371 [macOS] Do not block main thread during resizing if there is no content (flutter/engine#35409)
* [macOS] Do not block main thread during resizing if there is no content

Fixes: https://github.com/flutter/flutter/issues/92673
2022-09-22 22:45:43 +02:00
Joel Winarske
93a55ddeeb Enable cross compile of Linux GTK embedder (flutter/engine#36056) 2022-09-22 13:03:47 -07:00
Ben Bergkamp
4fcf481fb3 [fuchsia] Write trace profiles for v2 components (flutter/engine#36186) 2022-09-22 14:46:38 -05:00
Ben Bergkamp
fcf779e801 [fuchsia] enable dart null safety in fuchsia.dart files (flutter/engine#36303) 2022-09-22 14:41:00 -05:00
Alexander Biggs
6751734343 [fuchsia] Add run_unit_tests.sh script. (flutter/engine#36308)
This is a convenience script for running unit tests locally.

To make this script work, I had to move several test exclusions
from test_suites.yaml (which controls running tests on CQ)
to the tests themselves. I think this is for the best because
it makes running the tests locally with behavior that matches
CQ easier.

Also added fuchsia_tests to build_and_copy_to_fuchsia.sh
so it builds the unit tests .far packages by default.

Tested: Ran `run_unit_tests.sh`, all tests pass. Ran
`build_and_copy_to_fuchsia.sh`, it still builds.
2022-09-21 10:40:20 -07:00
Alexander Biggs
aff2fac56a Revert "Revert "fxbug.dev/94000: Set Opacity and Scale Flatland Values for Flatland Embedder (#36109)" (#36305)" (flutter/engine#36323)
This reverts commit 938b7349cc70fd80b8fe6df053acfa53cfc91ae3.

The tryjob failure is not related to this PR. https://github.com/flutter/flutter/issues/112014
2022-09-21 10:40:06 -07:00
Alexander Biggs
bef70aabc1 [fuchsia] Disable flaking shell test on Fuchsia. (flutter/engine#36320) 2022-09-21 17:28:50 +00:00
Shivesh Ganju
0976e7ab55 [fuchsia][scenic] Call GetViewRef once per view in flatland platform (flutter/engine#36304)
view.

Currently flatland platform view recursively calls GetViewRef to watch
for ViewRef changes. Since re-linking of views will not be supported by
flatland, GetViewRef should be called only once per view.

Test: ffx test run "fuchsia-pkg://fuchsia.com/flutter_runner_tests#meta/flutter_runner_tests.cm"

Bug: https://bugs.fuchsia.dev/p/fuchsia/issues/detail?id=109948
2022-09-21 11:55:24 -04:00
gaaclarke
6b2a14d348 Isolate platform channels for desktop (flutter/engine#35893) 2022-09-20 23:56:04 +00:00
gaaclarke
938b7349cc Revert "fxbug.dev/94000: Set Opacity and Scale Flatland Values for Flatland Embedder (#36109)" (flutter/engine#36305)
This reverts commit b4602ed641e3c8b2651b2b16f0d340a0a6835d35.
2022-09-20 15:55:16 -07:00
cfontas
b4602ed641 fxbug.dev/94000: Set Opacity and Scale Flatland Values for Flatland Embedder (flutter/engine#36109)
This PR makes a few changes to flatland_external_view_embedder as part of fxbug.dev/94000 to enable flatland on smart display.

- Add Opacity

- Add Scale

= Update flatland_external_view_embedder_unittests to verify changes.

Bug: https://fxbug.dev/94000
2022-09-20 15:22:16 -07:00
Shivesh Ganju
f73cf637fd [fuchsia][scenic] Add support for viewConnected and viewDisconnected (flutter/engine#36298)
signals in flatland.

This PR adds support for sending 'View.viewConnected' platform message
when a view gets created and 'View.viewDisconnected' signal when a view
gets destroyed.

Test: ffx test run "fuchsia-pkg://fuchsia.com/flutter_runner_tests#meta/flutter_runner_tests.cm"

Bug: https://bugs.fuchsia.dev/p/fuchsia/issues/detail?id=93452
2022-09-20 17:53:27 -04:00
yaakovschectman
74ec47aa10 Modify assert keyboard condition on Windows to account for violation of invariant (flutter/engine#36129)
* Skip assert on critical keys

* Comment motivation

* Update shell/platform/windows/keyboard_key_embedder_handler.cc

Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>

* Unit test keyboard change

* Format

* Ditto

* Update shell/platform/windows/keyboard_unittests.cc

Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>

* Update shell/platform/windows/keyboard_key_embedder_handler.cc

Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>

* Discard repeat keyup messages

* Initial

* Post synchronization

* Explain assertion

* Reassess pressing records

* Formatting

* Update shell/platform/windows/keyboard_key_embedder_handler.cc

Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>

* One space

* Update shell/platform/windows/keyboard_key_embedder_handler.cc

Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>

* Comment spacing

Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
2022-09-20 17:00:55 -04:00
Jia Hao
2e404ea083 Fix inverted setSystemUIChangeCallback (flutter/engine#36248) 2022-09-20 15:37:11 +00:00
Chris Yang
885e9a081a Clear platform view caches at begin frame in unittest (flutter/engine#36214) 2022-09-19 18:33:09 +00:00
Loïc Sharma
422d88f217 [A11y] Fix ReorderableListView crash on desktop (flutter/engine#36160) 2022-09-17 01:27:47 +00:00
Jia Hao
c858509095 Mention the need to rebuild before running tests (flutter/engine#36191) 2022-09-16 23:59:05 +00:00
Jason Simmons
a4543ccec9 Use a linker script to export only the required symbols in the Linux embedder library (flutter/engine#36187) 2022-09-16 22:09:09 +00:00
Jason Simmons
89369a1402 Fix flakiness in ShellTest.PushBackdropFilterToVisitedPlatformViews (flutter/engine#36212) 2022-09-16 19:39:54 +00:00
Callum Moffat
0a5737e441 Properly throw Dart error from PluginUtilities.getCallbackHandle FFI (flutter/engine#36032) 2022-09-16 17:11:08 +00:00
Jia Hao
abbff8407e Reland "Avoid vsync scheduling delay" (flutter/engine#36197) 2022-09-16 15:41:39 +00:00
yaakovschectman
ef3bc43183 Communicate switch status to semantics on Windows (flutter/engine#36177)
* Switch semantics

* Test native role
2022-09-15 18:02:12 -04:00
Ben Bergkamp
c3db8d1dc8 Enable dart null-safety (flutter/engine#36154) 2022-09-15 14:32:59 -05:00