DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

[fuchsia][scenic] Call GetViewRef once per view in flatland platform (flutter/engine#36304)

Browse Source 
view.

Currently flatland platform view recursively calls GetViewRef to watch
for ViewRef changes. Since re-linking of views will not be supported by
flatland, GetViewRef should be called only once per view.

Test: ffx test run "fuchsia-pkg://fuchsia.com/flutter_runner_tests#meta/flutter_runner_tests.cm"

Bug: https://bugs.fuchsia.dev/p/fuchsia/issues/detail?id=109948
This commit is contained in:
Shivesh Ganju 2022-09-21 11:55:24 -04:00 committed by GitHub
parent 25594c3645
commit 0976e7ab55
2 changed files with 1 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
engine/src/flutter/shell/platform/fuchsia/flutter/flatland_platform_view.cc
View File

@ -154,13 +154,6 @@ void FlatlandPlatformView::OnChildViewViewRef(
fidl::Clone(view_ref, &view_ref_clone);
pointer_injector_delegate_->OnCreateView(view_id, std::move(view_ref_clone));
OnChildViewConnected(content_id);
// TODO(http://fxbug.dev/109948): Remove the following GetViewRef call.
child_view_info_.at(content_id)
.child_view_watcher->GetViewRef(
[this, content_id, view_id](fuchsia::ui::views::ViewRef view_ref) {
this->OnChildViewViewRef(content_id, view_id, std::move(view_ref));
});
}
void FlatlandPlatformView::OnCreateView(ViewCallback on_view_created,

4
engine/src/flutter/shell/platform/fuchsia/flutter/tests/flatland_platform_view_unittest.cc
View File

@ -247,9 +247,7 @@ class MockChildViewWatcher
// |fuchsia::ui::composition::ChildViewWatcher|
void GetViewRef(GetViewRefCallback callback) override {
// GetViewRef only returns once as per flatland.fidl comments
if (control_ref_.reference) {
return;
}
ASSERT_FALSE(control_ref_.reference);
auto pair = scenic::ViewRefPair::New();
control_ref_ = std::move(pair.control_ref);
callback(std::move(pair.view_ref));