Mouad Debbar
647d4fca2b
[web] Move web-only initialization APIs to dart:ui_web ( flutter/engine#43111 )
...
| Old API in `dart:ui` | New API in `dart:ui_web` |
|-|-|
| ~`webOnlyInitializePlatform`~ | ~`ui_web.initializePlatform`~ |
| `webOnlyWarmupEngine` | `ui_web.bootstrapEngine` |
| `debugEmulateFlutterTesterEnvironment` | `ui_web.debugEmulateFlutterTesterEnvironment` |
| `webOnlySetPluginHandler` | `ui_web.setPluginHandler` |
Part of https://github.com/flutter/flutter/issues/126831
2023-06-29 19:52:48 +00:00
skia-flutter-autoroll
b2ace50e6e
Roll Skia from 8ada2c4b2947 to a4d0373cd414 (14 revisions) ( flutter/engine#43338 )
...
https://skia.googlesource.com/skia.git/+log/8ada2c4b2947..a4d0373cd414
2023-06-29 lovisolo@google.com [bazel] Rename skia_android_unit_test -> android_unit_test and reorganize code.
2023-06-29 michaelludwig@google.com Add SK_API to SkColorTable declaration
2023-06-29 bungeman@google.com Fix DirectWrite port COLRv1 clang warnings
2023-06-29 armansito@google.com Roll vello from 12e764d5 to 44353989
2023-06-29 jzern@google.com update libwebp to v1.3.1
2023-06-29 johnstiles@google.com Simplify appendInstruction.
2023-06-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from b5fa16ad27df to 7ded50742b4c (3 revisions)
2023-06-29 johnstiles@google.com Provide a semicolon when invoking the declareFunction callback.
2023-06-29 kjlubick@google.com Remove conditional compilation of SkJpegSourceMgr.cpp
2023-06-29 nicolettep@google.com [graphite] Populate most of Vulkan pipeline layout & creation structs.
2023-06-29 kjlubick@google.com Reland "Remove SkCanvas::flush() from Skia-proper and remove other gpu-specific code"
2023-06-29 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from 4765e38cdc27 to 49af09d96379 (32 revisions)
2023-06-29 johnstiles@google.com Rename Graphite's MtlTestContext.mm to fix libtool warning.
2023-06-29 bungeman@google.com Move SkPathEnums.h to src/core
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-29 19:19:07 +00:00
skia-flutter-autoroll
ecf928ab40
Roll Dart SDK from 656201921b30 to ecc2440be198 (1 revision) ( flutter/engine#43333 )
...
https://dart.googlesource.com/sdk.git/+log/656201921b30..ecc2440be198
2023-06-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.1.0-261.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter Engine:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-29 10:45:11 -07:00
skia-flutter-autoroll
e1169ee71e
Roll Skia from 0c320b3d5b64 to 8ada2c4b2947 (1 revision) ( flutter/engine#43332 )
...
https://skia.googlesource.com/skia.git/+log/0c320b3d5b64..8ada2c4b2947
2023-06-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from ed391dae33e6 to 77c4b6779152 (2 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
brianosman@google.com ,jimgraham@google.com,nicolettep@google.com,rmistry@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-29 10:44:55 -07:00
skia-flutter-autoroll
88997b281e
Roll Fuchsia Linux SDK from fxCNy4QivAngZXkvM... to nboAFpQUzwtrESDVo... ( flutter/engine#43334 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-29 17:31:04 +00:00
Martin Kustermann
d6f96120e9
Prepare for utf8.encode() to return more precise Uint8List type ( flutter/engine#43335 )
...
To avoid analyzer warnings when utf8.encode() will return the more
precise Uint8List type, we use const Utf8Encoder().convert() which
already returns Uint8List
See https://github.com/dart-lang/sdk/issues/52801
2023-06-29 19:27:49 +02:00
Jason Simmons
0f55317632
[Impeller] Ensure that the auto-release pool is available when the GoldenPlaygroundTestImpl is destructed ( flutter/engine#43322 )
2023-06-29 09:33:26 -07:00
Emircan Uysaler
d69d614045
[fuchsia] Remove strict equality check for SkMatrix comparison for Fl… ( flutter/engine#43309 )
...
Flatland version of
010e710512
Bug: fxb/126648
2023-06-29 12:01:12 -04:00
Jason Simmons
eb4725c362
[Impeller] Add an autorelease pool to the GoldenTests fixture ( flutter/engine#43323 )
2023-06-29 15:11:47 +00:00
skia-flutter-autoroll
4dfe901363
Roll Skia from 2b30565d0173 to 0c320b3d5b64 (2 revisions) ( flutter/engine#43331 )
...
https://skia.googlesource.com/skia.git/+log/2b30565d0173..0c320b3d5b64
2023-06-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 96ae8b91855e to 1761cfde4cbe
2023-06-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from ca7f5660896c to 96ae8b91855e (6 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-29 07:01:19 +00:00
skia-flutter-autoroll
cd528699ef
Roll Skia from 21feae4f3d8b to 2b30565d0173 (1 revision) ( flutter/engine#43330 )
...
https://skia.googlesource.com/skia.git/+log/21feae4f3d8b..2b30565d0173
2023-06-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 47b5898a4fa7 to 222e07b368b1 (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-29 05:49:14 +00:00
skia-flutter-autoroll
8045b8824d
Roll Skia from 26fa4b343fd3 to 21feae4f3d8b (17 revisions) ( flutter/engine#43329 )
...
https://skia.googlesource.com/skia.git/+log/26fa4b343fd3..21feae4f3d8b
2023-06-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 5e35b0b24e12 to b5fa16ad27df (6 revisions)
2023-06-28 armansito@google.com Roll vello from ef2630ad to 12e764d5
2023-06-28 johnstiles@google.com Remove Win10 + ANGLE + IrisXe test and perf jobs.
2023-06-28 robertphillips@google.com Fail wrapping a protected AHardwareBuffer within an unprotected context
2023-06-28 michaelludwig@google.com Implement normalize as sqrt + divide instead of invsqrt + multiply
2023-06-28 kjlubick@google.com Mark some methods on Runtime Builders as const
2023-06-28 kjlubick@google.com Remove gSkBlobAsSlugTesting
2023-06-28 robertphillips@google.com [graphite] Enable manual image tiling GMs (take 2)
2023-06-28 johnstiles@google.com Add extra parentheses as required by WGSL spec.
2023-06-28 johnstiles@google.com Fix logical-xor operator in WGSL.
2023-06-28 jlavrova@google.com Improve justification algorithm
2023-06-28 johnstiles@google.com Add GM test slide to reproduce Perlin noise issue.
2023-06-28 johnstiles@google.com Add peephole optimization for merge_condition_mask.
2023-06-28 johnstiles@google.com Remove set_current_stack SkRP op.
2023-06-28 johnstiles@google.com Add SkRP builder methods for instruction handling.
2023-06-28 herb@google.com Add builtin_expect to SkASSERT_RELEASE
2023-06-28 nicolettep@google.com [graphite] Improve Vulkan descriptor set lifetime mgmnt.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-29 04:37:57 +00:00
skia-flutter-autoroll
b53a86933c
Roll Dart SDK from a7151d73b88d to 656201921b30 (1 revision) ( flutter/engine#43328 )
...
https://dart.googlesource.com/sdk.git/+log/a7151d73b88d..656201921b30
2023-06-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-260.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-29 04:08:03 +00:00
Jason Simmons
a636ee22cf
[Impeller] Add a missing method to the Context mock ( flutter/engine#43326 )
2023-06-28 19:11:58 -07:00
gaaclarke
4f5dfc63c5
[Impeller] Collapse DrawRects into clear colors optimization ( flutter/engine#43168 )
...
design doc: https://docs.google.com/document/d/1Lqf1BRn4uCcUfv9dZlDyAgdSMeQ3FTnPgPjKF9yQ3MI/edit
fixes: https://github.com/flutter/flutter/issues/129292
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-06-29 00:37:02 +00:00
Chinmay Garde
0098a0b154
[Impeller] Add trace events to Vulkan texture and buffer lifecycle events. ( flutter/engine#43321 )
2023-06-29 00:32:05 +00:00
skia-flutter-autoroll
be77d166b0
Roll Dart SDK from 5a59cd06e49d to a7151d73b88d (2 revisions) ( flutter/engine#43318 )
...
https://dart.googlesource.com/sdk.git/+log/5a59cd06e49d..a7151d73b88d
2023-06-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-259.0.dev
2023-06-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-258.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-29 00:05:56 +00:00
Brandon DeRosier
5533ea8e5c
[Impeller] Fix advanced CPU blend modes ( flutter/engine#43294 )
...
Resolves https://github.com/flutter/flutter/issues/128606 .
All CPU blends now match the behavior of Impeller's GPU blends, which (after https://github.com/flutter/engine/pull/43283 ) closely matches Skia's blends! Now we can finally use these.
https://github.com/flutter/engine/assets/919017/f9dc7323-fd14-4cdc-ba8b-930622be4206
2023-06-28 22:34:26 +00:00
skia-flutter-autoroll
2bab49e2f6
Roll Fuchsia Linux SDK from 10hNrVMjnCypybnz2... to fxCNy4QivAngZXkvM... ( flutter/engine#43314 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-28 21:43:05 +00:00
skia-flutter-autoroll
7c7a9c5211
Roll Skia from 0b4f472a8c44 to 26fa4b343fd3 (2 revisions) ( flutter/engine#43306 )
...
https://skia.googlesource.com/skia.git/+log/0b4f472a8c44..26fa4b343fd3
2023-06-28 fmalita@chromium.org [skwindow] Relocate WindowContext out of sk_app
2023-06-28 drott@chromium.org [Fontations] Remove static initializer for typeface registration
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-28 21:39:20 +00:00
Jonah Williams
0d33dc9e2e
[Impeller] remove redundant highp modifiers in vertex shaders. ( flutter/engine#43305 )
...
Since we've let all vertex shaders opt into highp by default I believe these are redundant (though lets wait for malioc diff to confirm).
2023-06-28 17:10:55 +00:00
skia-flutter-autoroll
a2bd9b2c43
Roll Skia from 5209dc7702d0 to 0b4f472a8c44 (58 revisions) ( flutter/engine#43304 )
...
Roll Skia from 5209dc7702d0 to 0b4f472a8c44 (58 revisions)
https://skia.googlesource.com/skia.git/+log/5209dc7702d0..0b4f472a8c44
2023-06-28 jsimmons@google.com Remove unnecessary SkUnicodeHardCodedCharProperties destructor declaration
2023-06-28 jamesgk@google.com [graphite] Do partial dst copies
2023-06-28 robertphillips@google.com Remove SkCanvasPriv::DeviceClipBounds
2023-06-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from d5b636f780eb to 5e35b0b24e12 (2 revisions)
2023-06-28 robertphillips@google.com [graphite] Enable manual image tiling GMs
2023-06-28 robertphillips@google.com Clean up TiledTextureUtils
2023-06-28 michaelludwig@google.com Use a patterned source image in FilterResultTest
2023-06-28 armansito@google.com [graphite] AtlasShapeRenderStep support for inverse fills
2023-06-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 122b292d96c9 to ed391dae33e6 (7 revisions)
2023-06-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 9e529172240d to 44d18bcca074
2023-06-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from d5f800d73318 to ca7f5660896c (3 revisions)
2023-06-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from afd97bf1e914 to 47b5898a4fa7 (1 revision)
2023-06-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from ed70ac0399fc to 4765e38cdc27 (17 revisions)
2023-06-28 lehoangquyen@chromium.org graphite-dawn: use memoryless for MSAA & depth stencil textures.
2023-06-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 5897d0f765da to d5b636f780eb (4 revisions)
2023-06-28 jvanverth@google.com [graphite] Remove unused Device asyncRescaleAndRead methods.
2023-06-28 michaelludwig@google.com [skif] Take dst bounds into account for layer fills in FilterResult
2023-06-28 michaelludwig@google.com Add SkRectPriv::ClosestDisjointEdge utility function
2023-06-28 herb@google.com Add skia_use_safe_libcxx
2023-06-27 brianosman@google.com Revert "Fix link errors when XML (expat) is not included"
2023-06-27 armansito@google.com [graphite] Support atlas draws
2023-06-27 brianosman@google.com Fix link errors when XML (expat) is not included
2023-06-27 jmbetancourt@google.com [skottie] implement text slot tracking for SlotManager
2023-06-27 jvanverth@google.com [graphite] One more revision of the asyncReadPixelsYUV420 API.
2023-06-27 sunnyps@chromium.org graphite: Reset UniformDataCache on recording snap
2023-06-27 michaelludwig@google.com Add SkTileMode support to FilterResultTest harness
2023-06-27 michaelludwig@google.com Reorganize crop_imagefilter GM to be easier to interpret
2023-06-27 lovisolo@google.com [bazel] Add BazelGMRunner.cpp.
2023-06-27 jvanverth@google.com [graphite] Add more Recorder support to async yuv GMs.
2023-06-27 armansito@google.com [graphite] Rename text/AtlasManager to text/TextAtlasManager
2023-06-27 johnstiles@google.com Remove DUMP_SRC_IR macro from WGSL code generator.
2023-06-27 jlavrova@google.com Fixing CanvasKit build
2023-06-27 kjlubick@google.com Add CanvasKit Bazel Build job to the CQ
2023-06-27 kjlubick@google.com Remove SkEncodedImageFormat::kUnknown
2023-06-27 kjlubick@google.com Reland "Remove SkRuntimeEffect::makeImage"
2023-06-27 robertphillips@google.com [graphite] Implement new tiled API for Graphite
2023-06-27 michaelludwig@google.com Reland "[skif] Remove dedicated SkDropShadowImageFilter implementation"
2023-06-27 jvanverth@google.com [graphite] Get asyncReadPixelsYUV420 working.
2023-06-27 herb@google.com Remove unused private variables from DashOp
2023-06-27 jlavrova@google.com Extending SkUnicode API to avoid code duplication
2023-06-27 johnstiles@google.com Enable all shared tests in WGSL.
2023-06-27 johnstiles@google.com Implement array-cast constructors in WGSL.
2023-06-27 kjlubick@google.com Make context methods on SkCanvas const
2023-06-27 johnstiles@google.com Add WGSL support for ES2 geometric intrinsics.
2023-06-27 michaelludwig@google.com [skif] Remove legacy Lighting filter implementations
2023-06-27 kjlubick@google.com Remove slug-related #ifdefs from src/core
...
2023-06-28 16:07:54 +00:00
skia-flutter-autoroll
c88de6c916
Roll Dart SDK from e164fdc1a3ad to 5a59cd06e49d (1 revision) ( flutter/engine#43302 )
...
https://dart.googlesource.com/sdk.git/+log/e164fdc1a3ad..5a59cd06e49d
2023-06-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-257.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-28 15:08:00 +00:00
skia-flutter-autoroll
8eb9744766
Roll Fuchsia Mac SDK from sBFKkha8HNLZpTNwv... to cytps4RRhs8-wbcVJ... ( flutter/engine#43300 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-28 11:02:14 +00:00
skia-flutter-autoroll
e86587d051
Roll Dart SDK from 3233ec5b6862 to e164fdc1a3ad (1 revision) ( flutter/engine#43299 )
...
https://dart.googlesource.com/sdk.git/+log/3233ec5b6862..e164fdc1a3ad
2023-06-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-256.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-28 10:50:38 +00:00
skia-flutter-autoroll
3b8e71d838
Roll Fuchsia Linux SDK from Bvv7TyHm_VHUkndFx... to 10hNrVMjnCypybnz2... ( flutter/engine#43297 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-28 07:33:28 +00:00
skia-flutter-autoroll
23ba7b44ce
Roll Dart SDK from abfa59f66c42 to 3233ec5b6862 (2 revisions) ( flutter/engine#43296 )
...
https://dart.googlesource.com/sdk.git/+log/abfa59f66c42..3233ec5b6862
2023-06-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-255.0.dev
2023-06-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-254.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-28 06:45:10 +00:00
Jason Simmons
ff3ce46a4d
Include the SkRTreeFactory headers in the skwasm picture recorder ( flutter/engine#43292 )
2023-06-28 00:45:38 +00:00
skia-flutter-autoroll
a6f240e943
Roll Dart SDK from 7a233f843402 to abfa59f66c42 (3 revisions) ( flutter/engine#43291 )
...
https://dart.googlesource.com/sdk.git/+log/7a233f843402..abfa59f66c42
2023-06-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-253.0.dev
2023-06-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-252.0.dev
2023-06-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-251.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-28 00:15:45 +00:00
Brandon DeRosier
09246795b0
[Impeller] Correct advanced blending behavior. ( flutter/engine#43283 )
...
Investigated as part of
https://github.com/flutter/flutter/issues/127232 .
This took some time to work out, but:
* The amount of blending applied to the source color needs to be
weighted by the destination alpha, which is pretty sensible behavior.
This is in addition to applying source-over behavior with the resulting
blended color.
* All of the blend functions assume that the color is already
premultiplied, so remove the unpremultiply/premultiply surrounding the
blend call.
All of the blend modes now visually match up with the [Flutter
docs](https://api.flutter.dev/flutter/dart-ui/BlendMode.html ), except
for ColorBurn and Saturation, which appear to have a slight
miscalculation going on with the red channel.
2023-06-27 16:04:41 -07:00
skia-flutter-autoroll
f48b290687
Manual roll Dart SDK from 81cdbe69a16b to 7a233f843402 (4 revisions) ( flutter/engine#43288 )
...
Manual roll requested by jsimmons@google.com
https://dart.googlesource.com/sdk.git/+log/81cdbe69a16b..7a233f843402
2023-06-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-250.0.dev
2023-06-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-249.0.dev
2023-06-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-248.0.dev
2023-06-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-247.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jimgraham@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-27 22:54:17 +00:00
Srujan Gaddam
fe300ba3c6
Revert "Refactor JSNumber.toDart and Object.toJS" ( flutter/engine#43286 )
...
Reverts flutter/engine#43149
Reason for reverting: Broke the roll into the framework.
2023-06-27 22:31:17 +00:00
Jim Graham
7d44b42d7a
Update skia includes to be more specific ( flutter/engine#43284 )
...
Update flutter engine includes to be more specific about use of Skia includes.
These changes are required to unblock the Skia roller that has new streamlined include files.
2023-06-27 21:33:59 +00:00
Yegor
007bc8126e
[web:a11y] introduce primary role responsible for ARIA roles ( flutter/engine#43159 )
...
This PR fixes https://github.com/flutter/flutter/issues/128468 by changing the relationship between semantics nodes and their roles from this:
```
SemanticsNode one-to-many RoleManager
```
To this:
```
SemanticsNode one-to-one PrimaryRoleManager one-to-many RoleManager
```
Previously a node would simply have multiple role managers, some of which would be responsible for setting the `role` attribute. It wasn't clear which role manager should be doing this. It also wasn't clear which role managers were safe to reuse across multiple types of nodes. This led to the unfortunate situation in https://github.com/flutter/flutter/issues/128468 where `LabelAndValue` ended up overriding the role assigned by `Checkable`.
With this PR, a `SemanticsNode` has exactly one `PrimaryRoleManager`. A primary role manager is responsible for setting the `role` attribute, and importantly, it's the _only_ thing responsible for it. It's _not safe_ to share primary role managers across different kinds of nodes. They are meant to provide very specific functionality for the widget's main role. OTOH, a non-primary `RoleManager` provides a piece of functionality that's safe to share.
A `Checkable` is a `PrimaryRoleManager` and is the only thing that decides on the `role` attribute. `LabelAndValue` is now a `RoleManager` that's not responsible for setting the role. It's only responsible for `aria-label`. No more confusion.
This also drastically simplifies the logic for role assignment. There's no more [logical soup](d4889c682d/lib/web_ui/lib/src/engine/semantics/semantics.dart (L1340) ) attempting to find a good subset of roles to assign to a node. [Finding](93df91df95/lib/web_ui/lib/src/engine/semantics/semantics.dart (L1477) ) and [instantiating](93df91df95/lib/web_ui/lib/src/engine/semantics/semantics.dart (L1498) ) primary roles are very linear steps, as is [assigning a set of secondary roles](93df91df95/lib/web_ui/lib/src/engine/semantics/image.dart (L16) ).
2023-06-27 20:49:03 +00:00
skia-flutter-autoroll
de73f6fe7b
Roll Fuchsia Mac SDK from ytzCCSvHY1lHWEDM9... to sBFKkha8HNLZpTNwv... ( flutter/engine#43277 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-27 20:24:54 +00:00
skia-flutter-autoroll
8eeb3843c0
Roll ANGLE from 9faf7059f9ef to 113f847be69f (2 revisions) ( flutter/engine#43278 )
...
9faf7059f9..113f847be6
2023-06-27 steven@uplinklabs.net centralize basic OS/platform detection functions
2023-06-27 abdolrashidi@google.com Vulkan: Move device OOM tests to new test suite
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC flutter-engine@google.com ,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-27 20:23:30 +00:00
Jackson Gardner
3a44bbda74
Initialize skwasm codecs before handing them back to the user. ( flutter/engine#43274 )
...
Benchmarks were failing because the code was reading the `frameCount` and `repetitionCount` before reading any frames out of the codec. The codec gets implicitly initialized when you read a frame, but we should return it to the user initialized so that `frameCount` and `repetitionCount` work even if you haven't read a frame yet. This is consistent with how CanvasKit's codec works.
Also, modified our unit tests so that they exercise the codecs in this way.
2023-06-27 20:17:30 +00:00
skia-flutter-autoroll
7f00ce647f
Roll ANGLE from 02292814a9d3 to 9faf7059f9ef (7 revisions) ( flutter/engine#43272 )
...
02292814a9..9faf7059f9
2023-06-27 i.nazarov@samsung.com Optimize angle::Spinlock performance
2023-06-27 mark@lunarg.com Android: Add/update MaliG710 expectations and tests
2023-06-27 constantine.shablya@collabora.com Tests: Add paletted formats glGetTexImageANGLE tests
2023-06-27 m.maiya@samsung.com Fix bug in ProgramPipelineObjectBenchmark
2023-06-27 steven@uplinklabs.net Vulkan: support creating context with MoltenVK on macOS
2023-06-27 abdolrashidi@google.com Vulkan: Free the garbage memory before realloc
2023-06-27 abdolrashidi@google.com Vulkan: Free the garbage memory before realloc
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC flutter-engine@google.com ,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-27 18:39:05 +00:00
Victoria Ashworth
06457c8cae
Update Xcode to 14.3.1 ( flutter/engine#42930 )
...
Engine part of https://github.com/flutter/flutter/issues/129019 .
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-06-27 18:21:30 +00:00
Jonah Williams
7a937cfb61
[Impeller] Add Vulkan allocator traces. ( flutter/engine#43215 )
...
I suspect this is where we're blocking on the texture uploads right now.
2023-06-27 18:18:06 +00:00
skia-flutter-autoroll
2192b1172d
Roll Fuchsia Linux SDK from bj_X2Se1zObk_l_CC... to Bvv7TyHm_VHUkndFx... ( flutter/engine#43270 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-27 18:18:04 +00:00
Chinmay Garde
7ea00141cf
[Impeller] Report pipeline creation feedback to logs and traces. ( flutter/engine#43227 )
...
Piping the feedback to logs is disabled by default but can be enabled by patching the source for now. If reading from logs gets to be useful, we can move it behind a flag. In traces, enabled by default, pipeline cache hits and misses will be shown via counters. The time taken to create a pipeline variant is already covered by existing traces.
This patch also sets up infrastructure in the impeller::CapabilitiesVK to quickly enable optional device extensions.
Pipeline feedback will only be reported if the device supports `VK_EXT_pipeline_creation_feedback`.
Example of logs:
```
E/flutter ( 2011): >>>>>>
E/flutter ( 2011): Pipeline 'GaussianBlurAlphaDecal Pipeline' Time: 48.60ms Cache Hit: 0 Base Accel: 0 Thread: 481449901232
E/flutter ( 2011): Stage 1: Time: 12.91ms Cache Hit: 0 Base Accel: 0 Thread: 481449901232
E/flutter ( 2011): Stage 2: Time: 15.10ms Cache Hit: 0 Base Accel: 0 Thread: 481449901232
E/flutter ( 2011): <<<<<<
```
2023-06-27 18:10:59 +00:00
Jonah Williams
ac3ce651f3
[Impeller] Give Impeller a dedicated raster priority level worker loop. ( flutter/engine#43166 )
...
We'd like to (or already are) using the concurrent message loop for high priority rendering tasks like PSO construction and render pass encoding. The default priority level for the engine managed concurrent message loop is 2, which is a significantly lower priority than the raster thread at -5. This is almost certainly causing priority inversion.
We must move back to dedicated runners so we can adjust thread priorities.
2023-06-27 18:08:49 +00:00
Jason Simmons
6504962164
[Impeller] Fixes for GLES color mask setup ( flutter/engine#43225 )
...
* Always set the color mask even if blending is disabled
* Fix a typo in the check of the mask against each color bit
2023-06-27 10:44:44 -07:00
skia-flutter-autoroll
4e0c530160
Roll ANGLE from cba77bceb26c to 02292814a9d3 (1 revision) ( flutter/engine#43224 )
...
cba77bceb2..02292814a9
2023-06-27 cclao@google.com Vulkan: Optimize the usage of FastMap in DescriptorSetDescBuilder
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC flutter-engine@google.com ,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-27 01:21:16 +00:00
skia-flutter-autoroll
423c26f5cf
Roll Skia from 370132bcadb1 to 5209dc7702d0 (1 revision) ( flutter/engine#43223 )
...
https://skia.googlesource.com/skia.git/+log/370132bcadb1..5209dc7702d0
2023-06-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 5361da56b817 to f267b223b279 (6 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jsimmons@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-27 00:35:19 +00:00
David Iglesias
af5ad81ca7
[web] Removes patchCanvasKitModule. ( flutter/engine#42941 )
...
**This must land _after_ https://github.com/flutter/flutter/pull/129032 **
Flutter web uses requireJS in `debug` mode to assemble a DDC-compiled app from a bunch of small files ("modules").
This caused that `canvaskit.js` (then, but probably all other modules that used a browserify-like loading header) didn't work because it attempted to use the `define` function provided by Flutter's instance of `requireJS` (which kept the defined modules private, rather than as globals on the page, as the users of the JS expected).
A [fix](https://github.com/flutter/engine/pull/27342 ) was added to `flutter/engine` to trick loaders into *not* using the `requireJS` module loader, but a recent change in the fix's js-interop layer *subtly* changed its JS output on the page (objects went from `undefined` to `null`), causing this:
* https://github.com/flutter/flutter/issues/126131 (and others)
After flutter/flutter#129032 , the engine fix shouldn't be required anymore, so this PR removes it.
## Issues
* Fixes https://github.com/flutter/flutter/issues/126131 (and possibly others)
## Testing
* Manually tested with some test apps, and miscellanous JS scripts as reported by users.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-06-27 00:01:21 +00:00
skia-flutter-autoroll
34e09d7ff0
Roll ANGLE from cafbf6e2660f to cba77bceb26c (1 revision) ( flutter/engine#43222 )
...
cafbf6e266..cba77bceb2
2023-06-26 abdolrashidi@google.com Disable device OOM tests for Linux/NVIDIA
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC flutter-engine@google.com ,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-26 23:38:41 +00:00
Brandon DeRosier
083d8dd6d4
[Impeller] Fix CPU Porter-Duff blends ( flutter/engine#43217 )
...
Part of https://github.com/flutter/flutter/issues/128606 .
* Fix all of the Porter-Duff blends (virtually all of the blends were
wrong). Still working on getting all of the advanced/color blends fixed
up.
* Fill in missing ops for arithmetic types/remove Vector4 conversions.
* Remove the original GeometryTest in favor of the much clearer goldens.
Once we have all of the CPU blends matching up properly with the GPU
blends, we can think about constructing a more intentional test that
covers a select number of important cases with accompanying explanation.
Top rectangles = GPU blends
Bottom rectangles = CPU blends
2023-06-26 16:37:52 -07:00
skia-flutter-autoroll
b62a3603c1
Roll Skia from c1effc01211e to 370132bcadb1 (2 revisions) ( flutter/engine#43221 )
...
https://skia.googlesource.com/skia.git/+log/c1effc01211e..370132bcadb1
2023-06-26 jvanverth@google.com Restore the correct colorspace for asyncread GMs.
2023-06-26 brianosman@google.com Add support for BGRX_8888 textures to Ganesh
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jsimmons@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-26 23:32:09 +00:00