Parker Lougheed
63a8298d4b
Update links to old linter site to dart.dev ( #129866 )
...
Removes the remaining links to the old linter site, to the guaranteed dart.dev/lints redirect.
Contributes to https://github.com/dart-lang/linter/issues/4460 and https://github.com/dart-lang/site-www/issues/4499
2023-07-01 18:36:10 +00:00
Michael Goderbauer
aa5f4a28e9
Enable no_wildcard_variable_uses lint ( #129858 )
...
Wildcard parameters and local variables (e.g. underscore-only names like _, __, ___, etc.) will become non-binding in a future version of the Dart language. Any existing code that uses wildcard parameters or variables will break. In anticipation of this change, and to make adoption easier, this lint disallows wildcard and variable parameter uses.
We had no violations of this in the framework. Let's keep it that way!
2023-07-01 01:16:21 +00:00
Christopher Fujino
97fce9aa19
mark packages-autoroller bringup again ( #129859 )
...
Even after updating the account (and the cloudKMS GitHub token), when
the bot tries to push to
https://github.com/flutter-pub-roller-bot/flutter , it gets a 403, which
probably means authentication failed. I will have to investigate next
week.
```
Exception: GitException: Exception on command "push https://[GitHub TOKEN]@github.com/flutter-pub-roller-bot/flutter.git packages-autoroller-branch-1:packages-autoroller-branch-1": Command "git push https://[GitHub TOKEN]@github.com/flutter-pub-roller-bot/flutter.git packages-autoroller-branch-1:packages-autoroller-branch-1" failed in directory "/b/s/w/ir/x/w/flutter_conductor_checkouts/framework" to update the release branch with the commit. Git exited with error code 128.
stderr from git:
16:33:21.199510 exec-cmd.c:90 trace: resolved executable path from procfs: /b/s/w/ir/cipd_bin_packages/bin/git
16:33:21.199587 exec-cmd.c:237 trace: resolved executable dir: /b/s/w/ir/cipd_bin_packages/bin
16:33:21.200155 git.c:460 trace: built-in: git push https://[GitHub TOKEN]@github.com/flutter-pub-roller-bot/flutter.git packages-autoroller-branch-1:packages-autoroller-branch-1
16:33:21.200542 run-command.c:655 trace: run_command: GIT_DIR=.git git remote-https https://[GitHub TOKEN]@github.com/flutter-pub-roller-bot/flutter.git https://[GitHub TOKEN]@github.com/flutter-pub-roller-bot/flutter.git
16:33:21.201787 exec-cmd.c:90 trace: resolved executable path from procfs: /b/s/w/ir/cipd_bin_packages/libexec/git-core/git
16:33:21.201845 exec-cmd.c:237 trace: resolved executable dir: /b/s/w/ir/cipd_bin_packages/libexec/git-core
16:33:21.202175 git.c:750 trace: exec: git-remote-https https://[GitHub TOKEN]@github.com/flutter-pub-roller-bot/flutter.git https://[GitHub TOKEN]@github.com/flutter-pub-roller-bot/flutter.git
16:33:21.202195 run-command.c:655 trace: run_command: git-remote-https https://[GitHub TOKEN]@github.com/flutter-pub-roller-bot/flutter.git https://[GitHub TOKEN]@github.com/flutter-pub-roller-bot/flutter.git
16:33:21.203510 exec-cmd.c:90 trace: resolved executable path from procfs: /b/s/w/ir/cipd_bin_packages/libexec/git-core/git-remote-http
16:33:21.203567 exec-cmd.c:237 trace: resolved executable dir: /b/s/w/ir/cipd_bin_packages/libexec/git-core
remote: Permission to flutter-pub-roller-bot/flutter.git denied to flutter-pub-roller-bot.
fatal: unable to access 'https://github.com/flutter-pub-roller-bot/flutter.git/ ': The requested URL returned error: 403
```
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20packages_autoroller/6031/overview
This is still being tracked in
https://github.com/flutter/flutter/issues/129744
2023-06-30 16:54:55 -07:00
Qun Cheng
9249dcc283
Update SwitchTheme tests for M2/M3 ( #129811 )
2023-06-30 16:29:02 -07:00
Christopher Fujino
67b7aa22c2
Change pub roller bot to push to flutter-pub-roller-bot/flutter.git ( #129844 )
...
Fixes https://github.com/flutter/flutter/issues/129744
Part of https://github.com/flutter/flutter/issues/129847
Migrate the packages_autoroller script to push to
flutter-pub-roller-bot/flutter.git, rather than
fluttergithubbot/flutter.git.
2023-06-30 16:28:00 -07:00
Greg Price
1153371a56
Fix NetworkImage causing spurious warning in tests ( #129537 )
...
Fixes #129532 .
This ensures that when a test properly uses `debugNetworkImageHttpClientProvider` to tell `NetworkImage` to use a fake `HttpClient`, we don't go ahead and try to instantiate `HttpClient` anyway and generate a misleading warning.
2023-06-30 22:25:52 +00:00
engine-flutter-autoroll
84068857ff
Roll Flutter Engine from 54b573e9c4e5 to e6b8292705a8 (4 revisions) ( #129852 )
...
54b573e9c4...e6b8292705jonahwilliams@google.com [Impeller] cache MSAA texture in swapchain for devices that do not support memoryless. (flutter/engine#43349 )
2023-06-30 jonahwilliams@google.com [Impeller] Fix validation error in position color shader. (flutter/engine#43356 )
2023-06-30 109111084+yaakovschectman@users.noreply.github.com Fix inverted boolean in Windows document selection changed a11y event (flutter/engine#43281 )
2023-06-30 bdero@google.com Revert "Reland "add non-rendering operation culling to DisplayListBuilder" (#41463 )" (flutter/engine#43358 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-30 20:59:13 +00:00
gmackall
d1eb1f0a57
Upgrade integration tests to use AGP 7.3/Gradle 7.4 ( #129642 )
...
Upgrades tests under `dev/integration_tests` to use the latest values [in the templates](944d6c8fef/dev/tools/bin/generate_gradle_lockfiles.dart (L135)cef9a8c54b/dev/bots/test.dart (L553)https://github.com/flutter/flutter/pull/129642/files#diff-d7cfaa1c96d5c2383e7fc253ac8c9df062b544c24f7d80aa8a02290c01d17205L17 ) and [platform_interaction](https://github.com/flutter/flutter/pull/129642/files#diff-b2fba811efadd1cfb097bebd93be99fe4b6d6f17aefa863267290fc704290766L17 ) tests), because those had been manually edited to a newer version than the template.
Related to: https://github.com/flutter/flutter/issues/123636 , https://github.com/flutter/flutter/pull/123910
2023-06-30 19:34:20 +00:00
engine-flutter-autoroll
b1aa0d9d82
Roll Packages from d4752c40696e to 53ed5a0aa9e4 (5 revisions) ( #129837 )
...
d4752c4069...53ed5a0aa9me@jxstxn.dev [google_maps_flutter_web] Add padding to newLatLngBounds implementation (flutter/packages#3452 )
2023-06-29 stuartmorgan@google.com [various] Remove unused flutter_driver dependencies (flutter/packages#4347 )
2023-06-29 stuartmorgan@google.com [ci] Add LUCI version of dart unit tests (flutter/packages#4265 )
2023-06-29 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump org.jetbrains.kotlin:kotlin-gradle-plugin from 1.8.21 to 1.8.22 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#4189 )
2023-06-29 tarrinneal@gmail.com [shared_preferences] Adds new clearWithParameters and getAllWithParameters methods to all platforms. (flutter/packages#4262 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-30 19:20:55 +00:00
Ricardo Amador
089b46ba03
Updated correct tasks for test ownership fix ( #129812 )
...
Update a few of the tasks that are mislabeled as this will cause failures if that change is merged first.
This PR is needed before: https://github.com/flutter/cocoon/pull/2898
*List which issues are fixed by this PR. You must list at least one issue.*
Part of https://github.com/flutter/flutter/issues/125328
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2023-06-30 19:06:47 +00:00
Hans Muller
26ad4a4a79
Updated some golden image tests for M2/M3 ( #129794 )
...
Updated some of the golden image tests that were temporarily changed in https://github.com/flutter/flutter/pull/128914 to have M2 and M3 versions.
Updated the linear_gradient_0 example to M3 (which will require updating its golden image as well).
More info in https://github.com/flutter/flutter/issues/127064
2023-06-30 18:09:56 +00:00
Nate Bosch
34c092f2b3
Remove an unnecessary assert ( #129796 )
...
The type variable `T`, when used as an expression, will always be a
`Type`. The type test `T is! List` is always true (as is `T is Type`).
This expression will become a warning in the analyzer in some upcoming
release of the Dart SDK.
This `assert` was added in a PR which reapplied an earlier PR, however
the earlier PR did not include this assert. I do not see any discussion
indicating the intent of this assert.
The impact of testing this `T` in any way is low - this is a private
class so we can see all the uses and know that the only type bound to
`T` is `Uri`. Avoid the upcoming diagnostic and remove the assert
entirely. This maintains existing behavior but ignores the potential
intent for the check.
2023-06-30 18:07:54 +00:00
Qun Cheng
1ed54f8ec0
Update Radio tests for M2/M3 ( #129814 )
...
Updated unit tests for `Radio` to have M2 and M3 versions.
More info in https://github.com/flutter/flutter/issues/127064
2023-06-30 18:06:25 +00:00
Qun Cheng
0bb9409fd0
Update Switch tests for M2/M3 ( #129810 )
...
Updated and reorganized unit tests for `Switch` to have M2 and M3 versions.
More info in https://github.com/flutter/flutter/issues/127064
2023-06-30 18:06:23 +00:00
engine-flutter-autoroll
2fefe72c3f
Roll Flutter Engine from 099a70ebbc60 to 54b573e9c4e5 (1 revision) ( #129821 )
...
099a70ebbc...54b573e9c4skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from nboAFpQUzwtrESDVo... to iwgWLB4KaXslnaGwK... (flutter/engine#43357 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from nboAFpQUzwtr to iwgWLB4KaXsl
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-30 16:21:12 +00:00
Qun Cheng
2e4122cc61
Update SwitchListTile tests for M2/M3 ( #129809 )
...
Updated and reorganized unit tests for `SwitchListTile` to have M2 and M3 versions.
More info in https://github.com/flutter/flutter/issues/127064
2023-06-30 09:05:48 +00:00
Taha Tesser
7cef966147
Fix NavigationDrawer selected item has wrong icon color ( #129625 )
...
fixes [NavigationDrawer selected item has wrong icon color [Material3 spec]](https://github.com/flutter/flutter/issues/129572 )
### Description
This PR fixes a mistake in the `NavigationDrawer` defaults, where generated token value returns a `null`.
This issue can be detected when you want to customize the selected icon color for `NavigationDrawerDestination` using a custom color scheme.
### Code sample
<details>
<summary>expanded to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() => runApp(const MyApp());
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
debugShowCheckedModeBanner: false,
themeMode: ThemeMode.light,
theme: ThemeData(
colorScheme: ColorScheme.fromSeed(seedColor: Colors.blue).copyWith(
onSecondaryContainer: Colors.red,
),
useMaterial3: true,
),
home: const Example(),
);
}
}
class Example extends StatelessWidget {
const Example({super.key});
@override
Widget build(BuildContext context) {
return Scaffold(
appBar: AppBar(
title: const Text('NavigationDrawer Sample'),
),
drawer: const NavigationDrawer(
children: <Widget>[
NavigationDrawerDestination(
icon: Icon(Icons.favorite_outline_rounded),
label: Text('Favorite'),
selectedIcon: Icon(Icons.favorite_rounded),
),
NavigationDrawerDestination(
icon: Icon(Icons.favorite_outline_rounded),
label: Text('Favorite'),
),
],
),
);
}
}
```
</details>
### Before
<img width="1053" alt="Screenshot 2023-06-27 at 13 24 38" src="https://github.com/flutter/flutter/assets/48603081/18c13a73-688f-4586-bb60-bddef45d173f ">
### After
<img width="1053" alt="Screenshot 2023-06-27 at 13 24 25" src="https://github.com/flutter/flutter/assets/48603081/8a1427c6-517f-424a-b0bd-24bad7c5fbb0 ">
2023-06-30 08:58:14 +00:00
Bruno Leroux
3a6d661587
Update basic_test.dart for M3 compliance ( #129714 )
...
## Description
This PR fixes two test failures in `basic_test.dart` which surfaced when switching to M3 (see https://github.com/flutter/flutter/pull/127501 )
Those failures are related to M3 typography which sets line height to 1.43.
Forcing line height to 1.0 seems reasonable for these particular tests. With this change these two test are successful for both M2 and M3.
## Related Issue
fixes https://github.com/flutter/flutter/issues/129713
## Tests
Updates 2 tests.
2023-06-30 08:56:16 +00:00
engine-flutter-autoroll
7b8595629b
Roll Flutter Engine from d33343430f18 to 099a70ebbc60 (7 revisions) ( #129818 )
...
d33343430f...099a70ebbcditman@gmail.com [web] Add nonce configuration. (flutter/engine#42829 )
2023-06-30 bdero@google.com [Impeller] Unwrap optional procs in EntityPass (flutter/engine#43352 )
2023-06-30 bdero@google.com [Impeller] Assign missing user to TODO. (flutter/engine#43351 )
2023-06-29 skia-flutter-autoroll@skia.org Roll Skia from a1ae27969207 to 2d05e3ec6b67 (1 revision) (flutter/engine#43350 )
2023-06-29 skia-flutter-autoroll@skia.org Roll Dart SDK from ecc2440be198 to 2d98d9e27dae (1 revision) (flutter/engine#43347 )
2023-06-29 jonahwilliams@google.com [Impeller] Check for lazy memory support. (flutter/engine#43339 )
2023-06-29 bdero@google.com [Impeller] Remove all double empties (flutter/engine#43345 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-30 06:29:24 +00:00
engine-flutter-autoroll
d605e8747e
Roll Flutter Engine from 68cc1a7971d5 to d33343430f18 (2 revisions) ( #129801 )
...
68cc1a7971...d33343430fskia-flutter-autoroll@skia.org Roll Skia from c83f8ba23a80 to
a1ae27969207 (8 revisions) (flutter/engine#43343 )
2023-06-29 tamird@google.com Remove unused constants
(flutter/engine#43344 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-29 22:30:42 -07:00
godofredoc
732429e35b
Revert no-response to fork. ( #129775 )
...
The core action is not scaling well for the # of Prs and bugs of the flutter project.
Bug: https://github.com/flutter/flutter/issues/129771
2023-06-30 04:20:09 +00:00
Qun Cheng
91cb2618c3
Make DropdownMenu be able to scroll to the highlighted item when searching. ( #129740 )
...
Fixes #120349
This PR enables `DropdownMenu` to automatically scroll to the first matching item when `enableSearch` is true.
<details><summary>video example</summary>
https://github.com/flutter/flutter/assets/36861262/1a7a956c-c186-44ca-9a52-d94dc21cac8a
</details>
2023-06-30 01:48:05 +00:00
engine-flutter-autoroll
a2dc0ed854
Roll Flutter Engine from cd9ce66db14a to 68cc1a7971d5 (10 revisions) ( #129799 )
...
cd9ce66db1...68cc1a7971skia-flutter-autoroll@skia.org Roll Skia from a4d0373cd414 to c83f8ba23a80 (3 revisions) (flutter/engine#43340 )
2023-06-29 mdebbar@google.com [web] Move web-only initialization APIs to `dart:ui_web` (flutter/engine#43111 )
2023-06-29 skia-flutter-autoroll@skia.org Roll Skia from 8ada2c4b2947 to a4d0373cd414 (14 revisions) (flutter/engine#43338 )
2023-06-29 skia-flutter-autoroll@skia.org Roll Dart SDK from 656201921b30 to ecc2440be198 (1 revision) (flutter/engine#43333 )
2023-06-29 skia-flutter-autoroll@skia.org Roll Skia from 0c320b3d5b64 to 8ada2c4b2947 (1 revision) (flutter/engine#43332 )
2023-06-29 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from fxCNy4QivAngZXkvM... to nboAFpQUzwtrESDVo... (flutter/engine#43334 )
2023-06-29 kustermann@google.com Prepare for utf8.encode() to return more precise Uint8List type (flutter/engine#43335 )
2023-06-29 jason-simmons@users.noreply.github.com [Impeller] Ensure that the auto-release pool is available when the GoldenPlaygroundTestImpl is destructed (flutter/engine#43322 )
2023-06-29 uysalere@gmail.com [fuchsia] Remove strict equality check for SkMatrix comparison for Fl⦠(flutter/engine#43309 )
2023-06-29 jason-simmons@users.noreply.github.com [Impeller] Add an autorelease pool to the GoldenTests fixture (flutter/engine#43323 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from fxCNy4QivAng to nboAFpQUzwtr
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-29 23:27:07 +00:00
dependabot[bot]
15513f2c73
Bump actions/labeler from 4.1.0 to 4.2.0 ( #129797 )
...
Bumps [actions/labeler](https://github.com/actions/labeler ) from 4.1.0 to 4.2.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/labeler/releases ">actions/labeler's releases</a>.</em></p>
<blockquote>
<h2>v4.2.0</h2>
<h2>What's Changed</h2>
<p>In the scope of this release, the following outputs were added by <a href="https://github.com/danielsht86 "><code>@âdanielsht86</code></a> in <a href="https://redirect.github.com/actions/labeler/issues/60 ">#60</a>:</p>
<ul>
<li><code>new-labels</code> - a comma-separated string that contains all newly added labels.</li>
<li><code>all-labels</code> - a comma-separated string that contains all labels currently assigned to the PR.</li>
</ul>
<p>For detailed information, please refer to our <a href="0967ca812e (outputs)https://github.com/markmssd "><code>@âmarkmssd</code></a> in <a href="https://redirect.github.com/actions/labeler/issues/497 ">#497</a>. However, it's important to note that the GitHub API imposes a limit of 100 labels. To ensure smooth operation, a warning message that will alert you if the number of labels exceeds this limit was implemented. From this point forward, if more than 100 labels are specified, only the first 100 will be assigned.</p>
<p>The error handling for the <code>Resource not accessible by integration</code> error was added by <a href="https://github.com/jsoref "><code>@âjsoref</code></a> in <a href="https://redirect.github.com/actions/labeler/issues/405 ">#405</a>. Now, if the workflow is misconfigured, the labeler provides a clear warning and guidance for correction.</p>
<p>This release also includes the following changes:</p>
<ul>
<li>Warn about the limitations of GitHub tokens by <a href="https://github.com/dfandrich "><code>@âdfandrich</code></a> in <a href="https://redirect.github.com/actions/labeler/pull/491 ">actions/labeler#491</a></li>
<li>Improve readme by <a href="https://github.com/jsoref "><code>@âjsoref</code></a> in <a href="https://redirect.github.com/actions/labeler/pull/589 ">actions/labeler#589</a></li>
<li>Bump eslint-plugin-jest from 27.2.1 to 27.2.2 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/actions/labeler/pull/591 ">actions/labeler#591</a></li>
<li>Bump eslint from 8.42.0 to 8.43.0 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/actions/labeler/pull/592 ">actions/labeler#592</a></li>
<li>Bump <code>@âtypescript-eslint/eslint-plugin</code> from 5.60.0 to 5.60.1 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/actions/labeler/pull/598 ">actions/labeler#598</a></li>
<li>Bump <code>@âtypescript-eslint/parser</code> from 5.60.0 to 5.60.1 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/actions/labeler/pull/597 ">actions/labeler#597</a></li>
<li>Bump <code>@âoctokit/plugin-retry</code> from 5.0.2 to 5.0.4 by <a href="https://github.com/MaksimZhukov "><code>@âMaksimZhukov</code></a> in <a href="https://redirect.github.com/actions/labeler/pull/599 ">actions/labeler#599</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/dfandrich "><code>@âdfandrich</code></a> made their first contribution in <a href="https://redirect.github.com/actions/labeler/pull/491 ">actions/labeler#491</a></li>
<li><a href="https://github.com/markmssd "><code>@âmarkmssd</code></a> made their first contribution in <a href="https://redirect.github.com/actions/labeler/pull/497 ">actions/labeler#497</a></li>
<li><a href="https://github.com/danielsht86 "><code>@âdanielsht86</code></a> made their first contribution in <a href="https://redirect.github.com/actions/labeler/pull/60 ">actions/labeler#60</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/labeler/compare/v4...v4.2.0 ">https://github.com/actions/labeler/compare/v4...v4.2.0 </a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="0967ca812ehttps://redirect.github.com/actions/labeler/issues/60 ">#60</a>)</li>
<li><a href="375538a703https://redirect.github.com/actions/labeler/issues/599 ">#599</a>)</li>
<li><a href="8d17e8ac4chttps://redirect.github.com/actions/labeler/issues/597 ">#597</a>)</li>
<li><a href="9d45a7438fhttps://redirect.github.com/actions/labeler/issues/598 ">#598</a>)</li>
<li><a href="130636aba5https://redirect.github.com/actions/labeler/issues/592 ">#592</a>)</li>
<li><a href="54aeabf7b5https://redirect.github.com/actions/labeler/issues/593 ">#593</a>)</li>
<li><a href="899595ff01https://redirect.github.com/actions/labeler/issues/591 ">#591</a>)</li>
<li><a href="8056174ee0https://redirect.github.com/actions/labeler/issues/594 ">#594</a>)</li>
<li><a href="7a202e6428https://redirect.github.com/actions/labeler/issues/497 ">#497</a>)</li>
<li><a href="b5ff161cf0https://redirect.github.com/actions/labeler/issues/405 ">#405</a>)</li>
<li>Additional commits viewable in <a href="9fcb2c2f55...0967ca812ehttps://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/labeler&package-manager=github_actions&previous-version=4.1.0&new-version=4.2.0 )](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2023-06-29 23:19:39 +00:00
engine-flutter-autoroll
afcf67428c
Roll Flutter Engine from eabb22900b44 to cd9ce66db14a (1 revision) ( #129756 )
...
eabb22900b...cd9ce66db1skia-flutter-autoroll@skia.org Roll Skia from 2b30565d0173 to 0c320b3d5b64 (2 revisions) (flutter/engine#43331 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-29 22:24:08 +00:00
fzyzcjy
92969ba8ca
Remove @NonNull to avoid warning ( #129472 )
...
Otherwise android studio complains:
> Do not use @NonNull in Kotlin; the nullability is already implied by the Kotlin type MethodCall not ending with ?
2023-06-29 21:34:31 +00:00
Ricardo Amador
bda64b54e1
Remove use of any ( #129793 )
...
Remove use of any. This reverts to a previous change. Without any and the newest version this put us back to before the version change.
Restores to this change: 2be476d401
2023-06-29 21:34:28 +00:00
Martin Kustermann
7068a2088e
Prepare for utf8.encode() to return more precise Uint8List type ( #129769 )
...
To avoid analyzer warnings when utf8.encode() will return the more
precise Uint8List type, we use const Utf8Encoder().convert() which
already returns Uint8List
See https://github.com/dart-lang/sdk/issues/52801
2023-06-29 22:44:57 +02:00
lsaudon
7cab354def
Deletes files that should be ignored ( #127984 )
...
Some files are supposed to ignore, but don't.
- **/windows/flutter/generated_plugins.cmake
- **/linux/flutter/generated_plugin_registrant.cc
- **/linux/flutter/generated_plugin_registrant.h
- **/linux/flutter/generated_plugins.cmake
- **/windows/flutter/generated_plugin_registrant.cc
- **/windows/flutter/generated_plugin_registrant.h
- **/ios/Runner/GeneratedPluginRegistrant.h
- **/ios/Runner/GeneratedPluginRegistrant.m
*List which issues are fixed by this PR. You must list at least one issue.*
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2023-06-29 19:45:22 +00:00
Christopher Fujino
8b54878dee
Fix flutter_plugins by rolling revision ( #129781 )
...
Fixes https://github.com/flutter/flutter/issues/129782
Linux flutter_plugins is currently broken
https://ci.chromium.org/p/flutter/builders/prod/Linux%20flutter_plugins/12884
On an analysis error that was ignored upstream in
5d6e48c3e0
2023-06-29 12:27:17 -07:00
Tae Hyung Kim
ff838bca89
Add locale-specific DateTime formatting syntax ( #129573 )
...
Based on the [message format
syntax](https://unicode-org.github.io/icu/userguide/format_parse/messages/#examples )
for
[ICU4J](https://unicode-org.github.io/icu-docs/apidoc/released/icu4j/com/ibm/icu/text/MessageFormat.html ).
This adds new syntax to the current Flutter messageFormat parser which
should allow developers to add locale-specific date formatting.
## Usage example
```
"datetimeTest": "Today is {today, date, ::yMd}",
"@datetimeTest": {
"placeholders": {
"today": {
"description": "The date placeholder",
"type": "DateTime"
}
}
}
```
compiles to
```
String datetimeTest(DateTime today) {
String _temp0 = intl.DateFormat.yMd(localeName).format(today);
return 'Today is $_temp0';
}
```
Fixes https://github.com/flutter/flutter/issues/127304 .
2023-06-29 09:23:34 -07:00
Taha Tesser
f3a7485b2c
Update RadioListTile tests to M3 ( #129718 )
...
This updates the `RadioListTile` test which was modified in https://github.com/flutter/flutter/pull/128839
### Description
- Update the layout to the proper order `MaterialApp` -> `Material` -> `RadioListTile`
- Add M3 overlay test. (fixed problem faced in https://github.com/flutter/flutter/pull/128839 )
- Separate the M2 overlay test.
2023-06-29 15:55:15 +00:00
engine-flutter-autoroll
cd97b4391a
Roll Flutter Engine from 7fd0e9522ea1 to eabb22900b44 (1 revision) ( #129754 )
...
7fd0e9522e...eabb22900bskia-flutter-autoroll@skia.org Roll Skia from 21feae4f3d8b to 2b30565d0173 (1 revision) (flutter/engine#43330 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-29 07:52:07 +00:00
engine-flutter-autoroll
5951f9d945
Roll Flutter Engine from d5c25ead07e9 to 7fd0e9522ea1 (2 revisions) ( #129752 )
...
d5c25ead07...7fd0e9522eskia-flutter-autoroll@skia.org Roll Skia from 26fa4b343fd3 to 21feae4f3d8b (17 revisions) (flutter/engine#43329 )
2023-06-29 skia-flutter-autoroll@skia.org Roll Dart SDK from a7151d73b88d to 656201921b30 (1 revision) (flutter/engine#43328 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-29 06:30:39 +00:00
Jia Tan
87194a2301
Fix typos in ListTile examples. ( #129606 )
...
Fix typos.
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2023-06-29 06:29:03 +00:00
engine-flutter-autoroll
328d4d4895
Roll Flutter Engine from 4e49b9deb72d to d5c25ead07e9 (7 revisions) ( #129750 )
...
4e49b9deb7...d5c25ead07jason-simmons@users.noreply.github.com [Impeller] Add a
missing method to the Context mock (flutter/engine#43326 )
2023-06-29 30870216+gaaclarke@users.noreply.github.com [Impeller]
Collapse DrawRects into clear colors optimization (flutter/engine#43168 )
2023-06-29 chinmaygarde@google.com [Impeller] Add trace events to Vulkan
texture and buffer lifecycle events. (flutter/engine#43321 )
2023-06-29 skia-flutter-autoroll@skia.org Roll Dart SDK from
5a59cd06e49d to a7151d73b88d (2 revisions) (flutter/engine#43318 )
2023-06-28 bdero@google.com [Impeller] Fix advanced CPU blend modes
(flutter/engine#43294 )
2023-06-28 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
10hNrVMjnCypybnz2... to fxCNy4QivAngZXkvM... (flutter/engine#43314 )
2023-06-28 skia-flutter-autoroll@skia.org Roll Skia from 0b4f472a8c44 to
26fa4b343fd3 (2 revisions) (flutter/engine#43306 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 10hNrVMjnCyp to fxCNy4QivAng
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-28 22:27:39 -07:00
engine-flutter-autoroll
7b47ba1ef9
Roll Flutter Engine from 241ca5c1d6be to 4e49b9deb72d (1 revision) ( #129730 )
...
241ca5c1d6...4e49b9deb7jonahwilliams@google.com [Impeller] remove redundant highp
modifiers in vertex shaders. (flutter/engine#43305 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-28 21:37:55 -07:00
Jackson Gardner
1b887c72b5
Skwasm benchmarks. ( #129681 )
...
This enables benchmarks for the Skwasm renderer, compiled with
dart2wasm.
Platform views aren't supported in Skwasm yet, so we are skipping those
benchmarks for now.
2023-06-28 17:16:19 -07:00
Justin McCandless
c7511664e2
RTL InputDecoration fix ( #129661 )
...
Fixes InputDecoration (TextField) layout when 1. RTL 2. prefixIcon and 3. left/right contentPadding is asymmetric.
2023-06-28 16:31:51 -07:00
Christopher Fujino
c1b764a80f
mark autoroller flaky ( #129745 )
...
Unblock tree while I investigate: https://github.com/flutter/flutter/issues/129744
2023-06-28 23:26:56 +00:00
Flutter GitHub Bot
ba636881eb
Roll pub packages ( #129380 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2023-06-28 14:07:50 -07:00
pdblasi-google
af09b57e20
Removes deprecated APIs from AnimationBuilder ( #129657 )
...
Removes deprecated APIs from AnimationBuilder.
Resolves #129653
2023-06-28 20:12:19 +00:00
engine-flutter-autoroll
51bef1b632
Roll Flutter Engine from e8a1c23d66ba to 241ca5c1d6be (1 revision) ( #129725 )
...
e8a1c23d66...241ca5c1d6skia-flutter-autoroll@skia.org Roll Skia from 5209dc7702d0 to 0b4f472a8c44 (58 revisions) (flutter/engine#43304 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-28 17:46:25 +00:00
Parker Lougheed
c65e908449
Update analysis, linter, and repo links in analysis options ( #129686 )
...
Contributes to https://github.com/dart-lang/linter/issues/4460 and https://github.com/dart-lang/site-www/issues/4499
2023-06-28 17:30:15 +00:00
engine-flutter-autoroll
73bb959a65
Roll Flutter Engine from be1073aa352f to e8a1c23d66ba (1 revision) ( #129723 )
...
be1073aa35...e8a1c23d66skia-flutter-autoroll@skia.org Roll Dart SDK from e164fdc1a3ad to 5a59cd06e49d (1 revision) (flutter/engine#43302 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-28 16:46:03 +00:00
Hans Muller
0d4b5ae122
Dev, examples/api, etc updated for Material 3 by default ( #129683 )
...
Updated tests in dev, examples/api, and tests/widgets to ensure that
they continue to pass when the default for `ThemeData.useMaterial3` is
changed to true.
This is the final set of changes required for
https://github.com/flutter/flutter/issues/127064 .
2023-06-28 09:41:58 -07:00
Taha Tesser
32fe4d7f0a
Add DatePickerTheme.inputDecorationTheme for the DatePicker with input mode. ( #128950 )
2023-06-28 08:51:53 -07:00
Jonah Williams
9c96357277
[framework] ensure flexible space bar fades when scrolling. ( #129527 )
...
This was missing the actual opacity rendering, oops
2023-06-28 15:33:51 +00:00
Bruno Leroux
8d837062a4
Add InputDecorator.error to allow error message customization ( #129275 )
...
## Description
This PR is a fork of https://github.com/flutter/flutter/pull/118610 with some changes (mainly applying @justinmc comments).
~~This can be used by KishanBusa8 to update https://github.com/flutter/flutter/pull/118610 or can become a non WIP PR if KishanBusa8 does not respond or can not work on the update.~~
## Related Issue
fixes https://github.com/flutter/flutter/issues/11068
## Tests
Adds 3 tests.
2023-06-28 14:57:15 +00:00
engine-flutter-autoroll
b6b417c250
Roll Flutter Engine from b388e852be44 to be1073aa352f (1 revision) ( #129712 )
...
b388e852be...be1073aa35skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from sBFKkha8HNLZpTNwv... to cytps4RRhs8-wbcVJ... (flutter/engine#43300 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from sBFKkha8HNLZ to cytps4RRhs8-
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-28 13:53:39 +00:00
