David Martos
63018fe6cb
Relax the warning of unavailable tokens in gen_defaults when a default value is provided ( #140872 )
...
Fixes some false positives and false negatives from the `gen_defaults` tool regarding unavailable tokens in the Material spec.
Fixes #140871
# Before
# After
These new issues that are logged are being fixed in https://github.com/flutter/flutter/pull/140573
---
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2024-01-23 09:35:22 +00:00
engine-flutter-autoroll
aac6f33e51
Roll Flutter Engine from 37f68f6fc7fc to d2855da628da (1 revision) ( #142033 )
...
37f68f6fc7...d2855da628flutter/engine#49961 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-23 06:57:07 +00:00
engine-flutter-autoroll
5fbf951555
Roll Flutter Engine from 9e582c9032e5 to 37f68f6fc7fc (1 revision) ( #142027 )
...
9e582c9032...37f68f6fc7matanlurey@users.noreply.github.com Change how OpenGL textures are flipped in the Android embedder. (flutter/engine#49938 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-23 02:56:37 +00:00
engine-flutter-autoroll
676e322616
Roll Flutter Engine from df6b15d35703 to 9e582c9032e5 (1 revision) ( #142026 )
...
df6b15d357...9e582c9032skia-flutter-autoroll@skia.org Roll Dart SDK from 9470ea6b00a5 to 5bd0742466d2 (1 revision) (flutter/engine#49951 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-23 02:02:30 +00:00
engine-flutter-autoroll
5978d6bdb6
Roll Flutter Engine from d3dbd4225e08 to df6b15d35703 (6 revisions) ( #142023 )
...
d3dbd4225e...df6b15d357jonahwilliams@google.com [Impeller] dont emulate command buffers for compute on Metal/Vulkan. (flutter/engine#49922 )
2024-01-22 30870216+gaaclarke@users.noreply.github.com [Impeller] fixed colorspace for metal screenshots (flutter/engine#49941 )
2024-01-22 jonahwilliams@google.com [Impeller] remove frame counter that was unused in Vulkan allocator. (flutter/engine#49913 )
2024-01-22 jason-simmons@users.noreply.github.com [Impeller] Create the golden test screenshotter after setting the Vulkan ICD environment variable (flutter/engine#49948 )
2024-01-22 737941+loic-sharma@users.noreply.github.com [Windows] Rename and move EGL types (flutter/engine#49900 )
2024-01-22 skia-flutter-autoroll@skia.org Roll Skia from fa5f2461554f to 58973cca0edd (2 revisions) (flutter/engine#49947 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-23 01:18:27 +00:00
Ian Hickson
5dc3b1894f
Add a comment about how to test flutter_goldens ( #141902 )
...
This is part 2 of a broken down version of the #140101 refactor.
This particular change wasn't in that original refactor but is a note to myself so that I remember how to test each of these changes in the future.
2024-01-23 00:49:07 +00:00
Ian Hickson
15ceca93a4
Enable contextMenuBuilder in the absence of selectionControls ( #141810 )
2024-01-23 00:49:05 +00:00
engine-flutter-autoroll
38be13765f
Roll Flutter Engine from b069d7f8f1fd to d3dbd4225e08 (3 revisions) ( #142005 )
...
b069d7f8f1...d3dbd4225emdebbar@google.com [web] Bootstrap tests without implicit view by default (flutter/engine#48629 )
2024-01-22 skia-flutter-autoroll@skia.org Roll Skia from bbb0d6feaf1c to fa5f2461554f (1 revision) (flutter/engine#49945 )
2024-01-22 skia-flutter-autoroll@skia.org Roll Dart SDK from dc389e4a01f3 to 9470ea6b00a5 (1 revision) (flutter/engine#49944 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-23 00:34:38 +00:00
auto-submit[bot]
b258ca011e
Reverts "hello_world app: migrate to Gradle Kotlin DSL" ( #142018 )
...
Reverts flutter/flutter#141541
Initiated by: yusuf-goog
This change reverts the following previous change:
Original Description:
This PR introduces the first app in this repo that fully uses Gradle Kotlin DSL.
It also fixes a bug I found in the process – fields of `FlutterExtensions` must be `public`.
2024-01-23 00:01:17 +00:00
Justin McCandless
0f7f08d535
Floating cursor docs ( #133002 )
...
Explains what a "floating cursor" is in the docs.
2024-01-22 14:17:29 -08:00
Gustl22
a98e43a871
refactor: Rename filterPluginsByPlatform, cleanup Platform Strings ( #141780 )
...
Part of #137040 and #80374
- Rename _filterPluginsByPlatform to _createPluginMapOfPlatform
- Move method in chronological order
- Cleanup platform strings
2024-01-22 21:54:06 +00:00
Bartek Pacia
e593cdfb80
hello_world app: migrate to Gradle Kotlin DSL ( #141541 )
...
This PR introduces the first app in this repo that fully uses Gradle Kotlin DSL.
It also fixes a bug I found in the process â fields of `FlutterExtensions` must be `public`.
2024-01-22 21:47:20 +00:00
engine-flutter-autoroll
ab26090ac9
Roll Flutter Engine from b2762f410840 to b069d7f8f1fd (4 revisions) ( #141993 )
...
b2762f4108...b069d7f8f1skia-flutter-autoroll@skia.org Roll Skia from cd6b0ff3596e to bbb0d6feaf1c (1 revision) (flutter/engine#49943 )
2024-01-22 30870216+gaaclarke@users.noreply.github.com [Impeller] fixed CanRenderClippedRuntimeEffects for vulkan (flutter/engine#49912 )
2024-01-22 737941+loic-sharma@users.noreply.github.com [Windows] Fix resize crash (flutter/engine#49935 )
2024-01-22 skia-flutter-autoroll@skia.org Roll Skia from be066a6524ab to cd6b0ff3596e (3 revisions) (flutter/engine#49939 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-22 21:45:13 +00:00
Matan Lurey
3b1e96e074
Remove duplicate code as suggested by natebosch. ( #141988 )
...
See https://github.com/flutter/flutter/pull/141821/files#r1462288131 .
2024-01-22 13:08:36 -08:00
Jesús S Guerrero
a3cd05c6d3
Revert "Remove hack from PageView." ( #141977 )
...
Reverts flutter/flutter#141533
b/321743868
2024-01-22 20:14:44 +00:00
engine-flutter-autoroll
b037eeb5c8
Roll Flutter Engine from d653559ae183 to b2762f410840 (3 revisions) ( #141978 )
...
d653559ae1...b2762f410832242716+ricardoamador@users.noreply.github.com Add Mac cache_builder back into Prod (flutter/engine#49936 )
2024-01-22 skia-flutter-autoroll@skia.org Roll Skia from cc042f38288e to be066a6524ab (2 revisions) (flutter/engine#49937 )
2024-01-22 bdero@google.com [Impeller] Reland: Switch from transient stencil-only to depth+stencil buffer. (flutter/engine#49838 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-22 19:54:23 +00:00
Matan Lurey
0b2269447f
Do not hang on test failures of tests within flutter_tools ( #141821 )
...
Fixes https://github.com/flutter/flutter/issues/141823
Before this change, when a test would fail, the terminal would hang (by default for 30s) until killed by the test runner.
Basically, [`runZonedGuarded`](https://api.flutter.dev/flutter/dart-async/runZonedGuarded.html ) _does_ document (though not clearly) that a returned future should not be awaited:
```txt
The zone will always be an error-zone ([Zone.errorZone](https://api.flutter.dev/flutter/dart-async/Zone/errorZone.html )), so returning a future created inside the zone, and waiting for it outside of the zone, will risk the future not being seen to complete.
```
For example, you can see other places in Dart and Flutter that we circumvent that problem:
- 5987563e4a/packages/flutter_tools/test/general.shard/base/async_guard_test.dart (L279-L306)b04c9c127f/lib/src/dartdoc.dart (L258-L264)d1afda52d2/lib/web_ui/dev/browser_process.dart (L20-L22)
2024-01-22 19:49:59 +00:00
Greg Spencer
0dea82e684
Remove unneeded expectation in test ( #141822 )
...
## Description
This removes an unneeded expectation in the test for the AppLifecycleListener. It's unneeded because the test immediately resets the state anyhow. I'm removing it because the web implementation sets the value when initializing, so it's never initially null there.
## Related PR
- https://github.com/flutter/engine/pull/44720#issuecomment-1898482363
2024-01-22 19:46:10 +00:00
engine-flutter-autoroll
1f8085d8bb
Roll Flutter Engine from 1efe8ba6bc04 to d653559ae183 (3 revisions) ( #141972 )
...
1efe8ba6bc...d653559ae1bdero@google.com [Impeller] Add golden for Image ColorSource effect transform. (flutter/engine#49930 )
2024-01-22 skia-flutter-autoroll@skia.org Roll Skia from 9cb4de5da15a to cc042f38288e (1 revision) (flutter/engine#49934 )
2024-01-22 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from p0njgljtokVLYfzqK... to uQK4l0QeH_PlZO6cF... (flutter/engine#49933 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from p0njgljtokVL to uQK4l0QeH_Pl
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-22 18:32:01 +00:00
Jonas Uekötter
174bbf254b
Add documentation which explains that debugPrint also logs in release mode ( #141595 )
...
It's confusing that `debugPrint` also prints in release mode, given that a lot (most?) other things prefixed with `debug` don't do anything in release mode. Therefore, this adds some documentation that this is indeed logging in release mode and adds an example how to disable this.
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2024-01-22 18:24:38 +00:00
Taha Tesser
5aa6cb857d
Fix RangeSlider throws a null-check error after clearSemantics is called ( #141965 )
...
fixes [Null-check operator on RangeSlider's _startSemanticsNode](https://github.com/flutter/flutter/issues/141953 )
2024-01-22 18:21:31 +00:00
engine-flutter-autoroll
cf8d20f70f
Roll Flutter Engine from c49989292fc1 to 1efe8ba6bc04 (1 revision) ( #141969 )
...
c49989292f...1efe8ba6bcskia-flutter-autoroll@skia.org Roll Dart SDK from 7a91ef52d200 to dc389e4a01f3 (3 revisions) (flutter/engine#49932 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-22 17:40:21 +00:00
Hassan Toor
59e892d391
[web] - Fix broken TextField in semantics mode when it's a sibling of Navigator ( #138446 )
...
When a `TextField` is rendered before a `Navigator`, it breaks in semantics mode. This is because the framework generates the incorrect semantics tree (excludes the TextField) and when that tree gets sent to the engine, we don't get the signal to create the corresponding `<input>` element.
This happens for a few reasons:
* `ModalBarrier` uses `BlockSemantics` to drop the semantics of routes beneath the current route in `Navigator`
* `ModalBarrier` mistakenly recognizes the widget outside of the `Navigator` to be its sibling
* So we end up dropping the semantics node of the `TextField` rendered before it.
The fix is to let `Navigator` generate a semantics node so that `ModalBarrier` doesn't mistakenly think widgets outside of `Navigator` are its siblings.
`Navigator` doesn't currently do this, which causes all the nodes generated from its widget subtree to be directly attached to the parent semantics node above `Navigator` - since this is also the parent of `TextField`, it considers them siblings.
Fixes https://github.com/flutter/flutter/issues/129324
2024-01-22 17:03:14 +00:00
engine-flutter-autoroll
3ee8ff287a
Roll Flutter Engine from 40c5e9ce6596 to c49989292fc1 (1 revision) ( #141966 )
...
40c5e9ce65...c49989292fskia-flutter-autoroll@skia.org Roll Skia from f4b79968de2a to 9cb4de5da15a (1 revision) (flutter/engine#49931 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-22 16:53:29 +00:00
engine-flutter-autoroll
bfa245fa34
Roll Packages from 129e08c1dff1 to e4cbf235ec4d (11 revisions) ( #141962 )
...
129e08c1df...e4cbf235ecengine-flutter-autoroll@skia.org Roll Flutter from ddf60fb08733 to 5dea6b994e8f (5 revisions) (flutter/packages#5951 )
2024-01-21 stuartmorgan@google.com Update platform label rules for shared iOS/macOS (flutter/packages#5801 )
2024-01-20 stuartmorgan@google.com [pigeon] Support other hosts in generated file CI checks (flutter/packages#5944 )
2024-01-20 stuartmorgan@google.com [pigeon] Improve style of generated Swift code (flutter/packages#5938 )
2024-01-20 engine-flutter-autoroll@skia.org Roll Flutter from 684247a3c78a to ddf60fb08733 (12 revisions) (flutter/packages#5949 )
2024-01-20 41930132+hellohuanlin@users.noreply.github.com [camera]fix a sample buffer memory leak on pause resume recording (flutter/packages#5927 )
2024-01-19 magder@google.com [ci] Run Swift formatter and linter during CI formatting (flutter/packages#5928 )
2024-01-19 engine-flutter-autoroll@skia.org Manual roll Flutter from f77f82435a97 to 684247a3c78a (39 revisions) (flutter/packages#5948 )
2024-01-19 john@johnmccutchan.com Expose registered widget libraries and local widget library widgets. (flutter/packages#5936 )
2024-01-19 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.1.0 to 4.2.0 (flutter/packages#5937 )
2024-01-19 engine-flutter-autoroll@skia.org Manual roll Flutter (stable) from ef1af02aead6 to 67457e669f79 (1 revision) (flutter/packages#5932 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-22 15:45:08 +00:00
Tess Strickland
7ca4b7b86b
Mark defaultTargetPlatform as constant for non-debug non-web builds. ( #141105 )
...
This PR adds the Dart VM `vm:platform-const-if` pragma introduced in
https://github.com/dart-lang/sdk/commit/57a1168875 to the
`defaultTargetPlatform` property, allowing it to be computed as if it
was a constant field in non-debug AOT builds. In particular, this means
that platform-specific code executed conditionally based on this
property can be tree-shaken in release builds. Note that this PR changes
`defaultTargetPlatform` to only allow overriding via
`debugDefaultTargetPlatformOverride` in debug builds, and makes it so
that compilation throws an error if code assigns
to`debugDefaultTargetPlatformOverride` in other build modes.
Related issue: #14233
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] All existing and new tests are passing.
2024-01-22 14:49:47 +01:00
Taha Tesser
9574d585e3
Fix shape and collapsedShape isn't applied to ExpansionTile's splash ink ( #141777 )
...
This updates the previous attempt https://github.com/flutter/flutter/pull/135855 and removes the complications when testing M3 ink sparkle effect.
Thanks to this [PR](https://github.com/flutter/flutter/pull/138757 ) by @Piinks
fixes [ExpansionTile InkSplash doesn't respect Shape's borderRadius](https://github.com/flutter/flutter/issues/125779 )
fixes [`ExpansionTile.backgroundColor` & `ExpansionTile.collapsedBackgroundColor` removes splash effect](https://github.com/flutter/flutter/issues/107113 )
### Code sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() => runApp(const MyApp());
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return const MaterialApp(
debugShowCheckedModeBanner: false,
home: Example(),
);
}
}
class Example extends StatelessWidget {
const Example({super.key});
@override
Widget build(BuildContext context) {
return const Scaffold(
body: Center(
child: Padding(
padding: EdgeInsets.symmetric(horizontal: 24.0),
child: ExpansionTile(
collapsedBackgroundColor: Color(0x25ff0000),
backgroundColor: Color(0x250000ff),
collapsedShape: RoundedRectangleBorder(
borderRadius: BorderRadius.all(Radius.circular(30.0)),
side: BorderSide(color: Colors.black, width: 2.0),
),
shape: RoundedRectangleBorder(
borderRadius: BorderRadius.all(Radius.circular(30.0)),
side: BorderSide(color: Colors.black, width: 2.0),
),
clipBehavior: Clip.hardEdge,
title: Text('Expansion Tile'),
children: <Widget>[
FlutterLogo(size: 50),
FlutterLogo(size: 50),
FlutterLogo(size: 50),
FlutterLogo(size: 50),
],
),
)),
);
}
}
```
</details>
### Before
<img width="789" alt="Screenshot 2024-01-18 at 18 16 15" src="https://github.com/flutter/flutter/assets/48603081/8c6a6f1e-6986-4acf-8dec-e223a682c0d7 ">
<img width="789" alt="Screenshot 2024-01-18 at 18 16 44" src="https://github.com/flutter/flutter/assets/48603081/f55f6a26-2128-48a1-b24d-3c14e4f6ecdc ">
### After
<img width="789" alt="Screenshot 2024-01-18 at 18 20 27" src="https://github.com/flutter/flutter/assets/48603081/7ec8b888-7319-460d-8488-9cd44c9246a6 ">
<img width="789" alt="Screenshot 2024-01-18 at 18 20 53" src="https://github.com/flutter/flutter/assets/48603081/80d66d5b-7eb2-4f47-ab4d-d7f469a731fa ">
2024-01-22 11:13:31 +00:00
Daco Harkes
634b326efc
Reapply "Native assets: roll deps" ( #141748 ) ( #141864 )
...
Fixes https://github.com/flutter/flutter/issues/141827
Reland: https://dart-review.googlesource.com/c/sdk/+/346960 has rolled into g3, so the imports should now resolve in g3 as well.
> [!CAUTION]
> _Do NOT merge if "Google Testing" bot didn't run!_
Rolls the packages from https://github.com/dart-lang/native in the native assets implementation.
Most notable we're refactoring `package:native_assets_cli` for `build.dart` use.
Therefore, all imports to that package for Flutter/Dart should be to the implementation internals that are no longer visible for `build.dart` writers. Hence all the import updates.
No behavior in Flutter apps should change.
This PR also updates the template to use the latests version of `package:native_assets_cli` which no longer exposes all the implementation details.
2024-01-22 10:42:15 +00:00
engine-flutter-autoroll
ce97e34d0e
Roll Flutter Engine from 11c585f48b77 to 40c5e9ce6596 (1 revision) ( #141956 )
...
11c585f48b...40c5e9ce65skia-flutter-autoroll@skia.org Roll Skia from 8774ef8a314e to f4b79968de2a (1 revision) (flutter/engine#49929 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-22 10:36:10 +00:00
Taha Tesser
0ef4638822
Update ToggleButtons, ExpansionPanel, and ExpandIcon tests for Material 3 ( #141868 )
...
Updated unit tests for `ToggleButtons`, `ExpansionPanel`, and `ExpandIcon` to have M2 and M3 versions.
More info in #139076
2024-01-22 10:01:05 +00:00
engine-flutter-autoroll
5caa8b8962
Roll Flutter Engine from c485c574fb1d to 11c585f48b77 (1 revision) ( #141952 )
...
c485c574fb...11c585f48bskia-flutter-autoroll@skia.org Roll Skia from 97a00523af28 to 8774ef8a314e (1 revision) (flutter/engine#49927 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-22 08:35:42 +00:00
engine-flutter-autoroll
fb3a1e2bcd
Roll Flutter Engine from a7b207d5a1fe to c485c574fb1d (1 revision) ( #141951 )
...
a7b207d5a1...c485c574fbskia-flutter-autoroll@skia.org Roll Skia from c42ac527ff0e to 97a00523af28 (1 revision) (flutter/engine#49926 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-22 07:21:41 +00:00
engine-flutter-autoroll
5dea6b994e
Roll Flutter Engine from 2b31ad2fb819 to a7b207d5a1fe (1 revision) ( #141945 )
...
2b31ad2fb8...a7b207d5a1skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from kOnlSGX_aTAK7vvLc... to p0njgljtokVLYfzqK... (flutter/engine#49924 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from kOnlSGX_aTAK to p0njgljtokVL
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-21 17:01:23 +00:00
Christopher Fujino
92094802fe
[flutter_tools] update analyze_once_test.dart to be null-safe ( #141790 )
...
Fixes https://github.com/flutter/flutter/issues/141743
I should have made this change in https://github.com/flutter/flutter/pull/124039 , but it escaped my grep search.
2024-01-21 07:54:05 +00:00
林洵锋
f340d207f6
Adjust the position of require File.expand_path ( #141521 )
...
On `Podfile`:
```ruby
flutter_application_path = '../flutter_module'
load File.join(flutter_application_path, '.ios', 'Flutter', 'podhelper.rb')
target 'OCProject' do
# Comment the next line if you don't want to use dynamic frameworks
use_frameworks!
# Pods for OCProject
# install_all_flutter_pods(flutter_application_path)
# install_flutter_engine_pod(flutter_application_path)
# install_flutter_application_pod(flutter_application_path)
install_flutter_plugin_pods(flutter_application_path)
end
post_install do |installer|
flutter_post_install(installer)
end
```
Encountering the following error after executing `pod install`:
```shell
pod install
[!] Invalid `Podfile` file: undefined method `flutter_relative_path_from_podfile' for #<Pod::Podfile:0x000000010e74c520 @defined_in_file=#<Pathname:/Users/lxf/gitHub/flutter_hybrid_bug/OCProject/Podfile>, @internal_hash={}, @root_target_definitions=[#<Pod::Podfile::TargetDefinition label=Pods>], @current_target_definition=#<Pod::Podfile::TargetDefinition label=Pods>>
relative = flutter_relative_path_from_podfile(export_script_directory)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^.
# from /Users/lxf/gitHub/flutter_hybrid_bug/OCProject/Podfile:17
# -------------------------------------------
# # install_flutter_plugin_pods(flutter_application_path)
> install_flutter_application_pod(flutter_application_path)
#
# -------------------------------------------
```
The `flutter_relative_path_from_podfile` method is in `flutter_tools/bin/podhelper.rb`, but now `flutter_tools/bin/podhelper.rb` is only required in `install_all_flutter_pods` in `podhelper.rb.tmpl`.
Sometimes we only need to use the `install_flutter_plugin_pods` method in podhelper.rb. For example, using `Shorebird` in an iOS hybird app scenario, we need to build `Flutter.xcframework` and `App.xcframework` and embed them into the iOS native project. In order to avoid unnecessary conflicts, use `install_flutter_plugin_pods` method to install Flutter plugin pods.
[Shorebird - Code Push In Hybrid Apps](https://docs.shorebird.dev/guides/hybrid-app/ios )
So I adjust the position of `require File.expand_path(File.join('packages', 'flutter_tools', 'bin', 'podhelper'), flutter_root)`.
2024-01-21 06:18:26 +00:00
Yegor
a9faaf2683
Add RadioListItem use-case to a11y_assessments ( #140984 )
...
Adds a use-case screen for `RadioListTile`, similar to the `CheckBoxListTile`. This screen can help test scenarios such as the one reported in https://github.com/flutter/flutter/issues/126805 .
2024-01-21 00:32:34 +00:00
engine-flutter-autoroll
954d30f07f
Roll Flutter Engine from 704ef3399012 to 2b31ad2fb819 (1 revision) ( #141937 )
...
704ef33990...2b31ad2fb8skia-flutter-autoroll@skia.org Roll Skia from 3cac1efbdd7a to c42ac527ff0e (1 revision) (flutter/engine#49921 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-20 18:40:10 +00:00
engine-flutter-autoroll
ddf60fb087
Roll Flutter Engine from 1385f76018ab to 704ef3399012 (1 revision) ( #141932 )
...
1385f76018...704ef33990skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from geXIwPzzJiSXrZEEb... to kOnlSGX_aTAK7vvLc... (flutter/engine#49919 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from geXIwPzzJiSX to kOnlSGX_aTAK
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-20 14:40:27 +00:00
engine-flutter-autoroll
3c1cb8acec
Roll Flutter Engine from 6f6649bdfef2 to 1385f76018ab (1 revision) ( #141926 )
...
6f6649bdfe...1385f76018skia-flutter-autoroll@skia.org Manual roll Dart SDK from 8d697eaa395c to 7a91ef52d200 (5 revisions) (flutter/engine#49917 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-20 10:52:22 +00:00
engine-flutter-autoroll
3225cfebbd
Roll Flutter Engine from 4d67f267b115 to 6f6649bdfef2 (1 revision) ( #141920 )
...
4d67f267b1...6f6649bdfeskia-flutter-autoroll@skia.org Roll Skia from 61a2dcff4194 to 3cac1efbdd7a (4 revisions) (flutter/engine#49916 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-20 07:41:18 +00:00
engine-flutter-autoroll
61c3455b5d
Roll Flutter Engine from 53a2436cf75c to 4d67f267b115 (1 revision) ( #141917 )
...
53a2436cf7...4d67f267b1jonahwilliams@google.com [Impeller] Encode directly to command buffer for Metal. (flutter/engine#49785 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-20 04:38:24 +00:00
engine-flutter-autoroll
0d73663d9a
Roll Flutter Engine from a9b87c6288d2 to 53a2436cf75c (1 revision) ( #141916 )
...
a9b87c6288...53a2436cf7jonahwilliams@google.com [Impeller] use string view for labels in more places to defer allocatons. (flutter/engine#49905 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-20 03:32:20 +00:00
engine-flutter-autoroll
3842c24aa6
Roll Flutter Engine from d00e55f7f8ed to a9b87c6288d2 (3 revisions) ( #141914 )
...
d00e55f7f8...a9b87c6288jonahwilliams@google.com [Impeller] null check vertex buffer. (flutter/engine#49915 )
2024-01-19 30870216+gaaclarke@users.noreply.github.com [Impeller] adds vulkan golden images (flutter/engine#49849 )
2024-01-19 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Fuchsia] Redo - Use chromium test-scripts to download images and execute tests" (flutter/engine#49908 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-20 02:42:18 +00:00
LongCatIsLooong
5892a0039b
Remove more textScaleFactor references ( #141816 )
...
Remove more `textScaleFactor` references from flutter/flutter.
- Some changes are related to label scaling: the padding EdgeInsets values of some chip subclasses scale linearly between predetermined "max" padding values and "min" padding values. Before they scale with the `textScaleFactor` scalar, now they scale with the font size and are still capped at the original "max" and "min" values.
- The rest of them are tests or size heuristics that depend on `textScaleFactor`, these are replaced by an effective text scale factor computed using a default font size (which is determined in a pretty random fashion, but it will only make a difference on Android 14+).
No API changes in this batch. There are still some references left that I intend to remove in a different batch that would introduce API changes.
2024-01-20 00:27:18 +00:00
engine-flutter-autoroll
bc254ce3f5
Roll Flutter Engine from 517fc2bbfa51 to d00e55f7f8ed (1 revision) ( #141909 )
...
517fc2bbfa...d00e55f7f8737941+loic-sharma@users.noreply.github.com [Windows] Refactor EGL initialization (flutter/engine#49895 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-19 23:25:26 +00:00
engine-flutter-autoroll
cd6fe510e0
Roll Flutter Engine from f2b441a26416 to 517fc2bbfa51 (2 revisions) ( #141904 )
...
f2b441a264...517fc2bbfaskia-flutter-autoroll@skia.org Roll Skia from fabb71dcf9b7 to 61a2dcff4194 (1 revision) (flutter/engine#49904 )
2024-01-19 skia-flutter-autoroll@skia.org Roll Skia from c09908c48f14 to fabb71dcf9b7 (3 revisions) (flutter/engine#49902 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-19 22:41:23 +00:00
Taha Tesser
788614d171
Fix "Delete" tooltip is shown disabled on chips with onDeleted callback ( #141770 )
...
fixes [Disabled chips with `onDeleted` callback shows "Delete" tooltip on hover](https://github.com/flutter/flutter/issues/141336 )
### Code sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() => runApp(const MyApp());
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return const MaterialApp(
debugShowCheckedModeBanner: false,
home: Example(),
);
}
}
class Example extends StatefulWidget {
const Example({super.key});
@override
State<Example> createState() => _ExampleState();
}
class _ExampleState extends State<Example> {
bool _isEnable = false;
@override
Widget build(BuildContext context) {
return Scaffold(
body: Center(
child: Column(
mainAxisAlignment: MainAxisAlignment.spaceEvenly,
children: <Widget>[
RawChip(
label: const Text('RawChip'),
onPressed: () {},
isEnabled: _isEnable,
onDeleted: () {},
),
FilterChip(
label: const Text('FilterChip'),
selected: false,
onSelected: _isEnable ? (bool value) {} : null,
onDeleted: () {},
),
InputChip(
label: const Text('InputChip'),
isEnabled: _isEnable,
onDeleted: () {},
),
],
),
),
floatingActionButton: FloatingActionButton.extended(
onPressed: () {
setState(() {
_isEnable = !_isEnable;
});
},
label: Text(_isEnable ? 'Disable' : 'Enable'),
),
);
}
}
```
</details>
### Preview
| Before | After |
| --------------- | --------------- |
| <img src="https://github.com/flutter/flutter/assets/48603081/f80ae5f7-0a6d-4041-ade3-cbc2b5c78188 " height="450" /> | <img src="https://github.com/flutter/flutter/assets/48603081/04e62854-e3f1-4b65-9753-183d288f3cfe " height="450" /> |
2024-01-19 22:19:16 +00:00
godofredoc
6f7aed593d
Run module_test_ios on arm and x64 ( #141815 )
...
This will ensure the test runs on the supported platforms.
2024-01-19 22:05:12 +00:00
Qun Cheng
05854afa9b
SearchAnchor search view clear button only shows up when text input is not empty (#141755 )
2024-01-19 13:01:07 -08:00
Reid Baker
684247a3c7
Use Integer instead of int in map in flutter.groovy ( #141895 )
...
packages Roller breakage
https://ci.chromium.org/ui/p/flutter/builders/try/Linux_android%20android_build_all_packages%20master/5504/overview
Fixes flutter/flutter/issues/141897
```
FAILURE: Build failed with an exception.
* Where:
Script '/b/s/w/ir/x/w/flutter/packages/flutter_tools/gradle/src/main/groovy/flutter.groovy' line: 168
* What went wrong:
Could not compile script '/b/s/w/ir/x/w/flutter/packages/flutter_tools/gradle/src/main/groovy/flutter.groovy'.
> startup failed:
script '/b/s/w/ir/x/w/flutter/packages/flutter_tools/gradle/src/main/groovy/flutter.groovy': 168: primitive type parameters not allowed here;
solution: use the corresponding wrapper type, such as Integer for int @ line 168, column 41.
e static final Map<String, int> ABI_VERS
```
Covered by tests in packages.
2024-01-19 20:57:08 +00:00
