skia-flutter-autoroll
62c27dee14
Roll Skia from 8f5808650129 to 37b9f707ce96 (1 revision) ( flutter/engine#52544 )
...
https://skia.googlesource.com/skia.git/+log/8f5808650129..37b9f707ce96
2024-05-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 1526c466aadc to bb6365e1dcd3 (5 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-03 12:52:20 +00:00
skia-flutter-autoroll
bd6faa1151
Roll Fuchsia Linux SDK from cScmnvKM3py9E2087... to QDv0tal7_BgoZx0ju... ( flutter/engine#52543 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-03 11:46:21 +00:00
skia-flutter-autoroll
b5b17ff361
Roll Dart SDK from 138695ec00bd to 33bb0f4b0770 (1 revision) ( flutter/engine#52542 )
...
https://dart.googlesource.com/sdk.git/+log/138695ec00bd..33bb0f4b0770
2024-05-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-129.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-03 08:12:03 +00:00
skia-flutter-autoroll
3833b53247
Roll Skia from d2f0fd0faf90 to 8f5808650129 (1 revision) ( flutter/engine#52541 )
...
https://skia.googlesource.com/skia.git/+log/d2f0fd0faf90..8f5808650129
2024-05-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 1092e40f5ba5 to 252d184177c3 (5 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-03 06:29:21 +00:00
skia-flutter-autoroll
85098823f6
Roll Skia from 2eaea0383201 to d2f0fd0faf90 (1 revision) ( flutter/engine#52540 )
...
https://skia.googlesource.com/skia.git/+log/2eaea0383201..d2f0fd0faf90
2024-05-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 1092e40f5ba5 to 252d184177c3
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-03 04:27:25 +00:00
skia-flutter-autoroll
5d228f845b
Roll Dart SDK from 03b7868a71ae to 138695ec00bd (1 revision) ( flutter/engine#52539 )
...
https://dart.googlesource.com/sdk.git/+log/03b7868a71ae..138695ec00bd
2024-05-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-128.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-03 04:09:19 +00:00
Dustin Green
561a3c968b
[fuchsia] route fuchsia.sysmem2.Allocator pt 2 ( flutter/engine#52509 )
...
Fuchsia's fake-display will be migrating to sysmem2, which requires
fuchsia.sysmem2.Allocator to be routed.
fixes https://github.com/flutter/flutter/issues/146858
2024-05-02 18:43:30 -07:00
Jason Simmons
1b28d5a898
[et] Add Linux host_debug_unopt local engine builder ( flutter/engine#52538 )
2024-05-03 01:34:30 +00:00
Brandon DeRosier
5b35095a8e
[et] Add ios_debug_unopt build config. ( flutter/engine#52537 )
...
Resolves https://github.com/flutter/flutter/issues/147757
2024-05-03 01:28:22 +00:00
skia-flutter-autoroll
4be76bcc06
Roll Skia from df970dcd6cfa to 2eaea0383201 (1 revision) ( flutter/engine#52536 )
...
https://skia.googlesource.com/skia.git/+log/df970dcd6cfa..2eaea0383201
2024-05-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 23709f0474fe to 1526c466aadc (5 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-03 01:14:16 +00:00
Brandon DeRosier
7130c5c3b3
[Impeller] Remove Entity capture/AiksInspector. ( flutter/engine#52526 )
...
Resolves https://github.com/flutter/flutter/issues/134748 .
This was a really fun experiment. I learned a lot from it, and it genuinely helped me solve some coverage-related problems, but the reality is it was too little too late -- by the time we had this capture system, we had already solved most of the problems that would have benefitted from this.
It's been a few months since I've used or extended the capabilities of this capture system for something, and I don't have the spare time/energy to give it the love it needs to realize the vision I had for it. I still almost exclusively use a combination of native frame captures and print debugging to solve problems.
RIP in peace.
2024-05-03 01:08:22 +00:00
skia-flutter-autoroll
c00314985f
Roll Dart SDK from 0316fa44b401 to 03b7868a71ae (1 revision) ( flutter/engine#52534 )
...
https://dart.googlesource.com/sdk.git/+log/0316fa44b401..03b7868a71ae
2024-05-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-127.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-03 00:03:21 +00:00
skia-flutter-autoroll
0610180714
Roll Skia from 716e757c1ffb to df970dcd6cfa (1 revision) ( flutter/engine#52533 )
...
https://skia.googlesource.com/skia.git/+log/716e757c1ffb..df970dcd6cfa
2024-05-02 armansito@google.com [viewer] Add `disable_tint_symbol_renaming` option
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-02 23:54:30 +00:00
Harry Terkelsen
b28f8f5c42
[canvaskit] Round physical size to nearest whole number pixels ( flutter/engine#52467 )
...
The physical size is computed by multiplying the browser's `innerWidth`
and `innerHeight` by the `devicePixelRatio`. The physical size should be
an integer number of pixels. However, there may be some imprecision and
the result of the multiplication is not quite an integer. This change
rounds the physical size to integers before using them for drawing the
scene.
Fixes https://github.com/flutter/flutter/issues/144869
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2024-05-02 16:16:50 -07:00
gaaclarke
3892592ee1
Updated RBE documentation for default credentials. ( flutter/engine#52530 )
...
issue https://github.com/flutter/flutter/issues/147739
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-05-02 22:03:23 +00:00
Juanjo Tugores
3ec84538ca
Put the view focus functionality behind a (disabled by default) flag ( flutter/engine#52527 )
...
Put the view focus functionality behind a (disabled by default) flag
Should unblock https://github.com/flutter/flutter/pull/143259
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-05-02 21:27:23 +00:00
skia-flutter-autoroll
68f57e4fc2
Roll Skia from f9671ecda7da to 716e757c1ffb (5 revisions) ( flutter/engine#52528 )
...
https://skia.googlesource.com/skia.git/+log/f9671ecda7da..716e757c1ffb
2024-05-02 jvanverth@google.com [graphite] Add option to DrawAtlas to allow use of storage textures
2024-05-02 nscobie@google.com Make ATrace backend record arguments as sub-events in Android framework
2024-05-02 bungeman@google.com [fontations] Use CBDT advances
2024-05-02 egdaniel@google.com [Graphite] Fix Emscripten build after label change.
2024-05-02 jvanverth@google.com [graphite] Change GraphiteDawnTestContext to use new devicelost setup
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-02 21:19:08 +00:00
Brandon DeRosier
89f27d1eda
[Impeller] Remove checkerboard. ( flutter/engine#52524 )
...
I added this feature a long time ago on a rainy afternoon, and @gaaclarke mentioned that it's being removed from the framework anyway. We should just remove this if that's the case.
2024-05-02 20:28:35 +00:00
skia-flutter-autoroll
74975dd5df
Roll Skia from 894919003036 to f9671ecda7da (3 revisions) ( flutter/engine#52525 )
...
https://skia.googlesource.com/skia.git/+log/894919003036..f9671ecda7da
2024-05-02 bungeman@google.com [fontations] Properly place CBLC/CBDT glyphs
2024-05-02 robertphillips@google.com Disable GM_matrixconvolution_bigger/_biggest on the Nexus7/Tegra3
2024-05-02 egdaniel@google.com [Graphite] Add initial label support on Textures.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-02 20:08:08 +00:00
skia-flutter-autoroll
0551109034
Roll Dart SDK from 040d3f6c4c45 to 0316fa44b401 (1 revision) ( flutter/engine#52523 )
...
https://dart.googlesource.com/sdk.git/+log/040d3f6c4c45..0316fa44b401
2024-05-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-126.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-02 19:03:21 +00:00
skia-flutter-autoroll
8ca89d7b37
Roll Skia from a0f0c08f31d8 to 894919003036 (2 revisions) ( flutter/engine#52522 )
...
https://skia.googlesource.com/skia.git/+log/a0f0c08f31d8..894919003036
2024-05-02 egdaniel@google.com [Graphite] Add support for setting label on backend Buffers.
2024-05-02 armansito@google.com [graphite] Wire up VelloScene::append
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-02 18:50:18 +00:00
skia-flutter-autoroll
49c8b74ba3
Roll Skia from 4dbf9ad5fa1e to a0f0c08f31d8 (3 revisions) ( flutter/engine#52521 )
...
https://skia.googlesource.com/skia.git/+log/4dbf9ad5fa1e..a0f0c08f31d8
2024-05-02 nicolettep@google.com [graphite] Add convenience method to get SharedContext from RecorderPriv
2024-05-02 sunnyps@chromium.org graphite: Explicitly destroy Dawn buffers
2024-05-02 borenet@google.com Remove Perf-Mac10.15.7-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Release-All-Graphite_Dawn_Metal job
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-02 17:41:23 +00:00
skia-flutter-autoroll
3435d9f4c2
Roll Skia from d37c4d0c5e5d to 4dbf9ad5fa1e (3 revisions) ( flutter/engine#52520 )
...
https://skia.googlesource.com/skia.git/+log/d37c4d0c5e5d..4dbf9ad5fa1e
2024-05-02 jvanverth@google.com [graphite] Add flag to mark Plots as 'full'.
2024-05-02 jvanverth@google.com [graphite] Restructure ComputePathAtlas::recordDispatches to take list
2024-05-02 brianosman@google.com Ignore mipmapping requessts for externally wrapped WebGL textures
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-02 16:36:15 +00:00
Alexander Aprelev
8bd9e60267
Use new Dart_PortEx api to ensure SendPort can be rebuild properly. ( flutter/engine#52498 )
...
Currently used Dart API can not be reliably used to rebuild dart
SendPort object, [new API was introduced in dart sdk
](https://dart.googlesource.com/sdk/+/de4029ee1ba3bc89d839ae7d2fd0706d29abae58 )
and this PR moves flutter engine to use that new API.
BUG: https://github.com/flutter/flutter/issues/147469
2024-05-02 09:06:38 -07:00
skia-flutter-autoroll
730fc72a32
Roll Dart SDK from faabc0c9861c to 040d3f6c4c45 (1 revision) ( flutter/engine#52518 )
...
https://dart.googlesource.com/sdk.git/+log/faabc0c9861c..040d3f6c4c45
2024-05-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-125.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-02 14:40:05 +00:00
skia-flutter-autoroll
f7bbeea2c4
Roll Skia from 6c41182ab9bb to d37c4d0c5e5d (1 revision) ( flutter/engine#52517 )
...
https://skia.googlesource.com/skia.git/+log/6c41182ab9bb..d37c4d0c5e5d
2024-05-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 276647759516 to 23709f0474fe (4 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-02 11:18:38 +00:00
skia-flutter-autoroll
96a99bd466
Roll Dart SDK from c34adf6abcca to faabc0c9861c (1 revision) ( flutter/engine#52515 )
...
https://dart.googlesource.com/sdk.git/+log/c34adf6abcca..faabc0c9861c
2024-05-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-124.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-02 10:28:23 +00:00
skia-flutter-autoroll
1f1e058498
Roll Fuchsia Linux SDK from PIHl-e41i3mzbriG1... to cScmnvKM3py9E2087... ( flutter/engine#52516 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-02 10:24:24 +00:00
skia-flutter-autoroll
5c3698ae87
Roll Skia from 7c68b9c33b08 to 6c41182ab9bb (2 revisions) ( flutter/engine#52513 )
...
https://skia.googlesource.com/skia.git/+log/7c68b9c33b08..6c41182ab9bb
2024-05-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 85cd35a9f8f3 to 1092e40f5ba5 (8 revisions)
2024-05-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 816f6abb4c9a to b94ef82a4b1e (20 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-02 06:33:57 +00:00
skia-flutter-autoroll
eae48c9510
Roll Dart SDK from 30b5422ec1b2 to c34adf6abcca (1 revision) ( flutter/engine#52512 )
...
https://dart.googlesource.com/sdk.git/+log/30b5422ec1b2..c34adf6abcca
2024-05-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-123.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-02 06:27:03 +00:00
skia-flutter-autoroll
c57aa98eae
Roll Skia from 97aa3f4cf290 to 7c68b9c33b08 (1 revision) ( flutter/engine#52511 )
...
https://skia.googlesource.com/skia.git/+log/97aa3f4cf290..7c68b9c33b08
2024-05-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 8cb1d9ce0d7a to 1092e40f5ba5
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-02 05:29:15 +00:00
Jonah Williams
bea69e9024
[Impeller] allow for one more active swapchain image. ( flutter/engine#52505 )
...
Currently the rendering performance is less stable with this patch: https://flutter-flutter-perf.skia.org/e/?queries=device_type%3DPixel_7_Pro%26sub_result%3D90th_percentile_frame_rasterizer_time_millis%26sub_result%3D99th_percentile_frame_rasterizer_time_millis%26sub_result%3Daverage_frame_rasterizer_time_millis%26sub_result%3Dworst_frame_rasterizer_time_millis%26test%3Dcomplex_layout_scroll_perf_impeller__timeline_summary&selected=commit%3D40592%26name%3D%252Carch%253Dintel%252Cbranch%253Dmaster%252Cconfig%253Ddefault%252Cdevice_type%253DPixel_7_Pro%252Cdevice_version%253Dnone%252Chost_type%253Dlinux%252Csub_result%253D99th_percentile_frame_rasterizer_time_millis%252Ctest%253Dcomplex_layout_scroll_perf_impeller__timeline_summary%252C
The reason I suspect that is that we're signaling the semaphore at the start of the raster thread. This means that we're limiting the actual number of pending presents to 1, as we also need to account for the CPU access. Increase this and the max texture count to 3, to allow 2 pending presents and one image worked on by the CPU.
2024-05-02 05:05:18 +00:00
Ian Hickson
8966c48831
Remove rasterizerTracingThreshold, checkerboardRasterCacheImages, and checkerboardOffscreenLayers, etc ( flutter/engine#52446 )
2024-05-02 04:35:04 +00:00
skia-flutter-autoroll
51b0f37818
Roll Skia from 81ccf3ab27ee to 97aa3f4cf290 (1 revision) ( flutter/engine#52508 )
...
https://skia.googlesource.com/skia.git/+log/81ccf3ab27ee..97aa3f4cf290
2024-05-02 johnstiles@google.com Flatten branches from complex path of analytic_rrect_coverage_fn.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-02 03:09:22 +00:00
skia-flutter-autoroll
869cc3d144
Roll Dart SDK from 04d373e0a99d to 30b5422ec1b2 (1 revision) ( flutter/engine#52507 )
...
https://dart.googlesource.com/sdk.git/+log/04d373e0a99d..30b5422ec1b2
2024-05-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-122.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-02 02:26:45 +00:00
Brandon DeRosier
dfed7164a1
et phone home ( flutter/engine#52506 )
...
<img width="684" alt="image" src="https://github.com/flutter/engine/assets/919017/2dcdc7e9-b0e1-434d-9078-1de6a3d57d35 ">
2024-05-02 01:36:30 +00:00
David Iglesias
829ae71a50
[web] Expose browser_detection through ui_web. ( flutter/engine#52380 )
...
This PR moves the core of `browser_detection.dart` to a location in `dart:ui_web` so it can be used by apps and plugins.
In order for the code to be a little bit tidier in ui_web, it's encapsulated in a singleton instance that can be accessed through `BrowserDetection.instance` or a top level global `browser` in `dart:ui_web`.
## Issues
* Needed to fix: https://github.com/flutter/flutter/issues/128943
* Needed to land: https://github.com/flutter/flutter/pull/147346
## Tests
Updated affected tests. Mostly the update was to call the methods from `web_ui.browser.methodName` rather than a global scope. Also split the tests for this module in two files:
* `engine_browser_detect_test.dart` - with the tests specific to the engine (capability detection, etc...)
* `browser_detect_test.dart` - only the tests pertaining to the "core" of the library.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-05-02 01:20:10 +00:00
Jonah Williams
590b254c1a
[Impeller] remove incremental allocation during filled path tessellation. ( flutter/engine#52401 )
...
Don't allocate a polyline (and resulting std::vectors) when performing convex tessellation. Instead use a listener pattern and iterate through path verbs.
2024-05-02 01:05:55 +00:00
Jackson Gardner
bd471f7a8a
[skwasm] Don't mark the backend texture as mipmapped, since it isn't. ( flutter/engine#52501 )
...
We don't actually produce mipmaps for any of the textures generated through the `TextureSourceImageGenerator`, even if it is requested of us. So we shouldn't mark the texture as mipmapped in this case. This will allow rendering mechanisms to fall back to a non-mipmapped rendering strategy as needed.
2024-05-02 00:08:05 +00:00
skia-flutter-autoroll
a8d6d318eb
Roll Skia from 36ec16922dad to 81ccf3ab27ee (1 revision) ( flutter/engine#52504 )
...
https://skia.googlesource.com/skia.git/+log/36ec16922dad..81ccf3ab27ee
2024-05-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from ae1ce5ca5a1e to 276647759516 (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-01 23:08:20 +00:00
skia-flutter-autoroll
e431e0190d
Roll Dart SDK from f5a429107c87 to 04d373e0a99d (2 revisions) ( flutter/engine#52503 )
...
https://dart.googlesource.com/sdk.git/+log/f5a429107c87..04d373e0a99d
2024-05-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-121.0.dev
2024-05-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-120.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-01 22:14:13 +00:00
skia-flutter-autoroll
8e35d1d21d
Roll Skia from 553b6e2eddc5 to 36ec16922dad (2 revisions) ( flutter/engine#52502 )
...
https://skia.googlesource.com/skia.git/+log/553b6e2eddc5..36ec16922dad
2024-05-01 johnstiles@google.com Move #include "zlib.h" outside of anonymous namespace.
2024-05-01 borenet@google.com [infra] Update GPU driver version for Windows IntelIrisXe machines
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-01 22:06:50 +00:00
Jenn Magder
374dc4a4e3
Migrate PlatformMessageHandlerIos to ARC ( flutter/engine#52226 )
...
Smart pointers support ARC as of https://github.com/flutter/engine/pull/47612 , and the unit tests were migrated in https://github.com/flutter/engine/pull/48162 .
Migrate `PlatformMessageHandlerIos` from MRC to ARC. Clean up the `#include`s.
Part of https://github.com/flutter/flutter/issues/137801 .
2024-05-01 21:07:07 +00:00
chunhtai
c4415fb8e0
macOS fluttertextinputplugin drops selector called if no client ( flutter/engine#52495 )
...
The observed behavior is that if a keypress both reach framework and flutter textinputplugin selector and the keypress handler in framework causes the the textinputplugin to resign first responder, the selector will still go through even if the textinputplugin has already resigned.
The pr makes it so textinputplugin will ignore these selector call
fixes https://github.com/flutter/flutter/issues/143270
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-05-01 20:57:39 +00:00
skia-flutter-autoroll
28c23852af
Roll Skia from 0b31f64bd8d8 to 553b6e2eddc5 (5 revisions) ( flutter/engine#52500 )
...
https://skia.googlesource.com/skia.git/+log/0b31f64bd8d8..553b6e2eddc5
2024-05-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from 4a3a57f4bb79 to 6d0d7269a8c9
2024-05-01 johnstiles@google.com Fix uses of arithmetic conversion on enums.
2024-05-01 brianosman@google.com Add SkPath::addOpenOval
2024-05-01 robertphillips@google.com [graphite] Reduce the SkMatrixConvolutionImageFilter's program combinations
2024-05-01 borenet@google.com [infra] Roll infra, remove python2 hacks
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-01 20:51:54 +00:00
Chinmay Garde
6115e5ac3a
[Impeller] Wire up hardware buffer backed swapchains on Android. ( flutter/engine#52087 )
...
This wires up Android Hardware Buffer backed swapchains on platform that support
it (Android >= 29) with a KHR swapchain fallback (which can be removed later to
save on some binary size if needed).
Some salient features of these swapchains and their differences with the KHR
variant:
* All swapchain images are guaranteed to R8G8B8A8. This could potentially allow
for earlier creation of the context and the PSO libraries.
* All swapchain allocations are lazy. This should greatly reduce the time it
takes to create and resize a swapchain. However, swapchain image acquisition
may take longer for the first few frame where there is no pre-pooled image
available. Resizes should be similarly faster since the swapchain images for
the intermediate sizes are never created.
* Swapchain transients allocations (the attachments for the root render target)
are also lazily allocated.
* Swapchain images are pool and reused. The size of the pool is user specified
(currently 2). If an image in the pool ages past a user supplied value
(currently 1 second), it is collected as well. Applications that don't render
frames for a long period of time should see less memory use because of
swapchain image allocations.
* The present mode of AHB swapchains behave similar to KHR swapchains but with
VK_PRESENT_MODE_MAILBOX_KHR. In cases where there is no application managed
frame pipelining, this might cause images to never be presented if a newer
image is available. This wasted work can only be avoided by application
provided pipelining.
* There are no client side waits during image presentation. Instead, a new type
of fence is wired up that exports its state as a sync file descriptor. The
fence signal operation is enqueued on the client side and the buffer is set on
the surface control. The presentation engine then performs the wait.
* On Qualcomm devices, Chromium seems to be setting vendor specified flags for
opting the hardware buffers into using UBWC. AFAICT, this is similar to AFBC
(and NOT AFRC) on ARM Mali. This has not been wired up since I don't have a
Qualcomm device at the moment and cant verify bandwidth use using GPU
counters. I would also like to verify that UBWC is safe to use to images that
can be used as input attachments.
2024-05-01 19:54:13 +00:00
skia-flutter-autoroll
343400ed74
Roll Skia from bfbd738fb97b to 0b31f64bd8d8 (3 revisions) ( flutter/engine#52492 )
...
https://skia.googlesource.com/skia.git/+log/bfbd738fb97b..0b31f64bd8d8
2024-05-01 borenet@google.com [infra] Use vpython3 package instead of old vpython
2024-05-01 johnstiles@google.com Reject path triangulation after 500,000 self-intersections.
2024-05-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 9384550810a5 to ae1ce5ca5a1e (2 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-01 17:19:22 +00:00
skia-flutter-autoroll
679f0f50fd
Roll Dart SDK from d946408c559a to f5a429107c87 (2 revisions) ( flutter/engine#52487 )
...
https://dart.googlesource.com/sdk.git/+log/d946408c559a..f5a429107c87
2024-05-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-119.0.dev
2024-05-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-118.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-01 16:11:03 +00:00
gaaclarke
4429b2f2fe
[Impeller] Implements retry for Picture.toImage ( flutter/engine#52470 )
...
fixes https://github.com/flutter/flutter/issues/146990
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2024-05-01 08:53:54 -07:00
John McCutchan
1c441f353d
Fix et run ( flutter/engine#52477 )
...
et run was broken in https://github.com/flutter/engine/pull/51803
this PR adds the missing calls to mangledConfigName before invoking flutter run
2024-05-01 14:20:04 +00:00
