20971 Commits

Author SHA1 Message Date
Jonah Williams
61ba7dd218
[flutter_tools] If run fails to install the application on iOS, try uninstalling it and trying again. (#68078) 2020-10-14 09:14:36 -07:00
Per Classon
8a7fd39b85
[Material] Parent checkbox in DataTable should deselect all, if children checkboxes are disabled or selected (#67938) 2020-10-14 08:57:06 -07:00
Jonah Williams
06722679da
[devicelab] mark ios catalina as flaky (#68109) 2020-10-14 08:52:28 -07:00
xubaolin
7eeab2666b
Fix DropdownButton bug (#65915) 2020-10-14 01:52:03 -07:00
HeavenOSK
66cf8d47a3
[Improvement] Add prefix Alignment. for toString of Alignment (#67860)
* modify: add prefix `Alignment.` for toString of Alignment
2020-10-14 13:47:28 +08:00
Jonah Williams
4b351ac1b4
[flutter_tools] do not allow attaching in release mode (#68071)
Do not allow attach in release mode, as there is not VM Service to connect to. Observed in crash reporting as thrown string which is changed to exception below.
2020-10-13 21:29:23 -07:00
engine-flutter-autoroll
7b89af2c4f
Roll Engine from 6cdb2f69a4ef to adf5b59485a9 (14 revisions) (#68072) 2020-10-13 21:22:02 -07:00
Jonah Williams
751459df24
[flutter_tool] support --use-application-binary in flutter drive (#68060)
--use-application-binary allows running with an already built APK. This can be useful for speeding up CI test cases, or in our case eventually supporting some sort of build server. Demonstrate that this works by updating the old gallery test to use it. Fixes #56604

Co-authored-by: Jenn Magder <magder@google.com>
2020-10-13 19:27:30 -07:00
godofredoc
f8f6963cd1
Fix docset generation. (#67025)
* Fix docset generation.

* Remove checks to be able to test.

* More logging

* More logging

* More logging.

* more logging.

* More logging.

* Add flags to firebase command.

* Re-enable docset generation.

* Disable firebase step.

* Comment docset to speed up validations.

* Re-enable docset.

* Add back condition to prevent uploading docs from PRs.
2020-10-13 17:06:49 -07:00
Darren Austin
ca065f6456
Migrate more Material framework tests to null safety. (#67790)
* Migrate more Material framework tests to null safety.
2020-10-13 16:48:41 -07:00
Greg Spencer
ef119187d0
Convert some widgets tests to NNBD (#67782)
Migrating some more widget tests to NNBD.
2020-10-13 14:41:24 -07:00
Kate Lovett
085f1daa43
Clean up after large refactor (#67939) 2020-10-13 13:42:02 -07:00
Kate Lovett
46d1b7d8e8
[NNBD] Migrate some Widgets tests (#68034) 2020-10-13 13:07:05 -07:00
Jonah Williams
9e70180f63
[flutter_tools] do not measure progress timeout (#67959)
Remove "This is taking a long time" progress timeout and TimeoutConfiguration.
2020-10-13 13:05:47 -07:00
Jenn Magder
3e0d2741de
Detach debugger when VM connection fails on iOS (#68046) 2020-10-13 12:50:50 -07:00
Jenn Magder
4dffc851bc
Detect ARM macOS arch with sysctl hw.optional.arm64 (#67970) 2020-10-13 12:05:04 -07:00
Michael Goderbauer
0343555af1
Migrate more tests (#68037)
* Migrate more tests

* fix
2020-10-13 12:01:53 -07:00
engine-flutter-autoroll
dbf8cd4b10
Roll Engine from 663440688996 to 6cdb2f69a4ef (3 revisions) (#67995) 2020-10-13 11:42:02 -07:00
Jonah Williams
bdfb07dffd
[flutter_test] export fake from flutter_test (#68032)
Fake has been moved from mockito to test to facilitate NNBD, re-export this from flutter_test
2020-10-13 11:38:00 -07:00
Kate Lovett
e48c9b5553
[NNBD] Migrating some Material tests (#67689) 2020-10-13 11:37:03 -07:00
Jonah Williams
d6d06ed9f0
[flutter_tools] delete applicationPackageStore (#68026)
This class is entirely superseded by the application package factory. Only drive and install use it, and removing it from drive will allow use-application-binary support.
2020-10-13 11:33:55 -07:00
Jonah Williams
1c976933f3
[flutter_tools] support Android Studio 4.1 on Windows (#67992)
Android Studio 4.1 moved the location of the .home file on Windows which is used to located the install directory. This functionality is important because it is how we locate and discover the Android SDK functionality, as well as the appropriate JRE.

fixes #67986
2020-10-13 11:33:26 -07:00
Miguel Beltran
1aaa455f1b
Fix for "Pass RouteSettings to the internal Route in showCupertinoModalPopup" (#67990) 2020-10-13 11:32:20 -07:00
xubaolin
4982555982
Add more unit test cases for EditableText widget (#66889) 2020-10-13 11:32:03 -07:00
Jonah Williams
37ebe3d82a
Revert "prevent pageView scrolling when calling ensureVisible (#67988)" (#68036)
This reverts commit 62cf4dbf10a6bd5b01ab6687dedda2df7cdc9b35.
1.23.0-18.0.pre
2020-10-13 10:52:23 -07:00
Ren You
a57f45e080
Revert "More EditableText docs (#66864)" (#68025)
This reverts commit daa6b2cc29b5ff1f166660f9e70fb38d6c0de6cc.
2020-10-13 09:08:48 -07:00
xubaolin
62cf4dbf10
prevent pageView scrolling when calling ensureVisible (#67988) 2020-10-12 23:12:02 -07:00
engine-flutter-autoroll
625ffcaaa6
Roll Engine from c2938d06b193 to 663440688996 (2 revisions) (#67987) 2020-10-12 22:07:02 -07:00
Nobuhiro Tabuki
1e180062aa
[flutter_tools] Support IntelliJ 2020.1 and later on Linux and Windows (#58853)
This PR will update IntelliJ IDEA/Community validation logic for 2020.1 and later on Linux and Windows.
2020-10-12 22:03:36 -07:00
engine-flutter-autoroll
081c47b83d
Roll Engine from 11d756a62ed0 to c2938d06b193 (27 revisions) (#67983)
* 85b0031f7 Migration to PlatformDispatcher and multi-window (flutter/engine#20496)

* 0d151816c Remove uses of Dart VM bytecode mode from Flutter engine (flutter/engine#21741)

* 8be6cc039 Roll Skia from 88cda17bbeb8 to 61003cde7688 (4 revisions) (flutter/engine#21744)

* a2046aeb6 Revert "fix On iOS, dialog titles are announced twice (#19826)" (flutter/engine#21714)

* 3bd695b18 Roll Skia from 61003cde7688 to 13fc260c7080 (1 revision) (flutter/engine#21746)

* ca250c972 Roll Fuchsia Mac SDK from lqn8xmlDn... to gzhbqRUap... (flutter/engine#21749)

* 7f0e17b67 Roll Skia from 13fc260c7080 to aa64c352b349 (1 revision) (flutter/engine#21752)

* d97e74c7c Roll Fuchsia Linux SDK from EBX49sN_X... to YRTc9YoiB... (flutter/engine#21753)

* 7fc1a0386 Roll Skia from aa64c352b349 to d71dc2d25b8b (1 revision) (flutter/engine#21758)

* a3f3f989a Roll Fuchsia Mac SDK from gzhbqRUap... to _0R2HD4c8... (flutter/engine#21759)

* d4b8d676f Roll Fuchsia Linux SDK from YRTc9YoiB... to Nw5-0_sVF... (flutter/engine#21760)

* 910ce92e6 Roll Fuchsia Mac SDK from _0R2HD4c8... to 82ankF-Ht... (flutter/engine#21762)

* bd03014c2 Roll Fuchsia Mac SDK from 82ankF-Ht... to FFpTJfmj1... (flutter/engine#21768)

* f230fded7 Use buildroot clang for scenario app (flutter/engine#21690)

* 766d68282 Roll Fuchsia Linux SDK from Nw5-0_sVF... to h-DeV4tgE... (flutter/engine#21771)

* cff4ee74a Roll Skia from d71dc2d25b8b to ceb6214a556a (5 revisions) (flutter/engine#21772)

* fd1ba9ccf Ignore analysis warning for doc comment (flutter/engine#21773)

* 978cfd6d5 Roll Skia from ceb6214a556a to 9213e610ed92 (8 revisions) (flutter/engine#21774)

* 106842989 Roll Dart SDK from 06536d68ca0f to e256855d07ba (6 revisions) (flutter/engine#21775)

* 190fd8eb5 Reland "Create root isolate asynchronously (#20142)" (flutter/engine#21747)

* 10ed56318 Roll Skia from 9213e610ed92 to 840e8ea7403e (11 revisions) (flutter/engine#21779)

* e18cd9687 Roll Skia from 840e8ea7403e to ab6e62c131e9 (7 revisions) (flutter/engine#21783)

* 931a04683 Fix documentation build for window changes. (flutter/engine#21780)

* 38d8ebaa4 E2e screenshot tests2 (flutter/engine#21383)

* d912d502d [null-safety] fix build rule to produce sound dill (flutter/engine#21784)

* 05d97932b Extract a TextRange class for selection (flutter/engine#21722)

* c2938d06b Revert "Migration to PlatformDispatcher and multi-window #20496" (flutter/engine#21792)
2020-10-12 21:03:20 -07:00
Jonah Williams
ac751cc50c
[flutter_tools] verify checksum of downloaded artifacts (#67839)
All of the network requests from google cloud storage include an x-goog-hash header which contains an MD5 checksum. If present, use to validate that the downloaded binary is valid. This will rule out corrupt files as the cause of getting started crashers in the flutter_tool.

#38980

This does not fully resolve the above issue, because while we can check if the checksum matches what was expected from cloud storage, this A) may not necessarily be present and B) may not match up to what should be uploaded as part of the engine build process.

But when life gives you lemons you hash those lemons using an outdated hashing algorithm.
2020-10-12 17:44:23 -07:00
Jonah Williams
eb24393efe
remove missing argument (#67974) 2020-10-12 17:18:09 -07:00
Jonah Williams
5dfe7e6d51
[flutter_tools] attempt to stabilize hot restart benchmark the old fashioned way (#67971)
A change which sped up hot restart locally caused many of the devicelab measures to regress. I think this is because we do not measure when the isolate is actually "ready", so starting a reload or restart prematurely can cause time spent doing initialization to be registered as part of the reload operation.

A fix for this would be to have the framework include some sort of "initialization complete" event ... but it is not clear what the correct trigger would be. Perhaps after the first frame is successfully registered?

(9a3a0dc caused the benchmark regression - possibly since we spend less time syncing files now so we start the restart earlier)
2020-10-12 17:00:26 -07:00
Shi-Hao Hong
46238de8c5
[NNBD] Migrate some Material tests to NNBD (#67887)
Migrates the following files to NNBD: 
* input_decorator_test.dart
* list_tile_test.dart
* localizations_test.dart
* material_button_test.dart
* material_state_property_test.dart
* material_test.dart
* mergeable_material_test.dart
2020-10-13 07:57:23 +08:00
Shi-Hao Hong
244f5ab598
Expose date symbols and patterns for en_US in framework (#67900)
* Expose date symbols and patterns for en_US in framework
2020-10-13 07:56:10 +08:00
Jonah Williams
8aee75f645
Revert "Pass RouteSettings to the internal Route in showCupertinoModalPopup (#56024)" (#67969)
This reverts commit da58f5e6fe034f8edfa1adc08debcb92d42e2a68.
2020-10-12 16:09:20 -07:00
Miguel Beltran
da58f5e6fe
Pass RouteSettings to the internal Route in showCupertinoModalPopup (#56024) 2020-10-12 15:53:54 -07:00
Jonah Williams
18bb4d7254
Revert "[flutter_tools] reland: fold process resolution logic into the flutter tool (#67957)" (#67968)
This reverts commit bd8138797e445627d7a92ec139ac661af1b6b584.
2020-10-12 15:53:16 -07:00
Jonah Williams
52f8b89c0e
[flutter_tools] dont allow creating package name that is invalid (#67786)
According to https://dart.dev/tools/pub/pubspec#name , uppercase is not permitted for package names.
2020-10-12 15:38:23 -07:00
Jonah Williams
bd8138797e
[flutter_tools] reland: fold process resolution logic into the flutter tool (#67957)
Reland of #67669

The flutter tool has a number of crashes on stable where an ArgumentError is thrown due to the process manager not being able to resolve an executable.

So that we can adjust/modify this logic, fold it into flutter and add some additional logging.
caches the resolved executable per target directory, to avoid repeated look ups.
Instead of throwing an argument error, attempts to run the executable as given if an exact path can't be found
Accept files or symlinks for the executable path.
user where/which to resolve path instead of package:process logic.
2020-10-12 15:37:02 -07:00
Jonah Williams
c606f044d7
[gestures] make stylus pointer types use touch pan/drag slop (#67885) 2020-10-12 15:20:50 -07:00
Dan Field
b6c56fdeaf
Add test for TabBarView (#67799) 2020-10-12 14:25:17 -07:00
Hans Muller
6219b30850
Replace obsolete FlatButton reference in flutter_driver extension_test.dart (#67952) 2020-10-12 14:22:13 -07:00
Kate Lovett
9464661a98
Fix sample code (#67940) 2020-10-12 14:22:03 -07:00
Anurag Roy
7f1540f323
Add contentPadding property for RadioListTile (#67438)
Exposes contentPadding property for RadioListTile from its appropriate ListTile.
2020-10-12 14:22:01 -07:00
Michael Goderbauer
053ebf2c08
Make CupertinoTabScaffold restorable (#67770) 2020-10-12 14:17:02 -07:00
LongCatIsLooong
daa6b2cc29
More EditableText docs (#66864) 2020-10-12 14:12:06 -07:00
xubaolin
dd41f41f34
CupertinoTextField should not accept requestFocus when disabled (#65235) 2020-10-12 14:07:05 -07:00
Jonah Williams
408cd71d82
[flutter_tools] check asset files while the tool waits for the frontend_server compile (#67826)
On every hot reload, the flutter tool must file stat each asset in the bundle. With a large number of assets or a slow file system, this can take 20 - 30 ms. Do this operation while the flutter tool is waiting for a response from the frontend_server.

No tests updated since this is only a timing update. Any difference in behavior will be shown on benchmarks
2020-10-12 14:06:40 -07:00
Jonah Williams
354e2a57b1
Revert "[flutter_tools] fold executable resolution into flutter (#67669)" (#67954)
This reverts commit 10c78c264a6d269b42e6174edde55f670d531525.
2020-10-12 13:15:39 -07:00