DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
32,134 Commits 882 Branches 1,069 Tags
Commit Graph

32134 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Matej Knopp
6054dbd0cb [macOS] Fix tests failing on Sonoma (flutter/engine#46461) 
1. Using arbitrary struct passed as const reference  to `OCMStub` now fails in OCMock. Down the line this will result with `object_getClass` being called in [`OCMArg.m`](https://github.com/erikdoe/ocmock/blob/master/Source/OCMock/OCMArg.m#L129-L133) with the address of the reference, which is not a valid class instance. This seems to have worked pre-sonoma, but it seems like a weird thing to rely on.

2. `NSResponder` mock can not be set to view controller anymore. The controller will try to access an ivar of the `NSResponder`, but mocked responder does not have the ivar of original objects which will result on invalid selector being called on a `NSMutableArray` one of the ivar of mock objects. Solution for this is to inherit from `NSResponder` and forward calls to mocked object.

3. Adding `flutter::kModifierFlagShiftLeft` to a modifier flag containing `kCGEventFlagMaskShift`. The assertion was introduced in https://github.com/flutter/engine/pull/46230 but i missed the test failure because of the problems above.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-10-18 04:52:19 +00:00
skia-flutter-autoroll
0aa1f4977e Roll Fuchsia Linux SDK from VtEx0R7lepGAvwAMU... to OudOcFarQhQQzKDBx... (flutter/engine#47039) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-18 04:46:18 +00:00
skia-flutter-autoroll
820e1e437d Roll Fuchsia Mac SDK from E0Ui7KmD3u5JSKEk5... to Kp2wNpzRlAtbME0R4... (flutter/engine#47037) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-18 03:35:25 +00:00
skia-flutter-autoroll
aefed3c7f1 Roll Skia from f62b4dce5e55 to 13694b8c64aa (2 revisions) (flutter/engine#47033) 
https://skia.googlesource.com/skia.git/+log/f62b4dce5e55..13694b8c64aa

2023-10-17 lovisolo@google.com [bazel] adb_test_runner.go: Pipe through extra command-line arguments to binary.
2023-10-17 brianosman@google.com Add coloremoji to the set of ColorSpaces GMs we test

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-18 00:22:38 +00:00
Chinmay Garde
09fcf5e4e5 Roll buildroot to pull in removal of //tools. (flutter/engine#47032) 
None of these except remove_stale_pyc_files seems to be used. But we have the
pyc files in the .gitignore and I couldn't find any existing checked in pyc
files. So this check has never made sense for the Flutter. Removing instead of
migrating.

Buildroot patch https://github.com/flutter/buildroot/pull/784
 2023-10-18 00:16:28 +00:00
Jonah Williams
b964d7a907 Disable threading test that fails on CI (flutter/engine#47034) 
This is failing on CI but didn't fail locally on the PR. Not sure why.
 2023-10-17 17:02:48 -07:00
Chris Bracken
401ce5f32e Move imgui from buildroot to flutter third_party (flutter/engine#47031) 
As part of eliminating the Flutter buildroot (#67373), we are moving all
third-party dependencies from //third_party to //flutter/third_party.

Once all third-party dependencies have been migrated, tooling and config
will be moved and the buildroot will be eliminated altogether.

Issue: https://github.com/flutter/flutter/issues/136284

No tests changed because there is no semantic change to this PR. This is
simply relocating a dependency.

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I signed the [CLA].
- [X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-10-17 16:06:26 -07:00
Jonah Williams
633656df10 [Impeller] Rework Vulkan GPUTracker to decorate existing cmd buffers. (flutter/engine#46963) 
Switches the GPU tracing implementation to work more like the metal version, where we decorate individual cmd buffers with start/end time queries and then min/max the final result. Hopefully this stabilizes the values on CI
 2023-10-17 22:42:00 +00:00
Chris Bracken
6fd06e4039 [fml][embedder] Improve thread-check logging (flutter/engine#47020) 
Developers working their app's runner code or in the native parts of
plugins are often required to call methods from the platform thread, or
face a crash.
Makes a minor improvement to fml::ThreadChecker's
IsCreationThreadCurrent log message.
This patch originally proposed to emit a much more specific error
message when calling methods that must be called on the platform thread
(typically originating in calls from plugins), however, given that we
don't ship debug engines as part of the SDK, this is really only going
to be useful to engine developpers, or people brave enough to run with
their own local engine build, in any case. 

Issue: https://github.com/flutter/flutter/issues/135345

No changed tests since no functional change, just an error message
cleanup.

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I signed the [CLA].
- [X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-10-17 15:32:50 -07:00
skia-flutter-autoroll
23f95c816d Roll Dart SDK from 99ce477503f8 to da48c75b73b1 (1 revision) (flutter/engine#47027) 
https://dart.googlesource.com/sdk.git/+log/99ce477503f8..da48c75b73b1

2023-10-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-35.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-17 22:31:36 +00:00
Chinmay Garde
fa5f484e71 Roll buildroot to pull in //gpu removal. (flutter/engine#47014) 
Needs https://github.com/flutter/buildroot/pull/782
 2023-10-17 22:28:07 +00:00
skia-flutter-autoroll
93222a9a42 Roll Skia from b524e0af7d3a to f62b4dce5e55 (4 revisions) (flutter/engine#47029) 
https://skia.googlesource.com/skia.git/+log/b524e0af7d3a..f62b4dce5e55

2023-10-17 johnstiles@google.com Fix MakeClientBasedUnicode when skia_use_client_icu is set.
2023-10-17 herb@google.com Fix Segment intersection calculation
2023-10-17 avi@chromium.org Fix availability macro use
2023-10-17 johnstiles@google.com Fix more ClangTidy `performance-unnecessary-value-param` findings.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-17 22:28:05 +00:00
Jason Simmons
128b1d06d0 Workaround for a clang-tidy warning in CPUSpeedTracker (flutter/engine#47024) 
The newly rolled version of clang-tidy is warning about some accesses to std::optional values.  The function does a has_value check before accessing the values, but the analyzer does not detect that.
 2023-10-17 21:50:05 +00:00
skia-flutter-autoroll
4ec1df3d9e Roll Skia from a9caf3c19792 to b524e0af7d3a (1 revision) (flutter/engine#47017) 
https://skia.googlesource.com/skia.git/+log/a9caf3c19792..b524e0af7d3a

2023-10-17 armansito@google.com [graphite] Forward-declare VelloRenderer in RendererProvider.h

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-17 19:52:01 +00:00
Jason Simmons
1e53cd5758 Manual roll of Clang from 576b184d6e3b to 00396e6a1a0b (flutter/engine#46980) 2023-10-17 19:36:48 +00:00
skia-flutter-autoroll
53153bfeaa Roll Skia from 1a332d2b35d9 to a9caf3c19792 (1 revision) (flutter/engine#47013) 
https://skia.googlesource.com/skia.git/+log/1a332d2b35d9..a9caf3c19792

2023-10-17 ccameron@chromium.org Add files for public Exif interface and IFD parsing

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-17 19:07:06 +00:00
LongCatIsLooong
d4211a976b Don't respond to the insertionPointColor selector on iOS 17+ (flutter/engine#46373) 
Fixes https://github.com/flutter/flutter/issues/132548

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-10-17 19:03:48 +00:00
Zachary Anderson
edd9302b1c Shift some engine DEPS from github to mirrors (flutter/engine#46633) 
Progress towards https://github.com/flutter/flutter/issues/113052
 2023-10-17 17:52:21 +00:00
skia-flutter-autoroll
a206e1d703 Roll Skia from 8b3f2ef48a90 to 1a332d2b35d9 (1 revision) (flutter/engine#47009) 
https://skia.googlesource.com/skia.git/+log/8b3f2ef48a90..1a332d2b35d9

2023-10-17 jamesgk@google.com Revert "[graphite] Test that failed dst copies don't cause a crash"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-17 17:36:18 +00:00
skia-flutter-autoroll
eb1462e4f0 Roll Dart SDK from 2418bda7a457 to 99ce477503f8 (1 revision) (flutter/engine#47008) 
https://dart.googlesource.com/sdk.git/+log/2418bda7a457..99ce477503f8

2023-10-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-34.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-17 17:34:07 +00:00
gaaclarke
eae82ab804 [Impeller] added trace statements for colorsources (flutter/engine#47007) 
helped debug https://github.com/orgs/flutter/projects/21/views/1?pane=issue&itemId=41416077

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-10-17 17:23:29 +00:00
Chinmay Garde
cd22beb767 Move the secondary build tree into the engine. (flutter/engine#46989) 
Now, both the DEPS and the custom GN rules for them are in the same repo and won't need a buildroot sibling patch + roll.

Part of https://github.com/flutter/flutter/issues/67373. Pending landing of the buildroot patch in https://github.com/flutter/buildroot/pull/781 (the DEPS will be updated before landing and after the presubs pass).
 2023-10-17 17:14:57 +00:00
skia-flutter-autoroll
7333c88c02 Roll Skia from d937d10a0ba9 to 8b3f2ef48a90 (3 revisions) (flutter/engine#47005) 
https://skia.googlesource.com/skia.git/+log/d937d10a0ba9..8b3f2ef48a90

2023-10-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 160b327a9c37 to 1b161432fcf1 (7 revisions)
2023-10-17 bungeman@google.com Revert "Reland "[pdf] Simplify filled paths""
2023-10-17 johnstiles@google.com Fix ClangTidy `performance-unnecessary-value-param` findings.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-17 16:43:23 +00:00
Jackson Gardner
ef900554cb Include symbol maps in CanvasKit and Skwasm builds. (flutter/engine#46973) 
This should help with https://github.com/flutter/flutter/issues/122834

Emitting DWARF data or source maps actually significantly changes the size of the build, since some binaryen optimizations must actually be skipped when producing either of those. So we can emit symbol maps for now, which don't affect the size of the actual wasm output. With these, we can at least manually deobfuscate stack traces.
 2023-10-17 16:24:18 +00:00
skia-flutter-autoroll
b2ee7de62a Roll Fuchsia Linux SDK from Y9mDBoH4BSC6pWFXV... to VtEx0R7lepGAvwAMU... (flutter/engine#47004) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-17 16:01:18 +00:00
skia-flutter-autoroll
00211c0ac6 Roll Skia from f7e15ba449f7 to d937d10a0ba9 (7 revisions) (flutter/engine#47003) 
https://skia.googlesource.com/skia.git/+log/f7e15ba449f7..d937d10a0ba9

2023-10-17 kjlubick@google.com Put SkFontMgr::Factory and SkFontMgr::RefDefault behind #ifdefs
2023-10-17 jamesgk@google.com [graphite] Test that failed dst copies don't cause a crash
2023-10-17 49699333+dependabot[bot]@users.noreply.github.com Bump @babel/traverse from 7.12.10 to 7.23.2 in /modules/pathkit
2023-10-17 49699333+dependabot[bot]@users.noreply.github.com Bump @babel/traverse from 7.12.10 to 7.23.2 in /modules/canvaskit
2023-10-17 kjlubick@google.com Stop making wasm docker images
2023-10-17 johnstiles@google.com Enable ClangTidy for Dawn.
2023-10-17 johnstiles@google.com Enable ClangTidy for Graphite.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-17 15:58:55 +00:00
skia-flutter-autoroll
421e55f0fc Roll Fuchsia Mac SDK from gJiEzqLWUvPVgoq8b... to E0Ui7KmD3u5JSKEk5... (flutter/engine#47000) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-17 15:00:31 +00:00
Victoria Ashworth
ebe2cf39ca Only run web mac tests on macOS 12 (flutter/engine#46965) 
Web Mac tests currently fail on macOS 13 (https://github.com/flutter/flutter/issues/136274, https://github.com/flutter/flutter/issues/136279) so we limit CI to only run on macOS 12.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-10-17 14:59:05 +00:00
skia-flutter-autoroll
dc122dc6b7 Roll Dart SDK from 82c073d657eb to 2418bda7a457 (1 revision) (flutter/engine#46997) 
https://dart.googlesource.com/sdk.git/+log/82c073d657eb..2418bda7a457

2023-10-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-33.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-17 13:34:23 +00:00
Kevin Lubick
e43b039248 Replace use of SkFont::refTypefaceOrDefault() (flutter/engine#46969) 
This API is going away soon in
https://skia-review.googlesource.com/c/skia/+/766776
as is the concept of Skia having a "default typeface"

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-10-17 09:16:32 -04:00
skia-flutter-autoroll
5ef5a68231 Roll Dart SDK from 7d0a805e4ee1 to 82c073d657eb (1 revision) (flutter/engine#46995) 
https://dart.googlesource.com/sdk.git/+log/7d0a805e4ee1..82c073d657eb

2023-10-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-32.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-17 09:25:18 +00:00
skia-flutter-autoroll
8151b185e1 Roll Skia from c30529427b7d to f7e15ba449f7 (1 revision) (flutter/engine#46994) 
https://skia.googlesource.com/skia.git/+log/c30529427b7d..f7e15ba449f7

2023-10-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from cd6b265c2623 to 1ea49a2222e1 (12 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-17 07:34:24 +00:00
skia-flutter-autoroll
1b2114dee3 Roll Skia from 31310feb67dc to c30529427b7d (2 revisions) (flutter/engine#46992) 
https://skia.googlesource.com/skia.git/+log/31310feb67dc..c30529427b7d

2023-10-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from d42ad20d2b50 to 0dca655f102b
2023-10-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from b7f47ce3bc13 to d42ad20d2b50 (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-17 06:15:19 +00:00
skia-flutter-autoroll
17bfa75b0e Roll Dart SDK from f3e1cd38e8b0 to 7d0a805e4ee1 (2 revisions) (flutter/engine#46991) 
https://dart.googlesource.com/sdk.git/+log/f3e1cd38e8b0..7d0a805e4ee1

2023-10-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-31.0.dev
2023-10-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-30.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-17 05:29:25 +00:00
skia-flutter-autoroll
f5687a4112 Roll Skia from 205b728a8623 to 31310feb67dc (2 revisions) (flutter/engine#46990) 
https://skia.googlesource.com/skia.git/+log/205b728a8623..31310feb67dc

2023-10-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 90fc3629a642 to b665b7fda7cf (14 revisions)
2023-10-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 4d77c74a14a0 to 160b327a9c37 (11 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-17 05:25:07 +00:00
skia-flutter-autoroll
b49ad528d0 Roll Fuchsia Mac SDK from bMDZdOFfPiVkjIdiv... to gJiEzqLWUvPVgoq8b... (flutter/engine#46985) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-17 02:15:16 +00:00
skia-flutter-autoroll
df1b229147 Roll Skia from 751358929d1f to 205b728a8623 (1 revision) (flutter/engine#46982) 
https://skia.googlesource.com/skia.git/+log/751358929d1f..205b728a8623

2023-10-17 johnstiles@google.com Fix issues discovered by ClangTidy 17.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-17 01:14:37 +00:00
Jason Simmons
91cf2a899f Revert "Fix Platform.script for flutter_tester" (flutter/engine#46981) 
This reverts commit 670b5bd8e714a1fd2bd137aa2c5b36760b8ce89b.

With https://github.com/flutter/engine/pull/46911, the Platform.script API will return a URI for the compiled temporary wrapper script generated by "flutter test".  This will cause issues for tests that expect Platform.script to reflect the directory where "flutter test" was launched.
 2023-10-17 01:07:02 +00:00
skia-flutter-autoroll
7cbcff6ac6 Roll Dart SDK from 12f6559bd6ed to f3e1cd38e8b0 (1 revision) (flutter/engine#46977) 
https://dart.googlesource.com/sdk.git/+log/12f6559bd6ed..f3e1cd38e8b0

2023-10-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-29.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-16 23:55:03 +00:00
skia-flutter-autoroll
b7b2fafe99 Roll Fuchsia Linux SDK from 6E-cSq679DjzBMcqY... to Y9mDBoH4BSC6pWFXV... (flutter/engine#46974) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-16 23:28:56 +00:00
skia-flutter-autoroll
0eb4722d66 Roll Skia from 8919fecf15c1 to 751358929d1f (4 revisions) (flutter/engine#46972) 
https://skia.googlesource.com/skia.git/+log/8919fecf15c1..751358929d1f

2023-10-16 kjlubick@google.com Move SkDebug.cpp from core to base
2023-10-16 lovisolo@google.com [bazel] Add android_benchmark_test rule and sample targets.
2023-10-16 lovisolo@google.com [bazel] Move some utilities from //bazel to //tools/testrunners/common.
2023-10-16 nicolettep@google.com [graphite] Use UBO for intrinsic constant, remove inline uniform support

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-16 22:44:21 +00:00
Jonah Williams
cfaf868033 [Impeller] GPUTracer for Metal. (flutter/engine#46846) 
Impelement GPU frame time tracing for metal. Unlike Vulkan, this can't use dummy cmd buffers as those don't seem to ever get an executed callback. Instead we decorate every submitted cmd buffer with tracing functionality, and min/max the timestamps to compute the range of computation time.
 2023-10-16 22:32:24 +00:00
Dan Field
670b5bd8e7 Fix Platform.script for flutter_tester (flutter/engine#46911) 
This addresses the problem in https://github.com/flutter/flutter/issues/12847 which changed slightly over time.

Today, `Platform.script` does not give an empty `file` URI, it gives something like `file://path/to/package/main.dart` _regardless of how the file is actually named_.

After this change, it will give the absolute path to the file being run under test.

So before this change, the new test would have a URI like

```
file:///Users/dnfield/src/flutter/engine/src/main.dart
```

And now it has

```
file:///Users/dnfield/src/flutter/engine/src/out/host_debug_unopt_arm64/gen/platform_test.dart.dill
```

This is going to be helpful in generating relative paths from the test file.
 2023-10-16 21:55:06 +00:00
skia-flutter-autoroll
2bd3e9b6e6 Roll Skia from 85c8dca08cbe to 8919fecf15c1 (1 revision) (flutter/engine#46966) 
https://skia.googlesource.com/skia.git/+log/85c8dca08cbe..8919fecf15c1

2023-10-16 kjlubick@google.com Reland "Remove GL dependency from GrBackendSemaphore"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-16 21:53:06 +00:00
Matej Knopp
64af1329c2 [macOS] FlutterMutatorView should clip to bounds (flutter/engine#46463) 
*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*

*List which issues are fixed by this PR. You must list at least one issue.*

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-10-16 21:14:57 +00:00
skia-flutter-autoroll
97eae1ceed Roll Skia from 0e5207fb4971 to 85c8dca08cbe (1 revision) (flutter/engine#46964) 
https://skia.googlesource.com/skia.git/+log/0e5207fb4971..85c8dca08cbe

2023-10-16 michaelludwig@google.com [graphite] Fix SkMatrix row-major uniform upload bug

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-16 20:46:57 +00:00
John McCutchan
9f4cf7153a Allow Image backed platform view rendering target on Android >= 29 again (flutter/engine#46958) 
- Refactor the fence waiting code to only wait on Android >= 33.
- Log a warning message once per image rendering target on Android >= 29 && < 33.
- Add a simple unit test of ImageReaderPlatformViewRenderTargets.
 2023-10-16 20:08:13 +00:00
skia-flutter-autoroll
0174442f71 Roll Skia from 68de6e352585 to 0e5207fb4971 (1 revision) (flutter/engine#46960) 
https://skia.googlesource.com/skia.git/+log/68de6e352585..0e5207fb4971

2023-10-16 sunnyps@chromium.org graphite: Fix SkMipmap memory leak

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-16 19:58:44 +00:00
skia-flutter-autoroll
11b3a931e8 Roll Skia from 675f088b9ac4 to 68de6e352585 (1 revision) (flutter/engine#46956) 
https://skia.googlesource.com/skia.git/+log/675f088b9ac4..68de6e352585

2023-10-16 kjlubick@google.com Move SkMultiPictureDocument functions into namespace in include/docs

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-16 18:31:16 +00:00
gaaclarke
c8aa0844f2 [Impeller] implements a retry mechanism for dart:ui/Image.toByteData. (flutter/engine#46840) 
Design doc: [link](https://docs.google.com/document/d/1Uuiw3pdQxNFTA8OQuZ-kuvYg1NB42XgccQCZeqr4oII/edit#heading=h.hn6wreyrz6fm)
fixes: https://github.com/flutter/flutter/issues/135245

One slight deviation from the design doc is that I decided to make ContextMTL respond to changes to the SyncSwitch instead of having it observe the app state directly.  The benefits are:
1) This keeps that functionality in one location
1) It makes writing tests much easier
1) There's no need of conditional compilation between macos and ios
1) There is no need to add an objc class

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-10-16 18:31:13 +00:00