engine-flutter-autoroll
5bf11bc2cd
Roll Flutter Engine from b5e98f9b8d0f to f693fdd840e8 (4 revisions) ( #149057 )
...
b5e98f9b8d...f693fdd8401961493+harryterkelsen@users.noreply.github.com [canvaskit] Fix overlay reorganization for edge case with only 1 overlay (flutter/engine#53006 )
2024-05-24 skia-flutter-autoroll@skia.org Roll Dart SDK from 49b226cecee7 to 4ef8ed68a8d4 (1 revision) (flutter/engine#53024 )
2024-05-24 skia-flutter-autoroll@skia.org Roll Skia from f832549400ab to 97783ac3000d (1 revision) (flutter/engine#53023 )
2024-05-24 30870216+gaaclarke@users.noreply.github.com [Impeller] sped up the linear gradient by moving calculations to the cpu (flutter/engine#53007 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-25 00:44:19 +00:00
Joodo
734d243bc8
fix popup menu offset when using useRootNavigator in PopupMenu ( #144670 )
...
fix issue #144669
2024-05-24 21:38:08 +00:00
hangyu
735c3a857a
[GAR][a11y] Update assessment app to unblock tester from testing dark mode ( #149055 )
...
internal: b/317130300
reopening #149004
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
[Data Driven Fixes]:
https://github.com/flutter/flutter/wiki/Data-driven-Fixes
2024-05-24 13:44:55 -07:00
hangyu
8ff57091bc
[a11y] Slider should respect bold text setting ( #149053 )
...
Fix https://github.com/flutter/flutter/issues/147600
internal GAR issue: b/316933135
reopen from #148435
2024-05-24 19:48:14 +00:00
Kostia Sokolovskyi
7be97ab781
Add tests for editable_text.on_changed.0.dart API example. ( #148874 )
...
This PR contributes to https://github.com/flutter/flutter/issues/130459
### Description
- Adds tests for `examples/api/lib/widgets/editable_text/editable_text.on_changed.0.dart`
2024-05-24 19:21:12 +00:00
engine-flutter-autoroll
aa6382093e
Roll Flutter Engine from 979214444aca to b5e98f9b8d0f (1 revision) ( #149051 )
...
979214444a...b5e98f9b8dskia-flutter-autoroll@skia.org Roll Skia from 956e77ac96fd to f832549400ab (1 revision) (flutter/engine#53022 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-24 18:22:08 +00:00
Kostia Sokolovskyi
6a20a5b19c
Add test for text_editing_controller.0.dart API example. ( #148872 )
...
This PR contributes to https://github.com/flutter/flutter/issues/130459
### Description
- Adds test for `examples/api/lib/widgets/editable_text/text_editing_controller.0.dart`
2024-05-24 17:50:00 +00:00
engine-flutter-autoroll
6093a9cd2b
Roll Flutter Engine from 4ab442475223 to 979214444aca (3 revisions) ( #149045 )
...
4ab4424752...979214444askia-flutter-autoroll@skia.org Roll Skia from 92f576fd2c52 to 956e77ac96fd (2 revisions) (flutter/engine#53021 )
2024-05-24 skia-flutter-autoroll@skia.org Roll Dart SDK from fef7786d65f9 to 49b226cecee7 (1 revision) (flutter/engine#53020 )
2024-05-24 skia-flutter-autoroll@skia.org Roll Skia from 8b8cf5b49988 to 92f576fd2c52 (1 revision) (flutter/engine#53019 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-24 16:26:09 +00:00
Łukasz Gawron
a53b78ddfb
Fix TwoDimensionalViewport's keep alive child not always removed (when no longer should be kept alive) ( #148298 )
...
- Fixes a child not removed from `_keepAliveBucket` when widget is no longer kept alive offscreen. Bug was triggering assert in performLayout.
- Adds test to cover the case from bug report
Fixes #138977
2024-05-24 16:26:07 +00:00
engine-flutter-autoroll
6861b77c2b
Roll Packages from 1008d9e9cd07 to 7b423f582180 (2 revisions) ( #149043 )
...
1008d9e9cd...7b423f5821stuartmorgan@google.com [ci] Start moving podspec check to ARM (flutter/packages#6782 )
2024-05-24 10687576+bparrishMines@users.noreply.github.com [webview_flutter] Adds onHttpError callback to NavigationDelegate to catch HTTP error status codes (flutter/packages#6378 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-24 15:44:06 +00:00
engine-flutter-autoroll
8dd08314d2
Roll Flutter Engine from c6041cd9049c to 4ab442475223 (1 revision) ( #149039 )
...
c6041cd904...4ab4424752skia-flutter-autoroll@skia.org Roll Skia from 33f0e2e61db9 to 8b8cf5b49988 (1 revision) (flutter/engine#53017 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-24 11:26:25 +00:00
engine-flutter-autoroll
ca3aeb0151
Roll Flutter Engine from 8d896f4feb76 to c6041cd9049c (1 revision) ( #149035 )
...
8d896f4feb...c6041cd904skia-flutter-autoroll@skia.org Roll Skia from fc250ec3157f to 33f0e2e61db9 (1 revision) (flutter/engine#53016 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-24 10:18:25 +00:00
engine-flutter-autoroll
4cb47b864b
Roll Flutter Engine from fe3b26294d8f to 8d896f4feb76 (1 revision) ( #149030 )
...
fe3b26294d...8d896f4febskia-flutter-autoroll@skia.org Roll Skia from 447b7a9db1a7 to fc250ec3157f (1 revision) (flutter/engine#53015 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-24 08:53:24 +00:00
engine-flutter-autoroll
f524ea89fe
Roll Flutter Engine from b4fb08f21757 to fe3b26294d8f (1 revision) ( #149028 )
...
b4fb08f217...fe3b26294dskia-flutter-autoroll@skia.org Roll Skia from 0a5870c8a4b4 to 447b7a9db1a7 (1 revision) (flutter/engine#53014 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-24 07:54:14 +00:00
engine-flutter-autoroll
b3d8053f04
Roll Flutter Engine from f873230ce823 to b4fb08f21757 (2 revisions) ( #149025 )
...
f873230ce8...b4fb08f217skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from jQHA0UEiQtfQTuWzM... to 9PoD1BZXVglZ-EWu3... (flutter/engine#53012 )
2024-05-24 skia-flutter-autoroll@skia.org Roll Dart SDK from 9d7324ea563a to fef7786d65f9 (1 revision) (flutter/engine#53011 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from jQHA0UEiQtfQ to 9PoD1BZXVglZ
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-24 06:14:19 +00:00
engine-flutter-autoroll
722178b405
Roll Flutter Engine from d78f66753332 to f873230ce823 (1 revision) ( #149021 )
...
d78f667533...f873230ce8skia-flutter-autoroll@skia.org Roll Skia from f2053e772e6f to 0a5870c8a4b4 (1 revision) (flutter/engine#53010 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-24 04:54:24 +00:00
engine-flutter-autoroll
1317046ef8
Roll Flutter Engine from 768c90ee5dc7 to d78f66753332 (3 revisions) ( #149011 )
...
768c90ee5d...d78f667533skia-flutter-autoroll@skia.org Roll Skia from 2ef772706cda to f2053e772e6f (1 revision) (flutter/engine#53009 )
2024-05-24 skia-flutter-autoroll@skia.org Roll Dart SDK from 7809d6e332ff to 9d7324ea563a (7 revisions) (flutter/engine#53008 )
2024-05-24 31859944+LongCatIsLooong@users.noreply.github.com Allow unsetting `TextStyle.height` (flutter/engine#52940 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-24 02:35:13 +00:00
Nate
f419177057
Reland "Update FocusManager platform check to include iOS" ( #148984 )
...
It looks like removing `kIsWeb` from the `FocusManager._appLifecycleListener` platform check is causing [memory leaks](https://github.com/flutter/flutter/issues/148985 ) and test failures.
This pull request fixes #148475 and prevents the test failures shown in #148978 .
2024-05-23 23:13:18 +00:00
engine-flutter-autoroll
5beac73cfa
Roll Flutter Engine from ad12c5d02a8c to 768c90ee5dc7 (2 revisions) ( #149003 )
...
ad12c5d02a...768c90ee5dchinmaygarde@google.com Cleanup propagation of codecvt warning suppression in FML. (flutter/engine#52966 )
2024-05-23 skia-flutter-autoroll@skia.org Roll Skia from 60ed6f47af08 to 2ef772706cda (3 revisions) (flutter/engine#53003 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-23 22:59:09 +00:00
Taha Tesser
ec69f001fc
Fix SnackBar action text button overlay color ( #148961 )
...
fixes [`SnackBar` action hover state background too hard to see](https://github.com/flutter/flutter/issues/141343 )
### Code sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() {
runApp(const MyApp());
}
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return const MaterialApp(
home: Scaffold(
body: Center(
child: ScaffoldButton(),
),
),
);
}
}
class ScaffoldButton extends StatelessWidget {
const ScaffoldButton({super.key});
@override
Widget build(BuildContext context) {
return TextButton(
onPressed: () {
ScaffoldMessenger.of(context).showSnackBar(
SnackBar(
behavior: SnackBarBehavior.floating,
width: 320,
content: const Text('This is a snackbar!'),
action: SnackBarAction(
label: 'Close',
onPressed: () {},
),
),
);
},
child: const Text('Launch snackbar'),
);
}
}
```
</details>
### Before
<img src="https://github.com/flutter/flutter/assets/48603081/88b53c92-6184-4faf-88e1-ac70f78993b3 "/>
### After
<img src="https://github.com/flutter/flutter/assets/48603081/3e03c903-90c0-4da4-b49a-0070208d56d1 " />
2024-05-23 22:42:52 +00:00
wangyognqi
881e29f94a
Fix the second TextFormField to trigger onTapOutside ( #148930 )
...
This PR attempts to fix https://github.com/flutter/flutter/issues/127597
2024-05-23 22:25:51 +00:00
engine-flutter-autoroll
e4ce47f348
Roll Flutter Engine from 2a48302f6f4e to ad12c5d02a8c (3 revisions) ( #148993 )
...
2a48302f6f...ad12c5d02a1961493+harryterkelsen@users.noreply.github.com Move pictures from deleted canvases to second-to-last canvas instead of last. (flutter/engine#51397 )
2024-05-23 skia-flutter-autoroll@skia.org Roll Skia from 8af1d36fbccb to 60ed6f47af08 (2 revisions) (flutter/engine#52999 )
2024-05-23 skia-flutter-autoroll@skia.org Roll Skia from 7fcb4edbd9b7 to 8af1d36fbccb (1 revision) (flutter/engine#52998 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-23 22:06:07 +00:00
engine-flutter-autoroll
0e4a3995ff
Roll Flutter Engine from 964f087f288c to 2a48302f6f4e (1 revision) ( #148950 )
...
964f087f28...2a48302f6fbdero@google.com [Impeller] Fix stroke curves. (flutter/engine#52978 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-23 20:22:19 +00:00
Kate Lovett
65abc95542
[wiki migration] Remaining pages under docs/contributing/ ( #148790 )
2024-05-23 15:19:04 -05:00
Kate Lovett
de0fbdefe3
[wiki migration] Web team pages ( #148777 )
2024-05-23 14:36:47 -05:00
derdilla
7fb7192304
Test remaining transitions api examples ( #148302 )
...
Adds tests for `relative_positioned_transition`, `positioned_transition`, `sliver_fade_transition`, `align_transition`, `animated_builder`, `rotation_transition`, `animated_widget`, `slide_transition`, `listenable_builder`, `scale_transition`, `default_text_style_transition`, `decorated_box_transition`, `size_transition` api examples. Makes double type in the `align_transition` example explicit.
A test for `fade_transition` is already in currently open #148178 .
Part of #130459 .
2024-05-23 18:57:14 +00:00
derdilla
aaa4d336f6
Test snack bar examples ( #147774 )
...
Adds tests to the last two Snack Bar examples as part of #130459 . Makes the [last example](https://api.flutter.dev/flutter/material/SnackBar-class.html#material.SnackBar.3 ) more usable through the use of standard widgets and visual hierarchy. Constraints on options that are not required by the SnackBar contract have been removed (Overflow threshold works on fixed SnackBars).
2024-05-23 18:54:11 +00:00
derdilla
1c1516c35e
Add tests for material banner example ( #147733 )
...
Part of https://github.com/flutter/flutter/issues/130459 .
2024-05-23 18:48:09 +00:00
engine-flutter-autoroll
82c3b38eb8
Roll Packages from 65254411e677 to 1008d9e9cd07 (6 revisions) ( #148980 )
...
65254411e6...1008d9e9cdengine-flutter-autoroll@skia.org Roll Flutter from 73bf206f35e7 to 8d955cdd644e (24 revisions) (flutter/packages#6786 )
2024-05-23 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 5dcb86f68f23 to a14f74ff3a1c (3 revisions) (flutter/packages#6784 )
2024-05-23 stuartmorgan@google.com [file_selector] Convert iOS to Swift and SPM (flutter/packages#6755 )
2024-05-23 49699333+dependabot[bot]@users.noreply.github.com [webview]: Bump androidx.webkit:webkit from 1.7.0 to 1.10.0 in /packages/webview_flutter/webview_flutter_android/android (flutter/packages#5996 )
2024-05-23 engine-flutter-autoroll@skia.org Roll Flutter from d02292dbc409 to 73bf206f35e7 (31 revisions) (flutter/packages#6780 )
2024-05-23 goderbauer@google.com [rfw] Adds support for `DecorationImage.filterQuality`. (flutter/packages#6781 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-23 18:36:07 +00:00
Michael Goderbauer
6cdb632970
Revert "const vs. non-const widget build benchmark" ( #148970 )
...
Reverts flutter/flutter#148261
For some reason, the benchmark is flaky only on iOS. Android runs are fine. See https://github.com/flutter/flutter/issues/148845 .
Closes https://github.com/flutter/flutter/issues/148845 .
2024-05-23 18:20:53 +00:00
Ian Hickson
2025ebe767
Remove hidden dependencies on HttpClient ( #148773 )
...
This is part 16 of a broken down version of the #140101 refactor.
This only makes one dependency explicit. Further PRs will do the same for other dependencies, until these APIs have no hidden dependencies.
This PR makes no effort to keep the order of parameters reasonable. There is an existing TODO to do a refactor sweep later that does nothing but reorder arguments/parameters/fields to be consistent.
2024-05-23 18:20:50 +00:00
Renzo Olivares
84fe3b6e53
Revert "Update FocusManager platform check to include iOS" ( #148978 )
2024-05-23 10:46:10 -07:00
Nate
8d955cdd64
Update FocusManager platform check to include iOS ( #148612 )
...
Both iOS and Android run into issues when the FocusManager starts responding to app lifecycle changes.
Fortunately, this feature is primarily meant for desktop platforms, so the problem can be resolved with a platform check.
fixes https://github.com/flutter/flutter/issues/148475
2024-05-23 16:40:45 +00:00
Matej Knopp
02d5286e02
[iOS] fix hot restart with native assets ( #148752 )
...
Fixes https://github.com/flutter/flutter/issues/148687
Adds support for running the hot restart and reload integration test on
iOS simulator.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
[Data Driven Fixes]:
https://github.com/flutter/flutter/wiki/Data-driven-Fixes
2024-05-23 18:30:55 +02:00
engine-flutter-autoroll
c14d55c4d2
Roll Flutter Engine from b8b82454e302 to 964f087f288c (8 revisions) ( #148943 )
...
b8b82454e3...964f087f28skia-flutter-autoroll@skia.org Roll Skia from 371f52a008fa to 7fcb4edbd9b7 (1 revision) (flutter/engine#52997 )
2024-05-23 skia-flutter-autoroll@skia.org Roll Skia from 603607f7d249 to 371f52a008fa (1 revision) (flutter/engine#52996 )
2024-05-23 skia-flutter-autoroll@skia.org Roll Skia from 1b6281ae0816 to 603607f7d249 (1 revision) (flutter/engine#52995 )
2024-05-23 skia-flutter-autoroll@skia.org Roll Skia from 8cecdecc648e to 1b6281ae0816 (1 revision) (flutter/engine#52994 )
2024-05-23 skia-flutter-autoroll@skia.org Roll Skia from 21c6fb26c14e to 8cecdecc648e (1 revision) (flutter/engine#52993 )
2024-05-23 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from gWBn6yPljFeQvPSYz... to jQHA0UEiQtfQTuWzM... (flutter/engine#52992 )
2024-05-22 skia-flutter-autoroll@skia.org Roll Skia from 0ee149894a8d to 21c6fb26c14e (1 revision) (flutter/engine#52991 )
2024-05-22 skia-flutter-autoroll@skia.org Manual roll Dart SDK from fca7dd796e81 to 7809d6e332ff (2 revisions) (flutter/engine#52986 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from gWBn6yPljFeQ to jQHA0UEiQtfQ
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-23 11:11:29 +00:00
huycozy
e467289fb8
Fix DecoratedSliver sample code to reflect the description ( #148621 )
...
### Demo screenshot
### Related issue
- Fixes https://github.com/flutter/flutter/issues/145935
- Add test for `examples/api/test/widgets/sliver/decorated_sliver.0_test.dart` as a part of https://github.com/flutter/flutter/issues/130459 .
2024-05-23 08:52:15 +00:00
derdilla
abad37204e
Test raw autocomplete api examples ( #148234 )
...
Part of #130459 .
2024-05-23 08:52:13 +00:00
Valentin Vignal
84876e58ce
Add test for scaffold.0.dart and scaffold.2.dart ( #148166 )
...
Contributes to https://github.com/flutter/flutter/issues/130459
It adds test for
- `examples/api/lib/material/scaffold/scaffold.0.dart`
- `examples/api/lib/material/scaffold/scaffold.2.dart`
It also modifies the `scaffold.1_test.dart` because the only difference with scaffold 0 is the background color, so I figured the test should include it
2024-05-23 08:50:18 +00:00
Kostia Sokolovskyi
3beeed4929
Add tests for restorable_value.0.dart API example. ( #148676 )
...
This PR contributes to https://github.com/flutter/flutter/issues/130459
### Description
- Updates `examples/api/lib/widgets/restoration_properties/restorable_value.0.dart` to meet the latest API examples structure
- Adds tests for `examples/api/lib/widgets/restoration_properties/restorable_value.0.dart`
2024-05-23 08:34:23 +00:00
engine-flutter-autoroll
fe0932f2c0
Roll Flutter Engine from 8b094fbb94d8 to b8b82454e302 (6 revisions) ( #148919 )
...
8b094fbb94...b8b82454e3skia-flutter-autoroll@skia.org Roll Skia from 380ae98608de to 0ee149894a8d (5 revisions) (flutter/engine#52989 )
2024-05-22 skia-flutter-autoroll@skia.org Roll Skia from 396c66076ab1 to 380ae98608de (4 revisions) (flutter/engine#52983 )
2024-05-22 john@johnmccutchan.com Reduce rebuild times when invoking 'et run' (flutter/engine#52883 )
2024-05-22 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Add dilate and erode imagefilters (flutter/engine#48553 )
2024-05-22 skia-flutter-autoroll@skia.org Roll Skia from 93ed643df6d1 to 396c66076ab1 (3 revisions) (flutter/engine#52981 )
2024-05-22 john@johnmccutchan.com Fix another instance of platform view breakage on Android 14 (flutter/engine#52980 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-23 02:19:25 +00:00
LongCatIsLooong
a766945bdd
Allow RenderObject.getTransformTo to take an arbitrary RenderObject in the same tree ( #148897 )
...
This is https://github.com/flutter/flutter/pull/130192 but without the additional parameter.
Fixes https://github.com/flutter/flutter/issues/146764 , https://github.com/flutter/flutter/issues/148410
2024-05-22 23:32:24 +00:00
Kevin Chisholm
bb5b7d2608
3.22.1 changelog updates ( #148895 )
...
Updates changelog with 3.22.1 changes.
2024-05-22 17:30:44 -05:00
Helin Shiah
edf312d506
Add frame number and widget location map service extension ( #148702 )
...
This helps us add widget rebuild counts to the DevTools performance page: https://github.com/flutter/devtools/issues/4564
2024-05-22 21:29:27 +00:00
LongCatIsLooong
d57ea48ca1
Remove an assert with false positives ( #148795 )
...
Fixes https://github.com/flutter/flutter/issues/110343 .
This is not an important piece of guardrail and the iOS embedder only expects best-effort results anyways.
2024-05-22 21:25:31 +00:00
Renzo Olivares
b2eda0624a
Revert "Fix the second TextFormField to trigger onTapOutside" ( #148909 )
2024-05-22 13:40:59 -07:00
Kate Lovett
26e5352eec
[wiki migration] Remaining pages under docs/about/ ( #148782 )
...
This moves the wiki pages that have a final destination under docs/about/ as planned in [flutter.dev/go/migrate-flutter-wiki-spreadsheet](https://docs.google.com/spreadsheets/d/1x65189ZBdNiLRygpUYoU08pwvXD4M-Z157c6pm8deGI/edit?usp=sharing )
It also adds the team labels to the label bot for future PRs.
Changes to the content were only updating cross links, or links to refer to the main branch rather than master.
Remaining links to the wiki will be updated once all other pages have finished moving, they still work in the meantime.
Part of https://github.com/flutter/flutter/issues/145009
2024-05-22 18:41:12 +00:00
engine-flutter-autoroll
0e633a10b1
Roll Flutter Engine from b6971cdf14f8 to 8b094fbb94d8 (3 revisions) ( #148883 )
...
b6971cdf14...8b094fbb94skia-flutter-autoroll@skia.org Roll Skia from f00ab116e24f to 93ed643df6d1 (1 revision) (flutter/engine#52979 )
2024-05-22 skia-flutter-autoroll@skia.org Roll Skia from e0338616f368 to f00ab116e24f (2 revisions) (flutter/engine#52977 )
2024-05-22 skia-flutter-autoroll@skia.org Roll Skia from 78069713e02a to e0338616f368 (1 revision) (flutter/engine#52976 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-22 18:35:07 +00:00
wangyognqi
9acbc1d4a2
Fix the second TextFormField to trigger onTapOutside ( #148206 )
...
This PR attempts to fix https://github.com/flutter/flutter/issues/127597
2024-05-22 18:33:14 +00:00
Gray Mackall
eba7b97bb9
Try removing robolectric from integration_test tests ( #148803 )
...
May fix https://github.com/flutter/flutter/issues/148393 .
There are reports on the robolectric issue tracker of >`4.10.3` causing the error we are seeing
https://github.com/robolectric/robolectric/issues/8158
The test doesn't actually need robolectric (and didn't originally use it, or flake before using it), but it was added in https://github.com/flutter/flutter/pull/144348 . We can safely remove it by mocking the call to `View.generateViewId()`, so try removing it and see if flakes go away.
2024-05-22 18:29:19 +00:00
Victor Eronmosele
4c929f0f44
Prevent test folder deletion on running flutter create --empty on an existing app project ( #147160 )
...
This PR modifies the `flutter create --empty` command to not delete the `test/` folder when run on an existing app project.
Before:
```bash
flutter create my_app --empty
mkdir my_app/test
if test -d my_app/test; then echo "test exists"; else echo "test does not exist"; fi # test exists
flutter create my_app --empty
if test -d my_app/test; then echo "test exists"; else echo "test does not exist"; fi # test does not exist
```
After:
```bash
flutter create my_app --empty
mkdir my_app/test
if test -d my_app/test; then echo "test exists"; else echo "test does not exist"; fi # test exists
flutter create my_app --empty
if test -d my_app/test; then echo "test exists"; else echo "test does not exist"; fi # test exists
```
Fixes https://github.com/flutter/flutter/issues/134928
2024-05-22 17:37:05 +00:00
