DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
88,118 Commits 882 Branches 1,069 Tags
Commit Graph

88118 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
engine-flutter-autoroll
5a03d5ea2e
Roll Skia from 3167229206b5 to 9325111e6ee4 (1 revision) (#182061) 
https://skia.googlesource.com/skia.git/+log/3167229206b5..9325111e6ee4

2026-02-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SKP
CIPD package from 551 to 552

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bungeman@google.com,jsimmons@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2026-02-08 10:24:36 +00:00
engine-flutter-autoroll
659815e17f
Roll Fuchsia Linux SDK from sYqpDF9l9-kldd9_Q... to iqtwdXlgKIyZkL5Li... (#182058) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC jsimmons@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2026-02-08 08:06:28 +00:00
engine-flutter-autoroll
40993caa87
Roll Skia from ae78024b261e to 3167229206b5 (1 revision) (#182055) 
https://skia.googlesource.com/skia.git/+log/ae78024b261e..3167229206b5

2026-02-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from a7ed6cd3cd99 to 563a41bc005d (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
jmbetancourt@google.com,jsimmons@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2026-02-08 04:24:27 +00:00
engine-flutter-autoroll
010cd4f383
Roll Dart SDK from ad6368edbe02 to 965b51c219d3 (1 revision) (#182050) 
https://dart.googlesource.com/sdk.git/+log/ad6368edbe02..965b51c219d3

2026-02-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.12.0-127.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2026-02-07 11:18:40 +00:00
engine-flutter-autoroll
5473735956
Roll Skia from a471f253b941 to ae78024b261e (1 revision) (#182049) 
https://skia.googlesource.com/skia.git/+log/a471f253b941..ae78024b261e

2026-02-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from cf821bb30a59 to a7ed6cd3cd99 (8 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
jmbetancourt@google.com,jsimmons@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2026-02-07 11:10:26 +00:00
engine-flutter-autoroll
b606bbe85c
Roll Fuchsia Linux SDK from IOzzhWfhdzhu3zHsz... to sYqpDF9l9-kldd9_Q... (#182043) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC jsimmons@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2026-02-07 05:17:35 +00:00
engine-flutter-autoroll
670e836a69
Roll Dart SDK from 02092faa97c5 to ad6368edbe02 (2 revisions) (#182040) 
https://dart.googlesource.com/sdk.git/+log/02092faa97c5..ad6368edbe02

2026-02-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.12.0-126.0.dev
2026-02-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.12.0-125.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2026-02-07 02:45:32 +00:00
engine-flutter-autoroll
144af0100d
Roll Skia from 9a983f6c2c06 to a471f253b941 (24 revisions) (#182039) 
https://skia.googlesource.com/skia.git/+log/9a983f6c2c06..a471f253b941

2026-02-06 jmbetancourt@google.com add placeholder files to fix the
flutter roller
2026-02-06 michaelludwig@google.com [graphite] Share code for enabling
features in tests/viewer
2026-02-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from e1c390ad9841 to cf821bb30a59 (5 revisions)
2026-02-06 kylechar@google.com Fix MSAARenderToSingleSampled in
Graphite/Dawn
2026-02-06 jmbetancourt@google.com Revert "Clean-up Ganesh D3D helper
type to use smart pointers"
2026-02-06 bungeman@google.com Fix signed/unsigned comparison in ASAN
code
2026-02-06 michaelludwig@google.com [wgsl] Set sk_LastFragColor type to
correct precision
2026-02-06 thomsmit@google.com [graphite] Create DrawList Base Class
2026-02-06 kjlubick@google.com Clean-up Ganesh D3D helper type to use
smart pointers
2026-02-06 michaelludwig@google.com Revert "[graphite] Separate backend
GPU resource label update step"
2026-02-06 michaelludwig@google.com Reland "[graphite]
SkSurfaces::WrapBackendTexture doesn't require SkColorType"
2026-02-06 kjlubick@google.com Remove legacy VMA behavior from Graphite
2026-02-06
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2026-02-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from e08b8ae44d29 to e1c390ad9841 (6 revisions)
2026-02-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from 3ab51df6e556 to 11f6c7e6f928 (4 revisions)
2026-02-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from 820787f0ce0f to b6b359c68b89 (11 revisions)
2026-02-06
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2026-02-06
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2026-02-06
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2026-02-06
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2026-02-06 stephenduong@google.com Update Emscripten related code
2026-02-06 nicolettep@google.com [graphite] Separate backend GPU
resource label update step
2026-02-05 bungeman@google.com Prefer IDWriteFontFace to
IDWriteFontFamily
2026-02-05 nicolettep@google.com Add AHardwareBuffer extension as
preferred feature on Android builds

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
jmbetancourt@google.com,jsimmons@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2026-02-07 02:39:42 +00:00
gaaclarke
5f3a29abac
Add buffer around rerasterized input to fragment shaders to maintain coordinate space when clipped (#181743) 
fixes https://github.com/flutter/flutter/issues/181660

This works by changing the rerasterization logic such that we will
rerasterize the output from the blur filter to an image that matches the
dimensions of the input. The undoes the optimization of the clip rect
but standardizes the input to the fragment shader so that it is behaving
as if the input was the same as a backdrop filter without the blur
before hand.

I think there may be opportunities in the future to find a way to make
this more efficient if we could find some way to rerasterize only to the
clipped region but tweak the coordinates in the fragment shader to make
it act like it has a whole image.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2026-02-07 01:23:50 +00:00
Loïc Sharma
b5b3f9a40a
Update Flutter's style guide for dot shorthands and extension methods (#181934) 
This updates the style guide following the
[flutter.dev/go/flutter-style-updates](https://flutter.dev/go/flutter-style-updates)
Dash Forum.

Companion PR: https://github.com/flutter/flutter/pull/181985
Part of: https://github.com/flutter/flutter/issues/180607

### Gemini's style guide

This change does not update [Gemini's style
guide](https://github.com/flutter/flutter/blob/master/.gemini/styleguide.md)
since that links to Flutter's style guide.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2026-02-07 00:17:20 +00:00
Jason Simmons
3e015d2dab
Manual roll Skia from 39aa2a70213a to 9a983f6c2c06 (#181986) 
Includes updates for the renaming of SkDebug to SkLog
 2026-02-06 21:04:10 +00:00
chunhtai
4c19c37beb
Update doc in foundation to match the style guide (#181972) 
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->

doc should start with one sentence

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

---------

Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
 2026-02-06 21:04:07 +00:00
engine-flutter-autoroll
945ee8c77c
Roll Dart SDK from ec674bdb3ae4 to 02092faa97c5 (11 revisions) (#182017) 
https://dart.googlesource.com/sdk.git/+log/ec674bdb3ae4..02092faa97c5

2026-02-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.12.0-124.0.dev
2026-02-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.12.0-123.0.dev
2026-02-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.12.0-122.0.dev
2026-02-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.12.0-121.0.dev
2026-02-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.12.0-120.0.dev
2026-02-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.12.0-119.0.dev
2026-02-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.12.0-118.0.dev
2026-02-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.12.0-117.0.dev
2026-02-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.12.0-116.0.dev
2026-02-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.12.0-115.0.dev
2026-02-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.12.0-114.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2026-02-06 21:02:14 +00:00
engine-flutter-autoroll
0eab288f89
Roll Packages from c197455fc14b to 7805d3e2d654 (4 revisions) (#182016) 
c197455fc1...7805d3e2d6

2026-02-06 stuartmorgan@google.com [flutter_svg] Convert example app to
Swift (flutter/packages#10968)
2026-02-05 stuartmorgan@google.com [camera] Remove unused test file
(flutter/packages#10966)
2026-02-05 rick.hohler@gmail.com [camera_avfoundation] Handle
startWriting errors (flutter/packages#10921)
2026-02-05 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump com.google.ads.interactivemedia.v3:interactivemedia
from 3.38.0 to 3.39.0 in /packages/interactive_media_ads/android
(flutter/packages#10950)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2026-02-06 21:02:14 +00:00
auto-submit[bot]
fa51de9264
Reverts "[cupertino.dart] Implement CupertinoMenuAnchor and CupertinoMenuItem using RawMenuAnchor (#174695)" (#182010) 
<!-- start_original_pr_link -->
Reverts: flutter/flutter#174695
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: jtmcdole
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: post submits are broken

Please do not directly add to the merge queue until all presubmits pass.

#21 main.<anonymous closure>
(file:///C:/b/s/w/ir/x/w/flutter/packages/flutter/test/cupertino/menu_anchor_test.dart:969:18)

<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: davidhicks980
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {dkwingsmt}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
This PR implements `CupertinoMenuAnchor`, `CupertinoMenuItem`, and
`CupertinoMenuDivider` using `RawMenuAnchor`.

Resolves https://github.com/flutter/flutter/issues/60298,
https://github.com/notDmDrl/pull_down_button/issues/26,
https://github.com/flutter/flutter/pull/137936.


https://github.com/user-attachments/assets/551f2169-cac4-4078-890b-6728ab9c2ae5

Dartpad: https://dartpad.dev/8c6bba779b6a00e95582b61b132292bc

@dkwingsmt 

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
 2026-02-06 16:14:17 +00:00
Ivan Inozemtsev
a12bfe69b6
Update Dart SDK to 3.12 beta1 (#181948) 
There are no Dart SDK changes except that the new hash is from the beta
branch:
http://dart.googlesource.com/sdk/+diff/8f778ffd318b4e0eeb699298062dd3f1b80b2cc0..ec674bdb3ae40143cb46cd8ef2b2fd4c98fb14aa
 2026-02-06 06:22:13 +00:00
davidhicks980
48d89189bb
[cupertino.dart] Implement CupertinoMenuAnchor and CupertinoMenuItem using RawMenuAnchor (#174695) 
This PR implements `CupertinoMenuAnchor`, `CupertinoMenuItem`,
`CupertinoMenuDivider` using `RawMenuAnchor`.

Resolves https://github.com/flutter/flutter/issues/60298,
https://github.com/notDmDrl/pull_down_button/issues/26,
https://github.com/flutter/flutter/pull/137936.


https://github.com/user-attachments/assets/551f2169-cac4-4078-890b-6728ab9c2ae5

Dartpad: https://dartpad.dev/8c6bba779b6a00e95582b61b132292bc

@dkwingsmt 

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2026-02-06 06:21:10 +00:00
Mohellebi Abdessalem
cd45eb63ea
flutter_tool : Remove redundant enum types inside the enum definition scope (#181910) 
see https://discord.com/channels/608014603317936148/1468007948637831220
## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2026-02-06 04:25:30 +00:00
flutter-pub-roller-bot
0bfbce240e
Roll pub packages (#181973) 
This PR was generated by `flutter update-packages --force-upgrade`.
 2026-02-06 00:07:27 +00:00
engine-flutter-autoroll
ddd957bb2a
Roll Fuchsia Linux SDK from J2QdLcY2gyt4NP_xV... to IOzzhWfhdzhu3zHsz... (#181971) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC jsimmons@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2026-02-05 23:29:09 +00:00
Tess Strickland
93756969bb
Directly generate a Mach-O dynamic library using gen_snapshot. [reland] (#181539) 
Instead of generating assembly code that is then compiled to a Mach-O
dynamic library, use the new app-aot-macho-dylib output option for
gen_snapshot to generate the Mach-O dynamic library without the assembly
step.

This is a reland of https://github.com/flutter/flutter/pull/174870. No
changes from the previously landed PR are needed, as the fixes for the
App Store issue described in
https://github.com/flutter/flutter/issues/178602 are all on the Dart
side: https://github.com/dart-lang/sdk/commit/8cbf864.

Related issues:

* https://github.com/dart-lang/sdk/issues/43299
* https://github.com/dart-lang/sdk/issues/60307
* https://github.com/flutter/flutter/issues/178602
* https://github.com/dart-lang/sdk/issues/62414

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.
 2026-02-05 23:12:11 +00:00
Matej Knopp
692dbb71e7
macOS: Implement tooltip window controller (#180895) 
This PR implements tooltip windows on macOS.

*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2026-02-05 23:11:19 +00:00
Victor Sanni
153301ae9c
Constrain RawAutocomplete options by soft keyboard (#181930) 
Fixes [Autocomplete options overlay should automatically moves up when
soft keyboard is
visible](https://github.com/flutter/flutter/issues/157664)
Fixes b/317115348

Unblocked by https://github.com/flutter/flutter/pull/181579.

## Before



https://github.com/user-attachments/assets/586944be-6ff1-4817-980e-334bfefb6c62

## After



https://github.com/user-attachments/assets/086f4be9-0ebc-43af-b85b-3435d4144920




<details>
<summary>Sample code</summary>

```dart

import "package:flutter/material.dart";

void main() => runApp(const AutocompleteExampleApp());

/// Flutter code sample for [RawAutocomplete].

class AutocompleteExampleApp extends StatelessWidget {
  const AutocompleteExampleApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: Scaffold(
        appBar: AppBar(
          title: const Text("RawAutocomplete Basic"),
        ),
        body: const CustomScrollView(
          slivers: [
            SliverPadding(padding: EdgeInsets.symmetric(vertical: 300)),
            SliverToBoxAdapter(child: AutocompleteBasicExample()),
            SliverPadding(padding: EdgeInsets.symmetric(vertical: 700)),
          ],
        ),
      ),
    );
  }
}

class AutocompleteBasicExample extends StatelessWidget {
  const AutocompleteBasicExample({super.key});

  static const List<String> _options = <String>[
    "aardvark",
    "bobcat",
    "chameleon",
    "chameleon",
  ];

  @override
  Widget build(BuildContext context) {
    return RawAutocomplete<String>(
      optionsBuilder: (TextEditingValue textEditingValue) {
        return _options.where((String option) {
          return option.contains(textEditingValue.text.toLowerCase());
        });
      },
      fieldViewBuilder: (
        BuildContext context,
        TextEditingController textEditingController,
        FocusNode focusNode,
        VoidCallback onFieldSubmitted,
      ) {
        return TextFormField(
          controller: textEditingController,
          focusNode: focusNode,
          onFieldSubmitted: (String value) {
            onFieldSubmitted();
          },
        );
      },
      optionsViewBuilder: (
        BuildContext context,
        AutocompleteOnSelected<String> onSelected,
        Iterable<String> options,
      ) {
        return const Column(
          children: <Widget>[Expanded(child: Placeholder())],
        );
      },
    );
  }
}

```
</details>



## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

---------

Co-authored-by: Navaron Bracke <brackenavaron@gmail.com>
 2026-02-05 22:34:28 +00:00
engine-flutter-autoroll
98f02bc420
Roll Skia from 079d092f49e6 to 39aa2a70213a (1 revision) (#181970) 
https://skia.googlesource.com/skia.git/+log/079d092f49e6..39aa2a70213a

2026-02-05 bungeman@google.com Move code out of SkPath_pathdata.cpp

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
jmbetancourt@google.com,jsimmons@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2026-02-05 22:22:42 +00:00
jingweicai
e12f8c282f
perf: web ui loadFontFromList (#181440) 
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->

Optimize the loadFontFromList method of SkiaFontCollection. Reduce the
generation of unnecessary FontMgr.

issue: https://github.com/flutter/flutter/issues/181439


## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

Co-authored-by: Mouad Debbar <mdebbar@google.com>
 2026-02-05 22:12:40 +00:00
Ashok Narayan
3e034fce05
Improve accessibility contrast for pre-test message (#180469) 
Fixes https://github.com/flutter/flutter/issues/179181

The pre-test message "Test starting..." previously had a contrast ratio
of 2.99:1 against the background, which is below the recommended 3:1
minimum for accessibility.

This PR slightly adjusts the text color from 0xFF917FFF to 0xFF8F7FFF
to meet the minimum contrast requirement while preserving the visual
appearance.
 2026-02-05 21:22:24 +00:00
flutter-pub-roller-bot
60e001eeaa
Roll pub packages (#181965) 
This PR was generated by `flutter update-packages --force-upgrade`.
 2026-02-05 20:30:10 +00:00
engine-flutter-autoroll
cdcd25e68e
Roll Skia from 8543ce512d5c to 079d092f49e6 (8 revisions) (#181964) 
https://skia.googlesource.com/skia.git/+log/8543ce512d5c..079d092f49e6

2026-02-05 bungeman@google.com Prefer IDWriteFontFace to IDWriteFont
2026-02-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 5019d2a78945 to e08b8ae44d29 (1 revision)
2026-02-05 fmalita@google.com [skottie wasm] Use an actual font manager
for font resolution
2026-02-05 fmalita@google.com Embedded fontmgr load_font_from_data
should observe the instance index
2026-02-05 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll
vulkan-deps from 741ee9da829e to 5019d2a78945 (15 revisions)
2026-02-05 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll
Dawn from 56987efeebe8 to 8c7af65088cf (30 revisions)
2026-02-05 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll
ANGLE from ff5723672e4c to 3ab51df6e556 (15 revisions)
2026-02-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from 931a4fafbe2a to 820787f0ce0f (21 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
jmbetancourt@google.com,jsimmons@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2026-02-05 20:16:22 +00:00
Mairramer
20ba8a0035
Add clearError API to Form and FormFieldState (#180752) 
This PR introduces a `clearError` API for `FormFieldState` and
`FormState`, allowing
validation errors to be cleared without resetting field values or
re-running
validation.

Closes #178805

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2026-02-05 19:22:24 +00:00
Elijah Okoroh
93df033057
Bump minimum required Xcode version to 15 and recommended to 16 (#180531) 
This PR updates the Flutter tool's Xcode version requirements:

- **Minimum required version**: 14 → 15
- **Recommended version**: 15 → 16

*List which issues are fixed by this PR. You must list at least one
issue. An issue is not required if the PR fixes something trivial like a
typo.*

Fixes #144582

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2026-02-05 18:54:09 +00:00
Giancarlo Cante
2dd672d6ca
Rename "widgetTester" parameter to "tester" in "WidgetTesterCallback" (#180944) 
Fixes #180476

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
 2026-02-05 18:48:58 +00:00
engine-flutter-autoroll
37549677e3
Roll Packages from 3bddf2c57eed to c197455fc14b (3 revisions) (#181962) 
3bddf2c57e...c197455fc1

2026-02-05 engine-flutter-autoroll@skia.org Roll Flutter from
bf701fefec86 to f916dd6887bf (44 revisions) (flutter/packages#10967)
2026-02-05 stuartmorgan@google.com [webview_flutter] Fix crash in iOS
external native API (flutter/packages#10959)
2026-02-04 8014077+Frank3K@users.noreply.github.com [google_fonts] Fix
file type priority in asset path lookup (flutter/packages#10907)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2026-02-05 18:47:56 +00:00
Jason Simmons
515d8a6414
Temporarily remove the Pixel 9/API 36 device from the Firebase Test Lab tests. (#181956) 
There appears to be a Firebase outage that currently affects this device
type.

See https://github.com/flutter/flutter/issues/181954
 2026-02-05 17:43:13 +00:00
nmarci89
f916dd6887
Implement macOS wide gamut (Display P3) support (#181769) 
Adds wide gamut color support to macOS (matching iOS), upgrades the
surface pixel format from 10-bit BGRA10_XR to 16-bit float RGBA16Float
on both iOS and macOS when enabled, and fixes Impeller's blur filter P3
clamping on macOS.

**macOS Wide Gamut Support**
- Added DoesHardwareSupportWideGamut() hardware capability check
(MTLGPUFamilyApple2 or MTLGPUFamilyMac2)
- Wide gamut enabled when both hardware supports it and
FLTEnableWideGamut plist flag is YES
- Dynamic wide gamut switching when windows move between P3 and sRGB
displays
- Added flutter/screenshot method channel on macOS for integration
testing

**RGBA16Float Surface Format (iOS + macOS)**
- macOS IOSurface: kCVPixelFormatType_64RGBAHalf +
MTLPixelFormatRGBA16Float
- iOS CAMetalLayer: MTLPixelFormatRGBA16Float
- Image decoder: always uses kRGBA_F16_SkColorType for all wide gamut
images (previously only transparent images used 16-bit)

**Fix Blur P3 Clamping on macOS**
macOS uses the compositor/embedder path, not GPUSurfaceMetalImpeller, so
UpdateOffscreenLayerPixelFormat was never called. Added the call in
embedder.cc after wrapping the Metal resolve texture.

**Why RGBA16Float over BGRA10_XR?**
BGRA10_XR has only 10 bits per channel — values outside sRGB gamut get
clamped in intermediate render targets (e.g. blur filters). RGBA16Float
has 16 bits per channel with full floating-point range, preventing P3
color clamping in multi-pass rendering.

**Tests**
- 9 new iOS FlutterView unit tests verifying RGBA16Float pixel format
and extended sRGB color space
- Updated macOS FlutterSurfaceManagerTest for RGBA16Float, dynamic
switching, color space, and pixel format verification
- Updated image decoder and Impeller display list tests for
kR16G16B16A16Float
- 11 macOS/iOS integration tests: image, saveLayer, codecImage, none,
blur, drawnImage, container, linearGradient, radialGradient,
conicalGradient, sweepGradient

### Issues
https://github.com/flutter/flutter/issues/164557

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
 2026-02-05 00:27:27 +00:00
engine-flutter-autoroll
70d9d31880
Roll Skia from d23ecfbfdff9 to 8543ce512d5c (3 revisions) (#181923) 
https://skia.googlesource.com/skia.git/+log/d23ecfbfdff9..8543ce512d5c

2026-02-04 robertphillips@google.com [graphite] First whack at making
YCbCr combination method
2026-02-04 thomsmit@google.com [graphite] Fix SDF LCD Atlas Indexing Bug
2026-02-04 kjlubick@google.com Add Bazel-viewer-Mac job to CI

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
jmbetancourt@google.com,jsimmons@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2026-02-04 23:44:09 +00:00
engine-flutter-autoroll
934be734a0
Roll Dart SDK from 8001c99d952b to 8f778ffd318b (3 revisions) (#181927) 
https://dart.googlesource.com/sdk.git/+log/8001c99d952b..8f778ffd318b

2026-02-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.12.0-113.0.dev
2026-02-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.12.0-112.0.dev
2026-02-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.12.0-111.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2026-02-04 23:44:09 +00:00
Jason Simmons
6909aaee71
Re-enable AddressSanitizer on the linux_unopt builder (#181741) 
ASan had been disabled due to issues that were seen when the LUCI bots
were upgraded to Ubuntu 24. That upgrade was reverted, and ASan can be
run on the current Ubuntu 22 bots.

Fixes https://github.com/flutter/flutter/issues/181639
 2026-02-04 23:42:24 +00:00
Reid Baker
2693765e62
Add exception to log message in ContentSizingFlag.java (#181813) 
No bug
Gemini code review suggestion on a cp that should instead be made on
master.
https://github.com/flutter/flutter/pull/181732/files#r2747693178 
## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
 2026-02-04 22:58:15 +00:00
flutter-pub-roller-bot
836f7bd457
Roll pub packages (#181925) 
This PR was generated by `flutter update-packages --force-upgrade`.
 2026-02-04 22:49:27 +00:00
Nicholas Shahan
3d4a270c75
[flutter_tools] Deprecate web hot reload flag (#181884) 
Warn when the flag is passed, and prompt to file an issue if disabling
is required for a web development workflow.

The flag is enabled by default. It is still functional, but will be
removed in an upcoming release.
 2026-02-04 21:52:16 +00:00
Jenn Magder
4664d568b5
Marks platform_views_scroll_perf_impeller__timeline_summary unflaky (#181649) 
[Last 50 commits were
unflaky.](https://data.corp.google.com/sites/dash_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux_pixel_7pro%20platform_views_scroll_perf_impeller__timeline_summary%22)

Previous flakes were infra issues "devices not found", which should be
resolved separately.
Fixes https://github.com/flutter/flutter/issues/172210.
 2026-02-04 20:40:18 +00:00
engine-flutter-autoroll
e54ff3142e
Roll Dart SDK from 204db085d970 to 8001c99d952b (1 revision) (#181902) 
https://dart.googlesource.com/sdk.git/+log/204db085d970..8001c99d952b

2026-02-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.12.0-110.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2026-02-04 20:20:30 +00:00
engine-flutter-autoroll
8ef9901e0f
Roll Skia from f37a22506eb4 to d23ecfbfdff9 (23 revisions) (#181915) 
https://skia.googlesource.com/skia.git/+log/f37a22506eb4..d23ecfbfdff9

2026-02-04 fmalita@google.com Relocate test jpg to invalid_images/
2026-02-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from 835068588b2b to 931a4fafbe2a (16 revisions)
2026-02-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from ce049a4f0ed3 to 741ee9da829e (3 revisions)
2026-02-04 borenet@google.com [infra] Windows P400 machines have updated
to Win11
2026-02-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from 6381c90aa5c6 to ff5723672e4c (10 revisions)
2026-02-04
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2026-02-03 kjlubick@google.com Avoid use of uninitialized memory in
GrVkCaps.cpp
2026-02-03
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2026-02-03 ccameron@chromium.org kR8_unorm_SkColorType: Add D3D and
Metal support
2026-02-03 alexisdavidc@google.com first commit
2026-02-03 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll
Dawn from d056298c4999 to 56987efeebe8 (7 revisions)
2026-02-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from d7139503a3f3 to 6381c90aa5c6 (5 revisions)
2026-02-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from 3d03ba33dbea to 835068588b2b (14 revisions)
2026-02-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from 4764cd21387f to d056298c4999 (16 revisions)
2026-02-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from f4b93854afd1 to ce049a4f0ed3 (3 revisions)
2026-02-03
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2026-02-02
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2026-02-02 michaelludwig@google.com Reland "[graphite] Consolidate
colortype info functions into Caps"
2026-02-02
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2026-02-02 kjlubick@google.com Update Bazel rules to build viewer on Mac
& Windows
2026-02-02 bwils@google.com Add default values for corner pin effect.
2026-02-02 robertphillips@google.com [graphite] Update Precompilation
testing framework
2026-02-02 fmalita@google.com Fix invalid JPEG stream state

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
jmbetancourt@google.com,jsimmons@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2026-02-04 20:16:45 +00:00
Jason Simmons
f539ad0bfe
In the Web codec tests, skip an undecodable image that is used to test a Skia error handling code path. (#181870) 
A recent Skia change added an invalid image file that tests a decoding
failure case (see
https://skia.googlesource.com/skia/+/12cb69b2700acfccee52bacf63321800af8c138c)

That file should be excluded from the set of Skia image assets used by
the Flutter Web codec tests.
 2026-02-04 20:13:18 +00:00
engine-flutter-autoroll
ae49c60c5e
Roll Packages from 5b1bea87e8b9 to 3bddf2c57eed (5 revisions) (#181918) 
5b1bea87e8...3bddf2c57e

2026-02-04 ivan-vanyusho@yandex-team.ru [camera_avfoundation] ios saving
path (flutter/packages#10832)
2026-02-04 stuartmorgan@google.com [video_player] Remove OCMock
(flutter/packages#10932)
2026-02-04 stuartmorgan@google.com [google_maps_flutter] Remove use of
OCMock (flutter/packages#10863)
2026-02-04 32538273+ValentinVignal@users.noreply.github.com
[go_router_builder] Add support for `@TypedGoRouteParameter` to
customize parameter names (flutter/packages#10793)
2026-02-03 engine-flutter-autoroll@skia.org Roll Flutter from
c305f1f7ad35 to bf701fefec86 (9 revisions) (flutter/packages#10957)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2026-02-04 20:13:17 +00:00
engine-flutter-autoroll
2beceb6b1c
Roll Fuchsia Linux SDK from UmQaaNuhkiuE8Dzug... to J2QdLcY2gyt4NP_xV... (#181893) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC jsimmons@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2026-02-04 08:50:40 +00:00
engine-flutter-autoroll
776136d499
Roll Dart SDK from 54322a0b1109 to 204db085d970 (3 revisions) (#181890) 
https://dart.googlesource.com/sdk.git/+log/54322a0b1109..204db085d970

2026-02-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.12.0-109.0.dev
2026-02-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.12.0-108.0.dev
2026-02-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.12.0-107.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2026-02-04 06:57:25 +00:00
Nurda
3f9fa4cb01
Cleanup cross imports (#181807) 
Remove material from widgets tests:

- reassemble_test.dart
- page_storage_test.dart

Part of https://github.com/flutter/flutter/issues/177415
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->
## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

[![talabat.com
contributions](https://img.shields.io/badge/talabat.com-contributions-FF5A00?style=flat&logo=flutter&logoColor=white)](https://www.talabat.com)
[![Talabat Flutter
PRs](https://img.shields.io/badge/Talabat_Flutter_PRs-16%20merged-97ca00?style=flat&logo=flutter&logoColor=white)](https://github.com/search?q=org%3Aflutter+talabat&type=pullrequests)
 2026-02-04 06:53:23 +00:00
Kazbek Sultanov
9d58e0674f
[Material] Remove Material import from backdrop_filter_test.dart widget tests (#181386) 
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->

Migrate backdrop_filter_test.dart to use only widget imports following
issue #177415. Split the tests into two files:

- Widgets tests
(packages/flutter/test/widgets/backdrop_filter_test.dart):
  * Removed Material import, now uses widgets-only
  * Replaced MaterialApp + Scaffold with Directionality wrapper
  * Replaced Colors.black.withAlpha(40) with Color(0x28000000)
  * Kept 2 tests that validate BackdropFilter key behavior

- Material tests
(packages/flutter/test/material/backdrop_filter_test.dart):
  * Moved 4 Material-specific golden file tests (M2/M3 comparisons)
* These tests require Material theming to validate rendering differences

- Updated dev/bots/check_tests_cross_imports.dart to remove
backdrop_filter_test.dart

This approach keeps Material-specific tests in the material directory
while enabling the simple widget tests to pass without Material
dependencies.

Part of:  #177415

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md


[![talabat.com](https://img.shields.io/badge/talabat.com-contributions-FF5A00?style=flat&logo=flutter&logoColor=white)](https://www.talabat.com)
[![Talabat Flutter
PRs](https://img.shields.io/badge/Talabat_Flutter_PRs-10%20merged-97ca00?style=flat&logo=flutter&logoColor=white)](https://github.com/search?q=org%3Aflutter+talabat&type=pullrequests)

---------

Co-authored-by: Mohellebi Abdessalem <116356835+AbdeMohlbi@users.noreply.github.com>
 2026-02-04 05:54:29 +00:00
Kazbek Sultanov
e228f69947
Move CheckedModeBanner tests to material and remove Material import from widgets banner_test (#181261) 
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->

Move Material-specific Banner tests to the appropriate test file:
- `Banner widget in MaterialApp` test moved to material/banner_test.dart
- `CheckedModeBanner does not crash at zero area` test moved to
material/banner_test.dart

Remove Material import from `widgets/banner_test.dart` since all
remaining tests only use widgets-level BannerPainter and BannerLocation
APIs.

Update cross imports list to remove banner_test.dart from
knownWidgetsCrossImports.

All tests pass and no formatting issues detected.

Contributes to: https://github.com/flutter/flutter/issues/177412

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md


[![talabat.com](https://img.shields.io/badge/talabat.com-contributions-FF5A00?style=flat&logo=flutter&logoColor=white)](https://www.talabat.com)
[![Talabat Flutter
PRs](https://img.shields.io/badge/Talabat_Flutter_PRs-10%20merged-97ca00?style=flat&logo=flutter&logoColor=white)](https://github.com/search?q=org%3Aflutter+talabat&type=pullrequests)

---------

Co-authored-by: Navaron Bracke <brackenavaron@gmail.com>
 2026-02-04 04:12:13 +00:00