engine-flutter-autoroll
5903a8cf6e
Roll Flutter Engine from a26a479e86b3 to 1c4b6c0cb862 (1 revision) ( #125463 )
...
a26a479e86...1c4b6c0cb8skia-flutter-autoroll@skia.org Roll Skia from 2c0f33c7ec04 to 9b1b2a5dd899 (2 revisions) (flutter/engine#41473 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-25 09:13:25 +00:00
Taha Tesser
6e1d4f9fc6
Fix SliverAppBar.medium & SliverAppBar.large text scale ( #125038 )
...
fixes https://github.com/flutter/flutter/issues/114340
<details>
<summary>code sample</summary>
```dart
import 'package:flutter/material.dart';
/// Flutter code sample for [SliverAppBar.medium].
void main() {
runApp(const AppBarMediumApp());
}
class AppBarMediumApp extends StatelessWidget {
const AppBarMediumApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
theme: ThemeData(
useMaterial3: true,
),
home: MediaQuery(
data: MediaQuery.of(context).copyWith(textScaleFactor: 3.0),
child: Material(
child: CustomScrollView(
slivers: <Widget>[
SliverAppBar.medium(
leading:
IconButton(icon: const Icon(Icons.menu), onPressed: () {}),
title: const Text('Medium App Bar'),
actions: <Widget>[
IconButton(icon: const Icon(Icons.more_vert), onPressed: () {}),
],
),
// SliverAppBar.large(
// leading:
// IconButton(icon: const Icon(Icons.menu), onPressed: () {}),
// title: const Text('Large App Bar'),
// actions: <Widget>[
// IconButton(
// icon: const Icon(Icons.more_vert), onPressed: () {}),
// ],
// ),
// Just some content big enough to have something to scroll.
SliverToBoxAdapter(
child: Card(
child: SizedBox(
height: 1200,
child: Padding(
padding: const EdgeInsets.fromLTRB(8, 100, 8, 100),
child: Text(
'Here be scrolling content...',
style: Theme.of(context).textTheme.headlineSmall,
),
),
),
),
),
],
),
),
),
);
}
}
```
</details>
### Before
| Medium App Bar - `textScaleFactor: 3.0` | Large App Bar - `textScaleFactor.30` |
| --------------- | --------------- |
| <img src="https://user-images.githubusercontent.com/48603081/232815191-ab42523b-d710-4c93-a889-e9c92ca472c8.png " height="450" /> | <img src="https://user-images.githubusercontent.com/48603081/232815232-104c208d-f1dd-404e-9218-5dfb61244d56.png " height="450" /> |
### After
| Medium App Bar - `textScaleFactor: 3.0` | Large App Bar - `textScaleFactor.30` |
| --------------- | --------------- |
| <img src="https://user-images.githubusercontent.com/48603081/232815733-8b8af94f-197f-427a-bbb9-bc6cd0173658.png " height="450" /> | <img src="https://user-images.githubusercontent.com/48603081/232815758-2c336d14-085b-4e91-8b93-748a40822ea6.png " height="450" /> |
2023-04-25 08:27:24 +00:00
engine-flutter-autoroll
8395a2b2a1
Roll Flutter Engine from 3f4116c225e8 to a26a479e86b3 (1 revision) ( #125459 )
...
3f4116c225...a26a479e86skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from gxpKJcSBfY7AuR_Ur... to 5bc9_eyVcLoMrWvdO... (flutter/engine#41471 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from gxpKJcSBfY7A to 5bc9_eyVcLoM
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-25 08:00:07 +00:00
engine-flutter-autoroll
597cc8f9d0
Roll Flutter Engine from 64882f4b7371 to 3f4116c225e8 (2 revisions) ( #125458 )
...
64882f4b73...3f4116c225skia-flutter-autoroll@skia.org Roll Skia from 8822608fcb4d to 2c0f33c7ec04 (1 revision) (flutter/engine#41470 )
2023-04-25 skia-flutter-autoroll@skia.org Roll Skia from 5f4dd36a69f9 to 8822608fcb4d (2 revisions) (flutter/engine#41469 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-25 07:14:22 +00:00
engine-flutter-autoroll
5817ed4777
Roll Flutter Engine from 8fe8e94c02fc to 64882f4b7371 (1 revision) ( #125454 )
...
8fe8e94c02...64882f4b73godofredoc@google.com [Cleanup] remove type=local from local test/generators. (flutter/engine#41465 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-25 05:04:24 +00:00
engine-flutter-autoroll
d23dba223c
Roll Flutter Engine from 5fbde6c0fc57 to 8fe8e94c02fc (10 revisions) ( #125452 )
...
5fbde6c0fc...8fe8e94c02jonahwilliams@google.com Revert "[impeller] convert src over to src for solid color" (flutter/engine#41466 )
2023-04-24 godofredoc@google.com Remove empty tests properties. (flutter/engine#41461 )
2023-04-24 skia-flutter-autoroll@skia.org Roll Skia from 0ec4c84abd0b to 5f4dd36a69f9 (21 revisions) (flutter/engine#41462 )
2023-04-24 godofredoc@google.com Reland "Upload windows arm artifacts to production bucket." (flutter/engine#41409 )
2023-04-24 skia-flutter-autoroll@skia.org Roll Dart SDK from c7042dc03f43 to c3afc3507b4f (1 revision) (flutter/engine#41458 )
2023-04-24 54558023+keyonghan@users.noreply.github.com Add 16.2 runtime to Mac unopt (flutter/engine#41456 )
2023-04-24 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from EEdHfWcEn3fHwQj46... to gxpKJcSBfY7AuR_Ur... (flutter/engine#41453 )
2023-04-24 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from fJ7ysM-O4VYAGeBDc... to 8TJtGsJTpIHk5-Ss5... (flutter/engine#41451 )
2023-04-24 skia-flutter-autoroll@skia.org Roll Dart SDK from a1c1e0d3bb18 to c7042dc03f43 (2 revisions) (flutter/engine#41452 )
2023-04-24 skia-flutter-autoroll@skia.org Roll Skia from 1f84e5060646 to 0ec4c84abd0b (6 revisions) (flutter/engine#41449 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from fJ7ysM-O4VYA to 8TJtGsJTpIHk
fuchsia/sdk/core/mac-amd64 from EEdHfWcEn3fH to gxpKJcSBfY7A
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-25 04:12:18 +00:00
Taha Tesser
457e98a1e7
Add Sliders to macrobenchmarks ( #125296 )
...
This adds a performance test for `Slider` and `RangeSlider` to run on Android.
This is to measure upcoming changes to these widgets and compare their performance.
https://user-images.githubusercontent.com/48603081/233633349-0bcad3c3-04a9-42dd-acd0-46b76ce51178.mp4
2023-04-24 23:25:28 +00:00
Tirth
9525934ed3
[date_picker] [date_range_picker] add properties to change switch-to icons ( #124881 )
2023-04-24 16:20:21 -07:00
Tae Hyung Kim
482d1aaf13
Sliver Constrained Cross Axis ( #125239 )
...
Reimplements what we reverted here: #125233 .
2023-04-24 23:17:36 +00:00
Kevin Moore
7d9f2082f1
tool: Move cdKey to CustomDimensionsEnum ( #125335 )
2023-04-24 22:59:20 +00:00
Bernardo Ferrari
9e9ac77dea
Add borderRadius to LinearProgressIndicator ( #123517 )
...
Split from https://github.com/flutter/flutter/pull/122664 so it gets easier to review, as this is now unrelated to the `preferRound`. I'm one step from adding a width attribute, lol.
<img width="474" alt="image" src="https://user-images.githubusercontent.com/351125/226083798-71e529e9-4ae9-41de-a500-0412b989a273.png ">
cc @Piinks
2023-04-24 22:43:05 +00:00
Srujan Gaddam
aa5bb7d92e
Fix JS types in _test_http_request.dart ( #125220 )
...
Types are being reified in the JS backends, so these need to be
addressed. Fixes two issues:
- @staticInterop types need to be casted to JS types
- JS functions need to be cast to JSFunction before conversion
Enables landing of https://dart-review.googlesource.com/c/sdk/+/295105 .
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.
2023-04-24 14:48:27 -07:00
Taha Tesser
38c7c2fe93
Fix OutlinedButton, TextButton, and IconButton throw exception when passing only one cursor to styleFrom ( #125204 )
...
fixes https://github.com/flutter/flutter/issues/118071
2023-04-24 21:41:06 +00:00
Jenn Magder
b7332ef10a
Swap some iOS TESTOWNERS ( #125340 )
...
Temporarily remove myself from `TESTOWNER` and reassign to others. Please let me know if you'd rather not "own" these and I'll find someone else ð. I intend to take these back later.
Plugins -> @stuartmorgan
iOS-specific tooling -> @vashworth
Benchmark and app extension test -> @cyanglaz
iOS artifact checking -> @christopherfujino
2023-04-24 21:39:22 +00:00
Renzo Olivares
1a51dc2131
Fix iOS touch drag behavior ( #125169 )
...
Before this change on a quick touch drag the cursor, where the touch is not on the previous collapsed selection, the cursor would move to the tapped position.
After this change on a quick touch drag the cursor does not move unless the touch is on the previously collapsed selection. This is inline with native behavior.
Before|After|Native
--|--|--
<video src="https://user-images.githubusercontent.com/948037/233224775-f33b42b5-5638-416c-9278-39ecd964e3bb.mov " />|<video src="https://user-images.githubusercontent.com/948037/233224760-2d1af657-8d99-45fc-8499-9567f17d533e.mov " />|<video src="https://user-images.githubusercontent.com/948037/233224790-f5997cfa-7370-4891-8952-11ef8057a729.mov " />
2023-04-24 19:25:21 +00:00
keyonghan
624bdd38b0
Mark module_test_ios flaky ( #125426 )
...
https://github.com/flutter/flutter/issues/125425
2023-04-24 18:46:50 +00:00
chunhtai
3b4ac4d5cc
Implement url support for RouteInformation and didPushRouteInformation ( #119968 )
...
Related https://github.com/flutter/flutter/issues/100624
The goal is to make sure the engine can send a location string in either the existing format or a complete uri string to the framework, and the framework will still work as usual.
2023-04-24 18:33:24 +00:00
Kevin Moore
034adb66cc
[tool,web] Include more info URI on Wasm init failure ( #125312 )
2023-04-24 18:33:21 +00:00
Jenn Magder
9e2e64c7c0
Do not run windows_home_scroll_perf__timeline_summary benchmark in presubmit ( #125343 )
...
Introduced in https://github.com/flutter/flutter/pull/99564 . Checked with @jonahwilliams and this should not be running in presubmit.
2023-04-24 18:33:21 +00:00
fzyzcjy
c1e41b4304
Tiny fix doc pointing to incorrect widget confusing the readers ( #125394 )
...
Just a one-word super tiny change, which I encounter today when playing with RawGestureDetector :)
The original doc says:
> For common gestures, use a [GestureRecognizer](https://api.flutter.dev/flutter/gestures/GestureRecognizer-class.html ). [RawGestureDetector](https://api.flutter.dev/flutter/widgets/RawGestureDetector-class.html ) is useful primarily when developing your own gesture recognizers.
However, for "common gestures", IMHO the doc wants to say `GestureDetector` (because that one has easy-to-use onTap, onLongPress etc). On the other hand, GestureRecognizer should be used together with RawGestureDetector and is a quite low-level thing, and for common gestures people seldom use it. So I guess here it is a typo.
2023-04-24 18:33:18 +00:00
Justin McCandless
98aaf00a09
Fix the position of the Android-style spell check toolbar ( #124897 )
...
The spell check menu now appears directly below the misspelled word on Android.
2023-04-24 10:26:47 -07:00
engine-flutter-autoroll
3ab8cd2615
Roll Flutter Engine from fcf46af2d38c to 5fbde6c0fc57 (4 revisions) ( #125410 )
...
fcf46af2d3...5fbde6c0fcflutter/engine#41444 )
2023-04-24 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from kZQW1hC63MessR4gl... to EEdHfWcEn3fHwQj46... (flutter/engine#41441 )
2023-04-24 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 1RnHwa4NRXqe4iS6H... to fJ7ysM-O4VYAGeBDc... (flutter/engine#41440 )
2023-04-23 skia-flutter-autoroll@skia.org Roll Skia from b9c90858cdd8 to 1f84e5060646 (1 revision) (flutter/engine#41432 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 1RnHwa4NRXqe to fJ7ysM-O4VYA
fuchsia/sdk/core/mac-amd64 from kZQW1hC63Mes to EEdHfWcEn3fH
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-24 14:49:13 +00:00
Kevin Chisholm
a00babf47b
[Process] Update cherry-pick template assignees ( #125402 )
...
Updates the cherry-pick template to add @itsjustkevin as primary and
@CaseyHillers as secondary assignees to all cherry-pick requests.
2023-04-24 07:10:03 -07:00
engine-flutter-autoroll
60077ff979
Roll Flutter Engine from 0e329d5e2196 to fcf46af2d38c (1 revision) ( #125384 )
...
0e329d5e21...fcf46af2d3skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from KWUhrqWF9DaVpikxZ... to kZQW1hC63MessR4gl... (flutter/engine#41430 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from KWUhrqWF9DaV to kZQW1hC63Mes
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-23 11:09:16 +00:00
engine-flutter-autoroll
e4b2a5abdc
Roll Flutter Engine from f364492e2010 to 0e329d5e2196 (1 revision) ( #125381 )
...
f364492e20...0e329d5e21skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from I9z-K7N5PdhXN-5SG... to 1RnHwa4NRXqe4iS6H... (flutter/engine#41428 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from I9z-K7N5PdhX to 1RnHwa4NRXqe
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-23 08:03:36 +00:00
engine-flutter-autoroll
6382136e1f
Roll Flutter Engine from b6749106a482 to f364492e2010 (7 revisions) ( #125378 )
...
b6749106a4...f364492e20skia-flutter-autoroll@skia.org Roll Dart SDK from fd4797c1464b to a1c1e0d3bb18 (1 revision) (flutter/engine#41427 )
2023-04-22 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from qLDaxNMysjqL-IcPn... to KWUhrqWF9DaVpikxZ... (flutter/engine#41426 )
2023-04-22 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from RdOaZ2-aDsn_64hk5... to I9z-K7N5PdhXN-5SG... (flutter/engine#41424 )
2023-04-22 skia-flutter-autoroll@skia.org Roll Dart SDK from be6db2b60a41 to fd4797c1464b (2 revisions) (flutter/engine#41422 )
2023-04-22 skia-flutter-autoroll@skia.org Roll Skia from 9912500bcca3 to b9c90858cdd8 (2 revisions) (flutter/engine#41421 )
2023-04-22 skia-flutter-autoroll@skia.org Roll Dart SDK from b6de2d42e58d to be6db2b60a41 (2 revisions) (flutter/engine#41416 )
2023-04-22 skia-flutter-autoroll@skia.org Roll Skia from 36a6690cd1f1 to 9912500bcca3 (2 revisions) (flutter/engine#41415 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from RdOaZ2-aDsn_ to I9z-K7N5PdhX
fuchsia/sdk/core/mac-amd64 from qLDaxNMysjqL to KWUhrqWF9DaV
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-23 04:41:22 +00:00
engine-flutter-autoroll
d2646cf87d
Roll Flutter Engine from d96a09559ebf to b6749106a482 (2 revisions) ( #125350 )
...
d96a09559e...b6749106a4skia-flutter-autoroll@skia.org Roll Skia from aa592c60846d to 36a6690cd1f1 (11 revisions) (flutter/engine#41413 )
2023-04-22 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from fMOcI5zn1z0nOrV7s... to qLDaxNMysjqL-IcPn... (flutter/engine#41412 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from fMOcI5zn1z0n to qLDaxNMysjqL
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-22 03:06:17 +00:00
Nabeel Parkar
1c56c565f5
Migrate new feature issue template to GitHub forms ( #123682 )
...
Fixes https://github.com/flutter/flutter/issues/119919
<details>
<summary>Preview</summary>
</details>
2023-04-22 02:40:20 +00:00
Callum Moffat
e84daf3b70
Adjust selection rects inclusion criteria ( #125022 )
...
Include rects with any overlap instead of only when top-left or bottom-right included. The previous criteria didn't send any selection rects when text was taller than the text box and scroll offset was not zero.
Part of #30476
2023-04-22 01:40:20 +00:00
Nate Bosch
1789a4244b
Remove some ignores for un-deprecated imports ( #125261 )
...
The latest version of `test_api` removed the deprecated annotation for a couple libraries. The deprecations had been a hack to avoid usage from inappropriate places, but they cause trouble and likely weren't effective for that goal.
Remove separate import for `registerException` since that was also moved to be available from the top level `scaffolding.dart` library.
2023-04-22 01:04:24 +00:00
engine-flutter-autoroll
dff451ece6
Roll Flutter Engine from 462e9bbb8469 to d96a09559ebf (5 revisions) ( #125346 )
...
462e9bbb84...d96a09559eskia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Edv0I0o8GQ7c0z8XK... to RdOaZ2-aDsn_64hk5... (flutter/engine#41407 )
2023-04-21 skia-flutter-autoroll@skia.org Roll Dart SDK from fabaeef00dfb to b6de2d42e58d (2 revisions) (flutter/engine#41401 )
2023-04-21 jason-simmons@users.noreply.github.com [Impeller] Add a CommandBuffer::WaitUntilScheduled API (flutter/engine#41303 )
2023-04-21 30870216+gaaclarke@users.noreply.github.com [Impeller] Turned off the TextRotated golden test again (flutter/engine#41399 )
2023-04-21 skia-flutter-autoroll@skia.org Roll Skia from 5754b81988b8 to aa592c60846d (11 revisions) (flutter/engine#41398 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from Edv0I0o8GQ7c to RdOaZ2-aDsn_
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-22 00:54:14 +00:00
Kevin Moore
702f0144e0
[tool,web] track web-renderer, and Wasm build args in analytics ( #125336 )
...
Addresses part of https://github.com/flutter/flutter/issues/125164
2023-04-21 23:09:00 +00:00
Luccas Clezar
f86b9220a3
Update Cupertino desktop text selection toolbar ( #121829 )
...
Visual fidelity of the right-click context menu on MacOS.
2023-04-21 16:03:34 -07:00
chunhtai
8a815c1d1d
Remove unecessary reference to ClipboardStatusNotifier ( #125255 )
...
fixes https://github.com/flutter/flutter/issues/99360
2023-04-21 22:38:06 +00:00
Jenn Magder
baafa1991d
Combine flutter_tool_startup devicelab tests ( #125226 )
...
`flutter_tool_startup__windows/linux/macos` were identical. Use the same task for all three.
2023-04-21 22:33:07 +00:00
Jenn Magder
a2c247117b
Remove self from CODEOWNERS ( #125337 )
...
Remove self from `CODEOWNERS` file for `flutter_tools`. Now that we have the PR cocoon labeler the tools team should see any PRs that change these files, and tag the right people to review.
Also remove ownership of the `CODEOWNERS` file itself.
2023-04-21 22:33:05 +00:00
Jenn Magder
152f160508
Swap bundler dependabot reviewers ( #125333 )
...
Remove myself as a the CocoaPods gem [dependabot](https://github.blog/2020-06-01-keep-all-your-packages-up-to-date-with-dependabot/ ) reviewer and add @christopherfujino and @vashworth instead for Ruby gem bumps:
3a436f47f5/dev/ci/mac/Gemfilehttps://github.com/flutter/flutter/pulls?q=is%3Apr+dependabot+cocoapods+is%3Aclosed
Note the last minor version was ignored https://github.com/flutter/flutter/pull/122051 due to https://github.com/flutter/flutter/issues/122057 .
We have pretty good plugins/CocoaPods test coverage, so if that infra issue were fixed we should feel pretty safe about bumping this if all the tests pass.
2023-04-21 22:26:18 +00:00
Christopher Fujino
1561b65812
add gradle error handler for when the remote ssl host terminates handshake process ( #125270 )
...
Will fix transient network failures as in: https://github.com/flutter/flutter/issues/125108#issuecomment-1516519929
2023-04-21 21:59:10 +00:00
Hugo
d93ffc10c4
Fix the divider_theme space documentation problem ( #125195 )
...
In the specific implementation, the Divider uses the "space" field as the height for horizontal dividers, and the "space" field as the width for VerticalDivider , which is different from the documentation description.
2023-04-21 21:59:08 +00:00
Polina Cherkasova
3a436f47f5
Upgrade leak_tracker. ( #125272 )
2023-04-21 13:49:23 -07:00
engine-flutter-autoroll
d727aaf2e1
Roll Flutter Engine from dd67063fc921 to 462e9bbb8469 (3 revisions) ( #125324 )
...
dd67063fc9...462e9bbb8430870216+gaaclarke@users.noreply.github.com [impeller] fixed flake where blit wasn't tracking its texture (flutter/engine#41347 )
2023-04-21 121665385+andoriyaprashant@users.noreply.github.com removing the check_gn_format.py file from ci/ (flutter/engine#41397 )
2023-04-21 ditman@gmail.com [web] Fix HashUrlStrategy.addPopStateListener (flutter/engine#41384 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-21 19:31:38 +00:00
Greg Spencer
11f8ee5bb0
Add docs for kIsWeb on defaultTargetPlatform ( #125313 )
...
## Description
Adding some see also links to connect `defaultTargetPlatform` and `kIsWeb` docs.
2023-04-21 19:11:29 +00:00
engine-flutter-autoroll
c9004ff822
Roll Flutter Engine from 3f7e12b8e656 to dd67063fc921 (1 revision) ( #125316 )
...
3f7e12b8e6...dd67063fc9bdero@google.com [Impeller] Fix division by zero for transparent shadows (flutter/engine#41391 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-21 18:00:25 +00:00
Justin McCandless
8784eb1d8e
Red spell check selection on iOS ( #125162 )
...
iOS now hides the selection handles and shows red selection when tapping a misspelled word, like native.
2023-04-21 09:15:08 -07:00
engine-flutter-autoroll
4b188bd81f
Roll Flutter Engine from a7899c45791c to 3f7e12b8e656 (6 revisions) ( #125302 )
...
a7899c4579...3f7e12b8e6skia-flutter-autoroll@skia.org Roll Skia from fbfed7c82918 to 5754b81988b8 (1 revision) (flutter/engine#41395 )
2023-04-21 skia-flutter-autoroll@skia.org Roll Dart SDK from 4cc2e637a315 to fabaeef00dfb (1 revision) (flutter/engine#41394 )
2023-04-21 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from PqBDstaESE_l77k1e... to Edv0I0o8GQ7c0z8XK... (flutter/engine#41393 )
2023-04-21 bdero@google.com [Impeller] Fix SupportsReadFromOnscreenTexture capability check (flutter/engine#41386 )
2023-04-21 bdero@google.com [Impeller] Always use BGRA10_XR for wide gamut (flutter/engine#41385 )
2023-04-21 skia-flutter-autoroll@skia.org Roll Skia from 90a93bb0990f to fbfed7c82918 (2 revisions) (flutter/engine#41392 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from PqBDstaESE_l to Edv0I0o8GQ7c
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-21 15:54:21 +00:00
engine-flutter-autoroll
c18388588f
Roll Packages from 746750ecef78 to 7e3f5da42e81 (1 revision) ( #125301 )
...
746750ecef...7e3f5da42estuartmorgan@google.com [google_maps_flutter] Add examples for different iOS versions (flutter/packages#3757 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-21 15:44:06 +00:00
engine-flutter-autoroll
7f11020c55
Roll Flutter Engine from 122c3b382012 to a7899c45791c (7 revisions) ( #125290 )
...
122c3b3820...a7899c4579skia-flutter-autoroll@skia.org Roll Skia from 524ecb58945e to
90a93bb0990f (1 revision) (flutter/engine#41390 )
2023-04-21 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
4OrPF9lzqCKGwBLRh... to fMOcI5zn1z0nOrV7s... (flutter/engine#41389 )
2023-04-21 skia-flutter-autoroll@skia.org Roll Skia from f4609aa2eaba to
524ecb58945e (23 revisions) (flutter/engine#41388 )
2023-04-21 skia-flutter-autoroll@skia.org Roll Dart SDK from
50b96abe9f6f to 4cc2e637a315 (1 revision) (flutter/engine#41387 )
2023-04-21 54558023+keyonghan@users.noreply.github.com Update xcode to
14c18 (flutter/engine#41370 )
2023-04-21 zanderso@users.noreply.github.com Revert "[Impeller] Turned
on wide gamut support by default." (flutter/engine#41382 )
2023-04-21 chillers@google.com Revert "Manual roll skia to d5b4acfb4"
(flutter/engine#41381 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from 4OrPF9lzqCKG to fMOcI5zn1z0n
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-21 08:06:42 -07:00
Michael Thomsen
dc481b23d1
Cleanup flutter config output ( #122384 )
2023-04-21 16:45:43 +02:00
Bruno Leroux
d4f884e000
Make selectable text mouse cursor configurable ( #125133 )
...
## Description
This PR introduces `DefaultSelectionStyle.mouseCursor` to configure the mouse cursor over selectable text.
It also applies this solution to `InkResponse` to make the mouse cursor win over the default one provided by selectable `Text` for many Material components (such as buttons).
### Before
https://user-images.githubusercontent.com/840911/233627729-ddf98e2a-444d-4c6d-a6d5-f521982f48dd.mov
### After
https://user-images.githubusercontent.com/840911/233627718-8871a68f-d33c-44cf-b4a1-91bb1fcdf076.mov
## Related Issue
Fixes https://github.com/flutter/flutter/issues/104595
## Tests
Adds 6 tests.
2023-04-21 13:43:37 +00:00
keyonghan
d186792c00
Update xcode to 14c18 for host only bots ( #125211 )
...
With https://flutter-review.googlesource.com/c/recipes/+/42160 , we are
ready to make all tests consistent with xcode 14c18.
> auto label is removed for flutter/flutter, pr: 125211, due to This PR has not met approval requirements for merging. Changes were requested by {jmagman}, please make the needed changes and resubmit this PR. You have project association MEMBER and need 1 more review(s) in order to merge this PR.
>
> * Merge guidelines: You need at least one approved review if you are already a MEMBER or two member reviews if you are not a MEMBER before re-applying the autosubmit label. **Reviewers**: If you left a comment approving, please use the "approve" review action instead.
Sounds an auto-submit bug. Manually submit.
2023-04-20 20:50:59 -07:00
