DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
10,865 Commits 882 Branches 1,069 Tags
Commit Graph

8551 Commits

Author SHA1 Message Date
Chris Yang
56929f0ee2 Revert "Always make gpu thread different from platform thread regardless of platform view (#16068)" (flutter/engine#16161) 
This reverts commit f979af16ec379f268468015c7cb555849783ec21.
 2020-01-28 15:12:25 -08:00
Chinmay Garde
32e271a2ad Revert "Disable setting a library tag handler." (flutter/engine#16157) 
This reverts commit a801e2264fc2f48646d3a3bc2f15a3416e6dc87b. This address the use case of an internal customer. In a subsequent patch, I will add a test for this functionality. Instead of removing support for the same from tonic (along with the stuff surrounding filesystem access and package map handling), I’ll rework the same to use FML to avoid code duplication and maintainability.
 2020-01-28 11:44:27 -08:00
Chris Yang
f979af16ec Always make gpu thread different from platform thread regardless of platform view (flutter/engine#16068) 2020-01-28 11:36:43 -08:00
Chinmay Garde
f5ae64f523 Add test to ensure that concurrent message loops have at least one workers. (flutter/engine#16074) 
The current count is determined from std:🧵:hardware_concurrency which can
return zero. Even in such cases, the implementation may not return a loop with
no workers. There are numerous components that depend on having non-zero workers
in the queue.
 2020-01-28 11:29:42 -08:00
Dan Field
b392f1e3bd Revert breaking PRs (flutter/engine#16148) 
* Revert "Web PargraphStyle TextHeightBehavior integration (#16075)"

This reverts commit a152c9df009f74b3f52c46845e618b8ddcf3eaa7.

* Revert "Engine/LibTxt/dart:ui impl of TextHeightBehavior (#15087)"

This reverts commit e6f6d2a3c2fe333a85c8997d755ca91594e80544.
 2020-01-28 10:40:05 -08:00
skia-flutter-autoroll
3431a1797b Roll fuchsia/sdk/core/linux-amd64 from 8Ns10... to 2rLoq... (flutter/engine#15971) 2020-01-27 18:53:02 -08:00
Francisco Magdaleno
a4fe86b745 Gets the DPI for all awareness mode and older Windows versions (flutter/engine#15951) 2020-01-27 18:48:03 -08:00
Chinmay Garde
87beaf3a9b Hold a mutex when updating all CanPostTaskToAllNativeThreads::Captures members. (flutter/engine#16085) 
This is in the same vein as https://github.com/flutter/engine/pull/16081 but
includes holding the mutex when updating all members in the Captures struct
instead of just when tracking thread IDs.
 2020-01-27 18:37:20 -08:00
Chinmay Garde
a801e2264f Disable setting a library tag handler. (flutter/engine#16086) 
This is only used in the command line VM. The only conceivable use of this would
be with IsolateMirror.loadURI which is not supported in Flutter or used in known
embedder API implementations (even ones that use mirrors).
 2020-01-27 18:31:00 -08:00
Gary Qian
a152c9df00 Web PargraphStyle TextHeightBehavior integration (flutter/engine#16075) 2020-01-27 17:35:40 -08:00
Chinmay Garde
ec873f14d7 Fix flake by making thread ID tracking in CanPostTaskToAllNativeThreads thread safe. (flutter/engine#16081) 2020-01-27 17:34:56 -08:00
Chinmay Garde
80367b5298 Remove buggy assertion in EmbedderTest::CanPostTaskToAllNativeThreads. (flutter/engine#16071) 
This was introduced in
ef31000576.

The assertion was originally written to check that more than 4 threads were
managed by the engine (UI, Platform, GPU, IO + ConcurrentWQWorkers). However,
the assertion actually only checked the count of workers in the ConcurrentWQ. As
written, this assertion would fail on all hosts with a hardware concurrency of
less than 4. Remove the assertion. The engine threads count and its assertions
already check callbacks on workers. So this check was incorrect and redundant.
 2020-01-27 16:00:34 -08:00
Chinmay Garde
5defd058a9 Remove tonic/platform. (flutter/engine#16062) 
This is unused.
 2020-01-27 14:41:15 -08:00
Chinmay Garde
ef31000576 Allow embedders to schedule a callback on all engine managed threads. (flutter/engine#15980) 
`FlutterEnginePostCallbackOnAllNativeThreads` schedule a callback to be run on
all engine managed threads. The engine will attempt to service this callback the
next time the message loops for each managed thread is idle. Since the engine
manages the entire lifecycle of multiple threads, there is no opportunity for
the embedders to finely tune the priorities of threads directly, or, perform
other thread specific configuration (for example, setting thread names for
tracing). This callback gives embedders a chance to affect such tuning.

Fixes flutter/flutter#49551
Fixes b/143774406
Fixes b/148278215
Fixes b/148278931
 2020-01-27 13:49:39 -08:00
Gary Qian
e6f6d2a3c2 Engine/LibTxt/dart:ui impl of TextHeightBehavior (flutter/engine#15087) 2020-01-27 13:37:11 -08:00
skia-flutter-autoroll
e1060960cd Roll src/third_party/skia f1b2b42613cb..9c1d30dd163e (8 commits) (flutter/engine#16060) 
https://skia.googlesource.com/skia.git/+log/f1b2b42613cb..9c1d30dd163e

git log f1b2b42613cb..9c1d30dd163e --date=short --first-parent --format='%ad %ae %s'
2020-01-27 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2020-01-27 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2020-01-27 mtklein@google.com draw whole grid
2020-01-27 fmalita@chromium.org [skottie] Cleanup: convert transform adapters to new pattern
2020-01-27 mtklein@google.com rm mtklein@chromium
2020-01-27 bsalomon@google.com Revert "Switch runtime SkSL to always sample at explicit coords"
2020-01-27 jvanverth@google.com Revert "Wrap page index packing in helper methods."
2020-01-27 brianosman@google.com Switch runtime SkSL to always sample at explicit coords

Created with:
  gclient setdep -r src/third_party/skia@9c1d30dd163e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC reed@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: reed@google.com
 2020-01-27 15:44:10 -05:00
Chinmay Garde
b7e32f823d Remove stale recipe changelog. (flutter/engine#15985) 
We tried updating this for a while but we seem to have given up. This is now
stale. Removing the same.
 2020-01-27 12:24:42 -08:00
skia-flutter-autoroll
48f5325cc2 Roll src/third_party/skia 0fb0a21bd999..f1b2b42613cb (4 commits) (flutter/engine#16053) 
https://skia.googlesource.com/skia.git/+log/0fb0a21bd999..f1b2b42613cb

git log 0fb0a21bd999..f1b2b42613cb --date=short --first-parent --format='%ad %ae %s'
2020-01-27 sergeyu@google.com Fix GrSmallPathRenderer to respect max texture size.
2020-01-27 kjlubick@google.com [canvaskit] Fix test for drawOnce
2020-01-27 bryct@amazon.com Add drawOnce() API to SkSurface.
2020-01-27 nifong@google.com Use html tags instead of markdown for images in debugger user guide

Created with:
  gclient setdep -r src/third_party/skia@f1b2b42613cb

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC reed@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: reed@google.com
 2020-01-27 11:29:41 -05:00
skia-flutter-autoroll
731af83a38 Roll src/third_party/skia f93a8436cea5..0fb0a21bd999 (3 commits) (flutter/engine#16036) 
https://skia.googlesource.com/skia.git/+log/f93a8436cea5..0fb0a21bd999

git log f93a8436cea5..0fb0a21bd999 --date=short --first-parent --format='%ad %ae %s'
2020-01-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 2ae619822948..82459860eaf4 (508 commits)
2020-01-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 f3b4e6c3030f..fcef6dcb6ab2 (15 commits)
2020-01-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 5ef91b82cbed..748ad200897b (6 commits)

Created with:
  gclient setdep -r src/third_party/skia@0fb0a21bd999

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC reed@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: reed@google.com
 2020-01-27 01:49:09 -05:00
skia-flutter-autoroll
c44a692dbf Roll src/third_party/skia d92e4e9de7f1..f93a8436cea5 (1 commits) (flutter/engine#16029) 
https://skia.googlesource.com/skia.git/+log/d92e4e9de7f1..f93a8436cea5

git log d92e4e9de7f1..f93a8436cea5 --date=short --first-parent --format='%ad %ae %s'
2020-01-26 mtklein@google.com support dither in skvm

Created with:
  gclient setdep -r src/third_party/skia@f93a8436cea5

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC reed@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: reed@google.com
 2020-01-26 21:23:19 -05:00
skia-flutter-autoroll
7adf11f203 Roll src/third_party/skia 45add166fdb9..d92e4e9de7f1 (32 commits) (flutter/engine#16022) 
https://skia.googlesource.com/skia.git/+log/45add166fdb9..d92e4e9de7f1

git log 45add166fdb9..d92e4e9de7f1 --date=short --first-parent --format='%ad %ae %s'
2020-01-26 mtklein@google.com cache only when SkVM has a JIT
2020-01-26 reed@google.com offer raw-array variant of remaining 44 methods
2020-01-26 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version
2020-01-26 reed@google.com use vsphere to control light
2020-01-26 reed@google.com virtual sphere
2020-01-26 reed@google.com restore til I understand what changed
2020-01-26 reed@google.com consolidate examples to 1 matrix type
2020-01-25 bsalomon@google.com Revert "Revert "Use bitmap subset for comparison in texture_domain_effect GMs.""
2020-01-25 reed@google.com Revert "convert sample completely to SkM4"
2020-01-25 reed@google.com convert sample completely to SkM4
2020-01-25 bsalomon@google.com Revert "Use bitmap subset for comparison in texture_domain_effect GMs."
2020-01-25 bsalomon@google.com Use bitmap subset for comparison in texture_domain_effect GMs.
2020-01-25 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2020-01-24 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2020-01-24 ethannicholas@google.com add SkSLInterpreter vector instructions
2020-01-24 reed@google.com Revert "Revert "add rotate to SkM44""
2020-01-24 brianosman@google.com Make invokeChild just return a string containing the child function call
2020-01-24 reed@google.com Revert "add rotate to SkM44"
2020-01-24 bsalomon@google.com Detect implementation read formats on ES.
2020-01-24 reed@google.com add rotate to SkM44
2020-01-24 bungeman@google.com Preserve FcConfig in SkFontConfigInterface_direct methods.
2020-01-24 jvanverth@google.com Wrap page index packing in helper methods.
2020-01-24 bsalomon@google.com Revert "Revert "Move GrDomainEffect functionality into GrTextureEffect and delete""
2020-01-24 robertphillips@google.com Make GrGpu::createBackendTexture match createCompressedBackendTexture
2020-01-24 jvanverth@google.com Revert "Reland "Reland "Add new method for storing DrawOpAtlas texture index."""
2020-01-24 mtklein@google.com add skvm msan bot, move asan back to linux
2020-01-24 brianosman@google.com Remove invokeChild variants that write to output color
2020-01-24 mtklein@google.com clean up caches at thread exit
2020-01-24 mtklein@google.com link clang bots against our prepackaged libc++
2020-01-24 bsalomon@google.com Revert "Move GrDomainEffect functionality into GrTextureEffect and delete"
2020-01-24 ethannicholas@google.com Revert "Revert "Complete rewrite of the SkSL interpreter""
2020-01-24 bsalomon@google.com Move GrDomainEffect functionality into GrTextureEffect and delete the former.

Created with:
  gclient setdep -r src/third_party/skia@d92e4e9de7f1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC reed@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: reed@google.com
 2020-01-26 17:12:00 -05:00
skia-flutter-autoroll
f55dbc2b4b Roll src/third_party/skia 3ea4d5bb857d..45add166fdb9 (1 commits) (flutter/engine#15967) 
https://skia.googlesource.com/skia.git/+log/3ea4d5bb857d..45add166fdb9

git log 3ea4d5bb857d..45add166fdb9 --date=short --first-parent --format='%ad %ae %s'
2020-01-24 mtklein@google.com silly hack -- move SkVM/ASAN bot to Mac

Created with:
  gclient setdep -r src/third_party/skia@45add166fdb9

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC benjaminwagner@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: benjaminwagner@google.com
 2020-01-26 08:00:17 -05:00
Chinmay Garde
93d67baf2b Move tonic into //flutter/third_party. (flutter/engine#15895) 
Tonic used to be used by multiple consumers outside of Flutter Engine. Due to
this, it has an unnecessary abstraction layer as well as utilities duplicated in
FML and other engine subsystems. The sole user of Tonic is now the Flutter
Engine. It is intended that the Flutter Engine team now owns this subsystem,
remove unnecessary utilities and document the headers. This is the first step in
the transition. No history is being imported as the initial history was already
lost in the transition of this component to fuchsia.googlesource. As this
component was unmaintained there, I could see no additional value in importing
the history of the patches there.

No functional change. Just moved the repo from //third_party to
//flutter/third_party and updates GN refs.
 2020-01-25 17:01:56 -08:00
Michael Klimushyn
f3ec835234 Register plugins at the right time, once (flutter/engine#15979) 
Currently we're automatically registering plugins both when the
FlutterEngine is constructed and in the `flutter create` template, when
FlutterActivity#configureFlutterEngine is called. The initial
registration is too early to contain a reference to the activity and the
second registration can cause problems in some plugins.

This alters the flow so automatic registration happens in two discrete
places, and contains the `activity` in its first and only call for most
apps.

1. We're no longer automatically registering plugins on `FlutterEngine`
in any of our activities/fragments at construction time. But since the
FlutterEngine default constructor still automatically registers plugins,
anyone constructing the engine themselves (for example, in a service) is
still going to get automatic registration at `FlutterEngine`
instantiation time.
2. We now automatically register plugins in the base `FlutterActivity`'s
`configureFlutterEngine` hook. Anyone using `FlutterActivity` (or
`FlutterFragment`) should be automatically registered once that hook is
called. Right now the `flutter create` template overrides the base class
method with a subclass that registers everything manually in the same
spot. But with this in place we can safely recommend to remove the
subclass and rely on this hook to automatically register going forward.
Registering at this time means `activity` is set correctly.
 2020-01-25 00:34:52 -08:00
Ferhat
7a94b6e104 Use 2d matrix for transform to work around Safari clipping bug (flutter/engine#15976) 2020-01-24 20:40:12 -08:00
George Wright
86f501cbd8 Disable flakey CountDownLatchTest.CanWait unit test on Fuchsia (flutter/engine#15982) 2020-01-24 19:21:20 -08:00
Nurhan Turgut
9fe323f5e0 updating the versions of the browsers for flutter web engine unit tests (flutter/engine#15977) 2020-01-24 16:28:21 -08:00
Chris Bracken
d96d9de930 Eliminate unused import in Android embedding (flutter/engine#15975) 
Eliminates an unused dependency on android.os.build. The last remaining
use of this was eliminated in 0ad44285bd91d5e0a17facbac0d16eab7e60a110
with the removal of an unused method that contained an android version
check.
 2020-01-24 16:19:00 -08:00
Matt Carroll
10e5d6d7b5 Prevent duplicate plugin registration in FlutterEnginePluginRegistry. (#49365) (flutter/engine#15956) 2020-01-24 15:57:51 -08:00
Dan Field
7200c3f459 retry logic for another cipd upload (flutter/engine#15974) 2020-01-24 15:51:41 -08:00
George Wright
274356d3ab Ensure GetFixturesPath works on Fuchsia (flutter/engine#15978) 2020-01-24 15:47:29 -08:00
Nurhan Turgut
076cf25e37 [web] Calling platform message callback after copy (flutter/engine#15950) 
* Calling platform message callback after copy

* addressing pr comments

* adding unit tests to clipbpard.dart
 2020-01-24 15:35:03 -08:00
Kaushik Iska
024a753078 [fuchsia] Expose view_ref as part of dart:fuchsia initialization (flutter/engine#15958) 
fixes https://github.com/flutter/flutter/issues/47178
 2020-01-24 13:42:19 -08:00
George Wright
2d2da1dd64 Refactor ShellTest to allow for different ShellTestPlatformViews (flutter/engine#15972) 
This paves the way for us to have shell_unittests backed by different rendering APIs (e.g. OpenGL, Vulkan, Metal).
 2020-01-24 13:29:12 -08:00
Yegor
3f4a2380cd Cache computed window.physicalSize in a FrameReference (flutter/engine#15955) 2020-01-24 13:21:16 -08:00
Dan Field
62a99c60c5 the the fix (flutter/engine#15973) 2020-01-24 12:43:32 -08:00
Ferhat
74e67d3c35 Optimize drawRRect to use dom_canvas (flutter/engine#15970) 2020-01-24 11:03:19 -08:00
Ferhat
4fcba4abfd Remove paint apply in draw image (flutter/engine#15969) 
https://github.com/flutter/flutter/issues/49132
 2020-01-24 10:39:54 -08:00
skia-flutter-autoroll
8d2d8c7123 Roll fuchsia/sdk/core/linux-amd64 from Wc7e4... to 8Ns10... (flutter/engine#15964) 2020-01-24 02:13:02 -08:00
skia-flutter-autoroll
6765b84dad Roll src/third_party/skia a7e557f3e353..3ea4d5bb857d (4 commits) (flutter/engine#15963) 
https://skia.googlesource.com/skia.git/+log/a7e557f3e353..3ea4d5bb857d

git log a7e557f3e353..3ea4d5bb857d --date=short --first-parent --format='%ad %ae %s'
2020-01-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 7afe38da7578..2ae619822948 (463 commits)
2020-01-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 135f8fcba837..f3b4e6c3030f (8 commits)
2020-01-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader f324fe10ca65..5ef91b82cbed (6 commits)
2020-01-24 bsalomon@google.com Add support for GL_NV_fence.

Created with:
  gclient setdep -r src/third_party/skia@3ea4d5bb857d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC benjaminwagner@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: benjaminwagner@google.com
 2020-01-24 02:29:05 -05:00
George Wright
ffb91bfd48 ensure we export the various dart snapshot symbols on Fuchsia (flutter/engine#15953) 2020-01-23 20:13:03 -08:00
George Wright
33999d4bc3 Migrate flutter_runner from flutter_runner::{Thread,Loop} to fml::{Thread,MessageLoop} (flutter/engine#15118) 2020-01-23 18:54:49 -08:00
George Wright
da0fcfec7a Re-arm timer as necessary in MessageLoopFuchsia 2020-01-23 18:54:49 -08:00
skia-flutter-autoroll
72d0154e2b Roll src/third_party/skia c88a3bc3f561..a7e557f3e353 (6 commits) (flutter/engine#15957) 
https://skia.googlesource.com/skia.git/+log/c88a3bc3f561..a7e557f3e353

git log c88a3bc3f561..a7e557f3e353 --date=short --first-parent --format='%ad %ae %s'
2020-01-24 michaelludwig@google.com Reland "Increase precision of some quad AA calculations"
2020-01-24 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2020-01-23 reed@google.com remove legacy SkMScalar code
2020-01-23 mtklein@google.com use longer-lived alloc in CacheKey()
2020-01-23 mtklein@google.com force skvm interpreter in ASAN builds, add bots
2020-01-23 brianosman@google.com Use PipelineStageArgs throughout GrSkSLFP and PipelineStageCodeGenerator

Created with:
  gclient setdep -r src/third_party/skia@a7e557f3e353

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC benjaminwagner@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: benjaminwagner@google.com
 2020-01-23 21:49:01 -05:00
Wu Zhong
9e59686653 Fixes FlutterCallbackInfomation leaks (flutter/engine#15089) 
See: flutter/flutter#46750
 2020-01-23 16:33:26 -08:00
Wu Zhong
cf8b9d5e1a Fixes oc leaks in platform plugin (flutter/engine#15041) 
Some objc objects are not released in the iOS embedder. This fixes a
subset of those leaks in FlutterPlatformPlugin.mm.
 2020-01-23 16:32:31 -08:00
Jason Simmons
e98b1c3ef7 Do not reset the child isolate preparer if the isolate group data already has one (flutter/engine#15952) 
See https://github.com/flutter/flutter/issues/49358
 2020-01-23 16:04:02 -08:00
Chinmay Garde
e8827952d5 Fix data race in DartIsolateGroupData. (flutter/engine#15949) 
This class is meant to be thread safe. In fact, its headerdoc statement on
thread safety even mentions this. All fields on the class are readonly except
the child isolate preparer. This field is set during VM instantiated isolate
initialization. The VM may launch multiple isolate in the same isolate group on
at the same time (each on a VM backed thread pool thread). Attempting to set the
field without synchronization is a data race.

Fixes https://github.com/flutter/flutter/issues/49358
Fixes b/147798920
 2020-01-23 16:03:37 -08:00
Miguel
497dc90ab7 [fuchsia] Add LogSink to flutter_[jit & aot]_product_runner (flutter/engine#15697) 2020-01-23 15:15:33 -08:00
Jason Simmons
65ffe2546f Do not produce timeline events in release mode (flutter/engine#15894) 
Calling Dart_TimelineEvent has a performance cost, and the APIs for collecting
timeline events are not available in release mode.
 2020-01-23 15:05:00 -08:00