DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix flake by making thread ID tracking in CanPostTaskToAllNativeThreads thread safe. (flutter/engine#16081)

Browse Source
This commit is contained in:
Chinmay Garde 2020-01-27 17:34:56 -08:00 committed by GitHub
parent 80367b5298
commit ec873f14d7
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
engine/src/flutter/shell/platform/embedder/tests/embedder_unittests.cc
View File

@ -3943,6 +3943,7 @@ TEST_F(EmbedderTest, CanPostTaskToAllNativeThreads) {
fml::CountDownLatch latch;
// Ensures that the expect number of distinct threads were serviced.
std::mutex thread_ids_mutex;
std::set<std::thread::id> thread_ids;
size_t platform_threads_count = 0;
@ -3960,7 +3961,6 @@ TEST_F(EmbedderTest, CanPostTaskToAllNativeThreads) {
engine.get(),
[](FlutterNativeThreadType type, void* baton) {
auto captures = reinterpret_cast<Captures*>(baton);
switch (type) {
case kFlutterNativeThreadTypeRender:
captures->render_threads_count++;
@ -3975,8 +3975,10 @@ TEST_F(EmbedderTest, CanPostTaskToAllNativeThreads) {
captures->platform_threads_count++;
break;
}
captures->thread_ids.insert(std::this_thread::get_id());
{
std::scoped_lock lock(captures->thread_ids_mutex);
captures->thread_ids.insert(std::this_thread::get_id());
}
captures->latch.CountDown();
},
&captures),