flutter-pub-roller-bot
55af75d57b
Roll pub packages ( #154933 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2024-09-10 18:21:26 +00:00
Andrew Kolos
d88e692895
fix test chrome.close can recover if getTab throws a StateError ( #154889 )
...
Fixes https://github.com/flutter/flutter/issues/154857 .
Does so by:
* adding `await chromiumLauncher.connect(chrome, false);` before the `close` call to make sure we enter[ the block ](9cd2fc90af/packages/flutter_tools/lib/src/web/chrome.dart (L521-L535) )that actually tries to close chromium
* adding an `onGetTab` callback to `FakeChromeConnectionWithTab`, which the test now uses to throw a StateError upon `getTab` getting called.
## How I verified this change
1. Change `Chromium.close` from using the safer `getChromeTabGuarded` function to using the previous method of calling `ChromeConnection.getTab` directly. Do so by applying this diff:
```diff
diff --git a/packages/flutter_tools/lib/src/web/chrome.dart b/packages/flutter_tools/lib/src/web/chrome.dart
index c9a5fdab81..81bc246ff9 100644
--- a/packages/flutter_tools/lib/src/web/chrome.dart
+++ b/packages/flutter_tools/lib/src/web/chrome.dart
@@ -520,7 +520,7 @@ class Chromium {
Duration sigtermDelay = Duration.zero;
if (_hasValidChromeConnection) {
try {
- final ChromeTab? tab = await getChromeTabGuarded(chromeConnection,
+ final ChromeTab? tab = await chromeConnection.getTab(
(_) => true, retryFor: const Duration(seconds: 1));
if (tab != null) {
final WipConnection wipConnection = await tab.connect();
```
2. Then, run the test, which should correctly fail:
```
dart test test/web.shard/chrome_test.dart --name="chrome.close can recover if getTab throws a StateError"`
```
3. Revert the change from step 1 and run again. The test should now pass.
2024-09-10 17:23:56 +00:00
Justin McCandless
24d0b1db0a
SearchBar context menu ( #154833 )
...
SearchBar and SearchAnchor can now control their context menu. They both received new contextMenuBuilder parameters. See the docs for EditableText.contextMenuBuilder for how to use this, including how to use the native context menu on iOS and to control the browser's context menu on web.
2024-09-10 09:54:00 -07:00
Gray Mackall
f964f15dcb
Fix flutter build aar for modules that use a plugin ( #154757 )
...
https://github.com/flutter/flutter/pull/151675 bumped module templates to AGP 8.1.
In doing so, I tried to work around a behavior change [that was new in AGP 8.0](https://developer.android.com/build/releases/past-releases/agp-8-0-0-release-notes ):
> AGP 8.0 creates no SoftwareComponent by default. Instead AGP creates SoftwareComponents only for variants that are configured to be published using the publishing DSL.
by using AGP's publishing DSL to define which variants to publish in the module's ephemeral gradle files:
```
android.buildTypes.all {buildType ->
if (!android.productFlavors.isEmpty()) {
android.productFlavors.all{productFlavor ->
android.publishing.singleVariant(productFlavor.name + buildType.name.capitalize()) {
withSourcesJar()
withJavadocJar()
}
}
} else {
android.publishing.singleVariant(buildType.name) {
withSourcesJar()
withJavadocJar()
}
}
}
```
The problem is that this doesn't get applied to the plugin projects used by the module, so if a module uses any plugin it breaks. This PR fixes that by applying similar logic, but to each project (not just the module's project).
Tested manually with https://github.com/gmackall/GrayAddToApp , and also re-enabled an old test that tested this use case as a part of the PR.
Fixes: https://github.com/flutter/flutter/issues/154371
2024-09-10 16:42:22 +00:00
engine-flutter-autoroll
7e2de37336
Roll Packages from b4e0fc1bc117 to bb53e5d536ae (4 revisions) ( #154926 )
...
b4e0fc1bc1...bb53e5d536
2024-09-09 magder@google.com [ci] Increase deprecation check minimum to macOS 14 (flutter/packages#7544 )
2024-09-09 paulberry@google.com [camerax] Ignore new `unreachable_switch_default` warning. (flutter/packages#7592 )
2024-09-09 109111084+yaakovschectman@users.noreply.github.com [google_maps_flutter_platform_interface] Split `CameraUpdate` into derived classes to use structured data (flutter/packages#7596 )
2024-09-09 stuartmorgan@google.com [google_maps_flutter] Disable setAndGetScrollPosition on iOS (flutter/packages#7609 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-10 16:34:19 +00:00
Taha Tesser
ebc2c3e437
Clean up SnackBar inherit theme data test ( #154921 )
...
Fixes [Verbose `SnackBar` inherit theme data test](https://github.com/flutter/flutter/issues/154920 )
2024-09-10 16:27:14 +00:00
davidhicks980
bffa21549c
Revert "Improve CupertinoPopupSurface appearance" ( #154893 )
...
Reverts flutter/flutter#151430 to fix
https://github.com/flutter/flutter/issues/154887 until I can investigate
further.
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
2024-09-10 08:12:46 -07:00
engine-flutter-autoroll
4be3035103
Roll Flutter Engine from 3dc8b71f96cc to 8a038a6f7099 (1 revision) ( #154904 )
...
3dc8b71f96...8a038a6f70
2024-09-10 yjbanov@google.com [skwasm] use temporary RawPaint objects (attempt #2 ) (flutter/engine#55035 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-10 14:53:34 +00:00
engine-flutter-autoroll
d6e2b6aedb
Roll Flutter Engine from 656117fc8ba9 to 3dc8b71f96cc (3 revisions) ( #154900 )
...
656117fc8b...3dc8b71f96
2024-09-10 skia-flutter-autoroll@skia.org Roll Dart SDK from b6c3cd9b93f1 to a60078a23978 (14 revisions) (flutter/engine#55059 )
2024-09-09 jason-simmons@users.noreply.github.com Add missing include to fml/hex_codec.h (flutter/engine#55034 )
2024-09-09 skia-flutter-autoroll@skia.org Roll Skia from 7e659d5538fa to 9bea95918e69 (3 revisions) (flutter/engine#55052 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-10 05:27:20 +00:00
flutter-pub-roller-bot
b3481c3a2b
Roll pub packages ( #154894 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2024-09-10 04:26:19 +00:00
flutter-pub-roller-bot
ee89e9a560
Roll pub packages ( #154890 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2024-09-10 01:27:22 +00:00
Christopher Fujino
92697d3ecc
Improve tracing and fix packages_autoroller ( #154841 )
...
Reverts flutter/flutter#154555
Re-lands of https://github.com/flutter/flutter/pull/154441 and https://github.com/flutter/flutter/pull/154369
New changes in this PR:
1. extend timeout of the `Linux packages_autoroller` shard (see step 14 in this example [LED build](https://ci.chromium.org/ui/p/flutter/builders/prod.shadow/Linux%20packages_autoroller/7/infra ))
2. use the managed framework repo as the working directory in the `framework.streamDart()` helper function--we were generating gradle lockfiles in the wrong directory
A LED build with this code generated the following gradle lockfile update: d939981cd2
2024-09-09 23:31:21 +00:00
engine-flutter-autoroll
81d23d93f6
Roll Flutter Engine from c18ecf9e4000 to 656117fc8ba9 (2 revisions) ( #154883 )
...
c18ecf9e40...656117fc8b
2024-09-09 magder@google.com Unskip Impeller iOS scenario tests (flutter/engine#55012 )
2024-09-09 skia-flutter-autoroll@skia.org Roll Skia from 7ad1252da14f to 7e659d5538fa (2 revisions) (flutter/engine#55050 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-09 23:26:58 +00:00
engine-flutter-autoroll
c7f5b79c57
Roll Flutter Engine from 7ad9e5ba962c to c18ecf9e4000 (1 revision) ( #154855 )
...
7ad9e5ba96...c18ecf9e40
2024-09-09 skia-flutter-autoroll@skia.org Roll Skia from 8103f53635fd to 7ad1252da14f (3 revisions) (flutter/engine#55046 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-09 22:00:11 +00:00
Nate Wilson
bfa04edca6
un-break ThemeData equality ( #154695 )
...
This PR is _almost_ able to close issue #89127 .
Sadly, no `InheritedModel` or custom `RenderObject`s today; instead the [WidgetState operators](https://main-api.flutter.dev/flutter/widgets/WidgetStateOperators.html ) have been restructured to support equality checks.
`WidgetStateProperty.fromMap()` is now capable of accurate equality checks, and all of the `.styleFrom()` methods have been refactored to use that constructor.
(Equality checks are still broken for `WidgetStateProperty.resolveWith()`, and any other non-`const` objects that implement the interface.)
<br><br>
credit for this idea goes to @justinmc: https://github.com/flutter/flutter/issues/89127#issuecomment-2313187703
2024-09-09 21:49:09 +00:00
Michal Hazdra
18c325af17
Add scrim color parameter to _ZoomEnterTransitionPainter ( #152815 )
...
Implements #152064
There is currently no test here as I am not sure how to do it efficiently, I tried making the painter public and adding the visibleForTestinhg attribute, but then I need to add comments to everything... And even when I did that I did not know how to test the painter itself maybe via Golden tests? I have not done those in the Flutter repo yet. And if it can be done without them then that is definitely a better way. I'll wait for what the review says I should do.
2024-09-09 21:49:07 +00:00
engine-flutter-autoroll
8dace15468
Roll Flutter Engine from 813ad2db9796 to 7ad9e5ba962c (1 revision) ( #154849 )
...
813ad2db97...7ad9e5ba96
2024-09-09 jonahwilliams@google.com [Impeller] fix obvious memory leak. (flutter/engine#55036 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-09 20:58:20 +00:00
Andrew Kolos
9cd2fc90af
Handle ProcessExceptions due to git missing on the host ( #154445 )
...
Fixes https://github.com/flutter/flutter/issues/133585 .
This PR elects to add a new catch within `_handleToolError` that checks any uncaught error. This new catch will exit the tool without crashing provided the following conditions are met:
1. the error is a `ProcessException`,
2. the error message contains `git` somewhere in the message (we don't match on the entire string in case it changes or is locale-dependent), and
3. `git` does not appear to be runnable on the host system (`ProcessManager.canRun` returns `false` for git).
This is preferable to checking for runnability of `git` before we run it for 1) its simplicity and 2) lack of performance penalty for users that already have git installed (almost every single one).
This PR also does some light refactoring to runner_test.dart to make room for tests that aren't related to crash reporting.
2024-09-09 20:47:05 +00:00
Polina Cherkasova
8435e12ce5
Fix leaky tests. ( #154847 )
2024-09-09 20:35:03 +00:00
engine-flutter-autoroll
42a4271f0c
Roll Flutter Engine from 1b2656a5b8aa to 813ad2db9796 (2 revisions) ( #154844 )
...
1b2656a5b8...813ad2db97
2024-09-09 jonahwilliams@google.com [Impeller] add herustic for ignoring coverage limit w/ image filters. (flutter/engine#55030 )
2024-09-09 skia-flutter-autoroll@skia.org Roll Skia from f7e4ddabb754 to 8103f53635fd (1 revision) (flutter/engine#55043 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-09 19:49:06 +00:00
engine-flutter-autoroll
f49f2f5ca9
Roll Flutter Engine from 9822a711049c to 1b2656a5b8aa (1 revision) ( #154835 )
...
9822a71104...1b2656a5b8
2024-09-09 jacksongardner@google.com Revert "Add `crossOrigin` property to <img> tag used for decoding (#54961 )" (flutter/engine#55042 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-09 18:52:11 +00:00
engine-flutter-autoroll
cefca356e0
Roll Flutter Engine from 7e6d5c897a5a to 9822a711049c (1 revision) ( #154832 )
...
7e6d5c897a...9822a71104
2024-09-09 skia-flutter-autoroll@skia.org Roll Skia from 06cd203d0607 to f7e4ddabb754 (2 revisions) (flutter/engine#55041 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-09 17:52:13 +00:00
Lu Shueh Chou
4aecec70a9
Expose foreground property of TextStyle in Icon widget ( #150315 )
...
Expose foreground property to icon. See issues:
- #139411
2024-09-09 17:30:19 +00:00
engine-flutter-autoroll
d8ae99a790
Roll Packages from 56df73e3c54c to b4e0fc1bc117 (1 revision) ( #154824 )
...
56df73e3c5...b4e0fc1bc1
2024-09-06 engine-flutter-autoroll@skia.org Roll Flutter from 45ef8f36ff41 to 2e221e7308ba (20 revisions) (flutter/packages#7599 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-09 15:45:38 +00:00
engine-flutter-autoroll
fb24721a22
Roll Flutter Engine from 117a7d0859ed to 7e6d5c897a5a (1 revision) ( #154820 )
...
117a7d0859...7e6d5c897a
2024-09-09 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Dxly0DC9pQXTXVNm0... to kIWQ460iagZLxVRPc... (flutter/engine#55039 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from Dxly0DC9pQXT to kIWQ460iagZL
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-09 13:44:25 +00:00
engine-flutter-autoroll
f566016ed3
Roll Flutter Engine from 331fd5af8217 to 117a7d0859ed (1 revision) ( #154794 )
...
331fd5af82...117a7d0859
2024-09-08 jonahwilliams@google.com [engine] dispatch platform channel messages through event loop, except navigation on start. (flutter/engine#55027 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-08 19:06:24 +00:00
engine-flutter-autoroll
7a685ad072
Roll Flutter Engine from 51d4402f17b4 to 331fd5af8217 (2 revisions) ( #154791 )
...
51d4402f17...331fd5af82
2024-09-08 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from BF-8UyvqW5l52-hP2... to Dxly0DC9pQXTXVNm0... (flutter/engine#55033 )
2024-09-08 skia-flutter-autoroll@skia.org Manual roll Dart SDK from 0f783bdb7a4d to b6c3cd9b93f1 (1 revision) (flutter/engine#55031 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from BF-8UyvqW5l5 to Dxly0DC9pQXT
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-08 10:42:38 +00:00
hgraceb
0139761878
Fix TabBar crash with SliverAppBar ( #154485 )
...
Fixes #154484
Similar to #104998 . Cause with updated at different phases of the same frame.
2024-09-08 03:57:20 +00:00
engine-flutter-autoroll
cede6ba628
Roll Flutter Engine from 7bf1169715d6 to 51d4402f17b4 (2 revisions) ( #154782 )
...
7bf1169715...51d4402f17
2024-09-07 jonahwilliams@google.com [Impeller] Disable exp canvas. (flutter/engine#55026 )
2024-09-07 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from PBeI0gGvgFdXV6hCg... to BF-8UyvqW5l52-hP2... (flutter/engine#55024 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from PBeI0gGvgFdX to BF-8UyvqW5l5
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-07 19:25:35 +00:00
engine-flutter-autoroll
04d64d9c2f
Roll Flutter Engine from 419fb8c0ab3e to 7bf1169715d6 (14 revisions) ( #154769 )
...
419fb8c0ab...7bf1169715
2024-09-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[engine] reland: always post tasks for platform channel responses. (#55006 )" (flutter/engine#55022 )
2024-09-07 magder@google.com Turn off software rendering in iOS scenario golden tests (flutter/engine#55016 )
2024-09-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[skwasm] use temporary RawPaint objects (#54917 )" (flutter/engine#55018 )
2024-09-06 jonahwilliams@google.com [engine] reland: always post tasks for platform channel responses. (flutter/engine#55006 )
2024-09-06 skia-flutter-autoroll@skia.org Roll Skia from 4786936b4c0c to 06cd203d0607 (2 revisions) (flutter/engine#55014 )
2024-09-06 paulberry@google.com [multiple] Avoid new `unreachable_switch_default` warning. (flutter/engine#54996 )
2024-09-06 yjbanov@google.com [skwasm] use temporary RawPaint objects (flutter/engine#54917 )
2024-09-06 flar@google.com [DisplayList] use DlScalar, DlPoint, DlRect exclusively in DlOpReceiver methods (flutter/engine#54982 )
2024-09-06 skia-flutter-autoroll@skia.org Roll Skia from f38ea0134dba to 4786936b4c0c (4 revisions) (flutter/engine#55013 )
2024-09-06 jonahwilliams@google.com [Impeller] opt into exp canvas. (flutter/engine#54913 )
2024-09-06 skia-flutter-autoroll@skia.org Roll Skia from 8f62a6a4a299 to f38ea0134dba (4 revisions) (flutter/engine#55008 )
2024-09-06 jonahwilliams@google.com [impeller] fake image for fake tests. (flutter/engine#54974 )
2024-09-06 skia-flutter-autoroll@skia.org Roll Skia from 6ad117bd2efe to 8f62a6a4a299 (1 revision) (flutter/engine#55001 )
2024-09-06 59215665+davidhicks980@users.noreply.github.com Change "there own" to "their own" in Flutter-GPU docs (flutter/engine#54921 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-07 04:39:25 +00:00
auto-submit[bot]
07230960c1
Reverts "Roll Flutter Engine from 419fb8c0ab3e to b9f9015ff986 (12 revisions) ( #154764 )" ( #154765 )
...
Reverts: flutter/flutter#154764
Initiated by: jonahwilliams
Reason for reverting: failing post submit on mac module test.
Original PR Author: engine-flutter-autoroll
Reviewed By: {fluttergithubbot}
This change reverts the following previous change:
419fb8c0ab...b9f9015ff9
2024-09-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[skwasm] use temporary RawPaint objects (#54917 )" (flutter/engine#55018 )
2024-09-06 jonahwilliams@google.com [engine] reland: always post tasks for platform channel responses. (flutter/engine#55006 )
2024-09-06 skia-flutter-autoroll@skia.org Roll Skia from 4786936b4c0c to 06cd203d0607 (2 revisions) (flutter/engine#55014 )
2024-09-06 paulberry@google.com [multiple] Avoid new `unreachable_switch_default` warning. (flutter/engine#54996 )
2024-09-06 yjbanov@google.com [skwasm] use temporary RawPaint objects (flutter/engine#54917 )
2024-09-06 flar@google.com [DisplayList] use DlScalar, DlPoint, DlRect exclusively in DlOpReceiver methods (flutter/engine#54982 )
2024-09-06 skia-flutter-autoroll@skia.org Roll Skia from f38ea0134dba to 4786936b4c0c (4 revisions) (flutter/engine#55013 )
2024-09-06 jonahwilliams@google.com [Impeller] opt into exp canvas. (flutter/engine#54913 )
2024-09-06 skia-flutter-autoroll@skia.org Roll Skia from 8f62a6a4a299 to f38ea0134dba (4 revisions) (flutter/engine#55008 )
2024-09-06 jonahwilliams@google.com [impeller] fake image for fake tests. (flutter/engine#54974 )
2024-09-06 skia-flutter-autoroll@skia.org Roll Skia from 6ad117bd2efe to 8f62a6a4a299 (1 revision) (flutter/engine#55001 )
2024-09-06 59215665+davidhicks980@users.noreply.github.com Change "there own" to "their own" in Flutter-GPU docs (flutter/engine#54921 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-07 03:04:25 +00:00
engine-flutter-autoroll
8e360edc38
Roll Flutter Engine from 419fb8c0ab3e to b9f9015ff986 (12 revisions) ( #154764 )
...
419fb8c0ab...b9f9015ff9
2024-09-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[skwasm] use temporary RawPaint objects (#54917 )" (flutter/engine#55018 )
2024-09-06 jonahwilliams@google.com [engine] reland: always post tasks for platform channel responses. (flutter/engine#55006 )
2024-09-06 skia-flutter-autoroll@skia.org Roll Skia from 4786936b4c0c to 06cd203d0607 (2 revisions) (flutter/engine#55014 )
2024-09-06 paulberry@google.com [multiple] Avoid new `unreachable_switch_default` warning. (flutter/engine#54996 )
2024-09-06 yjbanov@google.com [skwasm] use temporary RawPaint objects (flutter/engine#54917 )
2024-09-06 flar@google.com [DisplayList] use DlScalar, DlPoint, DlRect exclusively in DlOpReceiver methods (flutter/engine#54982 )
2024-09-06 skia-flutter-autoroll@skia.org Roll Skia from f38ea0134dba to 4786936b4c0c (4 revisions) (flutter/engine#55013 )
2024-09-06 jonahwilliams@google.com [Impeller] opt into exp canvas. (flutter/engine#54913 )
2024-09-06 skia-flutter-autoroll@skia.org Roll Skia from 8f62a6a4a299 to f38ea0134dba (4 revisions) (flutter/engine#55008 )
2024-09-06 jonahwilliams@google.com [impeller] fake image for fake tests. (flutter/engine#54974 )
2024-09-06 skia-flutter-autoroll@skia.org Roll Skia from 6ad117bd2efe to 8f62a6a4a299 (1 revision) (flutter/engine#55001 )
2024-09-06 59215665+davidhicks980@users.noreply.github.com Change "there own" to "their own" in Flutter-GPU docs (flutter/engine#54921 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-07 02:08:16 +00:00
Siva
d7a658d705
Roll Flutter Engine from c50eb8a65097 to 419fb8c0ab3e ( #154734 )
...
c50eb8a650...419fb8c0ab
2024-09-06 98614782+auto-submit[bot]@users.noreply.github.com Reverts
"[engine] always force platform channel responses to schedule a task.
(https://github.com/flutter/flutter/issues/54975 )"
(https://github.com/flutter/engine/pull/55000 )
2024-09-06
[skia-flutter-autoroll@skia.org ](mailto:skia-flutter-autoroll@skia.org)
Roll Skia from b6bab0fde426 to 6ad117bd2efe (2 revisions)
(https://github.com/flutter/engine/pull/54999 )
2024-09-06
[skia-flutter-autoroll@skia.org ](mailto:skia-flutter-autoroll@skia.org)
Roll Fuchsia Test Scripts from D9INMR2u4wcyiZ750... to
5dqcFlKzRjJb6V95W... (https://github.com/flutter/engine/pull/54998 )
2024-09-06
[skia-flutter-autoroll@skia.org ](mailto:skia-flutter-autoroll@skia.org)
Roll Skia from a09312b70d37 to b6bab0fde426 (3 revisions)
(https://github.com/flutter/engine/pull/54997 )
2024-09-06
[skia-flutter-autoroll@skia.org ](mailto:skia-flutter-autoroll@skia.org)
Roll Skia from 368f209ccca5 to a09312b70d37 (1 revision)
(https://github.com/flutter/engine/pull/54995 )
2024-09-06
[skia-flutter-autoroll@skia.org ](mailto:skia-flutter-autoroll@skia.org)
Roll Skia from aec11ae18bb6 to 368f209ccca5 (3 revisions)
(https://github.com/flutter/engine/pull/54992 )
2024-09-06
[skia-flutter-autoroll@skia.org ](mailto:skia-flutter-autoroll@skia.org)
Roll Fuchsia Linux SDK from xNv47d1TZmK9XgTxu... to PBeI0gGvgFdXV6hCg...
(https://github.com/flutter/engine/pull/54990 )
2024-09-06
[skia-flutter-autoroll@skia.org ](mailto:skia-flutter-autoroll@skia.org)
Roll Skia from 809f868ded1c to aec11ae18bb6 (22 revisions)
(https://github.com/flutter/engine/pull/54988 )
2024-09-06
[30870216+gaaclarke@users.noreply.github.com ](mailto:30870216+gaaclarke@users.noreply.github.com)
Removes the int storage from Color
(https://github.com/flutter/engine/pull/54714 )
2024-09-06 [chris@bracken.jp ](mailto:chris@bracken.jp) iOS,macOS: Add
logging of duplicate codesign binaries
(https://github.com/flutter/engine/pull/54987 )
2024-09-06
[skia-flutter-autoroll@skia.org ](mailto:skia-flutter-autoroll@skia.org)
Roll Fuchsia Test Scripts from k4lKsecg0pdIp-U7c... to
D9INMR2u4wcyiZ750... (https://github.com/flutter/engine/pull/54984 )
2024-09-05
[a-siva@users.noreply.github.com ](mailto:a-siva@users.noreply.github.com)
Manual roll of Dart. (https://github.com/flutter/engine/pull/54983 )
2024-09-05 [chris@bracken.jp ](mailto:chris@bracken.jp) iOS,macOS: add
unsigned_binaries.txt (https://github.com/flutter/engine/pull/54977 )
2024-09-05
[jason-simmons@users.noreply.github.com ](mailto:jason-simmons@users.noreply.github.com)
Manual Skia roll to 809f868ded1c
(https://github.com/flutter/engine/pull/54972 )
2024-09-05
[1961493+harryterkelsen@users.noreply.github.com ](mailto:1961493+harryterkelsen@users.noreply.github.com)
[canvaskit] Fix incorrect calculation of ImageFilter paint bounds
(https://github.com/flutter/engine/pull/54980 )
2024-09-05 [jonahwilliams@google.com ](mailto:jonahwilliams@google.com)
[engine] always force platform channel responses to schedule a task.
(https://github.com/flutter/engine/pull/54975 )
2024-09-05
[tugorez@users.noreply.github.com ](mailto:tugorez@users.noreply.github.com)
Fix unexpected ViewFocus events when Text Editing utilities change focus
in the middle of a blur call.
(https://github.com/flutter/engine/pull/54965 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from xNv47d1TZmK9 to PBeI0gGvgFdX
---------
Co-authored-by: Christopher Fujino <christopherfujino@gmail.com>
Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com>
2024-09-06 15:42:07 -07:00
Taha Tesser
755cf0bd3f
Fix Material 3 AppBar.leading action IconButtons ( #154512 )
...
Fixes [`AppBar` back button focus/hover circle should not fill up whole height](https://github.com/flutter/flutter/issues/141361 )
Fixes [[Material 3] Date Range Picker close button has incorrect shape](https://github.com/flutter/flutter/issues/154393 )
This updates the leading condition added in https://github.com/flutter/flutter/pull/110722
### Code sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() => runApp(const MyApp());
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
home: Scaffold(
body: SingleChildScrollView(
child: Column(
children: [
Column(
spacing: 10.0,
mainAxisSize: MainAxisSize.min,
children: <Widget>[
AppBar(
leading: BackButton(
style: IconButton.styleFrom(backgroundColor: Colors.red),
),
backgroundColor: Theme.of(context).colorScheme.secondaryContainer,
title: const Text('AppBar with BackButton'),
),
AppBar(
leading: CloseButton(
style: IconButton.styleFrom(backgroundColor: Colors.red),
),
backgroundColor: Theme.of(context).colorScheme.secondaryContainer,
title: const Text('AppBar with CloseButton'),
),
AppBar(
leading: DrawerButton(
style: IconButton.styleFrom(backgroundColor: Colors.red),
),
backgroundColor: Theme.of(context).colorScheme.secondaryContainer,
title: const Text('AppBar with DrawerButton'),
),
],
),
const Divider(),
Column(
spacing: 10.0,
mainAxisSize: MainAxisSize.min,
children: <Widget>[
AppBar(
leading: BackButton(
style: IconButton.styleFrom(backgroundColor: Colors.red),
),
backgroundColor: Theme.of(context).colorScheme.secondaryContainer,
toolbarHeight: 100.0,
title: const Text('AppBar with custom height'),
),
AppBar(
leading: CloseButton(
style: IconButton.styleFrom(backgroundColor: Colors.red),
),
backgroundColor: Theme.of(context).colorScheme.secondaryContainer,
toolbarHeight: 100.0,
title: const Text('AppBar with custom height'),
),
AppBar(
leading: DrawerButton(
style: IconButton.styleFrom(backgroundColor: Colors.red),
),
backgroundColor: Theme.of(context).colorScheme.secondaryContainer,
toolbarHeight: 100.0,
title: const Text('AppBar with custom height'),
),
],
),
],
),
),
),
);
}
}
```
</details>
### Before
<img width="912" alt="Screenshot 2024-09-04 at 12 38 05" src="https://github.com/user-attachments/assets/25a6893c-89c9-4b45-a5bb-8da0eee71cd2 ">
### After
<img width="912" alt="Screenshot 2024-09-04 at 12 38 28" src="https://github.com/user-attachments/assets/49727183-568c-412e-9fa1-1eefd0cd87a7 ">
2024-09-06 21:10:35 +00:00
Rajesh Malviya
6ad6641f0f
Remove allowoptimization modifier from FlutterPlugin proguard rules ( #154715 )
...
Fixes : #154580
Previous PR: #154677
More info: https://github.com/flutter/flutter/issues/154580#issuecomment-2333799620
The errors described in the original issue [are still occurring](https://github.com/flutter/flutter/issues/154580#issuecomment-2333799620 ) after #154677 . Before this change, the repro [broken_demo](https://github.com/rajveermalviya/broken_demo ) mentioned in the original issue logs:
```shell-session
$ flutter run --release
Launching lib/main.dart on sdk gphone64 arm64 in release mode...
Running Gradle task 'assembleRelease'... 14.5s
â Built build/app/outputs/flutter-apk/app-release.apk (7.4MB)
Installing build/app/outputs/flutter-apk/app-release.apk... 739ms
Flutter run key commands.
h List all available interactive commands.
c Clear the screen
q Quit (terminate the application on the device).
W/FlutterEngineCxnRegstry(13284): Attempted to register plugin (a0.a@53b33b6) but it was already registered with this FlutterEngine (d0.c@8baa8b7).
E/flutter (13284): [ERROR:flutter/runtime/dart_vm_initializer.cc(40)] Unhandled Exception: PlatformException(channel-error, Unable to establish connection on channel., null, null)
E/flutter (13284): #0 PathProviderApi.getApplicationSupportPath (package:path_provider_android/messages.g.dart:65)
E/flutter (13284): <asynchronous suspension>
E/flutter (13284): #1 getApplicationSupportDirectory (package:path_provider/path_provider.dart:78)
E/flutter (13284): <asynchronous suspension>
E/flutter (13284): #2 _BorkenDemoHomePageState.build.<anonymous closure> (package:broken_demo/main.dart:44)
E/flutter (13284): <asynchronous suspension>
E/flutter (13284):
```
After this change:
```shell-session
$ flutter run --release
Launching lib/main.dart on sdk gphone64 arm64 in release mode...
Running Gradle task 'assembleRelease'... 15.2s
â Built build/app/outputs/flutter-apk/app-release.apk (7.4MB)
Installing build/app/outputs/flutter-apk/app-release.apk... 857ms
Flutter run key commands.
h List all available interactive commands.
c Clear the screen
q Quit (terminate the application on the device).
I/flutter (13040): path_provider: Directory: '/data/user/0/com.example.broken_demo/files'
```
2024-09-06 20:37:23 +00:00
Chris Bobbe
84757af9f8
Adjust ButtonStyle.{foreground,icon}Color dartdocs for new behavior ( #154646 )
...
Fixes #154644 .
This aligns these dartdocs with the new behavior introduced in PR #143501 / 51ed348f3, where passing `iconColor: null` would cause the icon to be colored with a hard-coded default instead of with `foregroundColor`.
2024-09-06 19:22:33 +00:00
auto-submit[bot]
8c6513ddd1
Reverts "Support custom transition duration for DialogRoute, CupertinoDialogRoute and show dialog methods. ( #154048 )" ( #154743 )
...
Reverts: flutter/flutter#154048
Initiated by: nate-thegrate
Reason for reverting: using `AnimationStyle` instead would allow for complete animation duration and curve customization.
Original PR Author: nploi
Reviewed By: {piedcipher, nate-thegrate}
This change reverts the following previous change:
Currently we don't support custom transition duration for `DialogRoute`, `CupertinoDialogRoute` and show dialog methods , This PR will to support that.
2024-09-06 19:13:17 +00:00
Bruno Leroux
2e221e7308
Fix DropdownMenu focused item styles ( #153159 )
...
## Description
This PR fixes the style resolution for selected dropdown menu items (make it possible to provide a custom style and avoid hardcoded values when possible).
For the moment, I kept the default selected background which was previously set (`onSurface.withOpacity(0.12)`) to keep this PR focused on its goal which is to make it possible to overrides the defaults item style by providing a custom button style at the theme level or at the menu entry level.
## Related Issue
Fixes https://github.com/flutter/flutter/issues/123736 .
## Tests
Adds 4 tests.
2024-09-06 18:50:06 +00:00
Nguyen Phuc Loi
0eaeb0d1c5
Support custom transition duration for DialogRoute, CupertinoDialogRoute and show dialog methods. ( #154048 )
...
Currently we don't support custom transition duration for `DialogRoute`, `CupertinoDialogRoute` and show dialog methods , This PR will to support that.
2024-09-06 18:42:36 +00:00
Mikhail Novoseltsev
d9321159bf
[tool] Add dartFileName setting for platform plugins ( #153099 )
...
This PR introduces the `dartFileName` parameter for platform plugin configurations with Dart platform implementations. This new parameter allows plugin developers to specify a custom path to the file where the `dartPluginClass` is defined.
**Implementation is opt-in**. `dartFileName` is completely optional and is taken in account only with `dartClassName`. Possibility to set `dartClassName` without `dartFileName` remains.
**Implementation is backward compatible** â existing configurations using only `dartClassName` remain fully supported. If `dartFileName` is omitted, the system falls back to the previous behavior of deriving the file name from the plugin name.
## Example
```yaml
flutter:
plugin:
platforms:
some_platform:
dartPluginClass: MyPlugin
dartFileName: 'src/my_plugin_implementation.dart'
```
fixes #152833
2024-09-06 18:27:09 +00:00
Reid Baker
9d9ec70b4e
[Conductor] Add ability to override mirror, add tests for default arg parsing and custom arg parsing ( #154363 )
...
fixes #154342
2024-09-06 18:07:09 +00:00
davidhicks980
35b0349294
Improve CupertinoPopupSurface appearance ( #151430 )
...
This PR makes the CupertinoPopupSurface more vibrant. Also, the gaussian kernel was switched to 30 from 20 based on comparisons.
@dkwingsmt - Looking forward to your dialog and fixes!
After is on bottom:
<img width="939" alt="image" src="https://github.com/flutter/flutter/assets/59215665/bd020c9b-af87-4342-9a9f-c9f8f7693456 ">
Notably, because the borders are very transparent, the new version looks more colorful in the sample screencap than it actually is. As such, focus on the individual colors to get a feel for the change.
| actual | old | new
|--|--|--|
| <img width="30" alt="image" src="https://github.com/flutter/flutter/assets/59215665/7de2801d-a2cc-44a4-a660-2692889fed63 "> | <img width="28" alt="image" src="https://github.com/flutter/flutter/assets/59215665/48689d82-af15-4612-b4ab-75d584e9b094 "> | <img width="30" alt="image" src="https://github.com/flutter/flutter/assets/59215665/7c1075ec-b815-47e0-b822-65a2b63497a0 "> |
| <img width="24" alt="image" src="https://github.com/flutter/flutter/assets/59215665/2eeefe25-2e1d-4a79-b748-4925d950b9a2 "> | <img width="26" alt="image" src="https://github.com/flutter/flutter/assets/59215665/68a2694c-d943-4563-9b5e-9e86e2ee1d58 "> | <img width="28" alt="image" src="https://github.com/flutter/flutter/assets/59215665/1932b90a-1719-40f5-828e-41ceafd59e26 "> |
<img width="22" alt="image" src="https://github.com/flutter/flutter/assets/59215665/0bd22c64-dd37-4262-a7e8-ed610151ab7a "> | <img width="28" alt="image" src="https://github.com/flutter/flutter/assets/59215665/e1738bd2-98d2-491b-9a4a-d2c7cbc5a080 "> | <img width="25" alt="image" src="https://github.com/flutter/flutter/assets/59215665/c245d786-19aa-4a14-8df3-029591d1debd "> |
Partially addresses https://github.com/flutter/flutter/issues/29483
This will need tests, which I will add once I know which tests break due to this commit.
Blockers:
* https://github.com/flutter/flutter/issues/152026
2024-09-06 15:47:11 +00:00
engine-flutter-autoroll
c56ab6b947
Roll Packages from 71e827e7df68 to 56df73e3c54c (1 revision) ( #154725 )
...
71e827e7df...56df73e3c5
2024-09-06 10687576+bparrishMines@users.noreply.github.com [extension_google_sign_in_as_googleapis_auth][google_maps_flutter_ios] Manual roll with fixes to example and skipping some native tests (flutter/packages#7571 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-06 15:45:07 +00:00
Michael Goderbauer
c6b0876a2f
Quick access to style guide ( #154689 )
2024-09-06 15:45:04 +00:00
auto-submit[bot]
3d53d1ae95
Reverts "Roll Flutter Engine from c50eb8a65097 to 015f3b1dec53 (2 revisions) ( #154691 )" ( #154726 )
...
Reverts: flutter/flutter#154691
Initiated by: jtmcdole
Reason for reverting: breaking flutter-dashboard
Original PR Author: engine-flutter-autoroll
Reviewed By: {fluttergithubbot}
This change reverts the following previous change:
c50eb8a650...015f3b1dec
2024-09-05 jonahwilliams@google.com [engine] always force platform channel responses to schedule a task. (flutter/engine#54975 )
2024-09-05 tugorez@users.noreply.github.com Fix unexpected ViewFocus events when Text Editing utilities change focus in the middle of a blur call. (flutter/engine#54965 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-06 15:24:26 +00:00
Loïc Sharma
aea84342eb
Improve iOS unpack target's error messages ( #154649 )
...
Improves the formatting and error messages of the target that unpacks the Flutter framework in Flutter iOS builds.
Follow up to: https://github.com/flutter/flutter/pull/154645
Part of https://github.com/flutter/flutter/issues/151567
2024-09-05 23:46:22 +00:00
gaaclarke
9e99675dbe
Made some pixel tests fuzzy ( #154680 )
...
This is a forward fix for the failures seen in https://github.com/flutter/engine/pull/54714/checks?check_run_id=29742599916 on https://github.com/flutter/engine/pull/54714
issue: https://github.com/flutter/flutter/issues/127855
2024-09-05 23:11:03 +00:00
engine-flutter-autoroll
b0ed1cb4f4
Roll Flutter Engine from c50eb8a65097 to 015f3b1dec53 (2 revisions) ( #154691 )
...
c50eb8a650...015f3b1dec
2024-09-05 jonahwilliams@google.com [engine] always force platform channel responses to schedule a task. (flutter/engine#54975 )
2024-09-05 tugorez@users.noreply.github.com Fix unexpected ViewFocus events when Text Editing utilities change focus in the middle of a blur call. (flutter/engine#54965 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-05 22:41:27 +00:00
dependabot[bot]
57faab2d11
Bump peter-evans/create-pull-request from 7.0.0 to 7.0.1 ( #154690 )
...
Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request ) from 7.0.0 to 7.0.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/peter-evans/create-pull-request/releases ">peter-evans/create-pull-request's releases</a>.</em></p>
<blockquote>
<h2>Create Pull Request v7.0.1</h2>
<p>âï¸ Fixes <a href="https://redirect.github.com/peter-evans/create-pull-request/issues/3311 ">an issue</a> affecting one particular use case where the action fails on <code>diff --stat</code> with <code>fatal: ambiguous argument</code>.</p>
<h2>What's Changed</h2>
<ul>
<li>build(deps): bump peter-evans/create-pull-request from 6 to 7 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3283 ">peter-evans/create-pull-request#3283</a></li>
<li>build(deps-dev): bump <code>@âtypes/node</code> from 18.19.46 to 18.19.48 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3288 ">peter-evans/create-pull-request#3288</a></li>
<li>build(deps-dev): bump <code>@âtypescript-eslint/parser</code> from 7.17.0 to 7.18.0 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3289 ">peter-evans/create-pull-request#3289</a></li>
<li>build(deps-dev): bump eslint-plugin-import from 2.29.1 to 2.30.0 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3290 ">peter-evans/create-pull-request#3290</a></li>
<li>build(deps-dev): bump <code>@âtypescript-eslint/eslint-plugin</code> from 7.17.0 to 7.18.0 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3291 ">peter-evans/create-pull-request#3291</a></li>
<li>fix: handle ambiguous argument failure on diff stat by <a href="https://github.com/peter-evans "><code>@âpeter-evans</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3312 ">peter-evans/create-pull-request#3312</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/peter-evans/create-pull-request/compare/v7.0.0...v7.0.1 ">https://github.com/peter-evans/create-pull-request/compare/v7.0.0...v7.0.1 </a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="8867c4aba1 "><code>8867c4a</code></a> fix: handle ambiguous argument failure on diff stat (<a href="https://redirect.github.com/peter-evans/create-pull-request/issues/3312 ">#3312</a>)</li>
<li><a href="6073f5434b "><code>6073f54</code></a> build(deps-dev): bump <code>@âtypescript-eslint/eslint-plugin</code> (<a href="https://redirect.github.com/peter-evans/create-pull-request/issues/3291 ">#3291</a>)</li>
<li><a href="6d01b5601c "><code>6d01b56</code></a> build(deps-dev): bump eslint-plugin-import from 2.29.1 to 2.30.0 (<a href="https://redirect.github.com/peter-evans/create-pull-request/issues/3290 ">#3290</a>)</li>
<li><a href="25cf8451c3 "><code>25cf845</code></a> build(deps-dev): bump <code>@âtypescript-eslint/parser</code> from 7.17.0 to 7.18.0 (<a href="https://redirect.github.com/peter-evans/create-pull-request/issues/3289 ">#3289</a>)</li>
<li><a href="d87b980a0e "><code>d87b980</code></a> build(deps-dev): bump <code>@âtypes/node</code> from 18.19.46 to 18.19.48 (<a href="https://redirect.github.com/peter-evans/create-pull-request/issues/3288 ">#3288</a>)</li>
<li><a href="119d131ea9 "><code>119d131</code></a> build(deps): bump peter-evans/create-pull-request from 6 to 7 (<a href="https://redirect.github.com/peter-evans/create-pull-request/issues/3283 ">#3283</a>)</li>
<li><a href="73e6230af4 "><code>73e6230</code></a> docs: update readme</li>
<li><a href="c0348e860f "><code>c0348e8</code></a> ci: add v7 to workflow</li>
<li>See full diff in <a href="4320041ed3...8867c4aba1 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2024-09-05 22:17:06 +00:00
Qun Cheng
6dd929ab28
Normalize Dialog theme ( #153982 )
...
This PR is to make preparations to make `DialogTheme` conform to Flutter's conventions for component themes:
* Added a `DialogThemeData` class which defines overrides for the defaults for `Dialog` properties.
* Added 2 `DialogTheme` constructor parameters: `DialogThemeData? data` and `Widget? child`. This is now the preferred way to configure a `DialogTheme`:
```
DialogTheme(
data: DialogThemeData(color: xxx, elevation: xxx, ...),
child: Dialog(...)
)
```
These two properties are made nullable to not break existing apps which has customized `ThemeData.dialogTheme`.
* Changed the type of theme defaults from `DialogTheme` to `DialogThemeData`.
TODO:
* Fix internal failures.
* Change the type of `ThemeData.dialogTheme` from `DialogTheme` to `DialogThemeData`. This may cause breaking changes, a migration guide will be created.
Addresses the "theme normalization" sub project within https://github.com/flutter/flutter/issues/91772
2024-09-05 22:00:23 +00:00