9222 Commits

Author SHA1 Message Date
Yegor
51e48deb34 add a convenience CLI tool for building and testing web engine (flutter/engine#12197) 2019-09-10 14:52:57 -07:00
Jason Simmons
a2819be2e2 [flutter_runner] Generate symbols for the Dart VM profiler (flutter/engine#12048)
Ported from the original implementation in the Topaz tree.
2019-09-10 14:35:42 -07:00
Yegor
0a3bdb877f Add custom test plugin that supports screenshot tests (flutter/engine#12079)
- Add a custom `PlatformPlugin` that spins up a server waiting for test to request a screenshot.
  - When a screenshot is requested the plugin talks to Chrome via the debug port, captures a screenshot, and compares it with a golden file
- This PR also adds proper CLI for `dev/test.dart` with an `ArgParser` for future extension into a proper developer tool for the team.
  - As a first couple of features, it adds `--debug` option to launch Chrome in debug mode, a `--target` option to choose a single test to run rather than all tests, and `--shard` option to choose a subset of tests to run.

Limitations:
 - While screenshot test will run on Cirrus, they are configured to not fail on Cirrus. Need to solve Chrome version skew.
 - Stack maps do not work yet (you get stacks, but they are nonsensical)
 - When requesting a single test, build_runner builds all tests anyway
 - Nothing but desktop Chrome is supported
 - Nothing but Linux is supported
 - There's no Chrome version pinning; currently assumed stable Chrome channel
2019-09-10 13:53:47 -07:00
Chinmay Garde
0c3ded5c19 Move the Fuchsia tryjob into a its own step and disable LTO. (flutter/engine#12190) 2019-09-10 13:51:07 -07:00
Ben Konyi
b1741cd309 Roll src/third_party/dart 62f78a7abb..300c3333d1 (6 commits)
dart-lang/sdk@300c3333d1 [gardening] Always tag class_id register on arm64 in subtype test cache stub
dart-lang/sdk@6717bfe423 [vm/concurrency] Lock weak table to prepare for concurrent access.
dart-lang/sdk@8329968192 fix for prefer_single_quotes
dart-lang/sdk@9357b48a8d [gardening] Use target::kWordSizeLog2 instead of kWordSizeLog2 on arm (fixes broken build)
dart-lang/sdk@ef9d699f07 [vm/concurrency] Move all information except for the class pointers out of [ClassTable] into [SharedClassTable]
dart-lang/sdk@9a2e2801d9 fix for avoid_relative_lib_imports
2019-09-10 13:34:22 -07:00
skia-flutter-autoroll
d9f2a5d2f6 Roll src/third_party/skia b88894c8811b..66d8006c2bb1 (5 commits) (flutter/engine#12178)
https://skia.googlesource.com/skia.git/+log/b88894c8811b..66d8006c2bb1

git log b88894c8811b..66d8006c2bb1 --date=short --no-merges --format='%ad %ae %s'
2019-09-10 ethannicholas@google.com fixed an assertion error with unspecified sksl array sizes
2019-09-10 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-09-10 brianosman@google.com GL: Don't leak shader objects when program linking fails
2019-09-10 bsalomon@google.com Adapt GrRectBlur for cases with rect W/H less than six sigma.
2019-09-10 jvanverth@google.com Hook up pinch-zoom and swipe gestures.

Created with:
  gclient setdep -r src/third_party/skia@66d8006c2bb1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC mtklein@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=mtklein@google.com
2019-09-10 14:54:16 -04:00
Jason Simmons
0354d92bea [flutter_runner] Port the accessibility bridge from Topaz (flutter/engine#12054) 2019-09-10 11:29:08 -07:00
liyuqian
6b742994a3 Smooth out iOS irregular input events delivery (flutter/engine#11817)
Fixes https://github.com/flutter/flutter/issues/31086

This patch is a lower level implementation of
https://github.com/flutter/flutter/pull/36616 that would only impact iOS
engine, and host unittests.
2019-09-10 11:18:01 -07:00
Ben Konyi
4745c0df72 Roll src/third_party/dart ccb6ba948b..62f78a7abb (3 commits)
dart-lang/sdk@62f78a7abb [nit] Fixes two typos: build flag and error string.
dart-lang/sdk@35a7f4b552 [release] Update CHANGELOG.md for 2.5.0
dart-lang/sdk@f16d6d5910 [infra] Ignore newly detected flakes in try runs
2019-09-10 10:23:59 -07:00
Jonah Williams
e412093624 Make ImageShader implement Shader for web ui (flutter/engine#12161) 2019-09-10 10:15:32 -07:00
Ben Konyi
50568dcda8 Roll src/third_party/dart 2e8d912848..ccb6ba948b (30 commits)
dart-lang/sdk@ccb6ba948b [cfe] Gather constraints from both possibilities for FutureOr
dart-lang/sdk@f1f709ec11 Migration: add support for metadata on library/import/export/part/part-of directives.
dart-lang/sdk@1daf84f0dc [nnbd_migration] support spread elements
dart-lang/sdk@7413879026 [analyzer] Add getter isNullAware to SpreadElement
dart-lang/sdk@78bf8f08b9 Fix language_2/deferred_load_library_wrong_args_test.
dart-lang/sdk@9fccb5120b [vm/bytecode] Fix clobbering of exception handler types in bytecode reader.
dart-lang/sdk@b4724c1d78 Fix language_2/regress_23408_test.
dart-lang/sdk@424ef3646e [vm/fuzzer] Print steps to reproduce on divergence
dart-lang/sdk@76bc894576 [vm/bytecode] Generate explicit DebugCheck for assignment to static field
dart-lang/sdk@95db62d6a2 [vm/io] Return data right away if it's ready.
dart-lang/sdk@601d8934f4 Fix issue31596 tests
dart-lang/sdk@32848c3a25 Migration: Rework handling of assignments to FutureOr.
dart-lang/sdk@36648acfcc [nnbd_migration] Pass as casts to _handleAssignment
dart-lang/sdk@98837e6e43 [vm/bytecode] Workaround for incorrect type parameters in function types
dart-lang/sdk@4e7b77e428 Fix language_2/super_bound_closure_test
dart-lang/sdk@a2c8b69af0 Status file cleanup
dart-lang/sdk@879cdeffb3 update scanner test
dart-lang/sdk@909e2515af Fix regress_29025_test
dart-lang/sdk@ecb9a113d1 Fix language_2/regress_22976_test
dart-lang/sdk@ef2a21ffd9 [vm/bytecode] Use local variable information when compiling from bytecode
dart-lang/sdk@27f803db76 fix for convert_to_null_aware_operators
dart-lang/sdk@0851b9ae4c Consider both getter and setter when deciding whether an extension reference is ambiguous.
dart-lang/sdk@4310d157a1 Fix language_2/type_promotion_more_specific_test/04
dart-lang/sdk@438c595950 Fix language_2/regress_30339_test
dart-lang/sdk@9497b7b0a4 Delete language_2/regress_29405_test
dart-lang/sdk@6f38a73618 Remove most of the task model.
dart-lang/sdk@fbd21a0d1f Guard against null in exportedDeclarations.
dart-lang/sdk@b4614904de Migration: add support for indexing on a dynamic type.
dart-lang/sdk@9fd672b1b7 fix for prefer_expression_bodies
dart-lang/sdk@c2e55a26bc [vm/bytecode] Cleanup support for old bytecode format versions before v10
2019-09-10 07:27:51 -07:00
skia-flutter-autoroll
3dd4e33a90 Roll src/third_party/skia 9e5c47936b17..b88894c8811b (3 commits) (flutter/engine#12151)
https://skia.googlesource.com/skia.git/+log/9e5c47936b17..b88894c8811b

git log 9e5c47936b17..b88894c8811b --date=short --no-merges --format='%ad %ae %s'
2019-09-10 bsalomon@google.com Remove per-format glCheckframebufferStatus checks.
2019-09-10 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (nontrivial).
2019-09-10 benjaminwagner@google.com [infra] Switch Mac builders to 10.14.6.

Created with:
  gclient setdep -r src/third_party/skia@b88894c8811b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC mtklein@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=mtklein@google.com
2019-09-10 10:20:38 -04:00
skia-flutter-autoroll
976af6a1f3 Roll src/third_party/skia 1bf30ce852e0..9e5c47936b17 (2 commits) (flutter/engine#12129)
https://skia.googlesource.com/skia.git/+log/1bf30ce852e0..9e5c47936b17

git log 1bf30ce852e0..9e5c47936b17 --date=short --no-merges --format='%ad %ae %s'
2019-09-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 a7ff7df26f28..58c5b07b47cf (7 commits)
2019-09-10 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps

Created with:
  gclient setdep -r src/third_party/skia@9e5c47936b17

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC mtklein@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=mtklein@google.com
2019-09-10 06:13:40 -04:00
skia-flutter-autoroll
73bbc2b3e1 Roll src/third_party/skia 8cae1e95a23b..1bf30ce852e0 (2 commits) (flutter/engine#12106)
https://skia.googlesource.com/skia.git/+log/8cae1e95a23b..1bf30ce852e0

git log 8cae1e95a23b..1bf30ce852e0 --date=short --no-merges --format='%ad %ae %s'
2019-09-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 44e6523d7ff3..cebb9635a5d5 (1 commits)
2019-09-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src a0cef9f54754..340a17ae1cc7 (385 commits)

Created with:
  gclient setdep -r src/third_party/skia@1bf30ce852e0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC mtklein@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=mtklein@google.com
2019-09-10 02:09:54 -04:00
skia-flutter-autoroll
1b91c27b61 Roll fuchsia/clang/mac-amd64 from H1Qjc... to HfPKR... (flutter/engine#12088)
Roll fuchsia/clang/mac-amd64 from H1Qjc... to HfPKR...

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-toolchain-flutter-engine
Please CC  on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-09-09 23:10:00 -04:00
Chinmay Garde
5d6d4e450d Don't launch the observatory by default on each embedder unit-test invocation. (flutter/engine#12087)
There is no test to assert this and it unnecessarily slows down the test
harness and opens tons of port on the host.
2019-09-09 19:58:36 -07:00
skia-flutter-autoroll
837e3c9770 Roll src/third_party/skia c2d84bfa7421..8cae1e95a23b (4 commits) (flutter/engine#12086)
https://skia.googlesource.com/skia.git/+log/c2d84bfa7421..8cae1e95a23b

git log c2d84bfa7421..8cae1e95a23b --date=short --no-merges --format='%ad %ae %s'
2019-09-09 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-09-09 herb@google.com Cleanup SkPackedGlyphID
2019-09-09 brianosman@google.com Remove temporary Metal pipeline cache size hack
2019-09-09 hcm@google.com Add release section for milestones and rel notes

Created with:
  gclient setdep -r src/third_party/skia@8cae1e95a23b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC mtklein@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=mtklein@google.com
2019-09-09 21:29:26 -04:00
Ben Konyi
daf73e2e97 Roll src/third_party/dart fb14babf59..2e8d912848 (65 commits)
dart-lang/sdk@2e8d912848 [developer] Allow async end events to have independent arguments.
dart-lang/sdk@09ce6d30e7 [vm, service] Remove _collectAllGarbage.
dart-lang/sdk@bc24702149 Add missing parens to static_extension_getter_setter_conflicts_test.dart
dart-lang/sdk@e9dcb9f45d fix typo in factory; add mixin text for protected
dart-lang/sdk@ab5e36bcfb fix for prefer_int_literals
dart-lang/sdk@41c5b81818 [cfe] Special error message for illegal override of a setter by a field
dart-lang/sdk@e9c3eebef1 [infra] Add handling of signed SDK directories to promote.py
dart-lang/sdk@ff0fda7732 [cfe] Handle UnknownType using defaultDartType
dart-lang/sdk@129d4a6144 simplify dartfix output
dart-lang/sdk@41bf7443d4 update parser to report static constructor
dart-lang/sdk@cb1efb8d27 update parser to allow "late var" in NNBD
dart-lang/sdk@99007f3a3e remove duplicate error generation in ClassBuilder
dart-lang/sdk@fb73cb19e6 update parser to report MixinDeclaresConstructor error
dart-lang/sdk@355df2a354 split AstBuilder endClassConstructor out of endClassMethod event
dart-lang/sdk@b6f6240013 fix extension factory declaration in AST
dart-lang/sdk@618b56d24d fix conditional expression parsing with NNBD enabled
dart-lang/sdk@fb446e5768 [dartdevc] Properly emitting JS interop anonymous classes
dart-lang/sdk@4a4f7cbde3 Migration: Handle uses of typedef types as expressions.
dart-lang/sdk@0b0c113b52 Migration: rework edge builder prefix handling.
dart-lang/sdk@028d97bb1d Migration: handle references to already-migrated fields.
dart-lang/sdk@cbe135255d Migration: add support for most compound assignments.
dart-lang/sdk@daaa6657b1 Migration: fix a corner case of post-dominator analysis.
dart-lang/sdk@23d28932f0 Remove asserts in TypeProviderImpl.
dart-lang/sdk@3d3bbc2dbf Remove 'strongMode' flag in StaticTypeAnalyzerTest.
dart-lang/sdk@7f8398e484 Changes to MockSdk to make it usable in linter.
dart-lang/sdk@116cfbaa2d Issue 38198. Fix for isMoreSpecific() extension.
dart-lang/sdk@9391e15cfd [ package:vm_service ] Added support for service protocol version 3.27.
dart-lang/sdk@13a69b5631 [vm/bytecode] Replace ICData constant pool entries with DynamicCall
dart-lang/sdk@cff9c587f4 Tighten call conventions in allowInterop
dart-lang/sdk@c0f49b05dd [vm/debugger] Pick the correct context async variable in bytecode frames.
dart-lang/sdk@68dede011e [ VM / Service ] Add getCpuProfileSamples RPC which returns a minimally processed sample buffer.
dart-lang/sdk@84db16381d [vm] Remove dead --load_deferred_eagerly and dependent code tracking for library prefixes.
dart-lang/sdk@1d6ab52f38 [vm] Fix CoreSnapshotSize and StandaloneSnapshotSize to account for the image page size.
dart-lang/sdk@fd7676e0bc Fix language_2/config_import_corelib_test
dart-lang/sdk@5247036142 fix for convert_to_if_element
dart-lang/sdk@e1dc432102 [vm/fuzzer]  Update rerun output and parser script
dart-lang/sdk@2c219ddb07 Replace AnalysisContextFactory with TestAnalysisContext.
dart-lang/sdk@67cdae394f Add import fix in missed case
dart-lang/sdk@cf94c3a2fa Additional tests verifying interaction between mixins, static extensions, and visiblity annotations (protected, visibleForTemplate, visibleForTesting).
dart-lang/sdk@ffd50c0dc5 Report EXTENSION_AS_EXPRESSION, set type fo dynamic.
dart-lang/sdk@254d0776d4 [vm/fuzzer] Fix bug where FFI caused dart crash
dart-lang/sdk@f5c0e2e362 [vm/concurrency] Ensure instance size in class table is either 0 or the correct size
dart-lang/sdk@eb60f0531e Support a fix to add a setter, both in extensions and elsewhere
dart-lang/sdk@e227ffa955 Migration: improve handling of catch clauses.
dart-lang/sdk@40454f0918 Fix language_2/f_bounded_quantification2_test
dart-lang/sdk@836f6de0f4 Fix language_2/f_bounded_quantification4_test
dart-lang/sdk@8ad0832bcb [vm/bytecode] Use static types of parameters when compiling from bytecode
dart-lang/sdk@1354ec93db fix for prefer_for_elements_to_map_fromIterable
dart-lang/sdk@152aa5a6ed fix calls following null-assertion operator
dart-lang/sdk@4e4047a52f fix extension abstract method error
dart-lang/sdk@a689f8df06 corelib_2/unsigned_shift_test fixes
dart-lang/sdk@6f4ceb887e [vm] Provide a couple more gdb helpers to print stack traces.
dart-lang/sdk@d7c96f323d Migration: handle prefixed class references.
dart-lang/sdk@0d63ce1d0c Clean up MockSdkElements.
dart-lang/sdk@8022f885af Stop using TestTypeProvider in analyzer_plugin.
dart-lang/sdk@e55a1e0f3a [vm/fuzzer] Add filter keywords to collect_data
dart-lang/sdk@c6a6add465 [vm/fuzzer] Count re-runs
dart-lang/sdk@d964c50cff clear contents on TemplateElement#setInnerHtml before appending
dart-lang/sdk@c8f3f132ad [vm, snapshot] Use data image pages for kFull snapshots.
dart-lang/sdk@add83ad185 Fix language_2/generic_no_such_method_dispatcher_test
dart-lang/sdk@f5b53276ce Fix language_2/compile_time_constant_static5_test
dart-lang/sdk@e34d71feee [nnbd_migration] Implement if/for in map/set
dart-lang/sdk@da235a57f8 [nnbd_migration] Fix for elements for list literals
dart-lang/sdk@6ae9709bcb Create TestTypeProvider as TypeProviderImpl on MockSdkElements.
dart-lang/sdk@46d7064108 Stop using resolutionMap in DDC.
2019-09-09 18:27:20 -07:00
Chinmay Garde
9b9635391c Guard availability of user notification related methods to iOS 10.0 (flutter/engine#12084)
* `NS_AVAILABLE_IOS(10_0)` makes us tell our compiler that the method needs
  to be stamped into the TU but we promise to do stuff in it only on iOS 10.0
  and above.
* `@availability` ensures that if those methods are called on iOS versions less
  than 10.0, we will do nothing with it. This guards us against the case where
  iOS introduced the functionality privately in older versions of iOS.
2019-09-09 20:25:29 -04:00
Maurice Parrish
af3929e2aa Add capability to add AppDelegate as UNUserNotificationCenterDelegate (flutter/engine#9864) 2019-09-09 14:54:00 -07:00
Ferhat
173674166f Add GradientRadial paintStyle implementation (flutter/engine#12081) 2019-09-09 14:13:10 -07:00
Harry Terkelsen
c314ab5b5b Don't quote generic font families (flutter/engine#12080)
* Don't quote generic font families

This is a change that should have been upstreamed before.

* Change generic family List to a Set

* Add test
2019-09-09 14:05:40 -07:00
skia-flutter-autoroll
67e65ce1db Roll src/third_party/skia 28d40b2e7ade..c2d84bfa7421 (3 commits) (flutter/engine#12082)
https://skia.googlesource.com/skia.git/+log/28d40b2e7ade..c2d84bfa7421

git log 28d40b2e7ade..c2d84bfa7421 --date=short --no-merges --format='%ad %ae %s'
2019-09-09 ethannicholas@google.com fixed byte/ubyte types in SPIR-V output
2019-09-09 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-09-09 brianosman@google.com Simplify GPUSink constructors by just passing the config object

Created with:
  gclient setdep -r src/third_party/skia@c2d84bfa7421

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC mtklein@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=mtklein@google.com
2019-09-09 16:59:52 -04:00
Jenn Magder
2e1bb190d1 Remove ENABLE_BITCODE from Scenarios test app (flutter/engine#11839) 2019-09-09 12:10:31 -07:00
skia-flutter-autoroll
160c032cf3 Roll src/third_party/skia 4f2674da4bbc..28d40b2e7ade (4 commits) (flutter/engine#12077)
https://skia.googlesource.com/skia.git/+log/4f2674da4bbc..28d40b2e7ade

git log 4f2674da4bbc..28d40b2e7ade --date=short --no-merges --format='%ad %ae %s'
2019-09-09 egdaniel@google.com Reland "Add support for direct use of vulkan primary command buffer in render pass."
2019-09-09 ethannicholas@google.com Fixed skslc assertion failure discovered by fuzzer
2019-09-09 brianosman@google.com Remove legacy flag: GrContextOptions::fDisallowGLSLBinaryCaching
2019-09-09 reed@google.com share private iterator/helpers for building paths

Created with:
  gclient setdep -r src/third_party/skia@28d40b2e7ade

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC mtklein@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=mtklein@google.com
2019-09-09 12:51:51 -04:00
skia-flutter-autoroll
15a7e6a929 Roll src/third_party/skia 627d15588f4d..4f2674da4bbc (1 commits) (flutter/engine#12075)
https://skia.googlesource.com/skia.git/+log/627d15588f4d..4f2674da4bbc

git log 627d15588f4d..4f2674da4bbc --date=short --no-merges --format='%ad %ae %s'
2019-09-09 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps

Created with:
  gclient setdep -r src/third_party/skia@4f2674da4bbc

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC mtklein@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=mtklein@google.com
2019-09-09 08:45:46 -04:00
skia-flutter-autoroll
bd1c2b1f34 Roll src/third_party/skia 6c3bd09ead0f..627d15588f4d (3 commits) (flutter/engine#12074)
https://skia.googlesource.com/skia.git/+log/6c3bd09ead0f..627d15588f4d

git log 6c3bd09ead0f..627d15588f4d --date=short --no-merges --format='%ad %ae %s'
2019-09-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 df0ce01870fa..a7ff7df26f28 (5 commits)
2019-09-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 649263777d17..a0cef9f54754 (522 commits)
2019-09-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 5d0faf9be9d7..44e6523d7ff3 (12 commits)

Created with:
  gclient setdep -r src/third_party/skia@627d15588f4d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC mtklein@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=mtklein@google.com
2019-09-09 03:05:59 -04:00
shoryukenn
58c3192c32 Improve Unicode handling on Windows (flutter/engine#11899)
Significantly improves the behavior of non-ASCII text input on Windows. Correctly
processes incoming character events as UTF-16, and for now uses UTF-32 for
the text model so that the existing index-based logic will work much more often.

Future work is still needed, but this will handle far more cases correctly.
2019-09-08 12:13:59 -07:00
skia-flutter-autoroll
1a8e8e5b41 Roll fuchsia/clang/linux-amd64 from VoYNW... to 2IT_b... (flutter/engine#12072)
Roll fuchsia/clang/linux-amd64 from VoYNW... to 2IT_b...

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-toolchain-flutter-engine
Please CC  on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-09-08 11:15:02 -04:00
skia-flutter-autoroll
77fa218ae1 Roll fuchsia/clang/mac-amd64 from XAazI... to H1Qjc... (flutter/engine#12071)
Roll fuchsia/clang/mac-amd64 from XAazI... to H1Qjc...

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-toolchain-flutter-engine
Please CC  on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-09-08 11:05:00 -04:00
xster
1488856a85 Annotate nullability on FlutterEngine to make swift writing more ergonomic (flutter/engine#11808) 2019-09-08 00:25:07 -07:00
skia-flutter-autoroll
45842a8597 Roll src/third_party/skia f433336585ed..6c3bd09ead0f (1 commits) (flutter/engine#12070)
https://skia.googlesource.com/skia.git/+log/f433336585ed..6c3bd09ead0f

git log f433336585ed..6c3bd09ead0f --date=short --no-merges --format='%ad %ae %s'
2019-09-08 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps

Created with:
  gclient setdep -r src/third_party/skia@6c3bd09ead0f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC mtklein@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=mtklein@google.com
2019-09-08 02:28:48 -04:00
skia-flutter-autoroll
df9316cdf1 Roll src/third_party/skia 69a426f5a427..f433336585ed (1 commits) (flutter/engine#12068)
https://skia.googlesource.com/skia.git/+log/69a426f5a427..f433336585ed

git log 69a426f5a427..f433336585ed --date=short --no-merges --format='%ad %ae %s'
2019-09-07 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps

Created with:
  gclient setdep -r src/third_party/skia@f433336585ed

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jlavrova@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=jlavrova@google.com
2019-09-07 06:24:33 -04:00
Dan Field
cae01907a7 option for --no-lto for fuchsia (flutter/engine#12010) 2019-09-07 00:21:04 -07:00
skia-flutter-autoroll
37738016dd Roll src/third_party/skia 380561393385..69a426f5a427 (2 commits) (flutter/engine#12067)
https://skia.googlesource.com/skia.git/+log/380561393385..69a426f5a427

git log 380561393385..69a426f5a427 --date=short --no-merges --format='%ad %ae %s'
2019-09-07 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-09-07 iannucci@chromium.org Remove use of deprecated tempfile module in skia.

Created with:
  gclient setdep -r src/third_party/skia@69a426f5a427

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jlavrova@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=jlavrova@google.com
2019-09-07 02:19:59 -04:00
skia-flutter-autoroll
3bc827152e Roll src/third_party/skia c30f1a936d84..380561393385 (3 commits) (flutter/engine#12059)
https://skia.googlesource.com/skia.git/+log/c30f1a936d84..380561393385

git log c30f1a936d84..380561393385 --date=short --no-merges --format='%ad %ae %s'
2019-09-06 benjaminwagner@google.com [infra] Update Mac 10.14 bots to 10.14.6
2019-09-06 cblume@chromium.org Add blocklist command line parameter
2019-09-06 egdaniel@google.com Revert "Add support for direct use of vulkan primary command buffer in render pass."

Created with:
  gclient setdep -r src/third_party/skia@380561393385

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jlavrova@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=jlavrova@google.com
2019-09-06 22:15:16 -04:00
Ben Konyi
835b2e8380 Roll src/third_party/dart ec7ec4ecf7..fb14babf59 (19 commits)
dart-lang/sdk@fb14babf59 [vm/fuzzer] disable control flow collections again
dart-lang/sdk@5d4940f968 Migration: remove a bogus comment
dart-lang/sdk@6043b53af6 Migration: add the ability to dump the graph after propagation.
dart-lang/sdk@cdd2f855e1 Migration: handle upcasts from function type to Function or Object.
dart-lang/sdk@7e04e051cf Migration: add an option to print just exception nodes rather than full stack traces.
dart-lang/sdk@28d16e1172 Migration: implement substitution logic for generic function types.
dart-lang/sdk@f48a5a9f64 Support create method fix for extensions
dart-lang/sdk@17c06c342e Unify to single TypeProviderImpl.
dart-lang/sdk@8c13ecf443 [cfe] Handle nested on-types
dart-lang/sdk@0a49ddef73 Remove previewDart2 related code in some tests.
dart-lang/sdk@836039e9b6 Add MockSdkElements for creating dart:core and dart:async mocks.
dart-lang/sdk@d8f16611ed Support replacing similar names in extensions
dart-lang/sdk@4d0fa1e402 fix for slash_for_doc_comments
dart-lang/sdk@dc204ec879 [CFE] Preserve file URIs of expressions in unevaluated constants.
dart-lang/sdk@0242f0c724 [kernel] FileUriExpression node
dart-lang/sdk@70a7cbf49d [vm] Support extensions in ffi transformation and tfa tree shaker
dart-lang/sdk@7152fd06a5 [cfe] Handle [] and []= on extensions
dart-lang/sdk@deb2fcf818 [cfe] Handle extension operators
dart-lang/sdk@7ca157dfd6 [cfe] Thread nullability modifiers for some InterfaceTypes in outline
2019-09-06 19:13:19 -07:00
Kaushik Iska
5d82d1af56 Roll fuchsia/clang/linux-amd64 from -mnHl... to VoYNW... (flutter/engine#12058)
fixing: https://github.com/flutter/engine/pull/12053
2019-09-06 19:07:49 -07:00
Kaushik Iska
2d656f6f32 Revert "Manage resource and onscreen contexts using separate IOSGLContext objects (#11798)" (flutter/engine#12055)
This reverts commit 9297908d54bf20f8cd8dd81849c95ff8528683e3.
2019-09-06 18:12:16 -07:00
George Wright
9297908d54 Manage resource and onscreen contexts using separate IOSGLContext objects (flutter/engine#11798)
Manage resource and onscreen contexts using separate IOSGLContext objects
2019-09-06 16:44:49 -07:00
Kaushik Iska
3a78a5e281 [flutter_runner] Refactor our build rules to make them more inline with topaz. (flutter/engine#12034)
Also add flutter tool support for topaz in-tree builds that already have
a dependency on the framework repository.

After this the only major changes left are profiler symbols and
Framework mode.

This should make making topaz use our buldrules significantly easier.
2019-09-06 15:30:37 -07:00
Emmanuel Garcia
61d1fabcae Document dependencies and remove support-v13 (flutter/engine#11912) 2019-09-06 15:25:59 -07:00
Ben Konyi
4c0b884392 Roll src/third_party/dart be66176534..ec7ec4ecf7 (37 commits)
dart-lang/sdk@ec7ec4ecf7 [gardening] Fix import to fix Flutter build
dart-lang/sdk@f989605cc9 Fix dartdoc typo in ffi
dart-lang/sdk@2246f0a8a3 Compute constant dependencies for constructor elements in canBeConst().
dart-lang/sdk@981be87206 Add configuration options and flags for controlling NNBD mode.
dart-lang/sdk@9ff104efd6 Move StaticError and StaticErrorParser to a separate file.
dart-lang/sdk@bad1816c21 Migration: add edge builder support for generic method invocations.
dart-lang/sdk@35f45f0ee4 Do null-aware shorting for IndexExpression.
dart-lang/sdk@90aca0b8d5 Add test for incomparable on type resolution and fix expectations.
dart-lang/sdk@f4229da6ab [vm, bytecode] Produce compile-time errors instead of crashing when failing to resolve libraries etc.
dart-lang/sdk@a64b06ec83 [gardening] Migrate most files to be implicit-bool-conversion free
dart-lang/sdk@698d120328 base processor migration; fix to add type annotations
dart-lang/sdk@d9a9346c3f [vm/compiler] Fix truncating logic
dart-lang/sdk@d2dc053752 Corrections to "[vm] Fix ASAN build."
dart-lang/sdk@592914fb8b Don't report HintCode.CAN_BE_NULL_AFTER_NULL_AWARE when NNBD.
dart-lang/sdk@c219a76652 Reland "[vm/ffi] Implement FFI callbacks on AOT for ELF and Asm snapshots (excl. blobs)."
dart-lang/sdk@6a8c988fc4 Simplify the computeCompilerArguments().
dart-lang/sdk@9a847a98e8 [ VM / Service ] Fix docs for @Instance not including optional closureFunction and closureContext fields
dart-lang/sdk@ff8b43750a Move reporting INVALID_ASSIGNMENT for compound assignments into StaticTypeAnalyzer.
dart-lang/sdk@cf5e9ca423 Additional tests and fixes for creating getters
dart-lang/sdk@6e3498cd08 bump server SDK constraint lower bound
dart-lang/sdk@89dde0501d Migration: fix handling of assignments involving FutureOr.
dart-lang/sdk@ec48af600f Support fix to import a library defining an extention
dart-lang/sdk@4fbd758f9e [vm/bytecode] Optimize comparisons with null
dart-lang/sdk@16a4c0d13c Bump up oldest_supported_abi_version for abi bot
dart-lang/sdk@c7bb9cf5c4 refactor to share common fix/assist processor code
dart-lang/sdk@5a45050d1e [observatory] Flatten the heap snapshot before loading.
dart-lang/sdk@75374b89f6 [vm] Fix ASAN build.
dart-lang/sdk@8ee3f314cb [vm/gardening] clang tidy fixes
dart-lang/sdk@89ad636b58 Remove the old "preview Dart 2" flags from the test runner.
dart-lang/sdk@aa34de3fe5 Flow analysis: adjust _variableInfosEqual to do a shallow comparison.
dart-lang/sdk@ea35690b96 Flow analysis: add unit tests of try/finally handling.
dart-lang/sdk@b179ef33ec Flow analysis: add unit tests of try/catch handling.
dart-lang/sdk@e2a00dc465 Flow analysis: add unit tests of while statements
dart-lang/sdk@edceedff90 [vm, reload] Allow any change to a class that hasn't yet been declaration loaded.
dart-lang/sdk@68ba13e4e8 With NNBD null-shorting is performed.
dart-lang/sdk@a7723d5c40 [vm] Out-line handle allocation.
dart-lang/sdk@16be3a095d [vm/benchmark] Add *Bytes suffix to Isolate SendReceive benchmark
2019-09-06 15:05:10 -07:00
skia-flutter-autoroll
f98dc9b930 Roll src/third_party/skia 080d210e7acc..c30f1a936d84 (21 commits) (flutter/engine#12031)
https://skia.googlesource.com/skia.git/+log/080d210e7acc..c30f1a936d84

git log 080d210e7acc..c30f1a936d84 --date=short --no-merges --format='%ad %ae %s'
2019-09-06 egdaniel@google.com Move surface wait ops to GrRenderTasks.
2019-09-06 reed@google.com simplify convexity-helper code
2019-09-06 brianosman@google.com Add support for pre-compiling cached SkSL shaders
2019-09-06 reed@google.com speed-up rotated rects for drawAtlas
2019-09-06 ethannicholas@google.com Revert "Revert "switched SkSL interpreter over to threaded code""
2019-09-06 egdaniel@google.com Add support for direct use of vulkan primary command buffer in render pass.
2019-09-06 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-09-06 robertphillips@google.com Cleanup after removal of IORefs from GrSurface
2019-09-06 robertphillips@google.com Add kRG_88_SkColorType
2019-09-06 hcm@google.com Update Skia milestone to 79
2019-09-06 joe@bitworking.org Add env vars to cloudbuild.yaml to enable vpython for depot_tools.
2019-09-06 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-09-06 reed@google.com don't call mutex if we're unique
2019-09-06 brianosman@google.com Make the size of program/pipeline caches configurable in GrContextOptions
2019-09-06 reed@google.com use scratch path to save on mallocs in drawAtlas
2019-09-06 robertphillips@google.com Remove IORefs from GrSurface
2019-09-06 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps
2019-09-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 0c35e0f44dbd..df0ce01870fa (5 commits)
2019-09-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src e96090c328fe..649263777d17 (605 commits)
2019-09-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader cf0e2fe12289..5d0faf9be9d7 (4 commits)
2019-09-06 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).

Created with:
  gclient setdep -r src/third_party/skia@c30f1a936d84

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jlavrova@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=jlavrova@google.com
2019-09-06 17:51:39 -04:00
Kaushik Iska
ed39cbade1 [flutter_runner] Kernel platform files can now be built in topaz (flutter/engine#12016)
- Tested this compatibility in topaz repo. The build rules can now be
used to build kernel_platform_files in topaz tree, after this change we
can migrate the platform*dill and vm*snapshot files in topaz to use the
engine built artifacts.

- Also removes some namespace conflicts for dart configuration.
2019-09-06 14:34:26 -07:00
Kaushik Iska
bb74945d36 [flutter_runner] Plumb Flutter component arguments to the Dart entrypoint (flutter/engine#12026)
port of Change-Id: Ibcd4a110b84805af02a436a2a5bcf2cf3d2029a4
2019-09-06 14:16:13 -07:00
Ferhat
d01050e5fc Fix multi span text ruler cache lookup failure. (flutter/engine#12023) 2019-09-06 14:05:52 -07:00
skia-flutter-autoroll
d61b3b3030 Roll fuchsia/sdk/core/linux-amd64 from Z7PSg... to R1yqu... (flutter/engine#11945)
Roll fuchsia/sdk/core/linux-amd64 from Z7PSg... to R1yqu...

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC  on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-09-06 17:00:31 -04:00
skia-flutter-autoroll
63781ed85f Roll fuchsia/sdk/core/mac-amd64 from -AQkJ... to spUG2... (flutter/engine#11939)
Roll fuchsia/sdk/core/mac-amd64 from -AQkJ... to spUG2...

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC  on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-09-06 16:58:19 -04:00
Ben Konyi
e242a636d8 Revert "Roll src/third_party/dart be66176534..f4229da6ab (29 commits)" (flutter/engine#12029)
This reverts commit ea7bfbd54461dd12ef4d81b6cd76f1056cf35dd7.
2019-09-06 13:54:03 -07:00