DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
4,253 Commits 882 Branches 1,069 Tags
Commit Graph

4253 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Adam Barth
4dcd995d30 Update sky_tools 2015-09-16 16:49:27 -07:00
Adam Barth
5609653ad8 Merge pull request #1202 from abarth/crash_on_failure 
Crash when we can't run main()
 2015-09-16 16:44:28 -07:00
Adam Barth
9a2411eeac Crash when we can't run main() 
Also, in testing, crash when we can't load a library off disk.
 2015-09-16 16:42:37 -07:00
Ian Hickson
240f3439a0 Merge pull request #1200 from Hixie/framework 
Improve debugging aids in framework.dart
 2015-09-16 16:15:01 -07:00
Hixie
595857045c Improve debugging aids in framework.dart 2015-09-16 16:08:05 -07:00
Adam Barth
7e18c717c7 Remove extra return 2015-09-16 14:28:44 -07:00
Ian Hickson
b3b70a2739 Merge pull request #1197 from Hixie/mimic 
Factor out GlobalKeyWatcher
 2015-09-16 14:27:44 -07:00
Ian Hickson
63195ccf86 Merge pull request #1198 from Hixie/performance 
Minor clean up of animation_performance.dart
 2015-09-16 14:27:40 -07:00
Hixie
18ee265a34 Minor clean up of animation_performance.dart 
- Reorder the methods so they are closer to run order.
- Reindent the code to match style guide.
 2015-09-16 14:09:51 -07:00
Hixie
6345637835 Factor out GlobalKeyWatcher 
This also moves the logic that tracks what Widget is being watched into
GlobalKeyWatcher, and much simplifies Mimic based on this.
 2015-09-16 13:20:09 -07:00
Ian Hickson
a2e9e91b9a Merge pull request #1191 from Hixie/flex 
FlexAlignItems.stretch didn't stretch
 2015-09-16 13:09:08 -07:00
Adam Barth
87ed56f700 Merge pull request #1195 from abarth/rm_on_gesture 
Remove support for onGestureFoo from Listener
 2015-09-16 12:57:32 -07:00
Adam Barth
01c437587d Remove support for onGestureFoo from Listener 
Please use GestureDetector instead.
 2015-09-16 12:43:33 -07:00
Adam Barth
12ab0e3005 Merge pull request #1194 from abarth/drawer_gestures 
Move Drawer to GestureDetector
 2015-09-16 12:38:28 -07:00
Adam Barth
863d3f119e Move Drawer to GestureDetector 
This fixes an issue in the stocks app in horizontal mode where you could both
scroll and drag the drawer at the same time.
 2015-09-16 12:33:51 -07:00
Hixie
ebf1256a6c FlexAlignItems.stretch didn't stretch 2015-09-16 12:22:37 -07:00
Ian Hickson
100526bb51 Merge pull request #1193 from Hixie/rendering_tester 
Refactor rendering_tester
 2015-09-16 12:10:56 -07:00
Hixie
b426774c03 Refactor rendering_tester 
RenderView has to be a singleton for sanity during tests, otherwise they
all end up in the dirty lists and we end up pumping all of them each frame.
 2015-09-16 12:03:57 -07:00
Adam Barth
8f8e955bb0 Merge pull request #1192 from abarth/simplify_test_runner 
Simplify TestRunner now that we don't have test_sky
 2015-09-16 12:00:15 -07:00
Adam Barth
d5b2969546 Simplify TestRunner now that we don't have test_sky 2015-09-16 11:00:33 -07:00
Ian Hickson
afd05899d0 Merge pull request #1188 from Hixie/animatedcontainer 
AnimatedContainer isn't an AnimatedComponent.
 2015-09-16 10:41:43 -07:00
Ian Hickson
dae61b32e5 Merge pull request #1186 from abarth/rm_widget_overlay 
Remove MimicOverlay
 2015-09-16 09:30:56 -07:00
Hixie
f429d21c96 AnimatedContainer isn't an AnimatedComponent. 
Turns out it gets nothing out of inheriting from AnimatedComponent.
 2015-09-16 09:29:54 -07:00
Adam Barth
db9c46213b Remove MimicOverlay 
This widget has no client.
 2015-09-16 09:27:50 -07:00
Adam Barth
01f98ee2a0 Merge pull request #1185 from abarth/rm_webkitpy 
Remove sky/tools/test_sky
 2015-09-16 09:12:16 -07:00
Adam Barth
b8d0fa5172 Remove sky/tools/test_sky 
This patch also removes webkitpy, which now has no clients.
 2015-09-16 09:09:59 -07:00
Ian Hickson
27fc139952 Merge pull request #1184 from abarth/rev_dart 
Update Dart SDK
 2015-09-16 09:07:41 -07:00
Adam Barth
fc125715cc Fix analyzer warnings 2015-09-16 09:07:23 -07:00
Ian Hickson
9e8c7bc84b Merge pull request #1182 from Hixie/ancestor 
Clarify why we don't assert that ancestor != null.
 2015-09-16 09:06:14 -07:00
Ian Hickson
e06cfbc6c8 Merge pull request #1183 from Hixie/dismissable 
Be more explicit about what's state in dismissable
 2015-09-16 09:06:09 -07:00
Adam Barth
8fa9bcf6d7 Update Dart SDK 2015-09-16 09:03:47 -07:00
Ian Hickson
2c464b6eaa Merge pull request #1180 from Hixie/syncChildren 
"newChild == oldChild || !newChild.mounted" assert
 2015-09-15 19:14:52 -07:00
Hixie
4a09ddb336 Be more explicit about what's state in dismissable 
Move _activeCardDragEndPoint near build() so it's more obvious that it
is part of the build state.

Make a couple of functions use setState() since they modify variables
that are used by build().

Add a more detailed comment to the empty setState() call, since those
are dubious in general and need explaining when they occur, lest people
start using them as magic incantations to Make Things Work.
 2015-09-15 17:51:11 -07:00
Hixie
8e8a08433e Clarify why we don't assert that ancestor != null. 
Follow-up for #1140.
 2015-09-15 17:49:22 -07:00
Hixie
0c9f161e5c "newChild == oldChild || !newChild.mounted" assert 
If a StatefulComponent marks itself dirty, gets rebuilt, then its parent
gets rebuilt, its parent will find that its child is from a newer
generation and hasn't changed. Previously, we considered two stateful
nodes to not be syncable even if they were the same; combined with the
way the "old" node looks like it's been put elsewhere (since it's
already been synced), we end up confused as to why the new node is
already mounted.

This fixes the problem by making the canSync logic consider two
identical nodes as syncable (since they are; syncChild() short-circuits
that case), and by changing syncChildren to consider identical nodes as
matches even if they are already synced.
 2015-09-15 17:07:26 -07:00
Ian Hickson
a609dcd551 Merge pull request #1178 from Hixie/syncChild 
Improve exception reporting in Widgets framework
 2015-09-15 16:49:10 -07:00
Hixie
c596d4c141 Improve exception reporting in Widgets framework 
This specifically improves the reporting of exceptions in syncChild(),
and makes the way we've been adding information to toStringName() less
ad-hoc and easier to extend.
 2015-09-15 15:39:51 -07:00
Ian Hickson
6413e58cb6 Merge pull request #1174 from Hixie/old-gen-bug 
Ignore generation of child if child is unchanged
 2015-09-15 13:35:41 -07:00
Hixie
6ac5bb42c4 Ignore generation of child if child is unchanged 
Also:

 - don't mark a node as from the new generation if it is dirty, since we
   know it still has to be built.

 - establish the rule that you can't call setState() during initState()
   or build().

 - make syncChild() return early for unchanged children.

 - update the tests, including adding a new one.
 2015-09-15 13:20:37 -07:00
Adam Barth
51cea68d38 Merge pull request #1148 from ksimbili/shutdown_sky 
Delete document view when view manager is disconnected.
 2015-09-15 11:55:49 -07:00
Kishore Simbili
5d12b71863 Delete document view when view manager is disconnected. 2015-09-15 10:22:40 -07:00
Adam Barth
07155abc7d Rev pub package 2015-09-15 09:14:51 -07:00
Adam Barth
fb63ec1a57 Rev pub packages 2015-09-15 09:11:55 -07:00
Collin Jackson
4c9ddd3533 Merge pull request #1164 from collinjackson/revert_iterable 
Revert "MultiChildRenderObjectWrapper should take an Iterable instead of a List"
 2015-09-14 15:13:24 -07:00
Ian Hickson
90abaa02e4 Merge pull request #1161 from Hixie/transition 
Clean up animation-related files.
 2015-09-14 15:02:20 -07:00
Collin Jackson
b858a44685 Revert "MultiChildRenderObjectWrapper should take an Iterable instead of a List" 
This reverts commit 7592213df29066cd357eaa4fffe4a19ed3bae189.
 2015-09-14 14:59:04 -07:00
Chinmay Garde
5a1addb798 Merge pull request #1162 from chinmaygarde/master 
Only note a rasterizer eviction if an image was inflated for a key
 2015-09-14 14:58:37 -07:00
Hixie
0c1d1df080 Clean up animation-related files. 
Surface all the constructor arguments of AnimationTiming in all its subclasses.
Remove some pointless casts.
Fix some typos.
Put constructors first in class declarations.
Remove some blank lines where they just confused the structure of the code.
 2015-09-14 14:07:03 -07:00
Chinmay Garde
0651ab7e62 Merge pull request #1160 from chinmaygarde/master 
Update Skia revision
 2015-09-14 13:49:23 -07:00
Chinmay Garde
f79c8dfe9b Only note a rasterizer eviction if an image was inflated for a key 2015-09-14 13:35:29 -07:00