5036 Commits

Author SHA1 Message Date
Ian Hickson
4cc6c900ea Merge pull request #1657 from Hixie/debugging
Reduce latency of low-volume debugPrint output
2015-10-18 14:51:44 -07:00
Ian Hickson
ceba7f5c13 Merge pull request #1660 from Hixie/PositionedTransition
Enable Positioned to be animated.
2015-10-18 14:51:27 -07:00
Hixie
6c7fcefe11 Enable Positioned to be animated.
Add a AnimatedRelativeRectValue class for animating RelativeRects.

Add a PositionedTransition class for animating Positioned using
AnimatedRelativeRectValues.

Add a test for PositionedTransition.

Fix a math bug a RelativeRect found by the test.

Fix a logic bug in the two ParentDataWidget classes found by the test.
Specifically, they were marking the child dirty, rather than the parent.
The parentData is for the parent's layout, not the child's, so they have
to mark the parent dirty. (I didn't hoist this up to the superclass
because ParentData could be used for painting, hit testing,
accessibility, or any number of other things, and I didn't want to bake
in the assumption that it needed markNeedsLayout.)
2015-10-17 19:06:42 -07:00
Ian Hickson
110ed16e91 Merge pull request #1658 from Hixie/more-debugging
toString()ify more stuff
2015-10-17 18:49:29 -07:00
Hixie
33e6a76949 toString()ify more stuff
- truncate pixel values to 1dp since there's really no point being told
  the Size is 302.98732587287 by 648.28498579187.

- describe more Widgets so that debugDumpApp() is more useful.

- remove bufferValue from ProgressIndicator (cc @hansmuller) since it's
  not yet implemented.

- half-hearted toString() for ThemeData. There's no point making a
  complete one, since it would cause line-wrap even on big monitors in
  debugDumpApp dumps, and you can easily get the actual values from a
  debugging if that's the issue.

- flesh out BoxConstraints.toString() so that fully unconstrained and
  fully infinite constraints are called out explicitly. I experimented
  with adding even more special cases, e.g. calling out unconstrained
  widths with fixed heights, etc, but it made the output less readable.

- remove a redundant _updateVariable() in AnimatedContainer (cc
  @abarth).

- add more information to RenderView.toString().
2015-10-17 17:55:17 -07:00
Hixie
a5d69d7008 Reduce latency of low-volume debugPrint output
If we haven't printed anything for a second, then reset the count of how
much we've printed.

I also reduced the amount of data to ~16kb until we pause because I saw
some corruption even pausing 1 second every ~32kb. (Numbers are
approximate because we're counting UTF-16 characters and some of the
characters in the output are multiple bytes in UTF-8.)
2015-10-17 16:43:22 -07:00
Ian Hickson
b6de7cb119 Merge pull request #1653 from Hixie/debugging
Sundry debugging aids and fixes
2015-10-16 19:27:51 -07:00
Ian Hickson
b1dff9a09f Merge pull request #1652 from Hixie/relativeRect
RelativeRect
2015-10-16 17:06:12 -07:00
Hixie
c412c31646 RelativeRect
Introduce a class that can describe the metrics used in a Positioned
widget, to enable easier manipulation and storage of the values, e.g.
for animation purposes.
2015-10-16 17:01:39 -07:00
Hixie
a4acd46ba4 Sundry debugging aids and fixes
(These are all the debugging-related fixes and trivial typo fixes that I
extracted out of my heroes branch.)

Fix rendering.dart import order.

Introduce a debugLabel for Performances so that when you create a
performance, you can tag it so that if later you print it out, you can
figure out which performance it is.

Allow the progress of a PerformanceView to be determined (but not set).

Allow subclasses of PerformanceView that are constants to be created by
defining a constant constructor for PerformanceView.

Introduce a debugPrint() method that throttles its output. This is a
test to see if it resolves the problems people have been having with
debugDumpRenderTree() et al having their output corrupted on Android. It
turns out (according to some things I read On The Internets) that
Android only has a 64KB kernel buffer for its logs and and if you output
to it too fast, it'll drop data on the floor. If this does in fact
reliably resolve this problem, we should probably move the fix over to
C++ land (where "print" is implemented) so that any use of print is
handled (avoiding the interleaving problem we have now if you use both
debugPrint() and print()).

Fix a bug with the debugging code for "size". In the specific case of a
RenderBox having a parent that doesn't set parentUsesSize, then later
the parent setting parentUsesSize but the child having its layout
short-circuited (e.g. because the constraints didn't change), we didn't
update the _DebugSize object to know that now it's ok that the size be
used by the parent, and we'd assert.

Also, allow a _DebugSize to be used to set the size of yourself.
Previously you could only set your size from a regular Size or from your
child's _DebugSize.

Add more debugging information to various Widgets where it might be
helpful.

Make GlobalKey's toString() include the runtimeType so that when
subclassing it the new class doesn't claim to be a GlobalKey instance.

Include the Widget's key in the Element's description since we don't
include it in the detailed description normally (it's in the name part).

Fix a test that was returning null from a route.
2015-10-16 16:41:56 -07:00
Hans Muller
043224b6f9 Merge pull request #1651 from HansMuller/fix_scrollable_tabs
Fix scrollable tabs, add basic unit test
2015-10-16 15:49:22 -07:00
Collin Jackson
9a06592805 Merge pull request #1640 from collinjackson/stocks_app
test harness for stocks app on iOS
2015-10-16 15:34:45 -07:00
Hans Muller
58c929003e Fix scollable tabs, add basic unit test 2015-10-16 15:10:26 -07:00
Ian Hickson
8b7c93cdab Merge pull request #1650 from Hixie/version-update
Release process rev number updates for stage two
2015-10-16 14:45:15 -07:00
Hixie
f361fdcd91 Release process rev number updates for stage two 2015-10-16 14:44:02 -07:00
Ian Hickson
69b00538ea Merge pull request #1648 from Hixie/release
Rev sky_engine and sky_services.
2015-10-16 12:44:05 -07:00
Hixie
f235719020 Rev sky_engine and sky_services. 2015-10-16 11:23:58 -07:00
Hans Muller
3efa869233 Merge pull request #1647 from HansMuller/restore_overlay_geometry
Restored overlay_geometry example
2015-10-16 11:13:16 -07:00
Viktor Lidholt
4fffd3c9db Merge pull request #1645 from vlidholt/master
Adds teleporting methods for moving sprite kinematic bodies
2015-10-16 11:04:42 -07:00
Hans Muller
829d7ebb5d Restored overlay_geometry example 2015-10-16 11:00:12 -07:00
Viktor Lidholt
5af0631465 Adds teleporting methods for moving sprite kinematic physics bodies without assigning velocities 2015-10-16 10:19:25 -07:00
Hans Muller
196cbee987 Merge pull request #1644 from HansMuller/scrollbar_assert_failures
OMG I've been running with checking turned off.  Fixed scrollbar assertion failures
2015-10-16 10:18:58 -07:00
Viktor Lidholt
1cf32201f6 Correctly resets targets for kinematic sprite physics bodies 2015-10-16 10:18:35 -07:00
Hans Muller
068ab33911 OMG I've been running with checking turned off. Fixed scrollbar assertion failures. 2015-10-16 10:14:26 -07:00
Viktor Lidholt
a3644e03b4 Merge pull request #1642 from vlidholt/master
Animated sprite physics bodies now correctly transfers energy to dynamic bodies
2015-10-16 08:57:12 -07:00
Matt Perry
fbfec0be07 Merge pull request #1632 from mpcomplete/activity.mojom
Remove UpdateService from activity.mojom
2015-10-16 11:47:01 -04:00
Matt Perry
5cf97f8fbe Remove UpdateService from activity.mojom.
It was moved to update_service.mojom.
2015-10-16 11:14:14 -04:00
Adam Barth
38fc83d5a0 Merge pull request #1643 from abarth/fix_exports
Rationalize exports a bit more
2015-10-16 00:12:54 -07:00
Adam Barth
8d173616aa Rationalize exports a bit more
The goal is to follow the guidelines in
https://github.com/flutter/engine/blob/master/sky/specs/style-guide.md#packages

Fixes #1638
2015-10-16 00:09:00 -07:00
Ian Hickson
c16b8efb95 Merge pull request #1641 from flutter/Hixie-patch-1
Describe conventions around exporting APIs
2015-10-15 22:42:31 -07:00
krisgiesing
b0c02407cf Merge pull request #1633 from krisgiesing/event_exports
Export new InputEvent classes from appropriate places
2015-10-15 17:50:02 -07:00
Viktor Lidholt
477b231b63 Updates physics test 2015-10-15 17:08:51 -07:00
Viktor Lidholt
eff62325b2 Animated sprite physics bodies now correctly transfers energy to dynamic bodies 2015-10-15 17:01:47 -07:00
Ian Hickson
5d496d2d77 Describe conventions around exporting APIs
Fixes #1634.
2015-10-15 16:29:18 -07:00
Collin Jackson
bce1efd5e7 Build stocks app on iOS 2015-10-15 16:17:25 -07:00
Hans Muller
f453389625 Merge pull request #1637 from HansMuller/linear_gradient_assert
Revised LinearGradient ctor checking

It's OK to specify colors and not stops.

Fix the problem reported here: #1631

All of the arg checking is now in the ui.LinearGradient ctor which provides helpful error messages.
2015-10-15 15:49:41 -07:00
Hans Muller
251dd27500 Revised LinearGradient ctor checking.
It's OK to just specify the colors list.
2015-10-15 15:46:03 -07:00
Viktor Lidholt
8799c62549 Remember last position in sprite physics 2015-10-15 14:43:48 -07:00
Viktor Lidholt
28c0ea3f5f Merge pull request #1636 from vlidholt/master
Fixes SpriteBox to work better with native points
2015-10-15 14:06:10 -07:00
Viktor Lidholt
19ff6b5c5f Merge pull request #1629 from vlidholt/master
Improves sprite physics debug drawing
2015-10-15 13:47:34 -07:00
Viktor Lidholt
2d0ed2f04f Fixes SpriteBox to work better with native points 2015-10-15 13:46:24 -07:00
krisgiesing
fb6143da0f Merge pull request #1617 from krisgiesing/arena_sweep
Arena sweep
2015-10-15 13:08:34 -07:00
Jason Simmons
9ccb5fa917 Merge pull request #1610 from jason-simmons/slice_border_warning
Fix warnings seen when running skyanalyzer in strong mode
2015-10-15 12:59:28 -07:00
Ian Hickson
3a00fbbd77 Merge pull request #1630 from Hixie/debug
Improve debugging output
2015-10-15 11:31:20 -07:00
Hixie
8c24f976db Improve debugging output
Teach dumpRenderTree() to draw actual trees.
Make the TextStyle output terser so it doesn't overflow the output.
Make debugDumpApp() say what mode we're in (checked vs release).
Hide lifecycle state from release mode dumps (since it's checked-only state).
2015-10-15 11:23:23 -07:00
Jason Simmons
94fa673029 Fix warnings seen when running skyanalyzer in strong mode 2015-10-15 10:56:03 -07:00
Kris Giesing
c14ac38cb2 Export new InputEvent classes from appropriate places 2015-10-15 10:29:09 -07:00
Viktor Lidholt
daf7afa546 Improves sprite physics debug drawing 2015-10-15 10:20:26 -07:00
Viktor Lidholt
b75b186d2b Merge pull request #1623 from vlidholt/master
Fixes touch handling and refactors sprite physics
2015-10-15 09:01:20 -07:00
Adam Barth
0bc96df174 Fix TextDecoration.lineThrough
We had a typo in our CSS translation.
2015-10-14 21:30:00 -07:00