engine-flutter-autoroll
4bc7a44eb6
Roll Packages from 4c3bc496bed2 to 23d2d9c01366 (6 revisions) ( #140550 )
...
4c3bc496be...23d2d9c013flutter/packages#5737 )
2023-12-21 54558023+keyonghan@users.noreply.github.com Disable `presubmit: false` targets for recipes CQ (flutter/packages#5735 )
2023-12-21 47866232+chunhtai@users.noreply.github.com [go_router] Refactored RouteMatchList and imperative APIs (flutter/packages#5497 )
2023-12-21 54558023+keyonghan@users.noreply.github.com Add env_variables in ci.yaml (flutter/packages#5730 )
2023-12-21 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 2e9cb0aa71a3 to 78666c8dc57e (1 revision) (flutter/packages#5734 )
2023-12-21 engine-flutter-autoroll@skia.org Roll Flutter from da0cd69659c5 to 11def8eff455 (16 revisions) (flutter/packages#5732 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-22 19:02:40 +00:00
engine-flutter-autoroll
bba4c1f937
Roll Flutter Engine from 5448105a76f7 to 0476141a016f (1 revision) ( #140549 )
...
5448105a76...0476141a01skia-flutter-autoroll@skia.org Roll Dart SDK from 151b363886f9 to eec6568c209f (1 revision) (flutter/engine#49369 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-22 18:20:38 +00:00
Reid Baker
48ae5ff6f6
Use double quotes over single quotes in gradle build files ( #140512 )
...
Following https://developer.android.com/build/migrate-to-kotlin-dsl
2/n Use double quotes instead of single quotes.
Should be a no-op change. If you see a behavioral change please flag it.
2023-12-22 16:25:06 +00:00
engine-flutter-autoroll
ede594f881
Roll Flutter Engine from a8da67fed23b to 5448105a76f7 (1 revision) ( #140540 )
...
a8da67fed2...5448105a76skia-flutter-autoroll@skia.org Roll Dart SDK from 69423a5dd254 to 151b363886f9 (1 revision) (flutter/engine#49357 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-22 10:11:17 +00:00
engine-flutter-autoroll
6126e4b4a4
Roll Flutter Engine from 1ba8fc0765f9 to a8da67fed23b (1 revision) ( #140536 )
...
1ba8fc0765...a8da67fed2skia-flutter-autoroll@skia.org Roll Dart SDK from fe94d9b88531 to 69423a5dd254 (1 revision) (flutter/engine#49354 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-22 06:14:20 +00:00
engine-flutter-autoroll
8024c5e4d4
Roll Flutter Engine from 737e6f8ce85e to 1ba8fc0765f9 (4 revisions) ( #140531 )
...
737e6f8ce8...1ba8fc0765dnfield@google.com Fix GetImpellerContext for ShellTestPlatformViewGL (flutter/engine#49337 )
2023-12-21 flar@google.com [Impeller] Remove use of private Rect fields from PathBuilder (flutter/engine#49334 )
2023-12-21 flar@google.com [Impeller] Do not skip rendering when mask blur is zero (flutter/engine#49342 )
2023-12-21 737941+loic-sharma@users.noreply.github.com [Windows] Fix incorrect surface manager comment (flutter/engine#49335 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-22 02:09:25 +00:00
godofredoc
c73bffe747
Migrate verify_codesigned. ( #139328 )
...
This is part of the migration of adhoc tests to shard tests.
Bug: https://github.com/flutter/flutter/issues/139153
2023-12-22 01:46:11 +00:00
Yegor
c02ace6b48
[web] unskip canvaskit tests that pass now ( #140480 )
...
Unskip a few CanvasKit tests that pass now.
2023-12-22 01:02:12 +00:00
engine-flutter-autoroll
08e58bab92
Roll Flutter Engine from 1b1b2a12a597 to 737e6f8ce85e (5 revisions) ( #140527 )
...
1b1b2a12a5...737e6f8ce8skia-flutter-autoroll@skia.org Roll Dart SDK from bcf68d22f0fa to fe94d9b88531 (1 revision) (flutter/engine#49343 )
2023-12-21 1961493+harryterkelsen@users.noreply.github.com Reland "[web] Enforce onDrawFrame/onBeginFrame render rule" (flutter/engine#49336 )
2023-12-21 magder@google.com Turn on scenario app screenshots (flutter/engine#49066 )
2023-12-21 chris@bracken.jp Revert onrender change (flutter/engine#49333 )
2023-12-21 yjbanov@google.com [web] autofocus in new routes (flutter/engine#47727 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-22 00:07:42 +00:00
engine-flutter-autoroll
b417fb828b
Roll Flutter Engine from c70f0a495ace to 1b1b2a12a597 (32 revisions) ( #140519 )
...
Roll Flutter Engine from c70f0a495ace to 1b1b2a12a597 (32 revisions)
c70f0a495a...1b1b2a12a5skia-flutter-autoroll@skia.org Roll Dart SDK from 4a10533a4dc8 to bcf68d22f0fa (1 revision) (flutter/engine#49329 )
2023-12-21 skia-flutter-autoroll@skia.org Roll Dart SDK from 1d0c3ecd1349 to 4a10533a4dc8 (1 revision) (flutter/engine#49326 )
2023-12-21 flar@google.com Ensure sorted rects in ui.Canvas for legacy compatibility (flutter/engine#49309 )
2023-12-21 skia-flutter-autoroll@skia.org Roll Dart SDK from 63a452b45026 to 1d0c3ecd1349 (1 revision) (flutter/engine#49318 )
2023-12-21 dnfield@google.com [Impeller] Make IPLR files multi-platform (flutter/engine#49253 )
2023-12-21 ditman@gmail.com [web] Defer injection of platform views until needed. (flutter/engine#48960 )
2023-12-21 skia-flutter-autoroll@skia.org Roll Dart SDK from 1aef027ec953 to 63a452b45026 (2 revisions) (flutter/engine#49311 )
2023-12-21 skia-flutter-autoroll@skia.org Roll Skia from 29917d8c97ca to 4b16117e94b2 (4 revisions) (flutter/engine#49310 )
2023-12-21 737941+loic-sharma@users.noreply.github.com Reland "[Windows] Move to FlutterCompositor for rendering" (flutter/engine#49262 )
2023-12-21 30870216+gaaclarke@users.noreply.github.com Reland `[Impeller] new blur: refactored math and fixed expanded padding size` (flutter/engine#49302 )
2023-12-20 dkwingsmt@users.noreply.github.com Multiview pipeline Pt. 1: Skip illegal render calls (flutter/engine#49266 )
2023-12-20 barpac02@gmail.com SemanticsUpdateBuilder: make all args non-null (flutter/engine#49148 )
2023-12-20 30870216+gaaclarke@users.noreply.github.com [Impeller] fixed Rect::Contains (flutter/engine#49294 )
2023-12-20 skia-flutter-autoroll@skia.org Roll Dart SDK from 97c3b7e1885a to 1aef027ec953 (1 revision) (flutter/engine#49295 )
2023-12-20 30870216+gaaclarke@users.noreply.github.com Revert "[Impeller] new blur: refactored math and fixed expanded padding size" (flutter/engine#49298 )
2023-12-20 30870216+gaaclarke@users.noreply.github.com [Impeller] new blur: refactored math and fixed expanded padding size (flutter/engine#49206 )
2023-12-20 dkwingsmt@users.noreply.github.com Multi-view pointer event (flutter/engine#46213 )
2023-12-20 1961493+harryterkelsen@users.noreply.github.com [web:multiview] Only call `Renderer.clearFragmentProgramCache` on hot restart (flutter/engine#48758 )
2023-12-20 skia-flutter-autoroll@skia.org Roll Skia from 9cb1bb1164ea to 29917d8c97ca (1 revision) (flutter/engine#49289 )
2023-12-20 bdero@google.com [Impeller] Add interactive Blur+Clip AiksTest. (flutter/engine#49283 )
2023-12-20 sergiy.dubovik@supercell.com [macos] FlutterKeyboardManager memory leak fix (flutter/engine#48824 )
2023-12-20 zanderso@users.noreply.github.com Don't guard Windows arm64 Dart SDK download on the release candidate flag (flutter/engine#49244 )
2023-12-20 15619084+vashworth@users.noreply.github.com Fix testAppExtensionLaunching for Xcode 15/iOS 17 (flutter/engine#49242 )
2023-12-20 skia-flutter-autoroll@skia.org Roll Skia from 8060d6b36066 to 9cb1bb1164ea (2 revisions) (flutter/engine#49288 )
2023-12-20 skia-flutter-autoroll@skia.org Roll Dart SDK from ed415d966d8a to 97c3b7e1885a (1 revision) (flutter/engine#49287 )
2023-12-20 skia-flutter-autoroll@skia.org Roll Skia from d0f09ad481f7 to 8060d6b36066 (1 revision) (flutter/engine#49285 )
2023-12-20 kevinjchisholm@gmail.com [release] Update release config (flutter/engine#49254 )
2023-12-20 skia-flutter-autoroll@skia.org Roll Dart SDK from 1732c4c92ccd to ed415d966d8a (1 revision) (flutter/engine#49274 )
2023-12-20 skia-flutter-autoroll@skia.org Roll Dart SDK from 4c59838945d9 to 1732c4c92ccd (1 revision) (flutter/engine#49269 )
2023-12-20 goderbauer@google.com Sync lints with flutter/flutter (flutter/engine#49192 )
2023-12-19 1961493+harryterkelsen@users.noreply.github.com [web] Enforce onDrawFrame/onBeginFrame render rule (flutter/engine#49214 )
2023-12-19 barpac02@gmail.com [Docs] Add more info about running tests on iOS (flutter/engine#48859 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
...
2023-12-21 22:55:07 +00:00
flutter-pub-roller-bot
9c2a756009
Roll pub packages ( #140525 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2023-12-21 22:13:24 +00:00
Victoria Ashworth
2da1ff2d93
Run mac staging tests with Xcode 15 ( #140518 )
...
Run macOS staging tests with Xcode 15 and macOS 13. Also, cleanup some comments.
2023-12-21 22:01:14 +00:00
Ian Hickson
62f1594908
Make tests more resilient to Skia gold failures and refactor flutter_goldens for extensive technical debt removal ( #140101 )
...
Originally landed in https://github.com/flutter/flutter/pull/139549
Originally reverted in https://github.com/flutter/flutter/pull/140085
- Remove all use of global variables.
- Always pass in all dependencies, only create them in main or in tests.
- Pass in the "print" primitive.
- Make all network traffic retry (except when run locally, when it just auto-passes).
- Enable tests to be run in random order.
- Better error messages
2023-12-21 21:35:07 +00:00
Andrew Kolos
9e104eb7c8
Fix flavor conditional asset bundling for macos ( #140433 )
...
Fixes https://github.com/flutter/flutter/issues/140430
Fixes https://github.com/flutter/flutter/issues/140432 while we are at it
2023-12-21 20:30:21 +00:00
Gray Mackall
a3e0fa56a3
Enable android_preview_tool_integration_tests check ( #140470 )
...
Enables the check that was added in https://github.com/flutter/flutter/pull/131901 .
Has been passing since https://github.com/flutter/flutter/pull/140099 (30 runs). Not sure what the normal number of successful runs we wait for is before enabling, let me know if we should wait for more data.
2023-12-21 19:20:43 +00:00
Christopher Fujino
674fbd26bc
[flutter_tools] Ensure flutter daemon clients can detect preview device ( #140112 )
...
Part of https://github.com/flutter/flutter/issues/130277
2023-12-21 19:01:16 +00:00
Non Vachara
90badf7050
Add send_text_input_action case to deserialization_factory to allow sendTextInputAction usages through flutter_driver. ( #139197 )
...
**As a follow up to https://github.com/flutter/flutter/pull/131776 .**
**Summary:**
Previously in https://github.com/flutter/flutter/pull/106561 , SendTextInputAction was added to Flutter Driver.
But it still cannot be used from flutter_driver tests. This PR intends to resolve that issue.
**Issue:**
An `DriverError: Unsupported command kind send_text_input_action` would be thrown from `flutter_driver/lib/src/common/deserialization_factory.dart` when a call to `driver.sendTextInputAction(TextInputAction.done);` was made despite the method `sendTextInputAction` is available for use since https://github.com/flutter/flutter/pull/106561 .
Previous works has been done in https://github.com/flutter/flutter/pull/131776 , I merely added tests.
Best regards.
2023-12-21 17:48:16 +00:00
auto-submit[bot]
cb50d4a804
Reverts "[web] Re-enable test now that source of flakiness is fixed" ( #140515 )
...
Reverts flutter/flutter#140462
Initiated by: cbracken
This change reverts the following previous change:
Original Description:
The test was flaky before due to overflowing GPU memory during the test. The memory leak was fixed here https://github.com/flutter/engine/pull/49214
Fixes https://github.com/flutter/flutter/issues/137669
As a side effect of the fix, this test also runs much faster, from about 3 minutes on my Macbook down to about 25 seconds.
2023-12-21 17:46:16 +00:00
Gustl22
f5ac225c8d
Reland: "Fix how Gradle resolves Android plugin" ( #137115 )
...
Relands #97823
When the tool migrated to `.flutter-plugins-dependencies`, the Gradle plugin was never changed.
Until now, the plugin had the heuristic that a plugin with a `android/build.gradle` file supported the Android platform.
Also applies schema of `getPluginDependencies` to `getPluginList` which uses a `List` of Object instead of `Properties`.
Fixes #97729
Cause of the error: 5f105a6ca7/packages/flutter_tools/gradle/flutter.gradle (L421C25-L421C25)Fixes #98048
The deprecated line `include ":$name"` in `settings.gradle` (pluginEach) in old projects causes the `project.rootProject.findProject` to also find the plugin "project", so it is not failing on the `afterEvaluate` method. But the plugin shouldn't be included in the first place as it fails with `Could not find method implementation() for arguments` error in special cases.
Related to #48918 , see [_writeFlutterPluginsListLegacy](27bc1cf61a/packages/flutter_tools/lib/src/flutter_plugins.dart (L248)
2023-12-21 16:55:04 +00:00
engine-flutter-autoroll
430254e13b
Roll Packages from dc5b267f3cd1 to 4c3bc496bed2 (1 revision) ( #140511 )
...
dc5b267f3c...4c3bc496be15619084+vashworth@users.noreply.github.com Remove workarounds for `check_podspecs` needed for older version of Cocoapods (flutter/packages#5724 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-21 15:44:08 +00:00
Michael Thomsen
11def8eff4
Update README.md ( #140382 )
...
Update the "fast results" subsection of readme with recent developments.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
---------
Co-authored-by: Parker Lougheed <parlough@gmail.com>
2023-12-21 13:03:09 +01:00
Jim Graham
8407dd2d0e
Revert "Integrate testWidgets with leak tracking. ( #138057 )" ( #140502 )
...
The PR is breaking the `flutter_test_performance` test and making the
tree red.
2023-12-21 12:44:58 +01:00
Polina Cherkasova
d746007fcd
Integrate testWidgets with leak tracking. ( #138057 )
...
Contributes to: https://github.com/flutter/flutter/issues/135856
TODO:
2023-12-21 00:19:59 +00:00
Qun Cheng
c0acd8c45f
Fix import pattern ( #140425 )
...
This PR is just to fix the import pattern to follow the convention.
2023-12-21 00:18:09 +00:00
godofredoc
cf3760bce0
Update job permissions ( #140476 )
...
Updates to use contents: write and pull-requests: write.
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-12-20 14:59:24 -08:00
flutter-pub-roller-bot
2d75f76b44
Roll pub packages ( #140472 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2023-12-20 22:57:21 +00:00
Michael Goderbauer
68e346e41c
Remove outdated ignores from tool ( #140467 )
...
These were not ignoring anything (anymore).
2023-12-20 22:14:32 +00:00
Michael Goderbauer
c4fda23393
Remove outdated ignores from framework ( #140465 )
...
These were not ignoring anything (anymore).
2023-12-20 22:05:29 +00:00
LongCatIsLooong
e2e8bcb1bc
Reland find.textRange.ofSubstring changes ( #140469 )
...
Extracted from https://github.com/flutter/flutter/pull/139717 as-is. Landing this change first so we can avoid doing a g3fix.
2023-12-20 22:00:55 +00:00
Reid Baker
d6e435a7ac
Part 1/n migration steps for kotlin migration ( #140452 )
...
Following https://developer.android.com/build/migrate-to-kotlin-dsl
1/n Add parentheses to method calls
Should be a no-op change. If you see a behavioral change please flag it.
2023-12-20 20:40:17 +00:00
auto-submit[bot]
9003f13803
Reverts "Make TextSpan hit testing precise." ( #140468 )
...
Reverts flutter/flutter#139717
Initiated by: LongCatIsLooong
This change reverts the following previous change:
Original Description:
Fixes https://github.com/flutter/flutter/issues/131435 , #104594 , #43400
Needs https://github.com/flutter/engine/pull/48774 (to fix the web test failure).
Currently the method we use for text span hit testing `TextPainter.getPositionForOffset` always returns the closest `TextPosition`, even when the given offset is far away from the text.
The new TextPaintes method tells you the layout bounds (`width = letterspacing / 2 + x_advance + letterspacing / 2`, `height = font ascent + font descent`) of a character, the PR changes the hit testing implementation such that a TextSpan is only considered hit if the point-down event landed in one of it's character's layout bounds.
Potential issues:
1. In theory since the text is baseline aligned, we should use the max ascent and max descent of each character to calculate the height of the text span's hit-test region, in case some characters in the span have to fall back to a different font, but that will be slower and it typically doesn't make a huge difference.
This is a breaking change. It also introduces a new finder and a new method `WidgetTester.tapOnText`: `await tester.tapOnText('string to match')` for ease of migration.
2023-12-20 19:32:10 +00:00
Harry Terkelsen
11bfb3c46a
[web] Re-enable test now that source of flakiness is fixed ( #140462 )
...
The test was flaky before due to overflowing GPU memory during the test.
The memory leak was fixed here
https://github.com/flutter/engine/pull/49214
Fixes https://github.com/flutter/flutter/issues/137669
As a side effect of the fix, this test also runs much faster, from about
3 minutes on my Macbook down to about 25 seconds.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-12-20 11:11:56 -08:00
Chris Bracken
7b0bfa8c61
Eliminate Cirrus build status badge ( #140461 )
...
We have no tasks running on Cirrus any more. This eliminates the "Build
Status - Cirrus" badge/link as well as the "Build status" link
reference, which was unused.
@CaseyHillers has filed a bug to add a Cocoon endpoint to replace it:
https://github.com/flutter/flutter/issues/140460
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-12-20 10:58:32 -08:00
Zachary Anderson
76c8e7387b
Move tests shifted to Pixel 7 from staging to prod ( #140438 )
2023-12-20 18:57:40 +00:00
engine-flutter-autoroll
0dc3b072c1
Roll Packages from be52ac86bb4f to dc5b267f3cd1 (5 revisions) ( #140450 )
...
be52ac86bb...dc5b267f3cengine-flutter-autoroll@skia.org Roll Flutter from 0eb788134051 to da0cd69659c5 (15 revisions) (flutter/packages#5729 )
2023-12-20 49699333+dependabot[bot]@users.noreply.github.com [webview]: Bump androidx.annotation:annotation from 1.7.0 to 1.7.1 in /packages/webview_flutter/webview_flutter_android/android (flutter/packages#5702 )
2023-12-19 jsharp83@gmail.com [webview_flutter] Implement platform interface for JavaScript dialog (flutter/packages#5670 )
2023-12-19 JeroenWeener@users.noreply.github.com [webview_flutter] Support for handling basic authentication requests (iOS) (flutter/packages#5455 )
2023-12-19 engine-flutter-autoroll@skia.org Roll Flutter from cdc83e5ebae4 to 0eb788134051 (17 revisions) (flutter/packages#5722 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-20 17:33:18 +00:00
Bruno Leroux
0d90014bae
_TabBarViewState should not recreate page controller ( #135500 )
...
## Description
This PR replaces the unconditional instantiation of `PageController` in `_TabBarViewState.didChangeDependencies` as suggested in https://github.com/flutter/flutter/pull/134091#discussion_r1319177744 .
## Related Issue
Fixes https://github.com/flutter/flutter/issues/134253 .
## Tests
Adds 1 test.
2023-12-20 17:04:29 +00:00
Gustl22
da0cd69659
Revert automated changes made to deprecated settings.gradle (plugins.each) ( #140037 )
...
Restore testing deprecated settings.gradle (plugins.each).
Updated presumably by accident in #83067
Split from #137115
See also https://github.com/flutter/flutter/pull/137115#issuecomment-1781909865
2023-12-20 15:45:08 +00:00
Xilai Zhang
62d699961f
[github actions] change minimal example workflow to be manually dispatched ( #140435 )
...
This would allow easier testing of the minimal example.
Might need Github Admin power to trigger the manual dispatches.
2023-12-20 04:59:27 +00:00
LongCatIsLooong
ea5b97286e
Make TextSpan hit testing precise. ( #139717 )
...
Fixes https://github.com/flutter/flutter/issues/131435 , #104594 , #43400
Needs https://github.com/flutter/engine/pull/48774 (to fix the web test failure).
Currently the method we use for text span hit testing `TextPainter.getPositionForOffset` always returns the closest `TextPosition`, even when the given offset is far away from the text.
The new TextPaintes method tells you the layout bounds (`width = letterspacing / 2 + x_advance + letterspacing / 2`, `height = font ascent + font descent`) of a character, the PR changes the hit testing implementation such that a TextSpan is only considered hit if the point-down event landed in one of it's character's layout bounds.
Potential issues:
1. In theory since the text is baseline aligned, we should use the max ascent and max descent of each character to calculate the height of the text span's hit-test region, in case some characters in the span have to fall back to a different font, but that will be slower and it typically doesn't make a huge difference.
This is a breaking change. It also introduces a new finder and a new method `WidgetTester.tapOnText`: `await tester.tapOnText('string to match')` for ease of migration.
2023-12-20 03:23:29 +00:00
Xilai Zhang
e86b825819
[github actions] add minimal workflow to test token ( #140363 )
...
Add a workflow that simply:
1. checkout repo
2. write a file
3. create a PR
This is used to verify the permissions and validity of the github token we use to create PR.
context: https://chat.google.com/room/AAAAc_4rqiI/Ck593Sg7mvs
If we think the triggering condition is complicated, I can also change this workflow to be manual dispatch, to make it truly minimal.
2023-12-20 01:18:07 +00:00
engine-flutter-autoroll
18db55b4e5
Roll Flutter Engine from 5279873a8635 to c70f0a495ace (2 revisions) ( #140431 )
...
5279873a86...c70f0a495askia-flutter-autoroll@skia.org Roll Skia from 48f959a857da to d0f09ad481f7 (3 revisions) (flutter/engine#49264 )
2023-12-19 dkwingsmt@users.noreply.github.com Revert "Reland 2: Multiview Pipeline (#47239 )" (flutter/engine#49238 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-20 00:55:24 +00:00
engine-flutter-autoroll
0ae9260111
Roll Flutter Engine from df1593e96a6b to 5279873a8635 (2 revisions) ( #140428 )
...
df1593e96a...5279873a86skia-flutter-autoroll@skia.org Roll Dart SDK from e8cdc554c598 to 4c59838945d9 (2 revisions) (flutter/engine#49261 )
2023-12-19 flar@google.com Make sure run_tests.py runs dart tests on Skia (flutter/engine#49260 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-20 00:16:15 +00:00
Christopher Fujino
ef1227f05d
[flutter_tools] handle FileSystemException trying to delete temp directory from core_devices.dart ( #140415 )
...
Fixes https://github.com/flutter/flutter/issues/140416 , the top crasher on stable/3.16.4
2023-12-20 00:08:54 +00:00
Zachary Anderson
ea6017ded8
Move hybrid_android_views_integration_test back to Moto G4 ( #140421 )
...
Related https://github.com/flutter/flutter/issues/140420
2023-12-19 23:44:10 +00:00
engine-flutter-autoroll
8316e8512f
Roll Flutter Engine from 3b156c8ce9bd to df1593e96a6b (2 revisions) ( #140422 )
...
3b156c8ce9...df1593e96azanderso@users.noreply.github.com Rolls clang to 725656bdd885483c39f482a01ea25d67acf39c46 (flutter/engine#49248 )
2023-12-19 aam@google.com Roll dart to 3.3.0-242.0.dev (flutter/engine#49239 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-19 23:36:20 +00:00
Fedor Blagodyr
2bb19a9501
Added onEnd callback into AnimatedSize ( #139859 )
...
close #106439
2023-12-19 22:59:46 +00:00
engine-flutter-autoroll
5a5683ddd7
Roll Flutter Engine from 3f45f9db4471 to 3b156c8ce9bd (1 revision) ( #140413 )
...
3f45f9db44...3b156c8ce9skia-flutter-autoroll@skia.org Roll Skia from df1a7ccbdc97 to 48f959a857da (1 revision) (flutter/engine#49255 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-19 22:37:56 +00:00
engine-flutter-autoroll
1fd5d87e54
Roll Flutter Engine from 187334c39b44 to 3f45f9db4471 (3 revisions) ( #140412 )
...
187334c39b...3f45f9db44skia-flutter-autoroll@skia.org Roll Skia from 541f16af8b3e to df1a7ccbdc97 (3 revisions) (flutter/engine#49250 )
2023-12-19 skia-flutter-autoroll@skia.org Roll Skia from 0d39fb28b32d to 541f16af8b3e (1 revision) (flutter/engine#49246 )
2023-12-19 john@johnmccutchan.com Use new SurfaceProducer external texture class for rendering platform views (flutter/engine#49201 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-19 21:54:13 +00:00
Victoria Ashworth
6981fe6fd3
Remove workarounds for plugin_lint_mac needed for older version of Cocoapods ( #140395 )
...
CI has been updated to Cocoapods 1.13, which fixes previous issues with the `plugin_lint_mac` test. Remove workarounds added previously.
Fixes https://github.com/flutter/flutter/issues/125812 .
See also https://github.com/flutter/flutter/issues/133584 .
2023-12-19 20:19:52 +00:00
engine-flutter-autoroll
b14d7452ef
Roll Flutter Engine from b87a782ce3a3 to 187334c39b44 (2 revisions) ( #140398 )
...
b87a782ce3...187334c39bskia-flutter-autoroll@skia.org Roll Skia from 22dad95c218f to 0d39fb28b32d (2 revisions) (flutter/engine#49241 )
2023-12-19 skia-flutter-autoroll@skia.org Roll Skia from 6496c9c5866a to 22dad95c218f (4 revisions) (flutter/engine#49237 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-19 19:26:05 +00:00
