This is partial revert of Iced1349e3ca750821d8882c551551f65bb569794.
Due to sorting of target family vectors, the font family order from XML
settings file is broken. Making unique operation stable doesn't fix the
issue completely since some font families are appended for the fallback
which also breaks the original order.
By this change, itemization becomes 3x slower than before if variation
selector is appended.
Bug: 29585939
Change-Id: I7c1a8a57f04111a30cd41a5cd5bec25fcfb3972e
Skia is moving to returning smart pointers from its factory methods.
This updates uses of SkTypeface::CreateXXX to SkTypeface::MakeXXX and
generally updates use of SkTypeface to sk_sp. This will allow for the
removal of the SK_SUPPORT_LEGACY_TYPEFACE_PTR define.
Change-Id: If3e600c6cb86080576667bc77d427da4f6560afa
Unicode recommends that the zwj sequences should be emoji presentation
even if they don't have the proper U+FE0F. Thus always lookup the glyph
for the code point before and after zwj as if they have a U+FE0F
variation selector.
Bug: 30056627
Change-Id: I03958a92337eaba4a8dd9c5be824b2665aa4a103
FEMALE SIGN(U+2640), MALE SIGN(U+2642), StAFF OF AESCULAPIUS(U+2695)
will be used as the ZWJ sequenced in gender balanced emoji sequence.
To be in the same run with ZWJ, mark these emoji as sticky chracters.
With this fix, Female police officer sequence will be shown correctly
regardless of VS16.
Bug: 30026374
Change-Id: I503fc061eaa943d45208bb69e885151610c430ce
Unicode recommends that the zwj sequences should be emoji presentation
even if they don't have the proper U+FE0F. Thus always lookup the glyph
for the code point before and after zwj as if they have a U+FE0F
variation selector.
Bug: 30056627
Change-Id: I03958a92337eaba4a8dd9c5be824b2665aa4a103
FEMALE SIGN(U+2640), MALE SIGN(U+2642), StAFF OF AESCULAPIUS(U+2695)
will be used as the ZWJ sequenced in gender balanced emoji sequence.
To be in the same run with ZWJ, mark these emoji as sticky chracters.
With this fix, Female police officer sequence will be shown correctly
regardless of VS16.
Bug: 30026374
Change-Id: I503fc061eaa943d45208bb69e885151610c430ce
This CL introduces performance tests for FontCollection.
To support TTC file in /system/fonts, this CL also extends FontTestUtils
Bug:29142734
Change-Id: I9d8ad24ca55f61031b85623ab7c26234239e4f41
This CL introduces performance tests for following three modules:
- Hyphenator
- WordBreaker
- GraphemeBreak
During using UnicodeUtils, need to decouple it from gtest since
perftest doesn't have gtest dependencies.
Bug:29142734
Change-Id: I700c662fa7d0a52f19d8e93150ad1a85dc28769f
This fixes following three memory leaks in test utilities.
There is no problem in production code and this CL doesn't affect
any production behaviors.
- SkTypeface leaks due to forget calling SkSafeUnref in dtor.
- MinikinFontForTest leaks during constructing FontCollection.
- FontCollection leaks due to unnecessary AddRef.
Change-Id: I22e1e0307f1b2499296acb1aacc3ef66076a36e9
Here is a new policy of the namespace of minikin.
- All components should be in minikin namespace.
- All tests are also in minikin namespace and no anonymous namespace.
Bug: 29233740
Change-Id: I71a8a35049bb8d624f7a78797231e90fed1e2b8c
To add perftests and reuse some utility classes, reconstruct
test directory structure.
- Move unit tests from minikin/tests to minikin/tests/unittests
- Extract utilitiy classes to minikin/tests/utils which will be
used by perftests eventually.
Change-Id: I5026b177934e72ae67d362ee888302037da2f808
am: b4bbae3202
* commit 'b4bbae320244d949d1f7766916919cbb3a6e72f3':
Do not break after Myanmar viramas
Change-Id: I69972aed4fe1c1b956c0b65af18e1a4f1c739bf4
am: 00de2cc363
* commit '00de2cc3631df7ee3d755956bbf4ec6812d5517f':
Do not break after Myanmar viramas
Change-Id: I2e240fab84a49c73165056ee5ff18dbfca0faeec
am: 74b56175e5
* commit '74b56175e5d41c1c1dc992208842b5576973d452':
Do not break after Myanmar viramas
Change-Id: I13297120c3c3789c03b860c9e72b3a04922ab9fa
am: 74b56175e5
* commit '74b56175e5d41c1c1dc992208842b5576973d452':
Do not break after Myanmar viramas
Change-Id: Idb9303889ac87853a730cdb25fba7faaaf352b93
This is to work around a bug in ICU's line breaker, which thinks
there is a valid line break between a Myanmar kinzi and a consonant.
See http://bugs.icu-project.org/trac/ticket/12561 for the ICU bug.
Bug: 28964845
Change-Id: I076ac15077e5627cbccf6732900bcc60d8596dda
This addresses the following cppcheck reports:
[frameworks/minikin/app/HyphTool.cpp:30]: (error) Resource leak: f
[frameworks/minikin/app/HyphTool.cpp:32]: (error) Resource leak: f
Change-Id: I5113e0a7268bd3a45bf1498fd023042d9dfe2b87
am: 8010ad4
* commit '8010ad473b88233f2fcacd869ac22cb775e60228':
Do not break before and after ZWJ.
Change-Id: I5cdc475d6b525aac29b8433e675d2ad2feb68722
am: 3bee494
* commit '3bee494eead989500c38d98f7f863986e95e25e0':
Do not break before and after ZWJ.
Change-Id: If1fe6c6192aae09bab68a00bc94aba3e768dd445
am: 77f4883
* commit '77f488345316fba46c271fc04bea470819ae1712':
Do not break before and after ZWJ.
Change-Id: Ic476d9048b44b84c69fd185b76108c961d8e8545
am: 77f4883
* commit '77f488345316fba46c271fc04bea470819ae1712':
Do not break before and after ZWJ.
Change-Id: I00a0e31c19dd5b2fbe2ffb389bec4001dec5d6c1
