chunhtai
4763be745d
Can traverse if current focused node skips traversal ( #130812 )
...
Currently if the focus is on a focusnode that `skipTraversal = true`, the tab won't be able to traverse focus out of the node.
this pr fixes it
2023-07-20 01:01:01 +00:00
Ian Hickson
9c8ee4fab6
Document that you can't change initialRoute usefully ( #130450 )
...
Fixes https://github.com/flutter/flutter/issues/12454
2023-07-20 00:41:51 +00:00
engine-flutter-autoroll
28dfd836e2
Roll Flutter Engine from 7671e2f2a9fc to eff70f7287f9 (3 revisions) ( #130953 )
...
7671e2f2a9...eff70f7287skia-flutter-autoroll@skia.org Roll Dart SDK from 936824d49aa7 to 677bbf64d4d7 (1 revision) (flutter/engine#43833 )
2023-07-19 flar@google.com Reland "Add non-rendering operation culling to DisplayListBuilder" (#41463 ) (flutter/engine#43831 )
2023-07-19 skia-flutter-autoroll@skia.org Roll Skia from bf75ae2f6eec to 8413c82dea43 (1 revision) (flutter/engine#43832 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-20 00:29:23 +00:00
engine-flutter-autoroll
1c569e9c8d
Roll Flutter Engine from 938140a974b0 to 7671e2f2a9fc (3 revisions) ( #130948 )
...
938140a974...7671e2f2a9skia-flutter-autoroll@skia.org Roll Skia from b1d6eab1f590 to bf75ae2f6eec (2 revisions) (flutter/engine#43829 )
2023-07-19 skia-flutter-autoroll@skia.org Roll ANGLE from 4dcaad2a894d to 4515b270772e (2 revisions) (flutter/engine#43830 )
2023-07-19 737941+loic-sharma@users.noreply.github.com Add the 'affects: desktop' label to labeler.yml (flutter/engine#43827 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-19 23:42:30 +00:00
engine-flutter-autoroll
76017e269d
Roll Flutter Engine from 0af285219809 to 938140a974b0 (1 revision) ( #130943 )
...
0af2852198...938140a974skia-flutter-autoroll@skia.org Roll Skia from 30d458aea0b9 to b1d6eab1f590 (2 revisions) (flutter/engine#43826 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-19 22:53:57 +00:00
Ian Hickson
10f464895d
Add docs to Route.maintainState ( #130638 )
...
Fixes https://github.com/flutter/flutter/issues/44836
2023-07-19 22:53:54 +00:00
dependabot[bot]
910e87eb73
Bump github/codeql-action from 2.20.4 to 2.21.0 ( #130941 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 2.20.4 to 2.21.0.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/github/codeql-action/blob/main/CHANGELOG.md ">github/codeql-action's changelog</a>.</em></p>
<blockquote>
<h1>CodeQL Action Changelog</h1>
<p>See the <a href="https://github.com/github/codeql-action/releases ">releases page</a> for the relevant changes to the CodeQL CLI and language packs.</p>
<h2>[UNRELEASED]</h2>
<p>No user facing changes.</p>
<h2>2.21.0 - 19 Jul 2023</h2>
<ul>
<li>CodeQL Action now requires CodeQL CLI 2.9.4 or later. For more information, see the corresponding changelog entry for CodeQL Action version 2.20.4. <a href="https://redirect.github.com/github/codeql-action/pull/1724 ">#1724</a></li>
</ul>
<h2>2.20.4 - 14 Jul 2023</h2>
<ul>
<li>This is the last release of the Action that supports CodeQL CLI versions 2.8.5 to 2.9.3. These versions of the CodeQL CLI were deprecated on June 20, 2023 alongside GitHub Enterprise Server 3.5 and will not be supported by the next release of the CodeQL Action (2.21.0).
<ul>
<li>If you are using one of these versions, please update to CodeQL CLI version 2.9.4 or later. For instance, if you have specified a custom version of the CLI using the 'tools' input to the 'init' Action, you can remove this input to use the default version.</li>
<li>Alternatively, if you want to continue using a version of the CodeQL CLI between 2.8.5 and 2.9.3, you can replace 'github/codeql-action/<em><a href="https://github.com/v2 "><code>@âv2</code></a>' by 'github/codeql-action/</em><a href="https://github.com/v2 "><code>@âv2</code></a>.20.4' in your code scanning workflow to ensure you continue using this version of the CodeQL Action.</li>
</ul>
</li>
<li>We are rolling out a feature in July 2023 that will slightly reduce the default amount of RAM used for query execution, in proportion to the runner's total memory. This will help to avoid out-of-memory failures on larger runners. <a href="https://redirect.github.com/github/codeql-action/pull/1760 ">#1760</a></li>
<li>Update default CodeQL bundle version to 2.14.0. <a href="https://redirect.github.com/github/codeql-action/pull/1762 ">#1762</a></li>
</ul>
<h2>2.20.3 - 06 Jul 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.13.5. <a href="https://redirect.github.com/github/codeql-action/pull/1743 ">#1743</a></li>
</ul>
<h2>2.20.2 - 03 Jul 2023</h2>
<p>No user facing changes.</p>
<h2>2.20.1 - 21 Jun 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.13.4. <a href="https://redirect.github.com/github/codeql-action/pull/1721 ">#1721</a></li>
<li>Experimental: add a new <code>resolve-environment</code> action which attempts to infer a configuration for the build environment that is required to build a given project. Do not use this in production as it is part of an internal experiment and subject to change at any time.</li>
</ul>
<h2>2.20.0 - 13 Jun 2023</h2>
<ul>
<li>Bump the version of the Action to 2.20.0. This ensures that users who received a Dependabot upgrade to <a href="cdcdbb5797https://redirect.github.com/github/codeql-action/pull/1729 ">#1729</a></li>
</ul>
<h2>2.3.6 - 01 Jun 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.13.3. <a href="https://redirect.github.com/github/codeql-action/pull/1698 ">#1698</a></li>
</ul>
<h2>2.3.5 - 25 May 2023</h2>
<ul>
<li>Allow invalid URIs to be used as values to <code>artifactLocation.uri</code> properties. This reverses a change from <a href="https://redirect.github.com/github/codeql-action/pull/1668 ">#1668</a> that inadvertently led to stricter validation of some URI values. <a href="https://redirect.github.com/github/codeql-action/pull/1705 ">#1705</a></li>
<li>Gracefully handle invalid URIs when fingerprinting. <a href="https://redirect.github.com/github/codeql-action/pull/1694 ">#1694</a></li>
</ul>
<h2>2.3.4 - 24 May 2023</h2>
<ul>
<li>Updated the SARIF 2.1.0 JSON schema file to the latest from <a href="123e95847b/Schemata/sarif-schema-2.1.0.jsonhttps://redirect.github.com/github/codeql-action/pull/1668 ">#1668</a></li>
<li>We are rolling out a feature in May 2023 that will disable Python dependency installation for new users of the CodeQL Action. This improves the speed of analysis while having only a very minor impact on results. <a href="https://redirect.github.com/github/codeql-action/pull/1676 ">#1676</a></li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="1813ca74c3https://redirect.github.com/github/codeql-action/issues/1791 ">#1791</a> from github/update-v2.21.0-6ae46f7a9</li>
<li><a href="68435408766ae46f7a92https://redirect.github.com/github/codeql-action/issues/1790 ">#1790</a> from github/henrymercer/aborted-user-error</li>
<li><a href="0cae69e062d2ed0a05b6https://redirect.github.com/github/codeql-action/issues/1786 ">#1786</a> from github/dependabot/npm_and_yarn/npm-0a410f26d2</li>
<li><a href="651d09131ahttps://redirect.github.com/github/codeql-action/issues/1788 ">#1788</a> from github/henrymercer/fix-feature-flag-usage</li>
<li><a href="e0f0892f8327d3b2f857da4e0a06c0e266801e21489225d82a...1813ca74c3https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github/codeql-action&package-manager=github_actions&previous-version=2.20.4&new-version=2.21.0 )](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2023-07-19 22:51:25 +00:00
Greg Spencer
258382c594
Add menu dismiss localization ( #128613 )
...
## Description
Modifies the semantic label for popup and context menus to be "Dismiss menu" instead of just "Dismiss".
## Related Issues
- Fixes https://github.com/flutter/flutter/issues/118994
## Tests
- Updated tests
2023-07-19 22:48:40 +00:00
Ian Hickson
07cdf37ca3
Add implementation advice to debugTypicalAncestorWidgetClass ( #130530 )
...
Fixes https://github.com/flutter/flutter/issues/56500
2023-07-19 22:47:43 +00:00
engine-flutter-autoroll
6cabe73623
Roll Flutter Engine from 6ea54eee0592 to 0af285219809 (4 revisions) ( #130939 )
...
6ea54eee05...0af2852198skia-flutter-autoroll@skia.org Roll Skia from 650c980daa72 to 30d458aea0b9 (1 revision) (flutter/engine#43825 )
2023-07-19 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from Iqf3gYJ8Vkq8k8l3O... to 7kGBjmX-zBXcg1svE... (flutter/engine#43823 )
2023-07-19 flar@google.com fix handling of clipped rendering inside a layer that applies a filter (flutter/engine#43787 )
2023-07-19 skia-flutter-autoroll@skia.org Roll Skia from 8d19d04472e1 to 650c980daa72 (6 revisions) (flutter/engine#43821 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from Iqf3gYJ8Vkq8 to 7kGBjmX-zBXc
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-19 21:27:33 +00:00
Pierre-Louis
0830a362d5
Add support for M3 motion ( #129942 )
...
## Description
This adds support for M3 easing and duration tokens.
This PR includes these changes:
* Generation of duration and easing constants, in `Durations` and
`Easing`, respectively (`Curves` is already taken in the `animation`
library)
* Add 3 Dart fixes
Once this is merged, I'll migrate packages/plugins/customers and then
uncomment the deprecation notices for the 3 M2 curves, all of which have
1:1 replacements.
## Related Issues
- Fixes https://github.com/flutter/flutter/issues/116525
## Tests
- Added Dart fix tests
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-07-19 22:07:59 +02:00
engine-flutter-autoroll
b54e83e4fc
Roll Flutter Engine from 2fab8ab5ff7f to 6ea54eee0592 (2 revisions) ( #130929 )
...
2fab8ab5ff...6ea54eee05skia-flutter-autoroll@skia.org Roll Dart SDK from a013e7bf089e to 936824d49aa7 (1 revision) (flutter/engine#43820 )
2023-07-19 skia-flutter-autoroll@skia.org Roll Skia from a352521a3a7c to 8d19d04472e1 (1 revision) (flutter/engine#43818 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-19 20:01:25 +00:00
engine-flutter-autoroll
8d3a5cf1a5
Roll Flutter Engine from 4b274b5c2c3a to 2fab8ab5ff7f (2 revisions) ( #130920 )
...
4b274b5c2c...2fab8ab5ffskia-flutter-autoroll@skia.org Roll Skia from 4728980564b1 to a352521a3a7c (3 revisions) (flutter/engine#43816 )
2023-07-19 bdero@google.com [Impeller] Disable color attachment on clip pipelines for Metal & Vulkan. (flutter/engine#43781 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-19 18:38:56 +00:00
engine-flutter-autoroll
ffa5953320
Roll Flutter Engine from 9645d8e27b59 to 4b274b5c2c3a (3 revisions) ( #130903 )
...
9645d8e27b...4b274b5c2cskia-flutter-autoroll@skia.org Roll Skia from 16475d7aa315 to 4728980564b1 (1 revision) (flutter/engine#43815 )
2023-07-19 jason-simmons@users.noreply.github.com Apply the offset to the child bounds of an ImageFilterLayer with no filter (flutter/engine#43783 )
2023-07-19 skia-flutter-autoroll@skia.org Roll Skia from 1f175b7a2155 to 16475d7aa315 (1 revision) (flutter/engine#43812 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-19 17:18:45 +00:00
Greg Price
f003911967
Fix contradictory advice in "detach" docs; cut redundancy in "attach" ( #130688 )
...
Fixes #115525 .
On [AbstractNode.detach] and its two progeny [RenderNode.detach]
and [Layer.detach], the docs said both to call the inherited method
before detaching children, and to end by doing so. The former
advice is what's enforced by an assertion in the base implementation,
so cut out the other.
The corresponding [attach] methods redundantly said twice to
call the inherited method first, so cut the redundancy.
Leave in place the version more recently added (in #76021 ), because
that PR shows the old version must have been easy to overlook.
2023-07-19 16:36:08 +00:00
engine-flutter-autoroll
ef43463c86
Roll Flutter Engine from 076bd7b81d9c to 9645d8e27b59 (1 revision) ( #130895 )
...
076bd7b81d...9645d8e27bskia-flutter-autoroll@skia.org Roll Skia from e9409b832799 to 1f175b7a2155 (1 revision) (flutter/engine#43811 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-19 15:54:10 +00:00
engine-flutter-autoroll
566198890d
Roll Packages from 3e8b8130cda3 to 209db219ad73 (8 revisions) ( #130894 )
...
3e8b8130cd...209db219adreidbaker@google.com [tooling] mark infra steps as infra steps in yaml files (flutter/packages#4473 )
2023-07-19 engine-flutter-autoroll@skia.org Manual roll Flutter from f842ed916514 to 6f09064e785b (11 revisions) (flutter/packages#4518 )
2023-07-19 stuartmorgan@google.com [ci] Enable new sharding (flutter/packages#4515 )
2023-07-19 stuartmorgan@google.com [flutter_markdown] Change the way tests get screen size (flutter/packages#4514 )
2023-07-18 stuartmorgan@google.com [ci] Roll Flutter to f842ed91 (flutter/packages#4513 )
2023-07-18 stuartmorgan@google.com [image_picker] Update Android example (flutter/packages#4504 )
2023-07-18 43054281+camsim99@users.noreply.github.com [camerax] Fixes relistening to `onStreamedFrameAvailable`'s stream behavior (flutter/packages#4511 )
2023-07-18 43054281+camsim99@users.noreply.github.com [various] Deletes deprecated splash screen meta-data element (flutter/packages#4501 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-19 15:43:16 +00:00
Zachary Anderson
3b0b670d91
Mark Windows_android channels_integration_test_win flaky ( #130893 )
...
For https://github.com/flutter/flutter/issues/130732
2023-07-19 08:39:43 -07:00
engine-flutter-autoroll
305c36f3d2
Roll Flutter Engine from eb2285205f25 to 076bd7b81d9c (2 revisions) ( #130891 )
...
eb2285205f...076bd7b81dskia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from ZABO4Om1vToxhI394... to -SNz0augjLKFVsUWn... (flutter/engine#43810 )
2023-07-19 kjlubick@users.noreply.github.com Update legacy call to SkImage::makeSubset (flutter/engine#43786 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from ZABO4Om1vTox to -SNz0augjLKF
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-19 15:11:04 +00:00
engine-flutter-autoroll
d07e8aece1
Roll Flutter Engine from 09389b16d684 to eb2285205f25 (3 revisions) ( #130879 )
...
09389b16d6...eb2285205fskia-flutter-autoroll@skia.org Roll ANGLE from 255dec886475 to 4dcaad2a894d (1 revision) (flutter/engine#43809 )
2023-07-19 skia-flutter-autoroll@skia.org Roll Skia from c03050eb2b65 to e9409b832799 (1 revision) (flutter/engine#43808 )
2023-07-19 skia-flutter-autoroll@skia.org Roll Dart SDK from 9f5e86b4c108 to a013e7bf089e (1 revision) (flutter/engine#43805 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-19 13:00:23 +00:00
engine-flutter-autoroll
37ed50ac34
Roll Flutter Engine from 0293a7cb7887 to 09389b16d684 (5 revisions) ( #130867 )
...
0293a7cb78...09389b16d6skia-flutter-autoroll@skia.org Roll ANGLE from b32d661389a6 to 255dec886475 (1 revision) (flutter/engine#43804 )
2023-07-19 jason-simmons@users.noreply.github.com Fix the rules for determining whether a blur image filter is valid (flutter/engine#43791 )
2023-07-19 skia-flutter-autoroll@skia.org Roll Skia from 035b12a03918 to c03050eb2b65 (1 revision) (flutter/engine#43802 )
2023-07-19 skia-flutter-autoroll@skia.org Roll Skia from 9062ca6a691c to 035b12a03918 (3 revisions) (flutter/engine#43801 )
2023-07-19 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from SCshjyIlymHWD9W4D... to Iqf3gYJ8Vkq8k8l3O... (flutter/engine#43800 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from SCshjyIlymHW to Iqf3gYJ8Vkq8
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-19 09:54:05 +00:00
Tomasz Gucio
e4e9dde4ed
Move TapAndDragGestureRecognizer code under gestures ( #119508 )
2023-07-19 11:48:01 +02:00
engine-flutter-autoroll
3213588c03
Roll Flutter Engine from 29de67c7d009 to 0293a7cb7887 (1 revision) ( #130858 )
...
29de67c7d0...0293a7cb78skia-flutter-autoroll@skia.org Roll Skia from caf0d191bd07 to 9062ca6a691c (1 revision) (flutter/engine#43799 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-19 07:20:21 +00:00
engine-flutter-autoroll
a417a6993b
Roll Flutter Engine from 39d60be72ffb to 29de67c7d009 (4 revisions) ( #130855 )
...
39d60be72f...29de67c7d0skia-flutter-autoroll@skia.org Roll Dart SDK from c184cac2d22f to 9f5e86b4c108 (1 revision) (flutter/engine#43798 )
2023-07-19 skia-flutter-autoroll@skia.org Roll Skia from d1d2b623799e to caf0d191bd07 (1 revision) (flutter/engine#43797 )
2023-07-19 skia-flutter-autoroll@skia.org Roll ANGLE from 6eea5ff4db82 to b32d661389a6 (1 revision) (flutter/engine#43796 )
2023-07-19 skia-flutter-autoroll@skia.org Roll Skia from 280fb8391187 to d1d2b623799e (1 revision) (flutter/engine#43795 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-19 06:36:01 +00:00
engine-flutter-autoroll
33d174d797
Roll Flutter Engine from b3bfc744bb61 to 39d60be72ffb (1 revision) ( #130847 )
...
b3bfc744bb...39d60be72fskia-flutter-autoroll@skia.org Roll Dart SDK from ec95774043ec to c184cac2d22f (1 revision) (flutter/engine#43794 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-19 02:36:21 +00:00
engine-flutter-autoroll
504c68ae81
Roll Flutter Engine from adf6142f6738 to b3bfc744bb61 (7 revisions) ( #130843 )
...
adf6142f67...b3bfc744bbzanderso@users.noreply.github.com Increase engine v2 orchestrator timeouts (flutter/engine#43788 )
2023-07-18 skia-flutter-autoroll@skia.org Roll Skia from dcc56df202cc to 280fb8391187 (1 revision) (flutter/engine#43793 )
2023-07-18 zanderso@users.noreply.github.com Remove obsolete legacy engine builds from staging (flutter/engine#43790 )
2023-07-18 skia-flutter-autoroll@skia.org Roll ANGLE from 52fe3116ead9 to 6eea5ff4db82 (1 revision) (flutter/engine#43789 )
2023-07-18 bdero@google.com [Impeller] Fix GL_NUM_EXTENSIONS check for desktop GL (flutter/engine#43785 )
2023-07-18 skia-flutter-autoroll@skia.org Roll Skia from 9a0f6d82a6f5 to dcc56df202cc (1 revision) (flutter/engine#43784 )
2023-07-18 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from ixKM7wyMrqmPDaQ11... to ZABO4Om1vToxhI394... (flutter/engine#43782 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from ixKM7wyMrqmP to ZABO4Om1vTox
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-19 01:16:26 +00:00
Bruno Leroux
a4af12f477
Update app_builder_test.dart for M3 ( #130794 )
...
This PR updates unit tests from app_builder_test.dart for M3 migration.
More info in https://github.com/flutter/flutter/issues/127064
In this particular case, I choose to make the tests Material-agnostic by removing the color theming which was not meaningful to what is tested here.
2023-07-18 23:29:31 +00:00
Ian Hickson
d21109220b
Catch errors in loadStructuredData ( #130748 )
...
Fixes https://github.com/flutter/flutter/issues/42390
2023-07-18 23:02:56 +00:00
fzyzcjy
2d753a621e
Fix super tiny space formatting (hope we have auto formatter in the future) ( #127479 )
...
Just fix a space... I do hope we can have the auto formatter enabled in the future!
2023-07-18 23:01:13 +00:00
engine-flutter-autoroll
0084347e78
Roll Flutter Engine from 71bbecee3010 to adf6142f6738 (2 revisions) ( #130831 )
...
71bbecee30...adf6142f67skia-flutter-autoroll@skia.org Roll Skia from 0adae44dd9cd to 9a0f6d82a6f5 (1 revision) (flutter/engine#43780 )
2023-07-18 skia-flutter-autoroll@skia.org Roll Skia from 4e518e65fea0 to 0adae44dd9cd (6 revisions) (flutter/engine#43779 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-18 22:31:05 +00:00
Bruno Leroux
e29f2b98af
Update SnackBar tests for M2/M3 ( #130717 )
...
This PR updates unit tests for `SnackBar` to have M2 and M3 versions.
More info in https://github.com/flutter/flutter/issues/127064
2023-07-18 22:10:17 +00:00
flutter-pub-roller-bot
edcaa335d1
Roll pub packages ( #130821 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2023-07-18 21:55:17 +00:00
Tae Hyung Kim
c6b93b2db7
Relax syntax for gen-l10n ( #130736 )
...
To preserve backward compatibility with the old parser which would
ignore syntax errors, this PR introduces a way to treat the special
characters `{` and `}` in the following way:
1. If we encounter a `{` which searching for a string token and this `{`
is not followed by a valid placeholder, then we treat the `{` as a
string and continue lexing for strings.
2. If we encounter a `}` while not within some expression (i.e.
placeholders, arguments, plurals, or selects), then we treat the `}` as
a string and continue lexing for strings.
This makes it so that
```
"helloWorld": "{ } { placeholder }",
"@@helloWorld": {
"placeholders": {
"placeholder" {}
}
}
```
treats the `{ }` as a string while `{ placeholder } ` is treated as a
placeholder.
Fixes https://github.com/flutter/flutter/issues/122404 .
2023-07-18 13:59:48 -07:00
engine-flutter-autoroll
bb798e2a84
Roll Flutter Engine from 45851af55bd6 to 71bbecee3010 (7 revisions) ( #130820 )
...
45851af55b...71bbecee30mdebbar@google.com [web] sync => isSync , scuba => golden (flutter/engine#43699 )
2023-07-18 skia-flutter-autoroll@skia.org Roll Skia from 219ca2581ab2 to 4e518e65fea0 (2 revisions) (flutter/engine#43777 )
2023-07-18 skia-flutter-autoroll@skia.org Roll ANGLE from 113f847be69f to 52fe3116ead9 (146 revisions) (flutter/engine#43776 )
2023-07-18 skia-flutter-autoroll@skia.org Roll Skia from b7103fe086c1 to 219ca2581ab2 (1 revision) (flutter/engine#43774 )
2023-07-18 chillers@google.com [ci.yaml] Skip windows arm on releases (flutter/engine#43771 )
2023-07-18 gspencergoog@users.noreply.github.com Check FlutterAppDelegate selector support before calling (flutter/engine#43425 )
2023-07-18 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from _CIP-1iUTmGCbCDZ5... to SCshjyIlymHWD9W4D... (flutter/engine#43773 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from _CIP-1iUTmGC to SCshjyIlymHW
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-18 20:45:06 +00:00
flutter-pub-roller-bot
60425b3c5e
Roll pub packages ( #130608 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2023-07-18 19:40:23 +00:00
engine-flutter-autoroll
8fa71cbbc5
Roll Flutter Engine from 831da7e9dc3b to 45851af55bd6 (2 revisions) ( #130814 )
...
831da7e9dc...45851af55bzanderso@users.noreply.github.com Reset Dart VM optimization level to 2 (flutter/engine#43770 )
2023-07-18 jonahwilliams@google.com [Impeller] Avoid inserting additional save layers based on clip configuration. (flutter/engine#43759 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-18 18:52:24 +00:00
Camille Simon
b42879a94e
[Android] Deletes deprecated splash screen meta-data element ( #130744 )
...
Deletes deprecated splash screen meta-data element.
This is no longer needed to present a splash screen in a Flutter application, but will be removed soon. See [go/flutter-splash-screen-migration](http://go/flutter-splash-screen-migration ) for more information.
Part of https://github.com/flutter/flutter/issues/105173 .
2023-07-18 18:38:12 +00:00
Hans Muller
433f93560a
Updated ThemeData.useMaterial3 API doc, default is true ( #130764 )
...
Fixes https://github.com/flutter/flutter/issues/130761
2023-07-18 11:22:02 -07:00
Casey Hillers
ab14a5c356
[labeler] Mark sync-labels as empty ( #130642 )
...
https://github.com/flutter/flutter/issues/128440
Recommendation from https://github.com/actions/labeler/issues/112#issuecomment-1136485391
2023-07-18 18:19:23 +00:00
engine-flutter-autoroll
fc2626a790
Roll Flutter Engine from c27658cc5ade to 831da7e9dc3b (2 revisions) ( #130810 )
...
c27658cc5a...831da7e9dcskia-flutter-autoroll@skia.org Roll Skia from b33cc7da1e23 to b7103fe086c1 (1 revision) (flutter/engine#43769 )
2023-07-18 skia-flutter-autoroll@skia.org Roll Skia from 8d3e00a1f25f to b33cc7da1e23 (1 revision) (flutter/engine#43768 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-18 18:01:54 +00:00
engine-flutter-autoroll
94179a8e3f
Roll Packages from 6889cca8ba78 to 3e8b8130cda3 (9 revisions) ( #130802 )
...
6889cca8ba...3e8b8130cdjkbturek@gmail.com [video_player] Fix iOS crash with multiple players (flutter/packages#4202 )
2023-07-17 stuartmorgan@google.com [pigeon] Enable Android emulator tests in CI (flutter/packages#4484 )
2023-07-17 defuncart@gmail.com [video_player] Add optional web options [Platform interface] (flutter/packages#4433 )
2023-07-17 rexios@rexios.dev [google_maps_flutter_platform_interface] Platform interface changes for #3258 (flutter/packages#4478 )
2023-07-17 yan.outside@gmail.com [video_player] fix: add missing isPlaybackLikelyToKeepUp check. (flutter/packages#3826 )
2023-07-17 43054281+camsim99@users.noreply.github.com [camerax] Add flash configuration for image capture (flutter/packages#3800 )
2023-07-17 stuartmorgan@google.com Remove `equatable` and `xml` allowances (flutter/packages#4489 )
2023-07-17 stuartmorgan@google.com [ci] Switch Linux platform tests to LUCI (flutter/packages#4479 )
2023-07-17 stuartmorgan@google.com [ci] Adjust bot configurations (flutter/packages#4485 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-18 16:42:10 +00:00
Taha Tesser
b460d49199
Update AppBar and AppBarTheme tests for M2/M3 ( #130790 )
...
Updated unit tests for `AppBar` and `AppBarTheme` to have M2 and M3 versions.
More info in https://github.com/flutter/flutter/issues/127064
2023-07-18 16:24:11 +00:00
Bruno Leroux
86385dce68
Update app tests for M3 ( #130792 )
...
This PR updates unit tests from `app_test.dart` for M3 migration.
More info in https://github.com/flutter/flutter/issues/127064
The diff is somewhat misleading because third test in the original code is now the fourth in the updated one, but because they were very similar git diff does not reflect this swap.
And also, first test is M2 only and last one M3 only.
2023-07-18 16:13:48 +00:00
Greg Spencer
8b768de18f
Add lint check to make sure samples are linked and have tests ( #130523 )
...
## Description
This adds a checker that will check all of the API docs examples to make sure that they are linked from at least one source file in the packages.
It also checks to make sure that all of the examples have an associated test. Since there are a large number that don't have tests at the moment, there is also a large exception list that can be burned down (burn down list is in https://github.com/flutter/flutter/issues/130459 ).
Because there are missing links currently, this PR will only pass after https://github.com/flutter/flutter/pull/130521 is merged.
## Related Issues
- https://github.com/flutter/flutter/issues/129956
- https://github.com/flutter/flutter/issues/130459
## Tests
- Added test for the checker.
2023-07-18 15:26:09 +00:00
engine-flutter-autoroll
3b0b8348fd
Roll Flutter Engine from aaec42812a1f to c27658cc5ade (2 revisions) ( #130799 )
...
aaec42812a...c27658cc5askia-flutter-autoroll@skia.org Roll Dart SDK from b83a63e0181a to ec95774043ec (1 revision) (flutter/engine#43767 )
2023-07-18 skia-flutter-autoroll@skia.org Roll Skia from a4df72ba04bb to 8d3e00a1f25f (1 revision) (flutter/engine#43766 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-18 15:22:24 +00:00
yaakovschectman
203ef6f7a3
Extract common functionality of iOS platformviews into superclasses ( #128716 )
...
Move most functionality of `UiKitView` and its supporting classes into
superclasses named `DarwinPlatformView`, etc., and create trivial or
near-trivial subclasses with the same names as the old classes.
I am currently awaiting approval for a macOS workstation that would
allow me to run the iOS/macOS tests and make sure all existing
functionality is preserved by this refactor. I can ensure that tests
will pass, but doing so may need to wait for a while.
Addresses [Add
AppKitView](https://github.com/flutter/flutter/issues/128519 )
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
---------
Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
Co-authored-by: Michael Goderbauer <goderbauer@google.com>
Co-authored-by: Chris Bracken <chris@bracken.jp>
2023-07-18 10:06:52 -04:00
engine-flutter-autoroll
beb245c749
Roll Flutter Engine from 88be39be7b07 to aaec42812a1f (1 revision) ( #130787 )
...
88be39be7b...aaec42812askia-flutter-autoroll@skia.org Roll Skia from 31be5646930b to a4df72ba04bb (1 revision) (flutter/engine#43763 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-18 11:25:32 +00:00
engine-flutter-autoroll
5952edb84b
Roll Flutter Engine from b46a8baf8ed9 to 88be39be7b07 (1 revision) ( #130784 )
...
b46a8baf8e...88be39be7bskia-flutter-autoroll@skia.org Roll Dart SDK from 979375f92109 to b83a63e0181a (1 revision) (flutter/engine#43762 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-18 10:07:25 +00:00
engine-flutter-autoroll
3718aef47d
Roll Flutter Engine from 777fe158f4e7 to b46a8baf8ed9 (1 revision) ( #130782 )
...
777fe158f4...b46a8baf8eflutter/engine#43760 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-18 09:15:19 +00:00
Taha Tesser
fa6754d362
Fix iconTheme in AppBar doesn't apply custom Colors.white in the dark mode for M3 ( #130574 )
...
fixes [[Material3] AppBar does not respect `foregroundColor` or `iconTheme` for leading and actions in some cases](https://github.com/flutter/flutter/issues/130485 )
### Description
- Fix `Colors.white` not applied in dark mode
- Add regression tests
- make `iconStyle` private for consistency
### Before
### After
2023-07-18 08:26:09 +00:00
