Jason Simmons
440ee21267
[Impeller] Do not capture the temporary ImpellerMapping struct pointer when storing release callbacks in libImpeller ( flutter/engine#56411 )
...
Fixes https://github.com/flutter/flutter/issues/158285
2024-11-06 21:13:46 +00:00
zijiehe@
cca1af22b2
Roll ICU from 9408c6fd4a39 to 4239b1559d11 (2 revisions) ( flutter/engine#56407 )
...
Redo #56401 with a manual license change to remove the chromeos/icudtl.dat.hash. The file was removed by https://crrev.com/83a7bd47a345137ac6081c71c2a7158f5403cd30 .
Original change description:
9408c6fd4a..4239b1559ddayeung@chromium.org ](mailto:dayeung@chromium.org) Updated TZ to 2024b
2024-09-05 [andreaorru@chromium.org ](mailto:andreaorru@chromium.org) Remove icudtl.dat.hash
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/icu-sdk-flutter-engine
Please CC [fuchsia-ui-discuss@google.com ](mailto:fuchsia-ui-discuss@google.com),[jsimmons@google.com ](mailto:jsimmons@google.com) on the revert to ensure that a human
is aware of the problem.
To file a bug in ICU: https://github.com/unicode-org/icu
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-11-06 20:57:10 +00:00
Chris Bracken
5a3f245710
iOS,macOS: Add Obj-C cflags to all Obj-C targets ( flutter/engine#56386 )
...
Ensure that all Objective-C code in the codebase is being built with the standard set of Flutter Objective-C compiler flags with ARC enabled.
Also bumps the cflags config up to the top of the first block within each target in which Objective-C sources appear, so that the location is consistent.
Migrates The following targets to ARC, which had been missed in previous passes since they didn't declare the standard Flutter Obj-C[++] cflags:
* `//flutter/fml:fml_unittests`
* `//flutter/impeller/golden_tests:metal_screenshot`
* `//flutter/impeller/playground:playground`
* `//flutter/impeller/backend/metal:metal`
* `//flutter/impeller/backend/metal:metal_unittests`
* `//shell/gpu:gpu_surface_metal_unittests`
* `//flutter/shell/platform/embedder:embedder_unittests`
This patch includes no semantic changes.
Issue: https://github.com/flutter/flutter/issues/137801
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-11-06 20:17:08 +00:00
skia-flutter-autoroll
5662b172be
Roll Skia from afaed8923682 to cf33c4e96e81 (5 revisions) ( flutter/engine#56408 )
...
https://skia.googlesource.com/skia.git/+log/afaed8923682..cf33c4e96e81
2024-11-06 jacksongardner@google.com Take into account the backdrop filter when calculating the bounds of a SaveLayer operation.
2024-11-06 fmalita@google.com [viewer] More path interpolation samples
2024-11-06 vigneshv@google.com SkCrabbyAvif: Remove explicit brand sniffing in IsAvif
2024-11-06 vigneshv@google.com SkCodec: Remove the sysprop guard for SkCrabbyAvifCodec
2024-11-06 robertphillips@google.com [graphite] Rename all things ForceSynchronous to ForPrecompile
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jsimmons@google.com,kjlubick@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-06 19:59:20 +00:00
skia-flutter-autoroll
daf757d436
Manual roll Dart SDK from 1c1d0420539f to d456f613465a (6 revisions) ( flutter/engine#56406 )
...
Manual roll requested by asiva@google.com
https://dart.googlesource.com/sdk.git/+log/1c1d0420539f..d456f613465a
2024-11-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-112.0.dev
2024-11-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-111.0.dev
2024-11-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-110.0.dev
2024-11-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-109.0.dev
2024-11-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-108.0.dev
2024-11-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-107.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC asiva@google.com ,dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-06 19:55:27 +00:00
Chinmay Garde
bcb04a6ea8
[Impeller] Avoid errors due to triangle fans usage on Molten. ( flutter/engine#56321 )
...
Added the test case for https://github.com/flutter/flutter/issues/157885 to the corpus but Jonah fixed it in https://github.com/flutter/engine/pull/56310 .
Fixes https://github.com/flutter/flutter/issues/158024 which is more of an inconvenience on macOS.
2024-11-06 18:36:48 +00:00
skia-flutter-autoroll
239bdb510a
Roll Skia from b4df8dda7ffc to afaed8923682 (14 revisions) ( flutter/engine#56404 )
...
https://skia.googlesource.com/skia.git/+log/b4df8dda7ffc..afaed8923682
2024-11-06 jamesgk@google.com Ignore more tests in Protected configs
2024-11-06 robertphillips@google.com [graphite] Add UMA enum histogram for Pipeline creation races
2024-11-06 fmalita@google.com [viewer] Add some hardcoded vertices for mesh gradient sample
2024-11-06 fmalita@google.com [viewer] Add AE mesh gradient sample
2024-11-06 borenet@google.com [infra] Add 'patch' asset
2024-11-06 jlavrova@google.com Adding few missing #ifdefs
2024-11-06 jamesgk@google.com [graphite] Support providing clip on replay
2024-11-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 1495532f997f to 76855a9baecc (1 revision)
2024-11-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 064137920a75 to 0262f84fa0d7 (6 revisions)
2024-11-06 danieldilan@google.com Proof of concept for general path interpolation
2024-11-06 kjlubick@google.com Temporarily remove golo machines from CQ
2024-11-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 97c315f09386 to e154ea2ed72d (6 revisions)
2024-11-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 84a24a1ea6a6 to 644b91f7e096 (7 revisions)
2024-11-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 08b478b3f3a3 to a8eb33756b22 (6 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jsimmons@google.com,kjlubick@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-06 18:29:19 +00:00
Jonah Williams
b2c59ea5fe
[Impeller] split downsample shader into GLES variant. ( flutter/engine#56376 )
...
This fixes a crash reported on a moto g4 where the on device shader compiler fails to process the ifdef.
2024-11-06 15:56:17 +00:00
Matan Lurey
b60b012f51
Add and document and explicit toARGB32. ( flutter/engine#56329 )
...
Closes https://github.com/flutter/flutter/issues/157128 .
2024-11-06 01:07:20 +00:00
skia-flutter-autoroll
baa41e0e14
Manual roll Dart SDK from 3e840340c412 to 1c1d0420539f (2 revisions) ( flutter/engine#56391 )
...
Manual roll requested by asiva@google.com
https://dart.googlesource.com/sdk.git/+log/3e840340c412..1c1d0420539f
2024-11-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-106.0.dev
2024-11-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-105.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC asiva@google.com ,dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-05 23:48:59 +00:00
Robert Ancell
9df9cb0c8d
Document fields in FlEngine ( flutter/engine#56266 )
...
Update documentation.
2024-11-06 12:34:19 +13:00
Matan Lurey
73c5a2be81
Add missing TOC. ( flutter/engine#56389 )
2024-11-05 22:55:55 +00:00
Jason Simmons
0be0d08156
Increase timeouts for Linux Fuchsia and Linux Web Framework Tests builders ( flutter/engine#56387 )
...
These builders have recently been timing out due to LUCI scheduling delays.
2024-11-05 22:17:20 +00:00
Chris Bracken
1cfe6487a6
iOS: Use standard Obj-C cflags for ios_test_flutter ( flutter/engine#56384 )
...
Previously, we had not enabled standard iOS cflags for `ios_test_flutter`, though ARC had been manually added to the cflags. This meant that the following flags were not enabled:
* -Werror=overriding-method-mismatch
* -Werror=undeclared-selector
Both of these existed in the code within this target:
* undeclared-selector: `insertionPointColor` was a non-public selector on UITextInput prior to iOS 17.
* overriding-method-mismatch: `FakeFlutterUndoManagerDelegate`, which implements the `FlutterUndoManagerDelegate` protocol, declared `initWithUndoManager:activeInputView:` with a different type for `activeInputView`. This was a hack to jam in a test mock object that didn't match the required type for the property. Conveniently we have a class (`FlutterTextInputView`) that implements the required type and protocol (`UIView<UITextInput>`).
Issue: https://github.com/flutter/flutter/issues/137801
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-11-05 21:51:18 +00:00
Robert Ancell
2a567cbef7
Remove unnecessary method for getting engine switches (command line). ( flutter/engine#56265 )
...
This method simply wrapped a common method, which is simpler to use
directly. The test only tested this common method, which already has
tests in common/.
2024-11-06 10:17:13 +13:00
Robert Ancell
a98f1eb4e2
Remove FlScrollingViewDelegate ( flutter/engine#56270 )
...
We can just contact the engine directly and test that by overriding the
engine API.
2024-11-06 10:16:49 +13:00
Chris Bracken
8582bd3b7a
fml: delete scoped_nsobject.h,mm ( flutter/engine#56382 )
...
fml::scoped_nsobject and fml::scoped_nsprotocol classes are no longer
necessary now that the entire codebase has been migrated to ARC.
This also eliminates the fml_arc_unittests target which tests that code.
All references to that target in documentation, run_tests.py have been
removed. This target was used in various `et` build/query unit tests and
has been replaced with the fml_unittests target in those cases.
Issue: https://github.com/flutter/flutter/issues/137801
2024-11-05 12:59:05 -08:00
skia-flutter-autoroll
438bcc7173
Roll Skia from b3be9cb59fe8 to 82175b411c80 (2 revisions) ( flutter/engine#56383 )
...
https://skia.googlesource.com/skia.git/+log/b3be9cb59fe8..82175b411c80
2024-11-05 egdaniel@google.com [Graphite] Fix layout transition for DstCopy in Vulkan.
2024-11-05 jvanverth@google.com Update GPU StrikeCache to track Glyph memory as well.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jsimmons@google.com,kjlubick@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-05 20:58:17 +00:00
Jason Simmons
eae69f89fe
[Impeller] Delete any remaining GL objects during destruction of the ReactorGLES ( flutter/engine#56361 )
...
At shutdown time the ReactorGLES may still be holding handles of GL objects. These objects should be cleaned up when the reactor is deleted.
This leak can be seen by running DlGoldenTest.ShimmerTest, which takes a series of screenshots. Each screenshot creates an AiksContext. Without this change, the textures in the AiksContext's ReactorGLES will be leaked after the AiksContext is destroyed.
2024-11-05 20:56:13 +00:00
Mouad Debbar
d6ce17ba66
[web] Switch all fonts to WOFF2 (non-split) ( flutter/engine#56035 )
...
Google Fonts serves TTF fonts gzipped. By switching to WOFF2 fonts, we get Brotli compression by design.
Google Font's WOFF2 fonts are 30%+ smaller than their gzipped TTF counterparts (including Roboto).
2024-11-05 20:50:50 +00:00
Jonah Williams
2604f3a406
[Impeller] exploit content context options' perfect hash function. ( flutter/engine#56360 )
...
The content context options hash function is pefect - meaning a distinct hash guarantees a distinct value and vice versa. We can replace the hashing entirely with an equality check of the hash function.
Additionally, we can remove the hashmap. As most of these maps have fewer than a dozen entries (often just 2 or 3) and the linear search is much faster.
2024-11-05 18:32:00 +00:00
skia-flutter-autoroll
51f461ff84
Roll Skia from 7989f782dbf4 to b3be9cb59fe8 (6 revisions) ( flutter/engine#56380 )
...
https://skia.googlesource.com/skia.git/+log/7989f782dbf4..b3be9cb59fe8
2024-11-05 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from 46043c56bc31 to 08b478b3f3a3 (9 revisions)
2024-11-05 jvanverth@google.com Add size tracking to GPU StrikeCache.
2024-11-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from f4673df701a0 to 97c315f09386 (8 revisions)
2024-11-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 2c4f822f9e78 to 46043c56bc31 (12 revisions)
2024-11-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 7ce8b268f584 to 84a24a1ea6a6 (6 revisions)
2024-11-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from ae5ea7b95745 to f4673df701a0 (7 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jsimmons@google.com,kjlubick@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-05 18:21:30 +00:00
skia-flutter-autoroll
3b2f59e67d
Roll Dart SDK from b39c729740eb to 3e840340c412 (1 revision) ( flutter/engine#56377 )
...
https://dart.googlesource.com/sdk.git/+log/b39c729740eb..3e840340c412
2024-11-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-104.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-05 18:16:19 +00:00
Jonah Williams
bf0dacbeb3
[Impeller] match Skia's old VMA default block size. ( flutter/engine#56368 )
...
The unspecified default is 256 MiB which is ... big. 4Mb value is the default that Skia used to use, and results in less memory usage at least in local testing.
benchmarks will determine if this has a positive or negative impact on performance.
https://github.com/flutter/flutter/issues/157497
2024-11-05 18:04:58 +00:00
Chris Bracken
97d61766d2
iOS: Refactor ShellTestPlatformViewMetal ( flutter/engine#56370 )
...
Migrates DarwinContextMetal to a plain C struct, eliminating the need for constructor, getters, etc. since it's only used in this translation unit. The fields themselves cannot be inlined as fields on ShellTestPlatformViewMetal because the header in which that class is defined is included in plain C++ (non-Obj-C++) translation units and therefore cannot contain Obj-C types.
This simplifies the code and simultaneously fixes complicated ARC behaviour in which the const "DarwinContextMetal::context()" getter caused retainCount to be incremented on the underlying context_ pointer, but not decremented even if never unassigned. In particular the line
```objc
FML_CHECK([metal_context->context() mainContext]));
```
appeared to cause refcount to be incremented but never decremented.
Regardless of the ARC issue, this significantly simplifies the code.
This also eliminates the last remaining use of fml::scoped_nsobject in Flutter's codebase. That class will be removed in a followup PR.
No test changes since there is no change to semantics.
Issue: https://github.com/flutter/flutter/issues/137801
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-11-05 18:01:37 +00:00
skia-flutter-autoroll
6355eebfaa
Roll Fuchsia Linux SDK from amgHXcqtplha8LuI_... to z1otZzn3yKuGnu1st... ( flutter/engine#56374 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jsimmons@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-05 18:01:34 +00:00
skia-flutter-autoroll
24927c939e
Roll Dart SDK from 695831e9a70b to b39c729740eb (1 revision) ( flutter/engine#56372 )
...
https://dart.googlesource.com/sdk.git/+log/695831e9a70b..b39c729740eb
2024-11-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-103.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-05 10:09:38 +00:00
skia-flutter-autoroll
592b1eb8d3
Roll Dart SDK from 0addd35215d0 to 695831e9a70b (3 revisions) ( flutter/engine#56371 )
...
https://dart.googlesource.com/sdk.git/+log/0addd35215d0..695831e9a70b
2024-11-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-102.0.dev
2024-11-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-101.0.dev
2024-11-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-100.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-05 06:01:05 +00:00
Jonah Williams
fa745a13cf
remove mock vulkan memory test. ( flutter/engine#56367 )
...
This test is flakey despite using the mocked vulkan backend. This likely
indicates that VMA is still performing some real initialization work in
a way that is not consistently passing or failing.
It may not be safe to use VMA with mock vulkan.
2024-11-04 19:39:02 -08:00
David Iglesias
b772962ba4
[web] injectPlatformView into correct flutterView ( flutter/engine#56334 )
...
Makes SceneView inject platform views in the current `flutterView`, instead of the `implicitView`.
This enables platform views in multi-view mode for the Skwasm renderer.
Fixes https://github.com/flutter/flutter/issues/157958
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-11-05 01:25:51 +00:00
Matan Lurey
8bd297a4be
Add and document et cleanup. ( flutter/engine#56327 )
...
Closes https://github.com/flutter/flutter/issues/157945 .
```sh
% et cleanup --dry-run
Checking /Users/matanl/Developer/engine/src/out...
The following directories were accessed later than 2024-10-02:
android_debug
android_debug_arm64
android_debug_unopt
android_debug_unopt_arm64_ide
host_debug_unopt_arm64_ide
ios_debug
ios_debug_sim_unopt_arm64
ios_debug_unopt
ios_debug_unopt_arm64
license_script_output
wasm_release
web_tests
Run without --dry-run to reclaim 2.79gb.
```
```sh
flutter % et cleanup
Checking /Users/matanl/Developer/engine/src/out...
Deleted 12 output directories and reclaimed 2.79gb.
```
2024-11-04 15:19:51 -08:00
Jonah Williams
574bb3b0f4
[Impeller] check if memory type is host coherent, avoid flush. ( flutter/engine#56350 )
...
Fixes https://github.com/flutter/flutter/issues/137454
Host coherent memory does not need to be flushed. Almost all mobile devices will have host coherent memory for us to write to, but we still need check because of swiftshader and/or desktop at some point.
2024-11-04 21:13:37 +00:00
skia-flutter-autoroll
2571cfc398
Roll Dart SDK from f238183cf168 to 0addd35215d0 (1 revision) ( flutter/engine#56357 )
...
https://dart.googlesource.com/sdk.git/+log/f238183cf168..0addd35215d0
2024-11-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-99.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-04 20:11:12 +00:00
gaaclarke
ab12617c32
Made it so angle builds on linux ( flutter/engine#56328 )
...
fixes: https://github.com/flutter/flutter/issues/151353
Before this PR, angle would not build on linux, now it does.
example:
```
./flutter/bin/et build -c host_debug_unopt //flutter/third_party/angle:libGLESv2
```
There isn't a CI step that builds this today to verify it keeps working, I implemented this as part of the work to see if i could get the golden test runner working on linux.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-11-04 19:28:01 +00:00
Jonah Williams
38a225b1ce
[Impeller] combine translate* scale mat mul when computing shader transform. ( flutter/engine#56352 )
...
For each draw we do 4 matrix multiplications, which isn't slow but does show up in CPU profiles at a few % of a frame. We can cut the number of multiplications down to 3 by constructing the translate*scale matrix in one go. The translate * scale matrix construction is much simpler than a full multiplication as we can ignore all of the known zero values.
2024-11-04 19:24:49 +00:00
dependabot[bot]
ad216a299d
Bump actions/checkout from 4.2.1 to 4.2.2 ( flutter/engine#56191 )
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 4.2.1 to 4.2.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/checkout/releases ">actions/checkout's releases</a>.</em></p>
<blockquote>
<h2>v4.2.2</h2>
<h2>What's Changed</h2>
<ul>
<li><code>url-helper.ts</code> now leverages well-known environment variables by <a href="https://github.com/jww3 "><code>@âjww3</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1941 ">actions/checkout#1941</a></li>
<li>Expand unit test coverage for <code>isGhes</code> by <a href="https://github.com/jww3 "><code>@âjww3</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1946 ">actions/checkout#1946</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/checkout/compare/v4.2.1...v4.2.2 ">https://github.com/actions/checkout/compare/v4.2.1...v4.2.2 </a></p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/actions/checkout/blob/main/CHANGELOG.md ">actions/checkout's changelog</a>.</em></p>
<blockquote>
<h1>Changelog</h1>
<h2>v4.2.2</h2>
<ul>
<li><code>url-helper.ts</code> now leverages well-known environment variables by <a href="https://github.com/jww3 "><code>@âjww3</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1941 ">actions/checkout#1941</a></li>
<li>Expand unit test coverage for <code>isGhes</code> by <a href="https://github.com/jww3 "><code>@âjww3</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1946 ">actions/checkout#1946</a></li>
</ul>
<h2>v4.2.1</h2>
<ul>
<li>Check out other refs/* by commit if provided, fall back to ref by <a href="https://github.com/orhantoy "><code>@âorhantoy</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1924 ">actions/checkout#1924</a></li>
</ul>
<h2>v4.2.0</h2>
<ul>
<li>Add Ref and Commit outputs by <a href="https://github.com/lucacome "><code>@âlucacome</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1180 ">actions/checkout#1180</a></li>
<li>Dependency updates by <a href="https://github.com/dependabot "><code>@âdependabot</code></a>- <a href="https://redirect.github.com/actions/checkout/pull/1777 ">actions/checkout#1777</a>, <a href="https://redirect.github.com/actions/checkout/pull/1872 ">actions/checkout#1872</a></li>
</ul>
<h2>v4.1.7</h2>
<ul>
<li>Bump the minor-npm-dependencies group across 1 directory with 4 updates by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1739 ">actions/checkout#1739</a></li>
<li>Bump actions/checkout from 3 to 4 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1697 ">actions/checkout#1697</a></li>
<li>Check out other refs/* by commit by <a href="https://github.com/orhantoy "><code>@âorhantoy</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1774 ">actions/checkout#1774</a></li>
<li>Pin actions/checkout's own workflows to a known, good, stable version. by <a href="https://github.com/jww3 "><code>@âjww3</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1776 ">actions/checkout#1776</a></li>
</ul>
<h2>v4.1.6</h2>
<ul>
<li>Check platform to set archive extension appropriately by <a href="https://github.com/cory-miller "><code>@âcory-miller</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1732 ">actions/checkout#1732</a></li>
</ul>
<h2>v4.1.5</h2>
<ul>
<li>Update NPM dependencies by <a href="https://github.com/cory-miller "><code>@âcory-miller</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1703 ">actions/checkout#1703</a></li>
<li>Bump github/codeql-action from 2 to 3 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1694 ">actions/checkout#1694</a></li>
<li>Bump actions/setup-node from 1 to 4 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1696 ">actions/checkout#1696</a></li>
<li>Bump actions/upload-artifact from 2 to 4 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1695 ">actions/checkout#1695</a></li>
<li>README: Suggest <code>user.email</code> to be <code>41898282+github-actions[bot]@users.noreply.github.com</code> by <a href="https://github.com/cory-miller "><code>@âcory-miller</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1707 ">actions/checkout#1707</a></li>
</ul>
<h2>v4.1.4</h2>
<ul>
<li>Disable <code>extensions.worktreeConfig</code> when disabling <code>sparse-checkout</code> by <a href="https://github.com/jww3 "><code>@âjww3</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1692 ">actions/checkout#1692</a></li>
<li>Add dependabot config by <a href="https://github.com/cory-miller "><code>@âcory-miller</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1688 ">actions/checkout#1688</a></li>
<li>Bump the minor-actions-dependencies group with 2 updates by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1693 ">actions/checkout#1693</a></li>
<li>Bump word-wrap from 1.2.3 to 1.2.5 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1643 ">actions/checkout#1643</a></li>
</ul>
<h2>v4.1.3</h2>
<ul>
<li>Check git version before attempting to disable <code>sparse-checkout</code> by <a href="https://github.com/jww3 "><code>@âjww3</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1656 ">actions/checkout#1656</a></li>
<li>Add SSH user parameter by <a href="https://github.com/cory-miller "><code>@âcory-miller</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1685 ">actions/checkout#1685</a></li>
<li>Update <code>actions/checkout</code> version in <code>update-main-version.yml</code> by <a href="https://github.com/jww3 "><code>@âjww3</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1650 ">actions/checkout#1650</a></li>
</ul>
<h2>v4.1.2</h2>
<ul>
<li>Fix: Disable sparse checkout whenever <code>sparse-checkout</code> option is not present <a href="https://github.com/dscho "><code>@âdscho</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1598 ">actions/checkout#1598</a></li>
</ul>
<h2>v4.1.1</h2>
<ul>
<li>Correct link to GitHub Docs by <a href="https://github.com/peterbe "><code>@âpeterbe</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1511 ">actions/checkout#1511</a></li>
<li>Link to release page from what's new section by <a href="https://github.com/cory-miller "><code>@âcory-miller</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1514 ">actions/checkout#1514</a></li>
</ul>
<h2>v4.1.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1396 ">Add support for partial checkout filters</a></li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="11bd71901bhttps://redirect.github.com/actions/checkout/issues/1953 ">#1953</a>)</li>
<li><a href="e3d2460bbbhttps://redirect.github.com/actions/checkout/issues/1946 ">#1946</a>)</li>
<li><a href="163217dfcdhttps://redirect.github.com/actions/checkout/issues/1941 ">#1941</a>)</li>
<li>See full diff in <a href="eef61447b9...11bd71901bhttps://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/checkout&package-manager=github_actions&previous-version=4.2.1&new-version=4.2.2 )](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2024-11-04 19:22:59 +00:00
Chris Bracken
8f6ef1c909
iOS: Eliminate fml::scoped_nsobject pointer use ( flutter/engine#56295 )
...
Eliminates use of `fml::scoped_nsobject` now that the codebase has been migrated to ARC.
Issue: https://github.com/flutter/flutter/issues/137801
No changes to tests since this patch makes no semantic changes.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-11-04 18:58:05 +00:00
skia-flutter-autoroll
7db7241097
Roll Skia from e2ad60ea8039 to b2bb3af36da3 (1 revision) ( flutter/engine#56355 )
...
https://skia.googlesource.com/skia.git/+log/e2ad60ea8039..b2bb3af36da3
2024-11-04 jie.a.chen@intel.com Extend the lifetime of IntrinsicConstantsManager
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,kjlubick@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-04 18:48:35 +00:00
Zachary Anderson
adbac02b99
Retry mac_unopt one time in presubmit ( flutter/engine#56319 )
...
While we mitigate https://github.com/flutter/flutter/issues/157636 .
2024-11-04 10:47:12 -08:00
Jonah Williams
b1bf47b924
[Impeller] faster descriptor type mapping. ( flutter/engine#56351 )
...
This is a dumb performance optimization. because we only use the DescriptorType enum to represent vk descriptor types, lets just make the enum values match. Then we can static cast instead of switch.
I do see this function showing up in profiles, though a very small slice.
2024-11-04 17:55:19 +00:00
skia-flutter-autoroll
ae88464a44
Roll Skia from 75740b68a282 to e2ad60ea8039 (8 revisions) ( flutter/engine#56354 )
...
https://skia.googlesource.com/skia.git/+log/75740b68a282..e2ad60ea8039
2024-11-04 bungeman@google.com [pdf] Avoid entires in both unicode maps
2024-11-04 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from 980a9b0e0fba to 2c4f822f9e78 (3 revisions)
2024-11-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 3c1e98a3120a to 2f8ad9c1042c (1 revision)
2024-11-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 91cb9c1a7ec7 to ae5ea7b95745 (1 revision)
2024-11-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 2e11bb731c4a to 064137920a75 (6 revisions)
2024-11-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from e0dd04eb7f86 to 980a9b0e0fba (2 revisions)
2024-11-04 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from 78a100c8c999 to e0dd04eb7f86 (6 revisions)
2024-11-04 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from a0239e7d364c to 78a100c8c999 (14 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,kjlubick@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-04 17:29:23 +00:00
yaakovschectman
97152fcaf0
Move detection of cutouts in Android engine to onApplyWindowInsets ( flutter/engine#55992 )
...
Stop including the translation of window insets cutouts to Flutter
cutout DisplayFeatures in the window info listener method, which would
not necessarily receive changes in the correct order/state when they
update, e.g. when the screen orientation changes.
Fixes https://github.com/flutter/flutter/issues/155658
*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2024-11-04 11:45:57 -05:00
skia-flutter-autoroll
0479842fe1
Roll Dart SDK from 69cec5dc51f9 to f238183cf168 (1 revision) ( flutter/engine#56353 )
...
https://dart.googlesource.com/sdk.git/+log/69cec5dc51f9..f238183cf168
2024-11-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-98.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-04 15:48:06 +00:00
skia-flutter-autoroll
c404d4f8b7
Roll Fuchsia Linux SDK from 07KmbdEtnhkg_tUhe... to amgHXcqtplha8LuI_... ( flutter/engine#56348 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-04 15:37:48 +00:00
skia-flutter-autoroll
71fb5456bd
Roll Dart SDK from 61bf0877807e to 69cec5dc51f9 (2 revisions) ( flutter/engine#56335 )
...
https://dart.googlesource.com/sdk.git/+log/61bf0877807e..69cec5dc51f9
2024-11-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-97.0.dev
2024-11-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-96.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-02 06:12:22 +00:00
Tong Mu
f10ac1e27e
Multiple touches of a stylus should be considered from the same device ( flutter/engine#56075 )
...
This PR fixes https://github.com/flutter/flutter/issues/156223 .
**Problem:** The issue above only occurred when using stylus on Web. Multiple touches were treated as different devices: new devices were added and former devices that had the pointer lifted were never removed. This was further caused by the design that Flutter uses JS's `PointerEvent.pointerId` as the device ID, which increases for each touch.
Flutter had to use `PointerEvent.pointerId` because JS doesn't provide a way to distinguish between multiple styluses. This PR fixes this issue by simply supporting only one stylus, since support for multi-stylus can be really hard. How multi-stylus should be supported can be discussed upon such demands in the future, but at least for now, iPad doesn't support multi-stylus and it's not something I can test.
This PR also rewrote some comments that I got confused by while reading the code.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-11-02 05:38:23 +00:00
skia-flutter-autoroll
e24e24fe1e
Roll Skia from 89ac72bb4922 to 6944cd128603 (2 revisions) ( flutter/engine#56331 )
...
https://skia.googlesource.com/skia.git/+log/89ac72bb4922..6944cd128603
2024-11-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from a52547961655 to b54c68a30790 (1 revision)
2024-11-01 borenet@google.com Roll Skia Infra from 65468f93b38c to 2e11bb731c4a (9 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,jamesgk@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-02 03:03:29 +00:00
Juanjo Tugores
b78aaca24c
[web] Transfer focus to view rootElement on blur/remove. ( flutter/engine#55045 )
...
The `safeBlur`/`safeRemove`/`safeRemoveSync` methods in the view manager should become the standard way to "blur" and "remove" elements within the web engine.
Calling these method ensures the blur operation doesn't disrupt the framework's view focus management because these methods transfer the focus from the current element to its containing EngineFlutterView's `rootElement`, so focus never abandons the Flutter view unless the user wants to.
This is a generalization of the former `DefaultTextEditingStrategy.scheduleFocusFlutterView`, which turns out is needed in anything that touches elements that may receive focus in the engine, not just text editing.
## Issue
(Maybe) Part of https://github.com/flutter/flutter/issues/157387
(Opportunistically) Fixes https://github.com/flutter/flutter/issues/46638
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-11-02 00:51:13 +00:00
Matan Lurey
6066418415
Refactor BuildPlan, better document and explain --config. ( flutter/engine#56324 )
...
Closes https://github.com/flutter/flutter/issues/156591 .
Closes https://github.com/flutter/flutter/issues/156355 .
I also moved some functions only used as implementation details :)
2024-11-02 00:10:06 +00:00
skia-flutter-autoroll
944481977b
Roll Fuchsia Linux SDK from MjcuejuzYvYGobbFM... to 07KmbdEtnhkg_tUhe... ( flutter/engine#56322 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-01 23:05:46 +00:00
