DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

[Impeller] match Skia's old VMA default block size. (flutter/engine#56368)

Browse Source 
The unspecified default is 256 MiB which is ... big. 4Mb value is the default that Skia used to use, and results in less memory usage at least in local testing.

benchmarks will determine if this has a positive or negative impact on performance.

https://github.com/flutter/flutter/issues/157497
This commit is contained in:
Jonah Williams 2024-11-05 10:04:58 -08:00 committed by GitHub
parent 97d61766d2
commit bf0dacbeb3
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
engine/src/flutter/impeller/renderer/backend/vulkan/allocator_vk.cc
View File

@ -84,6 +84,7 @@ static PoolVMA CreateBufferPool(VmaAllocator allocator) {
VmaPoolCreateInfo pool_create_info = {};
pool_create_info.memoryTypeIndex = memTypeIndex;
pool_create_info.flags = VMA_POOL_CREATE_IGNORE_BUFFER_IMAGE_GRANULARITY_BIT;
pool_create_info.minBlockCount = 1;
VmaPool pool = {};
result = vk::Result{::vmaCreatePool(allocator, &pool_create_info, &pool)};
@ -144,6 +145,8 @@ AllocatorVK::AllocatorVK(std::weak_ptr<Context> context,
allocator_info.physicalDevice = physical_device;
allocator_info.device = device_holder->GetDevice();
allocator_info.instance = instance;
// 4 MB, matching the default used by Skia Vulkan.
allocator_info.preferredLargeHeapBlockSize = 4 * 1024 * 1024;
allocator_info.pVulkanFunctions = &proc_table;
VmaAllocator allocator = {};