3744 Commits

Author SHA1 Message Date
Adam Barth
421cd7c2fb Merge pull request #1531 from abarth/raw_keyboard_crash
RawKeyboardListener asserts if disposed without keyboard
2016-02-02 20:52:30 -08:00
Adam Barth
12507d1bdd RawKeyboardListener asserts if disposed without keyboard
We need to check whether we're attached to the keyboard before trying to
detach from the keyboard.
2016-02-02 20:02:23 -08:00
Hans Muller
58156e1849 Merge pull request #1540 from HansMuller/new_toolbar
AppBar extensions for Scaffold et al

Add support for the appbar behavior described in the "Flexible space with image" section of https://www.google.com/design/spec/patterns/scrolling-techniques.html#scrolling-techniques-scrolling.

For now, an "AppBar" is a toolbar, a toolbar and a tabbar arranged in a column, or a toolbar and flexible space widget arranged in a stack with the toolbar on top. The AppBar occupies the space behind the status bar, i.e. its origin is at the top of the screen.

The Scaffold listens for scroll notifications from a Scrollable descendant identified by scrollableKey. Scrolling downwards from the top causes the Scaffold to shrink its appBar's height from appBarHeight to 0. Scrolling downwards when the appBar isn't visible causes its toolbar to reappear. Applications can specify the flexibleSpace - essentially the appbar's background - with a WidgetBuilder. The contents of the flexible space can track the appbar's relative height with Scaffold.of(context).appBarAnimation, an animation that's 0.0 when the appbar is fully visible and 1.0 when it has disappeared.

Added FlexibleSpaceBar to simplify building a flexible space widget that animates a title and a background image per the Material Design spec.

To enable the new behavior, specify the following Scaffold properties:

```
return new Scaffold(
  appBarHeight: appBarHeight,
  scrollableKey: scrollableKey,
  appBarBehavior: AppBarBehavior.scroll,
  ...
)
```

AppBarHeight should be greater than kToolBarHeight. Typically it will be much greater.

ScrollableKey identifies the Scrollable that the Scaffold will track.

AppBarBehavior.scroll indicates that the appbar will resize in response to scrolling.

The Scrollable must be a descendant of the Scaffold body and must specify the same scrollableKey as well as a padding value that accounts for the appbar's height. For example:

```
  body: new ScrollableViewport(
    key: scrollableKey,
    child: new Padding(padding: new EdgeDims.only(top: appBarHeight)
    ...
   )
```

Also:
- Added scrollableKey and scrollablePadding to MaterialList. They're applied to the ScrollableList child.
- Fixed the padding support in ScrollableList.
- Added a foregroundAlpha property to ToolBar. It controls the opacity of the icon and text themes' colors.
- Removed the toolbar's "bottom" widget property. Use the flexibleSpace WidgetBuilder instead.
2016-02-02 16:43:33 -08:00
Hans Muller
6bc65e0373 Add support for the appbar behavior described in the "Flexible space with image" section of https://www.google.com/design/spec/patterns/scrolling-techniques.html#scrolling-techniques-scrolling. 2016-02-02 16:32:39 -08:00
Adam Barth
687ff57e24 Merge pull request #1528 from abarth/layer_offset
Viewport fails to clip its AssetImage child
2016-02-02 13:16:06 -08:00
Adam Barth
167fbced06 Viewport fails to clip its AssetImage child
We were getting confused about our layer tree offsets, which caused us
to set an incorrect cull rect for the recording inside a viewport.

This patch does away with layer tree offsets almost entirely. We now use
them only at repaint boundaries, which is where we want the layer tree
to be mutable.

Fixes #1460
2016-02-02 13:04:55 -08:00
Yegor
9bf4016eff Merge pull request #1527 from yjbanov/contributing-update-2
tell people to submit code after LGTM
2016-02-02 12:22:43 -08:00
krisgiesing
aef96b805c Merge pull request #1505 from krisgiesing/image_scaling
Add scale awareness to images
2016-02-02 12:21:14 -08:00
yjbanov
628702392b tell people to submit code after LGTM 2016-02-02 12:20:48 -08:00
Adam Barth
b89d81a998 Merge pull request #1522 from abarth/editing_mojom
Update to new editing.mojom
2016-02-02 12:14:19 -08:00
Adam Barth
6f1d4df3bd Update engine 2016-02-02 12:13:55 -08:00
Kris Giesing
5161d12004 Give scale parameter to ImageCache and NetworkImage 2016-02-02 12:11:04 -08:00
Devon Carew
2981fc404d Merge pull request #1526 from devoncarew/start_paused
add --start-paused,--debug-port flags
2016-02-02 12:05:12 -08:00
Devon Carew
b780c07622 add --start-paused,--debug-port flags 2016-02-02 11:38:56 -08:00
Yegor
6d9f430853 Merge pull request #1525 from yjbanov/contributing-update
add section on submitting code in CONTRIBUTING.md
2016-02-02 11:21:31 -08:00
yjbanov
15e7bdb549 add section on submitting code in CONTRIBUTING.md 2016-02-02 11:17:16 -08:00
Yegor
a4e30ad9b1 Merge pull request #1517 from yjbanov/overflow-box-debugFillDescription-1487
add debugFillDescription to OverflowBox
2016-02-02 10:46:21 -08:00
yjbanov
4c823cdb97 add debugFillDescription to OverflowBox 2016-02-02 09:40:13 -08:00
Adam Barth
fade0dc097 Update to new editing.mojom
Now the keyboard is responsible for maintaining the state of the text
field.
2016-02-02 09:04:27 -08:00
Collin Jackson
3094348ad4 Merge pull request #1483 from collinjackson/engine_safety
In addition to checking for the existence of the engine, ensure that it’s the correct version
2016-02-01 16:10:03 -08:00
Kris Giesing
d4cc315cc4 Update example to use ImageInfo 2016-02-01 14:04:15 -08:00
Kris Giesing
f52a1e0a33 Associate scale with image more strongly in image resources 2016-02-01 13:50:07 -08:00
Devon Carew
5a21ef2411 Merge pull request #1504 from devoncarew/flutter_logs
refactor flutter logs
2016-02-01 13:30:27 -08:00
Kris Giesing
b81f3f8bd2 Style cleanup 2016-02-01 13:22:10 -08:00
Collin Jackson
beaffecb7b fix #1443 ensure engine is the correct version 2016-02-01 13:11:30 -08:00
Ian Hickson
3abb8c4ec9 Merge pull request #1493 from Hixie/semantics
Semantics updates
2016-02-01 13:04:25 -08:00
Hixie
85689f1231 Make the Semantics code be a service.
Port the tests to use the new interface.
2016-02-01 12:57:47 -08:00
Devon Carew
78e05884ed refactor flutter logs 2016-02-01 12:56:46 -08:00
Kris Giesing
bf115ec5b0 Add scale awareness to images 2016-02-01 11:35:14 -08:00
Hixie
e8a21f5d91 Turn MojoShell into an actual binding 2016-02-01 11:30:05 -08:00
Adam Barth
9e784f0cd3 Merge pull request #1500 from abarth/align_docs
Update the Align docs
2016-02-01 09:52:09 -08:00
Adam Barth
fade43ee55 Update the Align docs
They were out-of-date.

Fixes #1391
2016-01-31 23:06:34 -08:00
Devon Carew
a08c201996 Merge pull request #1481 from devoncarew/patch_ios_logs
fix a regex in the ios logs command
2016-01-30 22:55:18 -08:00
Devon Carew
d631ebe597 fix a regex in the ios logs command
fixed sub-process stdout parsing; added todos
2016-01-30 22:48:28 -08:00
Devon Carew
2bc67ed4f9 Merge pull request #1480 from devoncarew/analyze_command
tweak the output for the analyze command
2016-01-30 22:21:39 -08:00
Devon Carew
d6b4759fee tweak the output for the analyze command 2016-01-30 22:06:26 -08:00
Adam Barth
b89935e597 Merge pull request #1496 from abarth/move_caret
Adds the ability to move the caret by tapping
2016-01-30 22:03:22 -08:00
Adam Barth
3609938327 Adds the ability to move the caret by tapping
Now the text input control knows how to move the caret when you tap
inside the string. There's still some rough edges to polish up, but this
patch is the first step.

Fixes #108
2016-01-30 21:57:19 -08:00
Adam Barth
4125f3866f Merge pull request #1498 from abarth/fix_analyzer
Fix analyzer warnings related to SemanticsListener
2016-01-30 21:56:45 -08:00
Adam Barth
f8342c7a84 Fix analyzer warnings related to SemanticsListener
These were introduced by the recent engine roll.
2016-01-30 21:55:59 -08:00
Adam Barth
4bec05ad8b Update engine 2016-01-30 20:59:19 -08:00
Adam Barth
90e0003115 Merge pull request #1471 from abarth/paint_selection
Input should paint selections
2016-01-29 19:43:06 -08:00
Devon Carew
f4b9466951 Merge pull request #1484 from devoncarew/help_text
massage the help text
2016-01-29 16:20:35 -08:00
Ian Hickson
4aafa7dab7 Merge pull request #1488 from Hixie/overflow
Fix copypasta in RenderSizedOverflowBox.
2016-01-29 16:14:42 -08:00
Adam Barth
a5cfbad876 Input should paint selections
This patch teaches the editing system to paint reasonable selections for
single-line text fields, including for bidirectional text.

Requires https://github.com/flutter/engine/pull/2318
2016-01-29 16:07:54 -08:00
Viktor Lidholt
7defbc1cb4 Merge pull request #1486 from vlidholt/master
Adds opacity property to particle systems
2016-01-29 15:18:33 -08:00
Hixie
f2564a41a1 Fix copypasta in RenderSizedOverflowBox. 2016-01-29 15:17:54 -08:00
Viktor Lidholt
592250885f Adds opacity property to particle systems 2016-01-29 14:52:31 -08:00
Adam Barth
1703d065f6 Update engine 2016-01-29 14:51:51 -08:00
Adam Barth
024cc2cab5 Merge pull request #1485 from abarth/align_overflow_box
Add an alignment property to OverflowBox
2016-01-29 14:42:10 -08:00