Ahmed Mohamed Sameh
3ff025970a
Make sure that a CupertinoLinearActivityIndicator doesn't crash in 0x… ( #178566 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the
CupertinoLinearActivityIndicator widget.
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
2025-11-22 01:06:40 +00:00
Ahmed Mohamed Sameh
946edbc5f9
Make sure that a CupertinoTabBar doesn't crash in 0x0 environment ( #178613 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the CupertinoTabBar
widget.
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
2025-11-22 01:05:56 +00:00
Ahmed Mohamed Sameh
c213a54279
Make sure that a CupertinoContextMenu doesn't crash in 0x0 environment ( #178722 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the
CupertinoContextMenu widget.
2025-11-22 01:02:57 +00:00
b-luk
6c48c0f102
Sort entries in TESTOWNERS ( #178939 )
...
Sorting these entries was suggested by the gemini-code-assist bot in
another PR which modified the TESTOWNERS file: #178891 (see comments at
https://github.com/flutter/flutter/pull/178891#discussion_r2548209393
and
https://github.com/flutter/flutter/pull/178891#discussion_r2548209396 )
This is a follow-up PR to perform the sorting. We don't want to do it in
the PR where it was suggested #178891 because sorting the entries is out
of scope of that PR's goal.
2025-11-22 01:01:55 +00:00
LouiseHsu
216e5124a0
[ios] Dynamic Content Resizing ( #177410 )
...
This PR fixes https://github.com/flutter/flutter/issues/169147
This is the iOS implementation of
https://github.com/flutter/flutter/issues/149033
In Add-to-App scenarios, a common desired use case is to have the
embedded FlutterView be able to size itself based on it's content. Up
till now, the size had to be manually specified, which can be tedious
and inaccurate.
This PR adds a new flag, `isAutoResizable`, which enables the ability
for the embedded flutter view to dynamically set it's own size based off
it's content. Note that this feature will *NOT* work if the the embedded
app is wrapped in flexible or unsized widgets, such as Scaffold. The
FlutterView will just not display at all.
To use the new flag, just set it like
```
flutterViewController.autoResizable = true;
```
or in Swift
```
flutterViewController.isAutoResizable = true
```
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
2025-11-22 00:36:29 +00:00
engine-flutter-autoroll
da2642f2f7
Roll Skia from dc88b21ce7d2 to 3018c3053490 (2 revisions) ( #178947 )
...
https://skia.googlesource.com/skia.git/+log/dc88b21ce7d2..3018c3053490
2025-11-21
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-11-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 7e9132019790 to c31ad463724d (2 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
codefu@google.com ,kjlubick@google.com,robertphillips@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-21 22:52:33 +00:00
Kevin Moore
153fd7fc60
Manually roll material_color_utilities ( #170000 )
...
This updates Flutter to the latest release, which includes a bunch of
code cleanup that should improve compiled code size and (hopefully)
runtime performance.
The changes in https://github.com/flutter/flutter/pull/153385 (discussed
in
https://docs.flutter.dev/release/breaking-changes/material-design-3-token-update )
seem to have been incomplete.
This PR effectively catches up with these changes by updating the "math"
behind primary, secondary, tertiary, error colors.
There is a pending PR on the site to update the corresponding docs:
https://github.com/flutter/website/pull/12125
Fixes https://github.com/flutter/flutter/issues/177285
2025-11-21 20:32:29 +00:00
engine-flutter-autoroll
d32214a3dd
Roll Fuchsia Linux SDK from Y-cMdgKy3d6EnibWR... to 4ul9jvZ7jnDGIjtCD... ( #178934 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC codefu@google.com ,zra@google.com on the revert to ensure that
a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-21 19:35:16 +00:00
engine-flutter-autoroll
2938d55fef
Roll Dart SDK from c788b6a7aefd to 5af71c736b0a (1 revision) ( #178932 )
...
https://dart.googlesource.com/sdk.git/+log/c788b6a7aefd..5af71c736b0a
2025-11-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-162.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC codefu@google.com ,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-21 19:21:27 +00:00
engine-flutter-autoroll
6e65e0e09f
Roll Skia from c588bb60d5da to dc88b21ce7d2 (2 revisions) ( #178933 )
...
https://skia.googlesource.com/skia.git/+log/c588bb60d5da..dc88b21ce7d2
2025-11-21 briansalomon@gmail.com Add chinese-scroll Slide to viewer
2025-11-21 denniston.t@gmail.com Ensure SkPathData::getBounds() returns
sorted rects
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
codefu@google.com ,kjlubick@google.com,robertphillips@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-21 19:17:21 +00:00
b-luk
315c213aa1
Update .ci.yaml and TESTOWNERS for arc macrobenchmark tests ( #178891 )
...
The benchmarks were added in #178690 , but that PR didn't update the
.ci.yaml and TESTOWNERS files.
2025-11-21 17:41:23 +00:00
Victoria Ashworth
a7fd1467d6
Use interactive mode with devicectl to redirect stdout ( #178405 )
...
Reverts https://github.com/flutter/flutter/pull/178167 and instead runs
`devicectl` in interactive mode by prefixing command with `script -t 0
/dev/null` to convince `devicectl` it has a terminal attached in order
to redirect stdout.
Fixes b/454953393. Related to
https://github.com/flutter/flutter/issues/178319 .
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-11-21 17:19:20 +00:00
Elijah Okoroh
64c1b7d0d7
Update .ci.yaml in flutter/flutter to use either macOS 15.5 or macOS … ( #178666 )
...
Update .ci.yaml in flutter/flutter to use 15.5 or 15.7.2
*List which issues are fixed by this PR. You must list at least one
issue. An issue is not required if the PR fixes something trivial like a
typo.*
Fixes #176930
*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-11-21 17:11:26 +00:00
engine-flutter-autoroll
c9690d41d2
Roll Skia from d4e9d2873bfd to c588bb60d5da (1 revision) ( #178928 )
...
https://skia.googlesource.com/skia.git/+log/d4e9d2873bfd..c588bb60d5da
2025-11-21 michaelludwig@google.com [graphite] Stage SampleCount enum
with uint assignment
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
codefu@google.com ,kjlubick@google.com,robertphillips@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-21 17:03:39 +00:00
engine-flutter-autoroll
d100ac1d01
Roll Packages from b1e2fb049013 to e67b6be3f579 (7 revisions) ( #178927 )
...
b1e2fb0490...e67b6be3f5danferreiradev@gmail.com [file_selector] Implement
canCreateDirectories on macos and linux (flutter/packages#10443 )
2025-11-21 stuartmorgan@google.com [various] Replace deprecated
Color.value in SVG packages (flutter/packages#10482 )
2025-11-20 10687576+bparrishMines@users.noreply.github.com [pigeon]
Fixes compilation error with unbounded type parameter for
InstanceManager (flutter/packages#10483 )
2025-11-20 stuartmorgan@google.com [webview_flutter] Replace deprecated
Color.value (flutter/packages#10480 )
2025-11-20 stuartmorgan@google.com [google_maps_flutter] Replace
deprecated color APIs in platform interface (flutter/packages#10477 )
2025-11-20 engine-flutter-autoroll@skia.org Roll Flutter (stable) from
b45fa18946ec to f5a8537f90d1 (12 revisions) (flutter/packages#10478 )
2025-11-20 engine-flutter-autoroll@skia.org Roll Flutter from
de4be4f3892d to 9f383e099033 (21 revisions) (flutter/packages#10481 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-21 15:54:56 +00:00
Jason Simmons
d438df35f9
[ Tool ] Use a separate output directory when the native hooks run the build system ( #178840 )
...
FlutterBuildSystem.trackSharedBuildDirectory stores a hash of the most
recently run build configuration in the output directory defined in the
environment.
If the build executed by FlutterHookRunnerNative uses the same output
directory as other builds, then trackSharedBuildDirectory may think that
the hook build's output list replaces the outputs of those previous
builds. trackSharedBuildDirectory will then incorrectly delete files in
the previous output list because they are not part of the hook build's
outputs.
See https://github.com/flutter/flutter/issues/178529
2025-11-21 15:45:53 +00:00
DoLT
8111945eac
Fix Windows Enter key after focus loss ( #178523 )
...
Fix issue: https://github.com/flutter/flutter/issues/169447
Problem: On Windows, pressing Enter after refocusing the app could drop
the first keydown because the embedder still thought the key was
pressed, causing a double-press requirement and HardwareKeyboard
assertions.
Fix: In KeyboardKeyEmbedderHandler, synthesize a key-up whenever Win32
reports a “fresh” down for a key still tracked as pressed, so Flutter
sees a release before the new down. This keeps modifier/lock-key
synchronization intact.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
2025-11-21 14:32:10 +00:00
engine-flutter-autoroll
4c0d007210
Roll Dart SDK from 369795548c09 to c788b6a7aefd (1 revision) ( #178924 )
...
https://dart.googlesource.com/sdk.git/+log/369795548c09..c788b6a7aefd
2025-11-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-161.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC codefu@google.com ,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-21 14:13:45 +00:00
engine-flutter-autoroll
9c6e1e319f
Roll Skia from 51fd48dccfb8 to d4e9d2873bfd (4 revisions) ( #178912 )
...
https://skia.googlesource.com/skia.git/+log/51fd48dccfb8..d4e9d2873bfd
2025-11-21
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-11-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from a0962979c751 to 19e7c0d499ad (6 revisions)
2025-11-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from 4c3f46be5e92 to 8376a0b41a33 (17 revisions)
2025-11-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from f16b1cf2bb95 to d67fdadd6b61 (5 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
codefu@google.com ,kjlubick@google.com,robertphillips@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-21 11:58:41 +00:00
Reid Baker
cd9315350c
Add changelog for 3.38.2 ( #178796 )
2025-11-21 10:58:06 +00:00
engine-flutter-autoroll
9be24916d0
Roll Dart SDK from 003a42bad376 to 369795548c09 (2 revisions) ( #178899 )
...
https://dart.googlesource.com/sdk.git/+log/003a42bad376..369795548c09
2025-11-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-160.0.dev
2025-11-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-159.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC codefu@google.com ,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-21 06:57:11 +00:00
engine-flutter-autoroll
50ffd4c275
Roll Skia from b9eafe0fab0c to 51fd48dccfb8 (1 revision) ( #178897 )
...
https://skia.googlesource.com/skia.git/+log/b9eafe0fab0c..51fd48dccfb8
2025-11-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from b7b8946e9bdf to 7e9132019790 (6 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
codefu@google.com ,kjlubick@google.com,robertphillips@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-21 05:52:08 +00:00
engine-flutter-autoroll
bb1746ddbd
Roll Dart SDK from 0894b46fff76 to 003a42bad376 (1 revision) ( #178889 )
...
https://dart.googlesource.com/sdk.git/+log/0894b46fff76..003a42bad376
2025-11-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-158.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC codefu@google.com ,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-21 01:11:08 +00:00
Ahmed Mohamed Sameh
c5d2104166
Make sure that a TextSelectionToolbarTextButton doesn't crash in 0x0 … ( #178374 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the
TextSelectionToolbarTextButton widget.
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
2025-11-21 00:01:49 +00:00
Ahmed Mohamed Sameh
63ef482845
Make sure that a CupertinoSpellCheckSuggestionsToolbar doesn't crash … ( #177978 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the
CupertinoSpellCheckSuggestionsToolbar widget.
Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
2025-11-21 00:00:42 +00:00
Ahmed Mohamed Sameh
c2e3f39ae8
Make sure that a TabBar doesn't crash in 0x0 environment ( #178201 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the TabBar widget.
---------
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
2025-11-21 00:00:42 +00:00
Ahmed Mohamed Sameh
27d62d07e7
Make sure that a ToggleButtons doesn't crash in 0x0 environment ( #178454 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the ToggleButtons
widget.
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
2025-11-20 23:59:29 +00:00
engine-flutter-autoroll
8be69481dd
Roll Skia from d7b961c5f305 to b9eafe0fab0c (6 revisions) ( #178888 )
...
https://skia.googlesource.com/skia.git/+log/d7b961c5f305..b9eafe0fab0c
2025-11-20 michaelludwig@google.com [graphite] Disallow a value of 0 for
SampleCount
2025-11-20 kjlubick@google.com Minor cleanups to SkJpegCodec
2025-11-20 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll
Dawn from d5803ab29495 to f16b1cf2bb95 (11 revisions)
2025-11-20 robertphillips@google.com Disable
PersistentPipelineStorageTest for some Win11 jobs
2025-11-20 bungeman@google.com [pdf] Dump attribute element ids
2025-11-20 kjlubick@google.com Delete leftover build_overrides for tint
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
codefu@google.com ,kjlubick@google.com,robertphillips@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-20 23:54:21 +00:00
b-luk
59945af629
Add macrobenchmark perf test for drawing arcs ( #178690 )
...
Adding a benchmark so the impact of #178269 can be measured.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-11-20 23:50:37 +00:00
engine-flutter-autoroll
b3298ebef4
Roll Dart SDK from 5b21f8a7d5d3 to 0894b46fff76 (1 revision) ( #178881 )
...
https://dart.googlesource.com/sdk.git/+log/5b21f8a7d5d3..0894b46fff76
2025-11-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-157.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC codefu@google.com ,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-20 20:15:01 +00:00
engine-flutter-autoroll
cf13abbd85
Roll Skia from 6284b4f09e14 to d7b961c5f305 (1 revision) ( #178867 )
...
https://skia.googlesource.com/skia.git/+log/6284b4f09e14..d7b961c5f305
2025-11-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 9512ac41850e to b7b8946e9bdf (2 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
codefu@google.com ,kjlubick@google.com,robertphillips@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-20 16:09:12 +00:00
engine-flutter-autoroll
1254e165dd
Roll Fuchsia Linux SDK from 0z3qxzY6CWb8iVxEf... to Y-cMdgKy3d6EnibWR... ( #178865 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC codefu@google.com ,zra@google.com on the revert to ensure that
a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-20 15:57:34 +00:00
engine-flutter-autoroll
1ee3f59f62
Roll Packages from 8f72e4b9d66e to b1e2fb049013 (6 revisions) ( #178868 )
...
8f72e4b9d6...b1e2fb0490stuartmorgan@google.com [path_provider] Convert iOS/macOS to
FFI package (flutter/packages#9762 )
2025-11-19 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump com.squareup.okhttp3:okhttp from 5.3.0 to 5.3.1 in
/packages/espresso/android (flutter/packages#10446 )
2025-11-19 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump androidx.browser:browser from 1.8.0 to 1.9.0 in
/packages/url_launcher/url_launcher_android/android
(flutter/packages#10115 )
2025-11-19 47866232+chunhtai@users.noreply.github.com [ci] Adds github
action for creating batch release (flutter/packages#10298 )
2025-11-19 stuartmorgan@google.com [camera] Remove deprecated feature
from Windows example (flutter/packages#10380 )
2025-11-19 engine-flutter-autoroll@skia.org Roll Flutter from
cb7b7dfe86c7 to de4be4f3892d (20 revisions) (flutter/packages#10468 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-20 15:51:23 +00:00
engine-flutter-autoroll
9f383e0990
Roll Dart SDK from 331595776540 to 5b21f8a7d5d3 (1 revision) ( #178861 )
...
https://dart.googlesource.com/sdk.git/+log/331595776540..5b21f8a7d5d3
2025-11-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-156.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC codefu@google.com ,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-20 15:22:44 +00:00
engine-flutter-autoroll
483505b825
Roll ICU from f27805b7d7d8 to a86a32e67b8d (1 revision) ( #178859 )
...
f27805b7d7..a86a32e67bftang@chromium.org Fix undefined behavior front() call Cherry
pick undefined behavior fix from ICU PR3752
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/icu-sdk-flutter
Please CC codefu@google.com ,fuchsia-ui-discuss@google.com on the revert
to ensure that a human
is aware of the problem.
To file a bug in ICU: https://github.com/unicode-org/icu
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-20 12:28:27 +00:00
engine-flutter-autoroll
d26244b2b3
Roll Dart SDK from d6f9477a2d9f to 331595776540 (1 revision) ( #178851 )
...
https://dart.googlesource.com/sdk.git/+log/d6f9477a2d9f..331595776540
2025-11-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-155.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC codefu@google.com ,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-20 09:10:26 +00:00
engine-flutter-autoroll
13de9c88a8
Roll Skia from 5bdda9a41db9 to 6284b4f09e14 (3 revisions) ( #178849 )
...
https://skia.googlesource.com/skia.git/+log/5bdda9a41db9..6284b4f09e14
2025-11-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from 7b89c0056fc1 to a0962979c751 (11 revisions)
2025-11-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from f90f8d916021 to 4c3f46be5e92 (8 revisions)
2025-11-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from d7523eb33930 to d5803ab29495 (6 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
codefu@google.com ,kjlubick@google.com,robertphillips@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-20 08:48:42 +00:00
engine-flutter-autoroll
5bc23becc0
Roll Skia from 24c28206d912 to 5bdda9a41db9 (2 revisions) ( #178845 )
...
https://skia.googlesource.com/skia.git/+log/24c28206d912..5bdda9a41db9
2025-11-20 michaelludwig@google.com [graphite] Minor cleanup in prep for
SampleCount migration
2025-11-20
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
codefu@google.com ,kjlubick@google.com,robertphillips@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-20 05:38:32 +00:00
engine-flutter-autoroll
3be0461499
Roll Dart SDK from 7506c64a5117 to d6f9477a2d9f (1 revision) ( #178844 )
...
https://dart.googlesource.com/sdk.git/+log/7506c64a5117..d6f9477a2d9f
2025-11-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-154.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC codefu@google.com ,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-20 04:01:26 +00:00
engine-flutter-autoroll
2256707115
Roll Skia from fd41f3650729 to 24c28206d912 (2 revisions) ( #178841 )
...
https://skia.googlesource.com/skia.git/+log/fd41f3650729..24c28206d912
2025-11-20
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-11-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from c26927eb0c50 to 9512ac41850e (10 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
codefu@google.com ,kjlubick@google.com,robertphillips@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-20 03:39:27 +00:00
Matthew Kosarek
eea45ac3b2
Use WidgetsBinding.instance.platformDispatcher in windowing instead of PlatformDispatcher.instance ( #178799 )
...
This is the recommended way to do this as it allows us to override the
platform dispatcher when that is necessary
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
2025-11-20 03:01:27 +00:00
gaaclarke
d8fc22e25c
[Impeller] Adds support for r32float textures ( #178418 )
...
fixes https://github.com/flutter/flutter/issues/178420
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-11-20 01:28:35 +00:00
engine-flutter-autoroll
f3415ecb66
Roll Skia from a283da7a6b6c to fd41f3650729 (2 revisions) ( #178838 )
...
https://skia.googlesource.com/skia.git/+log/a283da7a6b6c..fd41f3650729
2025-11-19
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-11-19 michaelludwig@google.com Add more Graphite jobs to waterfall
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
codefu@google.com ,kjlubick@google.com,robertphillips@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-20 01:20:33 +00:00
Chinmay Garde
5467431da9
[Impeller] Deny-list Adreno 640 and 650 for Vulkan eligibility. ( #178833 )
...
Fallback to OpenGL ES on these devices. See linked issues for rationale.
Fixes https://github.com/flutter/flutter/issues/178285
Fixes https://github.com/flutter/flutter/issues/178498
2025-11-20 00:24:26 +00:00
engine-flutter-autoroll
264eabd315
Roll Skia from b5dc8c3494ac to a283da7a6b6c (8 revisions) ( #178832 )
...
https://skia.googlesource.com/skia.git/+log/b5dc8c3494ac..a283da7a6b6c
2025-11-19
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-11-19
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-11-19 mike@reedtribe.org fix signed/unsigned warning
2025-11-19 michaelludwig@google.com Reland "[graphite] Use SampleCount
enum for sample count in TextureInfo"
2025-11-19 kjlubick@google.com Fix quoting of windows paths with spaces
2025-11-19 mike@reedtribe.org Adapt remaining callers to be compatible
with std::span
2025-11-19 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll
Dawn from dac92db6ead5 to d7523eb33930 (7 revisions)
2025-11-19 kjlubick@google.com Disable legacy PNG encoding/decoding in
SkPicture
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
codefu@google.com ,kjlubick@google.com,robertphillips@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-19 23:00:11 +00:00
engine-flutter-autoroll
ecca0669e4
Roll Dart SDK from f7e9bd245fd9 to 7506c64a5117 (3 revisions) ( #178828 )
...
https://dart.googlesource.com/sdk.git/+log/f7e9bd245fd9..7506c64a5117
2025-11-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-153.0.dev
2025-11-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-152.0.dev
2025-11-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-151.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC codefu@google.com ,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-19 22:57:55 +00:00
Valentin Vignal
caa84ba097
Allow the RawAutocomplete to display the options even when one is selected ( #177705 )
...
Fixes https://github.com/flutter/flutter/issues/177429
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
2025-11-19 22:26:12 +00:00
Mouad Debbar
ea23b986ae
[web] Skip flaky service worker test ( #178820 )
...
Fixes https://github.com/flutter/flutter/issues/178032
2025-11-19 22:04:57 +00:00
walley892
664da1fe8f
Only call glCheckFrameBufferStatus in the render pass in debug builds ( #178707 )
...
Rendering to an offscreen texture on platforms without implicit MSAA
resolve causes the creation of a framebuffer each frame and a subsequent
call to glCheckFramebufferStatus.
This call can cause a full [GPU round trip]
(https://developer.mozilla.org/en-US/docs/Web/API/WebGL_API/WebGL_best_practices#avoid_blocking_api_calls_in_production ).
This change creates a function in the proc table that only actually
makes the glCheckFramebufferStatus check in debug builds, and changes
the calls in render_pass_gles to use this function instead.
An alternate way of doing this would be to directly wrap the callsites
with `ifdef` checks, but this way was more easily testable and seemed
cleaner.
Also removes a redundant call to CheckFramebufferStatus.
Fixes https://github.com/flutter/flutter/issues/175522
## Pre-launch Checklist
- [ x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ x] I read and followed the [Flutter Style Guide], including
[Features we expect every widget to implement].
- [ x] I signed the [CLA].
- [ x] I listed at least one issue that this PR fixes in the description
above.
- [ x] I updated/added relevant documentation (doc comments with `///`).
- [ x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ x] All existing and new tests are passing.
2025-11-19 21:17:10 +00:00
Kate Lovett
b62b97fd06
Manual pub roll ( #178687 )
...
Fresh crack at https://github.com/flutter/flutter/pull/178558 after
changes in flutter/tests and flutter/packages
Fixes https://github.com/flutter/flutter/issues/178270
Replaces https://github.com/flutter/flutter/pull/178312
Following up on why the script is not generating lock files in
https://github.com/flutter/flutter/issues/178409
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-11-19 20:49:22 +00:00
