Flutter GitHub Bot
3f79e2542d
Marks Linux build_android_host_app_with_module_aar to be unflaky ( #174864 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Linux build_android_host_app_with_module_aar"
}
-->
The issue https://github.com/flutter/flutter/issues/172630 has been
closed, and the test has been passing for [50 consecutive
runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux%20build_android_host_app_with_module_aar%22 ).
This test can be marked as unflaky.
2025-11-25 01:07:26 +00:00
Flutter GitHub Bot
b893e97a60
Marks Linux_mokey complex_layout__start_up to be unflaky ( #174865 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Linux_mokey complex_layout__start_up"
}
-->
The issue https://github.com/flutter/flutter/issues/173691 has been
closed, and the test has been passing for [50 consecutive
runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux_mokey%20complex_layout__start_up%22 ).
This test can be marked as unflaky.
2025-11-25 00:52:08 +00:00
Slava Egorov
aeda2b3bab
Manual Dart SDK roll to 3.11.0-169.0.dev ( #179054 )
...
Includes the following commits:
```
8dcc6bc368f [linter] Test unnecessary ignore logic for unique names.
ea75975e030 [vm,ia32] Avoid clobbering callee-save register in assembler test
60de6c5dad9 Update analysis server diagnostics page to use relative links
a89b2d6e539 [frontend_server_client] Syncing frontend_server_client Package with Webdev Repo
4d669c06ee5 [CFE] Change core to '3' for benchmarker-golem
76dcc632ca7 add a tool for searching for dart and flutter releases containing a specific commit
6230f5bd9df [vm] Skip appending Windows unwinding sections for relocatable objects.
4f1f82f59ee [dds/dap] Fix evaluateNames of global variables
7cd95f5f91e [linter] Introduce a new representation for removed lints.
0d052e39698 [deps] Roll dart-lang/native
2c804fa2513 [vm] Handle the context of implicit instance closures in the debugger.
```
Manual roll to accommodate `package:record_use` move into native
monorepo
2025-11-25 00:41:41 +00:00
Kate Lovett
460d55e659
Bump Dart to 3.9 ( #179041 )
...
Prep for https://github.com/flutter/flutter/issues/178827
This bumps Dart to 3.9.
We are holding off on 3.10 until we can include best practices for dot
shorthands in the style guide, which will follow the lint update in
#178827
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-11-25 00:41:40 +00:00
engine-flutter-autoroll
28e697ba8f
Roll Skia from e298c2f93ebf to d83c30b090f4 (2 revisions) ( #179058 )
...
https://skia.googlesource.com/skia.git/+log/e298c2f93ebf..d83c30b090f4
2025-11-24 mike@reedtribe.org Enable pathdata backend for immutable
paths.
2025-11-24
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC codefu@google.com ,fmalita@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-25 00:10:33 +00:00
gaaclarke
e398158b48
updated licenses_cpp readme ( #178874 )
...
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-11-24 22:14:11 +00:00
engine-flutter-autoroll
bc38b69577
Roll Skia from 43d2020be565 to e298c2f93ebf (5 revisions) ( #179046 )
...
https://skia.googlesource.com/skia.git/+log/43d2020be565..e298c2f93ebf
2025-11-24 bungeman@google.com Include Fontations header for
implementation
2025-11-24
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-11-24 kjlubick@google.com Introduce SkStreamPriv namespace
2025-11-24 kjlubick@google.com Make SkImage and SkImageGenerator return
const SkData from refEncoded
2025-11-24 kjlubick@google.com Add Android API30 build job to the CQ
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC codefu@google.com ,fmalita@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-24 22:10:19 +00:00
Mohellebi abdessalem
5d96125633
Refactor _isLabel method in stepper.dart to use any for better readablity ( #178909 )
...
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-11-24 21:30:24 +00:00
dependabot[bot]
4114d7411e
Bump actions/checkout from 5 to 6 in the all-github-actions group ( #179049 )
...
Bumps the all-github-actions group with 1 update:
[actions/checkout](https://github.com/actions/checkout ).
Updates `actions/checkout` from 5 to 6
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/actions/checkout/releases ">actions/checkout's
releases</a>.</em></p>
<blockquote>
<h2>v6.0.0</h2>
<h2>What's Changed</h2>
<ul>
<li>Update README to include Node.js 24 support details and requirements
by <a href="https://github.com/salmanmkc "><code>@salmanmkc</code></a>
in <a
href="https://redirect.github.com/actions/checkout/pull/2248 ">actions/checkout#2248</a></li>
<li>Persist creds to a separate file by <a
href="https://github.com/ericsciple "><code>@ericsciple</code></a> in <a
href="https://redirect.github.com/actions/checkout/pull/2286 ">actions/checkout#2286</a></li>
<li>v6-beta by <a
href="https://github.com/ericsciple "><code>@ericsciple</code></a> in <a
href="https://redirect.github.com/actions/checkout/pull/2298 ">actions/checkout#2298</a></li>
<li>update readme/changelog for v6 by <a
href="https://github.com/ericsciple "><code>@ericsciple</code></a> in <a
href="https://redirect.github.com/actions/checkout/pull/2311 ">actions/checkout#2311</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/actions/checkout/compare/v5.0.0...v6.0.0 ">https://github.com/actions/checkout/compare/v5.0.0...v6.0.0 </a></p>
<h2>v6-beta</h2>
<h2>What's Changed</h2>
<p>Updated persist-credentials to store the credentials under
<code>$RUNNER_TEMP</code> instead of directly in the local git
config.</p>
<p>This requires a minimum Actions Runner version of <a
href="https://github.com/actions/runner/releases/tag/v2.329.0 ">v2.329.0</a>
to access the persisted credentials for <a
href="https://docs.github.com/en/actions/tutorials/use-containerized-services/create-a-docker-container-action ">Docker
container action</a> scenarios.</p>
<h2>v5.0.1</h2>
<h2>What's Changed</h2>
<ul>
<li>Port v6 cleanup to v5 by <a
href="https://github.com/ericsciple "><code>@ericsciple</code></a> in <a
href="https://redirect.github.com/actions/checkout/pull/2301 ">actions/checkout#2301</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/actions/checkout/compare/v5...v5.0.1 ">https://github.com/actions/checkout/compare/v5...v5.0.1 </a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="1af3b93b68 "><code>1af3b93</code></a>
update readme/changelog for v6 (<a
href="https://redirect.github.com/actions/checkout/issues/2311 ">#2311</a>)</li>
<li><a
href="71cf2267d8 "><code>71cf226</code></a>
v6-beta (<a
href="https://redirect.github.com/actions/checkout/issues/2298 ">#2298</a>)</li>
<li><a
href="069c695914 "><code>069c695</code></a>
Persist creds to a separate file (<a
href="https://redirect.github.com/actions/checkout/issues/2286 ">#2286</a>)</li>
<li><a
href="ff7abcd0c3 "><code>ff7abcd</code></a>
Update README to include Node.js 24 support details and requirements (<a
href="https://redirect.github.com/actions/checkout/issues/2248 ">#2248</a>)</li>
<li>See full diff in <a
href="https://github.com/actions/checkout/compare/v5...v6 ">compare
view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore <dependency name> major version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's major version (unless you unignore this specific
dependency's major version or upgrade to it yourself)
- `@dependabot ignore <dependency name> minor version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's minor version (unless you unignore this specific
dependency's minor version or upgrade to it yourself)
- `@dependabot ignore <dependency name>` will close this group update PR
and stop Dependabot creating any more for the specific dependency
(unless you unignore this specific dependency or upgrade to it yourself)
- `@dependabot unignore <dependency name>` will remove all of the ignore
conditions of the specified dependency
- `@dependabot unignore <dependency name> <ignore condition>` will
remove the ignore condition of the specified dependency and ignore
conditions
</details>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-11-24 21:28:58 +00:00
Flop
35d95023da
Disposes test restoration manager when accessed by bindings ( #176519 )
...
Fixes #169119
## Details
The error caused by drag is due to the reference to
`ServicesBinding.instance.restorationManager` in the
`ScrollableState.saveOffset` method.
018897e3f1/packages/flutter/lib/src/widgets/scrollable.dart (L648-L656)
The TestWidgetsFlutterBinding now only cleans up the
`restorationManager` when `reset` is called. Therefore, we need to find
an appropriate place to clean up the `restorationManager`.
018897e3f1/packages/flutter_test/lib/src/binding.dart (L239-L263)
018897e3f1/packages/flutter_test/lib/src/widget_tester.dart (L188-L193)
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
---------
Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
2025-11-24 21:24:54 +00:00
Ben Konyi
101ace2140
[ Widget Preview ] Always generate scaffold under $TMP ( #179039 )
...
Since `flutter clean` can delete the `.dart_tool/` directory while a
`flutter widget-preview start` command is active, it's possible for the
`widget_preview_scaffold` to be deleted and cause the preview process to
crash.
This change works around this issue by always generating the
`widget_preview_scaffold` project under $TMP on each invocation of the
previewer. This doesn't result in much of a regression in startup times
as we currently aren't launching the previewer using restored state as
this isn't currently possible with the web device targets. Moving the
scaffold under $TMP means Flutter tooling will never accidentally delete
the scaffold while the previewer is running.
Filed https://github.com/flutter/flutter/issues/179036 to track
reverting this behavior when a better solution is found.
Fixes https://github.com/flutter/flutter/issues/175058
2025-11-24 20:48:36 +00:00
engine-flutter-autoroll
f0c196a5be
Roll Packages from e67b6be3f579 to e019cf9fc411 (9 revisions) ( #179035 )
...
e67b6be3f5...e019cf9fc4
2025-11-24 jessiewong401@gmail.com [Android 16] Bump Packages to
Robolectric 4.16 (flutter/packages#10492 )
2025-11-24 engine-flutter-autoroll@skia.org Roll Flutter from
c8cfb2b1a50b to 3f553f6779cb (11 revisions) (flutter/packages#10510 )
2025-11-24 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump the test-dependencies group across 6 directories with
2 updates (flutter/packages#10500 )
2025-11-22 engine-flutter-autoroll@skia.org Roll Flutter from
d438df35f998 to c8cfb2b1a50b (21 revisions) (flutter/packages#10494 )
2025-11-21 stuartmorgan@google.com [webview_flutter] Update Pigeon for
Kotlin 1.8 compat (flutter/packages#10486 )
2025-11-21 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump the gradle-plugin group across 19 directories with 1
update (flutter/packages#10456 )
2025-11-21 danferreiradev@gmail.com [file_selector] Add parameter to
control whether the new folders button is visible in the file dialog
(flutter/packages#9965 )
2025-11-21 engine-flutter-autoroll@skia.org Roll Flutter from
9f383e099033 to d438df35f998 (18 revisions) (flutter/packages#10491 )
2025-11-21 engine-flutter-autoroll@skia.org Roll Flutter (stable) from
f5a8537f90d1 to 19074d12f7ea (2 revisions) (flutter/packages#10489 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-24 19:46:08 +00:00
Reid Baker
59e4d00941
Update CHANGELOG.md for Flutter 3.38.3 ( #178935 )
...
Added release notes for Flutter version 3.38.3.
and better instructions for updating dart version in deps.
2025-11-24 19:38:04 +00:00
Mohellebi abdessalem
6f5a7134a1
Remove unnecessary String.valueOf in SettingsChannel.java ( #178590 )
...
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-11-24 19:30:57 +00:00
Kate Lovett
8fcd610210
Roll pub manually, pick up flutter_lints in examples/api ( #179030 )
...
Part of https://github.com/flutter/flutter/issues/178827
Manual pub roll to add dev dependency on flutter_lints to examples/api
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-11-24 18:39:23 +00:00
engine-flutter-autoroll
621c96963c
Roll Dart SDK from 24cc9a740bd3 to afca43095efa (1 revision) ( #179019 )
...
https://dart.googlesource.com/sdk.git/+log/24cc9a740bd3..afca43095efa
2025-11-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-167.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC codefu@google.com ,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-24 17:07:12 +00:00
Abdelaziz Mahdy
1b936203a9
Pass EXCLUDED_ARCHS from Xcode project to xcodebuild for macOS builds ( #176948 )
...
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->
Passes `EXCLUDED_ARCHS` from Xcode project build settings to the
xcodebuild command, fixing macOS builds when
dependencies don't support all architectures.
### Problem
Release builds for macOS create universal binaries (arm64 + x86_64) by
default. This causes build failures when
using native dependencies that only provide binaries for a single
architecture. While developers can set
`EXCLUDED_ARCHS` in their Xcode project's xcconfig files, Swift Package
Manager dependencies don't respect this
project-level setting.
**Fixes**: https://github.com/flutter/flutter/issues/176605
## Solution
Instead of adding a CLI flag, pass `EXCLUDED_ARCHS` from the Xcode
project's build settings directly to xcodebuild. This ensures Swift
Package Manager dependencies respect architecture exclusions set in the
project configuration.
**How it works:**
When `macos/Runner/Configs/Release.xcconfig` contains:
```xcconfig
EXCLUDED_ARCHS = x86_64
```
The build command now includes `EXCLUDED_ARCHS=x86_64`, creating an
arm64-only binary.
## Usage
**1. Edit your xcconfig file** (e.g.,
`macos/Runner/Configs/Release.xcconfig`):
```xcconfig
#include "../../Flutter/Flutter-Release.xcconfig"
#include "Warnings.xcconfig"
// Exclude x86_64 for dependencies that only support Apple Silicon
EXCLUDED_ARCHS = x86_64
```
**2. Build normally:**
```bash
flutter build macos --release
```
**Without exclusions (default behavior):**
```bash
# Creates universal binary (arm64 + x86_64)
flutter build macos --release
```
## Implementation
- Modified `buildMacOS()` to retrieve `EXCLUDED_ARCHS` from Xcode
project build settings
- Pass `EXCLUDED_ARCHS` to xcodebuild command when set and non-empty
- Removed unused `activeArch` parameter
- Added inline documentation explaining the SPM compatibility fix
## Testing
**Manual verification:**
- ✅ Built ExecuTorch Flutter example with `EXCLUDED_ARCHS = x86_64`:
arm64-only binary (518.6MB)
- ✅ Built without exclusions: universal binary (existing behavior)
- ✅ Verified architecture with `lipo -info`: arm64-only when excluded
**Unit tests:**
- ✅ Added test: "Passes EXCLUDED_ARCHS from Xcode project to xcodebuild
command"
- ✅ Added test: "Does not pass EXCLUDED_ARCHS when not set in Xcode
project"
- ✅ All 25 macOS build tests passing
*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Victoria Ashworth <15619084+vashworth@users.noreply.github.com>
2025-11-24 15:59:21 +00:00
engine-flutter-autoroll
3f553f6779
Roll Skia from 1cbc0e6a7d21 to 43d2020be565 (7 revisions) ( #179010 )
...
https://skia.googlesource.com/skia.git/+log/1cbc0e6a7d21..43d2020be565
2025-11-24 ccameron@chromium.org Add skhdr::Agtm::applyGain and
skhdr::Agtm::makeColorFilter functions
2025-11-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 727d988c641f to 8b5c5c1780de (1 revision)
2025-11-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
jsfiddle-base from e739450ff483 to ef6c6a80c82e
2025-11-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from 8376a0b41a33 to 7e3710ea589f (6 revisions)
2025-11-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
debugger-app-base from 4fab2c75015c to 9c01087f9cc7
2025-11-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from b91c63fc4078 to c3ddae38156b (2 revisions)
2025-11-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
shaders-base from a05e895e8ba2 to 77cefc24c76a
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC codefu@google.com ,fmalita@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-24 15:27:28 +00:00
Matthew Kosarek
337bbfbe04
Potentially fixing the flakiness in win32 windowing tests, but it needs some running ( #178499 )
...
Adding some more logging and retrying mechanisms to the win32 windowing
tests to see if it fixes the flakiness.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
2025-11-24 13:47:20 +00:00
engine-flutter-autoroll
1cee814c96
Roll Skia from ee2cd2c06cf7 to 1cbc0e6a7d21 (1 revision) ( #178995 )
...
https://skia.googlesource.com/skia.git/+log/ee2cd2c06cf7..1cbc0e6a7d21
2025-11-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
skottie-base from 0b6ddddfa5b5 to b106ae90b3af
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC codefu@google.com ,fmalita@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-24 06:52:33 +00:00
engine-flutter-autoroll
66c68b66d9
Roll Fuchsia Linux SDK from lJTlAwQY4MnuRuORC... to pOO9Jl9HTLsEmks6y... ( #178994 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC codefu@google.com ,zra@google.com on the revert to ensure that
a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-24 00:54:34 +00:00
engine-flutter-autoroll
d631703607
Roll Dart SDK from a1422c6f8aa1 to 24cc9a740bd3 (1 revision) ( #178992 )
...
https://dart.googlesource.com/sdk.git/+log/a1422c6f8aa1..24cc9a740bd3
2025-11-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-166.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC codefu@google.com ,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-23 22:13:32 +00:00
engine-flutter-autoroll
8824689087
Roll Skia from 6592e75d6f7e to ee2cd2c06cf7 (1 revision) ( #178990 )
...
https://skia.googlesource.com/skia.git/+log/6592e75d6f7e..ee2cd2c06cf7
2025-11-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SKP
CIPD package from 540 to 541
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC codefu@google.com ,fmalita@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-23 18:16:30 +00:00
engine-flutter-autoroll
e24d26eb5f
Roll Skia from fb6c00107a51 to 6592e75d6f7e (5 revisions) ( #178985 )
...
https://skia.googlesource.com/skia.git/+log/fb6c00107a51..6592e75d6f7e
2025-11-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 2914381d2a93 to 727d988c641f (1 revision)
2025-11-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from db2dc3621bff to 2914381d2a93 (1 revision)
2025-11-22 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll
Dawn from 46f0e08024d2 to b91c63fc4078 (8 revisions)
2025-11-22 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll
ANGLE from 19e7c0d499ad to 99f62cec302e (10 revisions)
2025-11-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from c31ad463724d to db2dc3621bff (7 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC codefu@google.com ,fmalita@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-23 12:16:28 +00:00
engine-flutter-autoroll
a493527464
Roll Fuchsia Linux SDK from 4ul9jvZ7jnDGIjtCD... to lJTlAwQY4MnuRuORC... ( #178971 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC codefu@google.com ,zra@google.com on the revert to ensure that
a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-22 23:12:27 +00:00
engine-flutter-autoroll
58d34d5f8c
Roll Dart SDK from c44cf2015e3d to a1422c6f8aa1 (2 revisions) ( #178968 )
...
https://dart.googlesource.com/sdk.git/+log/c44cf2015e3d..a1422c6f8aa1
2025-11-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-165.0.dev
2025-11-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-164.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC codefu@google.com ,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-22 21:59:22 +00:00
engine-flutter-autoroll
d094bb7e7e
Roll Skia from 3018c3053490 to fb6c00107a51 (4 revisions) ( #178952 )
...
https://skia.googlesource.com/skia.git/+log/3018c3053490..fb6c00107a51
2025-11-21
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-11-21 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll
Dawn from d67fdadd6b61 to 46f0e08024d2 (10 revisions)
2025-11-21 denniston.t@gmail.com Add missing #include
2025-11-21
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
codefu@google.com ,kjlubick@google.com,robertphillips@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-22 16:41:05 +00:00
engine-flutter-autoroll
f1e23690c4
Roll Dart SDK from 5af71c736b0a to c44cf2015e3d (1 revision) ( #178953 )
...
https://dart.googlesource.com/sdk.git/+log/5af71c736b0a..c44cf2015e3d
2025-11-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-163.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC codefu@google.com ,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-22 16:37:26 +00:00
Jim Graham
c8cfb2b1a5
Revert "[ios] Dynamic Content Resizing" ( #178958 )
...
Reverts flutter/flutter#177410
The change is causing the task `wide_gamut_ios` to hang every time.
Local testing shows that reverting this commit fixes the problem.
2025-11-22 15:42:27 +00:00
Ahmed Mohamed Sameh
12b5c1cfdf
Make sure that a SearchAnchor doesn't crash in 0x0 environment ( #177749 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the SearchAnchor
widget.
---------
Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
2025-11-22 01:12:08 +00:00
Ahmed Mohamed Sameh
f64ddb8cb8
Make sure that a Stepper doesn't crash in 0x0 environment ( #178068 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the Stepper widget.
---------
Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
2025-11-22 01:10:00 +00:00
Mohellebi abdessalem
554dfee06f
Remove deprecated activeColor in switch.0.dart example ( #178293 )
...
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-11-22 01:08:25 +00:00
Ahmed Mohamed Sameh
7698266eb1
Make sure that a UserAccountsDrawerHeader doesn't crash in 0x0 enviro… ( #178516 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the
UserAccountsDrawerHeader widget.
Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
2025-11-22 01:07:39 +00:00
Ahmed Mohamed Sameh
f5e342ecb2
Make sure that a TimePickerDialog doesn't crash in 0x0 environment ( #178451 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the TimePickerDialog
widget.
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
2025-11-22 01:07:38 +00:00
Ahmed Mohamed Sameh
3ff025970a
Make sure that a CupertinoLinearActivityIndicator doesn't crash in 0x… ( #178566 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the
CupertinoLinearActivityIndicator widget.
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
2025-11-22 01:06:40 +00:00
Ahmed Mohamed Sameh
946edbc5f9
Make sure that a CupertinoTabBar doesn't crash in 0x0 environment ( #178613 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the CupertinoTabBar
widget.
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
2025-11-22 01:05:56 +00:00
Ahmed Mohamed Sameh
c213a54279
Make sure that a CupertinoContextMenu doesn't crash in 0x0 environment ( #178722 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the
CupertinoContextMenu widget.
2025-11-22 01:02:57 +00:00
b-luk
6c48c0f102
Sort entries in TESTOWNERS ( #178939 )
...
Sorting these entries was suggested by the gemini-code-assist bot in
another PR which modified the TESTOWNERS file: #178891 (see comments at
https://github.com/flutter/flutter/pull/178891#discussion_r2548209393
and
https://github.com/flutter/flutter/pull/178891#discussion_r2548209396 )
This is a follow-up PR to perform the sorting. We don't want to do it in
the PR where it was suggested #178891 because sorting the entries is out
of scope of that PR's goal.
2025-11-22 01:01:55 +00:00
LouiseHsu
216e5124a0
[ios] Dynamic Content Resizing ( #177410 )
...
This PR fixes https://github.com/flutter/flutter/issues/169147
This is the iOS implementation of
https://github.com/flutter/flutter/issues/149033
In Add-to-App scenarios, a common desired use case is to have the
embedded FlutterView be able to size itself based on it's content. Up
till now, the size had to be manually specified, which can be tedious
and inaccurate.
This PR adds a new flag, `isAutoResizable`, which enables the ability
for the embedded flutter view to dynamically set it's own size based off
it's content. Note that this feature will *NOT* work if the the embedded
app is wrapped in flexible or unsized widgets, such as Scaffold. The
FlutterView will just not display at all.
To use the new flag, just set it like
```
flutterViewController.autoResizable = true;
```
or in Swift
```
flutterViewController.isAutoResizable = true
```
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
2025-11-22 00:36:29 +00:00
engine-flutter-autoroll
da2642f2f7
Roll Skia from dc88b21ce7d2 to 3018c3053490 (2 revisions) ( #178947 )
...
https://skia.googlesource.com/skia.git/+log/dc88b21ce7d2..3018c3053490
2025-11-21
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-11-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 7e9132019790 to c31ad463724d (2 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
codefu@google.com ,kjlubick@google.com,robertphillips@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-21 22:52:33 +00:00
Kevin Moore
153fd7fc60
Manually roll material_color_utilities ( #170000 )
...
This updates Flutter to the latest release, which includes a bunch of
code cleanup that should improve compiled code size and (hopefully)
runtime performance.
The changes in https://github.com/flutter/flutter/pull/153385 (discussed
in
https://docs.flutter.dev/release/breaking-changes/material-design-3-token-update )
seem to have been incomplete.
This PR effectively catches up with these changes by updating the "math"
behind primary, secondary, tertiary, error colors.
There is a pending PR on the site to update the corresponding docs:
https://github.com/flutter/website/pull/12125
Fixes https://github.com/flutter/flutter/issues/177285
2025-11-21 20:32:29 +00:00
engine-flutter-autoroll
d32214a3dd
Roll Fuchsia Linux SDK from Y-cMdgKy3d6EnibWR... to 4ul9jvZ7jnDGIjtCD... ( #178934 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC codefu@google.com ,zra@google.com on the revert to ensure that
a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-21 19:35:16 +00:00
engine-flutter-autoroll
2938d55fef
Roll Dart SDK from c788b6a7aefd to 5af71c736b0a (1 revision) ( #178932 )
...
https://dart.googlesource.com/sdk.git/+log/c788b6a7aefd..5af71c736b0a
2025-11-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-162.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC codefu@google.com ,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-21 19:21:27 +00:00
engine-flutter-autoroll
6e65e0e09f
Roll Skia from c588bb60d5da to dc88b21ce7d2 (2 revisions) ( #178933 )
...
https://skia.googlesource.com/skia.git/+log/c588bb60d5da..dc88b21ce7d2
2025-11-21 briansalomon@gmail.com Add chinese-scroll Slide to viewer
2025-11-21 denniston.t@gmail.com Ensure SkPathData::getBounds() returns
sorted rects
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
codefu@google.com ,kjlubick@google.com,robertphillips@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-21 19:17:21 +00:00
b-luk
315c213aa1
Update .ci.yaml and TESTOWNERS for arc macrobenchmark tests ( #178891 )
...
The benchmarks were added in #178690 , but that PR didn't update the
.ci.yaml and TESTOWNERS files.
2025-11-21 17:41:23 +00:00
Victoria Ashworth
a7fd1467d6
Use interactive mode with devicectl to redirect stdout ( #178405 )
...
Reverts https://github.com/flutter/flutter/pull/178167 and instead runs
`devicectl` in interactive mode by prefixing command with `script -t 0
/dev/null` to convince `devicectl` it has a terminal attached in order
to redirect stdout.
Fixes b/454953393. Related to
https://github.com/flutter/flutter/issues/178319 .
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-11-21 17:19:20 +00:00
Elijah Okoroh
64c1b7d0d7
Update .ci.yaml in flutter/flutter to use either macOS 15.5 or macOS … ( #178666 )
...
Update .ci.yaml in flutter/flutter to use 15.5 or 15.7.2
*List which issues are fixed by this PR. You must list at least one
issue. An issue is not required if the PR fixes something trivial like a
typo.*
Fixes #176930
*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-11-21 17:11:26 +00:00
engine-flutter-autoroll
c9690d41d2
Roll Skia from d4e9d2873bfd to c588bb60d5da (1 revision) ( #178928 )
...
https://skia.googlesource.com/skia.git/+log/d4e9d2873bfd..c588bb60d5da
2025-11-21 michaelludwig@google.com [graphite] Stage SampleCount enum
with uint assignment
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
codefu@google.com ,kjlubick@google.com,robertphillips@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-21 17:03:39 +00:00
engine-flutter-autoroll
d100ac1d01
Roll Packages from b1e2fb049013 to e67b6be3f579 (7 revisions) ( #178927 )
...
b1e2fb0490...e67b6be3f5
2025-11-21 danferreiradev@gmail.com [file_selector] Implement
canCreateDirectories on macos and linux (flutter/packages#10443 )
2025-11-21 stuartmorgan@google.com [various] Replace deprecated
Color.value in SVG packages (flutter/packages#10482 )
2025-11-20 10687576+bparrishMines@users.noreply.github.com [pigeon]
Fixes compilation error with unbounded type parameter for
InstanceManager (flutter/packages#10483 )
2025-11-20 stuartmorgan@google.com [webview_flutter] Replace deprecated
Color.value (flutter/packages#10480 )
2025-11-20 stuartmorgan@google.com [google_maps_flutter] Replace
deprecated color APIs in platform interface (flutter/packages#10477 )
2025-11-20 engine-flutter-autoroll@skia.org Roll Flutter (stable) from
b45fa18946ec to f5a8537f90d1 (12 revisions) (flutter/packages#10478 )
2025-11-20 engine-flutter-autoroll@skia.org Roll Flutter from
de4be4f3892d to 9f383e099033 (21 revisions) (flutter/packages#10481 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-21 15:54:56 +00:00
Jason Simmons
d438df35f9
[ Tool ] Use a separate output directory when the native hooks run the build system ( #178840 )
...
FlutterBuildSystem.trackSharedBuildDirectory stores a hash of the most
recently run build configuration in the output directory defined in the
environment.
If the build executed by FlutterHookRunnerNative uses the same output
directory as other builds, then trackSharedBuildDirectory may think that
the hook build's output list replaces the outputs of those previous
builds. trackSharedBuildDirectory will then incorrectly delete files in
the previous output list because they are not part of the hook build's
outputs.
See https://github.com/flutter/flutter/issues/178529
2025-11-21 15:45:53 +00:00